Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Side by Side Diff: Source/WebCore/ChangeLog

Issue 6691008: Merge 80842 - 2011-03-11 Anton Muhin <antonm@chromium.org>... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/648/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/WebCore/bindings/v8/V8GCController.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 2011-03-11 Anton Muhin <antonm@chromium.org>
2
3 Reviewed by Adam Barth.
4
5 [v8] Change the way group id for CSS objects is calculated
6 https://bugs.webkit.org/show_bug.cgi?id=56117
7
8 Do not treat CSSStyleDeclarations under not CSSRule as belonging to the same object group
9 as they should not be reachable in JavaScript.
10
11 Covered by existing layout tests. Fact of absence of retention is not t rivial to prove.
12
13 * bindings/v8/V8GCController.cpp:
14 (WebCore::calculateGroupId):
15 (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):
16
17 2011-03-11 Alexander Pavlov <apavlov@chromium.org>
18
19 Reviewed by Yury Semikhatsky.
20
21 Web Inspector: hover over elements in Elements panel does not highlight nodes
22 https://bugs.webkit.org/show_bug.cgi?id=56121
23
24 In DOM trees with a comment and/or doctype preceding the HTML tag, the t ree container right boundary
25 is 16px apart from the OL right boundary, and we miss the relevant LI by 4px. The fix is to compensate
26 for these 16px when computing the test point coordinates.
27
28 * inspector/front-end/ElementsTreeOutline.js:
29 (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
30
31 2011-03-11 Yury Semikhatsky <yurys@chromium.org>
32
33 Unreviewed. Roll out r80837.
34
35 * CMakeLists.txt:
36 * GNUmakefile.am:
37 * WebCore.gypi:
38 * WebCore.pro:
39 * WebCore.vcproj/WebCore.vcproj:
40 * WebCore.xcodeproj/project.pbxproj:
41 * bindings/js/JSInjectedScriptHostCustom.cpp:
42 (WebCore::InjectedScriptHost::createInjectedScript):
43 (WebCore::InjectedScriptHost::discardInjectedScript):
44 (WebCore::InjectedScriptHost::injectedScriptFor):
45 (WebCore::InjectedScriptHost::canAccessInspectedWindow):
46 * bindings/js/JSInjectedScriptManager.cpp: Removed.
47 * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
48 (WebCore::WeakReferenceCallback):
49 (WebCore::createInjectedScriptHostV8Wrapper):
50 (WebCore::InjectedScriptHost::createInjectedScript):
51 (WebCore::InjectedScriptHost::discardInjectedScript):
52 (WebCore::InjectedScriptHost::injectedScriptFor):
53 (WebCore::InjectedScriptHost::canAccessInspectedWindow):
54 * bindings/v8/custom/V8InjectedScriptManager.cpp: Removed.
55 * inspector/ConsoleMessage.cpp:
56 (WebCore::ConsoleMessage::addToFrontend):
57 * inspector/ConsoleMessage.h:
58 * inspector/InjectedScript.cpp:
59 (WebCore::InjectedScript::canAccessInspectedWindow):
60 * inspector/InjectedScript.h:
61 * inspector/InjectedScriptHost.cpp:
62 (WebCore::InjectedScriptHost::InjectedScriptHost):
63 (WebCore::InjectedScriptHost::~InjectedScriptHost):
64 (WebCore::InjectedScriptHost::inspectImpl):
65 (WebCore::InjectedScriptHost::clearConsoleMessages):
66 (WebCore::InjectedScriptHost::databaseIdImpl):
67 (WebCore::InjectedScriptHost::storageIdImpl):
68 (WebCore::InjectedScriptHost::injectedScriptForId):
69 (WebCore::InjectedScriptHost::injectedScriptForObjectId):
70 (WebCore::InjectedScriptHost::injectedScriptForMainFrame):
71 (WebCore::InjectedScriptHost::discardInjectedScripts):
72 (WebCore::InjectedScriptHost::releaseObjectGroup):
73 (WebCore::InjectedScriptHost::frontend):
74 (WebCore::InjectedScriptHost::injectedScriptSource):
75 (WebCore::InjectedScriptHost::injectScript):
76 * inspector/InjectedScriptHost.h:
77 (WebCore::InjectedScriptHost::create):
78 (WebCore::InjectedScriptHost::inspectorAgent):
79 (WebCore::InjectedScriptHost::disconnectController):
80 * inspector/InjectedScriptManager.cpp: Removed.
81 * inspector/InjectedScriptManager.h: Removed.
82 * inspector/Inspector.idl:
83 * inspector/InspectorAgent.cpp:
84 (WebCore::InspectorAgent::InspectorAgent):
85 (WebCore::InspectorAgent::inspectedPageDestroyed):
86 (WebCore::InspectorAgent::focusNode):
87 (WebCore::InspectorAgent::didClearWindowObjectInWorld):
88 (WebCore::InspectorAgent::createFrontendLifetimeAgents):
89 (WebCore::InspectorAgent::didCommitLoad):
90 (WebCore::InspectorAgent::domContentLoadedEventFired):
91 * inspector/InspectorAgent.h:
92 (WebCore::InspectorAgent::injectedScriptHost):
93 * inspector/InspectorBrowserDebuggerAgent.cpp:
94 * inspector/InspectorConsoleAgent.cpp:
95 (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
96 (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
97 (WebCore::InspectorConsoleAgent::clearConsoleMessages):
98 (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
99 (WebCore::InspectorConsoleAgent::addConsoleMessage):
100 * inspector/InspectorConsoleAgent.h:
101 * inspector/InspectorController.cpp:
102 (WebCore::InspectorController::InspectorController):
103 (WebCore::InspectorController::connectFrontend):
104 (WebCore::InspectorController::disconnectFrontend):
105 * inspector/InspectorController.h:
106 * inspector/InspectorDOMAgent.cpp:
107 (WebCore::InspectorDOMAgent::InspectorDOMAgent):
108 (WebCore::InspectorDOMAgent::discardBindings):
109 (WebCore::InspectorDOMAgent::addInspectedNode):
110 (WebCore::InspectorDOMAgent::pushNodeToFrontend):
111 (WebCore::InspectorDOMAgent::resolveNode):
112 * inspector/InspectorDOMAgent.h:
113 (WebCore::InspectorDOMAgent::create):
114 * inspector/InspectorDebuggerAgent.cpp:
115 (WebCore::InspectorDebuggerAgent::create):
116 (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
117 (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
118 (WebCore::InspectorDebuggerAgent::currentCallFrames):
119 * inspector/InspectorDebuggerAgent.h:
120 * inspector/InspectorRuntimeAgent.cpp:
121 (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
122 (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
123 (WebCore::InspectorRuntimeAgent::evaluate):
124 (WebCore::InspectorRuntimeAgent::evaluateOn):
125 (WebCore::InspectorRuntimeAgent::getProperties):
126 (WebCore::InspectorRuntimeAgent::setPropertyValue):
127 (WebCore::InspectorRuntimeAgent::releaseObject):
128 (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
129 * inspector/InspectorRuntimeAgent.h:
130 (WebCore::InspectorRuntimeAgent::create):
131 * inspector/front-end/ElementsPanel.js:
132 (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
133 (WebInspector.ElementsPanel):
134
135 2011-03-11 Yury Semikhatsky <yurys@chromium.org>
136
137 Reviewed by Pavel Feldman.
138
139 Web Inspector: split InjectedScriptHost into InjectedScriptManager and I njectedScriptHost
140 https://bugs.webkit.org/show_bug.cgi?id=56173
141
142 Moved all injected script managing logic into InjectedScriptManager whic h is owned by InspectorController.
143
144 * CMakeLists.txt:
145 * GNUmakefile.am:
146 * WebCore.gypi:
147 * WebCore.pro:
148 * WebCore.vcproj/WebCore.vcproj:
149 * WebCore.xcodeproj/project.pbxproj:
150 * bindings/js/JSInjectedScriptHostCustom.cpp:
151 * bindings/js/JSInjectedScriptManager.cpp: Added.
152 (WebCore::InjectedScriptManager::createInjectedScript):
153 (WebCore::InjectedScriptManager::discardInjectedScript):
154 (WebCore::InjectedScriptManager::injectedScriptFor):
155 (WebCore::InjectedScriptManager::canAccessInspectedWindow):
156 * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
157 * bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/Web Core/bindings/v8/custom/V8InjectedScriptHostCustom.cpp.
158 (WebCore::WeakReferenceCallback):
159 (WebCore::createInjectedScriptHostV8Wrapper):
160 (WebCore::InjectedScriptManager::createInjectedScript):
161 (WebCore::InjectedScriptManager::discardInjectedScript):
162 (WebCore::InjectedScriptManager::injectedScriptFor):
163 (WebCore::InjectedScriptManager::canAccessInspectedWindow):
164 * inspector/ConsoleMessage.cpp:
165 (WebCore::ConsoleMessage::addToFrontend):
166 * inspector/ConsoleMessage.h:
167 * inspector/InjectedScript.cpp:
168 (WebCore::InjectedScript::canAccessInspectedWindow):
169 * inspector/InjectedScript.h:
170 * inspector/InjectedScriptHost.cpp:
171 (WebCore::InjectedScriptHost::create):
172 (WebCore::InjectedScriptHost::InjectedScriptHost):
173 (WebCore::InjectedScriptHost::~InjectedScriptHost):
174 (WebCore::InjectedScriptHost::disconnect):
175 (WebCore::InjectedScriptHost::inspectImpl):
176 (WebCore::InjectedScriptHost::clearConsoleMessages):
177 (WebCore::InjectedScriptHost::databaseIdImpl):
178 (WebCore::InjectedScriptHost::storageIdImpl):
179 * inspector/InjectedScriptHost.h:
180 (WebCore::InjectedScriptHost::init):
181 (WebCore::InjectedScriptHost::setFrontend):
182 (WebCore::InjectedScriptHost::clearFrontend):
183 * inspector/InjectedScriptManager.cpp: Added.
184 (WebCore::InjectedScriptManager::create):
185 (WebCore::InjectedScriptManager::InjectedScriptManager):
186 (WebCore::InjectedScriptManager::~InjectedScriptManager):
187 (WebCore::InjectedScriptManager::disconnect):
188 (WebCore::InjectedScriptManager::injectedScriptHost):
189 (WebCore::InjectedScriptManager::injectedScriptForId):
190 (WebCore::InjectedScriptManager::injectedScriptForObjectId):
191 (WebCore::InjectedScriptManager::discardInjectedScripts):
192 (WebCore::InjectedScriptManager::releaseObjectGroup):
193 (WebCore::InjectedScriptManager::injectedScriptSource):
194 (WebCore::InjectedScriptManager::injectScript):
195 * inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspecto r/InjectedScriptHost.h.
196 * inspector/Inspector.idl:
197 * inspector/InspectorAgent.cpp:
198 (WebCore::InspectorAgent::InspectorAgent):
199 (WebCore::InspectorAgent::inspectedPageDestroyed):
200 (WebCore::InspectorAgent::focusNode):
201 (WebCore::InspectorAgent::didClearWindowObjectInWorld):
202 (WebCore::InspectorAgent::createFrontendLifetimeAgents):
203 (WebCore::InspectorAgent::didCommitLoad):
204 (WebCore::InspectorAgent::domContentLoadedEventFired):
205 * inspector/InspectorAgent.h:
206 * inspector/InspectorBrowserDebuggerAgent.cpp:
207 * inspector/InspectorConsoleAgent.cpp:
208 (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
209 (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
210 (WebCore::InspectorConsoleAgent::clearConsoleMessages):
211 (WebCore::InspectorConsoleAgent::addInspectedNode):
212 (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
213 (WebCore::InspectorConsoleAgent::addConsoleMessage):
214 * inspector/InspectorConsoleAgent.h:
215 * inspector/InspectorController.cpp:
216 (WebCore::InspectorController::InspectorController):
217 (WebCore::InspectorController::connectFrontend):
218 (WebCore::InspectorController::disconnectFrontend):
219 * inspector/InspectorController.h:
220 * inspector/InspectorDOMAgent.cpp:
221 (WebCore::InspectorDOMAgent::InspectorDOMAgent):
222 (WebCore::InspectorDOMAgent::discardBindings):
223 (WebCore::InspectorDOMAgent::pushNodeToFrontend):
224 (WebCore::InspectorDOMAgent::resolveNode):
225 * inspector/InspectorDOMAgent.h:
226 (WebCore::InspectorDOMAgent::create):
227 * inspector/InspectorDebuggerAgent.cpp:
228 (WebCore::InspectorDebuggerAgent::create):
229 (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
230 (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
231 (WebCore::InspectorDebuggerAgent::currentCallFrames):
232 * inspector/InspectorDebuggerAgent.h:
233 * inspector/InspectorRuntimeAgent.cpp:
234 (WebCore::InspectorRuntimeAgent::create):
235 (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
236 (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
237 (WebCore::InspectorRuntimeAgent::evaluate):
238 (WebCore::InspectorRuntimeAgent::evaluateOn):
239 (WebCore::InspectorRuntimeAgent::getProperties):
240 (WebCore::InspectorRuntimeAgent::setPropertyValue):
241 (WebCore::InspectorRuntimeAgent::releaseObject):
242 (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
243 * inspector/InspectorRuntimeAgent.h:
244 * inspector/front-end/ElementsPanel.js:
245 (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
246 (WebInspector.ElementsPanel):
247
248 2011-03-09 Hans Wennborg <hans@chromium.org>
249
250 Reviewed by Jeremy Orlow.
251
252 IndexedDB: Make IDBBackingStore abstract
253 https://bugs.webkit.org/show_bug.cgi?id=56013
254
255 Make IDBBackingStore abstract to allow for multiple implementations.
256 Move the SQLite implementation to IDBSQLiteBackingStore.
257
258 No new tests: refactoring only.
259
260 * WebCore.gypi:
261 * storage/IDBBackingStore.h:
262 (WebCore::IDBBackingStore::~IDBBackingStore):
263 * storage/IDBFactoryBackendImpl.cpp:
264 (WebCore::IDBFactoryBackendImpl::open):
265 * storage/IDBSQLiteBackingStore.cpp:
266 (WebCore::IDBSQLiteBackingStore::IDBSQLiteBackingStore):
267 (WebCore::IDBSQLiteBackingStore::~IDBSQLiteBackingStore):
268 (WebCore::runCommands):
269 (WebCore::createTables):
270 (WebCore::createMetaDataTable):
271 (WebCore::getDatabaseSchemaVersion):
272 (WebCore::migrateDatabase):
273 (WebCore::IDBSQLiteBackingStore::open):
274 (WebCore::IDBSQLiteBackingStore::extractIDBDatabaseMetaData):
275 (WebCore::IDBSQLiteBackingStore::setIDBDatabaseMetaData):
276 (WebCore::IDBSQLiteBackingStore::getObjectStores):
277 (WebCore::IDBSQLiteBackingStore::createObjectStore):
278 (WebCore::doDelete):
279 (WebCore::IDBSQLiteBackingStore::deleteObjectStore):
280 (WebCore::whereSyntaxForKey):
281 (WebCore::bindKeyToQuery):
282 (WebCore::lowerCursorWhereFragment):
283 (WebCore::upperCursorWhereFragment):
284 (WebCore::IDBSQLiteBackingStore::getObjectStoreRecord):
285 (WebCore::bindKeyToQueryWithNulls):
286 (WebCore::IDBSQLiteBackingStore::putObjectStoreRecord):
287 (WebCore::IDBSQLiteBackingStore::clearObjectStore):
288 (WebCore::IDBSQLiteBackingStore::deleteObjectStoreRecord):
289 (WebCore::IDBSQLiteBackingStore::nextAutoIncrementNumber):
290 (WebCore::IDBSQLiteBackingStore::keyExistsInObjectStore):
291 (WebCore::IDBSQLiteBackingStore::forEachObjectStoreRecord):
292 (WebCore::IDBSQLiteBackingStore::getIndexes):
293 (WebCore::IDBSQLiteBackingStore::createIndex):
294 (WebCore::IDBSQLiteBackingStore::deleteIndex):
295 (WebCore::IDBSQLiteBackingStore::putIndexDataForRecord):
296 (WebCore::IDBSQLiteBackingStore::deleteIndexDataForRecord):
297 (WebCore::IDBSQLiteBackingStore::getObjectViaIndex):
298 (WebCore::keyFromQuery):
299 (WebCore::IDBSQLiteBackingStore::getPrimaryKeyViaIndex):
300 (WebCore::IDBSQLiteBackingStore::keyExistsInIndex):
301 (WebCore::IDBSQLiteBackingStore::openObjectStoreCursor):
302 (WebCore::IDBSQLiteBackingStore::openIndexKeyCursor):
303 (WebCore::IDBSQLiteBackingStore::openIndexCursor):
304 (WebCore::IDBSQLiteBackingStore::createTransaction):
305 * storage/IDBSQLiteBackingStore.h: Added.
306
307 2011-03-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
308
309 Unreviewed build error fix.
310
311 [EFL] Fix build break when SHARED_CORE is ON
312 https://bugs.webkit.org/show_bug.cgi?id=56155
313
314 * platform/efl/ContextMenuEfl.cpp:
315 (WebCore::ContextMenu::ContextMenu):
316 * platform/efl/ContextMenuItemEfl.cpp:
317 (WebCore::ContextMenuItem::nativeMenuItem):
318 (WebCore::ContextMenuItem::ContextMenuItem):
319 (WebCore::ContextMenuItem::~ContextMenuItem):
320
321 2011-03-11 Andrey Kosyakov <caseq@chromium.org>
322
323 Reviewed by Pavel Feldman.
324
325 Web Inspector: resource load cancellation is reported to console as an e rror
326 https://bugs.webkit.org/show_bug.cgi?id=55764
327
328 - mark interruptionForPolicyChangeError as cancellation
329 - do not log resource cancelation as an error
330 - always push resource to front-end before console message, so front-end can use resource info while formatting message.
331
332 * inspector/InspectorConsoleAgent.cpp:
333 (WebCore::InspectorConsoleAgent::didFailLoading):
334 * inspector/InspectorInstrumentation.cpp:
335 (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
336 (WebCore::InspectorInstrumentation::didFailLoadingImpl):
337 * loader/MainResourceLoader.cpp:
338 (WebCore::MainResourceLoader::stopLoadingForPolicyChange):
339
340 2011-03-10 Alexander Pavlov <apavlov@chromium.org>
341
342 Reviewed by Yury Semikhatsky.
343
344 Web Inspector: Get rid of has/add/removeStyleClass() methods on Element. prototype - Step 1
345 https://bugs.webkit.org/show_bug.cgi?id=56096
346
347 No new tests, as this is a refactoring.
348
349 * inspector/front-end/BreakpointsSidebarPane.js:
350 (WebInspector.EventListenerBreakpointsSidebarPane):
351 * inspector/front-end/DetailedHeapshotView.js:
352 * inspector/front-end/ResourcesPanel.js:
353 (WebInspector.ResourcesPanel):
354 (WebInspector.BaseStorageTreeElement):
355 (WebInspector.BaseStorageTreeElement.prototype.onattach):
356 (WebInspector.StorageCategoryTreeElement):
357 (WebInspector.FrameTreeElement):
358 (WebInspector.FrameResourceTreeElement):
359 (WebInspector.DatabaseTreeElement):
360 (WebInspector.DatabaseTableTreeElement):
361 (WebInspector.DOMStorageTreeElement):
362 (WebInspector.CookieTreeElement):
363 (WebInspector.ApplicationCacheTreeElement):
364 (WebInspector.ResourceRevisionTreeElement):
365 * inspector/front-end/utilities.js:
366 (Element.prototype.removeStyleClass):
367 (Element.prototype.addStyleClass):
368 (Element.prototype.hasStyleClass):
369
370 2011-03-11 Brian Salomon <bsalomon@google.com>
371
372 Reviewed by Kenneth Russell.
373
374 Adds GrContext flush call to PlatformContextSkia destructor.
375 Calls GrContext flush with int parameter instead of bool due to skia
376 revision.
377
378 No new tests needed.
379
380 * platform/graphics/chromium/DrawingBufferChromium.cpp:
381 (WebCore::DrawingBuffer::publishToPlatformLayer):
382 * platform/graphics/skia/PlatformContextSkia.cpp:
383 (WebCore::PlatformContextSkia::~PlatformContextSkia):
384 (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
385
386 2011-03-10 Chris Guillory <chris.guillory@google.com>
387
388 Reviewed by James Robinson.
389
390 Fix for Coverity discovered NO_EFFECT (self-assign) defect.
391 https://bugs.webkit.org/show_bug.cgi?id=54143
392
393 * platform/graphics/gpu/TilingData.cpp:
394 (WebCore::TilingData::setMaxTextureSize):
395
396 2011-03-10 Emil A Eklund <eae@chromium.org>
397
398 Reviewed by Alexey Proskuryakov.
399
400 The web colours palevioletred and mediumpurple are incorrect
401 https://bugs.webkit.org/show_bug.cgi?id=46658
402
403 Changed value for the palevioletred and mediumpurple colors to match
404 the css3 specification.
405
406 Test: fast/css/named-colors.html
407
408 * inspector/front-end/Color.js:
409 * platform/ColorData.gperf:
410
411 2011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
412
413 Unreviewed build fix.
414
415 [WML] Fix build error
416 https://bugs.webkit.org/show_bug.cgi?id=56078
417
418 * wml/WMLInputElement.cpp:
419 (WebCore::WMLInputElement::defaultEventHandler):
420
421 2011-03-10 Jeremy Moskovich <jeremy@chromium.org>
422
423 Reviewed by Darin Adler.
424
425 Fix navigation menus on a bunch of sites in WebKit.
426 https://bugs.webkit.org/show_bug.cgi?id=52535
427
428 WebKit doesn't support position:relative for several table elements and
429 overwrites the style internally when position:relative is encountered.
430 Unfortunately position:relative affects the choice of nodes returned by
431 offsetParent.
432
433 This CL adds a bit to RenderStyle to track whether position:relative was
434 overwritten. The value is then consulted in offsetParent which makes us
435 match FF/IE.
436
437 Tests: fast/block/positioning/offsetLeft-relative-iframe.html
438 fast/block/positioning/offsetLeft-relative-td.html
439
440 * css/CSSStyleSelector.cpp:
441 (WebCore::CSSStyleSelector::adjustRenderStyle):
442 * rendering/RenderObject.cpp:
443 (WebCore::RenderObject::isOriginallyRelPositioned):
444 (WebCore::RenderObject::offsetParent):
445 * rendering/RenderObject.h:
446 * rendering/style/RenderStyle.h: Add a bit to track the original value o f position:relative.
447 (WebCore::InheritedFlags::positionWasRelative):
448 (WebCore::InheritedFlags::setPositionWasRelative):
449 * rendering/style/StyleRareNonInheritedData.cpp:
450 (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
451 (WebCore::StyleRareNonInheritedData::operator==):
452 * rendering/style/StyleRareNonInheritedData.h:
453
454 2011-03-10 Adam Barth <abarth@webkit.org>
455
456 Reviewed by Darin Adler.
457
458 REGRESSION (r66428/r71892): Crash after assertion failure (!m_reachedTer minalState) in ResourceLoader::didCancel()
459 https://bugs.webkit.org/show_bug.cgi?id=51357
460
461 Previously, we would try to print from a callstack that didn't want a
462 nested event loop, leading to re-entrancy problems. In this patch, we
463 complete the print call asynchronously, giving us a clean stack on
464 which to run the nested event loop.
465
466 Test: printing/print-close-crash.html
467
468 * page/DOMWindow.cpp:
469 (WebCore::DOMWindow::DOMWindow):
470 (WebCore::DOMWindow::print):
471 (WebCore::DOMWindow::printTimerFired):
472 * page/DOMWindow.h:
473
474 2011-03-11 Roland Steiner <rolandsteiner@chromium.org>
475
476 Reviewed by Ryosuke Niwa.
477
478 Bug 55570 - Remove dependency of dom/InputElement.cpp on html/ and wml/
479 https://bugs.webkit.org/show_bug.cgi?id=55570
480
481 Add a virtual function toInputElement() to Node that has a default
482 implementation of returning 0.
483 For HTMLInputElement and WMLInputElement (which derive from InputElement )
484 override this to return the object.
485 Change all calling sites of the old toInputElement to use the new member
486 function. This also allows us to save some casts.
487
488 No new tests. (refactoring)
489
490 * WebCore.exp.in:
491 * accessibility/AXObjectCache.cpp:
492 (WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
493 * accessibility/AccessibilityRenderObject.cpp:
494 (WebCore::AccessibilityRenderObject::isPasswordField):
495 (WebCore::AccessibilityRenderObject::isIndeterminate):
496 (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
497 (WebCore::AccessibilityRenderObject::isChecked):
498 * css/CSSStyleSelector.cpp:
499 (WebCore::CSSStyleSelector::canShareStyleWithElement):
500 (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
501 * dom/CheckedRadioButtons.cpp:
502 (WebCore::CheckedRadioButtons::removeButton):
503 * dom/InputElement.cpp:
504 * dom/InputElement.h:
505 * dom/Node.cpp:
506 (WebCore::Node::toInputElement):
507 * dom/Node.h:
508 * html/HTMLInputElement.h:
509 (WebCore::HTMLInputElement::toInputElement):
510 * rendering/RenderTextControlSingleLine.cpp:
511 (WebCore::RenderTextControlSingleLine::inputElement):
512 * rendering/RenderTheme.cpp:
513 (WebCore::RenderTheme::isChecked):
514 (WebCore::RenderTheme::isIndeterminate):
515 * wml/WMLInputElement.h:
516 (WebCore::WMLInputElement::toInputElement):
517
518 2011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
519
520 Reviewed by Kenneth Rohde Christiansen.
521
522 [EFL] New mediaControl css file for EFL
523 https://bugs.webkit.org/show_bug.cgi?id=55460
524
525 Add new mediaControl css file for html5 video UI.
526
527 * CMakeLists.txt:
528 * CMakeListsEfl.txt:
529 * css/mediaControlsEfl.css: Added.
530 (audio):
531 (audio::-webkit-media-controls-panel, video::-webkit-media-controls-pane l):
532 (video:-webkit-full-page-media::-webkit-media-controls-panel):
533 (audio::-webkit-media-controls-mute-button, video::-webkit-media-control s-mute-button):
534 (audio::-webkit-media-controls-play-button, video::-webkit-media-control s-play-button):
535 (audio::-webkit-media-controls-timeline-container, video::-webkit-media- controls-timeline-container):
536 (audio::-webkit-media-controls-current-time-display, video::-webkit-medi a-controls-current-time-display):
537 (audio::-webkit-media-controls-time-remaining-display, video::-webkit-me dia-controls-time-remaining-display):
538 (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-t imeline):
539 (audio::-webkit-media-controls-volume-slider-container, video::-webkit-m edia-controls-volume-slider-container):
540 (audio::-webkit-media-controls-volume-slider, video::-webkit-media-contr ols-volume-slider):
541 (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-co ntrols-seek-back-button):
542 (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media -controls-seek-forward-button):
543 (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-c ontrols-fullscreen-button):
544 (audio::-webkit-media-controls-rewind-button, video::-webkit-media-contr ols-rewind-button):
545 (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit -media-controls-return-to-realtime-button):
546 (audio::-webkit-media-controls-toggle-closed-captions-button, video::-we bkit-media-controls-toggle-closed-captions-button):
547 (audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit -media-controls-volume-slider-mute-button):
548 * platform/efl/RenderThemeEfl.cpp:
549 (WebCore::RenderThemeEfl::extraMediaControlsStyleSheet):
550
551 2011-03-10 Emil A Eklund <eae@chromium.org>
552
553 Reviewed by Dimitri Glazkov.
554
555 style.display affecting the initial selectedIndex value of a <select> wh en its multiple attribute is set programatically
556 https://bugs.webkit.org/show_bug.cgi?id=53860
557
558 Preserve selection when changing between multi-select and single-select
559 for <select> boxes even if it has not yet been rendered.
560
561 Test: fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html
562
563 * html/HTMLSelectElement.cpp:
564 (WebCore::HTMLSelectElement::setMultiple):
565
566 2011-03-10 Ojan Vafai <ojan@chromium.org>
567
568 Reviewed by Tony Chang.
569
570 update comment to reference new DOM Core spec
571 https://bugs.webkit.org/show_bug.cgi?id=56079
572
573 I'm excising all instances of WRONG_DOCUMENT_ERR from WebKit.
574 This is the only one that's actually specified to fire
575 in the latest DOM Core spec.
576
577 * dom/DOMImplementation.cpp:
578 (WebCore::DOMImplementation::createDocument):
579
580 2011-03-10 Rik Cabanier <cabanier@gmail.com>
581
582 Reviewed by Tony Gentilcore.
583
584 Fix that allows fixed length values to be floating point
585 https://bugs.webkit.org/show_bug.cgi?id=52699
586
587 * WebCore.xcodeproj/project.pbxproj:
588 * css/CSSStyleSelector.cpp:
589 (WebCore::convertToLength):
590 (WebCore::convertToIntLength):
591 (WebCore::convertToFloatLength):
592 (WebCore::CSSStyleSelector::applyProperty):
593 (WebCore::CSSStyleSelector::createTransformOperations):
594 * platform/Length.h:
595 (WebCore::Length::Length):
596 (WebCore::Length::operator==):
597 (WebCore::Length::operator!=):
598 (WebCore::Length::rawValue):
599 (WebCore::Length::type):
600 (WebCore::Length::quirk):
601 (WebCore::Length::setValue):
602 (WebCore::Length::calcFloatValue):
603 (WebCore::Length::isZero):
604 (WebCore::Length::blend):
605 (WebCore::Length::getIntValue):
606 (WebCore::Length::getFloatValue):
607 * rendering/AutoTableLayout.cpp:
608 (WebCore::AutoTableLayout::recalcColumn):
609 (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
610 * rendering/FixedTableLayout.cpp:
611 (WebCore::FixedTableLayout::calcWidthArray):
612
613 2011-03-10 Sheriff Bot <webkit.review.bot@gmail.com>
614
615 Unreviewed, rolling out r80800.
616 http://trac.webkit.org/changeset/80800
617 https://bugs.webkit.org/show_bug.cgi?id=56163
618
619 Caused hundreds of tests to crash on Windows 7 (Requested by
620 rniwa on #webkit).
621
622 * page/EventHandler.cpp:
623 (WebCore::EventHandler::mouseMoved):
624 (WebCore::EventHandler::updateMouseEventTargetNode):
625 * page/FocusController.cpp:
626 (WebCore::FocusController::setActive):
627 * page/FrameView.cpp:
628 (WebCore::FrameView::FrameView):
629 (WebCore::FrameView::~FrameView):
630 * page/FrameView.h:
631 * page/Page.cpp:
632 * page/Page.h:
633 * platform/ScrollView.cpp:
634 (WebCore::ScrollView::wheelEvent):
635 * platform/ScrollView.h:
636 * rendering/RenderDataGrid.cpp:
637 (WebCore::RenderDataGrid::RenderDataGrid):
638 (WebCore::RenderDataGrid::~RenderDataGrid):
639 * rendering/RenderLayer.cpp:
640 (WebCore::RenderLayer::RenderLayer):
641 (WebCore::RenderLayer::~RenderLayer):
642 * rendering/RenderLayer.h:
643 * rendering/RenderListBox.cpp:
644 (WebCore::RenderListBox::RenderListBox):
645 (WebCore::RenderListBox::~RenderListBox):
646
647 2011-03-10 Alice Boxhall <aboxhall@chromium.org>
648
649 Reviewed by Dimitri Glazkov.
650
651 NULL pointer crash when using :empty and :first-line pseudoclass selecto rs together
652 https://bugs.webkit.org/show_bug.cgi?id=53316
653
654 :empty is calculated for each element during parsing, but then not
655 recalculated after any child elements are attached. Force style
656 re-calculation on elements which have :empty in their style when
657 their children are changed.
658
659 Test: fast/css/empty-first-line-crash.html
660
661 * dom/Element.cpp:
662 (WebCore::checkForEmptyStyleChange): Pull out empty style checking
663 logic from checkForSiblingStyleChanges().
664 (WebCore::checkForSiblingStyleChanges): Use new checkForEmptyStyleChange s()
665 method.
666 (WebCore::Element::childrenChanged): Call checkForEmptyStyleChanges() w hen
667 called with changedByParser = true.
668
669 2011-03-10 Emil A Eklund <eae@chromium.org>
670
671 Unreviewed build fix.
672
673 Fix Leopard Release build broken by r80797.
674
675 * html/CollectionCache.h:
676
677 2011-03-10 Beth Dakin <bdakin@apple.com>
678
679 Reviewed by Darin Adler.
680
681 Fix for <rdar://problem/8944558> Overlay scrollers in overflow areas nee d to
682 send notifications appropriate times (showing up, resizing)
683 -and corresponding-
684 https://bugs.webkit.org/show_bug.cgi?id=56067
685
686 The general strategy here is to add a HashSet of ScrollableAreas to the page that
687 can be accessed when necessary to send notifications to all ScrollableAr eas.
688
689 Find layers for relevant node and if the layers are in the Page's Scroll ableArea
690 set, then send the relevant notification.
691 * page/EventHandler.cpp:
692 (WebCore::EventHandler::mouseMoved):
693 (WebCore::EventHandler::updateMouseEventTargetNode):
694
695 When the page is set active or not active, iterate through the Page's
696 ScrollableAreas to send hide/show notifications.
697 * page/FocusController.cpp:
698 (WebCore::FocusController::setActive):
699
700 When a FrameView is created, add it to the ScrollableArea set. When it's
701 destroyed, remove it.
702 * page/FrameView.cpp:
703 (WebCore::FrameView::FrameView):
704 (WebCore::FrameView::~FrameView):
705
706 Iterate through the Page's ScrollableAreas to send the paint notificatio n.
707 (WebCore::FrameView::notifyPageThatContentAreaWillPaint):
708 * page/FrameView.h:
709
710 Add the new ScrollableArea set.
711 * page/Page.cpp:
712 (WebCore::Page::addScrollableArea):
713 (WebCore::Page::removeScrollableArea):
714 (WebCore::Page::pageContainsScrollableArea):
715 * page/Page.h:
716 (WebCore::Page::scrollableAreaSet):
717
718 notifyPageThatContentAreaWillPaint() is a dummy function implemented in FrameView.
719 * platform/ScrollView.cpp:
720 (WebCore::ScrollView::notifyPageThatContentAreaWillPaint):
721
722 Call notifyPageThatContentAreaWillPaint() instead of calling
723 contentAreaWillPaint() just for the ScrollView.
724 (WebCore::ScrollView::paint):
725 * platform/ScrollView.h:
726
727 Add/remove ScrollableAreas to the set.
728 * rendering/RenderDataGrid.cpp:
729 (WebCore::RenderDataGrid::RenderDataGrid):
730 (WebCore::RenderDataGrid::~RenderDataGrid):
731 * rendering/RenderListBox.cpp:
732 (WebCore::RenderListBox::RenderListBox):
733 (WebCore::RenderListBox::~RenderListBox):
734 * rendering/RenderLayer.cpp:
735 (WebCore::RenderLayer::RenderLayer):
736 (WebCore::RenderLayer::~RenderLayer):
737
738 Should have implemented this ScrollableArea-interface function a while a go.
739 (WebCore::RenderLayer::currentMousePosition):
740 * rendering/RenderLayer.h:
741
742 2011-03-10 takano takumi <takano@apple.com>
743
744 Reviewed by David Hyatt.
745
746 Crash in RenderCombineText::combineText when running fast/text/internati onal/text-combine-parser-test.html on Windows with full page heap enabled
747 https://bugs.webkit.org/show_bug.cgi?id=55069
748
749 No new tests. If the test above runs without crash, the fix should be ok ay.
750
751 * dom/Node.cpp:
752 (WebCore::Node::diff):
753 - Changed to return Detach when textCombine style was changed.
754 * rendering/RenderCombineText.cpp:
755 (WebCore::RenderCombineText::styleDidChange):
756 (WebCore::RenderCombineText::setTextInternal):
757 (WebCore::RenderCombineText::width):
758 (WebCore::RenderCombineText::adjustTextOrigin):
759 (WebCore::RenderCombineText::charactersToRender):
760 (WebCore::RenderCombineText::combineText):
761 - Added assertions to ensure the passed object is RenderCombineText.
762 * rendering/RenderCombineText.h:
763 (WebCore::RenderCombineText::isCombineText):
764 - Added to distinguish plain RenderText and RenderCombineText.
765 (WebCore::toRenderCombineText):
766 - Added assertions to ensure the passed object is RenderCombineText.
767 * rendering/RenderObject.h:
768 (WebCore::RenderObject::isCombineText):
769 - Added to distinguish plain RenderText and RenderCombineText.
770
771 2011-03-10 Emil A Eklund <eae@chromium.org>
772
773 Reviewed by Darin Adler.
774
775 Collection cache not reset when moving base node between documents
776 https://bugs.webkit.org/show_bug.cgi?id=55446
777
778 Fix bug where HTMLCollection::resetCollectionInfo does not reset the
779 cache when the base node is moved to a different document by making sure
780 that the DOMVersion is updated and that it's unique across documents.
781
782 Tests: fast/dom/HTMLFormElement/invalid-form-field.html
783 fast/dom/HTMLFormElement/move-option-between-documents.html
784 fast/dom/collection-nameditem-move-between-documents.html
785
786 * dom/Document.cpp:
787 (WebCore::Document::Document):
788 * dom/Document.h:
789 (WebCore::Document::incDOMTreeVersion):
790 (WebCore::Document::domTreeVersion):
791 * dom/Node.cpp:
792 (WebCore::Node::setDocumentRecursively):
793 * html/FormAssociatedElement.cpp:
794 (WebCore::FormAssociatedElement::resetFormOwner):
795 * html/HTMLCollection.cpp:
796 (WebCore::HTMLCollection::resetCollectionInfo):
797 * xml/XPathResult.h:
798
799 2011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
800
801 Unreviewed build fix.
802
803 [EFL] Fix build break when CROSS_PLATFORM_CONTEXT_MENUS is disabled.
804 https://bugs.webkit.org/show_bug.cgi?id=56005
805
806 There are build breaks when CROSS_PLATFORM_CONTEXT_MENUS is disabled.
807
808 * platform/efl/ContextMenuEfl.cpp:
809 (WebCore::ContextMenu::ContextMenu):
810 * platform/efl/ContextMenuItemEfl.cpp:
811
812 2011-03-10 Ryosuke Niwa <rniwa@webkit.org>
813
814 Reviewed by Tony Chang.
815
816 startOfBlock and endOfBlock may return a position inside hr
817 https://bugs.webkit.org/show_bug.cgi?id=56025
818
819 Replaced calls to enclosingBlockFlowElement in startOfBlock and endOfBlo ck by
820 calls to enclosingBlock. Added EditingBoundaryCrossingRule to the argume nt lists
821 of startOfBlock, endOfBlock, and enclosingBlock. Also replaced the last boolean
822 argument variable of enclosingNodeOfType by EditingBoundaryCrossingRule.
823
824 Also replaced calls to enclosingBlockFlowElement in inSameBlock by calls to
825 enclosingBlock to be consitent with startOfBlock and endOfBlock.
826
827 This patch also replaced calls to deprecatedNode in startOfBlock, endOfB lock,
828 and inSameBlock by calls to containerNode because the enclosing block of a position
829 should never be before or after the position.
830
831 No tests are added because this change only affects WebCore internally.
832
833 * editing/DeleteSelectionCommand.cpp:
834 (WebCore::DeleteSelectionCommand::initializePositionData): Calls enclosi ngNodeOfType.
835 Pass CanCrossEditingBoundary instead of false.
836 * editing/htmlediting.cpp:
837 (WebCore::unsplittableElementForPosition): Ditto.
838 (WebCore::enclosingBlock): Takes EditingBoundaryCrossingRule and passes it to
839 enclosingNodeOfType.
840 (WebCore::enclosingNodeOfType): Takes EditingBoundaryCrossingRule instea d of boolean.
841 Fixed a bug that it stops walking the tree when it reached the root edit able node
842 even when the editing boundary crossing rule is CanCrossEditingBoundary.
843 * editing/htmlediting.h: Prototype changes.
844 * editing/visible_units.cpp:
845 (WebCore::startOfBlock): Calls enclosingBlock instead of enclosingBlockF lowElement.
846 Also added an early exit when there's no enclosing block.
847 (WebCore::endOfBlock): Ditto. The early exist in this case prevents cras h in
848 lastPositionInNode.
849 (WebCore::inSameBlock): Calls enclosingBlock instead of enclosingBlockFl owElement.
850 (WebCore::isStartOfBlock): Calls startOfBlock with CanCrossEditingBounda ry because
851 we don't care where the start of block is when we're comparing against t he given position.
852 (WebCore::isEndOfBlock): Ditto.
853 * editing/visible_units.h:
854
855 2011-03-10 Alexey Proskuryakov <ap@apple.com>
856
857 Reviewed by Dan Bernstein.
858
859 Backspace deletes all non-BMP symbols at once, and then some
860 https://bugs.webkit.org/show_bug.cgi?id=55971
861 <rdar://problem/8725312>
862
863 Test: platform/mac/editing/input/insert-delete-smp-symbol.html
864
865 * rendering/RenderText.cpp:
866 (WebCore::isMark): This matches what Core Foundation does for all charac ters that I tested.
867 (WebCore::RenderText::previousOffsetForBackwardDeletion): Changed to use isMark().
868
869 2011-03-10 Chris Evans <cevans@chromium.org>
870
871 Reviewed by Adam Barth.
872
873 Error in StyleElement::process with large nodesets
874 https://bugs.webkit.org/show_bug.cgi?id=56150
875
876 Test: none due to excessive runtime and CRASH() vs. real crash.
877
878 * dom/StyleElement.cpp:
879 (WebCore::StyleElement::process): Handle large node sets better.
880
881 2011-03-10 David Hyatt <hyatt@apple.com>
882
883 Reviewed by Simon Fraser.
884
885 https://bugs.webkit.org/show_bug.cgi?id=47151
886
887 Percentage heights should skip anonymous containing blocks when computin g the used value.
888
889 Added fast/block/basic/percentage-height-inside-anonymous-block.html
890
891 * rendering/RenderBox.cpp:
892 (WebCore::RenderBox::computePercentageLogicalHeight):
893
894 2011-03-10 Nat Duca <nduca@chromium.org>
895
896 Reviewed by James Robinson.
897
898 [chromium] Make updateAndDrawLayers argumentless.
899 https://bugs.webkit.org/show_bug.cgi?id=55985
900
901 Made the TilePainters and viewport parameters for
902 LayerRendererChromium member variables instead of arguments on
903 updateAndDrawLayers. In a future change, this will allows us to
904 draw the layer tree without the WebView's assistance.
905
906 * platform/graphics/chromium/LayerRendererChromium.cpp:
907 (WebCore::LayerRendererChromium::create):
908 (WebCore::LayerRendererChromium::LayerRendererChromium):
909 (WebCore::LayerRendererChromium::verticalScrollbarRect):
910 (WebCore::LayerRendererChromium::horizontalScrollbarRect):
911 (WebCore::LayerRendererChromium::invalidateRootLayerRect):
912 (WebCore::LayerRendererChromium::updateRootLayerContents):
913 (WebCore::LayerRendererChromium::updateRootLayerScrollbars):
914 (WebCore::LayerRendererChromium::drawRootLayer):
915 (WebCore::LayerRendererChromium::setViewport):
916 (WebCore::LayerRendererChromium::updateAndDrawLayers):
917 (WebCore::LayerRendererChromium::updateLayers):
918 (WebCore::LayerRendererChromium::drawLayers):
919 (WebCore::LayerRendererChromium::setRootLayer):
920 (WebCore::LayerRendererChromium::getFramebufferPixels):
921 (WebCore::LayerRendererChromium::cleanupSharedObjects):
922 * platform/graphics/chromium/LayerRendererChromium.h:
923 (WebCore::LayerRendererChromium::viewportSize):
924 * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
925 (WebCore::CCHeadsUpDisplay::draw):
926
927 2011-01-25 Martin Robinson <mrobinson@igalia.com>
928
929 Reviewed by Xan Lopez.
930
931 [GTK] Implement spin buttons for GTK+ 2.x
932 https://bugs.webkit.org/show_bug.cgi?id=53098
933
934 Implement spin buttons for GTK+ 2.x. This allows proper render and funct ioning
935 for input type=number. The implementation is based on the one in gtkspin button.c
936 from the GTK+ sources.
937
938 * platform/gtk/RenderThemeGtk.h: Added new members and getters.
939 * platform/gtk/RenderThemeGtk2.cpp:
940 (WebCore::RenderThemeGtk::platformInit): Initialize spin button widget.
941 (WebCore::RenderThemeGtk::adjustRepaintRect): We need to draw outside th e
942 spin button area to have proper rendering. There doesn't seem to be any other
943 clean way of having spin buttons that are the size of the text input fra me.
944 (WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle): Added implementat ion.
945 (WebCore::RenderThemeGtk::paintInnerSpinButton): Ditto.
946 (WebCore::RenderThemeGtk::gtkSpinButton): Added.
947
948 2011-03-10 Levi Weintraub <leviw@chromium.org>
949
950 Reviewed by Ryosuke Niwa.
951
952 InsertUnorderedList over a non-editable region and multiple lines enters an infinite loop
953 https://bugs.webkit.org/show_bug.cgi?id=53409
954
955 Fixing broken handling of mixed-editability content for InsertListComman d. Previously, if the selection
956 spanned non-contenteditable regions, it would get stuck endlessly iterat ing the same region as the algorithm
957 didn't skip the editable boundary.
958
959 Test: editing/execCommand/insert-list-with-noneditable-content.html
960
961 * editing/CompositeEditCommand.cpp:
962 (WebCore::CompositeEditCommand::cleanupAfterDeletion): Changed signature to take the destination
963 position for the active editing command. Without this, there are cases w hen the destination happens
964 to be a placeholder, and we remove it.
965 (WebCore::CompositeEditCommand::moveParagraphs):
966 * editing/CompositeEditCommand.h:
967 * editing/InsertListCommand.cpp:
968 (WebCore::InsertListCommand::doApply): Added logic to the paragraph iter ation loop to handle pockets of
969 non-editable content in an editable context. Previously, this could caus e an infinite loop.
970 * editing/visible_units.cpp:
971 (WebCore::startOfParagraph): Added a mode of operation where we'll jump across non-editable
972 content in the same paragraph to reach the actual editable paragraph sta rt.
973 (WebCore::endOfParagraph): Ditto.
974 (WebCore::startOfNextParagraph): Now uses the aforementioned non-editabl e content skipping mode of
975 endOfParagraph.
976
977 2011-03-10 Berend-Jan Wever <skylined@chromium.org>
978
979 Reviewed by Darin Adler.
980
981 Calling focus() on an area element not in a document should not cause a NULL ptr crash
982 https://bugs.webkit.org/show_bug.cgi?id=54877
983
984 Test: fast/dom/HTMLAreaElement/area-islink-focus-null-ptr-crash.html
985
986 * dom/Element.cpp:
987 (WebCore::Element::focus): Check element is in the document before allow ing focus
988 * html/HTMLAreaElement.cpp:
989 (WebCore::HTMLAreaElement::imageElement): Check element has a parent bef ore checking if its parent is a map
990
991 2011-03-10 Xiyuan Xia <xiyuan@chromium.org>
992
993 Reviewed by Tony Chang.
994
995 [Chromium] Fix default single selection select's popup background on chr omium/linux
996 https://bugs.webkit.org/show_bug.cgi?id=56023
997
998 Test: fast/html/select-dropdown-consistent-background-color.html
999
1000 * css/themeChromiumLinux.css:
1001
1002 2011-03-10 Kris Jordan <krisjordan@gmail.com>
1003
1004 Reviewed by Alexey Proskuryakov.
1005
1006 Improve default Accept header to give preference to HTML over XML.
1007 https://bugs.webkit.org/show_bug.cgi?id=27267
1008
1009 * loader/FrameLoader.cpp:Changed default accept header to match
1010 FireFox' as per bug 27267.
1011
1012 2011-03-10 Martin Robinson <mrobinson@igalia.com>
1013
1014 Reviewed by Xan Lopez.
1015
1016 [GTK] [Webkit2] There are no scrollbars visible in the MiniBrowser
1017 https://bugs.webkit.org/show_bug.cgi?id=56125
1018
1019 No new tests. This functionality will be tested once we have TestRunner
1020 implementation for WebKit2 with pixel dumping support.
1021
1022 * GNUmakefile.am: Add a new define with tracks whether or not we are usi ng
1023 our specialized GTK+ ScrollView.
1024 * platform/ScrollView.cpp: Only use the GTK+-specific ScrollView if we a re compiling
1025 WebKit1.
1026 (WebCore::ScrollView::wheelEvent):
1027 * platform/gtk/ScrollViewGtk.cpp: Ditto.
1028
1029 2011-03-10 Kent Tamura <tkent@chromium.org>
1030
1031 Reviewed by Dimitri Glazkov.
1032
1033 Assertion fails by validating a form twice very quickly
1034 https://bugs.webkit.org/show_bug.cgi?id=56069
1035
1036 If the interactive validation is invoked when a form control is in
1037 needsLayout() state, an assertion in isFocusable() fails. To avoid it,
1038 Add a call to updateLayoutIgnorePendingStylesheets() before isFocusable( ).
1039
1040 Test: fast/forms/interactive-validation-assertion-by-validate-twice.html
1041
1042 * html/HTMLFormElement.cpp:
1043 (WebCore::HTMLFormElement::validateInteractively):
1044 Calls updateLayoutIgnorePendingStylesheets().
1045
1046 2011-03-10 David Hyatt <hyatt@apple.com>
1047
1048 Reviewed by Beth Dakin.
1049
1050 https://bugs.webkit.org/show_bug.cgi?id=47143
1051
1052 Static distance computation is wrong when an ancestor is also positioned . We need to go up the container()
1053 chain (after initially starting with the parent()) when doing this compu tation, so that we properly skip
1054 intermediate boxes between two positioned blocks.
1055
1056 Added fast/block/positioning/static-distance-with-positioned-ancestor.ht ml.
1057
1058 * rendering/RenderBox.cpp:
1059 (WebCore::computeInlineStaticDistance):
1060 (WebCore::computeBlockStaticDistance):
1061
1062 2011-03-10 Adrienne Walker <enne@google.com>
1063
1064 Reviewed by Kenneth Russell.
1065
1066 [chromium] Make tiled compositor data structure more efficient.
1067 https://bugs.webkit.org/show_bug.cgi?id=54133
1068
1069 Previously, the compositor had a sparse 2D array of tiles for the
1070 whole page, most of which were null. The tiles were implicitly
1071 located based on their position in the array. This was inefficient
1072 when the page grew (e.g. infinite scrolling) and caused some bugs
1073 (e.g. width * height > MAX_INT). This change modifies tiles to have
1074 explicit positions so they can be stored in a hash map.
1075
1076 Tests: LayoutTests/compositing/
1077
1078 * platform/graphics/chromium/LayerTilerChromium.cpp:
1079 (WebCore::LayerTilerChromium::reset):
1080 (WebCore::LayerTilerChromium::createTile):
1081 (WebCore::LayerTilerChromium::invalidateTiles):
1082 (WebCore::LayerTilerChromium::contentRectToTileIndices):
1083 (WebCore::LayerTilerChromium::tileAt):
1084 (WebCore::LayerTilerChromium::tileContentRect):
1085 (WebCore::LayerTilerChromium::tileLayerRect):
1086 (WebCore::LayerTilerChromium::invalidateRect):
1087 (WebCore::LayerTilerChromium::invalidateEntireLayer):
1088 (WebCore::LayerTilerChromium::update):
1089 (WebCore::LayerTilerChromium::updateFromPixels):
1090 (WebCore::LayerTilerChromium::draw):
1091 (WebCore::LayerTilerChromium::growLayerToContain):
1092 * platform/graphics/chromium/LayerTilerChromium.h:
1093 (WebCore::LayerTilerChromium::Tile::Tile):
1094 (WebCore::LayerTilerChromium::Tile::i):
1095 (WebCore::LayerTilerChromium::Tile::j):
1096 (WebCore::LayerTilerChromium::Tile::moveTo):
1097 (WebCore::LayerTilerChromium::TileMapKeyTraits::emptyValue):
1098 (WebCore::LayerTilerChromium::TileMapKeyTraits::constructDeletedValue):
1099 (WebCore::LayerTilerChromium::TileMapKeyTraits::isDeletedValue):
1100
1101 2011-03-10 Ryosuke Niwa <rniwa@webkit.org>
1102
1103 Unreviewed build fix for r80752; Negated the boolean logic.
1104
1105 * editing/VisiblePosition.cpp:
1106 (WebCore::VisiblePosition::next):
1107 (WebCore::VisiblePosition::previous):
1108
1109 2011-03-10 David Hyatt <hyatt@apple.com>
1110
1111 Reviewed by Adam Roben.
1112
1113 Make the same change to xheight on Windows for CG.
1114
1115 * platform/graphics/win/SimpleFontDataCGWin.cpp:
1116 (WebCore::SimpleFontData::platformInit):
1117
1118 2011-03-10 David Hyatt <hyatt@apple.com>
1119
1120 Reviewed by Simon Fraser.
1121
1122 https://bugs.webkit.org/show_bug.cgi?id=47147
1123
1124 Fix for repaint issues when the root element is a table and needs to pai nt a background that
1125 covers the entire canvas. Remove paintRootBoxDecorations and replace wi th paintRootBoxFillLayers,
1126 so that it can be called only for fill layer painting. Make tables and normal boxes both
1127 call this new method. Fix the dirty check at the start of RenderTable p aint to not happen if
1128 the table is the root of the document (this same check exists in RenderB lock painting already).
1129
1130 * rendering/RenderBox.cpp:
1131 (WebCore::RenderBox::paintRootBoxFillLayers):
1132 (WebCore::RenderBox::paintBoxDecorations):
1133 (WebCore::RenderBox::paintBoxDecorationsWithSize):
1134 * rendering/RenderBox.h:
1135 * rendering/RenderLayerCompositor.cpp:
1136 (WebCore::RenderLayerCompositor::calculateCompositedBounds):
1137 * rendering/RenderTable.cpp:
1138 (WebCore::RenderTable::paint):
1139 (WebCore::RenderTable::paintBoxDecorations):
1140
1141 2011-03-10 Sheriff Bot <webkit.review.bot@gmail.com>
1142
1143 Unreviewed, rolling out r80749.
1144 http://trac.webkit.org/changeset/80749
1145 https://bugs.webkit.org/show_bug.cgi?id=56143
1146
1147 "Caused at least 3 media tests to be flaky" (Requested by
1148 tonyg-cr on #webkit).
1149
1150 * html/parser/HTMLDocumentParser.cpp:
1151 (WebCore::HTMLDocumentParser::canTakeNextToken):
1152 (WebCore::HTMLDocumentParser::pumpTokenizer):
1153 * html/parser/HTMLParserScheduler.cpp:
1154 * html/parser/HTMLParserScheduler.h:
1155 (WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
1156 * page/FrameView.h:
1157
1158 2011-03-10 Sam Weinig <sam@webkit.org>
1159
1160 Reviewed by David Hyatt.
1161
1162 Regression: Content not drawn when scrolling horizontally in an RTL page
1163 https://bugs.webkit.org/show_bug.cgi?id=55077
1164
1165 * platform/ScrollView.cpp:
1166 (WebCore::ScrollView::overhangAmount):
1167 (WebCore::ScrollView::calculateOverhangAreasForPainting):
1168 Take the scroll origin into account when calculating overhang.
1169
1170 * platform/ScrollView.h:
1171 * rendering/RenderLayer.h:
1172 * platform/ScrollableArea.h:
1173 (WebCore::ScrollableArea::scrollOrigin):
1174 Move identical scroll origin member from ScrollView and RenderLayer
1175 to shared base ScrollableArea. This is also needed so that the animator
1176 can access it.
1177
1178 * platform/mac/ScrollAnimatorMac.mm:
1179 (WebCore::ScrollAnimatorMac::pinnedInDirection):
1180 (WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
1181 (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
1182 Account for a scroll origin when doing calculating scroll offsets.
1183
1184 2011-03-09 Matthew Delaney <mdelaney@apple.com>
1185
1186 Reviewed by Simon Fraser.
1187
1188 Plumb through settings for accelerated drawing for canvas
1189 https://bugs.webkit.org/show_bug.cgi?id=56039
1190
1191 No new tests. Doesn't affect behavior, just adding a switch to toggle ca nvas backends.
1192
1193 * WebCore.exp.in:
1194 * html/HTMLCanvasElement.cpp:
1195 * html/canvas/CanvasRenderingContext2D.cpp:
1196 * page/Settings.cpp:
1197 * page/Settings.h:
1198
1199 2011-03-10 David Hyatt <hyatt@apple.com>
1200
1201 Reviewed by Simon Fraser.
1202
1203 https://bugs.webkit.org/show_bug.cgi?id=47157
1204
1205 CSS2.1 test suite failures because the ex unit is broken with the Ahem f ont.
1206
1207 Remove the code that tries to also include the maxX of the glyph bounds for the
1208 'x' glyph, since it just causes the x-height to be way too large in case s where the 'x' glyph extends
1209 below the baseline.
1210
1211 Remove the Apple Symbol hack for ex units, since the person who added th at was confused by another
1212 issue, namely that CGFontGetXHeight wasn't being properly multiplied by the pointSize. That's why
1213 the value was too small. Patched the code to just multiply by pointSize and took out the hack.
1214
1215 Fix causes many tests in the css2.1 directory to progress, so no new tes ts required. Many other
1216 layout tests change because the xHeight for Lucida Grande gets smaller b y a little bit, and radio
1217 buttons use ex horizontal margins by default.
1218
1219 * platform/graphics/mac/SimpleFontDataMac.mm:
1220 (WebCore::SimpleFontData::platformInit):
1221
1222 2011-03-10 Ryosuke Niwa <rniwa@webkit.org>
1223
1224 Reviewed by Tony Chang.
1225
1226 VisiblePosition's next and previous should take an enum instead of a boo lean
1227 https://bugs.webkit.org/show_bug.cgi?id=56135
1228
1229 Changed the argument type of VisiblePosition::next and VisiblePosition:: previous
1230 from bool to EditingBoundaryCrossingRule. Also got rid of StayInEditable Content enum
1231 in VisibleSelection and replaced it by EditingBoundaryCrossingRule becau se the enum
1232 was only used in VisiblePosition::isAll and subsequently in SelectionCon troller::isAll
1233 to call VisiblePosition::next and VisiblePosition::previous.
1234
1235 * WebCore.exp.in:
1236 * dom/Position.cpp:
1237 (WebCore::Position::trailingWhitespacePosition):
1238 * editing/ApplyBlockElementCommand.cpp:
1239 (WebCore::ApplyBlockElementCommand::doApply):
1240 * editing/CompositeEditCommand.cpp:
1241 (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph) :
1242 * editing/InsertListCommand.cpp:
1243 (WebCore::InsertListCommand::doApply):
1244 (WebCore::InsertListCommand::listifyParagraph):
1245 * editing/ReplaceSelectionCommand.cpp:
1246 (WebCore::ReplaceSelectionCommand::shouldMergeStart):
1247 (WebCore::ReplaceSelectionCommand::shouldMergeEnd):
1248 (WebCore::ReplaceSelectionCommand::doApply):
1249 * editing/SelectionController.cpp:
1250 (WebCore::SelectionController::modifyExtendingRight):
1251 (WebCore::SelectionController::modifyExtendingForward):
1252 (WebCore::SelectionController::modifyMovingForward):
1253 (WebCore::SelectionController::modifyExtendingLeft):
1254 (WebCore::SelectionController::modifyExtendingBackward):
1255 (WebCore::SelectionController::modifyMovingBackward):
1256 * editing/SelectionController.h:
1257 (WebCore::SelectionController::isAll):
1258 * editing/TypingCommand.cpp:
1259 (WebCore::TypingCommand::deleteKeyPressed):
1260 (WebCore::TypingCommand::forwardDeleteKeyPressed):
1261 * editing/VisiblePosition.cpp:
1262 (WebCore::VisiblePosition::next):
1263 (WebCore::VisiblePosition::previous):
1264 * editing/VisiblePosition.h:
1265 * editing/VisibleSelection.cpp:
1266 (WebCore::VisibleSelection::isAll):
1267 (WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGra nularity):
1268 * editing/VisibleSelection.h:
1269 * editing/htmlediting.cpp:
1270 (WebCore::selectionForParagraphIteration):
1271 * editing/visible_units.cpp:
1272 (WebCore::startOfNextParagraph):
1273
1274 2011-03-10 Mihai Parparita <mihaip@chromium.org>
1275
1276 Reviewed by Tony Gentilcore.
1277
1278 Remove CRASH() calls added to track down bug 53045
1279 https://bugs.webkit.org/show_bug.cgi?id=56137
1280
1281 Remove CRASH() calls added by r76575 and re-label ones added by r80155
1282 and r80269 as being associated with bug 56124 (which may still be
1283 happening).
1284
1285 * css/CSSImageValue.cpp:
1286 (WebCore::CSSImageValue::cachedImage):
1287 * css/CSSSelector.h:
1288 * css/CSSSelectorList.cpp:
1289 (WebCore::CSSSelectorList::deleteSelectors):
1290 * loader/cache/CachedResource.cpp:
1291 (WebCore::CachedResource::CachedResource):
1292 (WebCore::CachedResource::~CachedResource):
1293 * loader/cache/CachedResource.h:
1294
1295 2011-03-10 Tony Gentilcore <tonyg@chromium.org>
1296
1297 Reviewed by Eric Seidel.
1298
1299 Let the parser yield for layout before running scripts
1300 https://bugs.webkit.org/show_bug.cgi?id=54355
1301
1302 Prior to this patch, the parser would yield to perform a layout/paint be fore running a
1303 script only if the script or a stylesheet blocking the script is not loa ded yet. Since we
1304 don't preload scan into the body while parsing the head, typically we'll block on a script
1305 early in the body that causes us to yield to do the first paint within a reasonable time.
1306
1307 However, I'm planning to change the PreloadScanner to scan into the body from the head.
1308 That significantly improves overall load time, but would hurt first pain t time because
1309 fewer scripts would be blocked during parsing and thus wouldn't yield.
1310
1311 This change causes us to yield before running scripts if we haven't pain ted yet (regardless
1312 of whether or not the script is loaded). In addition to allowing the abo ve mentioned
1313 PreloadScanner change to be implemented without regressing first paint t ime, this also
1314 improves first paint time by itself.
1315
1316 I tested Alexa's top 45 websites using Web Page Replay to control the co ntent and simulate
1317 bandwidth. This patch improved average first paint time by 1% over an un limited connection,
1318 6% over a 1Mbps connection and 11% over a 5Mbps connection. There was no statistically
1319 signifcant change in page load time.
1320
1321 Within the pages tested, 33 had no statistically significant change in t ime to first paint,
1322 12 improved, and none regressed. Of the improved, some of the standouts from the 1Mbps set
1323 are: 20% on youtube, 37% on wiki, 27% on ebay, 13% on cnn, 16% on espn, 74% on sohu.
1324
1325 * html/parser/HTMLDocumentParser.cpp:
1326 (WebCore::HTMLDocumentParser::canTakeNextToken): This is the new yield p oint.
1327 (WebCore::HTMLDocumentParser::pumpTokenizer): Remove ASSERT that we are not paused. isPaused
1328 means that we are waiting for a script. Bug 54574 changed pumpTokenizer( ) so that it does
1329 the right thing whether we are just before a token or waiting for a scri pt. Now that we may
1330 yield before a token or before a script, this may be called while paused .
1331 * html/parser/HTMLParserScheduler.cpp:
1332 (WebCore::HTMLParserScheduler::checkForYieldBeforeScript): Added.
1333 * page/FrameView.h:
1334 (WebCore::FrameView::hasEverPainted): Added.
1335
1336 2011-03-10 Alejandro G. Castro <alex@igalia.com>
1337
1338 Reviewed by Martin Robinson.
1339
1340 Some Gtk code uses defined(USE_FREETYPE) instead of just USE(FREETYPE)
1341 https://bugs.webkit.org/show_bug.cgi?id=55996
1342
1343 Use the macre USE instead of defined fro WTF_USE_FREETYPE and
1344 WTF_USE_PANGO.
1345
1346 * GNUmakefile.am:
1347 * platform/graphics/cairo/OwnPtrCairo.cpp:
1348 * platform/graphics/cairo/OwnPtrCairo.h:
1349 * platform/graphics/cairo/RefPtrCairo.cpp:
1350 * platform/graphics/cairo/RefPtrCairo.h:
1351 * platform/graphics/gtk/FontGtk.cpp:
1352 (WebCore::setPangoAttributes):
1353 (WebCore::Font::drawComplexText):
1354 (WebCore::Font::floatWidthForComplexText):
1355 (WebCore::Font::offsetForPositionForComplexText):
1356 (WebCore::Font::selectionRectForComplexText):
1357
1358 2011-03-10 Geoffrey Garen <ggaren@apple.com>
1359
1360 Reviewed by Oliver Hunt.
1361
1362 Rolled back in 80277 and 80280 with event handler layout test failures f ixed.
1363 https://bugs.webkit.org/show_bug.cgi?id=55653
1364
1365 The failures were caused by a last minute typo: assigning to currentEven t
1366 instead of m_currentEvent.
1367
1368 * WebCore.xcodeproj/project.pbxproj:
1369 * bindings/js/JSDOMGlobalObject.cpp:
1370 * bindings/js/JSDOMGlobalObject.h:
1371 * bindings/js/JSDOMWindowBase.cpp:
1372 * bindings/js/JSDOMWindowBase.h:
1373 * bindings/js/JSDOMWindowCustom.h:
1374 * bindings/js/JSWorkerContextBase.cpp:
1375
1376 2011-03-10 David Hyatt <hyatt@apple.com>
1377
1378 Reviewed by Dan Bernstein.
1379
1380 https://bugs.webkit.org/show_bug.cgi?id=56129, vertical text broken on L ion and Leopard.
1381
1382 Add Snow Leopard ifdefs for the scaling by point size and then the divis ion by unitsPerEm to the
1383 translationsTransform applied to the results from CTFontGetVerticalTrans lationsForGlyphs, since
1384 this is done already on Lion and Leopard.
1385
1386 * platform/graphics/mac/FontMac.mm:
1387 (WebCore::showGlyphsWithAdvances):
1388
1389 2011-03-10 Sheriff Bot <webkit.review.bot@gmail.com>
1390
1391 Unreviewed, rolling out r80701.
1392 http://trac.webkit.org/changeset/80701
1393 https://bugs.webkit.org/show_bug.cgi?id=56126
1394
1395 fast/dom/Geolocation/window-close-crash.html fails on Snow
1396 Leopard release builds (Requested by mihaip on #webkit).
1397
1398 * page/DOMWindow.cpp:
1399 * page/DOMWindow.h:
1400 * page/Frame.cpp:
1401 (WebCore::Frame::pageDestroyed):
1402 (WebCore::Frame::transferChildFrameToNewDocument):
1403 * page/Geolocation.cpp:
1404 (WebCore::Geolocation::~Geolocation):
1405 (WebCore::Geolocation::disconnectFrame):
1406 (WebCore::Geolocation::lastPosition):
1407 (WebCore::Geolocation::requestPermission):
1408 (WebCore::Geolocation::startUpdating):
1409 (WebCore::Geolocation::stopUpdating):
1410 * page/Geolocation.h:
1411 * page/GeolocationController.cpp:
1412 (WebCore::GeolocationController::~GeolocationController):
1413 * page/Navigator.cpp:
1414 * page/Navigator.h:
1415 * platform/mock/GeolocationClientMock.cpp:
1416 * platform/mock/GeolocationClientMock.h:
1417
1418 2011-03-10 Pratik Solanki <psolanki@apple.com>
1419
1420 Reviewed by Alexey Proskuryakov.
1421
1422 ASSERT_NOT_REACHED triggered in WebCore::mapHTTPPipeliningPriorityToReso urceLoadPriority
1423 https://bugs.webkit.org/show_bug.cgi?id=56075
1424
1425 Map priority value 3, which means no priority, to ResourceLoadPriorityUn resolved.
1426
1427 * platform/network/cf/ResourceRequestCFNet.h:
1428 (WebCore::mapHTTPPipeliningPriorityToResourceLoadPriority):
1429 (WebCore::mapResourceLoadPriorityToHTTPPipeliningPriority):
1430
1431 2011-03-10 Andrey Adaikin <aandrey@google.com>
1432
1433 Reviewed by Pavel Feldman.
1434
1435 Web Inspector: [Text editor] Substitute live-edit mode activation by dou ble-click
1436 https://bugs.webkit.org/show_bug.cgi?id=56084
1437
1438 Also fixed a regression: console was not opening/closing on ESC key pres s because tabIndex="0" attribute was preserved for a readOnly viewer.
1439
1440 * inspector/front-end/SourceFrame.js:
1441 (WebInspector.SourceFrame):
1442 (WebInspector.SourceFrame.prototype._startEditing):
1443 (WebInspector.SourceFrame.prototype._registerShortcuts):
1444 (WebInspector.SourceFrame.prototype._handleKeyDown):
1445 (WebInspector.SourceFrame.prototype._handleSave):
1446 (WebInspector.SourceFrame.prototype._handleRevertEditing):
1447 (WebInspector.SourceFrame.prototype._doubleClick):
1448 * inspector/front-end/TextEditorModel.js:
1449 (WebInspector.TextEditorModel.prototype.get text):
1450 * inspector/front-end/TextViewer.js:
1451 (WebInspector.TextViewer.prototype.get readOnly):
1452 (WebInspector.TextEditorMainPanel):
1453 (WebInspector.TextEditorMainPanel.prototype.set readOnly):
1454 (WebInspector.TextEditorMainPanel.prototype.get readOnly):
1455
1456 2011-03-10 Greg Simon <gregsimon@chromium.org>
1457
1458 Reviewed by Pavel Feldman.
1459
1460 Web Inspector: Need new graphic icon for garbage collect button.
1461 https://bugs.webkit.org/show_bug.cgi?id=55794
1462
1463 No new tests: gc tests are flaky due to non-determinisic
1464 behavior of collection APIs (more notes in bug)
1465
1466 * English.lproj/localizedStrings.js:
1467 * WebCore.gypi:
1468 * bindings/js/ScriptProfiler.cpp:
1469 (WebCore::ScriptProfiler::collectGarbage):
1470 * bindings/js/ScriptProfiler.h:
1471 * bindings/v8/ScriptProfiler.cpp:
1472 (WebCore::ScriptProfiler::collectGarbage):
1473 * bindings/v8/ScriptProfiler.h:
1474 * inspector/Inspector.idl:
1475 * inspector/InspectorProfilerAgent.cpp:
1476 (WebCore::InspectorProfilerAgent::collectGarbage):
1477 * inspector/InspectorProfilerAgent.h:
1478 * inspector/front-end/Images/garbageCollectButtonGlyph.png: Added.
1479 * inspector/front-end/TimelinePanel.js:
1480 (WebInspector.TimelinePanel.prototype.get statusBarItems):
1481 (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
1482 (WebInspector.TimelinePanel.prototype._garbageCollectButtonClicked):
1483 * inspector/front-end/inspector.css:
1484 (.garbage-collect-status-bar-item .glyph):
1485
1486 2011-03-10 Andrey Kosyakov <caseq@chromium.org>
1487
1488 Web Inspector: better names for HAR export commands
1489 https://bugs.webkit.org/show_bug.cgi?id=56097
1490
1491 Rename Export to HAR to Copy entry/network log as HAR
1492 Expose Copy as HAR unconditionally, remove related settings entry.
1493
1494 * English.lproj/localizedStrings.js:
1495 * inspector/front-end/NetworkPanel.js:
1496 (WebInspector.NetworkPanel.prototype._contextMenu):
1497 * inspector/front-end/Settings.js:
1498
1499 2011-03-10 Qi Zhang <qi.2.zhang@nokia.com>
1500
1501 Reviewed by Laszlo Gombos.
1502
1503 [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
1504 https://bugs.webkit.org/show_bug.cgi?id=48636
1505
1506 Fix a typo in features.pri that turns on this feature on mobile
1507 devices by default.
1508
1509 * features.pri:
1510
1511 2011-03-10 Alexander Pavlov <apavlov@chromium.org>
1512
1513 Reviewed by Pavel Feldman.
1514
1515 Web Inspector: Invalid expected parameter list in CSSAgent.setSelectorTe xt() callback (CSSStyleModel.js)
1516 https://bugs.webkit.org/show_bug.cgi?id=56092
1517
1518 * inspector/front-end/CSSStyleModel.js:
1519 (WebInspector.CSSStyleModel.prototype.setRuleSelector):
1520
1521 2011-03-10 Pavel Feldman <pfeldman@chromium.org>
1522
1523 Not reviewed: rolling out r80478 and its follow ups for breaking
1524 inspector and engadget.com.
1525 https://bugs.webkit.org/show_bug.cgi?id=49401
1526
1527 * dom/Document.cpp:
1528 (WebCore::Document::Document):
1529 (WebCore::performTask):
1530 (WebCore::Document::postTask):
1531 * dom/Document.h:
1532 * loader/FrameLoader.cpp:
1533 (WebCore::FrameLoader::setDefersLoading):
1534 * manual-tests/database-callback-deferred.html: Removed.
1535 * page/PageGroupLoadDeferrer.cpp:
1536 (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
1537 (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
1538
1539 2011-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1540
1541 Reviewed by Kenneth Rohde Christiansen.
1542
1543 Tiled backing store's delegated scroll request uses incorrect convention
1544 https://bugs.webkit.org/show_bug.cgi?id=56011
1545
1546 Use a point instead of delta, when relaying the scroll request from
1547 ScrollView::setScrollPosition.
1548
1549 * loader/EmptyClients.h:
1550 (WebCore::EmptyChromeClient::delegatedScrollRequested):
1551 * page/Chrome.cpp:
1552 (WebCore::Chrome::delegatedScrollRequested):
1553 * page/Chrome.h:
1554 * page/ChromeClient.h:
1555 * platform/HostWindow.h:
1556 * platform/ScrollView.cpp:
1557 (WebCore::ScrollView::setScrollPosition):
1558
1559 2011-03-10 Pavel Feldman <pfeldman@chromium.org>
1560
1561 Reviewed by Yury Semikhatsky.
1562
1563 Web Inspector: brush up DOM agent API.
1564 https://bugs.webkit.org/show_bug.cgi?id=56093
1565
1566 * inspector/Inspector.idl:
1567 * inspector/InspectorDOMAgent.cpp:
1568 (WebCore::InspectorDOMAgent::childNodes):
1569 (WebCore::InspectorDOMAgent::setNodeName):
1570 (WebCore::InspectorDOMAgent::outerHTML):
1571 (WebCore::InspectorDOMAgent::setNodeValue):
1572 * inspector/InspectorDOMAgent.h:
1573 * inspector/front-end/DOMAgent.js:
1574 (WebInspector.DOMNode):
1575 (WebInspector.DOMNode.prototype.hasAttributes):
1576 (WebInspector.DOMNode.prototype.nodeType):
1577 (WebInspector.DOMNode.prototype.nodeName):
1578 (WebInspector.DOMNode.prototype.setNodeName):
1579 (WebInspector.DOMNode.prototype.localName):
1580 (WebInspector.DOMNode.prototype.nodeValue):
1581 (WebInspector.DOMNode.prototype.setNodeValue):
1582 (WebInspector.DOMNode.prototype.setAttribute):
1583 (WebInspector.DOMNode.prototype.attributes):
1584 (WebInspector.DOMNode.prototype.removeAttribute):
1585 (WebInspector.DOMNode.prototype.childNodes.mycallback):
1586 (WebInspector.DOMNode.prototype.childNodes):
1587 (WebInspector.DOMNode.prototype.outerHTML):
1588 (WebInspector.DOMNode.prototype.setOuterHTML):
1589 (WebInspector.DOMNode.prototype.removeNode):
1590 (WebInspector.DOMNode.prototype.copyNode):
1591 (WebInspector.DOMNode.prototype.path):
1592 (WebInspector.DOMNode.prototype._setAttributesPayload):
1593 (WebInspector.DOMNode.prototype._addAttribute):
1594 (WebInspector.DOMAgent.prototype._characterDataModified):
1595 * inspector/front-end/ElementsPanel.js:
1596 (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
1597 (WebInspector.ElementsPanel.prototype.decorateNodeLabel):
1598 (WebInspector.ElementsPanel.prototype.handleCopyEvent):
1599 * inspector/front-end/ElementsTreeOutline.js:
1600 (WebInspector.ElementsTreeOutline.prototype.findTreeElement):
1601 (WebInspector.ElementsTreeElement):
1602 (WebInspector.ElementsTreeElement.prototype.updateChildren):
1603 (WebInspector.ElementsTreeElement.prototype._updateChildren):
1604 (WebInspector.ElementsTreeElement.prototype._startEditingTarget):
1605 (WebInspector.ElementsTreeElement.prototype._startEditing):
1606 (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
1607 (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.mov eToNextAttributeIfNeeded):
1608 (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
1609 (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted):
1610 (WebInspector.ElementsTreeElement.prototype._attributeHTML):
1611 ():
1612 * inspector/front-end/EventListenersSidebarPane.js:
1613 ():
1614 * inspector/front-end/MetricsSidebarPane.js:
1615 * inspector/front-end/StylesSidebarPane.js:
1616 * inspector/front-end/utilities.js:
1617
1618 2011-03-09 Alexander Pavlov <apavlov@chromium.org>
1619
1620 Reviewed by Pavel Feldman.
1621
1622 Web Inspector: [STYLES] Editing a property value adds a word for any pro perty value that uses a paren
1623 https://bugs.webkit.org/show_bug.cgi?id=56002
1624
1625 * inspector/front-end/StylesSidebarPane.js: Introduce an additional chec k.
1626
1627 2011-03-09 Pavel Podivilov <podivilov@chromium.org>
1628
1629 Reviewed by Pavel Feldman.
1630
1631 Web Inspector: use DebuggerPresentation instead of DebuggerModel in sour ce frame delegate.
1632 https://bugs.webkit.org/show_bug.cgi?id=56034
1633
1634 * inspector/front-end/DebuggerPresentationModel.js:
1635 (WebInspector.DebuggerPresentationModel.prototype.continueToLine):
1636 (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
1637 (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
1638 (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
1639 (WebInspector.DebuggerPresentationModel.prototype._sourceLocationToActua lLocation):
1640 * inspector/front-end/ScriptsPanel.js:
1641 (WebInspector.ScriptsPanel.prototype._createSourceFrame):
1642 (WebInspector.SourceFrameDelegateForScriptsPanel):
1643 (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint ):
1644 (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpo int):
1645 (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpo int):
1646 (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoin t):
1647 (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLin e):
1648 * inspector/front-end/SourceFrame.js:
1649 (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCond ition.didEditBreakpointCondition):
1650 (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCond ition):
1651 (WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabl ed):
1652 (WebInspector.SourceFrame.prototype._contextMenu):
1653 (WebInspector.SourceFrame.prototype._mouseDown):
1654 (WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
1655 (WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
1656
1657 2011-03-09 Alexander Pavlov <apavlov@chromium.org>
1658
1659 Reviewed by Pavel Feldman.
1660
1661 Web Inspector: elements dom tree - word wrap toggle
1662 https://bugs.webkit.org/show_bug.cgi?id=44311
1663
1664 A "Word Wrap" option is now shown in a context menu for the entire DOM t ree content area
1665 and persisted into application settings.
1666
1667 * English.lproj/localizedStrings.js:
1668 * inspector/front-end/ElementsPanel.js:
1669 (WebInspector.ElementsPanel.prototype._contextMenuEventFired):
1670 (WebInspector.ElementsPanel.prototype._contextMenuEventFired.toggleWordW rap):
1671 * inspector/front-end/ElementsTreeOutline.js:
1672 (WebInspector.ElementsTreeOutline):
1673 (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
1674 (WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
1675 (WebInspector.ElementsTreeElement.prototype.onreveal):
1676 * inspector/front-end/Settings.js:
1677 (WebInspector.Settings):
1678 * inspector/front-end/inspector.css:
1679 (#elements-content.nowrap):
1680 (#elements-content > ol):
1681
1682 2011-03-09 Pavel Podivilov <podivilov@chromium.org>
1683
1684 Reviewed by Pavel Feldman.
1685
1686 Web Inspector: re-implement breakpoints sidebar pane based on debugger p resentation model.
1687 https://bugs.webkit.org/show_bug.cgi?id=55823
1688
1689 * inspector/front-end/BreakpointsSidebarPane.js:
1690 (WebInspector.JavaScriptBreakpointsSidebarPane):
1691 (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint.d idLoadSnippet):
1692 (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):
1693 (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.removeBreakpoin t):
1694 (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.highlightBreakp oint):
1695 (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.clearBreakpoint Highlight):
1696 (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._createBreakpoi ntItemId):
1697 (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointClic ked):
1698 (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointChec kboxClicked):
1699 (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenu):
1700 (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.reset):
1701 * inspector/front-end/DebuggerPresentationModel.js:
1702 (WebInspector.DebuggerPresentationModel):
1703 (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
1704 (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSo urce):
1705 (WebInspector.DebuggerPresentationModel.prototype._revealHiddenBreakpoin ts):
1706 (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFi leId):
1707 (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
1708 (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
1709 (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
1710 (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame) :
1711 (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourc eLocation):
1712 (WebInspector.DebuggerPresentationModel.prototype.reset):
1713 * inspector/front-end/ScriptsPanel.js:
1714 (WebInspector.ScriptsPanel):
1715 (WebInspector.ScriptsPanel.prototype._breakpointAdded):
1716 (WebInspector.ScriptsPanel.prototype._breakpointRemoved):
1717 (WebInspector.ScriptsPanel.prototype._debuggerPaused):
1718 (WebInspector.ScriptsPanel.prototype.reset):
1719 (WebInspector.ScriptsPanel.prototype._clearInterface):
1720
1721 2011-03-10 Andrey Adaikin <aandrey@google.com>
1722
1723 Reviewed by Pavel Feldman.
1724
1725 Web Inspector: Highlighter refactoring
1726 https://bugs.webkit.org/show_bug.cgi?id=56015
1727
1728 * inspector/front-end/TextEditorHighlighter.js:
1729 (WebInspector.TextEditorHighlighter):
1730 (WebInspector.TextEditorHighlighter.prototype.set mimeType):
1731 (WebInspector.TextEditorHighlighter.prototype.highlight):
1732 (WebInspector.TextEditorHighlighter.prototype.updateHighlight):
1733 (WebInspector.TextEditorHighlighter.prototype._highlightInChunks):
1734 (WebInspector.TextEditorHighlighter.prototype._highlightLines):
1735 (WebInspector.TextEditorHighlighter.prototype._selectHighlightState):
1736 (WebInspector.TextEditorHighlighter.prototype._clearHighlightState):
1737 * inspector/front-end/TextViewer.js:
1738 (WebInspector.TextEditorMainPanel.prototype._buildChunks):
1739 (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
1740
1741 2011-03-05 Pavel Podivilov <podivilov@chromium.org>
1742
1743 Reviewed by Pavel Feldman.
1744
1745 Web Inspector: move breakpoint column adjustment to debugger model.
1746 https://bugs.webkit.org/show_bug.cgi?id=55821
1747
1748 Test: inspector/debugger/debug-inlined-scripts.html
1749
1750 * inspector/front-end/DebuggerModel.js:
1751 (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
1752 (WebInspector.DebuggerModel.prototype.setBreakpoint):
1753 * inspector/front-end/SourceFrameContent.js:
1754 (WebInspector.SourceFrameContent.prototype.sourceFrameLineNumberToActual Location):
1755
1756 2011-01-21 John Knottenbelt <jknotten@chromium.org>
1757
1758 Reviewed by Dmitry Titov.
1759
1760 Detach Geolocation from Frame when Page destroyed.
1761 https://bugs.webkit.org/show_bug.cgi?id=52877
1762
1763 On Page destruction, any outstanding Geolocation permission
1764 requests should be cancelled, because the Geolocation can only
1765 access the client indirectly via m_frame->page().
1766
1767 Page destruction is signalled by a call to the
1768 Frame::pageDestroyed() method. This explictly calls
1769 DOMWindow::resetGeolocation which ultimately calls Geolocation::reset.
1770
1771 Geolocation::reset() detaches from the GeolocationController,
1772 cancels requests, watches and single shots, and sets the
1773 permission state back to Unknown.
1774
1775 Frame::pageDestroyed() is also called by FrameLoader even though
1776 the page is not destroyed. We should still cancel permission
1777 requests, because the GeolocationClient will become inaccessible
1778 to the Geolocation object after this call.
1779
1780 Frame::transferChildFrameToNewDocument also indirectly calls
1781 Geolocation::reset when the frame is reparented between
1782 pages. Ideally we would like the Geolocation's activities to
1783 continue after reparenting, see bug
1784 https://bugs.webkit.org/show_bug.cgi?id=55577
1785
1786 Since GeolocationController is owned by Page, and all Geolocation
1787 objects will now unsubscribe from the GeolocationController on
1788 pageDetached(), we no longer need to call stopUpdating() from the
1789 GeolocationController's destructor. Instead we can simply assert
1790 that there should be no no observers. See related bug
1791 https://bugs.webkit.org/show_bug.cgi?id=52216 .
1792
1793 Introduced new method 'numberOfPendingPermissionRequests' on
1794 GeolocationClientMock to count the number of outstanding pending
1795 permission requests. This provides a reusable implementation for
1796 client-based implementations of the LayoutTestController's
1797 numberOfPendingGeolocationPermissionRequests method.
1798
1799 Test: fast/dom/Geolocation/page-reload-cancel-permission-requests.html
1800
1801 * page/DOMWindow.cpp:
1802 (WebCore::DOMWindow::resetGeolocation):
1803 * page/DOMWindow.h:
1804 * page/Frame.cpp:
1805 (WebCore::Frame::pageDestroyed):
1806 (WebCore::Frame::transferChildFrameToNewDocument):
1807 * page/Geolocation.cpp:
1808 (WebCore::Geolocation::~Geolocation):
1809 (WebCore::Geolocation::page):
1810 (WebCore::Geolocation::reset):
1811 (WebCore::Geolocation::disconnectFrame):
1812 (WebCore::Geolocation::lastPosition):
1813 (WebCore::Geolocation::requestPermission):
1814 (WebCore::Geolocation::startUpdating):
1815 (WebCore::Geolocation::stopUpdating):
1816 * page/Geolocation.h:
1817 * page/GeolocationController.cpp:
1818 (WebCore::GeolocationController::~GeolocationController):
1819 * page/Navigator.cpp:
1820 (WebCore::Navigator::resetGeolocation):
1821 * page/Navigator.h:
1822 * platform/mock/GeolocationClientMock.cpp:
1823 (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
1824 * platform/mock/GeolocationClientMock.h:
1825
1826 2011-03-10 Ojan Vafai <ojan@chromium.org>
1827
1828 Reviewed by Darin Adler.
1829
1830 Able to move nodes across documents
1831 https://bugs.webkit.org/show_bug.cgi?id=19524
1832
1833 Makes cross-document appendChild, insertBefore, Range.insertNode and Ran ge.surroundContents work.
1834 This matches Gecko and the new Dom Core spec. There are a number of Rang e methods where we don't
1835 match Gecko or the spec that will need to be updated in a following patc h.
1836
1837 Test: fast/dom/move-nodes-across-documents.html
1838
1839 * dom/Element.cpp:
1840 (WebCore::Element::removeAttributeNode):
1841 * dom/NamedNodeMap.cpp:
1842 (WebCore::NamedNodeMap::setNamedItem):
1843 * dom/Node.cpp:
1844 (WebCore::Node::setDocumentRecursively):
1845 (WebCore::checkAcceptChild):
1846 (WebCore::Node::checkReplaceChild):
1847 * dom/Range.cpp:
1848 (WebCore::Range::insertNode):
1849 (WebCore::Range::surroundContents):
1850
1851 2011-03-09 Antti Koivisto <antti@apple.com>
1852
1853 Not reviewed.
1854
1855 Reverting crash catching code, the bug being hunted was fixed by
1856 http://trac.webkit.org/changeset/80686
1857
1858 * loader/cache/CachedResourceLoader.cpp:
1859 (WebCore::CachedResourceLoader::CachedResourceLoader):
1860 (WebCore::CachedResourceLoader::~CachedResourceLoader):
1861 (WebCore::CachedResourceLoader::requestImage):
1862 (WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
1863 (WebCore::CachedResourceLoader::requestResource):
1864 (WebCore::CachedResourceLoader::setAutoLoadImages):
1865 (WebCore::CachedResourceLoader::load):
1866 (WebCore::CachedResourceLoader::loadDone):
1867 (WebCore::CachedResourceLoader::preload):
1868 (WebCore::CachedResourceLoader::requestPreload):
1869 * loader/cache/CachedResourceLoader.h:
1870
1871 2011-03-09 Peter Kasting <pkasting@google.com>
1872
1873 Unreviewed, build fix.
1874
1875 * StringsNotToBeLocalized.txt: Add function names I forgot.
1876 * platform/win/SystemInfo.cpp: #if out some uncalled functions on WinCE,
1877 since they don't compile anyway. Use ZeroMemory() instead of "= {0}"
1878 since Qt is stupid and (sometimes?!) warns about it.
1879 (WebCore::windowsVersion):
1880 (WebCore::processorArchitecture):
1881
1882 2011-03-09 Peter Kasting <pkasting@google.com>
1883
1884 Reviewed by Ryosuke Niwa.
1885
1886 Add UA string tags for Windows 64.
1887 https://bugs.webkit.org/show_bug.cgi?id=55226
1888
1889 * StringsNotToBeLocalized.txt:
1890 * platform/win/SystemInfo.cpp:
1891 (WebCore::osVersionForUAString):
1892 (WebCore::isWOW64):
1893 (WebCore::processorArchitecture):
1894 (WebCore::architectureTokenForUAString):
1895 (WebCore::windowsVersionForUAString):
1896
1897 2011-03-09 Peter Kasting <pkasting@google.com>
1898
1899 Unreviewed, attempted build fix.
1900
1901 * WebCore.pri: Try to update include path for Qt Windows build.
1902
1903 2011-03-09 Peter Kasting <pkasting@google.com>
1904
1905 Unreviewed, build fix.
1906
1907 * platform/win/SystemInfo.cpp:
1908 (WebCore::windowsVersionForUAString): Fix const conversion warning on Qt .
1909
1910 2011-03-09 Peter Kasting <pkasting@google.com>
1911
1912 Reviewed by Mihai Parparita.
1913
1914 Unify Windows version checks.
1915 https://bugs.webkit.org/show_bug.cgi?id=55979
1916
1917 * GNUmakefile.am: Fix spaces -> tabs.
1918 * StringsNotToBeLocalized.txt:
1919 * WebCore.pro: Add SystemInfo.* to Qt build.
1920 * platform/chromium/ScrollbarThemeChromiumWin.cpp:
1921 (WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
1922 (WebCore::ScrollbarThemeChromiumWin::getThemeState):
1923 (WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
1924 * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
1925 (WebCore::fillBMPGlyphs):
1926 * platform/win/CursorWin.cpp:
1927 (WebCore::createSharedCursor):
1928 * platform/win/ScrollbarThemeWin.cpp:
1929 (WebCore::ScrollbarThemeWin::ScrollbarThemeWin):
1930 * platform/win/SystemInfo.cpp: Add full-fledged version check and UA str ing helper function.
1931 (WebCore::windowsVersion):
1932 (WebCore::windowsVersionForUAString):
1933 * platform/win/SystemInfo.h: Add full-fledged version check and UA strin g helper function.
1934 * rendering/RenderThemeChromiumWin.cpp:
1935 (WebCore::getNonClientMetrics):
1936 * rendering/RenderThemeWin.cpp:
1937 (WebCore::RenderThemeWin::getThemeData):
1938 (WebCore::RenderThemeWin::paintMenuList):
1939 (WebCore::RenderThemeWin::paintMenuListButton):
1940
1941 2011-03-09 Mihai Parparita <mihaip@chromium.org>
1942
1943 Reviewed by Tony Gentilcore.
1944
1945 REGRESSION (r74807): memory corruption after CachedResourceLoader refact oring
1946 https://bugs.webkit.org/show_bug.cgi?id=53045
1947
1948 Copy the URL out of the CachedResource that is being revalidated, so
1949 that we can still use it (in m_validatedURLs) after removing the
1950 resource from the memory cache, which may delete it.
1951
1952 No new tests, since I was not able to trigger this locally (in a layout
1953 test or otherwise).
1954
1955 * loader/cache/CachedResourceLoader.cpp:
1956 (WebCore::CachedResourceLoader::revalidateResource):
1957
1958 2011-03-09 Chris Fleizach <cfleizach@apple.com>
1959
1960 Reviewed by Beth Dakin.
1961
1962 VO reporting incorrect list count for http://www.macworld.com/news.html
1963 https://bugs.webkit.org/show_bug.cgi?id=56064
1964
1965 <li> tags should not be ignored, because they provide valuable informati on
1966 to screen readers.
1967
1968 Test: platform/mac/accessibility/list-items-ignored.html
1969
1970 * accessibility/AccessibilityRenderObject.cpp:
1971 (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
1972
1973 2011-03-09 Dan Bernstein <mitz@apple.com>
1974
1975 Reviewed by Dave Hyatt.
1976
1977 <rdar://problem/8733254> Float disappears after incremental layout
1978 Fixed the original bug and a copule more issues noticed while doing so.
1979
1980 Tests: fast/dynamic/dirty-float-in-clean-line.html
1981 fast/dynamic/float-at-line-break.html
1982 fast/dynamic/float-from-empty-line.html
1983
1984 * rendering/RenderBlock.h:
1985 * rendering/RenderBlockLineLayout.cpp:
1986 (WebCore::RenderBlock::layoutInlineChildren): If findNextLineBreak() ret urned an empty line,
1987 update the line break info of the last line with the new line break posi tion. This is tested
1988 by float-from-empty-line.html.
1989 (WebCore::RenderBlock::checkFloatsInCleanLine): Factored out code from d etermineStartPosition()
1990 into this new function.
1991 (WebCore::RenderBlock::determineStartPosition): Call checkFloatsInCleanL ine().
1992 (WebCore::RenderBlock::determineEndPosition): When iterating over lines, check clean lines with
1993 floats, as they may yet become dirty because of the floats. This is test ed by
1994 dirty-float-in-clean-line.html.
1995 (WebCore::RenderBlock::findNextLineBreak): If a float fits on the line, and the current line
1996 break is at the float, advance it to after the float. Otherwise, if the line gets dirty and the
1997 next one does not, the float will not make it into any line. This is tes ted by
1998 float-at-line-break.html.
1999
2000 2011-03-09 Ryosuke Niwa <rniwa@webkit.org>
2001
2002 Reviewed by Kent Tamura.
2003
2004 selectionStart reports wrong caret position when the last characters are newlines
2005 https://bugs.webkit.org/show_bug.cgi?id=56061
2006
2007 The bug was caused by SelectionController::setSelection's not calling
2008 notifyRendererOfSelectionChange when old selection was equal to new sele ction.
2009
2010 Because InsertLineBreakCommand inserts a text node with a single LF befo re the caret,
2011 this condition holds after the command is executed. However, the values of
2012 selectionStart and selectionEnd still need to be updated in this case be cause
2013 the offsets counted from the beginning of textarea have been increased b y 1.
2014
2015 * editing/SelectionController.cpp:
2016 (WebCore::SelectionController::setSelection): Call notifyRendererOfSelec tionChange
2017 when m_selection = s.
2018 * manual-tests/selection-start-after-inserting-line-break-in-textarea.ht ml: Added.
2019
2020 2011-03-09 Andy Estes <aestes@apple.com>
2021
2022 Reviewed by Adam Barth.
2023
2024 Bad cast in HTMLTreeBuilder::processStartTag
2025 https://bugs.webkit.org/show_bug.cgi?id=55955
2026
2027 Test: fast/parser/self-closing-foreign-content.html
2028
2029 When the parser encounters an svg or mathml root element, it places the
2030 insertion mode into InForeignContentMode. However, if the root element
2031 is self-closing (e.g. <svg />) then the element is never placed on the
2032 open elements stack. This leaves the parser in an inconsistent state
2033 where it is in InForeignContentMode but no foreign content is in the
2034 open element stack.
2035
2036 * html/parser/HTMLTreeBuilder.cpp:
2037 (WebCore::HTMLTreeBuilder::processStartTagForInBody): If a self-closing
2038 foreign element is inserted into the tree, do not set the insertion
2039 mode to InForeignContentMode.
2040
2041 2011-03-09 Gavin Barraclough <barraclough@apple.com>
2042
2043 Qt build fix.
2044
2045 * bridge/qt/qt_runtime.cpp:
2046 (JSC::Bindings::convertQVariantToValue):
2047
2048 2011-03-09 Andy Estes <aestes@apple.com>
2049
2050 Reviewed by Adam Barth.
2051
2052 REGRESSION (r80320): Assertion failure when processing mis-nested foreig n content.
2053 https://bugs.webkit.org/show_bug.cgi?id=55982
2054
2055 Test: fast/parser/fragment-foreign-content-misnested.html
2056
2057 It is a parse error to encounter certain start tags while the parser's
2058 insertion mode is InForeignContentMode (e.g. <br>). In these cases, we
2059 are to pop open elements off the HTMLElementStack until a foreign
2060 content scope marker is encountered. Before the change in r80320 to not
2061 insert a fake HTML element during fragment parsing, said fake HTML
2062 element counted as a foreign content scope marker.
2063
2064 With r80320, no fake HTML element is inserted and the stack is popped
2065 until empty in cases where no other element claims to be a foreign
2066 content scope marker. Fix this by treating the DocumentFragment as a
2067 foreign content scope marker.
2068
2069 * html/parser/HTMLElementStack.cpp:
2070 (WebCore::HTMLNames::isForeignContentScopeMarker): Take a
2071 ContainerNode* instead of a Element*.
2072 (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker): Pass
2073 topNode() to isForeignContentScopeMarker() instead of top().
2074
2075 2011-03-09 Gavin Barraclough <barraclough@apple.com>
2076
2077 Reviewed by Darin Adler.
2078
2079 Bug 56041 - RexExp constructor should only accept flags "gim"
2080 We also should be passing the flags around as a bitfield rather than a s tring,
2081 and should not have redundant, incompatible code for converting the stri ng to a bitfield!
2082
2083 * bindings/js/SerializedScriptValue.cpp:
2084 (WebCore::CloneDeserializer::readTerminal):
2085 - Need to parse flags string back to enum.
2086
2087 2011-03-09 James Robinson <jamesr@chromium.org>
2088
2089 Reviewed by Kenneth Russell.
2090
2091 [chromium]: Regression - Explicitly copy compositing properties from Lay erChromium to CCLayerImpl
2092 https://bugs.webkit.org/show_bug.cgi?id=56021
2093
2094 Initializes the m_doubleSided flag of LayerChromiums to the default
2095 value of true so the back sides of layers without
2096 backface-visibility:hidden are rendered.
2097
2098 Test: compositing/backface-visibility.html
2099
2100 * platform/graphics/chromium/LayerChromium.cpp:
2101 (WebCore::LayerChromium::LayerChromium):
2102
2103 2011-03-09 David Hyatt <hyatt@apple.com>
2104
2105 Reviewed by Dan Bernstein.
2106
2107 <rdar://problem/9110316> REGRESSION: 'ex' unit broken for vertical text
2108
2109 Fall back to the verticalRightOrientation data when obtaining the x-heig ht for vertically oriented
2110 text. That way we use the same metrics as for horizontal.
2111
2112 This fixes regressions in fast/lists and fast/overflow vertical text tes ts.
2113
2114 * platform/graphics/mac/SimpleFontDataMac.mm:
2115 (WebCore::SimpleFontData::platformInit):
2116 (WebCore::SimpleFontData::platformBoundsForGlyph):
2117
2118 2011-03-09 Ryosuke Niwa <rniwa@webkit.org>
2119
2120 Reviewed by Tony Chang.
2121
2122 REGRESSION: crash in nextLinePosition when extending selection forward b y line in an empty document
2123 https://bugs.webkit.org/show_bug.cgi?id=56004
2124
2125 The crash was caused by the false assumption that rootEditableElement() or documentElement()
2126 always return non-null pointer. Fixed the bug by adding an early exit.
2127
2128 Test: editing/selection/extend-by-line-in-empty-document.html
2129
2130 * editing/visible_units.cpp:
2131 (WebCore::previousLinePosition):
2132 (WebCore::nextLinePosition):
2133
2134 2011-03-09 Pavel Podivilov <podivilov@chromium.org>
2135
2136 Reviewed by Pavel Feldman.
2137
2138 Web Inspector: it should be possible to copy stack trace from call stack sidebar pane.
2139 https://bugs.webkit.org/show_bug.cgi?id=56024
2140
2141 * English.lproj/localizedStrings.js:
2142 * inspector/front-end/CallStackSidebarPane.js:
2143 (WebInspector.CallStackSidebarPane):
2144 (WebInspector.CallStackSidebarPane.prototype.update):
2145 (WebInspector.CallStackSidebarPane.prototype._contextMenu):
2146
2147 2011-03-09 David Hyatt <hyatt@apple.com>
2148
2149 Reviewed by Darin Adler.
2150
2151 Patch FontPlatformDataLinux to properly initialize and copy orientation/ text-orientation in all
2152 places. Make sure text-orientation is specified in the lookups/creation in FontCustomPlatformData
2153 and FontCache.
2154
2155 * platform/graphics/chromium/FontPlatformDataLinux.cpp:
2156 (WebCore::FontPlatformData::FontPlatformData):
2157 * platform/graphics/chromium/FontPlatformDataLinux.h:
2158 (WebCore::FontPlatformData::FontPlatformData):
2159
2160 2011-03-09 Steve Block <steveblock@google.com>
2161
2162 Reviewed by Jeremy Orlow.
2163
2164 JavaNPObject should not use JNI directly
2165 https://bugs.webkit.org/show_bug.cgi?id=56009
2166
2167 We move the JNI code to access a Java object's fields into
2168 a new JavaInstance::getField() method.
2169
2170 No new tests, refactoring only.
2171
2172 * bridge/jni/v8/JavaInstanceV8.cpp:
2173 (JavaInstance::getField):
2174 * bridge/jni/v8/JavaInstanceV8.h:
2175 * bridge/jni/v8/JavaNPObjectV8.cpp:
2176 (JSC::Bindings::JavaNPObjectGetProperty):
2177
2178 2011-03-09 Steve Block <steveblock@google.com>
2179
2180 Reviewed by Jeremy Orlow.
2181
2182 NPAPI - jvalue conversion should not be in JavaInstance
2183 https://bugs.webkit.org/show_bug.cgi?id=55967
2184
2185 No new tests, refactoring only.
2186
2187 * bridge/jni/v8/JavaInstanceV8.cpp:
2188 (JavaInstance::invokeMethod):
2189 * bridge/jni/v8/JavaInstanceV8.h:
2190 * bridge/jni/v8/JavaNPObjectV8.cpp:
2191 (JSC::Bindings::JavaNPObjectInvoke):
2192
2193 2011-03-09 Jessie Berlin <jberlin@apple.com>
2194
2195 Reviewed by Adam Roben.
2196
2197 Use the Cookie Storage from the Private Browsing Storage Session directl y
2198 https://bugs.webkit.org/show_bug.cgi?id=55986
2199
2200 * WebCore.exp.in:
2201 * platform/mac/WebCoreSystemInterface.h:
2202 * platform/mac/WebCoreSystemInterface.mm:
2203
2204 * platform/network/mac/CookieStorageMac.mm:
2205 (WebCore::setCookieStoragePrivateBrowsingEnabled):
2206 Just copy the cookie storage from the private browsing storage session.
2207 * platform/network/cf/CookieStorageCFNet.cpp:
2208 (WebCore::setCookieStoragePrivateBrowsingEnabled):
2209 Ditto.
2210
2211 2011-03-09 Andrey Kosyakov <caseq@chromium.org>
2212
2213 Unreviewed. Fixed a crash in InspectorInstrumentation::didReceiveRespons e() when loader is null (broken in r80639)
2214
2215 * inspector/InspectorInstrumentation.cpp:
2216 (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
2217
2218 2011-03-09 Yury Semikhatsky <yurys@chromium.org>
2219
2220 Reviewed by Pavel Feldman.
2221
2222 Web Inspector: pass explicit agent references to InspectorBackendDispatc her
2223 https://bugs.webkit.org/show_bug.cgi?id=55820
2224
2225 * inspector/CodeGeneratorInspector.pm:
2226 * inspector/InspectorController.cpp:
2227 (WebCore::InspectorController::InspectorController):
2228 (WebCore::InspectorController::connectFrontend):
2229 (WebCore::InspectorController::disconnectFrontend):
2230 (WebCore::InspectorController::dispatchMessageFromFrontend):
2231
2232 2011-03-09 Andrey Kosyakov <caseq@chromium.org>
2233
2234 Reviewed by Pavel Feldman.
2235
2236 Web Inspector: resource errors are not reported before front-end is open ed
2237 https://bugs.webkit.org/show_bug.cgi?id=55939
2238
2239 * inspector/InspectorInstrumentation.cpp:
2240 (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
2241 * inspector/InspectorInstrumentation.h:
2242 (WebCore::InspectorInstrumentation::didReceiveResourceResponse):
2243 (WebCore::InspectorInstrumentation::didFailLoading):
2244
2245 2011-03-08 Hans Wennborg <hans@chromium.org>
2246
2247 Reviewed by Jeremy Orlow.
2248
2249 IndexedDB: Add BackingStoreType parameter to IDBFactoryBackendInterface: :open
2250 https://bugs.webkit.org/show_bug.cgi?id=55948
2251
2252 Add a parameter that allows for selection of alternative backing store
2253 implementations.
2254
2255 No new tests: no new functionality.
2256
2257 * storage/IDBFactory.cpp:
2258 (WebCore::IDBFactory::open):
2259 * storage/IDBFactoryBackendImpl.cpp:
2260 (WebCore::IDBFactoryBackendImpl::open):
2261 * storage/IDBFactoryBackendImpl.h:
2262 * storage/IDBFactoryBackendInterface.h:
2263
2264 2011-03-08 Steve Block <steveblock@google.com>
2265
2266 Reviewed by Jeremy Orlow.
2267
2268 Factor out JNI method call to be used by both JSC and V8
2269 https://bugs.webkit.org/show_bug.cgi?id=55966
2270
2271 No new tests, refactoring only.
2272
2273 * bridge/jni/JNIUtility.cpp:
2274 (JSC::Bindings::callJNIMethod):
2275 * bridge/jni/JNIUtility.h:
2276 * bridge/jni/jsc/JavaInstanceJSC.cpp:
2277 (JavaInstance::invokeMethod):
2278 * bridge/jni/v8/JavaInstanceV8.cpp:
2279 (JavaInstance::invokeMethod):
2280
2281 2011-03-09 Andrey Adaikin <aandrey@google.com>
2282
2283 Reviewed by Pavel Feldman.
2284
2285 Web Inspector: [Text editor] Regression in handling DOMNodeInserted/DOMN odeRemoved events
2286 https://bugs.webkit.org/show_bug.cgi?id=55818
2287
2288 * inspector/front-end/TextViewer.js:
2289 (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
2290
2291 2011-03-09 Ilya Tikhonovsky <loislo@chromium.org>
2292
2293 Reviewed by Yury Semikhatsky.
2294
2295 Web Inspector: Web Inspector: we don't need to transfer objectId and has Children for primitive values.
2296 https://bugs.webkit.org/show_bug.cgi?id=55998
2297
2298 * inspector/InjectedScriptSource.js:
2299
2300 2011-03-09 Pavel Feldman <pfeldman@chromium.org>
2301
2302 Reviewed by Yury Semikhatsky.
2303
2304 Web Inspector: watch expressions should show string values in quotes.
2305 https://bugs.webkit.org/show_bug.cgi?id=55846
2306
2307 * inspector/InjectedScriptSource.js:
2308 * inspector/front-end/ObjectPropertiesSection.js:
2309 (WebInspector.ObjectPropertyTreeElement.prototype.update):
2310 * inspector/front-end/RemoteObject.js:
2311 (WebInspector.LocalJSONObject.prototype.get description):
2312 * inspector/front-end/WatchExpressionsSidebarPane.js:
2313 (WebInspector.WatchExpressionsSection.prototype.update):
2314 * inspector/front-end/inspector.css:
2315 (.console-formatted-string, .console-formatted-regexp):
2316
2317 2011-03-09 Pavel Feldman <pfeldman@chromium.org>
2318
2319 Reviewed by Yury Semikhatsky.
2320
2321 Web Inspector: "length" getter is invoked upon console object formatting .
2322 https://bugs.webkit.org/show_bug.cgi?id=55220
2323
2324 * inspector/InjectedScriptSource.js:
2325
2326 2011-03-08 Ilya Tikhonovsky <loislo@chromium.org>
2327
2328 Reviewed by Pavel Feldman.
2329
2330 Web Inspector: remove groupName from objectId.
2331 https://bugs.webkit.org/show_bug.cgi?id=55825
2332
2333 * inspector/InjectedScriptSource.js:
2334
2335 2011-03-08 Xiaomei Ji <xji@chromium.org>
2336
2337 Reviewed by David Hyatt.
2338
2339 Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
2340 https://bugs.webkit.org/show_bug.cgi?id=55077.
2341
2342 Inside ScrollView::calculateOverhangAreasForPainting(), when scroll posi tion
2343 is negative, should include the position value into overhang rectangle's
2344 starting position.
2345
2346 Tests: fast/dom/scroll-reveal-left-overflow.html
2347 fast/dom/scroll-reveal-top-overflow.html
2348
2349 * platform/ScrollView.cpp:
2350 (WebCore::ScrollView::calculateOverhangAreasForPainting):
2351
2352 2011-03-08 Daniel Bates <dbates@rim.com>
2353
2354 Reviewed by Darin Adler.
2355
2356 Add templatized CSSMutableStyleDeclaration::get{ShorthandValue, CommonVa lue, LayeredShorthandValue}()
2357 https://bugs.webkit.org/show_bug.cgi?id=55351
2358
2359 By using some template magic CSSMutableStyleDeclaration::get{ShorthandVa lue, CommonValue, LayeredShorthandValue}()
2360 can be called on an array A without the caller explicitly specifying the size of A.
2361
2362 No functionality was changed. So no new tests.
2363
2364 * css/CSSMutableStyleDeclaration.cpp:
2365 (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Modified to cal l templatized variants of
2366 CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShor thandValue}().
2367 (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Renamed second argument from "number" to "size"
2368 to better reflect its purpose - to be the size of the passed array.
2369 (WebCore::CSSMutableStyleDeclaration::getShorthandValue): Ditto.
2370 (WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto.
2371 (WebCore::CSSMutableStyleDeclaration::cssText): Modified to call templat ized variant of CSSMutableStyleDeclaration::getShorthandValue().
2372 * css/CSSMutableStyleDeclaration.h:
2373 (WebCore::CSSMutableStyleDeclaration::getShorthandValue): Added templati zed function that can determine
2374 the size of a passed array. Changed type of second argument to size_t si nce it represents the size of
2375 an array.
2376 (WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto.
2377 (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Ditto.
2378
2379 2011-03-08 Enrica Casucci <enrica@apple.com>
2380
2381 Reviewed by Darin Adler.
2382
2383 REGRESSION: Copied content loses formatting on paste to external apps.
2384 https://bugs.webkit.org/show_bug.cgi?id=47615
2385 <rdar://problem/9001214>
2386
2387 This is a resubmission of a patch that was landed a while ago then rolle d
2388 back because of a build failure on SnowLeopard and Leopard on the 32-bit builds.
2389
2390 This patch adds a way for WebKit2 to create NSAttributedStrings from
2391 a DOM range without using the AppKit api initWithDOMRange that internall y
2392 needs to access the WebView. The NSAttributedString is needed to create
2393 RTF formats in the pasteboard.
2394 This is to be considered a first step, since in the future we want to ha ve
2395 an implementation based on the TextIterator.
2396 * WebCore.xcodeproj/project.pbxproj:
2397 * platform/mac/HTMLConverter.h: Added.
2398 * platform/mac/HTMLConverter.mm: Added.
2399 * platform/mac/PasteboardMac.mm:
2400 (WebCore::Pasteboard::writeSelection):
2401
2402 2011-03-08 James Robinson <jamesr@chromium.org>
2403
2404 Reviewed by Kenneth Russell.
2405
2406 [chromium] Explicitly copy compositing properties from LayerChromium to CCLayerImpl
2407 https://bugs.webkit.org/show_bug.cgi?id=55900
2408
2409 This adds an explicit step to synchronize properties from
2410 LayerChromiums to their corresponding CCLayerImpls.
2411
2412 * platform/graphics/chromium/LayerChromium.cpp:
2413 (WebCore::LayerChromium::setBounds):
2414 * platform/graphics/chromium/LayerChromium.h:
2415 (WebCore::LayerChromium::bounds):
2416 (WebCore::LayerChromium::doubleSided):
2417 (WebCore::LayerChromium::setDoubleSided):
2418 * platform/graphics/chromium/LayerRendererChromium.cpp:
2419 (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
2420 * platform/graphics/chromium/cc/CCLayerImpl.cpp:
2421 (WebCore::CCLayerImpl::CCLayerImpl):
2422 (WebCore::CCLayerImpl::updateFromLayer):
2423 (WebCore::CCLayerImpl::descendantsDrawsContent):
2424 * platform/graphics/chromium/cc/CCLayerImpl.h:
2425 (WebCore::CCLayerImpl::anchorPoint):
2426 (WebCore::CCLayerImpl::anchorPointZ):
2427 (WebCore::CCLayerImpl::masksToBounds):
2428 (WebCore::CCLayerImpl::opacity):
2429 (WebCore::CCLayerImpl::position):
2430 (WebCore::CCLayerImpl::preserves3D):
2431 (WebCore::CCLayerImpl::sublayerTransform):
2432 (WebCore::CCLayerImpl::transform):
2433
2434 2011-03-08 James Robinson <jamesr@chromium.org>
2435
2436 Chromium compile fix.
2437
2438 * platform/graphics/chromium/SimpleFontDataLinux.cpp:
2439 (WebCore::SimpleFontData::platformInit):
2440
2441 2011-03-08 Peter Kasting <pkasting@google.com>
2442
2443 Reviewed by James Robinson.
2444
2445 Unify Windows version checks, part 1.
2446 https://bugs.webkit.org/show_bug.cgi?id=55979
2447
2448 Make everyone (I hope) pull in SystemInfo.cpp. Eliminate the
2449 now-unnecessary WindowsVersion.cpp from Chromium.
2450
2451 * GNUmakefile.am:
2452 * WebCore.gyp/WebCore.gyp:
2453 * WebCore.gypi:
2454 * platform/chromium/ScrollbarThemeChromiumWin.cpp:
2455 (WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
2456 (WebCore::ScrollbarThemeChromiumWin::getThemeState):
2457 (WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
2458 * platform/chromium/WindowsVersion.cpp: Removed.
2459 * platform/chromium/WindowsVersion.h: Removed.
2460 * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
2461 (WebCore::fillBMPGlyphs):
2462 * rendering/RenderThemeChromiumWin.cpp:
2463 (WebCore::getNonClientMetrics):
2464
2465 2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
2466
2467 Chromium Linux build fix attempt after r80582.
2468
2469 * platform/graphics/chromium/FontLinux.cpp:
2470 (WebCore::Font::drawGlyphs):
2471 * platform/graphics/chromium/SimpleFontDataLinux.cpp:
2472 (WebCore::SimpleFontData::platformInit):
2473 * platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
2474 (WebCore::GlyphPage::fill):
2475
2476 2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
2477
2478 Mac build fix attempt for r80582.
2479
2480 * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
2481 (WebCore::disableLigatures):
2482
2483 2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
2484
2485 Reviewed by Kent Tamura.
2486
2487 Remove calls to deprecatedEditingOffset in SelectionController and Visib leSelection
2488 https://bugs.webkit.org/show_bug.cgi?id=54937
2489
2490 * editing/SelectionController.cpp:
2491 (WebCore::SelectionController::setSelection): Calls anchorNode() instead of deprecatedNode() to obtain
2492 the document. Also restrained the lifetime of document variable.
2493 (WebCore::removingNodeRemovesPosition): Compare the node with anchorNode () instead of deprecatedNode()
2494 to determine whether or not position becomes null after removing a node.
2495 (WebCore::SelectionController::directionOfEnclosingBlock): The enclosing block is always a container
2496 so call containerNode() instead of deprecatedNode().
2497 (WebCore::SelectionController::debugRenderer): Call containerNode() and computeOffsetInContainer()
2498 instead of deprecatedNode() and deprecatedEditingOffset() respectively.
2499 (WebCore::SelectionController::isInPasswordField): Look for the shadow r oot from containerNode()
2500 instead of deprecatedNode to determine whether or not selection inside a password field. Also assert
2501 that the specified position is not before or after the shadow root as it violates our assumption.
2502 * editing/VisibleSelection.cpp:
2503 (WebCore::makeSearchRange): Call containerNode() and offsetInContainerNo de() instead of deprecatedNode()
2504 and deprecatedEditingOffset() respectively because start is always paren t anchored and therefore
2505 guaranteed to be an offset inside an anchor node.
2506 (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundar ies): Call containerNode()
2507 instead of deprecatedNode() to look for the lowest editable ancestor bec ause position before or after
2508 an editable element isn't editable.
2509 * page/DOMSelection.cpp: Call containerNode() and offsetInContainerNode( ) instead of deprecatedNode()
2510 and deprecatedEditingOffset() respectively in the following functions be cause they are exposed to
2511 DOM, which doesn't have before/after concept.
2512 (WebCore::DOMSelection::anchorNode):
2513 (WebCore::DOMSelection::anchorOffset):
2514 (WebCore::DOMSelection::focusNode):
2515 (WebCore::DOMSelection::focusOffset):
2516 (WebCore::DOMSelection::baseNode):
2517 (WebCore::DOMSelection::baseOffset):
2518 (WebCore::DOMSelection::extentNode):
2519 (WebCore::DOMSelection::extentOffset):
2520
2521 2011-03-08 Brent Fulgham <bfulgham@webkit.org>
2522
2523 Reviewed by Adam Roben.
2524
2525 Correct uninitialized variable in PolicyCallback found while
2526 running WebKit in BoundsChecker.
2527 https://bugs.webkit.org/show_bug.cgi?id=45199.
2528
2529 * loader/PolicyCallback.cpp:
2530 (WebCore::PolicyCallback::PolicyCallback): Initialize
2531 m_argument.
2532
2533 2011-03-08 Brent Fulgham <bfulgham@webkit.org>
2534
2535 More build bustage fix.
2536
2537 * platform/graphics/win/cairo/FontPlatformData.h:
2538 (WebCore::FontPlatformData::setOrientation): Duplicate accessor
2539 in WinCairo-local header. This is such a mess!
2540
2541 2011-03-08 David Hyatt <hyatt@apple.com>
2542
2543 Fix build bustage. Hide orientation setting behind a setter and stub it out in all
2544 FontPlatformData classes. (This class really needs to move to a common header with ifdefs.)
2545
2546 * platform/graphics/SimpleFontData.cpp:
2547 (WebCore::SimpleFontData::verticalRightOrientationFontData):
2548 * platform/graphics/cg/FontPlatformData.h:
2549 (WebCore::FontPlatformData::setOrientation):
2550 * platform/graphics/chromium/FontPlatformDataChromiumWin.h:
2551 (WebCore::FontPlatformData::setOrientation):
2552 * platform/graphics/chromium/FontPlatformDataLinux.h:
2553 (WebCore::FontPlatformData::setOrientation):
2554 * platform/graphics/cocoa/FontPlatformData.h:
2555 (WebCore::FontPlatformData::setOrientation):
2556 * platform/graphics/freetype/FontPlatformData.h:
2557 (WebCore::FontPlatformData::setOrientation):
2558 * platform/graphics/qt/FontPlatformData.h:
2559 (WebCore::FontPlatformData::setOrientation):
2560 * platform/graphics/wince/FontPlatformData.h:
2561 (WebCore::FontPlatformData::setOrientation):
2562 * platform/graphics/wx/FontPlatformData.h:
2563 (WebCore::FontPlatformData::setOrientation):
2564
2565 2011-03-08 Joe Wild <joseph.wild@nokia.com>
2566
2567 Reviewed by Csaba Osztrogonác.
2568
2569 [Qt] Missing SVG variables
2570 https://bugs.webkit.org/show_bug.cgi?id=32941
2571
2572 Basically, this patch just modifies features.pri to the Qt build to
2573 pass on the ENABLE_SVG_* flags to the IDL binding generator.
2574
2575 Also I had remove global-construtors.html from the skip list and
2576 updated the associated expected results files.
2577
2578 * features.pri:
2579 * page/DOMWindow.idl:
2580
2581 2011-03-08 Alok priyadarshi <alokp@chromium.org>
2582
2583 Reviewed by Dimitri Glazkov.
2584
2585 Plugins needs a way to trigger style recalc
2586 https://bugs.webkit.org/show_bug.cgi?id=55242
2587
2588 No test needed. A simple get function is added.
2589
2590 * platform/graphics/chromium/PluginLayerChromium.h:
2591 (WebCore::PluginLayerChromium::getTextureId):
2592
2593 2011-03-08 David Hyatt <hyatt@apple.com>
2594
2595 Reviewed by Dan Bernstein.
2596
2597 https://bugs.webkit.org/show_bug.cgi?id=48540, support the text-orientat ion CSS property.
2598
2599 This patch adds support for two values of the text-orientation property (the ones that actually matter): vertical-right and upright.
2600 The TextOrientation is part of the FontDescription and used to look up f onts (similar to FontOrientation).
2601
2602 Orientation of non-CJK characters is done using fallback font data of th e appropriate orientation type, e.g., verticalRightOrientation and
2603 uprightOrientation fallback font data. Vertical right is just implement ed as a normal horizontal font. Upright is implemented as a
2604 vertically oriented font that rotates all glyphs.
2605
2606 The main complication implementing text-orientation is that fonts have " baked-in" vertical glyphs for letters that are hardcoded to
2607 a vertical right facing. This means that you can use those special vert ical glyphs for vertical-right orientation without having to
2608 fall back, but then for upright orientation you have to ignore them and still fall back. As you can see from the test case, this doesn't
2609 work very well, but hopefully it won't be all that common. Limitations of CoreText prevent this case from rendering properly in either the
2610 simple or complex code paths, although the simple code path at least get s close.
2611
2612 Added fast/blockflow/text-orientation-basic.html
2613
2614 * WebCore.exp.in:
2615 * WebCore.xcodeproj/project.pbxproj:
2616 * css/CSSComputedStyleDeclaration.cpp:
2617 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2618 * css/CSSFontFaceSource.cpp:
2619 (WebCore::CSSFontFaceSource::getFontData):
2620 * css/CSSParser.cpp:
2621 (WebCore::CSSParser::parseValue):
2622 * css/CSSPrimitiveValueMappings.h:
2623 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2624 (WebCore::CSSPrimitiveValue::operator TextOrientation):
2625 * css/CSSPropertyNames.in:
2626 * css/CSSStyleSelector.cpp:
2627 (WebCore::CSSStyleSelector::applyDeclarations):
2628 (WebCore::CSSStyleSelector::applyProperty):
2629 * css/CSSValueKeywords.in:
2630 * loader/cache/CachedFont.cpp:
2631 (WebCore::CachedFont::platformDataFromCustomData):
2632 * loader/cache/CachedFont.h:
2633 * platform/graphics/FontCache.cpp:
2634 (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
2635 (WebCore::FontPlatformDataCacheKey::operator==):
2636 (WebCore::computeHash):
2637 (WebCore::FontCache::getCachedFontPlatformData):
2638 * platform/graphics/FontDescription.h:
2639 (WebCore::FontDescription::FontDescription):
2640 (WebCore::FontDescription::textOrientation):
2641 (WebCore::FontDescription::setTextOrientation):
2642 (WebCore::FontDescription::operator==):
2643 * platform/graphics/FontFastPath.cpp:
2644 (WebCore::Font::glyphDataForCharacter):
2645 (WebCore::offsetToMiddleOfGlyph):
2646 * platform/graphics/SimpleFontData.cpp:
2647 (WebCore::SimpleFontData::SimpleFontData):
2648 (WebCore::SimpleFontData::verticalRightOrientationFontData):
2649 (WebCore::SimpleFontData::uprightOrientationFontData):
2650 (WebCore::SimpleFontData::brokenIdeographFontData):
2651 (WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
2652 * platform/graphics/SimpleFontData.h:
2653 (WebCore::SimpleFontData::hasVerticalGlyphs):
2654 (WebCore::SimpleFontData::isTextOrientationFallback):
2655 * platform/graphics/cairo/FontCustomPlatformData.h:
2656 * platform/graphics/cocoa/FontPlatformData.h:
2657 (WebCore::FontPlatformData::FontPlatformData):
2658 (WebCore::FontPlatformData::textOrientation):
2659 (WebCore::FontPlatformData::hash):
2660 (WebCore::FontPlatformData::operator==):
2661 * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
2662 (WebCore::FontPlatformData::FontPlatformData):
2663 (WebCore::FontPlatformData::operator=):
2664 * platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
2665 (WebCore::FontCustomPlatformData::fontPlatformData):
2666 * platform/graphics/haiku/FontCustomPlatformData.cpp:
2667 (WebCore::FontCustomPlatformData::fontPlatformData):
2668 * platform/graphics/haiku/FontCustomPlatformData.h:
2669 * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
2670 (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCore Text):
2671 * platform/graphics/mac/FontCacheMac.mm:
2672 (WebCore::FontCache::createFontPlatformData):
2673 * platform/graphics/mac/FontCustomPlatformData.cpp:
2674 (WebCore::FontCustomPlatformData::fontPlatformData):
2675 * platform/graphics/mac/FontCustomPlatformData.h:
2676 * platform/graphics/mac/FontMac.mm:
2677 (WebCore::showGlyphsWithAdvances):
2678 (WebCore::Font::drawGlyphs):
2679 * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
2680 (WebCore::shouldUseCoreText):
2681 (WebCore::GlyphPage::fill):
2682 * platform/graphics/mac/SimpleFontDataCoreText.cpp:
2683 (WebCore::SimpleFontData::getCFStringAttributes):
2684 * platform/graphics/mac/SimpleFontDataMac.mm:
2685 (WebCore::SimpleFontData::platformInit):
2686 (WebCore::SimpleFontData::platformBoundsForGlyph):
2687 (WebCore::SimpleFontData::platformWidthForGlyph):
2688 * platform/graphics/pango/FontCustomPlatformDataPango.cpp:
2689 (WebCore::FontCustomPlatformData::fontPlatformData):
2690 * platform/graphics/qt/FontCustomPlatformData.h:
2691 * platform/graphics/qt/FontCustomPlatformDataQt.cpp:
2692 (WebCore::FontCustomPlatformData::fontPlatformData):
2693 * platform/graphics/skia/FontCustomPlatformData.cpp:
2694 (WebCore::FontCustomPlatformData::fontPlatformData):
2695 * platform/graphics/skia/FontCustomPlatformData.h:
2696 * platform/graphics/win/FontCustomPlatformData.cpp:
2697 (WebCore::FontCustomPlatformData::fontPlatformData):
2698 * platform/graphics/win/FontCustomPlatformData.h:
2699 * platform/graphics/win/FontCustomPlatformDataCairo.cpp:
2700 (WebCore::FontCustomPlatformData::fontPlatformData):
2701 * platform/graphics/win/FontCustomPlatformDataCairo.h:
2702 * platform/graphics/wince/FontCustomPlatformData.cpp:
2703 (WebCore::FontCustomPlatformData::fontPlatformData):
2704 * platform/graphics/wince/FontCustomPlatformData.h:
2705 * platform/text/TextOrientation.h: Added.
2706 * rendering/InlineFlowBox.cpp:
2707 (WebCore::InlineFlowBox::requiresIdeographicBaseline):
2708 * rendering/style/RenderStyle.h:
2709 (WebCore::InheritedFlags::initialTextOrientation):
2710
2711 2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
2712
2713 Reviewed by Darin Adler.
2714
2715 addInlineStyleIfNeeded should take EditingStyle
2716 https://bugs.webkit.org/show_bug.cgi?id=55950
2717
2718 Deployed EditingStyle in addInlineStyleIfNeeded, StyleChange::StyleChang e, and StyleChange::init.
2719 Also extracted EditingStyle::styleIsPresentInComputedStyleOfNode from re moveStyleFromRunBeforeApplyingStyle.
2720
2721 * editing/ApplyStyleCommand.cpp:
2722 (WebCore::StyleChange::StyleChange): Takes EditingStyle instead of CSSSt yleDeclaration.
2723 (WebCore::StyleChange::init): Ditto.
2724 (WebCore::ApplyStyleCommand::applyBlockStyle): Instantiates StyleChange.
2725 (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Calls addInli neStyleIfNeeded.
2726 (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Cal ls styleIsPresentInComputedStyleOfNode.
2727 (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Calls Editin gStyle::mergeInlineStyleOfElement
2728 instead of manually merging styles.
2729 (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Calls addInlin eStyleIfNeeded.
2730 (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Takes EditingStyle instead of CSSMutableStyleDeclaration.
2731 * editing/ApplyStyleCommand.h:
2732 * editing/CompositeEditCommand.h:
2733 * editing/EditingStyle.cpp:
2734 (WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode): Extracted from removeStyleFromRunBeforeApplyingStyle.
2735 * editing/EditingStyle.h:
2736
2737 2011-03-08 Nico Weber <thakis@chromium.org>
2738
2739 Reviewed by James Robinson.
2740
2741 Crash on big blur radius with canvas
2742 https://bugs.webkit.org/show_bug.cgi?id=55951
2743
2744 Move the clamping code out of an if branch, so that it happens in the
2745 canvas case as well.
2746
2747 Test: fast/canvas/shadow-huge-blur.html
2748
2749 * platform/graphics/cg/GraphicsContextCG.cpp:
2750 (WebCore::GraphicsContext::setPlatformShadow):
2751
2752 2011-03-08 Chris Fleizach <cfleizach@apple.com>
2753
2754 Reviewed by Sam Weinig.
2755
2756 WK2: Cannot set focus on an element when focus is outside of WKView
2757 https://bugs.webkit.org/show_bug.cgi?id=55281
2758
2759 In WK2, focus cannot be set from the WebProcess side because there's no platformWidget().
2760 Instead, the focus/unfocus messages need to be sent to the UIProcess sid e.
2761
2762 * platform/mac/WidgetMac.mm:
2763 (WebCore::Widget::setFocus):
2764
2765 2011-03-08 Sam Weinig <sam@webkit.org>
2766
2767 Reviewed by Anders Carlsson.
2768
2769 Overflow: scroll areas should not paint white in scroll corner if the
2770 scrollbars are overlay.
2771 <rdar://problem/9082871>
2772
2773 * rendering/RenderLayer.cpp:
2774 (WebCore::RenderLayer::paintScrollCorner):
2775 Don't paint the scroll corner white if we have overlay scrollbars.
2776
2777 2011-03-08 Chris Marrin <cmarrin@apple.com>
2778
2779 Reviewed by Darin Adler.
2780
2781 The first time animations are committed they have a bad start time
2782 https://bugs.webkit.org/show_bug.cgi?id=55947
2783
2784 Do a check for a returned lastCommitTime of <=0 and replace it
2785 with the mediaTime.
2786
2787
2788 * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
2789 (WebCore::CACFLayerTreeHost::notifyAnimationsStarted):
2790
2791 2011-03-08 James Kozianski <koz@chromium.org>
2792
2793 Reviewed by David Levin.
2794
2795 Expose isValidProtocol() in KURL.h.
2796 https://bugs.webkit.org/show_bug.cgi?id=54594
2797
2798 This is needed to validate protocols used in calls to
2799 navigator.registerProtocolHandler().
2800
2801 * platform/KURL.cpp:
2802 * platform/KURL.h:
2803 * platform/KURLGoogle.cpp:
2804 (WebCore::isValidProtocol):
2805
2806 2011-03-08 Adam Roben <aroben@apple.com>
2807
2808 Set svn:mime-type to text/css for all Inspector CSS files
2809
2810 This will cause them to be served with the correct MIME type from svn.we bkit.org's web
2811 interface.
2812
2813 Rubber-stamped by Tim Hatcher.
2814
2815 * inspector/front-end/audits.css: Added property svn:mime-type.
2816 * inspector/front-end/goToLineDialog.css: Added property svn:mime-type.
2817 * inspector/front-end/heapProfiler.css: Added property svn:mime-type.
2818 * inspector/front-end/helpScreen.css: Added property svn:mime-type.
2819 * inspector/front-end/inspector.css: Added property svn:mime-type.
2820 * inspector/front-end/inspectorSyntaxHighlight.css: Added property svn:m ime-type.
2821 * inspector/front-end/networkPanel.css: Added property svn:mime-type.
2822 * inspector/front-end/popover.css: Added property svn:mime-type.
2823 * inspector/front-end/textViewer.css: Added property svn:mime-type.
2824
2825 2011-03-08 Andrei Popescu <andreip@google.com>
2826
2827 Reviewed by Steve Block.
2828
2829 IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed.
2830 https://bugs.webkit.org/show_bug.cgi?id=55938
2831
2832 The IndexedDatabase specification changed and IDBIndex objects are no
2833 longer created asynchronously. We therefore no longer need this method.
2834
2835 No new tests, just cleanup.
2836
2837 * storage/IDBCallbacks.h:
2838 * storage/IDBRequest.cpp:
2839 * storage/IDBRequest.h:
2840
2841 2011-03-08 Sheriff Bot <webkit.review.bot@gmail.com>
2842
2843 Unreviewed, rolling out r80551.
2844 http://trac.webkit.org/changeset/80551
2845 https://bugs.webkit.org/show_bug.cgi?id=55933
2846
2847 It broke 285 tests on Qt bot (Requested by Ossy on #webkit).
2848
2849 * WebCore.pro:
2850 * platform/SharedBuffer.cpp:
2851 * platform/SharedBuffer.h:
2852 * platform/network/qt/QNetworkReplyHandler.cpp:
2853 (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
2854 (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
2855 (WebCore::QNetworkReplyHandler::forwardData):
2856 (WebCore::QNetworkReplyHandler::start):
2857 * platform/network/qt/QNetworkReplyHandler.h:
2858 * platform/network/qt/ResourceHandleQt.cpp:
2859 (WebCore::ResourceHandle::supportsBufferedData):
2860 (WebCore::ResourceHandle::bufferedData):
2861 * platform/qt/QtByteBlock.cpp: Removed.
2862 * platform/qt/QtByteBlock.h: Removed.
2863 * platform/qt/SharedBufferQt.cpp:
2864
2865 2011-03-08 Andreas Kling <kling@webkit.org>
2866
2867 Reviewed by Benjamin Poulain.
2868
2869 RenderObject: Pass complex type arguments as const-references.
2870
2871 * WebCore.exp.in:
2872 * rendering/RenderObject.h:
2873 * rendering/RenderObject.cpp:
2874 (WebCore::RenderObject::drawBoxSideFromPath):
2875 (WebCore::RenderObject::drawArcForBoxSide):
2876 (WebCore::RenderObject::localToAbsolute):
2877 (WebCore::RenderObject::absoluteToLocal):
2878
2879 2011-03-08 Andreas Kling <kling@webkit.org>
2880
2881 Reviewed by Antonio Gomes.
2882
2883 Path: Make measurement functions const
2884 https://bugs.webkit.org/show_bug.cgi?id=55914
2885
2886 * platform/graphics/Path.cpp:
2887 (WebCore::Path::length):
2888 (WebCore::Path::pointAtLength):
2889 (WebCore::Path::normalAngleAtLength):
2890 * platform/graphics/Path.h:
2891 * platform/graphics/cairo/PathCairo.cpp:
2892 (WebCore::Path::strokeBoundingRect):
2893 * platform/graphics/cg/PathCG.cpp:
2894 (WebCore::Path::strokeBoundingRect):
2895 * platform/graphics/openvg/PathOpenVG.cpp:
2896 (WebCore::Path::strokeBoundingRect):
2897 (WebCore::Path::length):
2898 (WebCore::Path::pointAtLength):
2899 (WebCore::Path::normalAngleAtLength):
2900 * platform/graphics/qt/PathQt.cpp:
2901 (WebCore::Path::strokeBoundingRect):
2902 (WebCore::Path::length):
2903 (WebCore::Path::pointAtLength):
2904 (WebCore::Path::normalAngleAtLength):
2905 * platform/graphics/skia/PathSkia.cpp:
2906 (WebCore::Path::strokeBoundingRect):
2907 * platform/graphics/wince/PathWinCE.cpp:
2908 (WebCore::Path::strokeBoundingRect):
2909 * platform/graphics/wx/PathWx.cpp:
2910 (WebCore::Path::strokeBoundingRect):
2911
2912 2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
2913
2914 Reviewed by Martin Robinson.
2915
2916 [GTK] Do not set juntion sides on scrollbar stepper buttons
2917 https://bugs.webkit.org/show_bug.cgi?id=55868
2918
2919 Fixes rendering of steppers for themes using rounded stepper
2920 buttons on scrollbars like Adwaita.
2921
2922 * platform/gtk/ScrollbarThemeGtk3.cpp:
2923 (WebCore::ScrollbarThemeGtk::paintButton):
2924
2925 2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
2926
2927 Reviewed by Martin Robinson.
2928
2929 [GTK] Use doubles instead of integers for coordinates when rendering arr ows
2930 https://bugs.webkit.org/show_bug.cgi?id=55866
2931
2932 To prevent off-by-one rounding errors.
2933
2934 * platform/gtk/RenderThemeGtk3.cpp:
2935 (WebCore::RenderThemeGtk::paintMenuList):
2936 * platform/gtk/ScrollbarThemeGtk3.cpp:
2937 (WebCore::ScrollbarThemeGtk::paintButton):
2938
2939 2011-03-08 Markus Goetz <guruz@guruz.de>
2940
2941 Reviewed by Kenneth Rohde Christiansen.
2942
2943 [Qt] Use the QNetworkAccessManager zerocopy feature
2944 https://bugs.webkit.org/show_bug.cgi?id=50082
2945
2946 The feature will be introduced in Qt 4.8.
2947 This patch is backwards compatible with Qt 4.7.
2948
2949 * WebCore.pro:
2950 * platform/SharedBuffer.cpp:
2951 * platform/SharedBuffer.h:
2952 * platform/network/qt/QNetworkReplyHandler.cpp:
2953 (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
2954 (WebCore::QNetworkReplyHandler::bufferedData):
2955 (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
2956 (WebCore::QNetworkReplyHandler::downloadProgress):
2957 (WebCore::QNetworkReplyHandler::forwardData):
2958 (WebCore::QNetworkReplyHandler::start):
2959 * platform/network/qt/QNetworkReplyHandler.h:
2960 * platform/network/qt/ResourceHandleQt.cpp:
2961 (WebCore::ResourceHandle::supportsBufferedData):
2962 (WebCore::ResourceHandle::bufferedData):
2963 * platform/qt/SharedBufferQt.cpp:
2964 (WebCore::SharedBuffer::wrapQtByteBlock):
2965 (WebCore::SharedBuffer::hasPlatformData):
2966 (WebCore::SharedBuffer::platformData):
2967 (WebCore::SharedBuffer::platformDataSize):
2968 (WebCore::SharedBuffer::maybeTransferPlatformData):
2969 (WebCore::SharedBuffer::clearPlatformData):
2970
2971 2011-03-08 Alejandro G. Castro <alex@igalia.com>
2972
2973 Reviewed by Martin Robinson.
2974
2975 [GTK] Fix compilation warnings after r80429
2976 https://bugs.webkit.org/show_bug.cgi?id=55864
2977
2978 * platform/gtk/WidgetGtk.cpp:
2979
2980 2011-03-08 Philippe Normand <pnormand@igalia.com>
2981
2982 Unreviewed, GTK build fix after r80536
2983
2984 * GNUmakefile.am:
2985
2986 2011-03-08 Zan Dobersek <zandobersek@gmail.com>
2987
2988 Reviewed by Martin Robinson.
2989
2990 [Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to bu ffer
2991 https://bugs.webkit.org/show_bug.cgi?id=55878
2992
2993 Multiply the quality parameter by 100 to put it in the range [0, 100] as needed
2994 when saving GdkPixbuf to a buffer.
2995
2996 * platform/graphics/gtk/ImageBufferGtk.cpp:
2997 (WebCore::ImageBuffer::toDataURL):
2998
2999 2011-03-07 Daniel Cheng <dcheng@chromium.org>
3000
3001 Unreviewed.
3002
3003 Final build fix for r80536.
3004
3005 * DerivedSources.make:
3006
3007 2011-03-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3008
3009 Reviewed by Kent Tamura.
3010
3011 [EFL] Adjust functions of WebCore's efl port to WebKit coding style
3012 https://bugs.webkit.org/show_bug.cgi?id=55924
3013
3014 Adjust webkit style to PlatformKeyboardEventEfl, PlatformMouseEventEfl a nd WidgetEfl files.
3015
3016 * platform/efl/PlatformKeyboardEventEfl.cpp:
3017 (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
3018 * platform/efl/PlatformMouseEventEfl.cpp:
3019 (WebCore::PlatformMouseEvent::PlatformMouseEvent):
3020 * platform/efl/WidgetEfl.cpp:
3021 (WebCore::Widget::frameRectsChanged):
3022 (WebCore::Widget::setEvasObject):
3023
3024 2011-03-07 Daniel Cheng <dcheng@chromium.org>
3025
3026 Unreviewed.
3027
3028 More build fixes for r80536.
3029
3030 * CMakeLists.txt:
3031 * platform/chromium/ClipboardChromium.cpp:
3032 * platform/chromium/ClipboardChromium.h:
3033
3034 2011-03-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3035
3036 Reviewed by Antonio Gomes.
3037
3038 [EFL] Adjust functions of ScrollbarEfl.cpp to WebKit coding style
3039 https://bugs.webkit.org/show_bug.cgi?id=55917
3040
3041 Adjust webkit style to ScrollbarEfl files.
3042
3043 * platform/efl/ScrollbarEfl.cpp:
3044 (scrollbarEflEdjeMessage):
3045 (ScrollbarEfl::setParent):
3046 (ScrollbarEfl::updateThumbPositionAndProportion):
3047 (ScrollbarEfl::frameRectsChanged):
3048 (ScrollbarEfl::paint):
3049 * platform/efl/ScrollbarEfl.h:
3050
3051 2011-03-07 Daniel Cheng <dcheng@chromium.org>
3052
3053 Unreviewed.
3054
3055 Build fix for Chromium after r80536.
3056
3057 * platform/chromium/DataTransferItemChromium.cpp:
3058 * platform/chromium/DataTransferItemsChromium.cpp:
3059
3060 2011-03-07 Daniel Cheng <dcheng@chromium.org>
3061
3062 Unreviewed.
3063
3064 More build fixes for r80536.
3065
3066 * CMakeLists.txt:
3067 * platform/chromium/ClipboardChromium.cpp:
3068 * platform/chromium/ClipboardChromium.h:
3069
3070 2011-03-07 Daniel Cheng <dcheng@chromium.org>
3071
3072 Reviewed by David Levin.
3073
3074 Add support for DataTransferItems
3075 https://bugs.webkit.org/show_bug.cgi?id=55115
3076
3077 This patch adds stubs for DataTransferItems/DataTransferItem as well as implementing the
3078 basic functionality on the Chromium port. With the exception of DataTran sferItem::getAsFile,
3079 all functionality on the DataTransferItems collection has been implement ed.
3080 This change does not actually hook up DataTransferItems to reflect the a ctual contents of a
3081 drop/paste operation or to allow mutation of data in a copy/drag start y et. That will be
3082 enabled via several followup patches.
3083
3084 Test: editing/pasteboard/data-transfer-items.html
3085
3086 * Android.mk:
3087 * CMakeLists.txt:
3088 * CodeGenerators.pri:
3089 * DerivedSources.cpp:
3090 * DerivedSources.make:
3091 * GNUmakefile.am:
3092 * WebCore.gypi:
3093 * WebCore.pro:
3094 * WebCore.vcproj/WebCore.vcproj:
3095 * WebCore.xcodeproj/project.pbxproj:
3096 * bindings/generic/RuntimeEnabledFeatures.cpp:
3097 * bindings/generic/RuntimeEnabledFeatures.h:
3098 (WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled):
3099 (WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled):
3100 * bindings/scripts/CodeGeneratorV8.pm: Do not emit an #include line for DOMString, since it's built-in.
3101 * dom/Clipboard.h:
3102 (WebCore::Clipboard::policy):
3103 * dom/Clipboard.idl:
3104 * dom/DataTransferItem.cpp: Added.
3105 * dom/DataTransferItem.h: Added.
3106 (WebCore::DataTransferItem::~DataTransferItem):
3107 * dom/DataTransferItem.idl: Added.
3108 * dom/DataTransferItems.h: Added.
3109 (WebCore::DataTransferItems::~DataTransferItems):
3110 * dom/DataTransferItems.idl: Added.
3111 * dom/StringCallback.cpp: Added.
3112 (WebCore::StringCallback::scheduleCallback):
3113 * dom/StringCallback.h: Added.
3114 (WebCore::StringCallback::~StringCallback):
3115 * dom/StringCallback.idl: Added.
3116 * platform/chromium/ClipboardChromium.cpp:
3117 (WebCore::ClipboardChromium::items):
3118 * platform/chromium/ClipboardChromium.h:
3119 * platform/chromium/DataTransferItemChromium.cpp: Added.
3120 (WebCore::DataTransferItemChromium::create):
3121 (WebCore::DataTransferItemChromium::DataTransferItemChromium):
3122 (WebCore::DataTransferItemChromium::kind):
3123 (WebCore::DataTransferItemChromium::type):
3124 (WebCore::DataTransferItemChromium::getAsString):
3125 * platform/chromium/DataTransferItemChromium.h: Added.
3126 * platform/chromium/DataTransferItemsChromium.cpp: Added.
3127 (WebCore::DataTransferItemsChromium::create):
3128 (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
3129 (WebCore::DataTransferItemsChromium::length):
3130 (WebCore::DataTransferItemsChromium::item):
3131 (WebCore::DataTransferItemsChromium::deleteItem):
3132 (WebCore::DataTransferItemsChromium::clear):
3133 (WebCore::DataTransferItemsChromium::add):
3134 * platform/chromium/DataTransferItemsChromium.h: Added.
3135
3136 2011-03-07 Ryosuke Niwa <rniwa@webkit.org>
3137
3138 Reviewed by Darin Adler.
3139
3140 selectionHasStyle and selectionStartHasStyle should use EditingStyle
3141 https://bugs.webkit.org/show_bug.cgi?id=55902
3142
3143 Deployed EditingStyle in selectionHasStyle and selectionStartHasStyle.
3144 This allowed us to move triStateOfStyle from Editor.cpp to EditingStyle. cpp.
3145
3146 Also changed the argument lists of selectionHasStyle and selectionStartH asStyle
3147 to take a property id and a value instead of a CSSMutableStyleDeclaratio n to cleanup
3148 call sites of these two functions.
3149
3150 * WebCore.exp.in: Updated the signature of selectionHasStyle. No longer exports
3151 selectionStartHasStyle because it's not called anywhere outside of WebCo re.
3152 * WebCore.order: Ditto.
3153 * editing/EditingStyle.cpp:
3154 (WebCore::EditingStyle::EditingStyle): Added a new constructor that take s a property id
3155 and a property value.
3156 (WebCore::EditingStyle::triStateOfStyle): Moved from Editor.cpp.
3157 * editing/EditingStyle.h:
3158 (WebCore::EditingStyle::create): Added.
3159 * editing/Editor.cpp:
3160 (WebCore::Editor::selectionStartHasStyle): Takes a property id and a val ue instead of
3161 a CSSStyleDeclaration.
3162 (WebCore::Editor::selectionHasStyle): Ditto.
3163 * editing/Editor.h: Updated the signatures of selectionStartHasStyle and selectionHasStyle.
3164 * editing/EditorCommand.cpp:
3165 (WebCore::executeToggleStyle): Calls selectionStartHasStyle and selectio nHasStyle.
3166 (WebCore::stateStyle): Ditto.
3167 * page/ContextMenuController.cpp:
3168 (WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.
3169
3170 2011-03-07 Alexey Proskuryakov <ap@apple.com>
3171
3172 Reviewed by Darin Adler.
3173
3174 REGRESSION (HTML5 tree builder): Text selection in a large text document is extremely slow
3175 https://bugs.webkit.org/show_bug.cgi?id=55898
3176
3177 <rdar://problem/9095839> REGRESSION: Mail hangs with a certain large mai l message when
3178 linkifying e-mail addresses in in -[DOMCharacterData setData:]
3179
3180 Changes render tree of fast/text/large-text-composed-char.html, but not image results.
3181
3182 * dom/CharacterData.cpp: (WebCore::CharacterData::parserAppendData):
3183 Changed parserAppendData() to accept a maximum length, and moved code fr om Text::createWithLengthLimit().
3184
3185 * dom/CharacterData.h: Moved a constant for maximum length from Text.h.
3186
3187 * dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
3188 * dom/Text.h:
3189 This function was unused in ToT. Moved code around to share with Charact erData.
3190
3191 * html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite:: insertTextNode):
3192 Chnaged to split large text nodes while parsing again.
3193
3194 2011-03-07 Alice Boxhall <aboxhall@chromium.org>
3195
3196 Reviewed by Adam Barth.
3197
3198 Fix platform/image-encoders/JPEGImageEncoder.cpp empty_output_buffer() b ehaviour
3199 https://bugs.webkit.org/show_bug.cgi?id=54522
3200
3201 Fix jpegEmptyOutputBuffer() by ignoring free_in_buffer value as required .
3202
3203 No new tests, as this code is not yet used in WebKit. Once this code is used to implement canvas.toDataUrl(), the canvas tests will exercise it.
3204
3205 * platform/image-encoders/JPEGImageEncoder.cpp:
3206 (WebCore::jpegEmptyOutputBuffer):
3207
3208 2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>
3209
3210 Reviewed by Eric Seidel.
3211
3212 Add the missing insertedIntoDocument() call in SVGVKernElement and SVGHK ernElement
3213 https://bugs.webkit.org/show_bug.cgi?id=55896
3214
3215 Test: svg/dom/vkern-element-crash.html
3216
3217 * svg/SVGHKernElement.cpp:
3218 (WebCore::SVGHKernElement::insertedIntoDocument):
3219 * svg/SVGVKernElement.cpp:
3220 (WebCore::SVGVKernElement::insertedIntoDocument):
3221
3222 2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>
3223
3224 Unreviewed, rolling out r80514.
3225 http://trac.webkit.org/changeset/80514
3226 https://bugs.webkit.org/show_bug.cgi?id=55915
3227
3228 Caused assertion failures (Requested by ukai on #webkit).
3229
3230 * platform/graphics/skia/GraphicsContextSkia.cpp:
3231 (WebCore::GraphicsContext::setPlatformShadow):
3232 * platform/graphics/skia/ImageSkia.cpp:
3233 (WebCore::paintSkBitmap):
3234
3235 2011-03-07 Cosmin Truta <ctruta@chromium.org>
3236
3237 Reviewed by Adam Barth.
3238
3239 SVG <image> referenced by <use> is displayed incorrectly
3240 https://bugs.webkit.org/show_bug.cgi?id=55750
3241
3242 The result of sourceURI must use the URL of the enclosing document as ba se.
3243 Otherwise, the base may sometimes be empty, and, as a consequence,
3244 the intermediate KURL object may be invalid.
3245
3246 Test: svg/custom/use-image-in-g.svg
3247
3248 * svg/SVGImageLoader.cpp:
3249 (WebCore::SVGImageLoader::sourceURI):
3250
3251 2011-03-07 Helder Correia <helder@sencha.com>
3252
3253 Reviewed by Simon Fraser.
3254
3255 Shadow is not shown when using strokeRect with a gradient strokeStyle
3256 https://bugs.webkit.org/show_bug.cgi?id=52509
3257
3258 This happens in CG and is related to bug 51869, this time to be fixed
3259 in GraphicsContext::strokeRect(const FloatRect& r, float lineWidth).
3260 We need to draw the gradient clipped to the stroke on a CGLayer first,
3261 and then draw the layer on the GraphicsContext.
3262
3263 Tests: fast/canvas/canvas-strokeRect-gradient-shadow.html
3264 svg/css/rect-gradient-stroke-shadow.svg
3265
3266 * platform/graphics/cg/GraphicsContextCG.cpp:
3267 (WebCore::GraphicsContext::strokeRect):
3268
3269 2011-03-07 Justin Novosad <junov@chromium.org>
3270
3271 Reviewed by Kenneth Russell.
3272
3273 Fix for blurs behind bitmap images in Chromium, and boosting
3274 shadow blur quality
3275 Bug URLs:
3276 https://bugs.webkit.org/show_bug.cgi?id=55410
3277 https://bugs.webkit.org/show_bug.cgi?id=55506
3278
3279 No new tests. Covered by existing layout tests.
3280
3281 * platform/graphics/skia/GraphicsContextSkia.cpp:
3282 (WebCore::GraphicsContext::setPlatformShadow): Turn on high quality shad ows and fix shadow color
3283 * platform/graphics/skia/ImageSkia.cpp:
3284 (WebCore::paintSkBitmap): Propagate the draw looper from context to pain ter
3285
3286 2011-03-07 Andreas Kling <kling@webkit.org>
3287
3288 Unreviewed Mac build fix after r80508.
3289
3290 * WebCore.exp.in:
3291
3292 2011-03-07 Enrica Casucci <enrica@apple.com>
3293
3294 Unreviewed build fix.
3295
3296 Rolling back http://trac.webkit.org/changeset/80497 due to the
3297 32-bit build failures.
3298
3299 * WebCore.xcodeproj/project.pbxproj:
3300 * platform/mac/HTMLConverter.h: Removed.
3301 * platform/mac/HTMLConverter.mm: Removed.
3302 * platform/mac/PasteboardMac.mm:
3303 (WebCore::Pasteboard::writeSelection):
3304
3305 2011-03-07 Andreas Kling <kling@webkit.org>
3306
3307 Reviewed by Benjamin Poulain.
3308
3309 FrameView::setBaseBackgroundColor: Pass Color argument as const-referenc e.
3310
3311 * page/FrameView.cpp:
3312 (WebCore::FrameView::setBaseBackgroundColor):
3313 * page/FrameView.h:
3314
3315 2011-03-07 Adam Barth <abarth@webkit.org>
3316
3317 Reviewed by Dimitri Glazkov.
3318
3319 REGRESSION(r78147): Crash on http://gnarf.net/jquery/test/
3320 https://bugs.webkit.org/show_bug.cgi?id=55894
3321
3322 The m_frame can disappear out from under us, and there's no point in
3323 checking whether the load is complete in a non-existant frame.
3324
3325 Test: fast/parser/document-write-into-initial-document.html
3326
3327 * dom/Document.cpp:
3328 (WebCore::Document::explicitClose):
3329
3330 2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>
3331
3332 Unreviewed, rolling out r80500.
3333 http://trac.webkit.org/changeset/80500
3334 https://bugs.webkit.org/show_bug.cgi?id=55908
3335
3336 Caused mysterious GYP error (Requested by abarth on #webkit).
3337
3338 * WebCore.gyp/WebCore.gyp:
3339 * WebCore.gypi:
3340
3341 2011-03-07 Adam Barth <abarth@webkit.org>
3342
3343 Fix Chromium Mac build. This header should only be included when the
3344 feature is enabled.
3345
3346 * platform/cf/RunLoopTimerCF.cpp:
3347
3348 2011-03-07 Adam Barth <abarth@webkit.org>
3349
3350 Reviewed by Dimitri Glazkov.
3351
3352 Add WML files to WebCore.gypi
3353 https://bugs.webkit.org/show_bug.cgi?id=55905
3354
3355 * WebCore.gyp/WebCore.gyp:
3356 * WebCore.gypi:
3357
3358 2011-03-07 Adrienne Walker <enne@google.com>
3359
3360 Reviewed by James Robinson.
3361
3362 [chromium] Add missing include to #define Skia parameter
3363 https://bugs.webkit.org/show_bug.cgi?id=55885
3364
3365 * platform/graphics/chromium/ShaderChromium.h:
3366
3367 2011-03-07 Chris Fleizach <cfleizach@apple.com>
3368
3369 Reviewed by Beth Dakin.
3370
3371 AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does no t
3372 https://bugs.webkit.org/show_bug.cgi?id=55706
3373
3374 * WebCore.exp.in:
3375 * accessibility/AXObjectCache.cpp:
3376 (WebCore::AXObjectCache::rootObjectForFrame):
3377 * accessibility/AXObjectCache.h:
3378 * accessibility/AccessibilityScrollView.cpp:
3379 (WebCore::AccessibilityScrollView::isAttachment):
3380 (WebCore::AccessibilityScrollView::widgetForAttachmentView):
3381 * accessibility/AccessibilityScrollView.h:
3382 (WebCore::AccessibilityScrollView::firstChild):
3383 * accessibility/mac/AccessibilityObjectWrapper.mm:
3384 (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
3385
3386 2011-03-07 Enrica Casucci <enrica@apple.com>
3387
3388 Reviewed by Darin Adler.
3389
3390 REGRESSION: Copied content loses formatting on paste to external apps.
3391 https://bugs.webkit.org/show_bug.cgi?id=47615
3392 <rdar://problem/9001214>
3393
3394 This is a resubmission of a patch that was landed a while ago then rolle d
3395 back because of a build failure on SnowLeopard and Leopard.
3396
3397 This patch adds a way for WebKit2 to create NSAttributedStrings from
3398 a DOM range without using the AppKit api initWithDOMRange that internall y
3399 needs to access the WebView. The NSAttributedString is needed to create
3400 RTF formats in the pasteboard.
3401 This is to be considered a first step, since in the future we want to ha ve
3402 an implementation based on the TextIterator.
3403
3404 * WebCore.xcodeproj/project.pbxproj: Added new file.
3405 * platform/mac/HTMLConverter.h: Added.
3406 * platform/mac/HTMLConverter.mm: Added.
3407 * platform/mac/PasteboardMac.mm:
3408 (WebCore::Pasteboard::writeSelection): We now use WebHTMLConverter
3409 class for WebKit2 to create the NSAttributedString from the DOM range.
3410
3411 2011-03-07 Adam Barth <abarth@webkit.org>
3412
3413 Reviewed by Dimitri Glazkov.
3414
3415 Add some missing platform files to WebCore.gypi
3416 https://bugs.webkit.org/show_bug.cgi?id=55897
3417
3418 There are a bunch more, but this is a start.
3419
3420 * WebCore.gyp/WebCore.gyp:
3421 * WebCore.gypi:
3422
3423 2011-03-07 Steve Block <steveblock@google.com>
3424
3425 Reviewed by Jeremy Orlow.
3426
3427 Rename JNIBridgeV8.cpp/h to JavaFieldV8.cpp/h
3428 https://bugs.webkit.org/show_bug.cgi?id=55879
3429
3430 No new tests, refactoring only.
3431
3432 * Android.v8bindings.mk:
3433 * WebCore.gypi:
3434 * bridge/jni/v8/JavaClassV8.cpp:
3435 * bridge/jni/v8/JavaClassV8.h:
3436 * bridge/jni/v8/JavaFieldV8.cpp: Renamed from Source/WebCore/bridge/jni/ v8/JNIBridgeV8.cpp.
3437 (JavaField::JavaField):
3438 * bridge/jni/v8/JavaFieldV8.h: Renamed from Source/WebCore/bridge/jni/v8 /JNIBridgeV8.h.
3439 (JSC::Bindings::JavaField::name):
3440 (JSC::Bindings::JavaField::type):
3441 (JSC::Bindings::JavaField::getJNIType):
3442 * bridge/jni/v8/JavaInstanceV8.cpp:
3443 * bridge/jni/v8/JavaNPObjectV8.cpp:
3444
3445 2011-03-07 Daniel Cheng <dcheng@chromium.org>
3446
3447 Reviewed by Tony Chang.
3448
3449 Add plumbing for paste support to ChromiumDataObject::types()
3450 https://bugs.webkit.org/show_bug.cgi?id=55792
3451
3452 This is a preliminary patch to support event.dataTransfer.items. This
3453 adds plumbing to support retrieving the types in a paste event. It also
3454 moves the check for files in a drag/paste up to ClipboardChromium, since
3455 internal code needs to be able to differentiate between actual files in
3456 a drag and someone that simply decided to use "Files" as a custom type
3457 string.
3458
3459 Test: editing/pasteboard/onpaste-text-html-types.html
3460
3461 * platform/chromium/ChromiumDataObject.cpp:
3462 (WebCore::ChromiumDataObject::types):
3463 (WebCore::ChromiumDataObject::containsFilenames):
3464 * platform/chromium/ChromiumDataObject.h:
3465 * platform/chromium/ClipboardChromium.cpp:
3466 (WebCore::ClipboardChromium::types):
3467 * platform/chromium/ClipboardMimeTypes.cpp:
3468 * platform/chromium/ClipboardMimeTypes.h:
3469
3470 2011-03-07 Takayoshi Kochi <kochi@chromium.org>
3471
3472 Reviewed by Tony Chang.
3473
3474 [chromium] Use preferred locale information when choosing fallback
3475 font using fontconfig on Linux platform.
3476 http://bugs.webkit.org/show_bug.cgi?id=55453
3477
3478 No new tests, as it depends on ICU and locale setting, so it will be
3479 covered by Chromium side.
3480
3481 * platform/chromium/PlatformBridge.h:
3482 * platform/graphics/chromium/FontCacheLinux.cpp:
3483
3484 2011-03-07 Adam Barth <abarth@webkit.org>
3485
3486 Reviewed by Eric Seidel.
3487
3488 Add gobject, cpp, and objc bindings to WebCore.gypi
3489 https://bugs.webkit.org/show_bug.cgi?id=55892
3490
3491 These are also excluded from the Chromium build but needed for various
3492 other ports.
3493
3494 * WebCore.gyp/WebCore.gyp:
3495 * WebCore.gypi:
3496
3497 2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>
3498
3499 Reviewed by Dimitri Glazkov.
3500
3501 Node::checkAddChild and Node::checkReplaceChild shouldn't change the own er document of a node
3502 https://bugs.webkit.org/show_bug.cgi?id=55803
3503
3504 Test: fast/dom/dom-method-document-change.html
3505
3506 * dom/ContainerNode.cpp:
3507 (WebCore::ContainerNode::insertBefore):
3508 (WebCore::ContainerNode::replaceChild):
3509 (WebCore::ContainerNode::appendChild):
3510 * dom/Node.cpp:
3511 (WebCore::Node::checkReplaceChild):
3512 (WebCore::Node::checkAddChild):
3513 * dom/Node.h:
3514
3515 2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>
3516
3517 Unreviewed, rolling out r80484.
3518 http://trac.webkit.org/changeset/80484
3519 https://bugs.webkit.org/show_bug.cgi?id=55891
3520
3521 requires Chromium DEPS roll (Requested by dcheng on #webkit).
3522
3523 * platform/chromium/ChromiumDataObject.cpp:
3524 (WebCore::ChromiumDataObject::types):
3525 * platform/chromium/ChromiumDataObject.h:
3526 (WebCore::ChromiumDataObject::containsFilenames):
3527 * platform/chromium/ClipboardChromium.cpp:
3528 (WebCore::ClipboardChromium::types):
3529 * platform/chromium/ClipboardMimeTypes.cpp:
3530 * platform/chromium/ClipboardMimeTypes.h:
3531
3532 2011-03-07 Adam Barth <abarth@webkit.org>
3533
3534 Reviewed by Dimitri Glazkov.
3535
3536 Add missing bindings/js files to WebCore.gypi
3537 https://bugs.webkit.org/show_bug.cgi?id=55888
3538
3539 These files are excluded from the Chromium build but needed for the Mac
3540 build.
3541
3542 * WebCore.gypi:
3543
3544 2011-03-07 Daniel Cheng <dcheng@chromium.org>
3545
3546 Reviewed by Tony Chang.
3547
3548 Add plumbing for paste support to ChromiumDataObject::types()
3549 https://bugs.webkit.org/show_bug.cgi?id=55792
3550
3551 This is a preliminary patch to support event.dataTransfer.items. This
3552 adds plumbing to support retrieving the types in a paste event. It also
3553 moves the check for files in a drag/paste up to ClipboardChromium, since
3554 internal code needs to be able to differentiate between actual files in
3555 a drag and someone that simply decided to use "Files" as a custom type
3556 string.
3557
3558 Test: editing/pasteboard/onpaste-text-html-types.html
3559
3560 * platform/chromium/ChromiumDataObject.cpp:
3561 (WebCore::ChromiumDataObject::types):
3562 (WebCore::ChromiumDataObject::containsFilenames):
3563 * platform/chromium/ChromiumDataObject.h:
3564 * platform/chromium/ClipboardChromium.cpp:
3565 (WebCore::ClipboardChromium::types):
3566 * platform/chromium/ClipboardMimeTypes.cpp:
3567 * platform/chromium/ClipboardMimeTypes.h:
3568
3569 2011-03-07 Joseph Pecoraro <joepeck@webkit.org>
3570
3571 Reviewed by Kenneth Rohde Christiansen.
3572
3573 Viewport Warning/Error Messages Are Now Inaccurate
3574 https://bugs.webkit.org/show_bug.cgi?id=53707
3575
3576 Correct and improve the error messages for viewport parsing.
3577
3578 Tests: fast/viewport/viewport-warnings-1.html
3579 fast/viewport/viewport-warnings-2.html
3580 fast/viewport/viewport-warnings-3.html
3581 fast/viewport/viewport-warnings-4.html
3582 fast/viewport/viewport-warnings-5.html
3583 fast/viewport/viewport-warnings-6.html
3584
3585 * dom/ViewportArguments.cpp:
3586 (WebCore::numericPrefix):
3587 (WebCore::findSizeValue): remove incorrect device-width / height tips.
3588 (WebCore::setViewportFeature): report a warning for an unrecognized key.
3589 (WebCore::viewportErrorMessageTemplate): added template for unrecognized key.
3590 (WebCore::viewportErrorMessageLevel): classify an unrecognized key is an error.
3591 * dom/ViewportArguments.h: removed no longer used warnings.
3592
3593 2011-03-07 James Robinson <jamesr@chromium.org>
3594
3595 Reviewed by Kenneth Russell.
3596
3597 [chromium] Separate the update and draw portions of LayerRendererChromiu m's drawLayers function
3598 https://bugs.webkit.org/show_bug.cgi?id=54047
3599
3600 This splits up LayerRendererChromium::drawLayers() into two phases,
3601 one that updates layers and one that actually draws them. Most of the
3602 patch is moving the bodies of drawLayers() and updateLayersRecursive()
3603 into smaller helper functions.
3604
3605 The main entry point is renamed updateAndDrawLayers(), but otherwise
3606 has the same signature as drawLayers() did. Internally it does the
3607 following:
3608
3609 1.) Updates the root layer's contents
3610 2.) Updates the root layer's scrollbars
3611 3.) Updates the RenderSurface tree and the contents of all child
3612 layers
3613 4.) Draws the root layer and root layer scrollbars
3614 5.) Draws all child layers using the previously updated
3615 CCLayerImpl/RenderSurface data.
3616
3617 A few things still need to be done after this patch to complete the sepa ration
3618 of the update and draw step, but they can happen in later patches:
3619 *) The root layer and root layer scrollbars contents should be
3620 uploaded to textures at draw time, not update time.
3621 *) The RenderSurface tree should be updated at draw time, not update
3622 time.
3623
3624 Covered by the compositing/ tests.
3625
3626 * platform/graphics/chromium/LayerRendererChromium.cpp:
3627 (WebCore::LayerRendererChromium::LayerRendererChromium):
3628 (WebCore::LayerRendererChromium::updateRootLayerContents):
3629 (WebCore::LayerRendererChromium::updateRootLayerScrollbars):
3630 (WebCore::LayerRendererChromium::drawRootLayer):
3631 (WebCore::LayerRendererChromium::updateAndDrawLayers):
3632 (WebCore::LayerRendererChromium::updateLayers):
3633 (WebCore::LayerRendererChromium::drawLayers):
3634 (WebCore::LayerRendererChromium::getFramebufferPixels):
3635 (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
3636 (WebCore::LayerRendererChromium::updateContentsRecursive):
3637 (WebCore::LayerRendererChromium::drawLayer):
3638 * platform/graphics/chromium/LayerRendererChromium.h:
3639 (WebCore::LayerRendererChromium::visibleRectSize):
3640 * platform/graphics/chromium/RenderSurfaceChromium.cpp:
3641 (WebCore::RenderSurfaceChromium::drawSurface):
3642 * platform/graphics/chromium/cc/CCLayerImpl.cpp:
3643 * platform/graphics/chromium/cc/CCLayerImpl.h:
3644
3645 2011-03-07 Adam Barth <abarth@webkit.org>
3646
3647 Reviewed by Eric Seidel.
3648
3649 Sort WebCore.gypi
3650 https://bugs.webkit.org/show_bug.cgi?id=55887
3651
3652 These files should be in order. This is preparation for adding in the
3653 missing files.
3654
3655 * WebCore.gypi:
3656
3657 2011-03-07 Csaba Osztrogonác <ossy@webkit.org>
3658
3659 Unreviewed buildfix after r80478.
3660
3661 * dom/Document.cpp: Add suggested parentheses to make GCC happy.
3662 (WebCore::Document::didReceiveTask):
3663
3664 2011-03-07 Yong Li <yoli@rim.com>
3665
3666 Reviewed by Darin Adler.
3667
3668 Defer ScriptExecutionContext::Task's in Document when page loading is de ferred.
3669 Schedule them with timer when page loading is resumed. The tasks will be performed
3670 in the original order. This fixes the problem that database callbacks co uld be missed
3671 when page loading was deferred.
3672 https://bugs.webkit.org/show_bug.cgi?id=49401
3673
3674 Manual test added: manual-tests/database-callback-deferred.html.
3675
3676 * dom/Document.cpp:
3677 (WebCore::Document::Document):
3678 (WebCore::Document::~Document):
3679 (WebCore::Document::didReceiveTask):
3680 (WebCore::Document::postTask):
3681 (WebCore::Document::pendingTasksTimerFired):
3682 (WebCore::Document::willDeferLoading):
3683 (WebCore::Document::didResumeLoading):
3684 * dom/Document.h:
3685 * manual-tests/database-callback-deferred.html: Added.
3686 * page/PageGroupLoadDeferrer.cpp:
3687 (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
3688 (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
3689
3690 2011-03-07 Antti Koivisto <antti@apple.com>
3691
3692 Reviewed by Sam Weinig.
3693
3694 Use HashMaps for caching primitive values
3695 https://bugs.webkit.org/show_bug.cgi?id=55873
3696
3697 Most documents use only small subset of cacheable primitive values. By r eplacing
3698 fixed size cache arrays with HashMaps we can reduce the constant memory usage while also
3699 expanding the range of cacheable values.
3700
3701 * css/CSSPrimitiveValueCache.cpp:
3702 (WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
3703 (WebCore::CSSPrimitiveValueCache::createIdentifierValue):
3704 (WebCore::CSSPrimitiveValueCache::createColorValue):
3705 (WebCore::CSSPrimitiveValueCache::createValue):
3706 * css/CSSPrimitiveValueCache.h:
3707
3708 2011-03-07 Steve Block <steveblock@google.com>
3709
3710 Reviewed by Jeremy Orlow.
3711
3712 Split JNIBridgeJSC.cpp/h into JavaArrayJSC.cpp/h and JavaFieldJSC.cpp/h
3713 https://bugs.webkit.org/show_bug.cgi?id=55881
3714
3715 No new tests, refactoring only.
3716
3717 * Android.jscbindings.mk:
3718 * GNUmakefile.am:
3719 * WebCore.xcodeproj/project.pbxproj:
3720 * bridge/jni/jsc/JNIBridgeJSC.cpp: Removed.
3721 * bridge/jni/jsc/JNIBridgeJSC.h: Removed.
3722 * bridge/jni/jsc/JNIUtilityPrivate.cpp:
3723 * bridge/jni/jsc/JavaClassJSC.cpp:
3724 * bridge/jni/jsc/JavaClassJSC.h:
3725 * bridge/jni/jsc/JavaInstanceJSC.cpp:
3726
3727 2011-03-07 Sam Weinig <sam@webkit.org>
3728
3729 Reviewed by Anders Carlsson.
3730
3731 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
3732 https://bugs.webkit.org/show_bug.cgi?id=55827
3733
3734 * loader/EmptyClients.h:
3735 (WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForResponse):
3736 * loader/FrameLoaderClient.h:
3737 * loader/MainResourceLoader.cpp:
3738 (WebCore::MainResourceLoader::didReceiveResponse):
3739 * loader/PolicyChecker.cpp:
3740 (WebCore::PolicyChecker::checkContentPolicy):
3741 * loader/PolicyChecker.h:
3742 Rename FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDec idePolicyForResponse
3743 and pass the entire response, instead of just the MIMEType.
3744
3745 2011-03-07 Eric Carlson <eric.carlson@apple.com>
3746
3747 Reviewed by Darin Adler.
3748
3749 Add API to enumerate/delete files downloaded for <audio> and <video>
3750 https://bugs.webkit.org/show_bug.cgi?id=55267
3751 <rdar://problem/9049280>
3752
3753 No new tests, this is just more plumbing.
3754
3755 * html/HTMLMediaElement.cpp:
3756 (WebCore::HTMLMediaElement::getSitesInMediaCache): Make static, call Med iaPlayer static method.
3757 (WebCore::HTMLMediaElement::clearMediaCache): Ditto.
3758 (WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
3759 * html/HTMLMediaElement.h:
3760
3761 * platform/graphics/MediaPlayer.cpp:
3762 (WebCore::MediaPlayerFactory::MediaPlayerFactory): Add new media engine factory functions.
3763 (WebCore::addMediaEngine): Ditto.
3764 (WebCore::MediaPlayer::getSitesInMediaCache): Call static method on all installed media engines.
3765 (WebCore::MediaPlayer::clearMediaCache): Ditto.
3766 (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
3767 * platform/graphics/MediaPlayer.h:
3768
3769 * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
3770 (WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine): Update for MediaEngineRegistrar change.
3771
3772 * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
3773 (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Ditto.
3774
3775 * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
3776 (WebCore::MediaPlayerPrivatePhonon::registerMediaEngine): Ditto.
3777
3778 * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
3779 (WebCore::MediaPlayerPrivateQt::registerMediaEngine): Ditto.
3780
3781 * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
3782 (WebCore::MediaPlayerPrivateQuickTimeVisualContext::registerMediaEngine) : Ditto.
3783
3784 * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
3785 (WebCore::MediaPlayerPrivate::registerMediaEngine): Ditto.
3786
3787 2011-03-07 Steve Block <steveblock@google.com>
3788
3789 Reviewed by Jeremy Orlow.
3790
3791 Split JNIBridge.cpp/h into JavaString.h and JavaMethod.cpp/h
3792 https://bugs.webkit.org/show_bug.cgi?id=55774
3793
3794 No new tests, refactoring only.
3795
3796 * Android.jscbindings.mk:
3797 * Android.v8bindings.mk:
3798 * GNUmakefile.am:
3799 * WebCore.gypi:
3800 * WebCore.xcodeproj/project.pbxproj:
3801 * bridge/jni/JavaMethod.cpp:
3802 (JavaMethod::JavaMethod):
3803 (JavaMethod::~JavaMethod):
3804 (appendClassName):
3805 (JavaMethod::signature):
3806 (JavaMethod::JNIReturnType):
3807 (JavaMethod::methodID):
3808 * bridge/jni/JavaMethod.h:
3809 (JSC::Bindings::JavaMethod::name):
3810 (JSC::Bindings::JavaMethod::returnType):
3811 (JSC::Bindings::JavaMethod::parameterAt):
3812 (JSC::Bindings::JavaMethod::numParameters):
3813 (JSC::Bindings::JavaMethod::isStatic):
3814 * bridge/jni/JavaString.h:
3815 (JSC::Bindings::JavaString::JavaString):
3816 (JSC::Bindings::JavaString::utf8):
3817 (JSC::Bindings::JavaString::length):
3818 (JSC::Bindings::JavaString::impl):
3819 * bridge/jni/jni_jsobject.mm:
3820 * bridge/jni/jsc/JNIBridgeJSC.h:
3821 * bridge/jni/v8/JNIBridgeV8.h:
3822 * bridge/jni/v8/JavaClassV8.cpp:
3823 * bridge/jni/v8/JavaClassV8.h:
3824 * bridge/jni/v8/JavaInstanceV8.cpp:
3825
3826 2011-03-07 Jeremy Orlow <jorlow@chromium.org>
3827
3828 Reviewed by Steve Block.
3829
3830 Add source to IDBCursor, objectStore to IDBIndex, and remove storeName
3831 https://bugs.webkit.org/show_bug.cgi?id=55812
3832
3833 This brings us in line with what's in the spec:
3834 http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html
3835
3836 * storage/IDBCursor.cpp:
3837 (WebCore::IDBCursor::create):
3838 (WebCore::IDBCursor::IDBCursor):
3839 (WebCore::IDBCursor::source):
3840 * storage/IDBCursor.h:
3841 * storage/IDBCursor.idl:
3842 * storage/IDBCursorWithValue.cpp:
3843 (WebCore::IDBCursorWithValue::create):
3844 (WebCore::IDBCursorWithValue::IDBCursorWithValue):
3845 * storage/IDBCursorWithValue.h:
3846 * storage/IDBIndex.cpp:
3847 (WebCore::IDBIndex::IDBIndex):
3848 * storage/IDBIndex.h:
3849 (WebCore::IDBIndex::create):
3850 (WebCore::IDBIndex::objectStore):
3851 * storage/IDBIndex.idl:
3852 * storage/IDBObjectStore.cpp:
3853 (WebCore::IDBObjectStore::createIndex):
3854 (WebCore::IDBObjectStore::index):
3855 * storage/IDBRequest.cpp:
3856 (WebCore::IDBRequest::onSuccess):
3857
3858 2011-03-07 Chris Fleizach <cfleizach@apple.com>
3859
3860 Reviewed by Beth Dakin.
3861
3862 AX: kAXCellForColumnAndRowParameterizedAttribute doesn't work ARIA grids with colspans
3863 https://bugs.webkit.org/show_bug.cgi?id=55735
3864
3865 The ARIA grid implementation needed to verify the row/column range of a cell instead of
3866 assuming a 1-1 mapping between children and row/column.
3867
3868 Test: platform/mac/accessibility/aria-table-with-colspan-cells.html
3869
3870 * accessibility/AccessibilityARIAGrid.cpp:
3871 (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
3872
3873 2011-03-07 Andrei Popescu <andreip@google.com>
3874
3875 Reviewed by Steve Block.
3876
3877 IDBRequest::onSuccess(IDBObjectStore*) should be removed as it is unused .
3878 IDBObjectStore objects used to be created asynchronously, so we needed
3879 this method to be invoked, with the new object store as the parameter,
3880 whenever the creation succeeded. The spec has changed so that IDBObjectS tore
3881 objects are created synchronously, so this method is no longer needed.
3882 https://bugs.webkit.org/show_bug.cgi?id=55777
3883
3884 No new tests, just refactoring.
3885
3886 * storage/IDBCallbacks.h:
3887 * storage/IDBRequest.cpp:
3888 * storage/IDBRequest.h:
3889
3890 2011-03-04 Steve Block <steveblock@google.com>
3891
3892 Reviewed by Jeremy Orlow.
3893
3894 JavaParameter should be removed
3895 https://bugs.webkit.org/show_bug.cgi?id=55772
3896
3897 No new tests, refactoring only.
3898
3899 * bridge/jni/JNIBridge.cpp:
3900 (JavaMethod::JavaMethod):
3901 (JavaMethod::~JavaMethod):
3902 (JavaMethod::signature):
3903 * bridge/jni/JNIBridge.h:
3904 (JSC::Bindings::JavaMethod::parameterAt):
3905 (JSC::Bindings::JavaMethod::numParameters):
3906 * bridge/jni/JNIUtility.h:
3907 * bridge/jni/jsc/JavaInstanceJSC.cpp:
3908 (JavaInstance::invokeMethod):
3909 * bridge/jni/v8/JNIUtilityPrivate.cpp:
3910 (JSC::Bindings::convertNPVariantToJValue):
3911 * bridge/jni/v8/JNIUtilityPrivate.h:
3912 * bridge/jni/v8/JavaInstanceV8.cpp:
3913 (JavaInstance::invokeMethod):
3914
3915 2011-03-07 Antti Koivisto <antti@apple.com>
3916
3917 Reviewed by Oliver Hunt.
3918
3919 REGRESSION (r79574): fast/dom/global-constructors.html failing on Window s 7 Release (Tests) bots
3920 https://bugs.webkit.org/show_bug.cgi?id=55166
3921 <rdar://problem/9050430>
3922
3923 Make CSS primitive value cache per-document.
3924
3925 Test: http/tests/security/cross-origin-css-primitive.html
3926
3927 * Android.mk:
3928 * CMakeLists.txt:
3929 * GNUmakefile.am:
3930 * WebCore.gypi:
3931 * WebCore.pro:
3932 * WebCore.vcproj/WebCore.vcproj:
3933 * WebCore.xcodeproj/project.pbxproj:
3934 * css/CSSComputedStyleDeclaration.cpp:
3935 (WebCore::valueForNinePieceImage):
3936 (WebCore::zoomAdjustedPixelValue):
3937 (WebCore::zoomAdjustedNumberValue):
3938 (WebCore::zoomAdjustedPixelValueForLength):
3939 (WebCore::valueForReflection):
3940 (WebCore::getPositionOffsetValue):
3941 (WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
3942 (WebCore::getBorderRadiusCornerValue):
3943 (WebCore::computedTransform):
3944 (WebCore::getDelayValue):
3945 (WebCore::getDurationValue):
3946 (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyw ord):
3947 (WebCore::CSSComputedStyleDeclaration::valueForShadow):
3948 (WebCore::valueForFamily):
3949 (WebCore::renderTextDecorationFlagsToCSSValue):
3950 (WebCore::fillRepeatToCSSValue):
3951 (WebCore::fillSizeToCSSValue):
3952 (WebCore::contentToCSSValue):
3953 (WebCore::counterToCSSValue):
3954 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3955 * css/CSSParser.cpp:
3956 (WebCore::CSSParser::parseSheet):
3957 (WebCore::CSSParser::parseRule):
3958 (WebCore::CSSParser::parseKeyframeRule):
3959 (WebCore::CSSParser::parseValue):
3960 (WebCore::CSSParser::parseColor):
3961 (WebCore::CSSParser::parseSelector):
3962 (WebCore::CSSParser::parseDeclaration):
3963 (WebCore::CSSParser::setStyleSheet):
3964 (WebCore::CSSParser::parseWCSSInputProperty):
3965 (WebCore::parseBackgroundClip):
3966 (WebCore::CSSParser::parseFillShorthand):
3967 (WebCore::CSSParser::parsePage):
3968 (WebCore::CSSParser::parseSizeParameter):
3969 (WebCore::CSSParser::parseContent):
3970 (WebCore::CSSParser::parseAttr):
3971 (WebCore::CSSParser::parseBackgroundColor):
3972 (WebCore::CSSParser::parseFillPositionXY):
3973 (WebCore::CSSParser::parseFillPosition):
3974 (WebCore::CSSParser::parseFillRepeat):
3975 (WebCore::CSSParser::parseFillSize):
3976 (WebCore::CSSParser::parseFillProperty):
3977 (WebCore::CSSParser::parseAnimationDelay):
3978 (WebCore::CSSParser::parseAnimationDirection):
3979 (WebCore::CSSParser::parseAnimationDuration):
3980 (WebCore::CSSParser::parseAnimationFillMode):
3981 (WebCore::CSSParser::parseAnimationIterationCount):
3982 (WebCore::CSSParser::parseAnimationName):
3983 (WebCore::CSSParser::parseAnimationPlayState):
3984 (WebCore::CSSParser::parseAnimationProperty):
3985 (WebCore::CSSParser::parseTransformOriginShorthand):
3986 (WebCore::CSSParser::parseAnimationTimingFunction):
3987 (WebCore::CSSParser::parseDashboardRegions):
3988 (WebCore::CSSParser::parseCounterContent):
3989 (WebCore::CSSParser::parseShape):
3990 (WebCore::CSSParser::parseFont):
3991 (WebCore::CSSParser::parseFontFamily):
3992 (WebCore::CSSParser::parseFontStyle):
3993 (WebCore::CSSParser::parseFontVariant):
3994 (WebCore::CSSParser::parseFontWeight):
3995 (WebCore::ShadowParseContext::ShadowParseContext):
3996 (WebCore::ShadowParseContext::commitLength):
3997 (WebCore::ShadowParseContext::commitStyle):
3998 (WebCore::CSSParser::parseShadow):
3999 (WebCore::CSSParser::parseReflect):
4000 (WebCore::BorderImageParseContext::BorderImageParseContext):
4001 (WebCore::BorderImageParseContext::commitNumber):
4002 (WebCore::BorderImageParseContext::commitBorderImage):
4003 (WebCore::CSSParser::parseBorderImage):
4004 (WebCore::CSSParser::parseBorderRadius):
4005 (WebCore::CSSParser::parseCounter):
4006 (WebCore::parseDeprecatedGradientPoint):
4007 (WebCore::parseDeprecatedGradientColorStop):
4008 (WebCore::CSSParser::parseDeprecatedGradient):
4009 (WebCore::valueFromSideKeyword):
4010 (WebCore::parseGradientColorOrKeyword):
4011 (WebCore::CSSParser::parseLinearGradient):
4012 (WebCore::CSSParser::parseRadialGradient):
4013 (WebCore::CSSParser::parseGradientColorStops):
4014 (WebCore::CSSParser::parseTransform):
4015 (WebCore::CSSParser::parseTransformOrigin):
4016 (WebCore::CSSParser::parseTextEmphasisStyle):
4017 * css/CSSParser.h:
4018 (WebCore::CSSParser::primitiveValueCache):
4019 * css/CSSPrimitiveValue.cpp:
4020 * css/CSSPrimitiveValue.h:
4021 (WebCore::CSSPrimitiveValue::createIdentifier):
4022 (WebCore::CSSPrimitiveValue::createColor):
4023 (WebCore::CSSPrimitiveValue::create):
4024 * css/CSSPrimitiveValueCache.cpp: Added.
4025 (WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
4026 (WebCore::CSSPrimitiveValueCache::~CSSPrimitiveValueCache):
4027 (WebCore::CSSPrimitiveValueCache::createIdentifierValue):
4028 (WebCore::CSSPrimitiveValueCache::createColorValue):
4029 (WebCore::CSSPrimitiveValueCache::createValue):
4030 * css/CSSPrimitiveValueCache.h: Added.
4031 (WebCore::CSSPrimitiveValueCache::create):
4032 (WebCore::CSSPrimitiveValueCache::createValue):
4033 * dom/Document.cpp:
4034 (WebCore::Document::cssPrimitiveValueCache):
4035 * dom/Document.h:
4036
4037 2011-03-06 Adam Barth <abarth@webkit.org>
4038
4039 Reviewed by Eric Seidel.
4040
4041 Filter sources in WebCore GYP build for Mac
4042 https://bugs.webkit.org/show_bug.cgi?id=55857
4043
4044 This patch removes a large number of files that do not build as part of
4045 the Mac build. I'm not fully sold on this method of
4046 including/excluding files, but it's the "gyp way" so we should probably
4047 try it first.
4048
4049 This patch also sets xcode_list_excluded_files to 0, which removes the
4050 excluded files from the Xcode project file, which is necessary in order
4051 to prevent the header map feature from including the wrong header file.
4052
4053 * gyp/WebCore.gyp:
4054
4055 2011-03-07 Ryuan Choi <ryuan.choi@samsung.com>
4056
4057 Unreviewed EFL build fix.
4058
4059 [EFL] Build break on Debug build.
4060 https://bugs.webkit.org/show_bug.cgi?id=55858
4061
4062 * platform/efl/RenderThemeEfl.cpp:
4063 (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
4064
4065 2011-03-06 Adam Barth <abarth@webkit.org>
4066
4067 Reviewed by Eric Seidel.
4068
4069 Add webcore_derived_source_files to WebCore.gypi
4070 https://bugs.webkit.org/show_bug.cgi?id=55856
4071
4072 This is the list of files generated by the Mac port. It's possible
4073 other ports generate a different list of files.
4074
4075 * WebCore.gypi:
4076 * gyp/WebCore.gyp:
4077
4078 2011-03-06 Naoki Takano <takano.naoki@gmail.com>
4079
4080 Reviewed by Kent Tamura.
4081
4082 Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.
4083 https://bugs.webkit.org/show_bug.cgi?id=55839
4084 http://crbug.com/73866
4085 http://crbug.com/62527
4086
4087 We also need style change for m_innerSpinButton not only for m_outerSpin Buggon when styleDidChange() is called.
4088
4089 Test: fast/forms/input-appearance-spinbutton-visibility.html
4090
4091 * rendering/RenderTextControlSingleLine.cpp:
4092 (WebCore::RenderTextControlSingleLine::styleDidChange):
4093
4094 2011-03-06 Naoki Takano <takano.naoki@gmail.com>
4095
4096 Reviewed by Kent Tamura.
4097
4098 [Chromium] Autocomplete suggestion extends out of window (and onto secon d monitor)
4099 https://bugs.webkit.org/show_bug.cgi?id=54795
4100
4101 Implement width clip logic according to browser screen width and popup w indow width. This fix is enough for Win and Mac, but there is a problem in Linux . Because WebScreenInfoFactory::screenInfo() can get only merged screen size, no t the screen size where the browser exists.
4102
4103 Test: manual-tests/popup-width-restriction-within-screen.html
4104
4105 * manual-tests/popup-width-restriction-within-screen.html: Added.
4106 * platform/chromium/PopupMenuChromium.cpp:
4107 (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Implement the w idth clip logic according to screen width.
4108
4109 2011-03-06 Yuta Kitamura <yutak@chromium.org>
4110
4111 Reviewed by Kent Tamura.
4112
4113 Add SHA-1 for new WebSocket protocol
4114 https://bugs.webkit.org/show_bug.cgi?id=55039
4115
4116 * ForwardingHeaders/wtf/SHA1.h: Added.
4117
4118 2011-03-06 Eric Carlson <eric.carlson@apple.com>
4119
4120 Reviewed by Antti Koivisto.
4121
4122 QuickTime based media engines should respect private browsing mode
4123 https://bugs.webkit.org/show_bug.cgi?id=55848
4124
4125 No new tests, it is only possible to test this by manually deleting and monitoring the
4126 the Quicktime caches.
4127
4128 * html/HTMLMediaElement.cpp:
4129 (WebCore::HTMLMediaElement::privateBrowsingStateDidChange): Add logging.
4130
4131 * platform/graphics/MediaPlayer.cpp:
4132 (WebCore::MediaPlayer::MediaPlayer): Initialize m_privateBrowsing.
4133 (WebCore::MediaPlayer::loadWithNextMediaEngine): Set privacy mode on new media engine.
4134 (WebCore::MediaPlayer::setPrivateBrowsingMode): Stash setting in m_priva teBrowsing.
4135 * platform/graphics/MediaPlayer.h:
4136 * platform/graphics/MediaPlayerPrivate.h:
4137 (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode):
4138
4139 * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
4140 * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
4141 (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): Initialize m_privateBrowsing.
4142 (WebCore::MediaPlayerPrivateQTKit::createQTMovie): Pass private browsing attribute when
4143 creating new movie.
4144 (WebCore::MediaPlayerPrivateQTKit::setPrivateBrowsingMode): New, store p rivacy setting in
4145 m_privateBrowsing and set movie attribute.
4146
4147 * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
4148 (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQu ickTimeVisualContext):
4149 Initialize m_privateBrowsing.
4150 (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setPrivateBrowsingMo de): New, store
4151 privacy setting in m_privateBrowsing and call QTMovie.
4152 * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
4153
4154 * platform/graphics/win/QTMovie.cpp:
4155 (QTMoviePrivate::QTMoviePrivate): Initialize m_privateBrowsing.
4156 (QTMovie::load):Pass private browsing property when creating new movie.
4157 (QTMovie::setPrivateBrowsingMode): New, store privacy setting in m_priv ateBrowsing and
4158 set movie property.
4159 * platform/graphics/win/QTMovie.h:
4160
4161 2011-03-06 Daniel Bates <dbates@rim.com>
4162
4163 Reviewed by Darin Adler.
4164
4165 style.borderSpacing always returns empty string
4166 https://bugs.webkit.org/show_bug.cgi?id=54816
4167
4168 Teach CSSMutableStyleDeclaration::getPropertyValue() how to reconstitute
4169 the value for border-spacing from the value of the WebKit internal CSS
4170 property -webkit-border-horizontal-spacing and -webkit-border-vertical-s pacing.
4171
4172 The CSS property border-spacing describes the horizontal and vertical bo rder
4173 spacing for an HTML Table element. Notice, WebKit internally represents the value
4174 of this property as two properties: -webkit-border-horizontal-spacing an d
4175 -webkit-border-vertical-spacing, for the horizontal and vertical border spacing,
4176 respectively. And WebKit doesn't know to reconstitute these internal pro perties.
4177 Therefore style.borderSpacing always returns the empty string.
4178
4179 Test: fast/css/table-border-spacing.html
4180
4181 * css/CSSMutableStyleDeclaration.cpp:
4182 (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
4183 (WebCore::CSSMutableStyleDeclaration::borderSpacingValue): Added.
4184 * css/CSSMutableStyleDeclaration.h:
4185
4186 2011-03-06 Dan Bernstein <mitz@apple.com>
4187
4188 Reviewed by Oliver Hunt.
4189
4190 <rdar://problem/9093327> Implement -hyphenate-limit-{before,after}
4191 https://bugs.webkit.org/show_bug.cgi?id=55850
4192
4193 Tests: fast/css/parsing-hyphenate-limit.html
4194 fast/text/hyphenate-limit-before-after.html
4195
4196 * css/CSSComputedStyleDeclaration.cpp:
4197 (WebCore::computedProperties) Updated this array with the new properties and some old properties
4198 that it was missing.
4199 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
4200 CSSPropertyWebkitHyphenateLimit{Before,After}.
4201
4202 * css/CSSParser.cpp:
4203 (WebCore::CSSParser::parseValue): Parse -webkit-hyphenate-limit-{before, after}, allowing
4204 'auto' and non-negative integers.
4205
4206 * css/CSSPropertyNames.in: Added -webkit-hyphenate-limit-{before,after}.
4207
4208 * css/CSSStyleSelector.cpp:
4209 (WebCore::CSSStyleSelector::applyProperty): Handle CSSPropertyWebkitHyph enateLimit{Before,After}.
4210
4211 * rendering/RenderBlockLineLayout.cpp:
4212 (WebCore::tryHyphenating): Added minimum prefix and suffix length parame ters and checks to only
4213 allow hyphenation if the prefix and the suffix are sufficiently long.
4214 (WebCore::RenderBlock::findNextLineBreak): Pass the limits to tryHyphena ting().
4215
4216 * rendering/style/RenderStyle.cpp:
4217 (WebCore::RenderStyle::diff): A difference in hyphenation limits is a la yout difference.
4218
4219 * rendering/style/RenderStyle.h:
4220 (WebCore::InheritedFlags::hyphenationLimitBefore): Added.
4221 (WebCore::InheritedFlags::hyphenationLimitAfter): Added.
4222 (WebCore::InheritedFlags::setHyphenationLimitBefore): Added.
4223 (WebCore::InheritedFlags::setHyphenationLimitAfter): Added.
4224 (WebCore::InheritedFlags::initialHyphenationLimitBefore): Added. Returns -1, which is the
4225 representation of 'auto'.
4226 (WebCore::InheritedFlags::initialHyphenationLimitAfter): Ditto.
4227
4228 * rendering/style/StyleRareInheritedData.cpp:
4229 (WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize hy phenation limits.
4230 (WebCore::StyleRareInheritedData::operator==): Compare hyphenation limit s.
4231 * rendering/style/StyleRareInheritedData.h:
4232
4233 2011-03-06 Jessie Berlin <jberlin@apple.com>
4234
4235 Reviewed by Sam Weinig.
4236
4237 WebKit2: Use CFNetwork Sessions API.
4238 https://bugs.webkit.org/show_bug.cgi?id=55435.
4239
4240 When Private Browsing is enabled, use cookies from a in-memory cookie st orage based on the
4241 Private Browsing Storage Session.
4242
4243 * WebCore.exp.in:
4244 Add the new WKSI functions.
4245 * platform/mac/WebCoreSystemInterface.h:
4246 Ditto.
4247 * platform/mac/WebCoreSystemInterface.mm:
4248 Ditto.
4249
4250 * platform/mac/CookieJar.mm:
4251 (WebCore::cookies):
4252 If USE(CFURLSTORAGESESSIONS) and there is a Private Browsing Cookie Stor age, call into WKSI.
4253 Otherwise, behave the same as before.
4254 (WebCore::cookieRequestHeaderFieldValue):
4255 Ditto.
4256 (WebCore::setCookies):
4257 Ditto.
4258 (WebCore::cookiesEnabled):
4259 Ditto
4260 (WebCore::getRawCookies):
4261 Ditto.
4262 (WebCore::deleteCookie):
4263 Ditto.
4264
4265 * platform/network/CookieStorage.h:
4266 * platform/network/cf/CookieStorageCFNet.cpp:
4267 (WebCore::privateBrowsingCookieStorage):
4268 Keep track of the Private Browsing Cookie Storage in a locally defined s tatic inside a
4269 function instead of at the global scope.
4270 (WebCore::currentCookieStorage):
4271 Use privateBrowsingCookieStorage.
4272 (WebCore::setCurrentCookieStorage):
4273 Ditto.
4274 (WebCore::setCookieStoragePrivateBrowsingEnabled):
4275 If USE(CFURLSTORAGESESSIONS), send the Private Browsing Storage Session to
4276 wkCreatePrivateInMemoryHTTPCookieStorage.
4277 * platform/network/mac/CookieStorageMac.mm:
4278 (WebCore::privateBrowsingCookieStorage):
4279 Keep track of the Private Browsing Cookie Storage.
4280 (WebCore::setCookieStoragePrivateBrowsingEnabled):
4281 If USE(CFURLSTORAGESESSIONS), then set or clear privateBrowsingCookieSto rage().
4282 Added a FIXME to observe changes to the Private Browsing Cookie Storage when it is defined.
4283
4284 * platform/network/mac/ResourceHandleMac.mm:
4285 (WebCore::shouldRelaxThirdPartyCookiePolicy):
4286 Refactor the logic to determine whether or not to relax the third party cookie policy here.
4287 If USE(CFURLSTORAGESESSIONS), then get the information from the privateB rowsingCookieStorage.
4288 (WebCore::ResourceHandle::createNSURLConnection):
4289 Use shouldRelaxThirdPartyCookiePolicy.
4290 (WebCore::ResourceHandle::loadResourceSynchronously):
4291 Ditto.
4292
4293 2011-03-05 Sheriff Bot <webkit.review.bot@gmail.com>
4294
4295 Unreviewed, rolling out r80428.
4296 http://trac.webkit.org/changeset/80428
4297 https://bugs.webkit.org/show_bug.cgi?id=55833
4298
4299 Broke SnowLeopard (Requested by xan_ on #webkit).
4300
4301 * plugins/gtk/PluginViewGtk.cpp:
4302 (WebCore::PluginView::handlePostReadFile):
4303
4304 2011-03-01 Martin Robinson <mrobinson@igalia.com>
4305
4306 Reviewed by Xan Lopez.
4307
4308 [GTK] Windowless plugins override the view cursor
4309 https://bugs.webkit.org/show_bug.cgi?id=55531
4310
4311 manual test: manual-tests/plugins/windowless.html
4312
4313 * platform/gtk/WidgetGtk.cpp:
4314 (WebCore::Widget::setCursor): Call into the ChromeClient implementation now.
4315 * plugins/gtk/PluginViewGtk.cpp:
4316 (WebCore::PluginView::initXEvent): Instead of setting the window for win dowless
4317 plugin events, set the window value to none. This method is also used to send
4318 focus in / focus out events to windowed plugins, but this is not one of the plugin
4319 types where the window parameter matters. This matches what Mozilla does . Also
4320 pass in the display of the widget itself, not the default display.
4321 (WebCore::PluginView::handleMouseEvent): When the cursor leaves the plug in area,
4322 reset the cursor.
4323 (WebCore::PluginView::platformGetValue): Clean up this section slightly. Give the
4324 widget the top-level window explicitly. This matches Mozilla.
4325
4326 2011-03-05 Martin Robinson <mrobinson@igalia.com>
4327
4328 Reviewed by Xan Lopez.
4329
4330 [GTK] http/tests/plugins/post-url-file.html fails on GTK+
4331 https://bugs.webkit.org/show_bug.cgi?id=55826
4332
4333 Correct the implementation of handlePostReadFile which uses GIO APIs and
4334 actually resizes the buffer to fit the entire size of the file data. Thi s
4335 was likely leading to memory corruption until now.
4336
4337 * plugins/gtk/PluginViewGtk.cpp:
4338 (WebCore::PluginView::handlePostReadFile): Fix this method.
4339
4340 2011-03-05 Mikhail Naganov <mnaganov@chromium.org>
4341
4342 Reviewed by Pavel Feldman.
4343
4344 Web Inspector: [Chromium] Allow dynamic enabling of detailed heap profil es.
4345 https://bugs.webkit.org/show_bug.cgi?id=55824
4346
4347 Detailed heap profiles can be now enabled by typing "leakz" in Profiles tab.
4348
4349 * inspector/front-end/DetailedHeapshotView.js:
4350 (WebInspector.DetailedHeapshotView.prototype.isDetailedSnapshot):
4351 * inspector/front-end/ProfilesPanel.js:
4352 (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
4353 (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
4354 (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
4355 (WebInspector.ProfilesPanel.prototype.handleShortcut):
4356 (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnable dHint.hideHint):
4357 (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnable dHint):
4358 (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):
4359 (WebInspector.ProfilesPanel.prototype._recognizeKeyboardCombo):
4360
4361 2011-03-05 Qi Zhang <qi.2.zhang@nokia.com>
4362
4363 Reviewed by Laszlo Gombos.
4364
4365 [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
4366 https://bugs.webkit.org/show_bug.cgi?id=48636
4367
4368 Add model infomation into user agent string when qtmobility is available , but only for symbian, Maemo and MeeGo.
4369
4370 * WebCore.pri:
4371 * features.pri:
4372
4373 2011-03-05 Pavel Feldman <pfeldman@chromium.org>
4374
4375 Not reviewed: adding null check to prevent inspector tests from failing.
4376
4377 * inspector/front-end/TextViewer.js:
4378 (WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
4379 (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
4380
4381 2011-03-05 Pavel Feldman <pfeldman@chromium.org>
4382
4383 Not reviewed: chromium rebaseline, flaky test fix.
4384
4385 * inspector/front-end/BreakpointManager.js:
4386 (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.d ecorateNode):
4387 (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
4388 (WebInspector.DOMBreakpointView.prototype._format.formatters.s):
4389 (WebInspector.DOMBreakpointView.prototype._format.append):
4390 (WebInspector.DOMBreakpointView.prototype._format):
4391
4392 2011-03-04 Pavel Podivilov <podivilov@chromium.org>
4393
4394 Reviewed by Yury Semikhatsky.
4395
4396 Web Inspector: [chromium] pause when script is running is broken.
4397 https://bugs.webkit.org/show_bug.cgi?id=55762
4398
4399 * inspector/CodeGeneratorInspector.pm:
4400
4401 2011-03-05 Adam Barth <abarth@webkit.org>
4402
4403 Reviewed by Dimitri Glazkov.
4404
4405 Add Derived Sources to WebCore GYP build
4406 https://bugs.webkit.org/show_bug.cgi?id=55813
4407
4408 Adding the derived source action to the GYP file required tweaking
4409 DerivedSources.make. I'm not sure how DerivedSources.make worked
4410 before beause these paths were incorrectly based.
4411
4412 * DerivedSources.make:
4413 * gyp/generate-derived-sources.sh: Added.
4414 * gyp/WebCore.gyp:
4415
4416 2011-03-04 Pavel Feldman <pfeldman@chromium.org>
4417
4418 Reviewed by Yury Semikhatsky.
4419
4420 Web Inspector: fix layout tests flakiness.
4421 https://bugs.webkit.org/show_bug.cgi?id=55816
4422
4423 - Order of issuing of evaluateForTestInFrontend was not guaranteed on th e backend side (InspectorAgent side)
4424 - Order of dispatching using timeouts was guaranteed via queueing. Sourc e of all kinds of pains on SnowLeopard Release (inspector.js)
4425
4426 * inspector/CodeGeneratorInspector.pm:
4427 * inspector/InspectorAgent.cpp:
4428 (WebCore::InspectorAgent::InspectorAgent):
4429 (WebCore::InspectorAgent::disconnectFrontend):
4430 (WebCore::InspectorAgent::populateScriptObjects):
4431 (WebCore::InspectorAgent::evaluateForTestInFrontend):
4432 (WebCore::InspectorAgent::issueEvaluateForTestCommands):
4433 * inspector/InspectorAgent.h:
4434 * inspector/front-end/TimelinePanel.js:
4435 (WebInspector.TimelinePanel.FormattedRecord):
4436 * inspector/front-end/inspector.js:
4437 (WebInspector.dispatch):
4438
4439 2011-03-05 Adam Barth <abarth@webkit.org>
4440
4441 Reviewed by Dimitri Glazkov.
4442
4443 WebCore GYP build should generate fewer than 10,000 compile errors per f ile
4444 https://bugs.webkit.org/show_bug.cgi?id=55810
4445
4446 This patch adds some missing include paths. We need to figure out how
4447 to handle separate include paths per port. It's clear that
4448 ForwardingHeaders are only useful for Mac, but it's less clear how to
4449 handle the others.
4450
4451 * WebCore.gypi:
4452 * gyp/WebCore.gyp:
4453
4454 2011-03-05 Dan Bernstein <mitz@apple.com>
4455
4456 Reviewed by Cameron Zwarich.
4457
4458 <rdar://problem/9082946> Make the Core Text code path in GlyphPage::fill () more robust
4459 https://bugs.webkit.org/show_bug.cgi?id=55817
4460
4461 * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
4462 (WebCore::GlyphPage::fill): When determining if a CTRun uses the primary font, compare against
4463 a CGFont obtained from Core Text for the primary font. This CGFont may b e different from
4464 the CGFont stored in the FontPlatformData.
4465
4466 2011-03-05 Ilya Sherman <isherman@chromium.org>
4467
4468 Reviewed by Darin Adler.
4469
4470 HTMLInputElement::setValue() should schedule change event when the eleme nt is focused.
4471 Refactored tracking of "changed since last change event" state from rend erer to DOM.In service of https://code.google.com/p/chromium/issues
4472 In service of https://code.google.com/p/chromium/issues/detail?id=42716
4473 https://bugs.webkit.org/show_bug.cgi?id=53160
4474
4475 Test: fast/forms/onchange-change-type.html
4476 Test: fast/forms/onchange-setvalueforuser.html
4477
4478 * WebCore.exp.in:
4479 * dom/Document.cpp:
4480 (WebCore::Document::setFocusedNode):
4481 * dom/Element.h:
4482 (WebCore::Element::wasChangedSinceLastFormControlChangeEvent): Added.
4483 (WebCore::Element::setChangedSinceLastFormControlChangeEvent): Added.
4484 * html/HTMLFormControlElement.cpp:
4485 (WebCore::HTMLFormControlElement::HTMLFormControlElement):
4486 (WebCore::HTMLFormControlElement::wasChangedSinceLastFormControlChangeEv ent): Added.
4487 (WebCore::HTMLFormControlElement::setChangedSinceLastFormControlChangeEv ent): Added.
4488 (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Also clear the "changed since last change event" flag.
4489 (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Also s et the "changed since last change event" flag.
4490 * html/HTMLFormControlElement.h:
4491 * html/HTMLInputElement.cpp:
4492 (WebCore::HTMLInputElement::updateType): Also clear the "changed since l ast change event" flag.
4493 (WebCore::HTMLInputElement::setValue):
4494 For a focused text field, dispatch an input event, but delay the cha nge event until the field loses focus.
4495 (WebCore::HTMLInputElement::defaultEventHandler):
4496 (WebCore::HTMLInputElement::stepUpFromRenderer):
4497 * html/shadow/TextControlInnerElements.cpp:
4498 (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
4499 * rendering/RenderTextControl.cpp:
4500 (WebCore::RenderTextControl::RenderTextControl):
4501 (WebCore::RenderTextControl::subtreeHasChanged):
4502 * rendering/RenderTextControl.h:
4503 * rendering/RenderTextControlMultiLine.cpp:
4504 (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
4505 * rendering/RenderTextControlSingleLine.cpp:
4506 (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
4507 * wml/WMLInputElement.cpp:
4508 (WebCore::WMLInputElement::WMLInputElement):
4509 (WebCore::WMLInputElement::defaultEventHandler):
4510 * wml/WMLInputElement.h:
4511 (WebCore::WMLInputElement::wasChangedSinceLastFormControlChangeEvent): A dded.
4512 (WebCore::WMLInputElement::setChangedSinceLastFormControlChangeEvent): A dded.
4513
4514 2011-03-04 Xianzhu Wang <wangxianzhu@google.com>
4515
4516 Reviewed by Adam Barth.
4517
4518 Remove fake request loading of SVGImage to avoid MainResourceLoader
4519 leak. The frame->init() already ensures initialization of the
4520 document loader.
4521
4522 https://bugs.webkit.org/show_bug.cgi?id=55017
4523
4524 Test: fast/images/svg-image-leak-loader.html
4525
4526 * svg/graphics/SVGImage.cpp:
4527 (WebCore::SVGImage::dataChanged):
4528
4529 2011-03-04 Mike Reed <reed@google.com>
4530
4531 Reviewed by Mihai Parparita.
4532
4533 [Chromium] fast/canvas/canvas-arc-360-winding.html fails on Linux and Wi ndows
4534 https://bugs.webkit.org/show_bug.cgi?id=49477
4535
4536 * platform/graphics/skia/PathSkia.cpp:
4537 (WebCore::Path::addArc):
4538
4539 2011-03-04 Jia Pu <jpu@apple.com>
4540
4541 Reviewed by Darin Adler.
4542
4543 On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
4544 https://bugs.webkit.org/show_bug.cgi?id=55717
4545 <rdar://problem/9018127>
4546
4547 manual-test: manual-tests/platforms/mac/autocorrection/autocorrection-in -iframe.html
4548
4549 Previously, the bounding box passed into EditorClient::showCorrectionPan el() is in the frame's
4550 coordinate. This is incorrect when the correction occurs in an iframe. T his patch added code
4551 to convert the bounding box to window coordinate using ScrollView::conte ntToWindow().
4552
4553 * dom/Range.cpp:
4554 (WebCore::Range::getBoundingClientRect):
4555 (WebCore::Range::boundingRect):
4556 * dom/Range.h:
4557 * editing/Editor.cpp:
4558 (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
4559 (WebCore::Editor::correctionPanelTimerFired):
4560 (WebCore::Editor::windowRectForRange):
4561 * editing/Editor.h:
4562 * manual-tests/autocorrection/autocorrection-in-iframe.html: Added.
4563 * manual-tests/autocorrection/document-for-iframe-test.html: Added.
4564
4565 2011-03-04 Jia Pu <jpu@apple.com>
4566
4567 Reviewed by Darin Adler.
4568
4569 Those checking in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEd ited() should be done with VisiblePosition::isNull().
4570 https://bugs.webkit.org/show_bug.cgi?id=55731
4571
4572 No new tests. There's no behavioral change.
4573
4574 This patch improved clarity and readability of Editor::removeSpellAndCor rectionMarkersFromWordsToBeEdited().
4575
4576 * editing/Editor.cpp:
4577 (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
4578
4579 2011-03-04 John Bauman <jbauman@chromium.org>
4580
4581 Reviewed by Kenneth Russell.
4582
4583 [chromium] premultipliedAlpha WebGL context attribute is ignored.
4584 https://bugs.webkit.org/show_bug.cgi?id=55411
4585
4586 Update compositor to set the blending of each layer correctly.
4587
4588 Test: compositing/webgl/webgl-nonpremultiplied-blend.html
4589
4590 * platform/graphics/chromium/CanvasLayerChromium.cpp:
4591 (WebCore::CanvasLayerChromium::CanvasLayerChromium):
4592 (WebCore::CanvasLayerChromium::draw):
4593 * platform/graphics/chromium/CanvasLayerChromium.h:
4594 * platform/graphics/chromium/ContentLayerChromium.cpp:
4595 (WebCore::ContentLayerChromium::draw):
4596 * platform/graphics/chromium/LayerRendererChromium.cpp:
4597 (WebCore::LayerRendererChromium::drawLayers):
4598 * platform/graphics/chromium/WebGLLayerChromium.cpp:
4599 (WebCore::WebGLLayerChromium::setContext):
4600
4601 2011-03-04 Adam Barth <abarth@webkit.org>
4602
4603 Reviewed by Eric Seidel.
4604
4605 WebCore GYP build should link with the correct frameworks
4606 https://bugs.webkit.org/show_bug.cgi?id=55804
4607
4608 * gyp/WebCore.gyp:
4609
4610 2011-03-04 Adam Barth <abarth@webkit.org>
4611
4612 Reviewed by Eric Seidel.
4613
4614 WebCore GYP build should Check For Inappropriate Files in Framework
4615 https://bugs.webkit.org/show_bug.cgi?id=55806
4616
4617 * gyp/WebCore.gyp:
4618
4619 2011-03-04 Dimitri Glazkov <dglazkov@chromium.org>
4620
4621 Reviewed by Adam Barth.
4622
4623 Add skeletal WebCore.gyp
4624 https://bugs.webkit.org/show_bug.cgi?id=55802
4625
4626 This doesn't yet build, but the basic structure is there.
4627
4628 * WebCore.gypi: Added headers and include directories variables.
4629 * gyp/WebCore.gyp: Added.
4630
4631 2011-03-04 Adam Barth <abarth@webkit.org>
4632
4633 Reviewed by Dimitri Glazkov.
4634
4635 Remove unneeded round-trips through ../Source in the Chromium GYP build
4636 https://bugs.webkit.org/show_bug.cgi?id=55795
4637
4638 This is just cleanup work, but it was bugging me.
4639
4640 * WebCore.gyp/WebCore.gyp:
4641
4642 2011-03-04 Mike Reed <reed@google.com>
4643
4644 Reviewed by James Robinson.
4645
4646 Option to use skia's native text drawing APIs when drawing text
4647 on Windows, rather than from outlines using drawPath(). This will
4648 only have a significant effect when the skia-gpu backend is enabled.
4649 https://bugs.webkit.org/show_bug.cgi?id=55609
4650
4651 No new tests. This is disabled by default. When enabled, it will draw
4652 essentially the same, but with slightly different antialiased edges, due
4653 to differences between the current scanconverter and GDI's font scaler.
4654 When enabled, we will have to recalibrate layouttest image results.
4655
4656 * platform/graphics/skia/SkiaFontWin.cpp:
4657 (WebCore::skiaDrawText):
4658 (WebCore::setupPaintForFont):
4659 (WebCore::paintSkiaText):
4660
4661 2011-03-04 Adrienne Walker <enne@google.com>
4662
4663 Reviewed by James Robinson.
4664
4665 [chromium] Fix texture stride issues on large content and image layers.
4666 https://bugs.webkit.org/show_bug.cgi?id=55679
4667
4668 This was an error caused during the refactoring in r80081.
4669
4670 Tests: LayoutTests/compositing/tiling/huge-layer-img.html
4671
4672 * platform/graphics/chromium/ContentLayerChromium.cpp:
4673 (WebCore::ContentLayerChromium::updateTexture):
4674 * platform/graphics/chromium/ImageLayerChromium.cpp:
4675 (WebCore::ImageLayerChromium::updateTextureIfNeeded):
4676
4677 2011-03-04 Sheriff Bot <webkit.review.bot@gmail.com>
4678
4679 Unreviewed, rolling out r80379.
4680 http://trac.webkit.org/changeset/80379
4681 https://bugs.webkit.org/show_bug.cgi?id=55799
4682
4683 "Breaks leopard compile (implicit conversion)" (Requested by
4684 tonyg-cr on #webkit).
4685
4686 * css/CSSStyleSelector.cpp:
4687 (WebCore::convertToLength):
4688 (WebCore::CSSStyleSelector::applyProperty):
4689 (WebCore::CSSStyleSelector::createTransformOperations):
4690 * platform/Length.h:
4691 (WebCore::Length::Length):
4692 (WebCore::Length::operator==):
4693 (WebCore::Length::operator!=):
4694 (WebCore::Length::rawValue):
4695 (WebCore::Length::type):
4696 (WebCore::Length::quirk):
4697 (WebCore::Length::setValue):
4698 (WebCore::Length::setRawValue):
4699 (WebCore::Length::calcFloatValue):
4700 (WebCore::Length::isZero):
4701 (WebCore::Length::blend):
4702 * rendering/AutoTableLayout.cpp:
4703 (WebCore::AutoTableLayout::recalcColumn):
4704 (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
4705 * rendering/FixedTableLayout.cpp:
4706 (WebCore::FixedTableLayout::calcWidthArray):
4707
4708 2011-03-04 Jessie Berlin <jberlin@apple.com>
4709
4710 Reviewed by Darin Adler.
4711
4712 WebKit2: Use CFNetwork Sessions API.
4713 https://bugs.webkit.org/show_bug.cgi?id=55435.
4714
4715 Add in the CFURLSTORAGESESSIONS guards that I incorrectly left out becau se the code was
4716 contained within guards that made USE(CFURLSTORAGESESSIONS) always be tr ue.
4717
4718 * platform/network/cf/ResourceHandleCFNet.cpp:
4719 (WebCore::makeFinalRequest):
4720 (WebCore::ResourceHandle::willSendRequest):
4721 * platform/network/cf/ResourceRequestCFNet.cpp:
4722 * platform/network/mac/ResourceHandleMac.mm:
4723 (WebCore::ResourceHandle::createNSURLConnection):
4724 (WebCore::ResourceHandle::willSendRequest):
4725 * platform/network/mac/ResourceRequestMac.mm:
4726
4727 2011-03-04 Yuqiang Xian <yuqiang.xian@intel.com>
4728
4729 Reviewed by Darin Adler.
4730
4731 improve layout performance by reducing the traversal time of the floatin g objects
4732 https://bugs.webkit.org/show_bug.cgi?id=55440
4733
4734 We observered large overhead on traversing the floating objects list
4735 in logicalLeftOffsetForLine() and logicalRightOffsetForLine() especially
4736 when the list becomes enormous, for example in the default 30x30 maze te st
4737 from http://ie.microsoft.com/testdrive/Performance/MazeSolver/Default.ht ml
4738 there're >3700 floating objects. When placing a new floating object the
4739 entire list (from begin to end) is traversed for multiple times.
4740 There's a low hanging fruit to reduce the chances to do the traversal
4741 which is especially applicable in logicalLeftOffsetForLine and logicalRi ghtOffsetForLine.
4742 As the two routines either cares about FloatLeft objects or FloatRight o bjects only,
4743 if we know there's no corresponding type floating objects in the list
4744 we can avoid the traversal actually. One thing we could do is to record
4745 the number of FloatLeft objects and the number of FloatRight objects and
4746 add a check before doing the traversal. This can reduce the time by 45%
4747 to resolve the 30x30 Maze measured on N470 Netbook MeeGo using latest
4748 Chromium browser 11 (from 503s to 269s).
4749
4750 No new tests, relying on existing layout tests.
4751
4752 * rendering/RenderBlock.cpp:
4753 (WebCore::RenderBlock::~RenderBlock):
4754 (WebCore::RenderBlock::addOverflowFromFloats):
4755 (WebCore::RenderBlock::repaintOverhangingFloats):
4756 (WebCore::RenderBlock::paintFloats):
4757 (WebCore::RenderBlock::selectionGaps):
4758 (WebCore::RenderBlock::insertFloatingObject):
4759 (WebCore::RenderBlock::removeFloatingObject):
4760 (WebCore::RenderBlock::removeFloatingObjectsBelow):
4761 (WebCore::RenderBlock::positionNewFloats):
4762 (WebCore::RenderBlock::positionNewFloatOnLine):
4763 (WebCore::RenderBlock::logicalLeftOffsetForLine):
4764 (WebCore::RenderBlock::logicalRightOffsetForLine):
4765 (WebCore::RenderBlock::nextFloatLogicalBottomBelow):
4766 (WebCore::RenderBlock::lowestFloatLogicalBottom):
4767 (WebCore::RenderBlock::clearFloats):
4768 (WebCore::RenderBlock::addOverhangingFloats):
4769 (WebCore::RenderBlock::addIntrudingFloats):
4770 (WebCore::RenderBlock::containsFloat):
4771 (WebCore::RenderBlock::hitTestFloats):
4772 (WebCore::RenderBlock::adjustForBorderFit):
4773 (WebCore::RenderBlock::FloatingObjects::clear):
4774 (WebCore::RenderBlock::FloatingObjects::increaseObjectsCount):
4775 (WebCore::RenderBlock::FloatingObjects::decreaseObjectsCount):
4776 * rendering/RenderBlock.h:
4777 (WebCore::RenderBlock::containsFloats):
4778 (WebCore::RenderBlock::FloatingObjects::FloatingObjects):
4779 (WebCore::RenderBlock::FloatingObjects::hasLeftObjects):
4780 (WebCore::RenderBlock::FloatingObjects::hasRightObjects):
4781 (WebCore::RenderBlock::FloatingObjects::set):
4782 * rendering/RenderBlockLineLayout.cpp:
4783 (WebCore::RenderBlock::layoutInlineChildren):
4784 (WebCore::RenderBlock::matchedEndLine):
4785
4786 2011-03-04 Rik Cabanier <cabanier@gmail.com>
4787
4788 Reviewed by David Hyatt.
4789
4790 Fix that allows fixed length values to be floating point
4791 https://bugs.webkit.org/show_bug.cgi?id=52699
4792
4793 * WebCore.xcodeproj/project.pbxproj:
4794 * css/CSSStyleSelector.cpp:
4795 (WebCore::convertToLength):
4796 (WebCore::convertToIntLength):
4797 (WebCore::convertToFloatLength):
4798 (WebCore::CSSStyleSelector::applyProperty):
4799 (WebCore::CSSStyleSelector::createTransformOperations):
4800 * platform/Length.h:
4801 (WebCore::Length::Length):
4802 (WebCore::Length::operator==):
4803 (WebCore::Length::operator!=):
4804 (WebCore::Length::rawValue):
4805 (WebCore::Length::type):
4806 (WebCore::Length::quirk):
4807 (WebCore::Length::setValue):
4808 (WebCore::Length::calcFloatValue):
4809 (WebCore::Length::isZero):
4810 (WebCore::Length::blend):
4811 (WebCore::Length::getIntValue):
4812 (WebCore::Length::getFloatValue):
4813 * rendering/AutoTableLayout.cpp:
4814 (WebCore::AutoTableLayout::recalcColumn):
4815 (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
4816 * rendering/FixedTableLayout.cpp:
4817 (WebCore::FixedTableLayout::calcWidthArray):
4818
4819 2011-03-04 Steve Falkenburg <sfalken@apple.com>
4820
4821 Reviewed by Jon Honeycutt.
4822
4823 Adopt VersionStamper tool for Windows WebKit DLLs
4824 https://bugs.webkit.org/show_bug.cgi?id=55784
4825
4826 We now use a tool to stamp the version number onto the Apple WebKit DLLs
4827 during the post-build step.
4828
4829 * WebCore.vcproj/QTMovieWin.rc: Removed.
4830 * WebCore.vcproj/QTMovieWin.vcproj:
4831 * WebCore.vcproj/QTMovieWinPostBuild.cmd: Stamp version with VersionStam per.
4832 * WebCore.vcproj/QTMovieWinPreBuild.cmd: Don't run auto-version.sh. We d on't use autoversion.h in this project.
4833 * WebCore.vcproj/WebCoreMediaQT.vsprops: Remove unnecessary include path s for resource files.
4834
4835 2011-03-04 Cosmin Truta <ctruta@chromium.org>
4836
4837 Reviewed by Adam Barth.
4838
4839 Clarify comment about potential memory leak in SVGImage
4840 https://bugs.webkit.org/show_bug.cgi?id=55362
4841
4842 No functionality change. No new tests.
4843
4844 * svg/graphics/SVGImage.cpp:
4845 (WebCore::SVGImage::dataChanged):
4846
4847 2011-03-04 Jessie Berlin <jberlin@apple.com>
4848
4849 Reviewed by Maciej Stachowiak.
4850
4851 WebKit2: Use CFNetwork Sessions API.
4852 https://bugs.webkit.org/show_bug.cgi?id=55435.
4853
4854 When Private Browsing is enabled, get the cached url response from the c ache associated with
4855 the Private Browsing Storage Session.
4856
4857 * WebCore.exp.in:
4858 Export the symbol for ResourceHandle::privateBrowsingStorageSession.
4859
4860 2011-03-04 Steve Block <steveblock@google.com>
4861
4862 Reviewed by Jeremy Orlow.
4863
4864 JSC and V8 versions of Java bridge should share JobjectWrapper
4865 https://bugs.webkit.org/show_bug.cgi?id=55763
4866
4867 No new tests, refactoring only.
4868
4869 * Android.jscbindings.mk:
4870 * Android.v8bindings.mk:
4871 * WebCore.gypi:
4872 * WebCore.order:
4873 * WebCore.xcodeproj/project.pbxproj:
4874 * bridge/jni/JobjectWrapper.cpp:
4875 (JobjectWrapper::JobjectWrapper):
4876 (JobjectWrapper::~JobjectWrapper):
4877 * bridge/jni/JobjectWrapper.h:
4878 (JSC::Bindings::JobjectWrapper::instance):
4879 (JSC::Bindings::JobjectWrapper::setInstance):
4880 (JSC::Bindings::JobjectWrapper::ref):
4881 (JSC::Bindings::JobjectWrapper::deref):
4882 * bridge/jni/jsc/JNIBridgeJSC.cpp:
4883 (JavaField::JavaField):
4884 (JavaArray::JavaArray):
4885 * bridge/jni/jsc/JNIBridgeJSC.h:
4886 * bridge/jni/jsc/JavaInstanceJSC.cpp:
4887 (JavaInstance::JavaInstance):
4888 * bridge/jni/jsc/JavaInstanceJSC.h:
4889
4890 2011-03-04 Patrick Gansterer <paroga@webkit.org>
4891
4892 Reviewed by Nikolas Zimmermann.
4893
4894 Move shared code into SVGStyledTransformableElement::svgAttributeChanged
4895 https://bugs.webkit.org/show_bug.cgi?id=55771
4896
4897 All sub classes of SVGStyledTransformableElement request a relayout
4898 the same way. So move that code into the common base class.
4899
4900 * svg/SVGCircleElement.cpp:
4901 (WebCore::SVGCircleElement::svgAttributeChanged):
4902 * svg/SVGEllipseElement.cpp:
4903 (WebCore::SVGEllipseElement::svgAttributeChanged):
4904 * svg/SVGForeignObjectElement.cpp:
4905 (WebCore::SVGForeignObjectElement::svgAttributeChanged):
4906 * svg/SVGGElement.cpp:
4907 (WebCore::SVGGElement::svgAttributeChanged):
4908 * svg/SVGImageElement.cpp:
4909 (WebCore::SVGImageElement::svgAttributeChanged):
4910 * svg/SVGLineElement.cpp:
4911 (WebCore::SVGLineElement::svgAttributeChanged):
4912 * svg/SVGPathElement.cpp:
4913 (WebCore::SVGPathElement::svgAttributeChanged):
4914 * svg/SVGPolyElement.cpp:
4915 (WebCore::SVGPolyElement::svgAttributeChanged):
4916 * svg/SVGRectElement.cpp:
4917 (WebCore::SVGRectElement::svgAttributeChanged):
4918 * svg/SVGStyledTransformableElement.cpp:
4919 (WebCore::SVGStyledTransformableElement::svgAttributeChanged):
4920 * svg/SVGStyledTransformableElement.h:
4921 * svg/SVGUseElement.cpp:
4922 (WebCore::SVGUseElement::svgAttributeChanged):
4923
4924 2011-03-03 John Abd-El-Malek <jam@chromium.org>
4925
4926 Reviewed by Dimitri Glazkov.
4927
4928 [chromium] Get rid of IsContentFiltered flags since they&apos;re not use d anymore
4929 https://bugs.webkit.org/show_bug.cgi?id=55748
4930
4931 * platform/network/chromium/ResourceResponse.cpp:
4932 (WebCore::ResourceResponse::doPlatformCopyData):
4933 (WebCore::ResourceResponse::doPlatformAdopt):
4934 * platform/network/chromium/ResourceResponse.h:
4935 (WebCore::ResourceResponse::ResourceResponse):
4936
4937 2011-03-03 Timothy Hatcher <timothy@apple.com>
4938
4939 Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).
4940
4941 Reviewed by Darin Adler.
4942
4943 * WebCore.exp.in: Added __ZN7WebCore21SerializedScriptValue6createEPN3JS C9ExecStateENS1_7JSValueE.
4944
4945 2011-03-04 Pavel Podivilov <podivilov@chromium.org>
4946
4947 Reviewed by Yury Semikhatsky.
4948
4949 Web Inspector: extract all code that depends on source mapping from Sour ceFrame.
4950 https://bugs.webkit.org/show_bug.cgi?id=55464
4951
4952 Extract all dependencies on DebuggerModel and ScriptsPanel to a delegate class
4953 to encapsulate source mapping aspects from SourceFrame.
4954
4955 * inspector/front-end/ResourceView.js:
4956 (WebInspector.ResourceView.createResourceView):
4957 (WebInspector.SourceFrameDelegateForResourcesPanel):
4958 (WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestCont ent):
4959 * inspector/front-end/ScriptsPanel.js:
4960 (WebInspector.ScriptsPanel.prototype._createSourceFrame):
4961 (WebInspector.SourceFrameDelegateForScriptsPanel):
4962 * inspector/front-end/SourceFrame.js:
4963 (WebInspector.SourceFrame):
4964 (WebInspector.SourceFrame.prototype.show):
4965 (WebInspector.SourceFrame.prototype._createTextViewer):
4966 (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoin t.didEditBreakpointCondition):
4967 (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoin t):
4968 (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCond ition.didEditBreakpointCondition):
4969 (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCond ition):
4970 (WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabl ed):
4971 (WebInspector.SourceFrame.prototype._contextMenu):
4972 (WebInspector.SourceFrame.prototype._mouseDown):
4973 (WebInspector.SourceFrame.prototype._mouseMove):
4974 (WebInspector.SourceFrame.prototype._hidePopup):
4975 (WebInspector.SourceFrame.prototype._mouseHover):
4976 (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
4977 (WebInspector.SourceFrame.prototype._showPopup):
4978 (WebInspector.SourceFrame.prototype._doubleClick):
4979 (WebInspector.SourceFrame.prototype._didEditLine):
4980 (WebInspector.SourceFrameDelegate):
4981 (WebInspector.SourceFrameDelegate.prototype.requestContent):
4982 (WebInspector.SourceFrameDelegate.prototype.debuggingSupported):
4983 (WebInspector.SourceFrameDelegate.prototype.setBreakpoint):
4984 (WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
4985 (WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
4986 (WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
4987 (WebInspector.SourceFrameDelegate.prototype.continueToLine):
4988 (WebInspector.SourceFrameDelegate.prototype.canEditScriptSource):
4989 (WebInspector.SourceFrameDelegate.prototype.editScriptSource):
4990 (WebInspector.SourceFrameDelegate.prototype.debuggerPaused):
4991 (WebInspector.SourceFrameDelegate.prototype.evaluate):
4992 (WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
4993
4994 2011-03-04 Andrey Kosyakov <caseq@chromium.org>
4995
4996 Reviewed by Pavel Feldman.
4997
4998 Web Inspector: [Extensions API] maintain own, unique & persistent identi fiers for resources.
4999 https://bugs.webkit.org/show_bug.cgi?id=55686
5000
5001 - Use internal ids for resources in extension server.
5002 - Log errors in inspector tests.
5003
5004 * inspector/front-end/ExtensionServer.js:
5005 (WebInspector.ExtensionServer):
5006 (WebInspector.ExtensionServer.prototype.resetResources):
5007 (WebInspector.ExtensionServer.prototype._notifyResourceFinished):
5008 (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
5009 (WebInspector.ExtensionServer.prototype._onGetHAR):
5010 (WebInspector.ExtensionServer.prototype._onGetResourceContent):
5011 (WebInspector.ExtensionServer.prototype._resourceId):
5012 (WebInspector.ExtensionServer.prototype._resourceById):
5013 * inspector/front-end/HAREntry.js:
5014 (WebInspector.HARLog):
5015 (WebInspector.HARLog.prototype._convertResource):
5016 * inspector/front-end/NetworkPanel.js:
5017 (WebInspector.NetworkPanel.prototype._reset):
5018
5019 2011-03-04 Andrey Kosyakov <caseq@chromium.org>
5020
5021 Reviewed by Pavel Feldman.
5022
5023 Web Inspector: exceptions when building context menu in network panel
5024 https://bugs.webkit.org/show_bug.cgi?id=55678
5025
5026 * inspector/front-end/DataGrid.js:
5027 (WebInspector.DataGrid.prototype.dataGridNodeFromNode):
5028 (WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
5029 * inspector/front-end/NetworkPanel.js:
5030 (WebInspector.NetworkPanel.prototype._contextMenu):
5031
5032 2011-03-04 Ilya Sherman <isherman@chromium.org>
5033
5034 Reviewed by James Robinson.
5035
5036 Override paintScrollCorner() for FramelessScrollView to forego any custo m scrollbar corner rendering.
5037 This was previously done in ScrollbarThemeChromium, but we also need thi s on the Mac when the ScrollView
5038 is a FramelessScrollView -- which is mostly just for Autofill.
5039 In service of http://crbug.com/73772 (crash)
5040 https://bugs.webkit.org/show_bug.cgi?id=55557
5041
5042 No tests added because this fix is Chromium-specific and the code is cur rently untestable from within WebKit.
5043 In particular, DRT crashes when trying to render a FramelessScrollView.
5044
5045 * platform/ScrollbarTheme.h:
5046 (WebCore::ScrollbarTheme::paintScrollCorner): Body moved to static funct ion defaultPaintScrollCorner().
5047 (WebCore::ScrollbarTheme::defaultPaintScrollCorner): Added.
5048 * platform/chromium/FramelessScrollView.cpp:
5049 (WebCore::FramelessScrollView::paintContents):
5050 (WebCore::FramelessScrollView::paintScrollCorner): Fix implementation mo ved to here from ScrollbarThemeChromium
5051 * platform/chromium/FramelessScrollView.h:
5052 * platform/chromium/ScrollbarThemeChromium.cpp:
5053 * platform/chromium/ScrollbarThemeChromium.h:
5054
5055 2011-03-04 Yury Semikhatsky <yurys@chromium.org>
5056
5057 Reviewed by Pavel Feldman.
5058
5059 Web Inspector: move dispatching of didCommitLoad to agents into Inspecto rInstrumentation
5060 https://bugs.webkit.org/show_bug.cgi?id=55770
5061
5062 * inspector/InspectorAgent.cpp:
5063 (WebCore::InspectorAgent::InspectorAgent):
5064 (WebCore::InspectorAgent::didCommitLoad):
5065 * inspector/InspectorCSSAgent.cpp:
5066 (WebCore::InspectorCSSAgent::InspectorCSSAgent):
5067 (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
5068 * inspector/InspectorCSSAgent.h:
5069 * inspector/InspectorDatabaseAgent.cpp:
5070 (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
5071 * inspector/InspectorInstrumentation.cpp:
5072 (WebCore::InspectorInstrumentation::didCommitLoadImpl):
5073 * inspector/InspectorInstrumentation.h:
5074 (WebCore::InspectorInstrumentation::didCommitLoad):
5075 * inspector/InspectorProfilerAgent.cpp:
5076 (WebCore::InspectorProfilerAgent::create):
5077 (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
5078 (WebCore::InspectorProfilerAgent::~InspectorProfilerAgent):
5079 (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
5080 (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
5081 (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
5082 (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
5083 * inspector/InspectorProfilerAgent.h:
5084 * inspector/InstrumentingAgents.h:
5085 (WebCore::InstrumentingAgents::InstrumentingAgents):
5086 (WebCore::InstrumentingAgents::inspectorCSSAgent):
5087 (WebCore::InstrumentingAgents::setInspectorCSSAgent):
5088 (WebCore::InstrumentingAgents::inspectorDOMStorageAgent):
5089 (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent):
5090 (WebCore::InstrumentingAgents::inspectorDatabaseAgent):
5091 (WebCore::InstrumentingAgents::setInspectorDatabaseAgent):
5092 (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
5093 (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
5094 (WebCore::InstrumentingAgents::inspectorDebuggerAgent):
5095 (WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
5096 (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent):
5097 (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent):
5098 (WebCore::InstrumentingAgents::inspectorProfilerAgent):
5099 (WebCore::InstrumentingAgents::setInspectorProfilerAgent):
5100
5101 2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>
5102
5103 Reviewed by Yury Semikhatsky.
5104
5105 Web Inspector: rename RuntimeAgent's function from releaseWrapperObjectG roup to releaseObjectGroup.
5106 https://bugs.webkit.org/show_bug.cgi?id=55773
5107
5108 * inspector/CodeGeneratorInspector.pm:
5109 * inspector/InjectedScript.cpp:
5110 (WebCore::InjectedScript::releaseObjectGroup):
5111 * inspector/InjectedScript.h:
5112 * inspector/InjectedScriptHost.cpp:
5113 (WebCore::InjectedScriptHost::releaseObjectGroup):
5114 * inspector/InjectedScriptHost.h:
5115 * inspector/InjectedScriptSource.js:
5116 (.):
5117 * inspector/Inspector.idl:
5118 * inspector/InspectorConsoleAgent.cpp:
5119 (WebCore::InspectorConsoleAgent::clearConsoleMessages):
5120 * inspector/InspectorRuntimeAgent.cpp:
5121 (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
5122 * inspector/InspectorRuntimeAgent.h:
5123 * inspector/front-end/ConsoleView.js:
5124 (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
5125 (WebInspector.ConsoleView.prototype.completions):
5126 * inspector/front-end/PropertiesSidebarPane.js:
5127 * inspector/front-end/SourceFrame.js:
5128 (WebInspector.SourceFrame.prototype._hidePopup):
5129 * inspector/front-end/WatchExpressionsSidebarPane.js:
5130 (WebInspector.WatchExpressionsSection.prototype.update):
5131
5132 2011-03-02 Andrey Adaikin <aandrey@google.com>
5133
5134 Reviewed by Pavel Feldman.
5135
5136 Web Inspector: Gutter height should be 100% when few lines are displayed
5137 https://bugs.webkit.org/show_bug.cgi?id=55574
5138
5139 * inspector/front-end/SourceFrame.js:
5140 (WebInspector.SourceFrame.prototype._startEditing):
5141 * inspector/front-end/TextViewer.js:
5142 (WebInspector.TextViewer.prototype._syncScroll):
5143 (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
5144 (WebInspector.TextEditorGutterPanel.prototype.textChanged):
5145 (WebInspector.TextEditorGutterPanel.prototype.syncClientHeight):
5146 * inspector/front-end/textViewer.css:
5147 (.text-editor-lines):
5148 (.text-editor-contents .inner-container):
5149 (.webkit-line-number):
5150
5151 2011-03-04 Andrey Adaikin <aandrey@google.com>
5152
5153 Reviewed by Pavel Feldman.
5154
5155 Web Inspector: [Text editor] Do bisect to find visible chunks
5156 https://bugs.webkit.org/show_bug.cgi?id=55685
5157
5158 * inspector/front-end/TextViewer.js:
5159 (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
5160 (WebInspector.TextEditorChunkedPanel.prototype._findVisibleChunks):
5161 (WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
5162 (WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
5163 (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
5164 (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
5165
5166 2011-03-04 Andrey Adaikin <aandrey@google.com>
5167
5168 Reviewed by Pavel Feldman.
5169
5170 Web Inspector: [Text editor] DOMNodeRemoved events are missing
5171 https://bugs.webkit.org/show_bug.cgi?id=55769
5172
5173 * inspector/front-end/TextViewer.js:
5174 (WebInspector.TextEditorMainPanel):
5175 (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
5176 (WebInspector.TextEditorMainChunk):
5177 (WebInspector.TextEditorMainChunk.prototype._createRow):
5178
5179 2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>
5180
5181 Reviewed by Yury Semikhatsky.
5182
5183 Web Inspector: Remove unnecessary domain and success flags from the resp onse messages.
5184 https://bugs.webkit.org/show_bug.cgi?id=55768
5185
5186 We have domain property in the response messages but it is not used beca use we dispatch
5187 the responses on the callback associated with seq.
5188
5189 If we have property 'errors' in the response then success eq false and t rue in the other case.
5190
5191 * inspector/CodeGeneratorInspector.pm:
5192
5193 2011-03-04 Christian Dywan <christian@lanedo.com>
5194
5195 Reviewed by Gustavo Noronha Silva.
5196
5197 Enable Copy Image Address context menu item in the Gtk port
5198 https://bugs.webkit.org/show_bug.cgi?id=55136
5199
5200 * page/ContextMenuController.cpp:
5201 * platform/ContextMenuItem.h:
5202 * platform/LocalizationStrategy.h:
5203 * platform/LocalizedStrings.cpp:
5204 * platform/LocalizedStrings.h:
5205 * platform/gtk/ContextMenuItemGtk.cpp:
5206 * platform/gtk/LocalizedStringsGtk.cpp:
5207
5208 2011-03-04 Pavel Feldman <pfeldman@chromium.org>
5209
5210 Reviewed by Yury Semikhatsky.
5211
5212 Web Inspector: implement getCompletions via evaluate.
5213 https://bugs.webkit.org/show_bug.cgi?id=55759
5214
5215 * inspector/InjectedScript.cpp:
5216 * inspector/InjectedScript.h:
5217 * inspector/InjectedScriptSource.js:
5218 * inspector/Inspector.idl:
5219 * inspector/InspectorDebuggerAgent.cpp:
5220 * inspector/InspectorDebuggerAgent.h:
5221 * inspector/InspectorRuntimeAgent.cpp:
5222 * inspector/InspectorRuntimeAgent.h:
5223 * inspector/front-end/ConsoleView.js:
5224 (WebInspector.ConsoleView.prototype.completions.evaluated):
5225 (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
5226 (WebInspector.ConsoleView.prototype.completions):
5227 (WebInspector.ConsoleView.prototype._reportCompletions):
5228 * inspector/front-end/ScriptsPanel.js:
5229 (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatin gCallbackWrapper):
5230 (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
5231 * inspector/front-end/SourceFrame.js:
5232 (WebInspector.SourceFrame.prototype._showPopup):
5233 (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
5234
5235 2011-03-04 Steve Block <steveblock@google.com>
5236
5237 Reviewed by Jeremy Orlow.
5238
5239 V8 version of JavaString should obtain string from JNI in UTF-16 encodin g
5240 https://bugs.webkit.org/show_bug.cgi?id=55566
5241
5242 We obtain the string from JNI in UTF-16 encoding and convert
5243 to UTF-8 using our own routines as required. This matches the
5244 behaviour of the JSC version of JavaString.
5245
5246 No new tests, no change in behaviour.
5247
5248 * bridge/jni/v8/JavaStringV8.h:
5249 (JSC::Bindings::JavaStringImpl::init):
5250 (JSC::Bindings::JavaStringImpl::utf8):
5251 (JSC::Bindings::JavaStringImpl::impl):
5252
5253 2011-03-03 Pavel Feldman <pfeldman@chromium.org>
5254
5255 Reviewed by Yury Semikhatsky.
5256
5257 Web Inspector: do not push document into front-end, make it request one.
5258 https://bugs.webkit.org/show_bug.cgi?id=55664
5259
5260 * inspector/Inspector.idl:
5261 * inspector/InspectorAgent.cpp:
5262 (WebCore::InspectorAgent::InspectorAgent):
5263 * inspector/InspectorAgent.h:
5264 * inspector/InspectorBrowserDebuggerAgent.cpp:
5265 (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
5266 * inspector/InspectorDOMAgent.cpp:
5267 (WebCore::InspectorDOMAgent::InspectorDOMAgent):
5268 (WebCore::InspectorDOMAgent::clearFrontend):
5269 (WebCore::InspectorDOMAgent::setDocument):
5270 (WebCore::InspectorDOMAgent::getDocument):
5271 (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
5272 (WebCore::InspectorDOMAgent::boundNodeId):
5273 (WebCore::InspectorDOMAgent::resolveNode):
5274 (WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
5275 * inspector/InspectorDOMAgent.h:
5276 (WebCore::InspectorDOMAgent::create):
5277 * inspector/front-end/BreakpointManager.js:
5278 (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints):
5279 (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.d ecorateNode):
5280 (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
5281 * inspector/front-end/DOMAgent.js:
5282 (WebInspector.DOMDocument):
5283 (WebInspector.DOMAgent):
5284 (WebInspector.DOMAgent.prototype.requestDocument):
5285 (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
5286 (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
5287 (WebInspector.DOMAgent.prototype._attributesUpdated):
5288 (WebInspector.DOMAgent.prototype._characterDataModified):
5289 (WebInspector.DOMAgent.prototype._documentUpdated):
5290 (WebInspector.DOMAgent.prototype._setDocument):
5291 (WebInspector.DOMAgent.prototype._setDetachedRoot):
5292 (WebInspector.DOMAgent.prototype._setChildNodes):
5293 (WebInspector.DOMAgent.prototype._childNodeInserted):
5294 (WebInspector.DOMAgent.prototype._childNodeRemoved):
5295 (WebInspector.DOMDispatcher.prototype.documentUpdated):
5296 * inspector/front-end/ElementsPanel.js:
5297 (WebInspector.ElementsPanel.prototype.show):
5298 (WebInspector.ElementsPanel.prototype.setDocument):
5299 * inspector/front-end/MetricsSidebarPane.js:
5300 * inspector/front-end/RemoteObject.js:
5301 (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
5302
5303 2011-03-04 Andrey Kosyakov <caseq@chromium.org>
5304
5305 Reviewed by Pavel Feldman.
5306
5307 Web Inspector: summary bar may overlap content of the network item view
5308 https://bugs.webkit.org/show_bug.cgi?id=55656
5309
5310 - drop custom summary bar placement logic, do it with CSS instead.
5311
5312 * inspector/front-end/NetworkPanel.js:
5313 (WebInspector.NetworkPanel.prototype.resize):
5314 (WebInspector.NetworkPanel.prototype._createSummaryBar):
5315 (WebInspector.NetworkPanel.prototype._updateSummaryBar):
5316 (WebInspector.NetworkPanel.prototype._updateFilter):
5317 (WebInspector.NetworkPanel.prototype.show):
5318 (WebInspector.NetworkPanel.prototype.refresh):
5319 (WebInspector.NetworkPanel.prototype._reset):
5320 (WebInspector.NetworkPanel.prototype._setLargerResources):
5321 (WebInspector.NetworkPanel.prototype._updateOffscreenRows):
5322 * inspector/front-end/networkPanel.css:
5323 (.network-sidebar .data-grid td):
5324 (.network-sidebar tr.filler td):
5325 (.network-summary-bar):
5326 (.network-sidebar .data-grid .network-summary-bar td):
5327 (.network-summary-bar img):
5328
5329 2011-03-04 James Su <suzhe@chromium.org>
5330
5331 Reviewed by Dimitri Glazkov.
5332
5333 [Chromium] keycode is always 0 when using non-Latin keyboard layout.
5334 https://bugs.webkit.org/show_bug.cgi?id=54939
5335
5336 Add KeyEventCocoa.{h,mm}, so that we can reuse them in chromium.
5337
5338 No intended functionality change.
5339
5340 * WebCore.gyp/WebCore.gyp:
5341 * WebCore.gypi:
5342
5343 2011-03-04 Patrick Gansterer <paroga@webkit.org>
5344
5345 Unreviewed EFL build fix for r80324.
5346
5347 * platform/efl/RenderThemeEfl.cpp:
5348 (WebCore::RenderThemeEfl::paintThemePart):
5349
5350 2011-03-04 Patrick Gansterer <paroga@webkit.org>
5351
5352 Unreviewed EFL build fix for r80324.
5353
5354 * platform/efl/RenderThemeEfl.cpp:
5355 (WebCore::RenderThemeEfl::paintThemePart):
5356
5357 2011-03-03 Yury Semikhatsky <yurys@chromium.org>
5358
5359 Reviewed by Pavel Feldman.
5360
5361 Web Inspector: AppCache agent should have same lifetime as InspectorAgen t
5362 https://bugs.webkit.org/show_bug.cgi?id=55673
5363
5364 * inspector/InspectorAgent.cpp:
5365 (WebCore::InspectorAgent::InspectorAgent):
5366 (WebCore::InspectorAgent::setFrontend):
5367 (WebCore::InspectorAgent::disconnectFrontend):
5368 (WebCore::InspectorAgent::createFrontendLifetimeAgents):
5369 (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
5370 (WebCore::InspectorAgent::didCommitLoad):
5371 * inspector/InspectorApplicationCacheAgent.cpp:
5372 (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent ):
5373 (WebCore::InspectorApplicationCacheAgent::setFrontend):
5374 (WebCore::InspectorApplicationCacheAgent::clearFrontend):
5375 * inspector/InspectorApplicationCacheAgent.h:
5376 * inspector/InspectorInstrumentation.cpp:
5377 (WebCore::InspectorInstrumentation::networkStateChangedImpl):
5378 (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
5379 * inspector/InstrumentingAgents.h:
5380 (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
5381 (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
5382
5383 2011-03-03 Brian Weinstein <bweinstein@apple.com>
5384
5385 Reviewed by Adam Roben.
5386
5387 Cleanup from https://bugs.webkit.org/show_bug.cgi?id=55427.
5388
5389 Call WebCore::startObservingCookieChanges and WebCore::stopObservingCook ieChanges
5390 on all platforms, and stub the functions on platforms that don't impleme nt them.
5391
5392 Add startObservingCookieChanges and stopObservingCookieChanges to Tempor aryLinkStubs
5393 for platforms that don't implement them.
5394
5395 * platform/android/TemporaryLinkStubs.cpp:
5396 * platform/brew/TemporaryLinkStubs.cpp:
5397 * platform/chromium/TemporaryLinkStubs.cpp:
5398 * platform/efl/TemporaryLinkStubs.cpp:
5399 * platform/gtk/TemporaryLinkStubs.cpp:
5400 * platform/haiku/TemporaryLinkStubs.cpp:
5401 * platform/qt/TemporaryLinkStubsQt.cpp:
5402 * platform/win/TemporaryLinkStubs.cpp:
5403
5404 2011-03-03 Eric Seidel <eric@webkit.org>
5405
5406 Reviewed by Dimitri Glazkov.
5407
5408 Refactor createRendererIfNeeded to avoid premature nextRenderer calculat ion
5409 https://bugs.webkit.org/show_bug.cgi?id=55720
5410
5411 There are two thing going on here:
5412 1. Delaying nextRenderer calculation until we actually use it,
5413 previously we would always compute nextRenderer (expensive!)
5414 even if no renderer insertion was to occur.
5415 2. Fix fullscreen elements to be inserted into the right place
5416 in the rendering tree. Previously they would always be the last
5417 child in their parent's list, even if that wasn't the right place.
5418
5419 I don't know of any way to trigger the fullscreen bug,
5420 but I tested this with peacekeeper and saw no performance change.
5421
5422 Peacekeeper's domJQueryBasics is now possibly as much as 2% faster
5423 but I don't really trust the stability of peacekeeper to begin with.
5424
5425 This paves the way for further improvement in our nextRenderer calculati on.
5426
5427 * dom/Node.cpp:
5428 (WebCore::Node::attach):
5429 (WebCore::Node::previousRenderer):
5430 (WebCore::Node::nextRenderer):
5431 (WebCore::Node::createRendererAndStyle):
5432 (WebCore::wrapWithRenderFullScreen):
5433 (WebCore::Node::createRendererIfNeeded):
5434 * dom/Node.h:
5435
5436 2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
5437
5438 Reviewed by Darin Adler.
5439
5440 Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
5441 https://bugs.webkit.org/show_bug.cgi?id=55554
5442
5443 * platform/Length.cpp:
5444 (WebCore::newLengthArray): Pass nullptr instead of 0.
5445
5446 2011-03-03 Nat Duca <nduca@chromium.org>
5447
5448 Reviewed by James Robinson.
5449
5450 [chromium] Create a LayerChromium layerTreeAsText. Add HUD to
5451 LayerRendererChromium that draws compositor FPS and, optionally,
5452 the layer tree.
5453 https://bugs.webkit.org/show_bug.cgi?id=54710
5454
5455 * WebCore.gypi:
5456 * platform/graphics/chromium/Canvas2DLayerChromium.h:
5457 (WebCore::Canvas2DLayerChromium::drawsContent):
5458 * platform/graphics/chromium/CanvasLayerChromium.h:
5459 (WebCore::CanvasLayerChromium::layerTypeAsString):
5460 * platform/graphics/chromium/ContentLayerChromium.cpp:
5461 (WebCore::writeIndent):
5462 (WebCore::ContentLayerChromium::dumpLayerProperties):
5463 * platform/graphics/chromium/ContentLayerChromium.h:
5464 (WebCore::ContentLayerChromium::drawsContent):
5465 (WebCore::ContentLayerChromium::layerTypeAsString):
5466 * platform/graphics/chromium/GraphicsLayerChromium.cpp:
5467 (WebCore::GraphicsLayerChromium::setName):
5468 (WebCore::GraphicsLayerChromium::updateNames):
5469 (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
5470 (WebCore::GraphicsLayerChromium::setupContentsLayer):
5471 * platform/graphics/chromium/GraphicsLayerChromium.h:
5472 * platform/graphics/chromium/ImageLayerChromium.h:
5473 (WebCore::ImageLayerChromium::drawsContent):
5474 (WebCore::ImageLayerChromium::layerTypeAsString):
5475 * platform/graphics/chromium/LayerChromium.cpp:
5476 (WebCore::LayerChromium::LayerChromium):
5477 (WebCore::LayerChromium::setName):
5478 (WebCore::LayerChromium::layerTreeAsText):
5479 (WebCore::writeIndent):
5480 (WebCore::LayerChromium::dumpLayer):
5481 (WebCore::LayerChromium::dumpLayerProperties):
5482 * platform/graphics/chromium/LayerChromium.h:
5483 (WebCore::LayerChromium::name):
5484 (WebCore::LayerChromium::drawsContent):
5485 (WebCore::LayerChromium::debugID):
5486 (WebCore::LayerChromium::layerTypeAsString):
5487 * platform/graphics/chromium/LayerRendererChromium.cpp:
5488 (WebCore::LayerRendererChromium::LayerRendererChromium):
5489 (WebCore::LayerRendererChromium::~LayerRendererChromium):
5490 (WebCore::LayerRendererChromium::drawLayers):
5491 (WebCore::LayerRendererChromium::present):
5492 (WebCore::LayerRendererChromium::layerTreeAsText):
5493 (WebCore::LayerRendererChromium::dumpRenderSurfaces):
5494 * platform/graphics/chromium/LayerRendererChromium.h:
5495 (WebCore::LayerRendererChromium::getHeadsUpDisplay):
5496 (WebCore::LayerRendererChromium::rootVisibleRect):
5497 * platform/graphics/chromium/PluginLayerChromium.h:
5498 (WebCore::PluginLayerChromium::drawsContent):
5499 (WebCore::PluginLayerChromium::layerTypeAsString):
5500 * platform/graphics/chromium/RenderSurfaceChromium.cpp:
5501 (WebCore::RenderSurfaceChromium::name):
5502 (WebCore::writeIndent):
5503 (WebCore::RenderSurfaceChromium::dumpSurface):
5504 * platform/graphics/chromium/RenderSurfaceChromium.h:
5505 * platform/graphics/chromium/VideoLayerChromium.h:
5506 (WebCore::VideoLayerChromium::drawsContent):
5507 (WebCore::VideoLayerChromium::layerTypeAsString):
5508 * platform/graphics/chromium/WebGLLayerChromium.h:
5509 (WebCore::WebGLLayerChromium::drawsContent):
5510 (WebCore::WebGLLayerChromium::layerTypeAsString):
5511 * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: Added.
5512 (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
5513 (WebCore::CCHeadsUpDisplay::~CCHeadsUpDisplay):
5514 (WebCore::CCHeadsUpDisplay::draw):
5515 (WebCore::CCHeadsUpDisplay::drawHudContents):
5516 (WebCore::CCHeadsUpDisplay::onPresent):
5517 * platform/graphics/chromium/cc/CCHeadsUpDisplay.h: Added.
5518 (WebCore::CCHeadsUpDisplay::setShowFPSCounter):
5519 (WebCore::CCHeadsUpDisplay::showFPSCounter):
5520 (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
5521 (WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
5522 (WebCore::CCHeadsUpDisplay::enabled):
5523 * platform/graphics/chromium/cc/CCLayerImpl.cpp:
5524 (WebCore::CCLayerImpl::CCLayerImpl):
5525 (WebCore::writeIndent):
5526 (WebCore::CCLayerImpl::dumpLayerProperties):
5527 * platform/graphics/chromium/cc/CCLayerImpl.h:
5528 (WebCore::CCLayerImpl::debugID):
5529 (WebCore::CCLayerImpl::setName):
5530 (WebCore::CCLayerImpl::name):
5531
5532 2011-03-02 Ojan Vafai <ojan@chromium.org>
5533
5534 Reviewed by Darin Adler.
5535
5536 crash in adoptNode with mutation events
5537 https://bugs.webkit.org/show_bug.cgi?id=50046
5538
5539 If the DOM is modified during the removeChild call in adoptNode,
5540 then the setDocument call that follows can leave the DOM in an
5541 inconsistent state.
5542
5543 * dom/Document.cpp:
5544 (WebCore::Document::adoptNode):
5545
5546 2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
5547
5548 Reviewed by Darin Adler.
5549
5550 Add audio tag tests to the media controls manual test suite.
5551 https://bugs.webkit.org/show_bug.cgi?id=55722
5552
5553 * manual-tests/media-controls.html: Added 4 audio tests.
5554
5555 2011-03-03 Gyuyoung Kim <gyuyoung.kim@samsung.com>
5556
5557 Reviewed by Eric Seidel.
5558
5559 [EFL] Adjust functions of RenderThemeEfl.cpp to WebKit parameter style
5560 https://bugs.webkit.org/show_bug.cgi?id=54392
5561
5562 Functions of RenderThemeEfl.cpp adhere efl coding style instead of WebKi t coding style.
5563 WebCore's functions should adhere WebKit coding style.
5564
5565 * platform/efl/RenderThemeEfl.cpp:
5566 (WebCore::RenderThemeEfl::themePartCacheEntryReset):
5567 (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
5568 (WebCore::RenderThemeEfl::cacheThemePartNew):
5569 (WebCore::RenderThemeEfl::cacheThemePartReset):
5570 (WebCore::RenderThemeEfl::cacheThemePartResizeAndReset):
5571 (WebCore::RenderThemeEfl::cacheThemePartGet):
5572 (WebCore::RenderThemeEfl::cacheThemePartFlush):
5573 (WebCore::RenderThemeEfl::applyEdjeStateFromForm):
5574 (WebCore::RenderThemeEfl::paintThemePart):
5575 (WebCore::renderThemeEflColorClassSelectionActive):
5576 (WebCore::renderThemeEflColorClassSelectionInactive):
5577 (WebCore::renderThemeEflColorClassFocusRing):
5578 (WebCore::renderThemeEflColorClassButtonText):
5579 (WebCore::renderThemeEflColorClassComboText):
5580 (WebCore::renderThemeEflColorClassEntryText):
5581 (WebCore::renderThemeEflColorClassSearchText):
5582 (WebCore::RenderThemeEfl::applyPartDescription):
5583 (WebCore::RenderThemeEfl::applyPartDescriptions):
5584 (WebCore::RenderThemeEfl::controlSupportsTints):
5585 (WebCore::RenderThemeEfl::baselinePosition):
5586 (WebCore::RenderThemeEfl::paintSliderTrack):
5587 (WebCore::RenderThemeEfl::adjustSliderTrackStyle):
5588 (WebCore::RenderThemeEfl::adjustSliderThumbStyle):
5589 (WebCore::RenderThemeEfl::paintSliderThumb):
5590 (WebCore::RenderThemeEfl::adjustCheckboxStyle):
5591 (WebCore::RenderThemeEfl::paintCheckbox):
5592 (WebCore::RenderThemeEfl::adjustRadioStyle):
5593 (WebCore::RenderThemeEfl::paintRadio):
5594 (WebCore::RenderThemeEfl::adjustButtonStyle):
5595 (WebCore::RenderThemeEfl::paintButton):
5596 (WebCore::RenderThemeEfl::adjustMenuListStyle):
5597 (WebCore::RenderThemeEfl::paintMenuList):
5598 (WebCore::RenderThemeEfl::adjustTextFieldStyle):
5599 (WebCore::RenderThemeEfl::paintTextField):
5600 (WebCore::RenderThemeEfl::adjustTextAreaStyle):
5601 (WebCore::RenderThemeEfl::paintTextArea):
5602 (WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
5603 (WebCore::RenderThemeEfl::paintSearchFieldDecoration):
5604 (WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
5605 (WebCore::RenderThemeEfl::paintSearchFieldResultsButton):
5606 (WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
5607 (WebCore::RenderThemeEfl::paintSearchFieldResultsDecoration):
5608 (WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
5609 (WebCore::RenderThemeEfl::paintSearchFieldCancelButton):
5610 (WebCore::RenderThemeEfl::adjustSearchFieldStyle):
5611 (WebCore::RenderThemeEfl::paintSearchField):
5612 (WebCore::RenderThemeEfl::adjustProgressBarStyle):
5613 (WebCore::RenderThemeEfl::paintProgressBar):
5614 (WebCore::RenderThemeEfl::paintMediaFullscreenButton):
5615 (WebCore::RenderThemeEfl::paintMediaMuteButton):
5616 (WebCore::RenderThemeEfl::paintMediaPlayButton):
5617 (WebCore::RenderThemeEfl::paintMediaSeekBackButton):
5618 (WebCore::RenderThemeEfl::paintMediaSeekForwardButton):
5619 (WebCore::RenderThemeEfl::paintMediaSliderTrack):
5620 (WebCore::RenderThemeEfl::paintMediaSliderThumb):
5621 (WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer):
5622 (WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack):
5623 (WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb):
5624 (WebCore::RenderThemeEfl::paintMediaCurrentTime):
5625
5626 2011-03-03 Andy Estes <aestes@apple.com>
5627
5628 Reviewed by Adam Barth.
5629
5630 Assertion failure in toElement(WebCore::Node*)
5631 https://bugs.webkit.org/show_bug.cgi?id=55697
5632
5633 Test: fast/parser/fragment-foreign-content.html
5634
5635 * html/parser/HTMLTreeBuilder.cpp:
5636 (WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken): The current
5637 element in the HTMLElementStack might be a DocumentFragment if a
5638 fragment is being parsed who's first node is foreign content.
5639
5640 2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
5641
5642 Reviewed by Kenneth Rohde Christiansen.
5643
5644 [QT] Implement mock client-based geolocation for layout testing
5645 https://bugs.webkit.org/show_bug.cgi?id=54334
5646
5647 Implements client() to GeolocationController to re-use geolocationClient Mock class
5648 for layout testing purpose.
5649
5650 * page/GeolocationController.h:
5651 (WebCore::GeolocationController::client):
5652
5653 2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
5654
5655 Reviewed by Kent Tamura.
5656
5657 Stop calling deprecatedNode and deprecatedEditingOffset in InsertTextCom mand
5658 https://bugs.webkit.org/show_bug.cgi?id=55352
5659
5660 Stopped calling deprecatedNode and deprecatedEditingOffset in the follow ing functions:
5661
5662 * editing/CompositeEditCommand.cpp:
5663 (WebCore::CompositeEditCommand::positionOutsideTabSpan): Takes care of a ll types of positions and
5664 no longer calls deprecated functions.
5665 * editing/InsertTextCommand.cpp:
5666 (WebCore::InsertTextCommand::positionInsideTextNode): Ditto; renamed fro m prepareForTextInsertion.
5667 Check if the text node inside a tab span before checking if the containe r node is a text node
5668 because the position before or after a text node can still be inside a t ab span.
5669 (WebCore::InsertTextCommand::input): No longer calls deprecated function s.
5670 * editing/InsertTextCommand.h:
5671 * editing/ModifySelectionListLevel.cpp:
5672 (WebCore::getStartEndListChildren): Call anchorNode() instead of depreca tedNode() because the start
5673 or the end of selection could be an immediate child of a list node (e.g. br inside ul)
5674
5675 2011-03-03 Hans Wennborg <hans@chromium.org>
5676
5677 Reviewed by Jeremy Orlow.
5678
5679 IndexedDB: Move last bits of SQL into IDBBackingStore
5680 https://bugs.webkit.org/show_bug.cgi?id=55668
5681
5682 After this, all SQL code for IndexedDB is in IDBBackingStore.cpp.
5683
5684 No new tests: refactoring only.
5685
5686 * storage/IDBBackingStore.cpp:
5687 (WebCore::IDBBackingStore::createTransaction):
5688 * storage/IDBBackingStore.h:
5689 * storage/IDBCursorBackendImpl.h:
5690 * storage/IDBDatabaseBackendImpl.cpp:
5691 (WebCore::IDBDatabaseBackendImpl::backingStore):
5692 * storage/IDBDatabaseBackendImpl.h:
5693 * storage/IDBIndexBackendImpl.h:
5694 * storage/IDBKey.h:
5695 * storage/IDBObjectStoreBackendImpl.h:
5696 * storage/IDBTransactionBackendImpl.cpp:
5697 (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
5698 * storage/IDBTransactionBackendImpl.h:
5699 * storage/IDBTransactionBackendInterface.h:
5700 * storage/IDBTransactionCoordinator.cpp:
5701
5702 2011-03-03 Adam Klein <adamk@chromium.org>
5703
5704 Reviewed by David Levin.
5705
5706 [fileapi] Tighten up ResolveURICallbacks
5707 https://bugs.webkit.org/show_bug.cgi?id=55638
5708
5709 Two changes:
5710 - Retry only on TYPE_MISMATCH_ERR now that Chromium
5711 properly sets that error code.
5712 - Call DirectoryEntry instead of DOMFileSystem methods.
5713
5714 No change in behavior, so no new tests.
5715
5716 * fileapi/FileSystemCallbacks.cpp:
5717 (WebCore::ResolveURICallbacks::didOpenFileSystem):
5718
5719 2011-03-03 Anders Carlsson <andersca@apple.com>
5720
5721 Reviewed by Sam Weinig.
5722
5723 Get rid of Page::globalHistoryItem
5724 https://bugs.webkit.org/show_bug.cgi?id=55738
5725
5726 The m_globalHistoryItem is only used by Mac and Windows WebKit1.
5727 Instead of having WebCore updating this member variable, just call out
5728 to a FrameLoaderClient member function and let WebKit keep it up to date .
5729
5730 * loader/EmptyClients.h:
5731 (WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem):
5732 (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryItemForPage):
5733 * loader/FrameLoader.cpp:
5734 (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
5735 (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
5736 * loader/FrameLoaderClient.h:
5737 (WebCore::FrameLoaderClient::updateGlobalHistoryItemForPage):
5738 * loader/HistoryController.cpp:
5739 (WebCore::HistoryController::goToItem):
5740 (WebCore::HistoryController::updateForStandardLoad):
5741 (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList) :
5742 * page/Page.cpp:
5743 * page/Page.h:
5744
5745 2011-03-02 Jeremy Orlow <jorlow@chromium.org>
5746
5747 Reviewed by Steve Block.
5748
5749 Cursor.continue with a key param should test less than, not equal to
5750 https://bugs.webkit.org/show_bug.cgi?id=55640
5751
5752 If you supply a param to cursor.continue, we sould guarantee that
5753 the item we continue to is greater than or equal to the parameter.
5754 Right now, we only test equality.
5755
5756 http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBCurso r-continue
5757 http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#dfn-steps-for -iterating-a-cursor
5758
5759 Test: storage/indexeddb/cursor-continue.html
5760
5761 * storage/IDBCursorBackendImpl.cpp:
5762 (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
5763 * storage/IDBKey.cpp:
5764 (WebCore::IDBKey::isLessThan):
5765 (WebCore::IDBKey::isEqual):
5766 * storage/IDBKey.h:
5767
5768 2011-03-03 Brent Fulgham <bfulgham@webkit.org>
5769
5770 Build fix. Need win/cURL DownloadBundle stub.
5771
5772 * platform/network/curl/DownloadBundle.h: Added.
5773
5774 2011-03-03 Geoffrey Garen <ggaren@apple.com>
5775
5776 Rolled out 80277 and 80280 because they caused event handler layout test
5777 failures.
5778
5779 * WebCore.xcodeproj/project.pbxproj:
5780 * bindings/js/JSDOMGlobalObject.cpp:
5781 * bindings/js/JSDOMGlobalObject.h:
5782 * bindings/js/JSDOMWindowBase.cpp:
5783 * bindings/js/JSDOMWindowBase.h:
5784 * bindings/js/JSDOMWindowCustom.h:
5785 * bindings/js/JSWorkerContextBase.cpp:
5786
5787 2011-03-03 Brady Eidson <beidson@apple.com>
5788
5789 Reviewed by Darin Adler.
5790
5791 https://bugs.webkit.org/show_bug.cgi?id=55721
5792 Global IconDatabase should be returned by reference, not as a pointer
5793
5794 * history/HistoryItem.cpp:
5795 (WebCore::HistoryItem::HistoryItem):
5796 (WebCore::HistoryItem::~HistoryItem):
5797 (WebCore::HistoryItem::reset):
5798 (WebCore::HistoryItem::icon):
5799 (WebCore::HistoryItem::setURLString):
5800
5801 * loader/FrameLoader.cpp:
5802 (WebCore::FrameLoader::startIconLoader):
5803 (WebCore::FrameLoader::commitIconURLToIconDatabase):
5804
5805 * loader/archive/cf/LegacyWebArchive.cpp:
5806 (WebCore::LegacyWebArchive::create):
5807
5808 * loader/icon/IconDatabase.cpp:
5809 (WebCore::iconDatabase):
5810 * loader/icon/IconDatabase.h:
5811 * loader/icon/IconDatabaseNone.cpp:
5812 (WebCore::iconDatabase):
5813 * loader/icon/wince/IconDatabaseWinCE.cpp:
5814 (WebCore::iconDatabase):
5815
5816 * loader/icon/IconLoader.cpp:
5817 (WebCore::IconLoader::finishLoading):
5818
5819 2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
5820
5821 Reviewed by Martin Robinson.
5822
5823 Stop instantiating legacy editing positions in FocusController::advanceF ocusInDocumentOrder
5824 https://bugs.webkit.org/show_bug.cgi?id=52742
5825
5826 Use firstPositionInOrBeforeNode to instantiate appropriate position.
5827
5828 * page/FocusController.cpp:
5829 (WebCore::FocusController::advanceFocusInDocumentOrder):
5830
5831 2011-03-03 Andy Estes <aestes@apple.com>
5832
5833 Reviewed by Darin Adler.
5834
5835 When displaying the missing plug-in sheet, pass the 'pluginspage'
5836 attribute to the UI process.
5837 https://bugs.webkit.org/show_bug.cgi?id=55553
5838
5839 * WebCore.exp.in: Export __ZN7WebCore9HTMLNames15pluginspageAttrE.
5840 * html/HTMLAttributeNames.in: Add 'pluginspage' as a known content
5841 attribute.
5842
5843 2011-03-03 Jessie Berlin <jberlin@apple.com>
5844
5845 Reviewed by Adam Roben.
5846
5847 WebKit2: Use CFNetwork Sessions API.
5848 https://bugs.webkit.org/show_bug.cgi?id=55435
5849
5850 Set the Private Browsing Storage Session on requests when Private Browsi ng is enabled.
5851
5852 * WebCore.exp.in:
5853 Support using WKCopyRequestWithStorageSession in WebCore.
5854 * platform/mac/WebCoreSystemInterface.h:
5855 Ditto.
5856 * platform/mac/WebCoreSystemInterface.mm:
5857 Ditto.
5858
5859 * platform/network/cf/ResourceHandleCFNet.cpp:
5860 (WebCore::makeFinalRequest):
5861 If Private Browsing is enabled, set the Private Browsing Storage Session on the request.
5862 (WebCore::ResourceHandle::willSendRequest):
5863 Ditto.
5864 * platform/network/mac/ResourceHandleMac.mm:
5865 (WebCore::ResourceHandle::createNSURLConnection):
5866 Ditto.
5867 (WebCore::ResourceHandle::willSendRequest):
5868 Ditto.
5869
5870 * platform/network/cf/ResourceRequest.h:
5871 * platform/network/cf/ResourceRequestCFNet.cpp:
5872 (WebCore::ResourceRequest::setStorageSession):
5873 Call through to WKSI.
5874 * platform/network/mac/ResourceRequestMac.mm:
5875 (WebCore::ResourceRequest::setStorageSession):
5876 Ditto.
5877
5878 2011-03-03 Chris Marrin <cmarrin@apple.com>
5879
5880 Reviewed by Simon Fraser.
5881
5882 REGRESSION: Accelerated transitions are jumpy
5883 https://bugs.webkit.org/show_bug.cgi?id=55022
5884
5885 Changed the way default TimingFunction is stored according to Adam Roben 's
5886 suggestion.
5887
5888 * platform/animation/TimingFunction.h:
5889 (WebCore::CubicBezierTimingFunction::defaultTimingFunction):
5890
5891 2011-03-03 Dan Bernstein <mitz@apple.com>
5892
5893 Reviewed by Sam Weinig.
5894
5895 Rename -webkit-hyphenate-locale to -webkit-locale
5896 https://bugs.webkit.org/show_bug.cgi?id=55709
5897
5898 * css/CSSComputedStyleDeclaration.cpp:
5899 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
5900 * css/CSSParser.cpp:
5901 (WebCore::CSSParser::parseValue):
5902 (WebCore::cssPropertyID):
5903 * css/CSSPropertyNames.in:
5904 * css/CSSStyleSelector.cpp:
5905 (WebCore::CSSStyleSelector::applyProperty):
5906 * rendering/RenderBlockLineLayout.cpp:
5907 (WebCore::RenderBlock::findNextLineBreak):
5908 * rendering/style/RenderStyle.cpp:
5909 (WebCore::RenderStyle::diff):
5910 * rendering/style/RenderStyle.h:
5911 (WebCore::InheritedFlags::locale):
5912 (WebCore::InheritedFlags::setLocale):
5913 (WebCore::InheritedFlags::initialLocale):
5914 * rendering/style/StyleRareInheritedData.cpp:
5915 (WebCore::StyleRareInheritedData::StyleRareInheritedData):
5916 (WebCore::StyleRareInheritedData::operator==):
5917 * rendering/style/StyleRareInheritedData.h:
5918
5919 2011-03-03 Kevin Ollivier <kevino@theolliviers.com>
5920
5921 [wx] Build fixes. Use Font::textMetrics to get ascent value, and add mis sing include.
5922
5923 * platform/wx/DragDataWx.cpp:
5924 * platform/wx/wxcode/win/non-kerned-drawing.cpp:
5925 (WebCore::drawTextWithSpacing):
5926
5927 2011-03-03 Oliver Hunt <oliver@apple.com>
5928
5929 Reviewed by Geoffrey Garen.
5930
5931 JSVariableObject needs to use WriteBarrier for symboltable property stor age
5932 https://bugs.webkit.org/show_bug.cgi?id=55698
5933
5934 Update to pass JSGlobalData for the symbol table write used
5935 to set the document property.
5936
5937 * bindings/js/JSDOMWindowBase.cpp:
5938 (WebCore::JSDOMWindowBase::updateDocument):
5939
5940 2011-03-03 Alexey Proskuryakov <ap@apple.com>
5941
5942 More build fixing. Move WebCoreKeyboardUIMode.h to a cross-platform loca tion.
5943
5944 * WebCore.xcodeproj/project.pbxproj:
5945 * page/WebCoreKeyboardUIMode.h: Copied from WebCore/page/mac/WebCoreKeyb oardUIMode.h.
5946 * page/mac/WebCoreKeyboardUIMode.h: Removed.
5947
5948 2011-03-03 Alexey Proskuryakov <ap@apple.com>
5949
5950 Build fix. Should include WebCoreKeyboardUIMode.h on all platforms now.
5951
5952 * page/ChromeClient.h:
5953
5954 2011-03-02 Alexey Proskuryakov <ap@apple.com>
5955
5956 Reviewed by Darin Adler.
5957
5958 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
5959 https://bugs.webkit.org/show_bug.cgi?id=55633
5960 <rdar://problem/8963023>
5961
5962 * loader/EmptyClients.h: (WebCore::EmptyChromeClient::keyboardUIMode):
5963 * page/ChromeClient.h:
5964 * page/EventHandler.cpp: (WebCore::EventHandler::tabsToLinks):
5965 Merged tabsToLinks() and keyboardUIMode(). The latter returned a superse t of information
5966 returned by former.
5967
5968 2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
5969
5970 Fix Win compile break, caused by r80276.
5971
5972 * rendering/RenderThemeWin.h: Changed signature of volumeSliderOffsetFro mMuteButton
5973 to match RenderTheme.h.
5974
5975 2011-03-02 Geoffrey Garen <ggaren@apple.com>
5976
5977 Reviewed by Darin Adler.
5978
5979 Moved all variable object storage inline -- upping the object size limit to 1K
5980 https://bugs.webkit.org/show_bug.cgi?id=55653
5981
5982 * bindings/js/JSDOMGlobalObject.cpp:
5983 * bindings/js/JSDOMGlobalObject.h:
5984 * bindings/js/JSDOMWindowBase.cpp:
5985 * bindings/js/JSDOMWindowBase.h:
5986 * bindings/js/JSDOMWindowCustom.h:
5987 * bindings/js/JSWorkerContextBase.cpp: Removed out-of-line storage. Chan ged d-> to m_.
5988
5989 2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
5990
5991 Reviewed by Darin Adler.
5992
5993 Use RenderBox in volumeSliderOffsetFromMuteButton, since that's what is actually being used.
5994 https://bugs.webkit.org/show_bug.cgi?id=55099
5995
5996 Cleanup, no behavior change.
5997
5998 * html/shadow/MediaControls.cpp:
5999 (WebCore::MediaControls::updateVolumeSliderContainer): Changed to pass R enderBox
6000 instead of Node.
6001 * rendering/RenderMediaControls.cpp:
6002 (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): Change d
6003 to use RenderBox as argument.
6004 * rendering/RenderMediaControls.h: Ditto.
6005 * rendering/RenderTheme.cpp:
6006 (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton): Ditto.
6007 * rendering/RenderTheme.h: Ditto.
6008 * rendering/RenderThemeChromiumMac.h: Ditto.
6009 * rendering/RenderThemeChromiumMac.mm:
6010 (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton): Dit to.
6011 * rendering/RenderThemeMac.h: Ditto.
6012 * rendering/RenderThemeMac.mm:
6013 (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton): Ditto.
6014 * rendering/RenderThemeWin.cpp:
6015 (WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton): Ditto.
6016
6017 2011-03-03 Alexis Menard <alexis.menard@openbossa.org>
6018
6019 Reviewed by Andreas Kling.
6020
6021 When building with DEFINES+=USE_GSTREAMER=1 we don't want to define ENAB LE_QT_MULTIMEDIA to 1.
6022 Also add the new files added after https://bugs.webkit.org/show_bug.cgi? id=54870 to support GRefPtr
6023 for GstElement.
6024
6025 * WebCore.pro:
6026 * features.pri:
6027
6028 2011-03-03 Anders Carlsson <andersca@apple.com>
6029
6030 Try to fix the Windows build again.
6031
6032 * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
6033 * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
6034
6035 2011-03-03 Mihai Parparita <mihaip@chromium.org>
6036
6037 Reviewed by Dimitri Glazkov.
6038
6039 Add another CRASH() for CSSSelector double frees
6040 https://bugs.webkit.org/show_bug.cgi?id=55693
6041
6042 To help track down bug 53045, add a CRASH call when the the array and/or
6043 CSSSelector member in CSSSelectorList is disposed of more than once.
6044
6045 Just a check, no new tests necessary.
6046
6047 * css/CSSSelectorList.cpp:
6048 (WebCore::CSSSelectorList::deleteSelectors):
6049
6050 2011-03-03 Anders Carlsson <andersca@apple.com>
6051
6052 Yet another attempt at fixing the Windows build.
6053
6054 * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
6055 * platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
6056 * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
6057 * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
6058
6059 2011-03-02 Chris Marrin <cmarrin@apple.com>
6060
6061 Reviewed by Simon Fraser.
6062
6063 REGRESSION: Accelerated transitions are jumpy
6064 https://bugs.webkit.org/show_bug.cgi?id=55022
6065
6066 Got rid of default TimingFunction values from PlatformCAAnimation*. A Ti mingFunction
6067 is now always passed in. The TimingFunction class now has a static metho d to get
6068 a default object which has the 'ease' values in it. I now assert in both Mac and
6069 Win implementations if a null TimingFunction pointer is seen.
6070
6071 * platform/animation/TimingFunction.h:
6072 (WebCore::CubicBezierTimingFunction::create):
6073 (WebCore::CubicBezierTimingFunction::defaultTimingFunction):
6074 (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction):
6075 * platform/graphics/ca/GraphicsLayerCA.cpp:
6076 (WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
6077 * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
6078 (toCAMediaTimingFunction):
6079 * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
6080 (toCACFTimingFunction):
6081
6082 2011-03-03 Tony Gentilcore <tonyg@chromium.org>
6083
6084 Unreviewed build fix.
6085
6086 Fix clang compile after r80220
6087 https://bugs.webkit.org/show_bug.cgi?id=55692
6088
6089 * storage/IDBBackingStore.cpp:
6090 (WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
6091
6092 2011-03-03 Anders Carlsson <andersca@apple.com>
6093
6094 Attempt to fix the Windows build.
6095
6096 * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
6097 * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
6098
6099 2011-03-02 Brian Weinstein <bweinstein@apple.com>
6100
6101 Reviewed by Adam Roben.
6102
6103 Rest of WebKit2: Need a way to send notifications to client when cookies change
6104 https://bugs.webkit.org/show_bug.cgi?id=55427
6105 <rdar://problem/9056027>
6106
6107 Add functions to be exported.
6108
6109 * WebCore.exp.in:
6110
6111 2011-03-03 Anders Carlsson <andersca@apple.com>
6112
6113 Reviewed by Darin Adler.
6114
6115 Improve WebCore build time by ~5%
6116 https://bugs.webkit.org/show_bug.cgi?id=55688
6117
6118 Forward declare the CATransform3D and CGAffineTransform structs instead of including
6119 large chunks of QuartzCore and Core Graphics.
6120
6121 On an 8 core Mac Pro, this sped up building WebCore by about 5%.
6122
6123 * platform/graphics/ca/GraphicsLayerCA.cpp:
6124 * platform/graphics/ca/TransformationMatrixCA.cpp:
6125 * platform/graphics/transforms/TransformationMatrix.h:
6126
6127 2011-03-03 Andrey Kosyakov <caseq@chromium.org>
6128
6129 Unreviewed. Adjusted call to a method renamed in r80102.
6130
6131 * inspector/front-end/SourceFrame.js:
6132 (WebInspector.SourceFrame.prototype._startEditing):
6133
6134 2011-03-03 Timothy Hatcher <timothy@apple.com>
6135
6136 Use APIEntryShim instead of JSLock in SerializedScriptValue to allow it to be used
6137 by contexts not created by WebCore.
6138
6139 https://webkit.org/b/55642
6140
6141 Reviewed by Oliver Hunt.
6142
6143 * bindings/js/SerializedScriptValue.cpp:
6144 (WebCore::SerializedScriptValue::create): Use APIEntryShim instead of JS Lock.
6145 (WebCore::SerializedScriptValue::deserialize): Ditto.
6146
6147 2011-03-03 Alexey Proskuryakov <ap@apple.com>
6148
6149 Reviewed by Darin Adler.
6150
6151 WebCore should check for "Upgrade" and "Connection" header fields in Web Sockets handshake
6152 https://bugs.webkit.org/show_bug.cgi?id=55498
6153 <rdar://problem/8752706>
6154
6155 Tests: http/tests/websocket/tests/handshake-fail-by-no-connection-header .html
6156 http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.ht ml
6157
6158 * websockets/WebSocketHandshake.h: Removed unused and meaningless setter s for response
6159 header fields. Removed separate member variables for those, as they were duplicating data
6160 available in response, and there is no reason to squeeze microsecods her e.
6161
6162 * websockets/WebSocketHandshake.cpp:
6163 (WebCore::WebSocketHandshake::reset): There are no longer member variabl es for header field
6164 values to reset here.
6165 (WebCore::WebSocketHandshake::readServerHandshake): Removed a call for p rocessHeaders().
6166 (WebCore::WebSocketHandshake::serverWebSocketOrigin): Changed to get the value from response.
6167 (WebCore::WebSocketHandshake::serverWebSocketLocation): Ditto.
6168 (WebCore::WebSocketHandshake::serverWebSocketProtocol): Ditto.
6169 (WebCore::WebSocketHandshake::serverSetCookie): Ditto.
6170 (WebCore::WebSocketHandshake::serverSetCookie2): Ditto.
6171 (WebCore::WebSocketHandshake::serverUpgrade): Added.
6172 (WebCore::WebSocketHandshake::serverConnection): Added.
6173 (WebCore::WebSocketHandshake::checkResponseHeaders): Added checks for Up grade and Connection
6174 header field presence and values.
6175
6176 2011-03-03 Helder Correia <helder@sencha.com>
6177
6178 Reviewed by Andreas Kling.
6179
6180 [Qt] fast/canvas/canvas-strokePath-gradient-shadow.html fails
6181 https://bugs.webkit.org/show_bug.cgi?id=55651
6182
6183 When relying on ContextShadow and using a gradient stroke for a path,
6184 the alpha of the shadow is incorrect.
6185
6186 * platform/graphics/qt/GraphicsContextQt.cpp:
6187 (WebCore::GraphicsContext::strokePath):
6188
6189 2011-03-03 Martin Robinson <mrobinson@igalia.com>
6190
6191 XHTMLMP build broken after r78342
6192 https://bugs.webkit.org/show_bug.cgi?id=55286
6193
6194 Fix XHTMLMP build now that the DocumentWriter is a member of DocumentLoa der
6195 instead of FrameLoader.
6196
6197 No new tests. This is a build fix.
6198
6199 * dom/Document.cpp:
6200 (WebCore::Document::isXHTMLMPDocument):
6201
6202 2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
6203
6204 Reviewed by Eric Carlson.
6205
6206 Tweak MediaControlMuteButtonElement class hierarchy.
6207 https://bugs.webkit.org/show_bug.cgi?id=55614
6208
6209 This allows the mute button on the panel to have event handlers that are
6210 different from the mute button in the volume slider.
6211
6212 No change in behavior, covered by existing tests.
6213
6214 * html/shadow/MediaControls.cpp:
6215 (WebCore::MediaControls::createMuteButton): Changed to use MediaControlP anelMuteButtonElement.
6216 * rendering/MediaControlElements.cpp:
6217 (WebCore::MediaControlMuteButtonElement::updateDisplayType):
6218 (WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButto nElement): Added.
6219 (WebCore::MediaControlPanelMuteButtonElement::create): Added.
6220 (WebCore::MediaControlPanelMuteButtonElement::shadowPseudoId): Moved.
6221 * rendering/MediaControlElements.h: Added defs.
6222
6223 2011-03-03 Yury Semikhatsky <yurys@chromium.org>
6224
6225 Reviewed by Pavel Feldman.
6226
6227 Web Inspector: Resource agent should have same lifetime as Inspector age nt
6228 https://bugs.webkit.org/show_bug.cgi?id=55461
6229
6230 * inspector/Inspector.idl:
6231 * inspector/InspectorAgent.cpp:
6232 (WebCore::InspectorAgent::InspectorAgent):
6233 (WebCore::InspectorAgent::inspectedPageDestroyed): disconnectFrontend is called before the agent is destroyed
6234 to clear frontend reference in all agents.
6235 (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
6236 (WebCore::InspectorAgent::setFrontend):
6237 (WebCore::InspectorAgent::disconnectFrontend):
6238 (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
6239 (WebCore::InspectorAgent::didCommitLoad):
6240 * inspector/InspectorAgent.h:
6241 (WebCore::InspectorAgent::resourceAgent):
6242 * inspector/InspectorBrowserDebuggerAgent.cpp:
6243 (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent) :
6244 * inspector/InspectorDebuggerAgent.cpp:
6245 (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
6246 * inspector/InspectorInstrumentation.cpp:
6247 (WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
6248 (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImp l):
6249 (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse Impl):
6250 (WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
6251 (WebCore::InspectorInstrumentation::retrieveResourceAgent):
6252 * inspector/InspectorResourceAgent.cpp:
6253 (WebCore::InspectorResourceAgent::setFrontend):
6254 (WebCore::InspectorResourceAgent::clearFrontend):
6255 (WebCore::InspectorResourceAgent::restore):
6256 (WebCore::InspectorResourceAgent::~InspectorResourceAgent):
6257 (WebCore::InspectorResourceAgent::enable):
6258 (WebCore::InspectorResourceAgent::disable):
6259 (WebCore::InspectorResourceAgent::InspectorResourceAgent):
6260 * inspector/InspectorResourceAgent.h:
6261 (WebCore::InspectorResourceAgent::create):
6262 * inspector/InspectorTimelineAgent.cpp:
6263 (WebCore::InspectorTimelineAgent::restore):
6264 * inspector/InspectorTimelineAgent.h:
6265 * inspector/front-end/NetworkManager.js:
6266 (WebInspector.NetworkManager):
6267 (WebInspector.NetworkManager.prototype.frontendReused):
6268 * inspector/front-end/inspector.js:
6269 (WebInspector.frontendReused):
6270
6271 2011-03-03 Andras Becsi <abecsi@webkit.org>
6272
6273 Reviewed by Andreas Kling.
6274
6275 CSS RGBA fast-path color parsing should clamp of out-of-range alpha valu es
6276 https://bugs.webkit.org/show_bug.cgi?id=55661
6277
6278 Test case originally written by Andreas Kling <andreas.kling@nokia.com>
6279
6280 Test: fast/canvas/rgba-parsing.html
6281
6282 * css/CSSParser.cpp:
6283 (WebCore::isValidDouble): Check whether the given string is a valid doub le.
6284 (WebCore::parseAlphaValue): Out-of-range alpha values should be clamped to the (0.0, 1.0) range.
6285
6286 2011-03-03 David Holloway <dhollowa@chromium.org>
6287
6288 Reviewed by Dimitri Glazkov.
6289
6290 Changes HTMLTextFormControlElement::placeholderShouldBeVisible to accoun t
6291 for non-empty suggestion text. The visibility of the placeholder text
6292 now turned off when suggestion text is set.
6293 https://bugs.webkit.org/show_bug.cgi?id=55245
6294
6295 No new tests because, by design, the suggestion text is not accessible
6296 through the DOM.
6297
6298 * html/HTMLFormControlElement.cpp:
6299 (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
6300 * html/HTMLFormControlElement.h:
6301 (WebCore::HTMLTextFormControlElement::isEmptySuggestedValue):
6302 * html/HTMLInputElement.h:
6303 (WebCore::HTMLInputElement::isEmptySuggestedValue):
6304
6305 2011-03-03 Andy Estes <aestes@apple.com>
6306
6307 Reviewed by Eric Seidel.
6308
6309 HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
6310 https://bugs.webkit.org/show_bug.cgi?id=48719
6311
6312 Instead of pushing a fake HTMLHtmlElement onto the open element stack
6313 during fragment parsing only to later remove it and reparent its
6314 children to the DocumentFragment, push the DocumentFragment directly
6315 onto the open element stack as the root node. This requires refactoring
6316 HTMLElementStack to hold ContainerNode pointers rather than Element
6317 pointers, which has implications for HTMLConstructionSite and
6318 HTMLTreeBuilder as well.
6319
6320 With this patch, the regression in Peacekeeper from Safari 5.0.3 to ToT
6321 is ~14%. However, if you discount the 'domDynamicCreationCreateElement'
6322 test, ToT is now ~4% faster than Safari 5.0.3. This indicates that the
6323 regression no longer lies in fragment parsing.
6324
6325 No new tests. No change in behavior.
6326
6327 * dom/Element.h:
6328 (WebCore::Node::hasLocalName):
6329 * dom/Node.h:
6330 * html/parser/HTMLConstructionSite.cpp:
6331 (WebCore::HTMLNames::hasImpliedEndTag):
6332 (WebCore::HTMLConstructionSite::HTMLConstructionSite):
6333 (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
6334 (WebCore::HTMLConstructionSite::insertComment):
6335 (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
6336 (WebCore::HTMLConstructionSite::attachToCurrent):
6337 (WebCore::HTMLConstructionSite::insertScriptElement):
6338 (WebCore::HTMLConstructionSite::insertTextNode):
6339 (WebCore::HTMLConstructionSite::createElement):
6340 (WebCore::HTMLConstructionSite::createHTMLElement):
6341 (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
6342 (WebCore::HTMLConstructionSite::generateImpliedEndTags):
6343 (WebCore::HTMLConstructionSite::findFosterSite):
6344 (WebCore::HTMLConstructionSite::shouldFosterParent):
6345 * html/parser/HTMLConstructionSite.h:
6346 (WebCore::HTMLConstructionSite::currentNode):
6347 * html/parser/HTMLElementStack.cpp:
6348 (WebCore::HTMLNames::isNumberedHeaderElement):
6349 (WebCore::HTMLNames::isScopeMarker):
6350 (WebCore::HTMLNames::isListItemScopeMarker):
6351 (WebCore::HTMLNames::isTableScopeMarker):
6352 (WebCore::HTMLNames::isTableBodyScopeMarker):
6353 (WebCore::HTMLNames::isTableRowScopeMarker):
6354 (WebCore::HTMLNames::isButtonScopeMarker):
6355 (WebCore::HTMLNames::isSelectScopeMarker):
6356 (WebCore::HTMLElementStack::ElementRecord::ElementRecord):
6357 (WebCore::HTMLElementStack::ElementRecord::replaceElement):
6358 (WebCore::HTMLElementStack::HTMLElementStack):
6359 (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
6360 (WebCore::HTMLElementStack::popAll):
6361 (WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
6362 (WebCore::HTMLElementStack::popUntil):
6363 (WebCore::HTMLElementStack::popUntilPopped):
6364 (WebCore::HTMLElementStack::popUntilTableScopeMarker):
6365 (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
6366 (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
6367 (WebCore::HTMLElementStack::pushHTMLHtmlElement):
6368 (WebCore::HTMLElementStack::push):
6369 (WebCore::HTMLElementStack::insertAbove):
6370 (WebCore::HTMLElementStack::find):
6371 (WebCore::HTMLElementStack::topmost):
6372 (WebCore::HTMLElementStack::contains):
6373 (WebCore::inScopeCommon):
6374 (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
6375 (WebCore::HTMLElementStack::htmlElement):
6376 (WebCore::HTMLElementStack::rootNode):
6377 (WebCore::HTMLElementStack::pushCommon):
6378 * html/parser/HTMLElementStack.h:
6379 (WebCore::HTMLElementStack::ElementRecord::element):
6380 (WebCore::HTMLElementStack::ElementRecord::node):
6381 (WebCore::HTMLElementStack::topNode):
6382 * html/parser/HTMLTreeBuilder.cpp:
6383 (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
6384 (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
6385 (WebCore::HTMLTreeBuilder::processStartTagForInBody):
6386 (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
6387 (WebCore::HTMLTreeBuilder::processStartTag):
6388 (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
6389 (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
6390 (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
6391 (WebCore::HTMLTreeBuilder::processEndTagForInCell):
6392 (WebCore::HTMLTreeBuilder::processEndTagForInBody):
6393 (WebCore::HTMLTreeBuilder::processEndTag):
6394 (WebCore::HTMLTreeBuilder::processEndOfFile):
6395 (WebCore::HTMLTreeBuilder::finished):
6396 * html/parser/HTMLTreeBuilder.h:
6397
6398 2011-03-02 Yury Semikhatsky <yurys@chromium.org>
6399
6400 Reviewed by Pavel Feldman.
6401
6402 Web Inspector: inspector protocol should allow different domains to have methods with same name
6403 https://bugs.webkit.org/show_bug.cgi?id=55558
6404
6405 * inspector/CodeGeneratorInspector.pm: each command is now identified by domain + command-name(was command-name only).
6406
6407 2011-03-02 Pavel Podivilov <podivilov@chromium.org>
6408
6409 Reviewed by Yury Semikhatsky.
6410
6411 Web Inspector: make selected call frame debugger presentation model prop erty.
6412 https://bugs.webkit.org/show_bug.cgi?id=55582
6413
6414 * inspector/front-end/CallStackSidebarPane.js:
6415 (WebInspector.CallStackSidebarPane):
6416 (WebInspector.CallStackSidebarPane.prototype.update):
6417 (WebInspector.CallStackSidebarPane.prototype.set selectedCallFrame):
6418 (WebInspector.CallStackSidebarPane.prototype._selectedCallFrameIndex):
6419 * inspector/front-end/ConsoleView.js:
6420 (WebInspector.ConsoleView.prototype.completions):
6421 * inspector/front-end/DebuggerPresentationModel.js:
6422 (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame) :
6423 (WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame) :
6424 * inspector/front-end/ScriptsPanel.js:
6425 (WebInspector.ScriptsPanel):
6426 (WebInspector.ScriptsPanel.prototype.getCompletionsOnCallFrame):
6427 (WebInspector.ScriptsPanel.prototype._debuggerResumed):
6428 (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
6429 (WebInspector.ScriptsPanel.prototype._callFrameSelected):
6430
6431 2011-03-03 Jia Pu <jpu@apple.com>
6432
6433 Reviewed by Darin Adler.
6434
6435 On Mac OS X, spelling suggestion panel stops showing up after change set 80121
6436 https://bugs.webkit.org/show_bug.cgi?id=55628
6437
6438 Removed a call to stopCorrectionPanelTimer() to fix a regression introdu ced by changeset 80121.
6439
6440 * editing/Editor.cpp:
6441 (WebCore::Editor::appliedEditing):
6442 * manual-tests/autocorrection/autocorrection-contraction.html:
6443
6444 2011-03-03 Pavel Podivilov <podivilov@chromium.org>
6445
6446 Reviewed by Pavel Feldman.
6447
6448 Web Inspector: rename "sourceName" to "sourceFileId" in ScriptsPanel.js.
6449 https://bugs.webkit.org/show_bug.cgi?id=55569
6450
6451 sourceFileId better reflects the intention to have unique identifier for each source that is shown in scripts panel.
6452
6453 * inspector/front-end/DebuggerPresentationModel.js:
6454 * inspector/front-end/ScriptsPanel.js:
6455
6456 2011-03-03 Steve Block <steveblock@google.com>
6457
6458 Reviewed by David Levin.
6459
6460 JavaString API should be implementable by both JSC and V8
6461 https://bugs.webkit.org/show_bug.cgi?id=55567
6462
6463 Remove JavaString's UString operator and replace it with a
6464 script-engine-independent impl() method, which returns a
6465 StringImpl and can be implemented with both JSC and V8.
6466
6467 No new tests, refactoring only.
6468
6469 * bridge/jni/JNIBridge.h:
6470 (JSC::Bindings::JavaString::impl):
6471 * bridge/jni/jni_jsobject.mm:
6472 (JavaJSObject::call):
6473 (JavaJSObject::eval):
6474 (JavaJSObject::getMember):
6475 (JavaJSObject::setMember):
6476 (JavaJSObject::removeMember):
6477 * bridge/jni/jsc/JNIBridgeJSC.cpp:
6478 (JavaField::valueFromInstance):
6479 (JavaField::setValueToInstance):
6480 * bridge/jni/jsc/JavaClassJSC.cpp:
6481 (JavaClass::JavaClass):
6482 * bridge/jni/jsc/JavaInstanceJSC.cpp:
6483 (JavaInstance::invokeMethod):
6484 * bridge/jni/jsc/JavaStringJSC.h:
6485 (JSC::Bindings::JavaStringImpl::impl):
6486 * bridge/jni/v8/JavaStringV8.h:
6487 (JSC::Bindings::JavaStringImpl::impl):
6488
6489 2011-03-03 Benjamin Poulain <ikipou@gmail.com>
6490
6491 Reviewed by Adam Roben.
6492
6493 REGRESSION (r79817): Lots of leaks of FloatingObjects seen on SnowLeopar d Intel Leaks bot
6494 https://bugs.webkit.org/show_bug.cgi?id=55602
6495
6496 Delete the FloatingObject referenced by m_floatingObjects when clearing the floats.
6497
6498 The DeprecatedPtrList was deleting the objects automatically due to its autoDelete behavior. The
6499 objects need to be deleted manually with ListHashSet.
6500
6501 * rendering/RenderBlock.cpp:
6502 (WebCore::RenderBlock::clearFloats):
6503
6504 2011-03-03 Hans Wennborg <hans@chromium.org>
6505
6506 Reviewed by Jeremy Orlow.
6507
6508 IndexedDB: Move SQL code, especially for cursors, to IDBBackingStore
6509 https://bugs.webkit.org/show_bug.cgi?id=55376
6510
6511 Move SQL code from IDBKey, IDBKeyRange, IDBIndexBackendImpl,
6512 IDBObjectStoreBackendImpl, and especially IDBCursorBackendImpl.
6513
6514 No new functionality, so no new tests.
6515
6516 * storage/IDBBackingStore.cpp:
6517 (WebCore::lowerCursorWhereFragment):
6518 (WebCore::upperCursorWhereFragment):
6519 (WebCore::IDBBackingStore::deleteObjectStoreRecord):
6520 (WebCore::IDBBackingStore::keyExistsInObjectStore):
6521 (WebCore::IDBBackingStore::getObjectViaIndex):
6522 (WebCore::keyFromQuery):
6523 (WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
6524 (WebCore::IDBBackingStore::keyExistsInIndex):
6525 (WebCore::CursorImplCommon::CursorImplCommon::continueInternal):
6526 (WebCore::CursorImplCommon::ObjectStoreCursorImpl::ObjectStoreCursorImpl ):
6527 (WebCore::CursorImplCommon::ObjectStoreCursorImpl::objectStoreDataId):
6528 (WebCore::CursorImplCommon::ObjectStoreCursorImpl::key):
6529 (WebCore::CursorImplCommon::ObjectStoreCursorImpl::value):
6530 (WebCore::CursorImplCommon::ObjectStoreCursorImpl::continueFunction):
6531 (WebCore::IDBBackingStore::openObjectStoreCursor):
6532 (WebCore::ObjectStoreCursorImpl::loadCurrentRow):
6533 (WebCore::ObjectStoreCursorImpl::currentRowExists):
6534 (WebCore::IndexKeyCursorImpl::IndexKeyCursorImpl):
6535 (WebCore::IndexKeyCursorImpl::indexDataId):
6536 (WebCore::IndexKeyCursorImpl::key):
6537 (WebCore::IndexKeyCursorImpl::primaryKey):
6538 (WebCore::IndexKeyCursorImpl::continueFunction):
6539 (WebCore::IDBBackingStore::openIndexKeyCursor):
6540 (WebCore::IndexKeyCursorImpl::loadCurrentRow):
6541 (WebCore::IndexKeyCursorImpl::currentRowExists):
6542 (WebCore::IndexCursorImpl::IndexCursorImpl):
6543 (WebCore::IndexCursorImpl::indexDataId):
6544 (WebCore::IndexCursorImpl::key):
6545 (WebCore::IndexCursorImpl::primaryKey):
6546 (WebCore::IndexCursorImpl::value):
6547 (WebCore::IndexCursorImpl::continueFunction):
6548 (WebCore::IDBBackingStore::openIndexCursor):
6549 (WebCore::IndexCursorImpl::loadCurrentRow):
6550 (WebCore::IndexCursorImpl::currentRowExists):
6551 * storage/IDBBackingStore.h:
6552 (WebCore::IDBBackingStore::Cursor::~Cursor):
6553 * storage/IDBCursorBackendImpl.cpp:
6554 (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
6555 (WebCore::IDBCursorBackendImpl::key):
6556 (WebCore::IDBCursorBackendImpl::value):
6557 (WebCore::IDBCursorBackendImpl::update):
6558 (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
6559 (WebCore::IDBCursorBackendImpl::deleteFunction):
6560 * storage/IDBCursorBackendImpl.h:
6561 (WebCore::IDBCursorBackendImpl::create):
6562 * storage/IDBIndexBackendImpl.cpp:
6563 (WebCore::IDBIndexBackendImpl::openCursorInternal):
6564 (WebCore::IDBIndexBackendImpl::getInternal):
6565 (WebCore::IDBIndexBackendImpl::addingKeyAllowed):
6566 * storage/IDBIndexBackendImpl.h:
6567 * storage/IDBKey.cpp:
6568 (WebCore::IDBKey::isEqual):
6569 * storage/IDBKey.h:
6570 * storage/IDBKeyRange.cpp:
6571 * storage/IDBKeyRange.h:
6572 * storage/IDBObjectStoreBackendImpl.cpp:
6573 (WebCore::IDBObjectStoreBackendImpl::putInternal):
6574 (WebCore::IDBObjectStoreBackendImpl::deleteInternal):
6575 (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
6576 * storage/IDBObjectStoreBackendImpl.h:
6577
6578 2011-03-03 Peter Kasting <pkasting@google.com>
6579
6580 Reviewed by James Robinson.
6581
6582 Drop redundant "Windows; " from the Windows-specific User Agent string.
6583 https://bugs.webkit.org/show_bug.cgi?id=54567
6584
6585 * StringsNotToBeLocalized.txt:
6586
6587 2011-03-03 Mario Sanchez Prada <msanchez@igalia.com>
6588
6589 Reviewed by Martin Robinson.
6590
6591 [GTK] Combo boxes should emit object:selection-changed even when collaps ed
6592 https://bugs.webkit.org/show_bug.cgi?id=53146
6593
6594 Emit the selection-changed signals when the menu list value has changed
6595
6596 Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.h tml
6597
6598 * accessibility/gtk/AXObjectCacheAtk.cpp:
6599 (WebCore::getListObject): New, return the right list object for
6600 menu lists and list boxes.
6601 (WebCore::notifyChildrenSelectionChange): Support menu lists.
6602 (WebCore::AXObjectCache::postPlatformNotification): Call function
6603 notifyChildrenSelectionChange for AXMenuListValueChanged.
6604
6605 2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
6606
6607 Reviewed by Tony Chang.
6608
6609 applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle
6610 https://bugs.webkit.org/show_bug.cgi?id=55338
6611
6612 Include wtf/Forward.h instead of wtf/text/String.h
6613
6614 * editing/EditingStyle.h:
6615
6616 2011-03-03 Csaba Osztrogonác <ossy@webkit.org>
6617
6618 Unreviewed trivial fix after r80169.
6619
6620 [Qt][WK2] Memory exhausted when building qtwebkit2 on linux
6621 https://bugs.webkit.org/show_bug.cgi?id=55484
6622
6623 * WebCore.pro: Typo fix. We have to use linux-g++* instead of linux-g++.
6624
6625
6626 2011-03-02 MORITA Hajime <morrita@google.com>
6627
6628 Reviewed by Kent Tamura.
6629
6630 [Refactoring] Make ScheduledEvent on FrameView abstract out to ScheduleA ction
6631 https://bugs.webkit.org/show_bug.cgi?id=54440
6632
6633 - Extracted FrameActionScheduler from FrameView
6634 - Extracted FrameAction abstract class from ScheduledEvent,
6635 which has fire() virtual method.
6636 - Renamed ScheduledEvent EventFrameAction
6637
6638 With this change, Any action can be hooked up to the end of the layout.
6639
6640 No new tests. No behavioral change.
6641
6642 * Android.mk:
6643 * CMakeLists.txt:
6644 * GNUmakefile.am:
6645 * WebCore.gypi:
6646 * WebCore.pro:
6647 * WebCore.vcproj/WebCore.vcproj:
6648 * WebCore.xcodeproj/project.pbxproj:
6649 * page/FrameActionScheduler.cpp: Added.
6650 (WebCore::EventFrameAction::EventFrameAction):
6651 (WebCore::EventFrameAction::fire):
6652 (WebCore::FrameActionScheduler::FrameActionScheduler):
6653 (WebCore::FrameActionScheduler::~FrameActionScheduler):
6654 (WebCore::FrameActionScheduler::isEmpty):
6655 (WebCore::FrameActionScheduler::clear):
6656 (WebCore::FrameActionScheduler::pause):
6657 (WebCore::FrameActionScheduler::resume):
6658 (WebCore::FrameActionScheduler::dispatch):
6659 (WebCore::FrameActionScheduler::scheduleAction):
6660 (WebCore::FrameActionScheduler::scheduleEvent):
6661 * page/FrameActionScheduler.h: Added.
6662 (WebCore::FrameAction::FrameAction):
6663 (WebCore::FrameAction::~FrameAction):
6664 (WebCore::FrameActionScheduler::isScheduled):
6665 * page/FrameView.cpp:
6666 (WebCore::FrameView::FrameView):
6667 (WebCore::FrameView::~FrameView):
6668 (WebCore::FrameView::layout):
6669 (WebCore::FrameView::scheduleEvent):
6670 (WebCore::FrameView::pauseScheduledEvents):
6671 (WebCore::FrameView::resumeScheduledEvents):
6672 (WebCore::FrameView::performPostLayoutTasks):
6673 (WebCore::FrameView::updateOverflowStatus):
6674 * page/FrameView.h:
6675
6676 2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
6677
6678 Unreviewed, rolling out r80201.
6679 http://trac.webkit.org/changeset/80201
6680 https://bugs.webkit.org/show_bug.cgi?id=55648
6681
6682 "caused tests to crash on several bots" (Requested by rniwa on
6683 #webkit).
6684
6685 * dom/Element.h:
6686 (WebCore::Node::hasTagName):
6687 * dom/Node.h:
6688 * html/parser/HTMLConstructionSite.cpp:
6689 (WebCore::HTMLNames::hasImpliedEndTag):
6690 (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
6691 (WebCore::HTMLConstructionSite::insertComment):
6692 (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
6693 (WebCore::HTMLConstructionSite::attachToCurrent):
6694 (WebCore::HTMLConstructionSite::insertScriptElement):
6695 (WebCore::HTMLConstructionSite::insertTextNode):
6696 (WebCore::HTMLConstructionSite::createElement):
6697 (WebCore::HTMLConstructionSite::createHTMLElement):
6698 (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
6699 (WebCore::HTMLConstructionSite::generateImpliedEndTags):
6700 (WebCore::HTMLConstructionSite::findFosterSite):
6701 (WebCore::HTMLConstructionSite::shouldFosterParent):
6702 * html/parser/HTMLConstructionSite.h:
6703 * html/parser/HTMLElementStack.cpp:
6704 (WebCore::HTMLNames::isNumberedHeaderElement):
6705 (WebCore::HTMLNames::isScopeMarker):
6706 (WebCore::HTMLNames::isListItemScopeMarker):
6707 (WebCore::HTMLNames::isTableScopeMarker):
6708 (WebCore::HTMLNames::isTableBodyScopeMarker):
6709 (WebCore::HTMLNames::isTableRowScopeMarker):
6710 (WebCore::HTMLNames::isButtonScopeMarker):
6711 (WebCore::HTMLNames::isSelectScopeMarker):
6712 (WebCore::HTMLElementStack::ElementRecord::ElementRecord):
6713 (WebCore::HTMLElementStack::ElementRecord::replaceElement):
6714 (WebCore::HTMLElementStack::HTMLElementStack):
6715 (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
6716 (WebCore::HTMLElementStack::popAll):
6717 (WebCore::HTMLElementStack::popUntilTableScopeMarker):
6718 (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
6719 (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
6720 (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker):
6721 (WebCore::HTMLElementStack::pushHTMLHtmlElement):
6722 (WebCore::HTMLElementStack::push):
6723 (WebCore::HTMLElementStack::insertAbove):
6724 (WebCore::HTMLElementStack::find):
6725 (WebCore::HTMLElementStack::topmost):
6726 (WebCore::inScopeCommon):
6727 (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
6728 (WebCore::HTMLElementStack::htmlElement):
6729 (WebCore::HTMLElementStack::bodyElement):
6730 (WebCore::HTMLElementStack::pushCommon):
6731 * html/parser/HTMLElementStack.h:
6732 (WebCore::HTMLElementStack::ElementRecord::element):
6733 (WebCore::HTMLElementStack::top):
6734 * html/parser/HTMLTreeBuilder.cpp:
6735 (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
6736 (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
6737 (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
6738 (WebCore::HTMLTreeBuilder::processStartTagForInBody):
6739 (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
6740 (WebCore::HTMLTreeBuilder::processStartTag):
6741 (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
6742 (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
6743 (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
6744 (WebCore::HTMLTreeBuilder::processEndTagForInCell):
6745 (WebCore::HTMLTreeBuilder::processEndTagForInBody):
6746 (WebCore::HTMLTreeBuilder::processEndTag):
6747 (WebCore::HTMLTreeBuilder::processEndOfFile):
6748 (WebCore::HTMLTreeBuilder::finished):
6749 * html/parser/HTMLTreeBuilder.h:
6750
6751 2011-03-02 Yury Semikhatsky <yurys@chromium.org>
6752
6753 Reviewed by Pavel Feldman.
6754
6755 Web Inspector: break down InspectorFrontend into domain-specific classes
6756 https://bugs.webkit.org/show_bug.cgi?id=55584
6757
6758 * inspector/CodeGeneratorInspector.pm: InspectorFrontend now contains ne sted classes for
6759 all domains that have event notifications.
6760 * inspector/ConsoleMessage.cpp:
6761 (WebCore::ConsoleMessage::addToFrontend):
6762 (WebCore::ConsoleMessage::updateRepeatCountInConsole):
6763 * inspector/ConsoleMessage.h:
6764 * inspector/InjectedScriptHost.cpp:
6765 (WebCore::InjectedScriptHost::inspectImpl):
6766 * inspector/Inspector.idl:
6767 * inspector/InspectorAgent.cpp:
6768 (WebCore::InspectorAgent::inspectedPageDestroyed):
6769 (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
6770 (WebCore::InspectorAgent::setFrontend):
6771 (WebCore::InspectorAgent::disconnectFrontend):
6772 (WebCore::InspectorAgent::populateScriptObjects):
6773 (WebCore::InspectorAgent::pushDataCollectedOffline):
6774 (WebCore::InspectorAgent::didCommitLoad):
6775 (WebCore::InspectorAgent::domContentLoadedEventFired):
6776 (WebCore::InspectorAgent::loadEventFired):
6777 (WebCore::InspectorAgent::postWorkerNotificationToFrontend):
6778 (WebCore::InspectorAgent::evaluateForTestInFrontend):
6779 (WebCore::InspectorAgent::showPanel):
6780 * inspector/InspectorApplicationCacheAgent.cpp:
6781 (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent ):
6782 * inspector/InspectorApplicationCacheAgent.h:
6783 * inspector/InspectorConsoleAgent.cpp:
6784 (WebCore::InspectorConsoleAgent::setFrontend):
6785 * inspector/InspectorConsoleAgent.h:
6786 * inspector/InspectorController.cpp:
6787 (WebCore::InspectorController::show):
6788 (WebCore::InspectorController::close):
6789 * inspector/InspectorDOMAgent.cpp:
6790 (WebCore::InspectorDOMAgent::setFrontend):
6791 * inspector/InspectorDOMAgent.h:
6792 * inspector/InspectorDOMStorageResource.cpp:
6793 (WebCore::InspectorDOMStorageResource::bind):
6794 * inspector/InspectorDOMStorageResource.h:
6795 * inspector/InspectorDatabaseAgent.cpp:
6796 (WebCore::InspectorDatabaseAgent::FrontendProvider::frontend):
6797 (WebCore::InspectorDatabaseAgent::FrontendProvider::FrontendProvider):
6798 (WebCore::InspectorDatabaseAgent::setFrontend):
6799 * inspector/InspectorDatabaseResource.cpp:
6800 (WebCore::InspectorDatabaseResource::bind):
6801 * inspector/InspectorDatabaseResource.h:
6802 * inspector/InspectorDebuggerAgent.cpp:
6803 (WebCore::InspectorDebuggerAgent::setFrontend):
6804 * inspector/InspectorDebuggerAgent.h:
6805 * inspector/InspectorProfilerAgent.cpp:
6806 * inspector/InspectorProfilerAgent.h:
6807 (WebCore::InspectorProfilerAgent::setFrontend):
6808 (WebCore::InspectorProfilerAgent::clearFrontend):
6809 * inspector/InspectorResourceAgent.cpp:
6810 (WebCore::InspectorResourceAgent::InspectorResourceAgent):
6811 * inspector/InspectorResourceAgent.h:
6812 * inspector/InspectorTimelineAgent.cpp:
6813 (WebCore::InspectorTimelineAgent::setFrontend):
6814 * inspector/InspectorTimelineAgent.h:
6815 * inspector/front-end/DOMAgent.js:
6816 (WebInspector.DOMDispatcher.prototype.inspectElementRequested):
6817 (WebInspector.DOMDispatcher.prototype.addNodesToSearchResult):
6818 * inspector/front-end/inspector.js:
6819
6820 2011-03-02 Kent Tamura <tkent@chromium.org>
6821
6822 Unreviewed, a trivial regression fix.
6823
6824 Fix LocalizedNumberICU regression by r80198 and r80199.
6825 https://bugs.webkit.org/show_bug.cgi?id=55629
6826
6827 * platform/text/LocalizedNumberICU.cpp:
6828 We should use U_SUCCESS().
6829 (WebCore::createFormatterForCurrentLocale):
6830 (WebCore::parseLocalizedNumber):
6831
6832 2011-03-02 Dan Bernstein <mitz@apple.com>
6833
6834 Let Xcode know that Localizable.strings is UTF-16-encoded.
6835
6836 * WebCore.xcodeproj/project.pbxproj:
6837
6838 2011-03-02 Andy Estes <aestes@apple.com>
6839
6840 Reviewed by Eric Seidel.
6841
6842 HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
6843 https://bugs.webkit.org/show_bug.cgi?id=48719
6844
6845 Instead of pushing a fake HTMLHtmlElement onto the open element stack
6846 during fragment parsing only to later remove it and reparent its
6847 children to the DocumentFragment, push the DocumentFragment directly
6848 onto the open element stack as the root node. This requires refactoring
6849 HTMLElementStack to hold ContainerNode pointers rather than Element
6850 pointers, which has implications for HTMLConstructionSite and
6851 HTMLTreeBuilder as well.
6852
6853 With this patch, the regression in Peacekeeper due to the introduction
6854 of the HTML5 fragment parsing algorithm is ~14%. The regression from
6855 Safari 5.0.3 is ~24%.
6856
6857 No new tests. No change in behavior.
6858
6859 * dom/Element.h:
6860 (WebCore::Node::hasLocalName):
6861 * dom/Node.h:
6862 * html/parser/HTMLConstructionSite.cpp:
6863 (WebCore::HTMLNames::hasImpliedEndTag):
6864 (WebCore::HTMLConstructionSite::HTMLConstructionSite):
6865 (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
6866 (WebCore::HTMLConstructionSite::insertComment):
6867 (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
6868 (WebCore::HTMLConstructionSite::attachToCurrent):
6869 (WebCore::HTMLConstructionSite::insertScriptElement):
6870 (WebCore::HTMLConstructionSite::insertTextNode):
6871 (WebCore::HTMLConstructionSite::createElement):
6872 (WebCore::HTMLConstructionSite::createHTMLElement):
6873 (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
6874 (WebCore::HTMLConstructionSite::generateImpliedEndTags):
6875 (WebCore::HTMLConstructionSite::findFosterSite):
6876 (WebCore::HTMLConstructionSite::shouldFosterParent):
6877 * html/parser/HTMLConstructionSite.h:
6878 (WebCore::HTMLConstructionSite::currentNode):
6879 * html/parser/HTMLElementStack.cpp:
6880 (WebCore::HTMLNames::isNumberedHeaderElement):
6881 (WebCore::HTMLNames::isScopeMarker):
6882 (WebCore::HTMLNames::isListItemScopeMarker):
6883 (WebCore::HTMLNames::isTableScopeMarker):
6884 (WebCore::HTMLNames::isTableBodyScopeMarker):
6885 (WebCore::HTMLNames::isTableRowScopeMarker):
6886 (WebCore::HTMLNames::isButtonScopeMarker):
6887 (WebCore::HTMLNames::isSelectScopeMarker):
6888 (WebCore::HTMLElementStack::ElementRecord::ElementRecord):
6889 (WebCore::HTMLElementStack::ElementRecord::replaceElement):
6890 (WebCore::HTMLElementStack::HTMLElementStack):
6891 (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
6892 (WebCore::HTMLElementStack::popAll):
6893 (WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
6894 (WebCore::HTMLElementStack::popUntil):
6895 (WebCore::HTMLElementStack::popUntilPopped):
6896 (WebCore::HTMLElementStack::popUntilTableScopeMarker):
6897 (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
6898 (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
6899 (WebCore::HTMLElementStack::pushHTMLHtmlElement):
6900 (WebCore::HTMLElementStack::push):
6901 (WebCore::HTMLElementStack::insertAbove):
6902 (WebCore::HTMLElementStack::find):
6903 (WebCore::HTMLElementStack::topmost):
6904 (WebCore::HTMLElementStack::contains):
6905 (WebCore::inScopeCommon):
6906 (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
6907 (WebCore::HTMLElementStack::htmlElement):
6908 (WebCore::HTMLElementStack::rootNode):
6909 (WebCore::HTMLElementStack::pushCommon):
6910 * html/parser/HTMLElementStack.h:
6911 (WebCore::HTMLElementStack::ElementRecord::element):
6912 (WebCore::HTMLElementStack::ElementRecord::node):
6913 (WebCore::HTMLElementStack::topNode):
6914 * html/parser/HTMLTreeBuilder.cpp:
6915 (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
6916 (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
6917 (WebCore::HTMLTreeBuilder::processStartTagForInBody):
6918 (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
6919 (WebCore::HTMLTreeBuilder::processStartTag):
6920 (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
6921 (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
6922 (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
6923 (WebCore::HTMLTreeBuilder::processEndTagForInCell):
6924 (WebCore::HTMLTreeBuilder::processEndTagForInBody):
6925 (WebCore::HTMLTreeBuilder::processEndTag):
6926 (WebCore::HTMLTreeBuilder::processEndOfFile):
6927 (WebCore::HTMLTreeBuilder::finished):
6928 * html/parser/HTMLTreeBuilder.h:
6929
6930 2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
6931
6932 Unreviewed, rolling out r80188.
6933 http://trac.webkit.org/changeset/80188
6934 https://bugs.webkit.org/show_bug.cgi?id=55647
6935
6936 Broke the WebKit API tests. (Requested by xenon on #webkit).
6937
6938 * WebCore.exp.in:
6939
6940 2011-03-02 Kent Tamura <tkent@chromium.org>
6941
6942 Unreviewed, build fix.
6943
6944 * platform/text/LocalizedNumberICU.cpp:
6945 (WebCore::createFormatterForCurrentLocale): Fix a typo.
6946
6947 2011-03-02 Kent Tamura <tkent@chromium.org>
6948
6949 Reviewed by Darin Adler.
6950
6951 Caching number formatter instances in LocalizedNumber* implementations
6952 https://bugs.webkit.org/show_bug.cgi?id=55629
6953
6954 No new tests. This change doesn't change existing behavior, and is
6955 covered by existing tests.
6956
6957 * platform/text/LocalizedNumberICU.cpp:
6958 (WebCore::createFormatterForCurrentLocale):
6959 (WebCore::numberFormatter): Introduce a function to return a static
6960 instance of NumberFormat.
6961 (WebCore::parseLocalizedNumber): Use numberFormatter().
6962 (WebCore::formatLocalizedNumber): Use numberFormatter().
6963 * platform/text/mac/LocalizedNumberMac.mm:
6964 (WebCore::createFormatterForCurrentLocale):
6965 (WebCore::numberFormatter): Introduce a function to return a static
6966 instance of NSNumberFormatter.
6967 (WebCore::parseLocalizedNumber): Use numberFormatter().
6968 (WebCore::formatLocalizedNumber): Use numberFormatter().
6969
6970 2011-03-02 Levi Weintraub <leviw@chromium.org>
6971
6972 Reviewed by Ryosuke Niwa.
6973
6974 deprecatedEditingOffset should actually return the expected deprecated v alue for "after" positions
6975 https://bugs.webkit.org/show_bug.cgi?id=54986
6976
6977 Calls to deprecatedEditingOffset needs to return the expected value for new Before/After positions
6978 until we can update all the call sites to consider the new position type s.
6979
6980 No tests. This is intended to simplify the transition to new Positions, not to change behavior.
6981
6982 * dom/Position.cpp:
6983 (WebCore::Position::deprecatedEditingOffset):
6984 (WebCore::Position::offsetForPositionAfterAnchor): Added to do the right thing while ensuring
6985 inline-speed for most calls to deprecatedEditingOffset.
6986 * dom/Position.h:
6987
6988 2011-03-02 Timothy Hatcher <timothy@apple.com>
6989
6990 Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).
6991
6992 Reviewed by Darin Adler.
6993
6994 * WebCore.exp.in: Added __ZN7WebCore21SerializedScriptValue6createEPN3JS C9ExecStateENS1_7JSValueE.
6995
6996 2011-03-02 Daniel Cheng <dcheng@chromium.org>
6997
6998 Reviewed by David Levin.
6999
7000 Manually revert ChromiumDataObject changes.
7001 https://bugs.webkit.org/show_bug.cgi?id=55627
7002
7003 No new tests since no functionality should change.
7004
7005 * WebCore.gypi:
7006 * editing/chromium/EditorChromium.cpp:
7007 (WebCore::Editor::newGeneralClipboard):
7008 * page/chromium/EventHandlerChromium.cpp:
7009 (WebCore::EventHandler::createDraggingClipboard):
7010 * platform/chromium/ChromiumDataObject.cpp:
7011 (WebCore::ChromiumDataObject::clearData):
7012 (WebCore::ChromiumDataObject::clearAll):
7013 (WebCore::ChromiumDataObject::clearAllExceptFiles):
7014 (WebCore::ChromiumDataObject::hasData):
7015 (WebCore::ChromiumDataObject::types):
7016 (WebCore::ChromiumDataObject::getData):
7017 (WebCore::ChromiumDataObject::setData):
7018 (WebCore::ChromiumDataObject::ChromiumDataObject):
7019 * platform/chromium/ChromiumDataObject.h:
7020 (WebCore::ChromiumDataObject::create):
7021 (WebCore::ChromiumDataObject::copy):
7022 (WebCore::ChromiumDataObject::urlTitle):
7023 (WebCore::ChromiumDataObject::setUrlTitle):
7024 (WebCore::ChromiumDataObject::htmlBaseUrl):
7025 (WebCore::ChromiumDataObject::setHtmlBaseUrl):
7026 (WebCore::ChromiumDataObject::containsFilenames):
7027 (WebCore::ChromiumDataObject::filenames):
7028 (WebCore::ChromiumDataObject::setFilenames):
7029 (WebCore::ChromiumDataObject::fileExtension):
7030 (WebCore::ChromiumDataObject::setFileExtension):
7031 (WebCore::ChromiumDataObject::fileContentFilename):
7032 (WebCore::ChromiumDataObject::setFileContentFilename):
7033 (WebCore::ChromiumDataObject::fileContent):
7034 (WebCore::ChromiumDataObject::setFileContent):
7035 * platform/chromium/ClipboardChromium.cpp:
7036 * platform/chromium/ClipboardChromium.h:
7037
7038 2011-03-02 David Grogan <dgrogan@chromium.org>
7039
7040 Reviewed by Jeremy Orlow.
7041
7042 IndexedDB: fire versionchange events when calling setVersion
7043 https://bugs.webkit.org/show_bug.cgi?id=55095
7044
7045 * dom/EventNames.h:
7046 * storage/IDBDatabase.cpp:
7047 (WebCore::IDBDatabase::setVersion):
7048 (WebCore::IDBDatabase::close):
7049 (WebCore::IDBDatabase::onVersionChange):
7050 (WebCore::IDBDatabase::open):
7051 (WebCore::IDBDatabase::enqueueEvent):
7052 (WebCore::IDBDatabase::dispatchEvent):
7053 * storage/IDBDatabase.h:
7054 (WebCore::IDBDatabase::dispatchEvent):
7055 * storage/IDBDatabase.idl:
7056 * storage/IDBDatabaseBackendImpl.cpp:
7057 (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::create):
7058 (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::databaseCallbac ks):
7059 (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::PendingSetVersi onCall):
7060 (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
7061 (WebCore::IDBDatabaseBackendImpl::setVersion):
7062 (WebCore::IDBDatabaseBackendImpl::open):
7063 (WebCore::IDBDatabaseBackendImpl::close):
7064 * storage/IDBDatabaseBackendImpl.h:
7065 * storage/IDBDatabaseBackendInterface.h:
7066 * storage/IDBDatabaseCallbacks.h: Copied from Source/WebCore/storage/IDB VersionChangeEvent.cpp.
7067 (WebCore::IDBDatabaseCallbacks::~IDBDatabaseCallbacks):
7068 * storage/IDBFactoryBackendImpl.cpp:
7069 (WebCore::IDBFactoryBackendImpl::open):
7070 * storage/IDBRequest.cpp:
7071 (WebCore::IDBRequest::onSuccess):
7072 * storage/IDBVersionChangeEvent.cpp:
7073 (WebCore::IDBVersionChangeEvent::create):
7074 (WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):
7075 * storage/IDBVersionChangeEvent.h:
7076 * storage/IDBVersionChangeRequest.cpp:
7077 (WebCore::IDBVersionChangeRequest::onBlocked):
7078
7079 2011-03-02 Alexey Proskuryakov <ap@apple.com>
7080
7081 Fix assertion failures on Gtk bot.
7082
7083 * page/EventHandler.cpp: (WebCore::EventHandler::tabsToLinks): Removed a n overzealous
7084 assertion. We can get here with non-Tab key events when spatial navigati on is enabled.
7085
7086 2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
7087
7088 Unreviewed, rolling out r80139.
7089 http://trac.webkit.org/changeset/80139
7090 https://bugs.webkit.org/show_bug.cgi?id=55620
7091
7092 failing and crashing tests on Snow Leopard bot (Requested by
7093 mihaip1 on #webkit).
7094
7095 * page/DOMWindow.cpp:
7096 * page/DOMWindow.h:
7097 * page/Frame.cpp:
7098 (WebCore::Frame::pageDestroyed):
7099 (WebCore::Frame::transferChildFrameToNewDocument):
7100 * page/Frame.h:
7101 (WebCore::Frame::detachFromPage):
7102 * page/Geolocation.cpp:
7103 (WebCore::Geolocation::~Geolocation):
7104 (WebCore::Geolocation::disconnectFrame):
7105 (WebCore::Geolocation::lastPosition):
7106 (WebCore::Geolocation::requestPermission):
7107 (WebCore::Geolocation::startUpdating):
7108 (WebCore::Geolocation::stopUpdating):
7109 * page/Geolocation.h:
7110 * page/GeolocationController.cpp:
7111 (WebCore::GeolocationController::~GeolocationController):
7112 * page/Navigator.cpp:
7113 * page/Navigator.h:
7114 * platform/mock/GeolocationClientMock.cpp:
7115 * platform/mock/GeolocationClientMock.h:
7116
7117 2011-03-02 Jessie Berlin <jberlin@apple.com>
7118
7119 Reviewed by Adam Roben.
7120
7121 WebKit2: Use CFNetwork Sessions API.
7122 https://bugs.webkit.org/show_bug.cgi?id=55435
7123
7124 Add the ability to create a Private Browsing Storage Session.
7125
7126 * WebCore.exp.in:
7127 Export the symbol for ResourceHandle::setPrivateBrowsingStorageSessionId entifierBase.
7128
7129 * page/Settings.cpp:
7130 (WebCore::Settings::setPrivateBrowsingEnabled):
7131 Propagate the private browsing state to the ResourceHandle.
7132
7133 * platform/mac/WebCoreSystemInterface.h:
7134 Add the function declaration for wkCreatePrivateStorageSession.
7135 * platform/mac/WebCoreSystemInterface.mm:
7136
7137 * platform/network/ResourceHandle.cpp:
7138 (WebCore::privateStorageSession):
7139 Since the same Private Browsing Storage Session will need to be accessed throughout the loading
7140 code and will need to be used by all web pages and page groups, make it a global static.
7141 (WebCore::privateBrowsingStorageSessionIdentifierBase):
7142 Ditto, since the identifier is needed to create the Private Browsing Sto rage Session.
7143 (WebCore::ResourceHandle::setPrivateBrowsingEnabled):
7144 If enabled, create and store the Private Browsing Storage Session.
7145 (WebCore::ResourceHandle::privateBrowsingStorageSession):
7146 (WebCore::ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase ):
7147 * platform/network/ResourceHandle.h:
7148
7149 * platform/network/cf/ResourceHandleCFNet.cpp:
7150 (WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
7151 The call to wkCreatePrivateStorageSession needs to be in a file includin g the correct
7152 version of WKSI.
7153 (WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefault Base):
7154 Return the bundle identifier.
7155 * platform/network/mac/ResourceHandleMac.mm:
7156 (WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
7157 The call to wkCreatePrivateStorageSession needs to be in a file importin g the correct
7158 version of WKSI.
7159 (WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefault Base):
7160 Return the bundle identifier.
7161
7162 2011-03-02 Daniel Cheng <dcheng@chromium.org>
7163
7164 Revert frame-specific WebClipboard changes
7165 https://bugs.webkit.org/show_bug.cgi?id=55617
7166
7167 This code is no longer needed since we've decided to use the original
7168 approach to copy/paste drag/drop handling in ClipboardChromium.
7169
7170 No new tests because no functionality changes.
7171
7172 * platform/chromium/ChromiumDataObject.cpp:
7173 (WebCore::ChromiumDataObject::createReadable):
7174 * platform/chromium/ChromiumDataObject.h:
7175 * platform/chromium/ClipboardChromium.cpp:
7176 (WebCore::ClipboardChromium::create):
7177 * platform/chromium/PlatformBridge.h:
7178 * platform/chromium/ReadableDataObject.cpp:
7179 (WebCore::ReadableDataObject::create):
7180 (WebCore::ReadableDataObject::ReadableDataObject):
7181 (WebCore::ReadableDataObject::getData):
7182 (WebCore::ReadableDataObject::urlTitle):
7183 (WebCore::ReadableDataObject::htmlBaseUrl):
7184 (WebCore::ReadableDataObject::filenames):
7185 (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
7186 * platform/chromium/ReadableDataObject.h:
7187
7188 2011-03-02 Tony Chang <tony@chromium.org>
7189
7190 Unreviewed, rolling chromium DEPS to r76362.
7191
7192 https://bugs.webkit.org/show_bug.cgi?id=55564
7193
7194 * WebCore.gyp/WebCore.gyp: Switch to libjpeg_turbo to match chromium
7195
7196 2011-03-02 Alexey Proskuryakov <ap@apple.com>
7197
7198 Build fix.
7199
7200 * page/ChromeClient.h: (WebCore::ChromeClient::keyboardUIMode): I didn't mean to commit these
7201 changes yet.
7202
7203 2011-03-02 Alexey Proskuryakov <ap@apple.com>
7204
7205 Reviewed by John Sullivan.
7206
7207 Clean up WebCore tabsToLinks code a little
7208 https://bugs.webkit.org/show_bug.cgi?id=55606
7209
7210 No change in behavior, so no tests.
7211
7212 * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isK eyboardFocusable):
7213 This is the only caller of tabsToAllControls(). Renamed this function to tabsToAllFormControls().
7214
7215 * page/EventHandler.cpp:
7216 (WebCore::EventHandler::isKeyboardOptionTab): Moved from platform specif ic files. This
7217 function cannot be file static, because EventHandlerMac.mm uses it.
7218 (WebCore::eventInvertsTabsToLinksClientCallResult): Merged implementatio ns from platform
7219 specific files. We can just as well have #if here. Renamed for clarity.
7220 (WebCore::EventHandler::tabsToLinks): Rewrote in a way that makes it cle arer how "invert"
7221 works.
7222
7223 * page/EventHandler.h: We no longer need invertSenseOfTabsToLinks() here , it's only used
7224 in EventHandler.cpp.
7225
7226 * page/android/EventHandlerAndroid.cpp: (WebCore::EventHandler::tabsToAl lFormControls):
7227 * page/brew/EventHandlerBrew.cpp: (WebCore::EventHandler::tabsToAllFormC ontrols):
7228 * page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::tabsTo AllFormControls):
7229 * page/efl/EventHandlerEfl.cpp: (WebCore::EventHandler::tabsToAllFormCon trols):
7230 * page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::tabsToAllFormCon trols):
7231 * page/haiku/EventHandlerHaiku.cpp: (WebCore::EventHandler::tabsToAllFor mControls):
7232 * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToAllFormCont rols):
7233 * page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::tabsToAllFormContr ols):
7234 * page/win/EventHandlerWin.cpp: (WebCore::EventHandler::tabsToAllFormCon trols):
7235 * page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::tabsToAllFormContr ols):
7236 Updating all port files.
7237
7238 2011-02-28 Jeremy Orlow <jorlow@chromium.org>
7239
7240 Reviewed by James Robinson.
7241
7242 Split IDBCursor.value into IDBCursor.primaryKey and IDBCursor.value
7243 https://bugs.webkit.org/show_bug.cgi?id=55443
7244
7245 Implement http://www.w3.org/Bugs/Public/show_bug.cgi?id=11948
7246
7247 The idea is to have an IDBCursor and an IDBCursorWithValue interface whi ch
7248 inherits from the former. index.openKeyCursor will return the former an d
7249 index/objectStore.openCursor will return the latter. We'll add a primar yKey
7250 attribute to IDBCursor. It will always be the key of the associated obj ect
7251 store entry. For index.openCursor cursors, the key attribute will be th e key
7252 of the index. For objectStore.openCursors, it'll be the same as the
7253 primaryKey. The value will be the value of the objectStore entry.
7254
7255 * WebCore.gypi:
7256 * bindings/scripts/CodeGeneratorV8.pm:
7257 * bindings/v8/SerializedScriptValue.cpp:
7258 (WebCore::SerializedScriptValue::deserializeAndSetProperty):
7259 * bindings/v8/SerializedScriptValue.h:
7260 * bindings/v8/custom/V8IDBAnyCustom.cpp:
7261 (WebCore::toV8):
7262 * storage/IDBAny.cpp:
7263 (WebCore::IDBAny::idbCursorWithValue):
7264 (WebCore::IDBAny::set):
7265 * storage/IDBAny.h:
7266 * storage/IDBCursor.cpp:
7267 (WebCore::IDBCursor::create):
7268 (WebCore::IDBCursor::primaryKey):
7269 (WebCore::IDBCursor::value):
7270 * storage/IDBCursor.h:
7271 * storage/IDBCursor.idl:
7272 * storage/IDBCursorBackendImpl.cpp:
7273 (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
7274 (WebCore::IDBCursorBackendImpl::primaryKey):
7275 (WebCore::IDBCursorBackendImpl::value):
7276 (WebCore::IDBCursorBackendImpl::update):
7277 (WebCore::IDBCursorBackendImpl::currentRowExists):
7278 (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
7279 (WebCore::IDBCursorBackendImpl::deleteFunction):
7280 (WebCore::IDBCursorBackendImpl::loadCurrentRow):
7281 * storage/IDBCursorBackendImpl.h:
7282 (WebCore::IDBCursorBackendImpl::create):
7283 * storage/IDBCursorBackendInterface.h:
7284 * storage/IDBCursorWithValue.cpp: Copied from Source/WebCore/storage/IDB Cursor.idl.
7285 (WebCore::IDBCursorWithValue::create):
7286 (WebCore::IDBCursorWithValue::IDBCursorWithValue):
7287 (WebCore::IDBCursorWithValue::~IDBCursorWithValue):
7288 * storage/IDBCursorWithValue.h: Copied from Source/WebCore/storage/IDBCu rsorBackendInterface.h.
7289 * storage/IDBCursorWithValue.idl: Copied from Source/WebCore/storage/IDB Cursor.idl.
7290 * storage/IDBIndex.cpp:
7291 (WebCore::IDBIndex::openCursor):
7292 (WebCore::IDBIndex::openKeyCursor):
7293 * storage/IDBIndexBackendImpl.cpp:
7294 (WebCore::IDBIndexBackendImpl::openCursorInternal):
7295 (WebCore::IDBIndexBackendImpl::openCursor):
7296 (WebCore::IDBIndexBackendImpl::openKeyCursor):
7297 * storage/IDBIndexBackendImpl.h:
7298 * storage/IDBObjectStore.cpp:
7299 (WebCore::IDBObjectStore::openCursor):
7300 * storage/IDBObjectStoreBackendImpl.cpp:
7301 (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
7302 * storage/IDBRequest.cpp:
7303 (WebCore::IDBRequest::IDBRequest):
7304 (WebCore::IDBRequest::setCursorType):
7305 (WebCore::IDBRequest::onSuccess):
7306 (WebCore::IDBRequest::dispatchEvent):
7307 * storage/IDBRequest.h:
7308
7309 2011-03-02 Aravind Akella <aravind.akella@nokia.com>
7310
7311 Reviewed by Csaba Osztrogonác.
7312
7313 [Qt][WK2] Memory exhausted when building qtwebkit2 on linux
7314 https://bugs.webkit.org/show_bug.cgi?id=55484
7315
7316 Using AllInOne files to avoid memory exhaustion for debug
7317 builds on 32 bit linux machines.
7318
7319 No new tests. Fixing a build issue.
7320
7321 * WebCore.pro:
7322
7323 2011-03-02 Daniel Cheng <dcheng@chromium.org>
7324
7325 Reviewed by David Levin.
7326
7327 Add feature define for data transfer items
7328 https://bugs.webkit.org/show_bug.cgi?id=55510
7329
7330 * Configurations/FeatureDefines.xcconfig:
7331 * GNUmakefile.am:
7332 * features.pri:
7333
7334 2011-03-02 Dimitri Glazkov <dglazkov@chromium.org>
7335
7336 Update location of media-file.js, which was moved in r79630.
7337
7338 * manual-tests/media-controls.html: Updated location.
7339
7340 2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
7341
7342 Unreviewed, rolling out r80156.
7343 http://trac.webkit.org/changeset/80156
7344 https://bugs.webkit.org/show_bug.cgi?id=55604
7345
7346 "Broke SL compile" (Requested by tonyg-cr on #webkit).
7347
7348 * bridge/jni/JNIBridge.h:
7349 (JSC::Bindings::JavaString::operator UString):
7350 * bridge/jni/jni_jsobject.mm:
7351 (JavaJSObject::call):
7352 (JavaJSObject::eval):
7353 (JavaJSObject::getMember):
7354 (JavaJSObject::setMember):
7355 (JavaJSObject::removeMember):
7356 * bridge/jni/jsc/JavaClassJSC.cpp:
7357 (JavaClass::JavaClass):
7358 * bridge/jni/jsc/JavaStringJSC.h:
7359 (JSC::Bindings::JavaStringImpl::uString):
7360 * bridge/jni/v8/JavaStringV8.h:
7361
7362 2011-03-02 Steve Block <steveblock@google.com>
7363
7364 Reviewed by Jeremy Orlow.
7365
7366 JavaString API should be implementable by both JSC and V8
7367 https://bugs.webkit.org/show_bug.cgi?id=55567
7368
7369 Remove JavaString's UString operator and replace it with a
7370 script-engine-independent impl() method, which returns a
7371 StringImpl and can be implemented with both JSC and V8.
7372
7373 No new tests, refactoring only.
7374
7375 * bridge/jni/JNIBridge.h:
7376 (JSC::Bindings::JavaString::impl):
7377 * bridge/jni/jni_jsobject.mm:
7378 (JavaJSObject::call):
7379 (JavaJSObject::eval):
7380 (JavaJSObject::getMember):
7381 (JavaJSObject::setMember):
7382 (JavaJSObject::removeMember):
7383 * bridge/jni/jsc/JavaClassJSC.cpp:
7384 (JavaClass::JavaClass):
7385 * bridge/jni/jsc/JavaStringJSC.h:
7386 (JSC::Bindings::JavaStringImpl::impl):
7387 * bridge/jni/v8/JavaStringV8.h:
7388 (JSC::Bindings::JavaStringImpl::impl):
7389
7390 2011-03-02 Mihai Parparita <mihaip@chromium.org>
7391
7392 Reviewed by Dimitri Glazkov.
7393
7394 Add CRASH() for CSSSelector double frees
7395 https://bugs.webkit.org/show_bug.cgi?id=55596
7396
7397 To help track down bug 53045, add a CRASH call when the CSSSelector
7398 destructor is invoked more than once.
7399
7400 Just a check, no new tests necessary.
7401
7402 * css/CSSSelector.h:
7403 (WebCore::CSSSelector::CSSSelector):
7404 (WebCore::CSSSelector::~CSSSelector):
7405
7406 2011-03-02 Carol Szabo <carol.szabo@nokia.com>
7407
7408 Reviewed by David Hyatt <hyatt@apple.com>
7409
7410 content property doesn't support quotes
7411 https://bugs.webkit.org/show_bug.cgi?id=6503
7412
7413 Added full support for quotes as defined by CSS 2.1.
7414
7415 Tests: fast/css/content/content-quotes-01.html
7416 fast/css/content/content-quotes-02.html
7417 fast/css/content/content-quotes-03.html
7418 fast/css/content/content-quotes-04.html
7419 fast/css/content/content-quotes-05.html
7420 fast/css/content/content-quotes-06.html
7421
7422 * Android.mk:
7423 * CMakeLists.txt:
7424 * GNUmakefile.am:
7425 * WebCore.gypi:
7426 * WebCore.pro:
7427 * WebCore.vcproj/WebCore.vcproj:
7428 * WebCore.xcodeproj/project.pbxproj:
7429 Added RenderQuote.cpp/h and QuotesData.cpp/h to the dependency lists
7430 * css/CSSParser.cpp:
7431 (WebCore::CSSParser::parseValue):
7432 (WebCore::CSSParser::parseQuotes):
7433 * css/CSSParser.h:
7434 Added needed stylesheet parsing support for quotes,
7435 (no-)open-quote and (no-)close-quote
7436 * css/CSSStyleSelector.cpp:
7437 (WebCore::CSSStyleSelector::applyProperty):
7438 Handled setting of the new quotes RenderStyle property and added
7439 handling of quotes for the content property.
7440 * css/html.css:
7441 (q:before):
7442 (q:after):
7443 replaced the '"' workaround with open/close-quote
7444 * rendering/RenderBlockLineLayout.cpp:
7445 (WebCore::dirtyLineBoxesForRenderer):
7446 Made RenderQuote behave like RenderCounter.
7447 Needed to ensure that the Quote text is calculated before layout,
7448 just as it is for RenderCounter.
7449 * rendering/RenderObject.h:
7450 (WebCore::RenderObject::isQuote):
7451 * rendering/RenderObjectChildList.cpp:
7452 (WebCore::RenderObjectChildList::removeChildNode):
7453 (WebCore::RenderObjectChildList::appendChildNode):
7454 (WebCore::RenderObjectChildList::insertChildNode):
7455 Handled updating of quote depth when renderers are added and removed
7456 from the tree.
7457 (WebCore::RenderObjectChildList::updateBeforeAfterContent):
7458 Added support for Quote content.
7459 * rendering/RenderQuote.cpp: Added.
7460 (WebCore::adjustDepth):
7461 (WebCore::RenderQuote::RenderQuote):
7462 (WebCore::RenderQuote::~RenderQuote):
7463 (WebCore::RenderQuote::renderName):
7464 (WebCore::RenderQuote::placeQuote):
7465 (WebCore::LanguageData::operator<):
7466 (WebCore::defaultLanguageQuotes):
7467 (WebCore::quotesMap):
7468 (WebCore::quotesForLanguage):
7469 (WebCore::defaultQuotes):
7470 (WebCore::RenderQuote::originalText):
7471 (WebCore::RenderQuote::computePreferredLogicalWidths):
7472 (WebCore::RenderQuote::rendererSubtreeAttached):
7473 (WebCore::RenderQuote::rendererRemovedFromTree):
7474 (WebCore::RenderQuote::styleDidChange):
7475 * rendering/RenderQuote.h: Added.
7476 (WebCore::RenderQuote::isQuote):
7477 (WebCore::toRenderQuote):
7478 * rendering/RenderingAllInOne.cpp:
7479 Included RenderQuote.cpp
7480 * rendering/style/StyleAllInOne.cpp:
7481 Included QuotesData.cpp
7482 * rendering/style/ContentData.cpp:
7483 (WebCore::ContentData::dataEquivalent):
7484 Checked for quotetype identity.
7485 (WebCore::ContentData::deleteContent):
7486 Accounted for the new QUOTE_TYPE.
7487 * rendering/style/ContentData.h:
7488 (WebCore::ContentData::isQuote):
7489 (WebCore::ContentData::quote):
7490 (WebCore::ContentData::setQuote):
7491 * rendering/style/QuotesData.cpp: Added.
7492 (WebCore::QuotesData::create):
7493 (WebCore::QuotesData::operator==):
7494 (WebCore::QuotesData::~QuotesData):
7495 * rendering/style/QuotesData.h: Added.
7496 (WebCore::QuotesData::data):
7497 (WebCore::QuotesData::operator delete):
7498 (WebCore::QuotesData::QuotesData):
7499 * rendering/style/RenderStyle.cpp:
7500 (WebCore::RenderStyle::setContent):
7501 (WebCore::RenderStyle::setQuotes):
7502 * rendering/style/RenderStyle.h:
7503 (WebCore::InheritedFlags::quotes):
7504 (WebCore::InheritedFlags::setQuotes):
7505 * rendering/style/RenderStyleConstants.h:
7506 * rendering/style/StyleAllInOne.cpp:
7507 Added QuotesData.cpp to the included files list.
7508 * rendering/style/StyleRareInheritedData.cpp:
7509 (WebCore::StyleRareInheritedData::operator==):
7510 Included quotes in equality check.
7511 * rendering/style/StyleRareInheritedData.h:
7512 Added quotes
7513
7514 2011-03-02 Antti Koivisto <antti@apple.com>
7515
7516 Reviewed by Dave Hyatt.
7517
7518 Selector usage flags should not be set by the CSS parser
7519 https://bugs.webkit.org/show_bug.cgi?id=55573
7520
7521 Currently flags like Document::usesSiblingRules() are set directly by th e CSS parser. This is wrong as
7522 we may parse stylesheets that are not actually used for document renderi ng. This is especially bad when
7523 the page uses querySelectorAll(). As a result we may end up in various p erformance penalty boxes
7524 triggered by complex selectors for no good reason.
7525
7526 - Use the selector traversal in style selector constructor to figure out which flags
7527 are actually needed for the currently active style sheets.
7528 - Remove the selector flag related code from the CSS parser/grammar.
7529 - Remove the usesDescendantRules flag completely. We have descendant rul es in the default
7530 style sheet, every document uses them.
7531
7532 * css/CSSGrammar.y:
7533 * css/CSSParser.cpp:
7534 (WebCore::CSSParser::updateSpecifiersWithElementName):
7535 * css/CSSStyleSelector.cpp:
7536 (WebCore::collectSiblingRulesInDefaultStyle):
7537 (WebCore::CSSStyleSelector::CSSStyleSelector):
7538 (WebCore::CSSStyleSelector::Features::Features):
7539 (WebCore::CSSStyleSelector::Features::~Features):
7540 (WebCore::CSSStyleSelector::locateCousinList):
7541 (WebCore::CSSStyleSelector::matchesSiblingRules):
7542 (WebCore::CSSStyleSelector::canShareStyleWithElement):
7543 (WebCore::CSSStyleSelector::locateSharedStyle):
7544 (WebCore::collectFeaturesFromSelector):
7545 (WebCore::collectFeaturesFromList):
7546 (WebCore::RuleSet::collectFeatures):
7547 * css/CSSStyleSelector.h:
7548 (WebCore::CSSStyleSelector::usesSiblingRules):
7549 (WebCore::CSSStyleSelector::usesFirstLineRules):
7550 (WebCore::CSSStyleSelector::usesBeforeAfterRules):
7551 (WebCore::CSSStyleSelector::usesLinkRules):
7552 * dom/Document.cpp:
7553 (WebCore::Document::Document):
7554 (WebCore::Document::recalcStyle):
7555 (WebCore::Document::createStyleSelector):
7556 * dom/Document.h:
7557 (WebCore::Document::usesSiblingRules):
7558 (WebCore::Document::setUsesSiblingRules):
7559 (WebCore::Document::usesFirstLineRules):
7560 (WebCore::Document::usesBeforeAfterRules):
7561 (WebCore::Document::setUsesBeforeAfterRules):
7562 * dom/Element.cpp:
7563 (WebCore::Element::recalcStyle):
7564
7565 2011-03-02 Brian Weinstein <bweinstein@apple.com>
7566
7567 Fix fallout from a last minute renaming.
7568
7569 * platform/network/cf/CookieStorageCFNet.cpp:
7570 (WebCore::startObservingCookieChanges):
7571 (WebCore::stopObservingCookieChanges):
7572
7573 2011-03-01 Brian Weinstein <bweinstein@apple.com>
7574
7575 Reviewed by Adam Roben.
7576
7577 Part of WebKit2: Need a way to send notifications to client when cookies change
7578 https://bugs.webkit.org/show_bug.cgi?id=55427
7579 <rdar://problem/9056027>
7580
7581 Add functions on CookieStorage that allow listening for changes in cooki es. When
7582 the cookies are changed, they call through to CookiesStrategy::notifyCoo kiesChanged.
7583
7584 No change in behavior requiring tests.
7585
7586 * platform/CookiesStrategy.h: Added.
7587 (WebCore::CookiesStrategy::~CookiesStrategy):
7588
7589 * platform/PlatformStrategies.h:
7590 (WebCore::PlatformStrategies::cookiesStrategy):
7591 (WebCore::PlatformStrategies::PlatformStrategies):
7592
7593 * platform/network/CookieStorage.h: Add new function declarations.
7594
7595 * platform/network/cf/CookieStorageCFNet.cpp:
7596 (WebCore::notifyCookiesChangedOnMainThread): Call through to CookiesStra tegy::notifyCookiesChanged.
7597 (WebCore::notifyCookiesChanged): Call notifyCookiesChangedOnMainThread o n the main thread.
7598 (WebCore::beginObservingCookieChanges): Set up cookie observers on the l oader run loop.
7599 (WebCore::finishObservingCookieChanges): Remove our cookie observers fro m the loader run loop.
7600
7601 * platform/network/mac/CookieStorageMac.mm:
7602 (-[CookieStorageObjCAdapter notifyCookiesChangedOnMainThread]): Call thr ough to CookiesStrategy::notifyCookiesChanged.
7603 (-[CookieStorageObjCAdapter cookiesChangedNotificationHandler:]): Call n otifyCookiesChangedOnMainThread on
7604 the main thread.
7605 (-[CookieStorageObjCAdapter registerForCookieChangeNotifications]): Set up the observer for cookie change notifications.
7606 (-[CookieStorageObjCAdapter unregisterForCookieChangeNotifications]): Re move the observer for cookie change notifications.
7607 (WebCore::beginObservingCookieChanges): Create our CookieStorageObjCAdap ter, and call registerForCookieChangeNotifications.
7608 (WebCore::finishObservingCookieChanges): Call unregisterForCookieChangeN otifications.
7609
7610 Add new file.
7611 * WebCore.vcproj/WebCore.vcproj:
7612 * WebCore.xcodeproj/project.pbxproj: Set role on files we need to includ e in WebKit to private.
7613
7614 2011-03-02 Sergey Glazunov <serg.glazunov@gmail.com>
7615
7616 Reviewed by Dimitri Glazkov.
7617
7618 A WebKitCSSKeyframesRule object should set itself as the parent for inse rted rules
7619 https://bugs.webkit.org/show_bug.cgi?id=55488
7620
7621 Test: fast/css/css-keyframe-parent.html
7622
7623 * css/WebKitCSSKeyframesRule.cpp:
7624 (WebCore::WebKitCSSKeyframesRule::append):
7625
7626 2011-03-02 Sergio Villar Senin <svillar@igalia.com>
7627
7628 Reviewed by Martin Robinson.
7629
7630 [GTK] Add support for external protocol handlers
7631 https://bugs.webkit.org/show_bug.cgi?id=55473
7632
7633 Do not unconditionally create and replace the SoupRequester of the
7634 SoupSession if there is already one. No new tests needed as we
7635 just allow clients to create their our SoupRequesters.
7636
7637 * platform/network/soup/ResourceHandleSoup.cpp:
7638 (WebCore::ensureSessionIsInitialized):
7639
7640 2011-03-02 John Knottenbelt <jknotten@chromium.org>
7641
7642 Reviewed by jknotten@chromium.org.
7643
7644 Fix build-breakage when GEOLOCATION not enabled.
7645 https://bugs.webkit.org/show_bug.cgi?id=55586
7646
7647 Geolocation::reset needs to be defined if ENABLE(GEOLOCATION)
7648 is not true.
7649
7650 * page/Geolocation.cpp:
7651 (WebCore::Geolocation::reset):
7652
7653 2011-03-02 Pavel Feldman <pfeldman@chromium.org>
7654
7655 Reviewed by Yury Semikhatsky.
7656
7657 Web Inspector: remove InjectedScriptHost -> DOMAgent dependency.
7658 https://bugs.webkit.org/show_bug.cgi?id=55575
7659
7660 * bindings/js/JSInjectedScriptHostCustom.cpp:
7661 (WebCore::JSInjectedScriptHost::inspectedNode):
7662 * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
7663 (WebCore::V8InjectedScriptHost::inspectedNodeCallback):
7664 * inspector/ConsoleMessage.cpp:
7665 (WebCore::ConsoleMessage::addToFrontend):
7666 * inspector/InjectedScript.cpp:
7667 (WebCore::InjectedScript::evaluateOn):
7668 (WebCore::InjectedScript::wrapObject):
7669 (WebCore::InjectedScript::wrapNode):
7670 (WebCore::InjectedScript::inspectNode):
7671 (WebCore::InjectedScript::nodeAsScriptValue):
7672 * inspector/InjectedScript.h:
7673 * inspector/InjectedScriptHost.cpp:
7674 (WebCore::InjectedScriptHost::addInspectedNode):
7675 (WebCore::InjectedScriptHost::clearInspectedNodes):
7676 (WebCore::InjectedScriptHost::copyText):
7677 (WebCore::InjectedScriptHost::inspectedNode):
7678 * inspector/InjectedScriptHost.h:
7679 * inspector/InjectedScriptHost.idl:
7680 * inspector/InjectedScriptSource.js:
7681 * inspector/Inspector.idl:
7682 * inspector/InspectorDOMAgent.cpp:
7683 (WebCore::InspectorDOMAgent::discardBindings):
7684 (WebCore::InspectorDOMAgent::addInspectedNode):
7685 (WebCore::InspectorDOMAgent::resolveNode):
7686 (WebCore::InspectorDOMAgent::injectedScriptForNode):
7687 * inspector/InspectorDOMAgent.h:
7688 * inspector/InspectorRuntimeAgent.cpp:
7689 (WebCore::InspectorRuntimeAgent::evaluateOn):
7690 * inspector/InspectorRuntimeAgent.h:
7691 * inspector/front-end/ElementsTreeOutline.js:
7692 (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setToo ltip):
7693 (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolv edNode):
7694 (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
7695 * inspector/front-end/PropertiesSidebarPane.js:
7696 (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
7697 (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady ):
7698 (WebInspector.PropertiesSidebarPane.prototype.update.fillSection):
7699 (WebInspector.PropertiesSidebarPane.prototype.update):
7700 * inspector/front-end/RemoteObject.js:
7701 (WebInspector.RemoteObject.resolveNode):
7702 (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
7703 (WebInspector.RemoteObject.prototype.evaluate):
7704
7705 2011-01-21 John Knottenbelt <jknotten@chromium.org>
7706
7707 Reviewed by Dmitry Titov.
7708
7709 Detach Geolocation from Frame when Page destroyed.
7710 https://bugs.webkit.org/show_bug.cgi?id=52877
7711
7712 On Page destruction, any outstanding Geolocation permission
7713 requests should be cancelled, because the Geolocation can only
7714 access the client indirectly via m_frame->page().
7715
7716 Additionally, if the Frame is reparented to another page, the
7717 Geolocation should cancel watches, single-shots and requests on
7718 the old page.
7719
7720 Page destruction is signalled by a call to the
7721 Frame::pageDestroyed() method. This calls Frame::detachFromPage,
7722 where we extend the call chain to Geolocation::detachFromPage()
7723 where we call Geolocation::reset() which detaches from the
7724 GeolocationController, cancels requests, watches and single shots,
7725 and sets the permission state back to Unknown.
7726
7727 We also now call detachFromPage when the frame reparented in
7728 Frame::transferChildFrameToNewDocument.
7729
7730 Frame::pageDestroyed() is also called by FrameLoader even though
7731 the page is not destroyed. We should still cancel permission
7732 requests, because the GeolocationClient will become inaccessible
7733 to the Geolocation object after this call.
7734
7735 Since GeolocationController is owned by Page, and all Geolocation
7736 objects will now unsubscribe from the GeolocationController on
7737 pageDetached(), we no longer need to call stopUpdating() from the
7738 GeolocationController's destructor. Instead we can simply assert
7739 that there should be no no observers. See related bug
7740 https://bugs.webkit.org/show_bug.cgi?id=52216 .
7741
7742 Introduced new method 'numberOfPendingPermissionRequests' on
7743 GeolocationClientMock to count the number of outstanding pending
7744 permission requests. This provides a reusable implementation for
7745 client-based implementations of the LayoutTestController's
7746 numberOfPendingGeolocationPermissionRequests method.
7747
7748 Tests: fast/dom/Geolocation/iframe-reparent.html
7749 fast/dom/Geolocation/page-reload-cancel-permission-requests.html
7750
7751 * page/DOMWindow.cpp:
7752 (WebCore::DOMWindow::resetGeolocationPermissions):
7753 * page/DOMWindow.h:
7754 * page/Frame.cpp:
7755 (WebCore::Frame::detachFromPage):
7756 (WebCore::Frame::pageDestroyed):
7757 (WebCore::Frame::transferChildFrameToNewDocument):
7758 * page/Frame.h:
7759 * page/Geolocation.cpp:
7760 (WebCore::Geolocation::~Geolocation):
7761 (WebCore::Geolocation::page):
7762 (WebCore::Geolocation::reset):
7763 (WebCore::Geolocation::disconnectFrame):
7764 (WebCore::Geolocation::lastPosition):
7765 (WebCore::Geolocation::requestPermission):
7766 (WebCore::Geolocation::startUpdating):
7767 (WebCore::Geolocation::stopUpdating):
7768 * page/Geolocation.h:
7769 * page/GeolocationController.cpp:
7770 (WebCore::GeolocationController::~GeolocationController):
7771 * page/Navigator.cpp:
7772 (WebCore::Navigator::resetGeolocationPermissions):
7773 * page/Navigator.h:
7774 * platform/mock/GeolocationClientMock.cpp:
7775 (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
7776 * platform/mock/GeolocationClientMock.h:
7777
7778 2011-03-02 Mikhail Naganov <mnaganov@chromium.org>
7779
7780 Reviewed by Pavel Feldman.
7781
7782 Web Inspector: [Chromium] Landing detailed heap snapshots, part 4.
7783 https://bugs.webkit.org/show_bug.cgi?id=55563
7784
7785 This part adds implementations for data grids used to display
7786 different heap snapshots projections. We are almost done.
7787
7788 * English.lproj/localizedStrings.js:
7789 * WebCore.gypi:
7790 * bindings/v8/ScriptHeapSnapshot.cpp:
7791 (WebCore::ScriptHeapSnapshot::getExactRetainedSize):
7792 * bindings/v8/ScriptHeapSnapshot.h:
7793 * inspector/Inspector.idl:
7794 * inspector/InspectorProfilerAgent.cpp:
7795 (WebCore::InspectorProfilerAgent::getExactHeapSnapshotNodeRetainedSize):
7796 * inspector/InspectorProfilerAgent.h:
7797 * inspector/front-end/DetailedHeapshotGridNodes.js:
7798 (WebInspector.HeapSnapshotObjectNode):
7799 (WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
7800 (WebInspector.HeapSnapshotInstanceNode):
7801 (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
7802 (WebInspector.HeapSnapshotDominatorObjectNode):
7803 (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider) :
7804 (MixInSnapshotNodeFunctions):
7805 * inspector/front-end/DetailedHeapshotView.js:
7806 (WebInspector.HeapSnapshotContainmentDataGrid):
7807 (WebInspector.HeapSnapshotSortableDataGrid):
7808 (WebInspector.HeapSnapshotConstructorsDataGrid):
7809 (WebInspector.HeapSnapshotDiffDataGrid):
7810 (WebInspector.HeapSnapshotDominatorsDataGrid):
7811 (WebInspector.HeapSnapshotRetainingPathsList):
7812 (WebInspector.DetailedHeapshotView.profileCallback):
7813 (WebInspector.DetailedHeapshotView):
7814 * inspector/front-end/HeapSnapshot.js:
7815 (WebInspector.HeapSnapshotEdge.prototype.get isInvisible):
7816 (WebInspector.HeapSnapshotEdge.prototype.toString):
7817 (WebInspector.HeapSnapshot.prototype._init):
7818 (WebInspector.HeapSnapshot.prototype._buildAggregatesIndexes):
7819 (WebInspector.HeapSnapshot.prototype._markInvisibleEdges):
7820 (WebInspector.HeapSnapshotPathFinder.prototype._skipEdge):
7821 * inspector/front-end/Images/helpButtonGlyph.png: Added.
7822 * inspector/front-end/Panel.js:
7823 (WebInspector.Panel.prototype.reset):
7824 * inspector/front-end/Popover.js:
7825 (WebInspector.Popover):
7826 (WebInspector.Popover.prototype.show):
7827 (WebInspector.Popover.prototype.hide):
7828 (WebInspector.Popover.prototype.get visible):
7829 * inspector/front-end/ProfilesPanel.js:
7830 (WebInspector.ProfilesPanel.prototype._reset):
7831 (WebInspector.ProfilesPanel.prototype.getProfile):
7832 * inspector/front-end/heapProfiler.css:
7833 * inspector/front-end/inspector.js:
7834 (WebInspector.resetFocusElement):
7835
7836 2011-03-02 David Kilzer <ddkilzer@apple.com>
7837
7838 <http://webkit.org/b/55534> Clean up macros in Extensions3DOpenGL.cpp
7839
7840 Reviewed by Darin Adler.
7841
7842 Change "#if GL_APPLE_vertex_array_object" macros to check that
7843 GL_APPLE_vertex_array_object is both defined and non-zero.
7844
7845 * platform/graphics/opengl/Extensions3DOpenGL.cpp:
7846 (WebCore::Extensions3DOpenGL::createVertexArrayOES):
7847 (WebCore::Extensions3DOpenGL::deleteVertexArrayOES): Remove
7848 empty #else clause.
7849 (WebCore::Extensions3DOpenGL::isVertexArrayOES):
7850 (WebCore::Extensions3DOpenGL::bindVertexArrayOES): Add early
7851 return check. Remove #else clause that would never have
7852 compiled (since array is not a WTF::String).
7853
7854 2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
7855
7856 Reviewed by Darin Adler.
7857
7858 Assertion failure after removing a selection in keydown handler
7859 https://bugs.webkit.org/show_bug.cgi?id=51389
7860
7861 The bug was caused by textWillBeReplaced's not always updating selection , and
7862 shouldRemovePositionAfterAdoptingTextReplacement's not moving the end of fset when it's
7863 at the end of replaced data.
7864
7865 Fixed the bug by always updating selection in textWillBeReplaced and fix ing the condition
7866 to move the offset in shouldRemovePositionAfterAdoptingTextReplacement. Also added a call
7867 to setSelection instead of directly modifying m_selection to notify all the clients.
7868 Namely, the call to EditorClient::respondToChangedSelection is required for
7869 setting-input-value-cancel-ime-composition.html.
7870
7871 Note that we must update layout before calling setSelection because setS election calls
7872 setFocusedNodeIfNeeded and it requires layout to be up-to-date. Without this call, tests
7873 such as fast/forms/input-appearance-maxlength.html hits an assertion in Node::isFocusable.
7874
7875 Test: editing/input/setting-input-value-cancel-ime-composition.html
7876
7877 * editing/SelectionController.cpp:
7878 (WebCore::shouldRemovePositionAfterAdoptingTextReplacement): When replac ing text, the offset
7879 of the selection end must be updated even if it was at the end of the re placed text.
7880 e.g. removing "world" from "hello world] WebKit" should result in "hello ] WebKit" not
7881 "hello WebK[it". Note we don't move the offset if no text is removed be cause appending
7882 "world" to "hello ]" should result in "hello ]world" not "hello world]".
7883 (WebCore::SelectionController::textWillBeReplaced): Calls setSelection t o update
7884 the selection instead of modifying m_selection directly.
7885
7886 2011-03-02 Andrey Adaikin <aandrey@google.com>
7887
7888 Reviewed by Pavel Feldman.
7889
7890 Web Inspector: highlighted line does not span horizonally in scripts pan el while debugging.
7891 https://bugs.webkit.org/show_bug.cgi?id=54675
7892
7893 * inspector/front-end/TextViewer.js:
7894 (WebInspector.TextViewer.prototype._syncScroll):
7895 (WebInspector.TextEditorChunkedPanel.prototype._buildChunks):
7896 (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
7897 (WebInspector.TextEditorGutterPanel):
7898 (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
7899 (WebInspector.TextEditorGutterPanel.prototype.textChanged):
7900 (WebInspector.TextEditorMainPanel):
7901 (WebInspector.TextEditorMainPanel.prototype.set readOnly):
7902 (WebInspector.TextEditorMainPanel.prototype._getSelection):
7903 (WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
7904 (WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified):
7905 (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
7906 (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
7907 * inspector/front-end/textViewer.css:
7908 (.inner-container):
7909
7910 2011-03-02 Oleg Romashin <romaxa@gmail.com>
7911
7912 Reviewed by Andreas Kling.
7913
7914 Fixing inspector compilation with JAVASCRIPT_DEBUGGER disabled
7915 https://bugs.webkit.org/show_bug.cgi?id=55477
7916
7917 * inspector/InspectorAgent.cpp:
7918 (WebCore::InspectorAgent::populateScriptObjects):
7919
7920 2011-03-02 Kent Tamura <tkent@chromium.org>
7921
7922 Unreviewed, a trivial fix for r80096.
7923
7924 REGRESSION (r80096): [Chromium] fast/forms/input-number-unacceptable-sty le.html failure
7925 https://bugs.webkit.org/show_bug.cgi?id=55562
7926
7927 * platform/text/LocalizedNumberICU.cpp:
7928 (WebCore::parseLocalizedNumber): Check the ParsePosition after NumberFor mat::parse()
7929 to reject strings with a valid number + extra letters.
7930
7931 2011-03-02 Steve Block <steveblock@google.com>
7932
7933 Reviewed by Jeremy Orlow.
7934
7935 JObjectWrapper should be moved to its own file
7936 https://bugs.webkit.org/show_bug.cgi?id=55384
7937
7938 No new tests, refactoring only.
7939
7940 * Android.v8bindings.mk:
7941 * WebCore.gypi:
7942 * bridge/jni/v8/JNIBridgeV8.cpp:
7943 (JavaField::JavaField):
7944 * bridge/jni/v8/JNIBridgeV8.h:
7945 * bridge/jni/v8/JavaInstanceV8.cpp:
7946 (JavaInstance::JavaInstance):
7947 * bridge/jni/v8/JavaInstanceV8.h:
7948 * bridge/jni/v8/JobjectWrapper.cpp: Copied from Source/WebCore/bridge/jn i/v8/JNIBridgeV8.h.
7949 (JobjectWrapper::JobjectWrapper):
7950 (JobjectWrapper::~JobjectWrapper):
7951 * bridge/jni/v8/JobjectWrapper.h: Copied from Source/WebCore/bridge/jni/ v8/JNIBridgeV8.h.
7952 (JSC::Bindings::JobjectWrapper::instance):
7953 (JSC::Bindings::JobjectWrapper::setInstance):
7954 (JSC::Bindings::JobjectWrapper::ref):
7955 (JSC::Bindings::JobjectWrapper::deref):
7956
7957 2011-02-25 Andrey Kosyakov <caseq@chromium.org>
7958
7959 Reviewed by Pavel Feldman.
7960
7961 Web Inspector: factor search logic out of inspector.js
7962 https://bugs.webkit.org/show_bug.cgi?id=54965
7963
7964 * WebCore.gypi:
7965 * WebCore.vcproj/WebCore.vcproj:
7966 * inspector/front-end/ElementsPanel.js:
7967 (WebInspector.ElementsPanel.prototype.searchCanceled):
7968 (WebInspector.ElementsPanel.prototype.switchToAndFocus):
7969 (WebInspector.ElementsPanel.prototype._updateMatchesCount):
7970 * inspector/front-end/Panel.js:
7971 (WebInspector.Panel.prototype.searchCanceled):
7972 (WebInspector.Panel.prototype.performSearch.updateMatchesCount):
7973 * inspector/front-end/ScriptsPanel.js:
7974 (WebInspector.ScriptsPanel.prototype.searchCanceled):
7975 (WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
7976 (WebInspector.ScriptsPanel.prototype.performSearch):
7977 * inspector/front-end/SearchController.js: Added.
7978 (WebInspector.SearchController):
7979 (WebInspector.SearchController.prototype.updateSearchMatchesCount):
7980 (WebInspector.SearchController.prototype.updateSearchLabel):
7981 (WebInspector.SearchController.prototype.cancelSearch):
7982 (WebInspector.SearchController.prototype.handleShortcut):
7983 (WebInspector.SearchController.prototype.activePanelChanged.performPanel Search):
7984 (WebInspector.SearchController.prototype.activePanelChanged):
7985 (WebInspector.SearchController.prototype._updateSearchMatchesCount):
7986 (WebInspector.SearchController.prototype._focusSearchField):
7987 (WebInspector.SearchController.prototype._onSearchFieldManualFocus):
7988 (WebInspector.SearchController.prototype._onKeyDown):
7989 (WebInspector.SearchController.prototype._onSearch):
7990 (WebInspector.SearchController.prototype._performSearch):
7991 * inspector/front-end/WebKit.qrc:
7992 * inspector/front-end/inspector.html:
7993 * inspector/front-end/inspector.js:
7994 (WebInspector.set currentPanel):
7995 (WebInspector.set attached):
7996 (WebInspector.doLoadedDone):
7997 (WebInspector.documentKeyDown):
7998
7999 2011-03-02 Renata Hodovan <reni@webkit.org>
8000
8001 Reviewed by Andreas Kling.
8002
8003 FEMorphologyElement changes doesn't require relayout
8004 https://bugs.webkit.org/show_bug.cgi?id=55462
8005
8006 When the FEMorphologyElement receives an update message but the given va lue remains the same we don't need
8007 to relayout the filter.
8008
8009 No new tests are needed because this modification is covered by the dyna mic update tests of FEMorphology.
8010
8011 * platform/graphics/filters/FEMorphology.cpp:
8012 (WebCore::FEMorphology::setMorphologyOperator):
8013 (WebCore::FEMorphology::setRadiusX):
8014 (WebCore::FEMorphology::setRadiusY):
8015 * platform/graphics/filters/FEMorphology.h:
8016 * svg/SVGFEMorphologyElement.cpp:
8017 (WebCore::SVGFEMorphologyElement::setFilterEffectAttribute):
8018 (WebCore::SVGFEMorphologyElement::svgAttributeChanged):
8019 * svg/SVGFEMorphologyElement.h:
8020
8021 2011-03-01 Kent Tamura <tkent@chromium.org>
8022
8023 Reviewed by Dimitri Glazkov.
8024
8025 Assertion fails when a form validation bubble appears
8026 https://bugs.webkit.org/show_bug.cgi?id=55550
8027
8028 Test: fast/forms/interactive-validation-attach-assertion.html
8029
8030 * html/ValidationMessage.cpp:
8031 (WebCore::ValidationMessage::buildBubbleTree):
8032 Just remove unnecessary attach().
8033
8034 2011-03-01 Kent Tamura <tkent@chromium.org>
8035
8036 Reviewed by Dimitri Glazkov.
8037
8038 Support localized numbers in <input type=number>
8039 https://bugs.webkit.org/show_bug.cgi?id=42484
8040
8041 This change adds support of localized numbers in <input type=number>.
8042 This affects only the UI, and not HTMLInputElement::value.
8043
8044 - Remove the keyboard input restriction feature because it is hard to
8045 retrieve characters usable for localized numbers in ICU.
8046
8047 - Separate convertFromVisibleValue() from sanitizeValue().
8048 sanitizeValue() is used for not only converting a renderer value to a
8049 DOM value.
8050
8051 - Implement LocalizedNumber functions for ICU and NSNumberFormatter.
8052 It is used only in Chromium for now.
8053
8054 Test: manual-tests/input-number-localization.html
8055
8056 * WebCore.gypi: Use LocalizedNumberICU.cpp.
8057 * WebCore.xcodeproj/project.pbxproj:
8058 Add LocalizedNumberMac.mm and remove LocalizedNumberNone.cpp.
8059 * dom/InputElement.h: Introduce convertFromVisibleValue().
8060 * html/HTMLInputElement.cpp:
8061 (WebCore::HTMLInputElement::convertFromVisibleValue):
8062 * html/HTMLInputElement.h:
8063 * html/InputType.cpp:
8064 (WebCore::InputType::convertFromVisibleValue):
8065 * html/InputType.h:
8066 * html/NumberInputType.cpp: Remove isHTMLNumberCharacter(),
8067 isNumberCharacter(), and handleBeforeTextInsertedEvent() because we
8068 remove the keyboard input restriction feature for type=number.
8069 (WebCore::NumberInputType::convertFromVisibleValue):
8070 (WebCore::NumberInputType::sanitizeValue):
8071 * html/NumberInputType.h:
8072 * manual-tests/input-number-localization.html: Add a manual test because
8073 the behavior depends on the current locale.
8074 * platform/text/LocalizedNumber.h: Remove isLocalizedNumberCharacter().
8075 * platform/text/LocalizedNumberICU.cpp:
8076 Implement LocalizedNumber functions with ICU NumberFormat.
8077 (WebCore::createFormatterForCurrentLocale):
8078 (WebCore::parseLocalizedNumber):
8079 (WebCore::formatLocalizedNumber):
8080 * platform/text/LocalizedNumberNone.cpp: Remove isLocalizedNumberCharact er().
8081 * platform/text/mac/LocalizedNumberMac.mm:
8082 Implement LocalizedNumber functions with NSNumberFormatter.
8083 (WebCore::parseLocalizedNumber):
8084 (WebCore::formatLocalizedNumber):
8085 * rendering/RenderTextControlSingleLine.cpp:
8086 (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
8087 * wml/WMLInputElement.h:
8088 (WebCore::WMLInputElement::convertFromVisibleValue):
8089 Implemented as a function doing nothing.
8090
8091 2011-03-01 Yuta Kitamura <yutak@chromium.org>
8092
8093 Reviewed by Darin Adler.
8094
8095 REGRESSION(r78383): Failure to connect on websocketstest.com
8096 https://bugs.webkit.org/show_bug.cgi?id=54811
8097
8098 After r78383, KURL::setPort() no longer appends ":port" part
8099 if that port is the default port for URL scheme. This broke
8100 SocketStreamHandleCFNet, whose code was based on an assumption
8101 that KURL::setPort() always inserts ":port" part.
8102
8103 To fix this, KURL::port() call is removed from SocketStreamHandle
8104 and the port number is calculated on-the-fly.
8105
8106 Unfortunately it is impossible to write a test; this bug only
8107 affects WebSockets connecting to the default port (port 80
8108 for ws, port 443 for wss), while we use different ports to test
8109 WebSockets in LayoutTests.
8110
8111 * platform/network/cf/SocketStreamHandle.h:
8112 * platform/network/cf/SocketStreamHandleCFNet.cpp:
8113 (WebCore::SocketStreamHandle::SocketStreamHandle):
8114 (WebCore::SocketStreamHandle::createStreams):
8115 (WebCore::SocketStreamHandle::port):
8116
8117 2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
8118
8119 Unreviewed, rolling out r80079.
8120 http://trac.webkit.org/changeset/80079
8121 https://bugs.webkit.org/show_bug.cgi?id=55547
8122
8123 "Broke the Win debug build?" (Requested by dcheng on #webkit).
8124
8125 * Configurations/FeatureDefines.xcconfig:
8126 * GNUmakefile.am:
8127 * features.pri:
8128
8129 2011-02-25 Adrienne Walker <enne@google.com>
8130
8131 Reviewed by James Robinson.
8132
8133 [chromium] Abstract "pixels with a graphics context" into its own class
8134 https://bugs.webkit.org/show_bug.cgi?id=55259
8135
8136 This creates new PlatformCanvas/PlatformImage classes which wrap
8137 all of the #ifdef Skia/Cg warts from the compositor. All classes
8138 (LayerTilerChromium, ContentLayerChromium, and ImageLayerChromium) are
8139 modified to use these abstractions.
8140
8141 Tests: LayoutTests/compositing
8142
8143 * WebCore.gypi:
8144 * platform/graphics/chromium/ContentLayerChromium.cpp:
8145 (WebCore::ContentLayerChromium::updateContentsIfDirty):
8146 (WebCore::ContentLayerChromium::resizeUploadBuffer):
8147 (WebCore::ContentLayerChromium::updateTextureIfNeeded):
8148 (WebCore::ContentLayerChromium::updateTexture):
8149 (WebCore::ContentLayerChromium::draw):
8150 * platform/graphics/chromium/ContentLayerChromium.h:
8151 * platform/graphics/chromium/ImageLayerChromium.cpp:
8152 (WebCore::ImageLayerChromium::updateContentsIfDirty):
8153 (WebCore::ImageLayerChromium::updateTextureIfNeeded):
8154 * platform/graphics/chromium/ImageLayerChromium.h:
8155 * platform/graphics/chromium/LayerTilerChromium.cpp:
8156 (WebCore::LayerTilerChromium::contentRectToTileIndices):
8157 (WebCore::LayerTilerChromium::update):
8158 (WebCore::LayerTilerChromium::updateFromPixels):
8159 * platform/graphics/chromium/LayerTilerChromium.h:
8160 * platform/graphics/chromium/PlatformCanvas.cpp: Added.
8161 (WebCore::PlatformCanvas::PlatformCanvas):
8162 (WebCore::PlatformCanvas::~PlatformCanvas):
8163 (WebCore::PlatformCanvas::resize):
8164 (WebCore::PlatformCanvas::AutoLocker::AutoLocker):
8165 (WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
8166 (WebCore::PlatformCanvas::Painter::Painter):
8167 (WebCore::PlatformCanvas::Painter::~Painter):
8168 * platform/graphics/chromium/PlatformCanvas.h: Added.
8169 (WebCore::PlatformCanvas::AutoLocker::pixels):
8170 (WebCore::PlatformCanvas::Painter::context):
8171 (WebCore::PlatformCanvas::size):
8172 * platform/graphics/chromium/PlatformImage.cpp: Copied from Source/WebCo re/platform/graphics/chromium/ImageLayerChromium.cpp.
8173 (WebCore::PlatformImage::PlatformImage):
8174 (WebCore::PlatformImage::updateFromImage):
8175 * platform/graphics/chromium/PlatformImage.h: Added.
8176 (WebCore::PlatformImage::pixels):
8177 (WebCore::PlatformImage::size):
8178
8179 2011-03-01 Daniel Cheng <dcheng@chromium.org>
8180
8181 Reviewed by David Levin.
8182
8183 Add feature define for data transfer items
8184 https://bugs.webkit.org/show_bug.cgi?id=55510
8185
8186 * Configurations/FeatureDefines.xcconfig:
8187 * GNUmakefile.am:
8188 * features.pri:
8189
8190 2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
8191
8192 Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
8193
8194 * dom/ViewportArguments.cpp:
8195 (WebCore::computeViewportAttributes):
8196 (WebCore::numericPrefix):
8197 (WebCore::findSizeValue):
8198 (WebCore::setViewportFeature):
8199 (WebCore::viewportErrorMessageTemplate):
8200 (WebCore::viewportErrorMessageLevel):
8201 * dom/ViewportArguments.h:
8202
8203 2011-03-01 Jeremy Orlow <jorlow@chromium.org>
8204
8205 Reviewed by James Robinson.
8206
8207 IDBKeyRange.bound() should not use the optional options object
8208 https://bugs.webkit.org/show_bug.cgi?id=55419
8209
8210 http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#range-concept
8211
8212 Added some code to existing tests to cover these cases.
8213
8214 * storage/IDBKeyRange.cpp:
8215 (WebCore::IDBKeyRange::bound):
8216 * storage/IDBKeyRange.h:
8217 * storage/IDBKeyRange.idl:
8218
8219 2011-03-01 Dan Bernstein <mitz@apple.com>
8220
8221 Build fix.
8222
8223 * dom/DocumentMarkerController.cpp:
8224 (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectin gRange):
8225
8226 2011-03-01 Kent Tamura <tkent@chromium.org>
8227
8228 Unreviewed. Apply sort-Xcode-project-file.
8229
8230 * WebCore.xcodeproj/project.pbxproj:
8231
8232 2011-03-01 Jeremy Orlow <jorlow@chromium.org>
8233
8234 Reviewed by James Robinson.
8235
8236 V8 code generator doesn't properly support a single SerializedScriptValu e attribute
8237 https://bugs.webkit.org/show_bug.cgi?id=55530
8238
8239 This is tested by the bindings tests changes.
8240
8241 * bindings/scripts/CodeGeneratorV8.pm:
8242 * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp : Added.
8243 (WebDOMTestSerializedScriptValueInterface::WebDOMTestSerializedScriptVal ueInterfacePrivate::WebDOMTestSerializedScriptValueInterfacePrivate):
8244 (WebDOMTestSerializedScriptValueInterface::WebDOMTestSerializedScriptVal ueInterface):
8245 (WebDOMTestSerializedScriptValueInterface::operator=):
8246 (WebDOMTestSerializedScriptValueInterface::impl):
8247 (WebDOMTestSerializedScriptValueInterface::~WebDOMTestSerializedScriptVa lueInterface):
8248 (WebDOMTestSerializedScriptValueInterface::value):
8249 (toWebCore):
8250 (toWebKit):
8251 * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h: Added.
8252 * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterf ace.cpp: Added.
8253 (WebKit::kit):
8254 (webkit_dom_test_serialized_script_value_interface_get_value):
8255 (WebKit::core):
8256 (webkit_dom_test_serialized_script_value_interface_finalize):
8257 (webkit_dom_test_serialized_script_value_interface_set_property):
8258 (webkit_dom_test_serialized_script_value_interface_get_property):
8259 (webkit_dom_test_serialized_script_value_interface_constructed):
8260 (webkit_dom_test_serialized_script_value_interface_class_init):
8261 (webkit_dom_test_serialized_script_value_interface_init):
8262 (WebKit::wrapTestSerializedScriptValueInterface):
8263 * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterf ace.h: Added.
8264 * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterf acePrivate.h: Added.
8265 * bindings/scripts/test/JS/JSTestInterface.cpp:
8266 (WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):
8267 (WebCore::JSTestInterface::JSTestInterface):
8268 * bindings/scripts/test/JS/JSTestInterface.h:
8269 * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
8270 (WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListL istenerConstructor):
8271 (WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
8272 (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
8273 * bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
8274 * bindings/scripts/test/JS/JSTestObj.cpp:
8275 (WebCore::JSTestObjConstructor::JSTestObjConstructor):
8276 (WebCore::JSTestObj::JSTestObj):
8277 (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
8278 (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
8279 (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
8280 (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
8281 (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
8282 (WebCore::jsTestObjPrototypeFunctionSerializedValue):
8283 (WebCore::jsTestObjPrototypeFunctionIdbKey):
8284 (WebCore::jsTestObjPrototypeFunctionOptionsObject):
8285 (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
8286 (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
8287 (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
8288 (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
8289 (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
8290 (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
8291 (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalA rg):
8292 (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOption alArgs):
8293 (WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackA rg):
8294 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
8295 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
8296 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
8297 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
8298 (WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):
8299 * bindings/scripts/test/JS/JSTestObj.h:
8300 * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Add ed.
8301 (WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructu re):
8302 (WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSeriali zedScriptValueInterfaceConstructor):
8303 (WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropert ySlot):
8304 (WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropert yDescriptor):
8305 (WebCore::JSTestSerializedScriptValueInterfacePrototype::self):
8306 (WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptVa lueInterface):
8307 (WebCore::JSTestSerializedScriptValueInterface::createPrototype):
8308 (WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):
8309 (WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor ):
8310 (WebCore::jsTestSerializedScriptValueInterfaceValue):
8311 (WebCore::jsTestSerializedScriptValueInterfaceConstructor):
8312 (WebCore::JSTestSerializedScriptValueInterface::getConstructor):
8313 (WebCore::toJS):
8314 (WebCore::toTestSerializedScriptValueInterface):
8315 * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: Copie d from Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h.
8316 (WebCore::JSTestSerializedScriptValueInterface::createStructure):
8317 (WebCore::JSTestSerializedScriptValueInterface::impl):
8318 (WebCore::JSTestSerializedScriptValueInterfacePrototype::createStructure ):
8319 (WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerialize dScriptValueInterfacePrototype):
8320 * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h: Ad ded.
8321 * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm: A dded.
8322 (-[DOMTestSerializedScriptValueInterface dealloc]):
8323 (-[DOMTestSerializedScriptValueInterface finalize]):
8324 (-[DOMTestSerializedScriptValueInterface value]):
8325 (core):
8326 (kit):
8327 * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterfaceIntern al.h: Added.
8328 * bindings/scripts/test/TestSerializedScriptValueInterface.idl: Added.
8329 * bindings/scripts/test/V8/V8TestInterface.cpp:
8330 (WebCore::ConfigureV8TestInterfaceTemplate):
8331 * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: Cop ied from Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp.
8332 (WebCore::TestSerializedScriptValueInterfaceInternal::V8_USE):
8333 (WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
8334 (WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
8335 (WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
8336 (WebCore::V8TestSerializedScriptValueInterface::HasInstance):
8337 (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
8338 (WebCore::V8TestSerializedScriptValueInterface::derefObject):
8339 * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Added .
8340 (WebCore::V8TestSerializedScriptValueInterface::toNative):
8341 (WebCore::V8TestSerializedScriptValueInterface::wrap):
8342 (WebCore::toV8):
8343
8344 2011-03-01 Oliver Hunt <oliver@apple.com>
8345
8346 Reviewed by Joseph Pecoraro.
8347
8348 Misaligned memory access in CloneDeserializer on all ARM arch.
8349 https://bugs.webkit.org/show_bug.cgi?id=48742
8350
8351 Push platforms that need aligned memory access down the
8352 endian independent serialization and deserialization
8353 paths.
8354
8355 * bindings/js/SerializedScriptValue.cpp:
8356
8357 2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
8358
8359 Reviewed by Kenneth Rohde Christiansen.
8360
8361 Viewport Warning/Error Messages Are Now Inaccurate
8362 https://bugs.webkit.org/show_bug.cgi?id=53707
8363
8364 Correct and improve the error messages for viewport
8365 parsing. Clarify the difference between incorrect
8366 keys, values, and when to use the device-width or
8367 device-height constants.
8368
8369 * dom/ViewportArguments.cpp:
8370 (WebCore::computeViewportAttributes): suggest using keywords if fixed in put matches device width or height.
8371 (WebCore::numericPrefix):
8372 (WebCore::findSizeValue): remove incorrect warnings about fixed numbers because we don't know the device width or height.
8373 (WebCore::setViewportFeature): report a warning for an unrecognized key.
8374 (WebCore::viewportErrorMessageTemplate): added template for unrecognized key.
8375 (WebCore::viewportErrorMessageLevel):
8376 * dom/ViewportArguments.h:
8377
8378 2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
8379
8380 Reviewed by Darin Adler.
8381
8382 WebKit does not merge text decorations in the typing style and the selec ted element properly
8383 https://bugs.webkit.org/show_bug.cgi?id=55349
8384
8385 The bug was caused by EditingStyle::mergeTypingStyle's not properly merg ing text decoration property.
8386 Fixed the bug by extracting a function from ApplyStyleCommand::pushDownI nlineStyleAroundNode and
8387 calling it in pushDownInlineStyleAroundNode and in mergeTypingStyle.
8388
8389 Test: editing/execCommand/merge-text-decoration-with-typing-style.html
8390
8391 * editing/ApplyStyleCommand.cpp:
8392 (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Takes EditingS tyle*;
8393 calls mergeInlineStyleOfElement.
8394 (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls apply InlineStyleToPushDown.
8395 (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto.
8396 * editing/ApplyStyleCommand.h:
8397 * editing/EditingStyle.cpp:
8398 (WebCore::EditingStyle::mergeTypingStyle): Added; calls mergeStyle.
8399 (WebCore::EditingStyle::mergeInlineStyleOfElement): Ditto.
8400 (WebCore::EditingStyle::mergeStyle): Extracted from applyInlineStyleToPu shDown.
8401 * editing/EditingStyle.h:
8402
8403 2011-03-01 Levi Weintraub <leviw@chromium.org>
8404
8405 Reviewed by Ryosuke Niwa.
8406
8407 Stop instantiating legacy editing Positions in VisiblePosition
8408 https://bugs.webkit.org/show_bug.cgi?id=52919
8409
8410 Changing VisiblePosition completely away from legacy positions.
8411
8412 No new tests since this is functionaly equivalent.
8413
8414 * WebCore.exp.in: Removing the legacy VisiblePosition constructor and
8415 adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePos itions
8416 outside of WebCore, they should be parent anchored.
8417 * accessibility/AXObjectCache.cpp:
8418 (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
8419 * accessibility/AccessibilityObject.cpp:
8420 (WebCore::startOfStyleRange):
8421 (WebCore::endOfStyleRange):
8422 * accessibility/AccessibilityRenderObject.cpp:
8423 (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
8424 * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
8425 (objectAndOffsetUnignored):
8426 * dom/Position.cpp:
8427 (WebCore::Position::document): Added this inline function to avoid the n ecessity
8428 of calling anchorNode to assure a document from a Position.
8429 (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfte rAnchor
8430 (WebCore::Position::downstream): ditto
8431 * dom/Range.cpp:
8432 (WebCore::Range::editingStartPosition):
8433 * editing/Editor.cpp:
8434 (WebCore::Editor::canDeleteRange):
8435 * editing/ReplaceSelectionCommand.cpp:
8436 (WebCore::ReplaceSelectionCommand::doApply):
8437 * editing/SelectionController.cpp:
8438 (WebCore::SelectionController::selectFrameElementInParentIfFullySelected ):
8439 (WebCore::SelectionController::setSelectedRange):
8440 * editing/TextIterator.cpp:
8441 (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
8442 * editing/TypingCommand.cpp:
8443 (WebCore::TypingCommand::deleteKeyPressed):
8444 * editing/VisiblePosition.cpp:
8445 (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
8446 (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
8447 (WebCore::VisiblePosition::canonicalPosition):
8448 (WebCore::VisiblePosition::characterAfter):
8449 (WebCore::VisiblePosition::localCaretRect):
8450 (WebCore::makeRange):
8451 (WebCore::startVisiblePosition):
8452 (WebCore::endVisiblePosition):
8453 (WebCore::setStart):
8454 (WebCore::setEnd):
8455 (WebCore::isFirstVisiblePositionInNode):
8456 (WebCore::isLastVisiblePositionInNode):
8457 * editing/VisiblePosition.h:
8458 (WebCore::VisiblePosition::VisiblePosition):
8459 * editing/htmlediting.cpp:
8460 (WebCore::firstInSpecialElement):
8461 (WebCore::lastInSpecialElement):
8462 (WebCore::visiblePositionBeforeNode):
8463 (WebCore::visiblePositionAfterNode):
8464 * editing/visible_units.cpp:
8465 (WebCore::startPositionForLine):
8466 (WebCore::endPositionForLine):
8467 (WebCore::previousLinePosition):
8468 (WebCore::nextLinePosition):
8469 (WebCore::startOfParagraph):
8470 (WebCore::endOfParagraph):
8471 (WebCore::endOfBlock):
8472 (WebCore::startOfDocument):
8473 (WebCore::endOfDocument):
8474 (WebCore::logicalStartPositionForLine):
8475 (WebCore::logicalEndPositionForLine):
8476 * page/DOMSelection.cpp:
8477 (WebCore::DOMSelection::collapse):
8478 (WebCore::DOMSelection::setBaseAndExtent):
8479 (WebCore::DOMSelection::setPosition):
8480 (WebCore::DOMSelection::extend):
8481 * page/EventHandler.cpp:
8482 (WebCore::EventHandler::handleMousePressEventSingleClick):
8483 * rendering/RenderObject.cpp:
8484 (WebCore::RenderObject::createVisiblePosition):
8485 * rendering/RenderTextControl.cpp:
8486 (WebCore::RenderTextControl::visiblePositionForIndex):
8487 * svg/SVGTextContentElement.cpp:
8488 (WebCore::SVGTextContentElement::selectSubString):
8489
8490 2011-03-01 Jeremy Orlow <jorlow@chromium.org>
8491
8492 Reviewed by Steve Block.
8493
8494 When an IDBTransaction is aborted, all requests that have not yet fired s hould fire an ABORT_ERR
8495 https://bugs.webkit.org/show_bug.cgi?id=54785
8496
8497 This patch adds in a lot of sanity checks/ASSERTs to make sure we're doin g
8498 the right thing and continue to do the right thing. It also modifies Even tQueue
8499 so that we can cancel an event. To do this efficiently, the vector is now a
8500 ListHashSet.
8501
8502 Cancelling the event is harder/messier, but the most deterministic thing to do.
8503 To the user, the work isn't done until we fire the onsuccess/onerror hand ler.
8504 So the event (which does fire that) needs to be cancelable.
8505
8506 transaction-abort.html tests this.
8507
8508 * dom/EventQueue.cpp:
8509 (WebCore::EventQueue::enqueueEvent):
8510 (WebCore::EventQueue::cancelEvent):
8511 (WebCore::EventQueue::pendingEventTimerFired):
8512 (WebCore::EventQueue::dispatchEvent):
8513 * dom/EventQueue.h:
8514 * dom/ExceptionCode.cpp:
8515 * storage/IDBCursor.cpp:
8516 (WebCore::IDBCursor::update):
8517 (WebCore::IDBCursor::deleteFunction):
8518 * storage/IDBDatabaseBackendImpl.cpp:
8519 (WebCore::IDBDatabaseBackendImpl::close):
8520 * storage/IDBDatabaseException.h:
8521 * storage/IDBIndex.cpp:
8522 (WebCore::IDBIndex::openCursor):
8523 (WebCore::IDBIndex::openKeyCursor):
8524 (WebCore::IDBIndex::get):
8525 (WebCore::IDBIndex::getKey):
8526 * storage/IDBObjectStore.cpp:
8527 (WebCore::IDBObjectStore::get):
8528 (WebCore::IDBObjectStore::add):
8529 (WebCore::IDBObjectStore::put):
8530 (WebCore::IDBObjectStore::deleteFunction):
8531 (WebCore::IDBObjectStore::clear):
8532 (WebCore::IDBObjectStore::openCursor):
8533 * storage/IDBRequest.cpp:
8534 (WebCore::IDBRequest::IDBRequest):
8535 (WebCore::IDBRequest::~IDBRequest):
8536 (WebCore::IDBRequest::readyState):
8537 (WebCore::IDBRequest::markEarlyDeath):
8538 (WebCore::IDBRequest::source):
8539 (WebCore::IDBRequest::abort):
8540 (WebCore::IDBRequest::onSuccess):
8541 (WebCore::IDBRequest::dispatchEvent):
8542 (WebCore::IDBRequest::enqueueEvent):
8543 * storage/IDBRequest.h:
8544 * storage/IDBTransaction.cpp:
8545 (WebCore::IDBTransaction::registerRequest):
8546 (WebCore::IDBTransaction::unregisterRequest):
8547 (WebCore::IDBTransaction::onAbort):
8548 * storage/IDBTransaction.h:
8549
8550 2011-03-01 Jeremy Orlow <jorlow@chromium.org>
8551
8552 Reviewed by Mihai Parparita.
8553
8554 EventQueue needs to be ref counted
8555 https://bugs.webkit.org/show_bug.cgi?id=55512
8556
8557 EventQueue needs to be ref counted because it's possible for its instanc e
8558 to be deleted while it's dispatching events. This is the reason why
8559 https://bugs.webkit.org/show_bug.cgi?id=54785 had to be reverted.
8560
8561 No change of behavior, so no tests.
8562
8563 * dom/Document.h:
8564 * dom/EventQueue.cpp:
8565 (WebCore::EventQueue::create):
8566 * dom/EventQueue.h:
8567
8568 2011-03-01 Helder Correia <helder@sencha.com>
8569
8570 Reviewed by Simon Fraser.
8571
8572 No shadow when stroking a path with a gradient
8573 https://bugs.webkit.org/show_bug.cgi?id=55436
8574
8575 This happens in CG and is related to bug 52509, this time to be fixed
8576 in GraphicsContext::strokePath(). The gradient needs to be drawn
8577 clipped to the stroke on a CGLayer first, then the layer drawn on the
8578 GraphicsContext.
8579
8580 Tests: fast/canvas/canvas-strokePath-gradient-shadow.html
8581 svg/css/path-gradient-stroke-shadow.svg
8582
8583 * platform/graphics/cg/GraphicsContextCG.cpp:
8584 (WebCore::GraphicsContext::strokePath):
8585
8586 2011-03-01 David Hyatt <hyatt@apple.com>
8587
8588 Reviewed by Dan Bernstein.
8589
8590 Fix Font::spaceWidth() to be a float instead of an int.
8591
8592 * platform/graphics/Font.h:
8593 (WebCore::Font::spaceWidth):
8594
8595 2011-02-28 Steve Block <steveblock@google.com>
8596
8597 Reviewed by Jeremy Orlow.
8598
8599 Chromium gypi file should include Java bridge files from WebCore/bridge
8600 https://bugs.webkit.org/show_bug.cgi?id=55387
8601
8602 No new tests, no code changes.
8603
8604 * WebCore.gyp/WebCore.gyp:
8605 * WebCore.gypi:
8606
8607 2011-03-01 James Simonsen <simonjam@chromium.org>
8608
8609 Reviewed by Tony Gentilcore.
8610
8611 [Web Timing] Handle the case where no responseEnd time is available.
8612 https://bugs.webkit.org/show_bug.cgi?id=55444
8613
8614 * loader/MainResourceLoader.cpp:
8615 (WebCore::MainResourceLoader::MainResourceLoader): Initialize to 0.
8616 (WebCore::MainResourceLoader::didFinishLoading): Fall back to current ti me if no other time is available.
8617
8618 2011-03-01 Patrick Gansterer <paroga@webkit.org>
8619
8620 Unreviewed, adding missing change for r80034.
8621
8622 Add a handler class for Win32 HANDLE
8623 https://bugs.webkit.org/show_bug.cgi?id=55334
8624
8625 * platform/win/Win32Handle.h: Added missing WTF_MAKE_NONCOPYABLE macro.
8626
8627 2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
8628
8629 Unreviewed, rolling out r80037.
8630 http://trac.webkit.org/changeset/80037
8631 https://bugs.webkit.org/show_bug.cgi?id=55508
8632
8633 broke compile on SL (Requested by tonyg-cr on #webkit).
8634
8635 * Android.mk:
8636 * CMakeLists.txt:
8637 * GNUmakefile.am:
8638 * WebCore.gypi:
8639 * WebCore.pro:
8640 * WebCore.vcproj/WebCore.vcproj:
8641 * WebCore.xcodeproj/project.pbxproj:
8642 * css/CSSParser.cpp:
8643 (WebCore::CSSParser::parseValue):
8644 * css/CSSParser.h:
8645 * css/CSSStyleSelector.cpp:
8646 (WebCore::CSSStyleSelector::applyProperty):
8647 * css/html.css:
8648 (q:before):
8649 (q:after):
8650 * rendering/RenderBlockLineLayout.cpp:
8651 (WebCore::dirtyLineBoxesForRenderer):
8652 * rendering/RenderObject.h:
8653 * rendering/RenderObjectChildList.cpp:
8654 (WebCore::RenderObjectChildList::removeChildNode):
8655 (WebCore::RenderObjectChildList::appendChildNode):
8656 (WebCore::RenderObjectChildList::insertChildNode):
8657 (WebCore::RenderObjectChildList::updateBeforeAfterContent):
8658 * rendering/RenderQuote.cpp: Removed.
8659 * rendering/RenderQuote.h: Removed.
8660 * rendering/RenderingAllInOne.cpp:
8661 * rendering/style/ContentData.cpp:
8662 (WebCore::ContentData::dataEquivalent):
8663 (WebCore::ContentData::deleteContent):
8664 * rendering/style/ContentData.h:
8665 * rendering/style/QuotesData.cpp: Removed.
8666 * rendering/style/QuotesData.h: Removed.
8667 * rendering/style/RenderStyle.cpp:
8668 * rendering/style/RenderStyle.h:
8669 * rendering/style/RenderStyleConstants.h:
8670 * rendering/style/StyleAllInOne.cpp:
8671 * rendering/style/StyleRareInheritedData.cpp:
8672 (WebCore::StyleRareInheritedData::operator==):
8673 * rendering/style/StyleRareInheritedData.h:
8674
8675 2011-03-01 Abhishek Arya <inferno@chromium.org>
8676
8677 Reviewed by Dave Hyatt.
8678
8679 Paint outline for tables.
8680 https://bugs.webkit.org/show_bug.cgi?id=55474
8681
8682 Test: fast/table/table-and-parts-outline.html
8683
8684 * rendering/RenderTable.cpp:
8685 (WebCore::RenderTable::paintObject):
8686
8687 2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
8688
8689 Unreviewed, rolling out r80028.
8690 http://trac.webkit.org/changeset/80028
8691 https://bugs.webkit.org/show_bug.cgi?id=55502
8692
8693 'caused crashes; rolling out while investigating' (Requested
8694 by jorlow on #webkit).
8695
8696 * dom/EventQueue.cpp:
8697 (WebCore::EventQueue::enqueueEvent):
8698 (WebCore::EventQueue::pendingEventTimerFired):
8699 (WebCore::EventQueue::dispatchEvent):
8700 * dom/EventQueue.h:
8701 * dom/ExceptionCode.cpp:
8702 * storage/IDBCursor.cpp:
8703 (WebCore::IDBCursor::update):
8704 (WebCore::IDBCursor::deleteFunction):
8705 * storage/IDBDatabaseException.h:
8706 * storage/IDBDatabaseException.idl:
8707 * storage/IDBIndex.cpp:
8708 (WebCore::IDBIndex::openCursor):
8709 (WebCore::IDBIndex::openKeyCursor):
8710 (WebCore::IDBIndex::get):
8711 (WebCore::IDBIndex::getKey):
8712 * storage/IDBObjectStore.cpp:
8713 (WebCore::IDBObjectStore::get):
8714 (WebCore::IDBObjectStore::add):
8715 (WebCore::IDBObjectStore::put):
8716 (WebCore::IDBObjectStore::deleteFunction):
8717 (WebCore::IDBObjectStore::clear):
8718 (WebCore::IDBObjectStore::openCursor):
8719 * storage/IDBRequest.cpp:
8720 (WebCore::IDBRequest::IDBRequest):
8721 (WebCore::IDBRequest::~IDBRequest):
8722 (WebCore::IDBRequest::readyState):
8723 (WebCore::IDBRequest::dispatchEvent):
8724 (WebCore::IDBRequest::enqueueEvent):
8725 (WebCore::IDBRequest::source):
8726 * storage/IDBRequest.h:
8727 * storage/IDBTransaction.cpp:
8728 (WebCore::IDBTransaction::onAbort):
8729 * storage/IDBTransaction.h:
8730
8731 2011-03-01 Carol Szabo <carol.szabo@nokia.com>
8732
8733 Reviewed by David Hyatt <hyatt@apple.com>
8734
8735 content property doesn't support quotes
8736 https://bugs.webkit.org/show_bug.cgi?id=6503
8737
8738 Added full support for quotes as defined by CSS 2.1.
8739
8740 Tests: fast/css/content/content-quotes-01.html
8741 fast/css/content/content-quotes-02.html
8742 fast/css/content/content-quotes-03.html
8743 fast/css/content/content-quotes-04.html
8744 fast/css/content/content-quotes-05.html
8745
8746 * Android.mk:
8747 * CMakeLists.txt:
8748 * GNUmakefile.am:
8749 * WebCore.pro:
8750 * WebCore.vcproj/WebCore.vcproj:
8751 * WebCore.xcodeproj/project.pbxproj:
8752 Added RenderQuote.cpp/h and QuotesData.cpp/h to the dependency lists
8753 * css/CSSParser.cpp:
8754 (WebCore::CSSParser::parseValue):
8755 (WebCore::CSSParser::parseQuotes):
8756 * css/CSSParser.h:
8757 Added needed stylesheet parsing support for quotes,
8758 (no-)open-quote and (no-)close-quote
8759 * css/CSSStyleSelector.cpp:
8760 (WebCore::CSSStyleSelector::applyProperty):
8761 Handled setting of the new quotes RenderStyle property and added
8762 handling of quotes for the content property.
8763 * css/html.css:
8764 (q:before):
8765 (q:after):
8766 replaced the '"' workaround with open/close-quote
8767 * rendering/RenderBlockLineLayout.cpp:
8768 (WebCore::dirtyLineBoxesForRenderer):
8769 Made RenderQuote behave like RenderCounter.
8770 Needed to ensure that the Quote text is calculated before layout,
8771 just as it is for RenderCounter.
8772 * rendering/RenderObject.h:
8773 (WebCore::RenderObject::isQuote):
8774 * rendering/RenderObjectChildList.cpp:
8775 (WebCore::RenderObjectChildList::removeChildNode):
8776 (WebCore::RenderObjectChildList::appendChildNode):
8777 (WebCore::RenderObjectChildList::insertChildNode):
8778 Handled updating of quote depth when renderers are added and removed
8779 from the tree.
8780 (WebCore::RenderObjectChildList::updateBeforeAfterContent):
8781 * rendering/RenderQuote.cpp: Added.
8782 (WebCore::adjustDepth):
8783 (WebCore::RenderQuote::RenderQuote):
8784 (WebCore::RenderQuote::~RenderQuote):
8785 (WebCore::RenderQuote::renderName):
8786 (WebCore::RenderQuote::placeQuote):
8787 (WebCore::RenderQuote::originalText):
8788 (WebCore::RenderQuote::computePreferredLogicalWidths):
8789 (WebCore::RenderQuote::rendererSubtreeAttached):
8790 (WebCore::RenderQuote::rendererRemovedFromTree):
8791 (WebCore::RenderQuote::styleDidChange):
8792 * rendering/RenderQuote.h: Added.
8793 (WebCore::RenderQuote::isQuote):
8794 (WebCore::toRenderQuote):
8795 * rendering/RenderingAllInOne.cpp:
8796 Included RenderQuote.cpp
8797 * rendering/style/StyleAllInOne.cpp:
8798 Included QuotesData.cpp
8799 * rendering/style/ContentData.cpp:
8800 (WebCore::ContentData::dataEquivalent):
8801 Checked for quotetype identity.
8802 (WebCore::ContentData::deleteContent):
8803 Accounted for the new QUOTE_TYPE.
8804 * rendering/style/ContentData.h:
8805 (WebCore::ContentData::isQuote):
8806 (WebCore::ContentData::quote):
8807 (WebCore::ContentData::setQuote):
8808 * rendering/style/RenderStyle.cpp:
8809 (WebCore::RenderStyle::setContent):
8810 * rendering/style/RenderStyle.h:
8811 (WebCore::InheritedFlags::quotes):
8812 (WebCore::InheritedFlags::setQuotes):
8813 * rendering/style/RenderStyleConstants.h:
8814 * rendering/style/StyleRareInheritedData.cpp:
8815 (WebCore::StyleRareInheritedData::operator==):
8816 Included quotes in equality check.
8817 * rendering/style/StyleRareInheritedData.h:
8818 Added quotes
8819
8820 2011-03-01 Michael Nordman <michaeln@google.com>
8821
8822 Reviewed by Alexey Proskuryakov.
8823
8824 Alter the relative priorities of network vs fallback namespaces in the a ppcache.
8825 If a resource url is in an appcache's network namespace and fallback nam espace, the network
8826 namespace wins (with the exception of the special '*' network namespace which does not take
8827 priority over the fallback namespace.
8828 https://bugs.webkit.org/show_bug.cgi?id=49292
8829
8830 Test: http/tests/appcache/online-fallback-layering.html
8831
8832 * loader/appcache/ApplicationCache.cpp:
8833 (WebCore::ApplicationCache::isURLInOnlineWhitelist):
8834 * loader/appcache/ApplicationCacheHost.cpp:
8835 (WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache):
8836 (WebCore::ApplicationCacheHost::getApplicationCacheFallbackResource):
8837 * loader/appcache/ApplicationCacheStorage.cpp:
8838 (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
8839
8840 2011-03-01 Patrick Gansterer <paroga@webkit.org>
8841
8842 Reviewed by Adam Roben.
8843
8844 Add a handler class for Win32 HANDLE
8845 https://bugs.webkit.org/show_bug.cgi?id=55334
8846
8847 This class will call CloseHandle in the destructor for valid handles.
8848
8849 * platform/win/Win32Handle.h: Added.
8850
8851 2011-03-01 Eric Carlson <eric.carlson@apple.com>
8852
8853 Reviewed by Chris Marrin.
8854
8855 <audio> and <video> should respect private browsing mode
8856 https://bugs.webkit.org/show_bug.cgi?id=55287
8857 <rdar://problem/9057699>
8858
8859 No new tests, this is just the plumbing.
8860
8861 * dom/Document.cpp:
8862 (WebCore::Document::privateBrowsingStateDidChange): New.
8863 (WebCore::Document::registerForPrivateBrowsingStateChangedCallbacks): Di tto.
8864 (WebCore::Document::unregisterForPrivateBrowsingStateChangedCallbacks): Ditto.
8865 * dom/Document.h:
8866
8867 * dom/Element.h:
8868 (WebCore::Element::privateBrowsingStateDidChange): New.
8869
8870 * html/HTMLMediaElement.cpp:
8871 (WebCore::HTMLMediaElement::HTMLMediaElement): Register for privacy mode changes.
8872 (WebCore::HTMLMediaElement::~HTMLMediaElement): Unregister for privacy m ode changes.
8873 (WebCore::HTMLMediaElement::loadResource): Tell player current privacy m ode.
8874 (WebCore::HTMLMediaElement::privateBrowsingStateDidChange): New, call t hrough to MediaPlayer.
8875 * html/HTMLMediaElement.h:
8876
8877 * page/Page.cpp:
8878 (WebCore::Page::privateBrowsingStateChanged): Call document()->privateBr owsingStateDidChange.
8879
8880 * platform/graphics/MediaPlayer.cpp:
8881 (WebCore::MediaPlayer::setPrivateBrowsingMode): New, call through to med ia engine.
8882 * platform/graphics/MediaPlayer.h:
8883
8884 * platform/graphics/MediaPlayerPrivate.h:
8885 (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode): Declare new interface.
8886
8887 2011-03-01 Jeremy Orlow <jorlow@chromium.org>
8888
8889 Reviewed by Steve Block.
8890
8891 When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
8892 https://bugs.webkit.org/show_bug.cgi?id=54785
8893
8894 This patch adds in a lot of sanity checks/ASSERTs to make sure we're doi ng
8895 the right thing and continue to do the right thing. It also modifies Eve ntQueue
8896 so that we can cancel an event. To do this efficiently, the vector is no w a
8897 ListHashSet.
8898
8899 Canelling the event is harder/messier, but the most deterministic thing to do.
8900 To the user, the work isn't done until we fire the onsuccess/onerror han dler.
8901 So the event (which does fire that) needs to be cancelable.
8902
8903 transaction-abort.html tests this.
8904
8905 * dom/EventQueue.cpp:
8906 (WebCore::EventQueue::enqueueEvent):
8907 (WebCore::EventQueue::cancelEvent):
8908 (WebCore::EventQueue::pendingEventTimerFired):
8909 (WebCore::EventQueue::dispatchEvent):
8910 * dom/EventQueue.h:
8911 * dom/ExceptionCode.cpp:
8912 * storage/IDBCursor.cpp:
8913 (WebCore::IDBCursor::update):
8914 (WebCore::IDBCursor::deleteFunction):
8915 * storage/IDBDatabaseBackendImpl.cpp:
8916 (WebCore::IDBDatabaseBackendImpl::close):
8917 * storage/IDBDatabaseException.h:
8918 * storage/IDBIndex.cpp:
8919 (WebCore::IDBIndex::openCursor):
8920 (WebCore::IDBIndex::openKeyCursor):
8921 (WebCore::IDBIndex::get):
8922 (WebCore::IDBIndex::getKey):
8923 * storage/IDBObjectStore.cpp:
8924 (WebCore::IDBObjectStore::get):
8925 (WebCore::IDBObjectStore::add):
8926 (WebCore::IDBObjectStore::put):
8927 (WebCore::IDBObjectStore::deleteFunction):
8928 (WebCore::IDBObjectStore::clear):
8929 (WebCore::IDBObjectStore::openCursor):
8930 * storage/IDBRequest.cpp:
8931 (WebCore::IDBRequest::IDBRequest):
8932 (WebCore::IDBRequest::~IDBRequest):
8933 (WebCore::IDBRequest::readyState):
8934 (WebCore::IDBRequest::markEarlyDeath):
8935 (WebCore::IDBRequest::source):
8936 (WebCore::IDBRequest::abort):
8937 (WebCore::IDBRequest::onSuccess):
8938 (WebCore::IDBRequest::dispatchEvent):
8939 (WebCore::IDBRequest::enqueueEvent):
8940 * storage/IDBRequest.h:
8941 * storage/IDBTransaction.cpp:
8942 (WebCore::IDBTransaction::registerRequest):
8943 (WebCore::IDBTransaction::unregisterRequest):
8944 (WebCore::IDBTransaction::onAbort):
8945 * storage/IDBTransaction.h:
8946
8947 2011-03-01 Jeremy Orlow <jorlow@chromium.org>
8948
8949 Reviewed by Steve Block.
8950
8951 Only IndexedDB's error event should be cancelable
8952 https://bugs.webkit.org/show_bug.cgi?id=55413
8953
8954 * storage/IDBRequest.cpp:
8955 (WebCore::createSuccessEvent):
8956 * storage/IDBTransaction.cpp:
8957 (WebCore::IDBTransaction::onAbort):
8958 (WebCore::IDBTransaction::onComplete):
8959
8960 2011-03-01 Jia Pu <jpu@apple.com>
8961
8962 Reviewed by Darin Adler.
8963
8964 Remove CorrectionIndicator markers sooner.
8965 https://bugs.webkit.org/show_bug.cgi?id=54893
8966 <rdar://problem/8997524>
8967
8968 Test: platform/mac/editing/spelling/removing-underline-after-accepting-a utocorrection-using-punctuation.html
8969
8970 This patch changes the autocorrection behavior on Mac OS X. We want to r emove CorrectionIndicator
8971 marker after any editing command if the command:
8972 1. is not a SpellingCorrectionCommand itself.
8973 2. is not the command that triggers the autocorrection.
8974 This is achieved by adding shouldRetainAutocorrectionIndicator() functio n to EditCommand. This function returns
8975 false for all commands derived from EditCommand, except SpellingCorrecti onCommand and TypingCommand. This function
8976 always returns true for SpellingCorrectionCommand. For TypingCommand, th e return value is determined by member
8977 variable m_shouldRetainAutocorrectionIndicator, which can be modified by passing option into the TypingCommand's
8978 public functions.
8979
8980 To avoid constantly searching marker list, we use variable DocumentMarke rController::m_absentMarkerTypeCache
8981 to cache whether there is any marker of a particular type.
8982
8983 This patch also fixes two minor existing bugs.
8984
8985 1. We used to show reversion panel for word with CorrectionIndicator mar ker. This is incorrect because
8986 CorrectionIndicator marker can be removed from corrected words. Since al l autocorrected words have Replacement
8987 marker unless the whole word is deleted, the correct behavior is to show reversion panel for word with Replacement
8988 marker, since all autocorrected words have such marker. However, since w e don't want to show the reversion panel
8989 if an autocorrected word has been edited, we also check to see if the Re placement marker's description is null.
8990
8991 This works as following:
8992 When we apply an autocorrection, we add Replacement marker to corrected word, and store original word
8993 as the marker's description. If the user edited the corrected word after ward, we set description to null.
8994 So when we decide whether to show a reversion panel, we not only check f or the existence of Replacement
8995 marker, but also check if description is null.
8996
8997 2. Fixed an assertion violation in Editor::removeSpellAndCorrectionMarke rsFromWordsToBeEdited(), which would
8998 occur when deleting the first character in an editable area.
8999
9000 * dom/DocumentMarker.h: Added m_possiblyExistingMarkerTypes to allow qui ckly checking whether a marker type is
9001 completely in from the document.
9002
9003 * dom/DocumentMarkerController.cpp: Most of the functions listed here ar e optimized for early return by checking
9004 the return value of possiblyHasMarkers() at beginning.
9005 (WebCore::DocumentMarkerController::possiblyHasMarkers):
9006 (WebCore::DocumentMarkerController::DocumentMarkerController):
9007 (WebCore::DocumentMarkerController::detach):
9008 (WebCore::DocumentMarkerController::removeMarkers):
9009 (WebCore::DocumentMarkerController::addMarker):
9010 (WebCore::DocumentMarkerController::copyMarkers):
9011 (WebCore::DocumentMarkerController::markerContainingPoint):
9012 (WebCore::DocumentMarkerController::renderedRectsForMarkers):
9013 (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair ):
9014 (WebCore::DocumentMarkerController::repaintMarkers):
9015 (WebCore::DocumentMarkerController::shiftMarkers):
9016 (WebCore::DocumentMarkerController::setMarkersActive):
9017 (WebCore::DocumentMarkerController::hasMarkers):
9018 (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectin gRange):
9019 * dom/DocumentMarkerController.h:
9020 * editing/EditCommand.cpp:
9021 (WebCore::EditCommand::apply):
9022 (WebCore::EditCommand::shouldRetainAutocorrectionIndicator):
9023 (WebCore::EditCommand::setShouldRetainAutocorrectionIndicator):
9024 * editing/EditCommand.h:
9025 * editing/Editor.cpp:
9026 (WebCore::Editor::respondToChangedSelection):
9027 (WebCore::Editor::appliedEditing):
9028 (WebCore::Editor::insertTextWithoutSendingTextEvent):
9029 (WebCore::Editor::insertLineBreak):
9030 (WebCore::Editor::insertParagraphSeparator):
9031 (WebCore::Editor::markMisspellingsAfterTypingToWord):
9032 (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
9033 (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
9034 (WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate):
9035 * editing/Editor.h:
9036 * editing/EditorCommand.cpp:
9037 (WebCore::executeInsertLineBreak):
9038 (WebCore::executeInsertParagraph):
9039 (WebCore::executeInsertText):
9040 * editing/SpellingCorrectionCommand.cpp:
9041 (WebCore::SpellingCorrectionCommand::shouldRetainAutocorrectionIndicator ):
9042 * editing/SpellingCorrectionCommand.h:
9043 * editing/TypingCommand.cpp:
9044 (WebCore::TypingCommand::TypingCommand):
9045 (WebCore::TypingCommand::deleteSelection):
9046 (WebCore::TypingCommand::deleteKeyPressed):
9047 (WebCore::TypingCommand::forwardDeleteKeyPressed):
9048 (WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection) :
9049 (WebCore::TypingCommand::insertText):
9050 (WebCore::TypingCommand::insertLineBreak):
9051 (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
9052 (WebCore::TypingCommand::insertParagraphSeparator):
9053 * editing/TypingCommand.h:
9054 (WebCore::TypingCommand::create):
9055 (WebCore::TypingCommand::shouldRetainAutocorrectionIndicator):
9056 (WebCore::TypingCommand::setShouldRetainAutocorrectionIndicator):
9057 * manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html:
9058
9059 2011-03-01 Renata Hodovan <reni@webkit.org>
9060
9061 Reviewed by Andreas Kling.
9062
9063 FEDisplacementMapElement changes doesn't require relayout
9064 https://bugs.webkit.org/show_bug.cgi?id=55454
9065
9066 When the FEDisplacementMapElement receives an update message but the giv en value remains the same we don't need
9067 to relayout the filter.
9068
9069 No new tests are needed because this modification is covered by the dyna mic update tests of FEDisplacementMap.
9070
9071 * platform/graphics/filters/FEDisplacementMap.cpp:
9072 (WebCore::FEDisplacementMap::setXChannelSelector):
9073 (WebCore::FEDisplacementMap::setYChannelSelector):
9074 (WebCore::FEDisplacementMap::setScale):
9075 * platform/graphics/filters/FEDisplacementMap.h:
9076 * svg/SVGFEDisplacementMapElement.cpp:
9077 (WebCore::SVGFEDisplacementMapElement::setFilterEffectAttribute):
9078 (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):
9079 * svg/SVGFEDisplacementMapElement.h:
9080
9081 2011-03-01 Dan Bernstein <mitz@apple.com>
9082
9083 Reviewed by Darin Adler.
9084
9085 <rdar://problem/8902714> Expand ruby text when it is shorter than the ru by base
9086 https://bugs.webkit.org/show_bug.cgi?id=55487
9087
9088 * css/html.css:
9089 (ruby > rt): Changed the default text-align value to -webkit-auto to sig nal
9090 the default expansion behavior.
9091 * rendering/RenderBlock.h:
9092 (WebCore::RenderRubyText::textAlignmentForLine): Made protected.
9093 (WebCore::RenderBlock::adjustInlineDirectionLineBounds): Made protected.
9094 * rendering/RenderRubyText.cpp:
9095 (WebCore::RenderRubyText::textAlignmentForLine): Added. If text-align is
9096 -webkit-auto, returns JUSTIFY to allow expansion.
9097 (WebCore::RenderRubyText::adjustInlineDirectionLineBounds): Added. If
9098 text-align is -webkit-auto, insets the line such that the inset on each side
9099 is the half the inter-ideograph expansion, or one ruby character wide,
9100 whichever is smaller.
9101 * rendering/RenderRubyText.h:
9102
9103 2011-03-01 Sam Weinig <sam@webkit.org>
9104
9105 Reviewed by Timothy Hatcher.
9106
9107 WebKit2 needs to be made localizable
9108 https://bugs.webkit.org/show_bug.cgi?id=55483
9109
9110 * English.lproj/Localizable.strings: Copied from Source/WebKit/English.l proj/Localizable.strings.
9111 * WebCore.xcodeproj/project.pbxproj:
9112 Move Localizable.strings to WebCore.
9113
9114 * WebCore.exp.in:
9115 Add export for localizedString function.
9116
9117 * platform/LocalizedStrings.h:
9118 * platform/mac/LocalizedStringsMac.mm: Added.
9119 Add function to get localized version of a string from the WebCore bundl e.
9120
9121 2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
9122
9123 Reviewed by Timothy Hatcher.
9124
9125 All Console Messages should be passed to ChromeClients.
9126 https://bugs.webkit.org/show_bug.cgi?id=54926
9127
9128 Do not filter the message type here, allow clients
9129 to filter and deal with the different message types.
9130
9131 * page/Console.cpp:
9132 (WebCore::Console::addMessage):
9133
9134 2011-02-23 Joseph Pecoraro <joepeck@webkit.org>
9135
9136 Reviewed by Kenneth Rohde Christiansen.
9137
9138 Viewport parsing no longer accepts "1.0;" value as valid.
9139 https://bugs.webkit.org/show_bug.cgi?id=53705
9140
9141 When parsing numeric values, the "css-viewport" spec says
9142 to use the number prefix, and the non numeric part of the
9143 string can be ignored. This matches our behavior before
9144 r67376. The change was that checking the error out condition
9145 of String::toFloat doesn't necessarily mean that there
9146 was a non-numeric prefix. This patch checks if there was
9147 or wasn't a non-numeric prefix.
9148
9149 There is a console warning in any case where a numeric
9150 value is not parsed cleanly. There is an error warning
9151 when it is not a number at all, and a tip warning when
9152 it has been truncated.
9153
9154 Error messages are slightly improved to provide more
9155 context, both the key and value, when an error happens.
9156
9157 Test: fast/viewport/viewport-129.html
9158
9159 * dom/ViewportArguments.cpp:
9160 (WebCore::numericPrefix):
9161 (WebCore::findSizeValue):
9162 (WebCore::findScaleValue):
9163 (WebCore::findUserScalableValue):
9164 (WebCore::findTargetDensityDPIValue):
9165 (WebCore::viewportErrorMessageTemplate):
9166 (WebCore::viewportErrorMessageLevel):
9167 (WebCore::reportViewportWarning):
9168 * dom/ViewportArguments.h:
9169
9170 2011-03-01 Ilya Tikhonovsky <loislo@chromium.org>
9171
9172 Reviewed by Pavel Feldman.
9173
9174 Web Inspector: InjectedScript.setPropertyValue doesn't work.
9175 https://bugs.webkit.org/show_bug.cgi?id=55475
9176
9177 * inspector/InjectedScript.cpp:
9178 (WebCore::InjectedScript::setPropertyValue):
9179
9180 2011-03-01 Steve Block <steveblock@google.com>
9181
9182 Reviewed by Jeremy Orlow.
9183
9184 Remove unused JavaString::uchars()
9185 https://bugs.webkit.org/show_bug.cgi?id=55465
9186
9187 No new tests, removing dead code only.
9188
9189 * bridge/jni/JNIBridge.h:
9190 * bridge/jni/jsc/JavaStringJSC.h:
9191 (JSC::Bindings::JavaStringImpl::utf8):
9192 * bridge/jni/v8/JavaStringV8.h:
9193
9194 2011-03-01 Alexander Pavlov <apavlov@chromium.org>
9195
9196 Reviewed by Yury Semikhatsky.
9197
9198 Web Inspector: Extremely slow DOM search in GMail
9199 https://bugs.webkit.org/show_bug.cgi?id=55456
9200
9201 The solution comprises three major parts:
9202 - avoid multiple invocations of highlightSearchResults(), one per each n odeIds chunk.
9203 - cache highlighted node's innerHTML so that no extra _nodeTitleInfo() c alls will be needed.
9204 - replace hand-written Text nodes iteration with a snapshot-based ".//te xt()" XPathResult.
9205
9206 * inspector/front-end/ElementsPanel.js:
9207 (WebInspector.ElementsPanel.prototype.searchCanceled):
9208 (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
9209 * inspector/front-end/ElementsTreeOutline.js:
9210 (WebInspector.ElementsTreeElement.prototype.highlightSearchResults):
9211 (WebInspector.ElementsTreeElement.prototype.updateTitle):
9212 ():
9213 * inspector/front-end/utilities.js:
9214 ():
9215
9216 2011-03-01 Adam Roben <aroben@apple.com>
9217
9218 Fix multiple-definition linker warnings introduced by r79978 on Windows
9219
9220 * rendering/RenderingAllInOne.cpp: Removed TextControlInnerElements.cpp, as it is now being
9221 compiled separately.
9222
9223 2011-03-01 Andras Becsi <abecsi@webkit.org>
9224
9225 Reviewed by Csaba Osztrogonác.
9226
9227 [Qt] Clean up the project files and move common options to WebKit.pri.
9228
9229 No new tests needed.
9230
9231 * WebCore.pri: Move common options to WebKit.pri.
9232 * WebCore.pro: Ditto.
9233
9234 2011-03-01 Steve Block <steveblock@google.com>
9235
9236 Reviewed by Pavel Feldman.
9237
9238 JNI code in Java bridge is not correctly guarded
9239 https://bugs.webkit.org/show_bug.cgi?id=55459
9240
9241 No new tests, build fix only.
9242
9243 * bridge/jni/v8/JNIBridgeV8.cpp:
9244 * bridge/jni/v8/JNIBridgeV8.h:
9245 * bridge/jni/v8/JNIUtilityPrivate.cpp:
9246 * bridge/jni/v8/JNIUtilityPrivate.h:
9247 * bridge/jni/v8/JavaClassV8.cpp:
9248 * bridge/jni/v8/JavaClassV8.h:
9249 * bridge/jni/v8/JavaInstanceV8.cpp:
9250 * bridge/jni/v8/JavaInstanceV8.h:
9251 * bridge/jni/v8/JavaNPObjectV8.cpp:
9252 * bridge/jni/v8/JavaNPObjectV8.h:
9253
9254 2011-03-01 Steve Block <steveblock@google.com>
9255
9256 Reviewed by Jeremy Orlow.
9257
9258 Bridge.h should not include BridgeJSC.h
9259 https://bugs.webkit.org/show_bug.cgi?id=55212
9260
9261 Instead, BridgeJSC.h should include Bridge.h and code should include
9262 BridgeJSC.h as appropriate.
9263
9264 This prevents ports that use V8 from having to include JSC-specific
9265 files, even if the contents of those files are guarded.
9266
9267 No new tests, cleanup only.
9268
9269 * bindings/js/JSPluginElementFunctions.cpp:
9270 * bindings/js/ScriptControllerBrew.cpp:
9271 * bindings/js/ScriptControllerGtk.cpp:
9272 * bindings/js/ScriptControllerHaiku.cpp:
9273 * bindings/js/ScriptControllerQt.cpp:
9274 * bindings/js/ScriptControllerMac.mm:
9275 * bindings/js/ScriptControllerWin.cpp:
9276 * bindings/js/ScriptControllerWx.cpp:
9277 * bindings/js/ScriptInstance.h:
9278 * bindings/objc/WebScriptObject.mm:
9279 * bridge/Bridge.h:
9280 * bridge/c/c_class.h:
9281 * bridge/c/c_instance.h:
9282 * bridge/c/c_runtime.h:
9283 * bridge/jni/jsc/JNIBridgeJSC.h:
9284 * bridge/jni/jsc/JavaInstanceJSC.h:
9285 * bridge/jsc/BridgeJSC.h:
9286 * bridge/objc/objc_runtime.h:
9287 * bridge/qt/qt_class.h:
9288 * bridge/qt/qt_instance.h:
9289 * bridge/qt/qt_pixmapruntime.h:
9290 * bridge/qt/qt_runtime.h:
9291 * bridge/runtime_array.h:
9292 * bridge/runtime_method.h:
9293 * bridge/runtime_object.h:
9294 * bridge/runtime_root.cpp:
9295 * bridge/testbindings.cpp:
9296 * bridge/testbindings.mm:
9297 * bridge/testqtbindings.cpp:
9298 * page/win/FrameWin.cpp:
9299 * platform/graphics/wince/MediaPlayerProxy.cpp:
9300 * plugins/PluginView.cpp:
9301 * plugins/PluginViewNone.cpp:
9302 * plugins/gtk/PluginViewGtk.cpp:
9303 * plugins/mac/PluginViewMac.mm:
9304 * plugins/qt/PluginViewQt.cpp:
9305 * plugins/symbian/PluginViewSymbian.cpp:
9306 * plugins/win/PluginViewWin.cpp:
9307
9308 2011-03-01 Nikolas Zimmermann <nzimmermann@rim.com>
9309
9310 Reviewed by Antti Koivisto.
9311
9312 SVG 1.1 2nd Edition color-prop-05-t.svg exposes bug in 'currentColor' ha ndling
9313 https://bugs.webkit.org/show_bug.cgi?id=54800
9314
9315 Wrong handling of currentColor on inherit
9316 https://bugs.webkit.org/show_bug.cgi?id=38102
9317
9318 Stop storing RefPtr<SVGPaint> objects in the SVGRenderStyle for fill/str oke. These are the last
9319 two objects that held references to CSSValues, they're all gone now, ali gning better with RenderStyle.
9320 It's also dangerous, as a SVGPaint object can be shared by multiple SVGR enderStyles (MappedAttribute will
9321 once create a CSSStyleDeclaration for fill="red" and reuse it where poss ible), and it was easy to
9322 accidently mutate the object, affecting multiple styles. Instead store a Color, an URI and a paint
9323 type in SVGRenderStyle, enough to create a SVGPaint object, if needed (e g for computed styles).
9324
9325 <g color="green"><rect fill="currentColor"/> already worked fine in trun k, but
9326 <g fill="currentColor" color="green"><rect color="red"/> procuded a red rectangle.
9327
9328 In order to fix to bug we have to resolve all currentColor values for SV GPaint objects, in SVGCSSStyleSelector,
9329 as it's already done for SVGColor objects (stop-color, flood-color, etc. ) instead of in RenderSVGResource::fill/strokePaintingResource,
9330 when trying to use the paint server. The correct "color" value that shou ld be used from the RenderStyle, is directly
9331 available in CSSStyleSelector: in applyProperty m_style->color() gives t he desired value. In CSSStyleSelector it's handled
9332 exactly this way for non-SVG currentColor properties. Also fix computed styles, which did not resolve currentColor for SVGPaint/SVGColor.
9333
9334 A previous patch implemented the SVGPaint/SVGColor API. SVG demands thes e CSSValues to be mutable. Introduce
9335 CSSMutableValue, which extends CSSValue by a Node pointer, and let SVGPa int/SVGColor inherit from it.
9336 Mutating a SVGPaint/SVGColor object now takes immediate effect, which is reflected in the inline style / computed style.
9337 (Note that getPresentationAttribute() already takes care of removing the CSSValue from the mapped attribute cache, so that it's no longer shared.)
9338
9339 Add several new tests covering the patch.
9340
9341 Tests: svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
9342 svg/animations/animate-color-fill-currentColor.html
9343 svg/custom/SVGPaint-mutate-attribute.svg
9344 svg/custom/SVGPaint-mutate-inline-style.svg
9345
9346 * GNUMakefile.am: Add CSSMutableValue.h
9347 * WebCore.gypi: Ditto.
9348 * WebCore.xcodeproj/project.pbxproj: Ditto.
9349 * css/CSSMutableStyleDeclaration.cpp: Reset the Node pointer in all CSSM utableValues belonging to this style declaration.
9350 (WebCore::CSSMutableStyleDeclaration::~CSSMutableStyleDeclaration):
9351 * css/CSSMutableStyleDeclaration.h: Add destructor.
9352 * css/CSSMutableValue.h: Added.
9353 (WebCore::CSSMutableValue::CSSMutableValue):
9354 (WebCore::CSSMutableValue::~CSSMutableValue):
9355 (WebCore::CSSMutableValue::isMutableValue):
9356 (WebCore::CSSMutableValue::node):
9357 (WebCore::CSSMutableValue::setNode):
9358 (WebCore::CSSMutableValue::setNeedsStyleRecalc):
9359 * css/CSSStyleDeclaration.cpp:
9360 (WebCore::CSSStyleDeclaration::getPropertyCSSValue): Set the Node object of a CSSMutableValue to the Node, this style declaration belongs to.
9361 * css/CSSValue.h:
9362 (WebCore::CSSValue::isMutableValue): Return false, default.
9363 * css/SVGCSSComputedStyleDeclaration.cpp:
9364 (WebCore::CSSComputedStyleDeclaration::adjustSVGPaintForCurrentColor): A dd helper function, resolving currentColor values for SVGPaint objects.
9365 (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): Use curr entColorOrValidColor/adjustSVGPaintForCurrentColor to resolve SVGColor/SVGPaint values.
9366 * css/SVGCSSStyleSelector.cpp:
9367 (WebCore::CSSStyleSelector::applySVGProperty): Store fill/stroke uri, co lor, paint type seperated in SVGRenderStyle, don't store the full SVGPaint objec t anymore.
9368 * rendering/style/SVGRenderStyle.cpp:
9369 (WebCore::SVGRenderStyle::diff): Adapt to SVGPaint changes.
9370 * rendering/style/SVGRenderStyle.h: Ditto.
9371 (WebCore::SVGRenderStyle::initialFillOpacity):
9372 (WebCore::SVGRenderStyle::initialFillPaintType):
9373 (WebCore::SVGRenderStyle::initialFillPaintColor):
9374 (WebCore::SVGRenderStyle::initialFillPaintUri):
9375 (WebCore::SVGRenderStyle::initialStrokeOpacity):
9376 (WebCore::SVGRenderStyle::initialStrokePaintType):
9377 (WebCore::SVGRenderStyle::initialStrokePaintColor):
9378 (WebCore::SVGRenderStyle::initialStrokePaintUri):
9379 (WebCore::SVGRenderStyle::initialStrokeMiterLimit):
9380 (WebCore::SVGRenderStyle::initialStopOpacity):
9381 (WebCore::SVGRenderStyle::initialFloodOpacity):
9382 (WebCore::SVGRenderStyle::setFillPaint):
9383 (WebCore::SVGRenderStyle::setStrokePaint):
9384 (WebCore::SVGRenderStyle::fillPaintType):
9385 (WebCore::SVGRenderStyle::fillPaintColor):
9386 (WebCore::SVGRenderStyle::fillPaintUri):
9387 (WebCore::SVGRenderStyle::strokePaintType):
9388 (WebCore::SVGRenderStyle::strokePaintColor):
9389 (WebCore::SVGRenderStyle::strokePaintUri):
9390 (WebCore::SVGRenderStyle::hasStroke):
9391 (WebCore::SVGRenderStyle::hasFill):
9392 * rendering/style/SVGRenderStyleDefs.cpp: Ditto.
9393 (WebCore::StyleFillData::StyleFillData):
9394 (WebCore::StyleFillData::operator==):
9395 (WebCore::StyleStrokeData::StyleStrokeData):
9396 (WebCore::StyleStrokeData::operator==):
9397 * rendering/style/SVGRenderStyleDefs.h: Ditto.
9398 * rendering/svg/RenderSVGResource.cpp: Ditto.
9399 (WebCore::requestPaintingResource):
9400 * rendering/svg/RenderSVGResourceClipper.cpp: Ditto.
9401 (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
9402 * rendering/svg/SVGResources.cpp: Ditto.
9403 (WebCore::paintingResourceFromSVGPaint):
9404 (WebCore::SVGResources::buildCachedResources):
9405 * svg/SVGColor.cpp: Call setNeedsStyleRecalc() after mutating the object .
9406 (WebCore::SVGColor::setRGBColor):
9407 (WebCore::SVGColor::setRGBColorICCColor):
9408 (WebCore::SVGColor::setColor):
9409 * svg/SVGColor.h:
9410 * svg/SVGPaint.cpp: Ditto.
9411 (WebCore::SVGPaint::setUri):
9412 (WebCore::SVGPaint::setPaint):
9413 * svg/SVGPaint.h:
9414
9415 2011-03-01 Andrey Adaikin <aandrey@google.com>
9416
9417 Reviewed by Pavel Feldman.
9418
9419 Web Inspector: [Text editor] Handle decorated lines in the editor
9420 https://bugs.webkit.org/show_bug.cgi?id=55373
9421
9422 * inspector/front-end/SourceFrame.js:
9423 (WebInspector.SourceFrame.prototype._startEditing):
9424 (WebInspector.SourceFrame.prototype._endEditing):
9425 (WebInspector.SourceFrame.prototype._createTextViewer):
9426 * inspector/front-end/TextViewer.js:
9427 (WebInspector.TextEditorGutterPanel.prototype.textChanged):
9428 (WebInspector.TextEditorGutterChunk.prototype.addDecoration):
9429 (WebInspector.TextEditorGutterChunk.prototype.removeDecoration):
9430 (WebInspector.TextEditorMainPanel.prototype.set readOnly):
9431 (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
9432 (WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified):
9433 (WebInspector.TextEditorMainPanel.prototype._markDirtyLines):
9434 (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
9435 (WebInspector.TextEditorMainPanel.prototype._removeDecorationsInRange):
9436 (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
9437 (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
9438 (WebInspector.TextEditorMainChunk.prototype.addDecoration):
9439 (WebInspector.TextEditorMainChunk.prototype.removeDecoration):
9440 (WebInspector.TextEditorMainChunk.prototype.removeAllDecorations):
9441 (WebInspector.TextEditorMainChunk.prototype.get decorated):
9442
9443 2011-03-01 Philippe Normand <pnormand@igalia.com>
9444
9445 Unreviewed GTK build fix after r79978
9446
9447 * GNUmakefile.am:
9448
9449 2011-03-01 Andras Becsi <abecsi@webkit.org>
9450
9451 Unreviewed build fix.
9452
9453 [Qt] Fix minimal build.
9454
9455 No new tests needed.
9456
9457 * WebCore.pri: Is included in WebKit2.pro, so XP_UNIX can remain here.
9458
9459 2011-03-01 anthony taranto <anthony.taranto@gmail.com>
9460
9461 Return undefined value from ScriptController::evaluate(), allowing the
9462 caller to distinguish between an error and an undefined return value.
9463 https://bugs.webkit.org/show_bug.cgi?id=51528
9464
9465 * bindings/v8/ScriptController.cpp:
9466
9467 2011-03-01 Roland Steiner <rolandsteiner@chromium.org>
9468
9469 Reviewed by Kent Tamura.
9470
9471 Bug 54853 - Move TextControlInnerElements from WebCore/rendering to WebC ore/html/shadow
9472 https://bugs.webkit.org/show_bug.cgi?id=54853
9473
9474 Moving the files from rendering to html/shadow, with the exception of
9475 the class RenderTextControlInnerBlock, which I moved to RenderTextContro lSingleLine
9476 (this place is not ideal, but only a temporary state during the larger r efactoring
9477 for <input>).
9478
9479 No new tests. (refactoring)
9480
9481 * Android.mk:
9482 * CMakeLists.txt:
9483 * WebCore.gypi:
9484 * WebCore.pro:
9485 * WebCore.vcproj/WebCore.vcproj:
9486 * WebCore.xcodeproj/project.pbxproj:
9487 * html/shadow/TextControlInnerElements.cpp: Copied from Source/WebCore/r endering/TextControlInnerElements.cpp.
9488 * html/shadow/TextControlInnerElements.h: Copied from Source/WebCore/ren dering/TextControlInnerElements.h.
9489 * rendering/RenderTextControlSingleLine.cpp:
9490 (WebCore::RenderTextControlInnerBlock::positionForPoint):
9491 * rendering/RenderTextControlSingleLine.h:
9492 (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
9493 (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
9494 * rendering/TextControlInnerElements.cpp: Removed.
9495 * rendering/TextControlInnerElements.h: Removed.
9496
9497 2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
9498
9499 Reviewed by Tony Chang.
9500
9501 applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle
9502 https://bugs.webkit.org/show_bug.cgi?id=55338
9503
9504 Deployed EditingStyle in applyInlineStyleToPushDown and removeInlineStyl eFromElement.
9505
9506 Also added a convenience function EditingStyle::setProperty, which lazil y instantiates
9507 new CSSMutableStyleDeclaration for m_mutableStyle.
9508
9509 * editing/ApplyStyleCommand.cpp:
9510 (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Takes Editin gStyle*.
9511 (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Ditto.
9512 (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto.
9513 (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls the a bove three functions.
9514 (WebCore::ApplyStyleCommand::removeInlineStyle): Calls pushDownInlineSty leAroundNode.
9515 * editing/ApplyStyleCommand.h:
9516 * editing/EditingStyle.cpp:
9517 (WebCore::HTMLElementEquivalent::addToStyle): Takes EditingStyle*; calls EditingStyle::setProperty.
9518 (WebCore::HTMLAttributeEquivalent::addToStyle): Ditto.
9519 (WebCore::EditingStyle::setProperty): Added. This member function lazil y instantiates
9520 new CSSMutableStyleDeclaration for m_mutableStyle.
9521 (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Takes Editin gStyle*.
9522 (WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Ditto.
9523 (WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Di tto.
9524 * editing/EditingStyle.h: Added HTMLElementEquivalent and HTMLAttributeE quivalent as friends.
9525 (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Ditto.
9526 * editing/InsertTextCommand.cpp: Removed unnecessary includes.
9527 * editing/RemoveCSSPropertyCommand.h: Ditto.
9528
9529 2011-02-28 Pavel Feldman <pfeldman@chromium.org>
9530
9531 Not reviewed: chromium rebuilds XMLViewer after noop. Fixed gyp file.
9532
9533 * WebCore.gyp/WebCore.gyp:
9534
9535 2011-02-28 David Levin <levin@chromium.org>
9536
9537 Reviewed by Darin Adler.
9538
9539 KURL should expose a referrer property.
9540 https://bugs.webkit.org/show_bug.cgi?id=55415
9541
9542 No change in functionality so no new tests.
9543
9544 * loader/FrameLoader.cpp:
9545 (WebCore::FrameLoader::setOutgoingReferrer): Refactor to put the majorit y
9546 of functionality in KURL::strippedForUseAsReferrer() so that this code c an
9547 be more easily reused.
9548 * platform/KURL.cpp:
9549 (WebCore::KURL::strippedForUseAsReferrer): Converts the url to a string
9550 which is suitable for use as a referrer.
9551 * platform/KURL.h:
9552
9553 2011-02-28 Chang Shu <cshu@webkit.org>
9554
9555 Reviewed by Ryosuke Niwa.
9556
9557 Remove the support of Frame::isContentEditable and its dependencies.
9558 https://bugs.webkit.org/show_bug.cgi?id=54292
9559
9560 Frame::isContentEditable is currently based on two things: Editor::clien tIsEditable and
9561 Document::inDesignMode. In fact, it should only rely on Document::inDesi gnMode. As a result,
9562 Editor::clientIsEditable and its client-side implementation can be remov ed.
9563
9564 * WebCore.exp.in:
9565 * accessibility/AccessibilityRenderObject.cpp:
9566 (WebCore::AccessibilityRenderObject::isReadOnly):
9567 * editing/Editor.cpp:
9568 * editing/Editor.h:
9569 * editing/SelectionController.cpp:
9570 (WebCore::SelectionController::setSelectionFromNone):
9571 * html/HTMLElement.cpp:
9572 (WebCore::HTMLElement::isContentEditable):
9573 (WebCore::HTMLElement::isContentRichlyEditable):
9574 * page/DragController.cpp:
9575 (WebCore::DragController::operationForLoad):
9576 * page/EditorClient.h:
9577 * page/Frame.cpp:
9578 * page/Frame.h:
9579
9580 2011-02-28 Kent Tamura <tkent@chromium.org>
9581
9582 Reviewed by Darin Adler.
9583
9584 Number type input cannot be set to empty string if it has an initial val ue
9585 https://bugs.webkit.org/show_bug.cgi?id=53744
9586
9587 We need to distinguish null strings and empty strings for
9588 InputElementData::value. So InputType::sanitizeValue() also needs to
9589 take care of it.
9590
9591 * dom/InputElement.h: Add a comment to InputElementData::value and
9592 setValue about null strings.
9593 * html/InputType.h: Add a comment to sanitizeValue about null strings.
9594 * html/NumberInputType.cpp:
9595 (WebCore::NumberInputType::sanitizeValue): Returns a null string if the
9596 proposed value is a null string. Returning an empty string if the
9597 proposed value is not a number.
9598
9599 2011-02-28 Kent Tamura <tkent@chromium.org>
9600
9601 Reviewed by Darin Adler.
9602
9603 Number type input should not handle mouse wheel events if it has no focu s.
9604 https://bugs.webkit.org/show_bug.cgi?id=53638
9605
9606 * html/TextFieldInputType.cpp:
9607 (WebCore::TextFieldInputType::handleWheelEventForSpinButton): Check focu sed().
9608
9609 2011-02-28 Noel Gordon <noel.gordon@gmail.com>
9610 Reviewed by James Robinson.
9611
9612 [chromium] GradientSkia: use the common Gradient stop sorting methods.
9613 https://bugs.webkit.org/show_bug.cgi?id=54625
9614
9615 Remove a FIXME: call the Gradient.cpp stop storting routines, no need
9616 to duplicate that code herein.
9617
9618 No change in behavior, so no new tests.
9619
9620 * platform/graphics/skia/GradientSkia.cpp:
9621 (WebCore::Gradient::platformGradient):
9622
9623 2011-02-28 Steve Block <steveblock@google.com>
9624
9625 Reviewed by Jeremy Orlow.
9626
9627 JNI code should include <jni.h> on non-OSX platforms.
9628 https://bugs.webkit.org/show_bug.cgi?id=55219
9629
9630 On Mac we need to include <JavaVM/jni.h> as this is a framework
9631 include. We include jni.h through JNIUtility.h to minimize the
9632 number of ifdefs.
9633
9634 No new tests, build fix only.
9635
9636 * WebCore.xcodeproj/project.pbxproj
9637 * bridge/jni/JNIUtility.h:
9638 * bridge/jni/jni_jsobject.h:
9639 * bridge/jni/jsc/JNIBridgeJSC.h:
9640 * bridge/jni/jsc/JavaInstanceJSC.h:
9641 * bridge/jni/v8/JavaInstanceV8.h:
9642
9643 2011-02-28 Nebojsa Sabovic <neb@chromium.org>
9644
9645 Reviewed by James Robinson.
9646
9647 [chromium] Pepper plugins render upside down
9648 https://bugs.webkit.org/show_bug.cgi?id=55101
9649
9650 No layout tests for pepper plugins (yet).
9651
9652 * platform/graphics/chromium/PluginLayerChromium.h:
9653
9654 2011-02-28 Tony Gentilcore <tonyg@chromium.org>
9655
9656 Reviewed by Adam Barth.
9657
9658 Follow HTML5 spec for document.open() a little more closely
9659 https://bugs.webkit.org/show_bug.cgi?id=55392
9660
9661 See: 3.5.1.4 at http://www.whatwg.org/specs/web-apps/current-work/#dom-d ocument-open.
9662
9663 The second return check matches the spec. The first return check (isExec utingScript())
9664 was left in place because without it, fast/tokenizer/write-external-scri pt-open.html
9665 would fail. It also possible there is a spec bug because FF4 crashes on that test and
9666 IE9 prints "FAILURE." The isLoadingMainResource() check was removed beca use the main
9667 resource is always loading while parser->isParsing().
9668
9669 Test: fast/parser/double-write-from-closed-iframe.html
9670
9671 * dom/Document.cpp:
9672 (WebCore::Document::open):
9673
9674 2011-02-28 Avi Drissman <avi@google.com>
9675
9676 Reviewed by James Robinson.
9677
9678 WebCursorInfo needs to match enums in platform/Cursor.h
9679 https://bugs.webkit.org/show_bug.cgi?id=55094
9680
9681 * platform/chromium/CursorChromium.cpp:
9682 (WebCore::grabCursor):
9683 (WebCore::grabbingCursor):
9684 * platform/chromium/PlatformCursor.h:
9685
9686 2011-02-28 Jia Pu <jpu@apple.com>
9687
9688 Reviewed by Darin Adler.
9689
9690 [Mac] Make "Change back to …" contextual menu item work with new autocor rection.
9691 https://bugs.webkit.org/show_bug.cgi?id=55396
9692 <rdar://problem/8836093>
9693
9694 The change in InlineTextBox.cpp fixes a bug, where the rectangle of Repl acement marker isn't
9695 calculated. We need this to do hit test when deciding whether to show "C hange back to ..." on
9696 contextual menu.
9697
9698 The change in Editor.cpp is for notifying spellchecker about the reversi on whenever "Change
9699 back to ..." is clicked.
9700
9701 * editing/Editor.cpp:
9702 (WebCore::Editor::changeBackToReplacedString):
9703 * rendering/InlineTextBox.cpp:
9704 (WebCore::InlineTextBox::paintDocumentMarkers):
9705
9706 2011-02-28 Victoria Kirst <vrk@google.com>
9707
9708 Reviewed by Kenneth Russell.
9709
9710 [chromium] Fall back to texSubImage2D when mapTexSubImage2D fails in Vid eoLayerChromium
9711 https://bugs.webkit.org/show_bug.cgi?id=55269
9712
9713 Mesa does not support mapTexSubImage2D, so this change lets
9714 GPU-accelerated video work with DRT layout tests.
9715
9716 * platform/graphics/chromium/VideoLayerChromium.cpp:
9717 (WebCore::VideoLayerChromium::updateTexture):
9718
9719 2011-02-28 David Hyatt <hyatt@apple.com>
9720
9721 Reviewed by Dan Bernstein.
9722
9723 https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text. Change staticX and staticY
9724 to be staticInlinePosition and staticBlockPosition. Patch all of the co mputations involving these variables to be writing
9725 mode aware. Mixed writing modes are not yet supported.
9726
9727 Added new tests in fast/block/positioning/auto.
9728
9729 * rendering/RenderBlock.cpp:
9730 (WebCore::RenderBlock::adjustPositionedBlock):
9731 (WebCore::RenderBlock::layoutPositionedObjects):
9732 * rendering/RenderBlock.h:
9733 (WebCore::RenderBlock::startOffsetForLine):
9734 * rendering/RenderBlockLineLayout.cpp:
9735 (WebCore::RenderBlock::appendRunsForObject):
9736 (WebCore::setStaticPositions):
9737 (WebCore::RenderBlock::skipTrailingWhitespace):
9738 (WebCore::RenderBlock::skipLeadingWhitespace):
9739 (WebCore::RenderBlock::findNextLineBreak):
9740 * rendering/RenderBox.cpp:
9741 (WebCore::RenderBox::positionLineBox):
9742 (WebCore::computeInlineStaticDistance):
9743 (WebCore::RenderBox::computePositionedLogicalWidth):
9744 (WebCore::computeBlockStaticDistance):
9745 (WebCore::RenderBox::computePositionedLogicalHeight):
9746 (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
9747 (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
9748 * rendering/RenderBoxModelObject.h:
9749 (WebCore::RenderBoxModelObject::borderAndPaddingLogicalLeft):
9750 (WebCore::RenderBoxModelObject::borderAndPaddingStart):
9751 (WebCore::RenderBoxModelObject::borderLogicalLeft):
9752 (WebCore::RenderBoxModelObject::borderLogicalRight):
9753 * rendering/RenderFlexibleBox.cpp:
9754 (WebCore::RenderFlexibleBox::layoutHorizontalBox):
9755 (WebCore::RenderFlexibleBox::layoutVerticalBox):
9756 * rendering/RenderInline.cpp:
9757 (WebCore::RenderInline::relativePositionedInlineOffset):
9758 * rendering/RenderLayer.cpp:
9759 (WebCore::RenderLayer::RenderLayer):
9760 * rendering/RenderLayer.h:
9761 (WebCore::RenderLayer::staticInlinePosition):
9762 (WebCore::RenderLayer::staticBlockPosition):
9763 (WebCore::RenderLayer::setStaticInlinePosition):
9764 (WebCore::RenderLayer::setStaticBlockPosition):
9765 * rendering/style/RenderStyle.h:
9766 (WebCore::InheritedFlags::hasAutoLeftAndRight):
9767 (WebCore::InheritedFlags::hasAutoTopAndBottom):
9768 (WebCore::InheritedFlags::hasStaticInlinePosition):
9769 (WebCore::InheritedFlags::hasStaticBlockPosition):
9770
9771 2011-02-28 Balazs Kelemen <kbalazs@webkit.org>
9772
9773 Reviewed by Anders Carlsson.
9774
9775 [Qt][WK2] Plugin initialization
9776 https://bugs.webkit.org/show_bug.cgi?id=48127
9777
9778 No function change so no new tests.
9779
9780 * WebCore.pri: Lift the definition of the XP_UNIX macro
9781 from WebCore.pri to WebKit.pri to apply it to WebKit2 as well.
9782
9783 2011-02-28 Dean Jackson <dino@apple.com>
9784
9785 Reviewed by Eric Carlson.
9786
9787 https://bugs.webkit.org/show_bug.cgi?id=55239
9788
9789 Allow webkitEnterFullScreen to be called from outside
9790 a user gesture, but only when the correct restrictions
9791 have been lifted in WebCore. Add a new restriction type
9792 for this situation. Meanwhile, expose the current
9793 restrictions externally from HTMLMediaElement, so that
9794 clients can easily set restrictions on their port.
9795
9796 No new tests. This doesn't change existing behavior. Some
9797 WebKit clients may lift the restriction.
9798
9799 * html/HTMLMediaElement.cpp:
9800 (WebCore::HTMLMediaElement::HTMLMediaElement):
9801 - ensure restrictions initialize with fullscreen restricted
9802 * html/HTMLMediaElement.h:
9803 (WebCore::HTMLMediaElement::requireUserGestureForLoad):
9804 (WebCore::HTMLMediaElement::requireUserGestureForRateChange):
9805 (WebCore::HTMLMediaElement::requireUserGestureForFullScreen):
9806 (WebCore::HTMLMediaElement::setBehaviorRestrictions):
9807 - new methods to expose the current restrictions
9808 * html/HTMLVideoElement.cpp:
9809 (WebCore::HTMLVideoElement::webkitEnterFullscreen):
9810
9811 2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
9812
9813 Unreviewed, rolling out r78789.
9814 http://trac.webkit.org/changeset/78789
9815 https://bugs.webkit.org/show_bug.cgi?id=55409
9816
9817 Incorrect canvas fallback implementation (Requested by
9818 inferno-sec on #webkit).
9819
9820 * accessibility/AccessibilityObject.h:
9821 * accessibility/AccessibilityRenderObject.cpp:
9822 (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
9823 (WebCore::AccessibilityRenderObject::canHaveChildren):
9824 * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
9825 (atkRole):
9826 * accessibility/mac/AccessibilityObjectWrapper.mm:
9827 * html/HTMLFormControlElement.cpp:
9828 (WebCore::HTMLFormControlElement::isFocusable):
9829 * rendering/RenderHTMLCanvas.cpp:
9830 * rendering/RenderHTMLCanvas.h:
9831 * rendering/RenderObject.cpp:
9832 (WebCore::RenderObject::repaint):
9833 * rendering/RenderTreeAsText.cpp:
9834 (WebCore::write):
9835
9836 2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
9837
9838 Unreviewed, rolling out r79425.
9839 http://trac.webkit.org/changeset/79425
9840 https://bugs.webkit.org/show_bug.cgi?id=55406
9841
9842 Incorrect canvas fallback implementation. (Requested by
9843 inferno-sec on #webkit).
9844
9845 * rendering/RenderHTMLCanvas.cpp:
9846 (WebCore::RenderHTMLCanvas::nodeAtPoint):
9847
9848 2011-02-28 Adam Klein <adamk@chromium.org>
9849
9850 Reviewed by Adam Barth.
9851
9852 [fileapi] Implement LocalFileSystem.resolveLocalFileSystemURI
9853 https://bugs.webkit.org/show_bug.cgi?id=54774
9854
9855 See http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#methods
9856 for the spec implemented by this patch.
9857
9858 Test: fast/filesystem/resolve-uri.html
9859
9860 * fileapi/DOMFileSystemBase.cpp:
9861 (WebCore::DOMFileSystemBase::crackFileSystemURL):
9862 * fileapi/DOMFileSystemBase.h:
9863 Added constants for "temporary" and "persistent".
9864 * fileapi/EntryBase.cpp:
9865 Replace hardcoded strings with aforementioned constants.
9866 * fileapi/FileSystemCallbacks.cpp:
9867 (WebCore::ResolveURICallbacks::create):
9868 (WebCore::ResolveURICallbacks::ResolveURICallbacks):
9869 (WebCore::ResolveURICallbacks::didOpenFileSystem):
9870 Chains a call of openFileSystem to calls to getDirectory/getFile.
9871 * fileapi/FileSystemCallbacks.h:
9872 * fileapi/LocalFileSystem.cpp:
9873 (WebCore::LocalFileSystem::readFileSystem):
9874 * fileapi/LocalFileSystem.h:
9875 Remove size argument from readFileSystem()
9876 * page/DOMWindow.cpp:
9877 (WebCore::DOMWindow::resolveLocalFileSystemURI):
9878 * page/DOMWindow.h:
9879 * page/DOMWindow.idl:
9880
9881 2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
9882
9883 Reviewed by Oliver Hunt.
9884
9885 Build fix for Qt port after API changes of http://trac.webkit.org/change set/79904.
9886
9887 * bridge/qt/qt_runtime.cpp:
9888 (JSC::Bindings::QtConnectionObject::execute):
9889
9890 2011-02-25 David Levin <levin@chromium.org>
9891
9892 Reviewed by Darin Adler.
9893
9894 Remove some duplicate code from KURLGoogle.cpp
9895 https://bugs.webkit.org/show_bug.cgi?id=55266
9896
9897 No change in functionality so no new tests.
9898
9899 * WebCore.gyp/WebCore.gyp: Make KURL.cpp get built by Chromium.
9900 * platform/KURL.cpp:
9901 Simply moved #include's and some code that was identical (i.e.
9902 had been copied) to KURLGoogle.cpp outside of ifdef !USE(GOOGLEURL)
9903 to reduce duplication.
9904 * platform/KURLGoogle.cpp:
9905 Removed the duplicate code.
9906
9907 2011-02-28 Oliver Hunt <oliver@apple.com>
9908
9909 Reviewed by Gavin Barraclough.
9910
9911 Make ScopeChainNode GC allocated
9912 https://bugs.webkit.org/show_bug.cgi?id=55283
9913
9914 Update WebCore to deal with the absence of the ScopeChain
9915 class.
9916
9917 * ForwardingHeaders/runtime/ScopeChain.h: Added.
9918 * bindings/js/JSHTMLElementCustom.cpp:
9919 (WebCore::JSHTMLElement::pushEventHandlerScope):
9920 * bindings/js/JSJavaScriptCallFrameCustom.cpp:
9921 (WebCore::JSJavaScriptCallFrame::scopeChain):
9922 (WebCore::JSJavaScriptCallFrame::scopeType):
9923 * bindings/js/JSLazyEventListener.cpp:
9924 (WebCore::JSLazyEventListener::initializeJSFunction):
9925 * bindings/js/JSMainThreadExecState.h:
9926 (WebCore::JSMainThreadExecState::evaluate):
9927 * bindings/js/JSNodeCustom.cpp:
9928 (WebCore::JSNode::pushEventHandlerScope):
9929 * bindings/js/JavaScriptCallFrame.cpp:
9930 (WebCore::JavaScriptCallFrame::scopeChain):
9931 * bindings/js/JavaScriptCallFrame.h:
9932 * bindings/scripts/CodeGeneratorJS.pm:
9933 * bridge/c/c_class.cpp:
9934 * bridge/c/c_runtime.cpp:
9935 * bridge/jni/JNIBridge.cpp:
9936 * bridge/qt/qt_runtime.cpp:
9937 (JSC::Bindings::QtConnectionObject::execute):
9938 * plugins/PluginViewNone.cpp:
9939
9940 2011-02-28 Chang Shu <cshu@webkit.org>
9941
9942 Reviewed by Adele Peterson.
9943
9944 REGRESSION (r79762): Items in <select multiple> have focus rings, but sh ouldn't
9945 https://bugs.webkit.org/show_bug.cgi?id=55323
9946
9947 Draw focus ring on selected items only if spatial navigation is enabled.
9948
9949 Test: fast/forms/select-listbox-multiple-no-focusring.html
9950
9951 * rendering/RenderBlock.h:
9952 * rendering/RenderListBox.cpp:
9953 (WebCore::RenderListBox::addFocusRingRects):
9954
9955 2011-02-28 Abhishek Arya <inferno@chromium.org>
9956
9957 Reviewed by Anders Carlsson.
9958
9959 We can cancel the plugin load and fail with error before m_manualStream
9960 got a chance to initialize in PluginView::didReceiveResponse. This can
9961 happen when we run pending document onload events during plugin load tha t
9962 remove the frame from underneath. So, change the assert into a null chec k.
9963 https://bugs.webkit.org/show_bug.cgi?id=55307
9964
9965 * plugins/PluginView.cpp:
9966 (WebCore::PluginView::didFail):
9967
9968 2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
9969
9970 Reviewed by Alexey Proskuryakov.
9971
9972 Build fix for Intel ICC Compiler.
9973 https://bugs.webkit.org/show_bug.cgi?id=55221
9974
9975 The virtual inheritance seems to confuse ICC.
9976 Anything that links with webkit has an undefined reference otherwise.
9977
9978 * svg/SVGTransformable.cpp:
9979 (WebCore::SVGTransformable::~SVGTransformable):
9980 * svg/SVGTransformable.h:
9981
9982 2011-02-28 Sergio Villar Senin <svillar@igalia.com>
9983
9984 Reviewed by Martin Robinson.
9985
9986 [Gtk] Resource size is incorrectly reported to WebCore
9987 https://bugs.webkit.org/show_bug.cgi?id=53228
9988
9989 When calling didReceiveData we are sending an invalid value for
9990 lengthReceived. Sometimes we were even passing a boolean value instead o f the
9991 expected integer. We should pass the size of the received data instead o f the
9992 total amount of data received.
9993
9994 * platform/network/ResourceHandleInternal.h:
9995 (WebCore::ResourceHandleInternal::ResourceHandleInternal):
9996 * platform/network/soup/ResourceHandleSoup.cpp:
9997 (WebCore::gotChunkCallback):
9998 (WebCore::sendRequestCallback):
9999 (WebCore::readCallback):
10000
10001 2011-02-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>
10002
10003 Reviewed by Dan Bernstein.
10004
10005 Cleanup the include guard form an Objective-C files
10006 https://bugs.webkit.org/show_bug.cgi?id=55379
10007
10008 Normally Objective-C files do not need include guard.
10009 r76916 introduced an include guard in EmptyProtocolDefinitions.h.
10010 The guard is no longer needed after r76991.
10011
10012 No new tests as there is no new functionality.
10013
10014 * platform/mac/EmptyProtocolDefinitions.h:
10015
10016 2011-02-28 Pavel Podivilov <podivilov@chromium.org>
10017
10018 Reviewed by Pavel Feldman.
10019
10020 Web Inspector: [REGRESSION] no resources in scripts panel because debugg er is enabled too early.
10021 https://bugs.webkit.org/show_bug.cgi?id=55389
10022
10023 * inspector/InspectorAgent.cpp:
10024 (WebCore::InspectorAgent::populateScriptObjects):
10025 * inspector/InspectorDebuggerAgent.cpp:
10026 (WebCore::InspectorDebuggerAgent::setFrontend):
10027 (WebCore::InspectorDebuggerAgent::enableDebuggerAfterShown):
10028 * inspector/InspectorDebuggerAgent.h:
10029
10030 2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
10031
10032 Unreviewed, rolling out r79877.
10033 http://trac.webkit.org/changeset/79877
10034 https://bugs.webkit.org/show_bug.cgi?id=55388
10035
10036 Breaks chromium build (Requested by antonm_ on #webkit).
10037
10038 * WebCore.gypi:
10039 * platform/graphics/chromium/ContentLayerChromium.cpp:
10040 (WebCore::ContentLayerChromium::updateContentsIfDirty):
10041 (WebCore::ContentLayerChromium::resizeUploadBufferForImage):
10042 (WebCore::ContentLayerChromium::resizeUploadBuffer):
10043 (WebCore::SkBitmapConditionalAutoLockerPixels::SkBitmapConditionalAutoLo ckerPixels):
10044 (WebCore::SkBitmapConditionalAutoLockerPixels::~SkBitmapConditionalAutoL ockerPixels):
10045 (WebCore::SkBitmapConditionalAutoLockerPixels::lockPixels):
10046 (WebCore::ContentLayerChromium::updateTextureIfNeeded):
10047 (WebCore::ContentLayerChromium::draw):
10048 * platform/graphics/chromium/ContentLayerChromium.h:
10049 * platform/graphics/chromium/ImageLayerChromium.cpp:
10050 (WebCore::ImageLayerChromium::updateContentsIfDirty):
10051 * platform/graphics/chromium/ImageLayerChromium.h:
10052 * platform/graphics/chromium/LayerTilerChromium.cpp:
10053 (WebCore::LayerTilerChromium::contentRectToTileIndices):
10054 (WebCore::LayerTilerChromium::update):
10055 * platform/graphics/chromium/LayerTilerChromium.h:
10056 * platform/graphics/chromium/PlatformCanvas.cpp: Removed.
10057 * platform/graphics/chromium/PlatformCanvas.h: Removed.
10058 * platform/graphics/chromium/PlatformImage.cpp: Removed.
10059 * platform/graphics/chromium/PlatformImage.h: Removed.
10060
10061 2011-02-28 Pavel Podivilov <podivilov@chromium.org>
10062
10063 Reviewed by Pavel Feldman.
10064
10065 Web Inspector: add live edit test.
10066 https://bugs.webkit.org/show_bug.cgi?id=55360
10067
10068 Test: inspector/debugger/live-edit.html
10069
10070 * inspector/front-end/SourceFrame.js:
10071 (WebInspector.SourceFrame.prototype._doubleClick):
10072 (WebInspector.SourceFrame.prototype._didEditLine):
10073
10074 2011-02-28 Pavel Feldman <pfeldman@chromium.org>
10075
10076 Not reviewed. Follow up to r79858, removing optimistic assertion that fa ils on debug bot.
10077
10078 * inspector/InspectorBrowserDebuggerAgent.cpp:
10079 (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
10080
10081 2011-02-25 Adrienne Walker <enne@google.com>
10082
10083 Reviewed by James Robinson.
10084
10085 [chromium] Abstract "pixels with a graphics context" into its own class
10086 https://bugs.webkit.org/show_bug.cgi?id=55259
10087
10088 This creates new PlatformCanvas/PlatformImage classes which wrap
10089 all of the #ifdef Skia/Cg warts from the compositor. All classes
10090 (LayerTilerChromium, ContentLayerChromium, and ImageLayerChromium) are
10091 modified to use these abstractions.
10092
10093 Tests: LayoutTests/compositing
10094
10095 * WebCore.gypi:
10096 * platform/graphics/chromium/ContentLayerChromium.cpp:
10097 (WebCore::ContentLayerChromium::updateContentsIfDirty):
10098 (WebCore::ContentLayerChromium::resizeUploadBuffer):
10099 (WebCore::ContentLayerChromium::updateTextureIfNeeded):
10100 (WebCore::ContentLayerChromium::updateTexture):
10101 (WebCore::ContentLayerChromium::draw):
10102 * platform/graphics/chromium/ContentLayerChromium.h:
10103 * platform/graphics/chromium/ImageLayerChromium.cpp:
10104 (WebCore::ImageLayerChromium::updateContentsIfDirty):
10105 (WebCore::ImageLayerChromium::updateTextureIfNeeded):
10106 * platform/graphics/chromium/ImageLayerChromium.h:
10107 * platform/graphics/chromium/LayerTilerChromium.cpp:
10108 (WebCore::LayerTilerChromium::contentRectToTileIndices):
10109 (WebCore::LayerTilerChromium::update):
10110 (WebCore::LayerTilerChromium::updateFromPixels):
10111 * platform/graphics/chromium/LayerTilerChromium.h:
10112 * platform/graphics/chromium/PlatformCanvas.cpp: Added.
10113 (WebCore::PlatformCanvas::PlatformCanvas):
10114 (WebCore::PlatformCanvas::~PlatformCanvas):
10115 (WebCore::PlatformCanvas::resize):
10116 (WebCore::PlatformCanvas::AutoLocker::AutoLocker):
10117 (WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
10118 (WebCore::PlatformCanvas::Painter::Painter):
10119 (WebCore::PlatformCanvas::Painter::~Painter):
10120 * platform/graphics/chromium/PlatformCanvas.h: Added.
10121 (WebCore::PlatformCanvas::AutoLocker::pixels):
10122 (WebCore::PlatformCanvas::Painter::context):
10123 (WebCore::PlatformCanvas::size):
10124 * platform/graphics/chromium/PlatformImage.cpp: Copied from Source/WebCo re/platform/graphics/chromium/ImageLayerChromium.cpp.
10125 (WebCore::PlatformImage::PlatformImage):
10126 (WebCore::PlatformImage::updateFromImage):
10127 * platform/graphics/chromium/PlatformImage.h: Added.
10128 (WebCore::PlatformImage::pixels):
10129 (WebCore::PlatformImage::size):
10130
10131 2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
10132
10133 Unreviewed, rolling out r79784.
10134 http://trac.webkit.org/changeset/79784
10135 https://bugs.webkit.org/show_bug.cgi?id=55386
10136
10137 This change causes lots of assertion failures in Debug builds
10138 (Requested by aroben on #webkit).
10139
10140 * css/CSSStyleSelector.cpp:
10141 (WebCore::convertToLength):
10142 (WebCore::CSSStyleSelector::applyProperty):
10143 (WebCore::CSSStyleSelector::createTransformOperations):
10144 * platform/Length.h:
10145 (WebCore::Length::Length):
10146 (WebCore::Length::operator==):
10147 (WebCore::Length::operator!=):
10148 (WebCore::Length::rawValue):
10149 (WebCore::Length::type):
10150 (WebCore::Length::quirk):
10151 (WebCore::Length::setValue):
10152 (WebCore::Length::setRawValue):
10153 (WebCore::Length::calcFloatValue):
10154 (WebCore::Length::isZero):
10155 (WebCore::Length::blend):
10156 * rendering/AutoTableLayout.cpp:
10157 (WebCore::AutoTableLayout::recalcColumn):
10158 (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
10159 * rendering/FixedTableLayout.cpp:
10160 (WebCore::FixedTableLayout::calcWidthArray):
10161
10162 2011-02-28 Andreas Kling <kling@webkit.org>
10163
10164 Reviewed by Darin Adler.
10165
10166 Use Frame::ownerElement() directly where appropriate.
10167 https://bugs.webkit.org/show_bug.cgi?id=55385
10168
10169 Don't take the roundabout way through frame->document->ownerElement
10170 which just checks that the document->frame is non-null.
10171
10172 No new test, refactoring only.
10173
10174 * editing/SelectionController.cpp:
10175 (WebCore::SelectionController::selectFrameElementInParentIfFullySelected ):
10176 * loader/FrameLoader.cpp:
10177 (WebCore::FrameLoader::loadWithDocumentLoader):
10178 * page/DOMWindow.cpp:
10179 (WebCore::DOMWindow::dispatchLoadEvent):
10180 * page/EventHandler.cpp:
10181 (WebCore::EventHandler::scrollRecursively):
10182 (WebCore::EventHandler::logicalScrollRecursively):
10183 * page/FrameView.cpp:
10184 (WebCore::FrameView::init):
10185 (WebCore::FrameView::layout):
10186 (WebCore::FrameView::repaintContentRectangle):
10187 (WebCore::FrameView::windowClipRect):
10188 (WebCore::FrameView::paintContents):
10189
10190 2011-02-28 Pavel Podivilov <podivilov@chromium.org>
10191
10192 Reviewed by Pavel Feldman.
10193
10194 Web Inspector: [REGRESSION] source frame is recreated for each inlined s cript in document.
10195 https://bugs.webkit.org/show_bug.cgi?id=55377
10196
10197 * inspector/front-end/ScriptsPanel.js:
10198 (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
10199 (WebInspector.ScriptsPanel.prototype._sourceFrameForSourceName):
10200 (WebInspector.ScriptsPanel.prototype._createSourceFrame):
10201 (WebInspector.ScriptsPanel.prototype._recreateSourceFrame):
10202
10203 2011-02-28 Patrick Gansterer <paroga@webkit.org>
10204
10205 Unreviewed build fix for !ENABLE(SVG_ANIMATION) after r79569.
10206
10207 * svg/SVGDocumentExtensions.cpp:
10208 (WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget):
10209
10210 2011-02-28 Renata Hodovan <reni@webkit.org>
10211
10212 Reviewed by Andreas Kling.
10213
10214 Optimize parameter transmissions in FEConvolveMatrix.
10215 https://bugs.webkit.org/show_bug.cgi?id=55381
10216
10217 Parameter transmission via reference is more efficient than with copy. S o they are substituted.
10218
10219 No new tests are needed since this is a refactoring.
10220
10221 * platform/graphics/filters/FEConvolveMatrix.cpp:
10222 (WebCore::FEConvolveMatrix::setKernelSize):
10223 (WebCore::FEConvolveMatrix::setTargetOffset):
10224 (WebCore::FEConvolveMatrix::setKernelUnitLength):
10225 * platform/graphics/filters/FEConvolveMatrix.h:
10226
10227 2011-02-28 Yury Semikhatsky <yurys@chromium.org>
10228
10229 Unreviewed. Fix Chromium tests failures due to r79858.
10230
10231 * inspector/InspectorAgent.cpp:
10232 (WebCore::InspectorAgent::inspectedPageDestroyed):
10233
10234 2011-02-28 Vsevolod Vlasov <vsevik@chromium.org>
10235
10236 Reviewed by Pavel Feldman.
10237
10238 XML without style should render as syntax-highlighted source.
10239 https://bugs.webkit.org/show_bug.cgi?id=13807
10240
10241 XML tree view mode implemented. If XML does not have any style
10242 information, it is rendered as highlighted source with collapsable
10243 elements.
10244
10245 Tests: fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog.xml
10246 fast/encoding/dumpAsText/utf-16-no-bom.xml
10247 http/tests/xmlviewer/dumpAsText/css-stylesheet.xml
10248 http/tests/xmlviewer/dumpAsText/frames.html
10249 http/tests/xmlviewer/dumpAsText/mathml.xml
10250 http/tests/xmlviewer/dumpAsText/svg.xml
10251 http/tests/xmlviewer/dumpAsText/wml.xml
10252 http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
10253 http/tests/xmlviewer/dumpAsText/xlink.xml
10254 http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
10255 http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
10256 http/tests/xmlviewer/dumpAsText/xmlviewer.xml
10257 http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
10258 http/tests/xmlviewer/dumpAsText/xul.xml
10259 svg/hixie/error/dumpAsText/004.xml
10260 svg/hixie/error/dumpAsText/005.xml
10261
10262 * CMakeLists.txt:
10263 * DerivedSources.make:
10264 * GNUmakefile.am:
10265 * WebCore.gyp/WebCore.gyp:
10266 * WebCore.gypi:
10267 * WebCore.vcproj/WebCore.vcproj:
10268 * WebCore.xcodeproj/project.pbxproj:
10269 * css/CSSStyleSelector.cpp:
10270 (WebCore::CSSStyleSelector::matchUARules):
10271 * dom/Document.cpp:
10272 (WebCore::Document::Document):
10273 (WebCore::Document::createElement):
10274 * dom/Document.h:
10275 (WebCore::Document::usesViewSourceStyles):
10276 (WebCore::Document::setUsesViewSourceStyles):
10277 (WebCore::Document::sawElementsInKnownNamespaces):
10278 * dom/XMLDocumentParser.h:
10279 * dom/XMLDocumentParserLibxml2.cpp:
10280 (WebCore::XMLDocumentParser::XMLDocumentParser):
10281 (WebCore::XMLDocumentParser::processingInstruction):
10282 (WebCore::XMLDocumentParser::initializeParserContext):
10283 (WebCore::XMLDocumentParser::doEnd):
10284 * dom/XMLDocumentParserQt.cpp:
10285 (WebCore::XMLDocumentParser::XMLDocumentParser):
10286 (WebCore::XMLDocumentParser::initializeParserContext):
10287 (WebCore::XMLDocumentParser::parseProcessingInstruction):
10288 * html/HTMLViewSourceDocument.cpp:
10289 (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
10290 * xml/XMLTreeViewer.cpp: Added.
10291 (WebCore::XMLTreeViewer::XMLTreeViewer):
10292 (WebCore::XMLTreeViewer::hasNoStyleInformation):
10293 (WebCore::XMLTreeViewer::transformDocumentToTreeView):
10294 * xml/XMLTreeViewer.h: Added.
10295 (WebCore::XMLTreeViewer::~XMLTreeViewer):
10296 * xml/XMLViewer.xsl: Added.
10297 * xml/XSLStyleSheet.h:
10298 (WebCore::XSLStyleSheet::createForXMLTreeViewer):
10299
10300 2011-02-28 Yury Semikhatsky <yurys@chromium.org>
10301
10302 Reviewed by Pavel Feldman.
10303
10304 Web Inspector: debugger agents should have same livetime as InspectorAge nt
10305 https://bugs.webkit.org/show_bug.cgi?id=55369
10306
10307 DOM and JS debugger agents are now created in InspectorAgent's construct or and owned
10308 by the agent. Debugger state is cleared on frontend disconnect.
10309
10310 * inspector/Inspector.idl:
10311 * inspector/InspectorAgent.cpp:
10312 (WebCore::InspectorAgent::InspectorAgent):
10313 (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
10314 (WebCore::InspectorAgent::setFrontend):
10315 (WebCore::InspectorAgent::disconnectFrontend):
10316 (WebCore::InspectorAgent::populateScriptObjects):
10317 (WebCore::InspectorAgent::didCommitLoad):
10318 (WebCore::InspectorAgent::showScriptsPanel):
10319 * inspector/InspectorAgent.h:
10320 * inspector/InspectorBrowserDebuggerAgent.cpp:
10321 (WebCore::InspectorBrowserDebuggerAgent::create):
10322 (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
10323 (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent) :
10324 (WebCore::InspectorBrowserDebuggerAgent::debuggerWasEnabled):
10325 (WebCore::InspectorBrowserDebuggerAgent::debuggerWasDisabled):
10326 (WebCore::InspectorBrowserDebuggerAgent::disable):
10327 (WebCore::InspectorBrowserDebuggerAgent::setFrontend):
10328 (WebCore::InspectorBrowserDebuggerAgent::clearFrontend):
10329 (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
10330 (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
10331 (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
10332 (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
10333 (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
10334 (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
10335 (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
10336 (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
10337 (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
10338 (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
10339 (WebCore::InspectorBrowserDebuggerAgent::clear):
10340 * inspector/InspectorBrowserDebuggerAgent.h:
10341 * inspector/InspectorController.cpp:
10342 (WebCore::InspectorController::debuggerEnabled):
10343 (WebCore::InspectorController::showAndEnableDebugger):
10344 (WebCore::InspectorController::disableDebugger):
10345 * inspector/InspectorDebuggerAgent.cpp:
10346 (WebCore::InspectorDebuggerAgent::create):
10347 (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
10348 (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
10349 (WebCore::InspectorDebuggerAgent::startUserInitiatedDebugging):
10350 (WebCore::InspectorDebuggerAgent::enable):
10351 (WebCore::InspectorDebuggerAgent::disable):
10352 (WebCore::InspectorDebuggerAgent::enabled):
10353 (WebCore::InspectorDebuggerAgent::restore):
10354 (WebCore::InspectorDebuggerAgent::setFrontend):
10355 (WebCore::InspectorDebuggerAgent::clearFrontend):
10356 (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpoint):
10357 (WebCore::InspectorDebuggerAgent::removeJavaScriptBreakpoint):
10358 (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
10359 (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
10360 (WebCore::InspectorDebuggerAgent::currentCallFrames):
10361 (WebCore::InspectorDebuggerAgent::didParseSource):
10362 (WebCore::InspectorDebuggerAgent::clear):
10363 * inspector/InspectorDebuggerAgent.h:
10364 (WebCore::InspectorDebuggerAgent::enable):
10365 (WebCore::InspectorDebuggerAgent::disable):
10366 (WebCore::InspectorDebuggerAgent::Listener::~Listener):
10367 (WebCore::InspectorDebuggerAgent::setListener):
10368 * inspector/InspectorInstrumentation.cpp:
10369 (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
10370 (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
10371 (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
10372 (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
10373 (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
10374 (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
10375 (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
10376 * inspector/front-end/DebuggerModel.js:
10377 (WebInspector.DebuggerModel.prototype.enableDebugger):
10378 (WebInspector.DebuggerModel.prototype.disableDebugger):
10379
10380 2011-02-28 Renata Hodovan <reni@webkit.org>
10381
10382 Reviewed by Andreas Kling.
10383
10384 FECompositeElement changes doesn't require relayout.
10385 https://bugs.webkit.org/show_bug.cgi?id=55367
10386
10387 When the FECompositeElement receives an update message but the given val ue remains the same we don't need
10388 to relayout the filter.
10389
10390 No new tests are needed because this modification is covered by the dyna mic update tests of FEComposite.
10391
10392 * platform/graphics/filters/FEComposite.cpp:
10393 (WebCore::FEComposite::setOperation):
10394 (WebCore::FEComposite::setK1):
10395 (WebCore::FEComposite::setK2):
10396 (WebCore::FEComposite::setK3):
10397 (WebCore::FEComposite::setK4):
10398 * platform/graphics/filters/FEComposite.h:
10399 * svg/SVGFECompositeElement.cpp:
10400 (WebCore::SVGFECompositeElement::setFilterEffectAttribute):
10401 (WebCore::SVGFECompositeElement::svgAttributeChanged):
10402 * svg/SVGFECompositeElement.h:
10403
10404 2011-02-28 Andreas Kling <kling@webkit.org>
10405
10406 Reviewed by Kenneth Rohde Christiansen.
10407
10408 FrameLoader: Reorder early-returns in checkCompleted()
10409 https://bugs.webkit.org/show_bug.cgi?id=55366
10410
10411 Check allChildrenAreComplete() last, since it's the most expensive.
10412
10413 * loader/FrameLoader.cpp:
10414 (WebCore::FrameLoader::checkCompleted):
10415
10416 2011-02-28 Ryosuke Niwa <rniwa@webkit.org>
10417
10418 Reviewed by Kent Tamura.
10419
10420 Range::processContents needs cleanup
10421 https://bugs.webkit.org/show_bug.cgi?id=51006
10422
10423 Refactored Range::processContents. Extracted childOfCommonRootBeforeOff set from processContents
10424 which is used to find processStart and processEnd respectively. In the case of processStart,
10425 we use the next sibling of the node returned by childOfCommonRootBeforeO ffset when m_start is not
10426 the common root because copying m_start's ancestors will result in proce ssing too much contents.
10427
10428 Also extracted processNodes and deleteCharacterData from processContents and processContentsBetweenOffsets.
10429
10430 In addition, lengthOfContentsInNode was modified to return the correct l ength instead of
10431 numeric_limits<unsigned>::max() because the convention that processConte ntsBetweenOffsets automatically
10432 corrects the length when endOffset is numeric_limits<unsigned>::max() se emed more confusing than
10433 having two switch statements that need to be consistent.
10434
10435 Historically, lengthOfContentsInNode was introduced in r78413 as a build fix because unsigned const
10436 LengthOfContentsInNode added in r78409 violated WebKit C++ rules and cau sed build failures on Mac and
10437 other ports.
10438
10439 * dom/Range.cpp:
10440 (WebCore::childOfCommonRootBeforeOffset): Extracted from processContents .
10441 (WebCore::lengthOfContentsInNode): Added.
10442 (WebCore::Range::processContents): Calls childOfCommonRootBeforeOffset, lengthOfContentsInNode,
10443 and processNodes.
10444 (WebCore::deleteCharacterData): Added.
10445 (WebCore::Range::processContentsBetweenOffsets): Calls deleteCharacterDa ta and processNodes.
10446 (WebCore::Range::processNodes): Extracted from processContents and proce ssContentsBetweenOffsets.
10447 (WebCore::Range::processAncestorsAndTheirSiblings):
10448 * dom/Range.h:
10449
10450 2011-02-28 Pavel Feldman <pfeldman@chromium.org>
10451
10452 Not reviewed. Test harness change follow up.
10453 Consider missing localized string a warning, not an error in the front-e nd.
10454
10455 * inspector/front-end/inspector.js:
10456 (WebInspector.UIString):
10457
10458 2011-02-28 Steve Block <steveblock@google.com>
10459
10460 Reviewed by Jeremy Orlow.
10461
10462 getJNIEnv() passes wrong type to AttachCurrentThread() for JNIEnv argume nt on Android
10463 https://bugs.webkit.org/show_bug.cgi?id=55218
10464
10465 AttachCurrentThread() in Android's JVM takes a JINEnv**
10466 argument.
10467
10468 No new tests, build fix only.
10469
10470 * bridge/jni/JNIUtility.cpp:
10471 (JSC::Bindings::getJNIEnv):
10472
10473 2011-02-28 Renata Hodovan <reni@webkit.org>
10474
10475 Reviewed by Andreas Kling.
10476
10477 FETurbulenceElement changes doesn't require relayout
10478 https://bugs.webkit.org/show_bug.cgi?id=55141
10479
10480 When the FETurbulenceElement receives an update message but the given va lue remains the same we don't need
10481 to relayout the filter.
10482 Besides fix a typo in FETurbulence and change the paramterer type of FET urbulence::setNumOctaves from bool
10483 to int according to the spec.
10484
10485 No new tests are needed because this modification is covered by the dyna mic update tests of FETurbulence.
10486
10487 * platform/graphics/filters/FETurbulence.cpp:
10488 (WebCore::FETurbulence::FETurbulence):
10489 (WebCore::FETurbulence::create):
10490 (WebCore::FETurbulence::type):
10491 (WebCore::FETurbulence::setType):
10492 (WebCore::FETurbulence::setBaseFrequencyY):
10493 (WebCore::FETurbulence::setBaseFrequencyX):
10494 (WebCore::FETurbulence::setSeed):
10495 (WebCore::FETurbulence::setNumOctaves):
10496 (WebCore::FETurbulence::setStitchTiles):
10497 (WebCore::operator<<):
10498 * platform/graphics/filters/FETurbulence.h:
10499 * svg/SVGFETurbulenceElement.cpp:
10500 (WebCore::SVGFETurbulenceElement::setFilterEffectAttribute):
10501 (WebCore::SVGFETurbulenceElement::svgAttributeChanged):
10502 (WebCore::SVGFETurbulenceElement::build):
10503 * svg/SVGFETurbulenceElement.h:
10504
10505 2011-02-28 Pavel Feldman <pfeldman@chromium.org>
10506
10507 Reviewed by Yury Semikhatsky.
10508
10509 WebInspector: InspectorAgent calls offsetWidth in the middle of painting
10510 https://bugs.webkit.org/show_bug.cgi?id=54597
10511
10512 * inspector/InspectorAgent.cpp:
10513 (WebCore::InspectorAgent::drawElementTitle):
10514
10515 2011-02-28 Roland Steiner <rolandsteiner@chromium.org>
10516
10517 Reviewed by Kent Tamura.
10518
10519 Bug 55355 - TextIterator should not be a friend of RenderTextControl
10520 https://bugs.webkit.org/show_bug.cgi?id=55355
10521
10522 Remove need for 'friend' clause by making innerTextElement() public.
10523
10524 No new tests. (simple refactoring)
10525
10526 * rendering/RenderTextControl.h:
10527
10528 2011-02-27 Patrick Gansterer <paroga@webkit.org>
10529
10530 Reviewed by Darin Adler.
10531
10532 Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecWi nCE
10533 https://bugs.webkit.org/show_bug.cgi?id=55317
10534
10535 This functions are obsolete, since r78499 added TextCodecUTF8.
10536 Also remove the "fast path" for UTF-8 data, because we now have a separa te TextCodec.
10537
10538 * platform/text/TextEncodingRegistry.cpp:
10539 (WebCore::buildBaseTextCodecMaps):
10540 * platform/text/wince/TextCodecWinCE.cpp:
10541 * platform/text/wince/TextCodecWinCE.h:
10542
10543 2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
10544
10545 Reviewed by Sam Weinig.
10546
10547 Use OwnPtr to handle the memory of RenderBlock::m_floatingObjects and Re nderBlock::m_positionedObjects
10548 https://bugs.webkit.org/show_bug.cgi?id=55327
10549
10550 Refactor RenderBlock to use OwnPtr for m_floatingObjects and m_positione dObjects so we do not have
10551 to release the memory manually.
10552
10553 * rendering/RenderBlock.cpp:
10554 (WebCore::RenderBlock::~RenderBlock):
10555 (WebCore::RenderBlock::selectionGaps):
10556 (WebCore::RenderBlock::insertPositionedObject):
10557 (WebCore::RenderBlock::insertFloatingObject):
10558 (WebCore::RenderBlock::addOverhangingFloats):
10559 (WebCore::RenderBlock::addIntrudingFloats):
10560 * rendering/RenderBlock.h:
10561 (WebCore::RenderBlock::positionedObjects):
10562
10563 2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
10564
10565 Reviewed by Andreas Kling.
10566
10567 Eliminate DeprecatedPtrList
10568 https://bugs.webkit.org/show_bug.cgi?id=17425
10569
10570 Remove the implementation of DeprecatedPtrList and all its references
10571 from the build systems.
10572
10573 * Android.mk:
10574 * CMakeLists.txt:
10575 * GNUmakefile.am:
10576 * WebCore.gypi:
10577 * WebCore.order:
10578 * WebCore.pro:
10579 * WebCore.vcproj/WebCore.vcproj:
10580 * WebCore.xcodeproj/project.pbxproj:
10581 * platform/DeprecatedPtrList.h: Removed.
10582 * platform/DeprecatedPtrListImpl.cpp: Removed.
10583 * platform/DeprecatedPtrListImpl.h: Removed.
10584
10585 2011-02-27 Andreas Kling <kling@webkit.org>
10586
10587 Reviewed by Kenneth Rohde Christiansen.
10588
10589 [Qt] Use WTF ref counting for FontPlatformDataPrivate
10590 https://bugs.webkit.org/show_bug.cgi?id=55303
10591
10592 Make FontPlatformDataPrivate a RefCounted<FPDP>.
10593 Incidentally fixes an uninitialized member bug in FontPlatformData().
10594
10595 * platform/graphics/qt/FontPlatformData.h:
10596 (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
10597 (WebCore::FontPlatformData::FontPlatformData):
10598 (WebCore::FontPlatformData::isHashTableDeletedValue):
10599 (WebCore::FontPlatformData::font):
10600 (WebCore::FontPlatformData::size):
10601 (WebCore::FontPlatformData::family):
10602 (WebCore::FontPlatformData::bold):
10603 (WebCore::FontPlatformData::italic):
10604 (WebCore::FontPlatformData::smallCaps):
10605 (WebCore::FontPlatformData::pixelSize):
10606 * platform/graphics/qt/FontPlatformDataQt.cpp:
10607 (WebCore::toQFontWeight):
10608 (WebCore::FontPlatformData::operator==):
10609 (WebCore::FontPlatformData::hash):
10610
10611 2011-02-27 Benjamin Poulain <ikipou@gmail.com>
10612
10613 Reviewed by Darin Adler.
10614
10615 Eliminate DeprecatedPtrList from RenderBlock
10616 https://bugs.webkit.org/show_bug.cgi?id=54972
10617
10618 Refactor RenderBlock to get rid of the DeprecatedPtrList.
10619 The floating objects are stored in a ListHashSet.
10620
10621 Refactoring covered by existing test.
10622
10623 * rendering/RenderBlock.cpp:
10624 (WebCore::RenderBlock::~RenderBlock):
10625 (WebCore::RenderBlock::addOverflowFromFloats):
10626 (WebCore::RenderBlock::repaintOverhangingFloats):
10627 (WebCore::RenderBlock::paintFloats):
10628 (WebCore::RenderBlock::selectionGaps):
10629 (WebCore::RenderBlock::insertFloatingObject):
10630 (WebCore::RenderBlock::removeFloatingObject):
10631 (WebCore::RenderBlock::removeFloatingObjectsBelow):
10632 (WebCore::RenderBlock::positionNewFloats):
10633 (WebCore::RenderBlock::positionNewFloatOnLine):
10634 (WebCore::RenderBlock::logicalLeftOffsetForLine):
10635 (WebCore::RenderBlock::logicalRightOffsetForLine):
10636 (WebCore::RenderBlock::nextFloatLogicalBottomBelow):
10637 (WebCore::RenderBlock::lowestFloatLogicalBottom):
10638 (WebCore::RenderBlock::clearFloats):
10639 (WebCore::RenderBlock::addOverhangingFloats):
10640 (WebCore::RenderBlock::addIntrudingFloats):
10641 (WebCore::RenderBlock::containsFloat):
10642 (WebCore::RenderBlock::hitTestFloats):
10643 (WebCore::RenderBlock::adjustForBorderFit):
10644 * rendering/RenderBlock.h:
10645 (WebCore::RenderBlock::FloatingObjectHashFunctions::hash):
10646 (WebCore::RenderBlock::FloatingObjectHashFunctions::equal):
10647 (WebCore::RenderBlock::FloatingObjectHashTranslator::hash):
10648 (WebCore::RenderBlock::FloatingObjectHashTranslator::equal):
10649 * rendering/RenderBlockLineLayout.cpp:
10650 (WebCore::RenderBlock::layoutInlineChildren):
10651 (WebCore::RenderBlock::matchedEndLine):
10652
10653 2011-02-26 Adam Barth <abarth@webkit.org>
10654
10655 Reviewed by Eric Seidel.
10656
10657 <input value="type=submit"> throws a warning (“HTML parse error”)
10658 https://bugs.webkit.org/show_bug.cgi?id=55120
10659
10660 This patch removes parse error messages from the HTML parser. These
10661 messages are displayed at the wrong times, aren't tested, and aren't
10662 helpful. We'll try again with some more informative messages and
10663 better testing.
10664
10665 * html/parser/HTMLTreeBuilder.cpp:
10666 (WebCore::HTMLTreeBuilder::parseError):
10667
10668 2011-02-26 Patrick Gansterer <paroga@webkit.org>
10669
10670 Reviewed by Alexey Proskuryakov.
10671
10672 Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecBr ew
10673 https://bugs.webkit.org/show_bug.cgi?id=55309
10674
10675 This functions are obsolete, since r78499 added TextCodecUTF8.
10676
10677 * platform/text/TextEncodingRegistry.cpp:
10678 (WebCore::buildBaseTextCodecMaps):
10679 * platform/text/brew/TextCodecBrew.cpp:
10680 * platform/text/brew/TextCodecBrew.h:
10681
10682 2011-02-26 Justin Schuh <jschuh@chromium.org>
10683
10684 Reviewed by Darin Adler.
10685
10686 Delay firing of mutation events while setting attribute values
10687 https://bugs.webkit.org/show_bug.cgi?id=55199
10688
10689 Test: fast/dom/attribute-change-on-mutate.html
10690
10691 * dom/Attr.cpp:
10692 (WebCore::Attr::setValue):
10693
10694 2011-02-26 Yi Shen <yi.4.shen@nokia.com>
10695
10696 Reviewed by Andreas Kling.
10697
10698 [Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed
10699 https://bugs.webkit.org/show_bug.cgi?id=55252
10700
10701 Need to invoke a callback function to notify the HTMLMediaElement
10702 when MediaPlayerPrivateQt's playback state gets changed.
10703
10704 * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
10705 (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): Set a flag to ign ore the playback state change for pre-roll
10706 (WebCore::MediaPlayerPrivateQt::commitLoad): Call playbackStateChanged() to notify HTMLMediaElement
10707 (WebCore::MediaPlayerPrivateQt::stateChanged):
10708 * platform/graphics/qt/MediaPlayerPrivateQt.h:
10709
10710 2011-02-25 Abhishek Arya <inferno@chromium.org>
10711
10712 Reviewed by Adam Barth.
10713
10714 When plugin document parser finishes parsing, it runs the raw
10715 document's parser finish functions which call the pending document
10716 onload events that removes the frame from underneath. So, we protect
10717 frame (and hence frameloader) in DocumentLoader::commitLoad.
10718 https://bugs.webkit.org/show_bug.cgi?id=55289
10719
10720 Test: fast/frames/iframe-plugin-load-remove-document-crash.html
10721
10722 * loader/DocumentLoader.cpp:
10723 (WebCore::DocumentLoader::commitLoad):
10724
10725 2011-02-26 Pavel Feldman <pfeldman@chromium.org>
10726
10727 Not reviewed: rolling out 79799 and 79804 for breaking xml tests on mac.
10728
10729 2011-02-26 Pavel Feldman <pfeldman@chromium.org>
10730
10731 Not reviewed: follow up to r79799. Fixing WinCE+Efl, mute new tests on Q t.
10732 https://bugs.webkit.org/show_bug.cgi?id=55302
10733
10734 * CMakeLists.txt:
10735
10736 2011-02-25 Vsevolod Vlasov <vsevik@chromium.org>
10737
10738 Reviewed by Pavel Feldman.
10739
10740 XML without style should render as syntax-highlighted source.
10741 https://bugs.webkit.org/show_bug.cgi?id=13807
10742
10743 XML tree view mode implemented. If XML does not have any style
10744 information, it is rendered as highlighted source with collapsable
10745 elements.
10746
10747 Tests: http/tests/xmlviewer/dumpAsText/css-stylesheet.xml
10748 http/tests/xmlviewer/dumpAsText/frames.html
10749 http/tests/xmlviewer/dumpAsText/mathml.xml
10750 http/tests/xmlviewer/dumpAsText/svg.xml
10751 http/tests/xmlviewer/dumpAsText/wml.xml
10752 http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
10753 http/tests/xmlviewer/dumpAsText/xlink.xml
10754 http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
10755 http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
10756 http/tests/xmlviewer/dumpAsText/xmlviewer.xml
10757 http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
10758 http/tests/xmlviewer/dumpAsText/xul.xml
10759
10760 * CMakeLists.txt:
10761 * DerivedSources.make:
10762 * GNUmakefile.am:
10763 * WebCore.gyp/WebCore.gyp:
10764 * WebCore.gypi:
10765 * WebCore.vcproj/WebCore.vcproj:
10766 * WebCore.xcodeproj/project.pbxproj:
10767 * css/CSSStyleSelector.cpp:
10768 (WebCore::CSSStyleSelector::matchUARules):
10769 * dom/Document.cpp:
10770 (WebCore::Document::Document):
10771 (WebCore::Document::createElement):
10772 * dom/Document.h:
10773 (WebCore::Document::usesViewSourceStyles):
10774 (WebCore::Document::setUsesViewSourceStyles):
10775 (WebCore::Document::sawElementsInKnownNamespaces):
10776 * dom/XMLDocumentParser.h:
10777 * dom/XMLDocumentParserLibxml2.cpp:
10778 (WebCore::XMLDocumentParser::XMLDocumentParser):
10779 (WebCore::XMLDocumentParser::processingInstruction):
10780 (WebCore::XMLDocumentParser::initializeParserContext):
10781 (WebCore::XMLDocumentParser::doEnd):
10782 * dom/XMLDocumentParserQt.cpp:
10783 (WebCore::XMLDocumentParser::XMLDocumentParser):
10784 (WebCore::XMLDocumentParser::initializeParserContext):
10785 (WebCore::XMLDocumentParser::parseProcessingInstruction):
10786 * html/HTMLViewSourceDocument.cpp:
10787 (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
10788 * xml/XMLTreeViewer.cpp: Added.
10789 (WebCore::XMLTreeViewer::XMLTreeViewer):
10790 (WebCore::XMLTreeViewer::hasNoStyleInformation):
10791 (WebCore::XMLTreeViewer::transformDocumentToTreeView):
10792 * xml/XMLTreeViewer.h: Added.
10793 (WebCore::XMLTreeViewer::~XMLTreeViewer):
10794 * xml/XMLViewer.xsl: Added.
10795 * xml/XSLStyleSheet.h:
10796 (WebCore::XSLStyleSheet::createFromString):
10797
10798 2011-02-26 Andreas Kling <kling@webkit.org>
10799
10800 Reviewed by Kenneth Rohde Christiansen.
10801
10802 [Qt] Enable usage of synchronous HTTP feature in Qt
10803 https://bugs.webkit.org/show_bug.cgi?id=37191
10804
10805 Currently, we spin an event loop when doing synchronous calls to
10806 wait for completion. This patch uses synchronous requests in Qt,
10807 if available, and spins the event loop as a fallback solution.
10808
10809 Based on work by Simon Hausmann and Peter Hartmann.
10810
10811 * platform/network/qt/QNetworkReplyHandler.cpp:
10812 (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
10813 (WebCore::QNetworkReplyHandler::start):
10814 * platform/network/qt/QNetworkReplyHandler.h:
10815 * platform/network/qt/ResourceHandleQt.cpp:
10816 (WebCore::WebCoreSynchronousLoader::setReplyFinished):
10817 (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
10818 (WebCore::WebCoreSynchronousLoader::didFinishLoading):
10819 (WebCore::WebCoreSynchronousLoader::didFail):
10820 (WebCore::ResourceHandle::loadResourceSynchronously):
10821
10822 2011-02-26 Ryosuke Niwa <rniwa@webkit.org>
10823
10824 Reviewed by Kent Tamura.
10825
10826 REGRESSION(r79398): Webkit crash on dojo theme tester page
10827 https://bugs.webkit.org/show_bug.cgi?id=55290
10828
10829 The bug was caused by selectionStartCSSPropertyValue's not considering t he possibility
10830 of selectionStartStyle() returning a null pointer. Fixed it by adding a null check.
10831
10832 Test: editing/execCommand/value-without-selection-crash.html
10833
10834 * editing/Editor.cpp:
10835 (WebCore::Editor::selectionStartCSSPropertyValue):
10836
10837 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
10838
10839 Reviewed by Pavel Feldman.
10840
10841 DumpRenderTree should reset frame opener between tests.
10842 https://bugs.webkit.org/show_bug.cgi?id=54874
10843
10844 No new tests. (no code affected, just exporting a method for DumpRenderT ree use)
10845
10846 * WebCore.exp.in:
10847
10848 2011-02-26 Jia Pu <jpu@apple.com>
10849
10850 Reviewed by Dan Bernstein.
10851
10852 On Mac, need to remove misspell underline in Editor::learnSpelling().
10853 https://bugs.webkit.org/show_bug.cgi?id=55251
10854
10855 This change makes sure that the misspelling markers are removed after th e word is learned.
10856
10857 * editing/Editor.cpp:
10858 (WebCore::Editor::learnSpelling):
10859
10860 2011-02-26 Rik Cabanier <cabanier@adobe.com>
10861
10862 Reviewed by David Hyatt.
10863
10864 Fix that allows fixed length values to be floating point
10865 https://bugs.webkit.org/show_bug.cgi?id=52699
10866
10867 Transitions now return matrices in floating point. 2 of the transition t ests were failing
10868 because they expected integer values.
10869
10870 * WebCore.xcodeproj/project.pbxproj:
10871 * css/CSSStyleSelector.cpp:
10872 (WebCore::convertToLength):
10873 (WebCore::convertToIntLength):
10874 (WebCore::convertToFloatLength):
10875 (WebCore::CSSStyleSelector::applyProperty):
10876 (WebCore::CSSStyleSelector::createTransformOperations):
10877 * platform/Length.h:
10878 (WebCore::Length::Length):
10879 (WebCore::Length::operator==):
10880 (WebCore::Length::operator!=):
10881 (WebCore::Length::rawValue):
10882 (WebCore::Length::type):
10883 (WebCore::Length::quirk):
10884 (WebCore::Length::setValue):
10885 (WebCore::Length::calcFloatValue):
10886 (WebCore::Length::isZero):
10887 (WebCore::Length::blend):
10888 (WebCore::Length::getIntValue):
10889 (WebCore::Length::getFloatValue):
10890 * rendering/AutoTableLayout.cpp:
10891 (WebCore::AutoTableLayout::recalcColumn):
10892 (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
10893 * rendering/FixedTableLayout.cpp:
10894 (WebCore::FixedTableLayout::calcWidthArray):
10895
10896 2011-02-26 Eric Seidel <eric@webkit.org>
10897
10898 Reviewed by Maciej Stachowiak.
10899
10900 malloc in removeChildren shows up on profile of peacekeeper domDynamicCr eationCreateElement
10901 https://bugs.webkit.org/show_bug.cgi?id=55204
10902
10903 * dom/ContainerNode.cpp:
10904 (WebCore::ContainerNode::removeChildren):
10905 - Using an inlineCapacity of 10 for now. We may want to tweak it later.
10906 - This removes yet another malloc from code which removes nodes (which is rather common).
10907
10908 2011-02-26 Eric Seidel <eric@webkit.org>
10909
10910 Reviewed by Maciej Stachowiak.
10911
10912 HashSet<T>::end() creation is expensive and should be avoided
10913 https://bugs.webkit.org/show_bug.cgi?id=55205
10914
10915 In the common case, m_ranges is an empty set. When that's
10916 the case, we spend all our time in skipEmptyBuckets, walking
10917 the hash storage skipping over empty buckets.
10918
10919 This looks to be at least a 5% speedup on (my local version of) peacekee per's domDynamicCreationCreateElement.
10920
10921 Before:
10922 avg 383.6666666666667
10923 median 386
10924 stdev 7.152311203768722
10925 min 360
10926 max 391
10927
10928 After:
10929 avg 366.3333333333333
10930 median 366
10931 stdev 2.712112747574399
10932 min 362
10933 max 377
10934
10935 * dom/Document.cpp:
10936 (WebCore::Document::nodeChildrenChanged):
10937 (WebCore::Document::nodeChildrenWillBeRemoved):
10938 (WebCore::Document::nodeWillBeRemoved):
10939 (WebCore::Document::textInserted):
10940 (WebCore::Document::textRemoved):
10941 (WebCore::Document::textNodesMerged):
10942 (WebCore::Document::textNodeSplit):
10943
10944 2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
10945
10946 Unreviewed, rolling out r79764.
10947 http://trac.webkit.org/changeset/79764
10948 https://bugs.webkit.org/show_bug.cgi?id=55295
10949
10950 "broke Chromium builds" (Requested by rniwa on #webkit).
10951
10952 * WebCore.exp.in:
10953
10954 2011-02-26 Adam Klein <adamk@chromium.org>
10955
10956 Reviewed by Adam Barth.
10957
10958 [fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase
10959 https://bugs.webkit.org/show_bug.cgi?id=54585
10960
10961 In order to move toURI to EntryBase, it needed access to
10962 SecurityOrigin. Most of the changes below were to pass a
10963 ScriptExecutionContext to DOMFileSystemBase to enable this.
10964
10965 Test: fast/filesystem/workers/file-entry-to-uri-sync.html
10966
10967 * WebCore.gypi:
10968 * WebCore.xcodeproj/project.pbxproj:
10969 * fileapi/DOMFileSystem.cpp:
10970 (WebCore::DOMFileSystem::DOMFileSystem):
10971 * fileapi/DOMFileSystemBase.cpp:
10972 (WebCore::DOMFileSystemBase::DOMFileSystemBase):
10973 (WebCore::DOMFileSystemBase::securityOrigin):
10974 * fileapi/DOMFileSystemBase.h:
10975 (WebCore::DOMFileSystemBase::create):
10976 * fileapi/DOMFileSystemSync.cpp:
10977 (WebCore::DOMFileSystemSync::create):
10978 (WebCore::DOMFileSystemSync::DOMFileSystemSync):
10979 * fileapi/DOMFileSystemSync.h:
10980 (WebCore::DOMFileSystemSync::create):
10981 * fileapi/Entry.cpp:
10982 * fileapi/Entry.h:
10983 * fileapi/EntryBase.cpp: Added.
10984 (WebCore::EntryBase::EntryBase):
10985 (WebCore::EntryBase::~EntryBase):
10986 (WebCore::EntryBase::toURI):
10987 * fileapi/EntryBase.h:
10988 * fileapi/EntrySync.idl:
10989
10990 2011-02-26 Alice Boxhall <aboxhall@chromium.org>
10991
10992 Reviewed by Ojan Vafai.
10993
10994 typing enter in the input element should not fire textInput
10995 https://bugs.webkit.org/show_bug.cgi?id=54152
10996
10997 Stop textInput event propagation in HTMLInputElement::preDispatchEventHa ndler if the event target should submit implicitly.
10998
10999 Test: fast/forms/textinput-not-fired-on-enter-in-input.html
11000
11001 * html/HTMLInputElement.cpp:
11002 (WebCore::HTMLInputElement::preDispatchEventHandler): Check m_inputType- >shouldSubmitImplicitly for textInputEvents and stop propagation if true.
11003
11004 2011-02-26 James Simonsen <simonjam@chromium.org>
11005
11006 Reviewed by Tony Gentilcore.
11007
11008 [Web Timing] loadEvent timing should refer to first load event if there are many
11009 https://bugs.webkit.org/show_bug.cgi?id=55201
11010
11011 Test: fast/dom/webtiming-document-open.html
11012
11013 * page/DOMWindow.cpp:
11014 (WebCore::DOMWindow::dispatchLoadEvent):
11015
11016 2011-02-26 Tony Gentilcore <tonyg@chromium.org>
11017
11018 Reviewed by Adam Barth.
11019
11020 Fix isLayoutTimerActive for ports that set a minimumLayoutDelay
11021 https://bugs.webkit.org/show_bug.cgi?id=54810
11022
11023 No new tests because no new functionality.
11024
11025 * dom/Document.cpp:
11026 (WebCore::Document::isLayoutTimerActive): Moved from HTMLParserScheduler per FIXME. Compare
11027 minimumLayoutDelay() to m_extraLayoutDelay instead of 0. This spirit of this comparison was
11028 broken by r52919. The effect would be that ports that set an extra layou t delay can't yield
11029 between tokens. Note: can't be const because minimumLayoutDelay sets a m ember.
11030 * dom/Document.h:
11031 * html/parser/HTMLParserScheduler.cpp:
11032 (WebCore::HTMLParserScheduler::continueNextChunkTimerFired):
11033 (WebCore::HTMLParserScheduler::checkForYieldBeforeScript):
11034
11035 2011-02-26 David Dorwin <ddorwin@chromium.org>
11036
11037 Reviewed by Darin Fisher.
11038
11039 Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled b y default.
11040
11041 fullscreen javascript bindings not implemented for v8
11042 https://bugs.webkit.org/show_bug.cgi?id=44797
11043
11044 Tested by the existing fullscreen Layout Tests.
11045
11046 * WebCore.gyp/WebCore.gyp:
11047 * WebCore.gypi:
11048
11049 2011-02-26 Tony Gentilcore <tonyg@chromium.org>
11050
11051 Reviewed by Adam Barth.
11052
11053 Prevent parser yields from triggering early dumpAsText()
11054 https://bugs.webkit.org/show_bug.cgi?id=55187
11055
11056 DRT's dumpAsText() takes a snapshot when DocumentLoader::isLoadingInAPIS ense()
11057 indicates the page is done. isLoadingInAPISense depends on
11058 HTMLDocumentParser::isProcessingData(), which just checks if the parser is in an
11059 insert() or append().
11060
11061 This means that if the parser is pumping in a resumeParsingAfterScriptEx ecution() or
11062 resumeParsingAfterYield(), isLoadingInAPISense() may not be blocked. Thi s patch
11063 fixes that by repurposing m_writeNestingLevel as m_pumpSessionNestingLev el and
11064 incrementing it in pumpTokenizer().
11065
11066 When I locally cause the parser to yield after every token, a lot of tes ts fail
11067 because DRT snapshots too early. This patch fixes those tests, however I 'm having
11068 trouble writing a test case that reliably reproduces the problem without this patch
11069 and passes with it (without changing yield constants). This is because i t requires
11070 4,096 tokens in a single pump session to yield and (len('<b>' * 4096 = 1 2k, which
11071 doesn't always happen).
11072
11073 * html/parser/HTMLDocumentParser.cpp:
11074 (WebCore::HTMLDocumentParser::HTMLDocumentParser):
11075 (WebCore::HTMLDocumentParser::~HTMLDocumentParser):
11076 (WebCore::HTMLDocumentParser::processingData):
11077 (WebCore::HTMLDocumentParser::pumpTokenizer):
11078 (WebCore::HTMLDocumentParser::insert):
11079 (WebCore::HTMLDocumentParser::append):
11080 * html/parser/HTMLDocumentParser.h:
11081 (WebCore::HTMLDocumentParser::inPumpSession):
11082 (WebCore::HTMLDocumentParser::shouldDelayEnd):
11083 * html/parser/HTMLParserScheduler.h:
11084 (WebCore::PumpSession::PumpSession):
11085 * html/parser/NestingLevelIncrementer.h:
11086
11087 2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>
11088
11089 Reviewed by David Kilzer.
11090
11091 https://bugs.webkit.org/show_bug.cgi?id=48781
11092
11093 Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
11094
11095 Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
11096 should paint the default broken image when an image fails to load or dec ode. The method also passes the
11097 URL of the failed image.
11098
11099 Test: fast/images/support-broken-image-delegate.html
11100
11101 * loader/FrameLoaderClient.h:
11102 (WebCore::FrameLoaderClient::shouldPaintBrokenImage):
11103 * loader/cache/CachedImage.cpp:
11104 (WebCore::CachedImage::CachedImage):
11105 (WebCore::CachedImage::image):
11106 (WebCore::CachedImage::checkShouldPaintBrokenImage):
11107 (WebCore::CachedImage::error):
11108 * loader/cache/CachedImage.h:
11109
11110 2011-02-26 Chris Evans <cevans@chromium.org>
11111
11112 Reviewed by Adam Barth.
11113
11114 Database: Data race: should only touch the transaction queue inside the
11115 lock.
11116 https://bugs.webkit.org/show_bug.cgi?id=55031
11117
11118 * storage/Database.cpp:
11119 (WebCore::Database::changeVersion): only touch queue inside lock.
11120 (WebCore::Database::runTransaction): only touch queue inside lock.
11121
11122 2011-02-26 Yi Shen <yi.4.shen@nokia.com>
11123
11124 Reviewed by Eric Carlson.
11125
11126 Missing volumechangeEvent in case of mediaPlayerVolumeChanged gets callb ack
11127 https://bugs.webkit.org/show_bug.cgi?id=55147
11128
11129 When HTMLMediaElement::mediaPlayerVolumeChanged() gets callback,
11130 a volumechangeEvent event should be fired if the volume gets changed.
11131
11132 Test: media/event-attributes.html
11133
11134 * html/HTMLMediaElement.cpp:
11135 (WebCore::HTMLMediaElement::setMuted): Remove updateVolume() since it do es nothing when m_player is 0.
11136 (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): Fire a volumechan geEvent when the volume is changed.
11137
11138 2011-02-26 Eric Seidel <eric@webkit.org>
11139
11140 Reviewed by Maciej Stachowiak.
11141
11142 disableRangeMutation quirk for mail slows down peacekeeper domDynamicCre ationCreateElement
11143 https://bugs.webkit.org/show_bug.cgi?id=55127
11144
11145 Before:
11146 avg 513.4
11147 median 515
11148 stdev 7.234638899074368
11149 min 490
11150 max 528
11151
11152 After:
11153 avg 508.15
11154 median 510
11155 stdev 6.966168243733426
11156 min 485
11157 max 515
11158
11159 Yes, the stdev is a bit high to actually support my conclusions. But lo oking
11160 at the profile, this change makes a lot of sense. I'll up the iteration s
11161 for future testing.
11162
11163 * dom/Document.cpp:
11164 (WebCore::disableRangeMutation):
11165 - This check should only be compiled in if we're planning to run on Tig er or Leopard.
11166
11167 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
11168
11169 Reviewed by Pavel Feldman.
11170
11171 DumpRenderTree should reset frame opener between tests.
11172 https://bugs.webkit.org/show_bug.cgi?id=54874
11173
11174 No new tests. (no code affected, just exporting a method for DumpRenderT ree use)
11175
11176 * WebCore.exp.in:
11177
11178 2011-02-26 Chang Shu <chang.shu@nokia.com>
11179
11180 Reviewed by Antonio Gomes.
11181
11182 Based on patch by Carlos Garcia Campos <cgarcia@igalia.com>.
11183
11184 Spatial Navigation: Add support for <select> element in multiple selecti on mode
11185 https://bugs.webkit.org/show_bug.cgi?id=49261
11186
11187 When spatial navigation is enabled, use space key to toggle select
11188 items. And the up and down keys should not affect selection but just
11189 navigate through items, which is indicated visually by a focus ring.
11190
11191 New Test: fast/spatial-navigation/snav-single-select-list.html
11192 Enhanced Test: fast/spatial-navigation/snav-multiple-select.html
11193
11194 * dom/SelectElement.cpp:
11195 (WebCore::SelectElement::listBoxDefaultEventHandler):
11196 * rendering/RenderListBox.cpp:
11197 (WebCore::RenderListBox::addFocusRingRects):
11198 * rendering/RenderListBox.h:
11199
11200 2011-02-25 Ryosuke Niwa <rniwa@webkit.org>
11201
11202 Unreviewed Qt build fix; included CSSValueList.h in EditingStyle.cpp.
11203
11204 * editing/EditingStyle.cpp:
11205
11206 2011-02-25 Ryosuke Niwa <rniwa@webkit.org>
11207
11208 Reviewed by Darin Adler.
11209
11210 Move HTMLEquivalent and its subclasses to EditingStyle
11211 https://bugs.webkit.org/show_bug.cgi?id=55207
11212
11213 Moved HTMLEquivalent and its subclasses from ApplyStyleCommand to Editin gStyle,
11214 and renamed HTMLEquivalent, HTMLEquivalentValueList, HTMLAttributeEquiva lent,
11215 and HTMLEquivalentFontSizeAttribute to HTMLElementEquivalent, HTMLTextDe corationEquivalent,
11216 HTMLAttributeEquivalent, and HTMLFontSizeEquivalent respectively.
11217
11218 Also extracted the logic to determine which element and attribute are re moved
11219 as conflictsWithImplicitStyleOfElement, conflictsWithImplicitStyleOfAttr ibutes,
11220 and extractConflictingImplicitStyleOfAttributes.
11221
11222 * editing/ApplyStyleCommand.cpp:
11223 (WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
11224 (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
11225 * editing/ApplyStyleCommand.h:
11226 * editing/EditingStyle.cpp:
11227 (WebCore::HTMLElementEquivalent::create): Moved from ApplyStyleCommand.c pp.
11228 (WebCore::HTMLElementEquivalent::~HTMLElementEquivalent): Ditto.
11229 (WebCore::HTMLElementEquivalent::matches): Ditto.
11230 (WebCore::HTMLElementEquivalent::hasAttribute): Ditto.
11231 (WebCore::HTMLElementEquivalent::propertyExistsInStyle): Ditto.
11232 (WebCore::HTMLElementEquivalent::HTMLElementEquivalent): Ditto.
11233 (WebCore::HTMLElementEquivalent::valueIsPresentInStyle): Ditto.
11234 (WebCore::HTMLElementEquivalent::addToStyle): Ditto.
11235 (WebCore::HTMLTextDecorationEquivalent::create): Ditto.
11236 (WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent): D itto.
11237 (WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle): Ditto.
11238 (WebCore::HTMLAttributeEquivalent::create): Ditto.
11239 (WebCore::HTMLAttributeEquivalent::matches): Ditto.
11240 (WebCore::HTMLAttributeEquivalent::hasAttribute): Ditto.
11241 (WebCore::HTMLAttributeEquivalent::attributeName): Ditto.
11242 (WebCore::HTMLAttributeEquivalent::HTMLAttributeEquivalent): Ditto.
11243 (WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle): Ditto.
11244 (WebCore::HTMLAttributeEquivalent::addToStyle): Ditto.
11245 (WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue): Ditto.
11246 (WebCore::HTMLFontSizeEquivalent::create): Ditto.
11247 (WebCore::HTMLFontSizeEquivalent::HTMLFontSizeEquivalent): Ditto.
11248 (WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue): Ditto.
11249 (WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Added.
11250 (WebCore::htmlAttributeEquivalents): Added.
11251 (WebCore::EditingStyle::conflictsWithImplicitStyleOfAttributes): Added.
11252 (WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Ad ded.
11253 * editing/EditingStyle.h:
11254
11255 2011-02-25 Chris Fleizach <cfleizach@apple.com>
11256
11257 Reviewed by Anders Carlsson.
11258
11259 AX: Add Xcode entries back to the navigator list for Accessibility cpp f iles
11260 https://bugs.webkit.org/show_bug.cgi?id=55280
11261
11262 * WebCore.xcodeproj/project.pbxproj:
11263
11264 2011-02-25 Fumitoshi Ukai <ukai@chromium.org>
11265
11266 Reviewed by Adam Barth.
11267
11268 WebSocket uses insecure random numbers
11269 https://bugs.webkit.org/show_bug.cgi?id=54714
11270
11271 * websockets/WebSocketHandshake.cpp:
11272 (WebCore::randomNumberLessThan):
11273 (WebCore::generateSecWebSocketKey):
11274 (WebCore::generateKey3):
11275
11276 2011-02-25 Eric Carlson <eric.carlson@apple.com>
11277
11278 Reviewed by Darin Adler.
11279
11280 Add API to enumerate/delete files downloaded for <audio> and <video>
11281 https://bugs.webkit.org/show_bug.cgi?id=55267
11282
11283 Add review changes missed in r79737.
11284
11285 * html/HTMLMediaElement.cpp:
11286 (WebCore::HTMLMediaElement::clearMediaCacheForSite): Pass string by refe rence.
11287 * html/HTMLMediaElement.h:
11288 * platform/graphics/MediaPlayer.cpp:
11289 (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
11290 * platform/graphics/MediaPlayer.h:
11291 * platform/graphics/MediaPlayerPrivate.h:
11292 (WebCore::MediaPlayerPrivateInterface::clearMediaCacheForSite): Ditto.
11293
11294 2011-02-25 Eric Carlson <eric.carlson@apple.com>
11295
11296 Reviewed by Darin Adler.
11297
11298 Add API to enumerate/delete files downloaded for <audio> and <video>
11299 https://bugs.webkit.org/show_bug.cgi?id=55267
11300 <rdar://problem/9049280>
11301
11302 No new tests, this is just the plumbing.
11303
11304 * html/HTMLMediaElement.cpp:
11305 (WebCore::HTMLMediaElement::getSitesInMediaCache): New, call through to MediaPlayer.
11306 (WebCore::HTMLMediaElement::clearMediaCache): Ditto.
11307 (WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
11308 * html/HTMLMediaElement.h:
11309
11310 * platform/graphics/MediaPlayer.cpp:
11311 (WebCore::MediaPlayer::getSitesInMediaCache): New, call through to media engine.
11312 (WebCore::MediaPlayer::clearMediaCache): Ditto.
11313 (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
11314 * platform/graphics/MediaPlayer.h:
11315
11316 * platform/graphics/MediaPlayerPrivate.h:
11317 (WebCore::MediaPlayerPrivateInterface::getSitesInMediaCache): Declare ne w interface.
11318 (WebCore::MediaPlayerPrivateInterface::clearMediaCache): Ditto.
11319 (WebCore::MediaPlayerPrivateInterface::clearMediaCacheForSite): Ditto.
11320
11321 2011-02-25 Abhishek Arya <inferno@chromium.org>
11322
11323 Reviewed by Dave Hyatt.
11324
11325 Don't add inline continuation outline to the containing block's
11326 continuationOutlineTable list if it is not enclosed by an anonymous bloc k.
11327 https://bugs.webkit.org/show_bug.cgi?id=54690
11328
11329 We currently don't reconnect inline continuations after a child removal.
11330 As a result, those merged inlines do not get seperated and hence not get enclosed
11331 by anonymous blocks. In this case, it is better to bail out and paint it ourself.
11332
11333 Test: fast/table/table-continuation-outline-paint-crash.html
11334
11335 * rendering/InlineFlowBox.cpp:
11336 (WebCore::InlineFlowBox::paint):
11337 * rendering/RenderBlock.cpp:
11338 (WebCore::RenderBlock::paintsContinuationOutline): helper function to te ll
11339 if this containing block has the continuation flow in its continuations list.
11340 * rendering/RenderBlock.h: helper function definition.
11341 * rendering/RenderInline.cpp:
11342 (WebCore::RenderInline::destroy): debug only code that asserts if we lea ve
11343 behind a continuation in the containing block's continuation list when i t is
11344 getting destroyed.
11345
11346 2011-02-25 David Hyatt <hyatt@apple.com>
11347
11348 Reviewed by Adam Roben.
11349
11350 https://bugs.webkit.org/show_bug.cgi?id=55265, remove the unused "Static " type
11351 from Length.
11352
11353 * css/CSSPrimitiveValue.cpp:
11354 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
11355 * platform/Length.h:
11356 (WebCore::Length::isFixed):
11357 * rendering/AutoTableLayout.cpp:
11358 (WebCore::AutoTableLayout::layout):
11359 * rendering/RenderImage.cpp:
11360 (WebCore::RenderImage::isLogicalWidthSpecified):
11361 (WebCore::RenderImage::isLogicalHeightSpecified):
11362 * rendering/RenderObject.h:
11363 (WebCore::RenderObject::markContainingBlocksForLayout):
11364 * rendering/style/RenderStyle.h:
11365 (WebCore::InheritedFlags::hasStaticX):
11366 (WebCore::InheritedFlags::hasStaticY):
11367
11368 2011-02-25 Brian Weinstein <bweinstein@apple.com>
11369
11370 Windows build fix.
11371
11372 * platform/network/cf/CookieJarCFNet.cpp:
11373 (WebCore::getHostnamesWithCookies): Add a const_cast.
11374 (WebCore::deleteCookiesForHostname): Ditto.
11375
11376 2011-02-25 Pavel Feldman <pfeldman@chromium.org>
11377
11378 Reviewed by Timothy Hatcher.
11379
11380 Web Inspector: Empty Elements panel after closing and reopening Inspecto r
11381 https://bugs.webkit.org/show_bug.cgi?id=55248
11382
11383 Fixing regression real quick. Test to follow.
11384
11385 * inspector/InspectorDOMAgent.cpp:
11386 (WebCore::InspectorDOMAgent::reset):
11387
11388 2011-02-25 Pavel Feldman <pfeldman@chromium.org>
11389
11390 Not reviewed: added missing handle scope into V8InjectedScriptHostCustom .
11391 https://bugs.webkit.org/show_bug.cgi?id=55256
11392
11393 * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
11394 (WebCore::InjectedScriptHost::nodeAsScriptValue):
11395 (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
11396
11397 2011-02-25 David Hyatt <hyatt@apple.com>
11398
11399 Reviewed by Sam Weinig.
11400
11401 https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
11402
11403 Make positioned objects work with all possible crazy combinations of mix ed writing modes. Added new helper
11404 functions that flip around the padding box of the containing block and t hen add in the appropriate border
11405 side to ensure that the offset of the positioned object is actually corr ectly placed in the containing block's
11406 local coordinate space.
11407
11408 Added two new tests of both replaced and non-replaced positioned element s in mixed writing mode environments.
11409
11410 * rendering/RenderBox.cpp:
11411 (WebCore::computeLogicalLeftPositionedOffset):
11412 (WebCore::RenderBox::computePositionedLogicalWidthUsing):
11413 (WebCore::computeLogicalTopPositionedOffset):
11414 (WebCore::RenderBox::computePositionedLogicalHeightUsing):
11415 (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
11416 (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
11417
11418 2011-02-25 Brian Weinstein <bweinstein@apple.com>
11419
11420 Reviewed by Brady Eidson and looked over by Jessie Berlin.
11421
11422 WebKit2: Need a way to manage cookies from the web process
11423 https://bugs.webkit.org/show_bug.cgi?id=55086
11424
11425 Implement the functions needed to manage cookies in CookieJar (getHostna mesWithCookies,
11426 deleteCookiesWithHostname, and deleteAllCookies) for Mac and CFNetwork ( stub out the rest),
11427 and call them from WebKit2's WebCookieManager.
11428
11429 No change in behavior needing tests.
11430
11431 * WebCore.exp.in: Added needed functions to export.
11432 * platform/CookieJar.h:
11433
11434 * platform/mac/CookieJar.mm:
11435 (WebCore::getHostnamesWithCookies): Gets all hostnames with cookies from NSHTTPCookieStorage.
11436 (WebCore::deleteCookiesForHostname): Deletes all cookies with a given ho stname from
11437 NSHTTPCookieStorage.
11438 (WebCore::deleteAllCookies): Deletes all cookies from NSHTTPCookieStorag e.
11439
11440 * platform/network/cf/CookieJarCFNet.cpp:
11441 (WebCore::getHostnamesWithCookies): Implement using CFNetwork cookie API s.
11442 (WebCore::deleteCookiesForHostname): Ditto.
11443 (WebCore::deleteAllCookies): Ditto.
11444
11445 * platform/efl/CookieJarEfl.cpp: Added stub functions.
11446 * platform/haiku/CookieJarHaiku.cpp: Ditto.
11447 * platform/network/android/CookieJarAndroid.cpp: Ditto.
11448 * platform/network/chromium/CookieJarChromium.cpp: Ditto.
11449 * platform/network/curl/CookieJarCurl.cpp: Ditto.
11450 * platform/network/soup/CookieJarSoup.cpp: Ditto.
11451 * platform/network/win/CookieJarWin.cpp: Ditto.
11452 * platform/qt/CookieJarQt.cpp: Ditto.
11453
11454 2011-02-25 Eric Carlson <eric.carlson@apple.com>
11455
11456 Reviewed by Eric Seidel.
11457
11458 'load' and 'error' events fired for @poster
11459 https://bugs.webkit.org/show_bug.cgi?id=54908
11460
11461 * html/HTMLImageLoader.cpp:
11462 (WebCore::HTMLImageLoader::dispatchLoadEvent): Don't fire events when be ing used
11463 by a video element.
11464
11465 2011-02-25 David Hyatt <hyatt@apple.com>
11466
11467 Reviewed by Sam Weinig.
11468
11469 https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
11470
11471 Patch computePositionedLogicalHeightReplaced to be writing-mode aware.
11472
11473 Added six new tests in fast/replaced.
11474
11475 * rendering/RenderBox.cpp:
11476 (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
11477
11478 2011-02-25 Patrick Gansterer <paroga@webkit.org>
11479
11480 Unreviewed build fix.
11481
11482 * platform/text/brew/TextBreakIteratorBrew.cpp:
11483 (WebCore::acquireLineBreakIterator):
11484 * platform/text/wince/TextBreakIteratorWinCE.cpp:
11485 (WebCore::acquireLineBreakIterator):
11486
11487 2011-02-25 Vangelis Kokkevis <vangelis@chromium.org>
11488
11489 Reviewed by Simon Fraser.
11490
11491 Update the clip layer size whenever the root layer's size and position
11492 is updated. This only affects the accelerated compositing path.
11493 https://bugs.webkit.org/show_bug.cgi?id=55103
11494
11495 * rendering/RenderLayerCompositor.cpp:
11496 (WebCore::RenderLayerCompositor::updateRootLayerPosition):
11497
11498 Test: platform/chromium/compositing/layout-width-change.html
11499
11500 * rendering/RenderLayerCompositor.cpp:
11501 (WebCore::RenderLayerCompositor::updateRootLayerPosition):
11502
11503 2011-02-25 Ned Holbrook <nholbrook@apple.com>
11504
11505 Reviewed by Dan Bernstein.
11506
11507 Minimize calls to ubrk_setText()
11508 https://bugs.webkit.org/show_bug.cgi?id=54912
11509 <rdar://problem/9032774>
11510
11511 Avoid calling ubrk_setText() once per call to isBreakable() by using a L azyLineBreakIterator, which defers
11512 break iterator creation until needed. This requires replacing the global line break iterator primitive with a
11513 version that can be nested, since in some cases two iterators may need t o be outstanding. In particular,
11514 layoutInlineChildren() may indirectly call computePreferredLogicalWidths () and each may need an iterator.
11515 In a test with a paragraph of Japanese text, this reduced the number of ubrk_setText() calls from 164 to 1.
11516
11517 * platform/text/TextBreakIterator.h: Add LazyLineBreakIterator.
11518 (WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
11519 (WebCore::LazyLineBreakIterator::~LazyLineBreakIterator):
11520 (WebCore::LazyLineBreakIterator::string):
11521 (WebCore::LazyLineBreakIterator::length):
11522 (WebCore::LazyLineBreakIterator::get):
11523 (WebCore::LazyLineBreakIterator::reset):
11524 * platform/text/TextBreakIteratorICU.cpp: Replace lineBreakIterator() pr imitive with acquireLineBreakIterator()/releaseLineBreakIterator().
11525 (WebCore::acquireLineBreakIterator):
11526 (WebCore::releaseLineBreakIterator):
11527 * platform/text/brew/TextBreakIteratorBrew.cpp: Ditto.
11528 (WebCore::acquireLineBreakIterator):
11529 (WebCore::releaseLineBreakIterator):
11530 * platform/text/gtk/TextBreakIteratorGtk.cpp: Ditto.
11531 (WebCore::acquireLineBreakIterator):
11532 (WebCore::releaseLineBreakIterator):
11533 * platform/text/qt/TextBreakIteratorQt.cpp: Ditto.
11534 (WebCore::acquireLineBreakIterator):
11535 (WebCore::releaseLineBreakIterator):
11536 * platform/text/wince/TextBreakIteratorWinCE.cpp: Ditto.
11537 (WebCore::acquireLineBreakIterator):
11538 (WebCore::releaseLineBreakIterator):
11539 * rendering/RenderBlock.h:
11540 * rendering/RenderBlockLineLayout.cpp:
11541 (WebCore::RenderBlock::layoutInlineChildren): Pass a mapping of RenderTe xt to LazyLineBreakIterator from one call of findNextLineBreak() to the next.
11542 (WebCore::RenderBlock::findNextLineBreak): Use said mapping, resetting L azyLineBreakIterator for any newly-encountered RenderText.
11543 * rendering/RenderText.cpp: Use a local LazyLineBreakIterator.
11544 (WebCore::RenderText::computePreferredLogicalWidths):
11545 * rendering/break_lines.cpp: Accept LazyLineBreakIterator rather than Un iChar buffer.
11546 (WebCore::nextBreakablePosition):
11547 * rendering/break_lines.h: Accept LazyLineBreakIterator rather than UniC har buffer.
11548 (WebCore::isBreakable):
11549
11550 2011-02-25 David Hyatt <hyatt@apple.com>
11551
11552 Reviewed by Sam Weinig.
11553
11554 https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
11555
11556 Patch computePositionedLogicalWidthReplaced to be writing-mode aware. N ot testable yet, since the height function overwrites the values
11557 in a vertical text environment.
11558
11559 * rendering/RenderBox.cpp:
11560 (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
11561
11562 2011-02-25 Abhishek Arya <inferno@chromium.org>
11563
11564 Reviewed by Dave Hyatt.
11565
11566 When trying to find which lines to dirty for a changed child, make sure
11567 that we do test if the adjacent next linebox contains that changed child
11568 and if yes, dirty it. This can happen in cases when we have a word break
11569 between text nodes.
11570 https://bugs.webkit.org/show_bug.cgi?id=55206
11571
11572 Test: fast/text/word-break-next-linebox-not-dirty-crash-main.html
11573
11574 * rendering/RenderLineBoxList.cpp:
11575 (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
11576
11577 2011-02-25 Andrey Adaikin <aandrey@google.com>
11578
11579 Reviewed by Pavel Feldman.
11580
11581 Web Inspector: [Text editor] Add basic layout tests for the highlighter
11582 https://bugs.webkit.org/show_bug.cgi?id=54751
11583
11584 Test: inspector/editor/highlighter-basics.html
11585
11586 * inspector/front-end/TextEditorHighlighter.js:
11587 (WebInspector.TextEditorHighlighter.prototype.highlight):
11588
11589 2011-02-24 Alexander Pavlov <apavlov@chromium.org>
11590
11591 Reviewed by Pavel Feldman.
11592
11593 Web Inspector: Huge fonts in font preview
11594 https://bugs.webkit.org/show_bug.cgi?id=55143
11595
11596 * inspector/front-end/FontView.js:
11597 (WebInspector.FontView.prototype._createContentIfNeeded):
11598 (WebInspector.FontView.prototype.show):
11599 (WebInspector.FontView.prototype.resize):
11600 (WebInspector.FontView.prototype._measureElement):
11601 (WebInspector.FontView.prototype.updateFontPreviewSize):
11602
11603 2011-02-25 Nikolas Zimmermann <nzimmermann@rim.com>
11604
11605 Reviewed by Dirk Schulze.
11606
11607 Implement SVGColor/SVGPaint API
11608 https://bugs.webkit.org/show_bug.cgi?id=55119
11609
11610 SVGColor::cssText() shouldn't return #RRGGBBAA colors
11611 https://bugs.webkit.org/show_bug.cgi?id=48120
11612
11613 Rewrite SVGColor/SVGPaint to actually implement their desired setPaint/s etColor/setURI APIs.
11614 SVGPaint is a CSSValue, and its setPaint() function allows to switch to an arbitary paint type.
11615 That means, unlike all other CSSValues, SVGColor/SVGPaint are mutable. T hat means changes to
11616 their CSSValues should be reflected in the elements style as well as in the computed style.
11617 This patch doesn't yet implement that, the stubbed-out method valueChang ed() is what
11618 needs to be implemented. For now you can grab a SVGColor/SVGPaint object through getCSSPropertyValue
11619 and manipulate it, in every possible way (SVPaint.uri/paintType/colorTyp e/color attributes are all sync'ed).
11620 Switch to strict JS bindings (RequiresAllArguments=Raise, StrictTypeChec king) for both objects.
11621
11622 Enable proper serialization of colors through Color::serialized(), affec ts some testcases (#FF.. -> #ff..)
11623 Add extensive tests of all SVGColor/SVGPaint API, currently shows some F AIL messages, as element style
11624 <-> computed style is not live, after mutating SVGColor/SVGPaint. That w ill be implemented in a follow-up patch.
11625
11626 Tests: svg/dom/SVGColor.html
11627 svg/dom/SVGPaint.html
11628
11629 * bindings/scripts/CodeGenerator.pm: Remove obsolete handling of "SVGPai ntType", take ushort for paintType, as specified in the SVG 1.1 IDLs.
11630 * bindings/scripts/CodeGeneratorJS.pm: Ditto.
11631 * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
11632 * bindings/scripts/CodeGeneratorV8.pm: Ditto.
11633 * css/SVGCSSParser.cpp: Adapt to SVGPaint/SVGColor create() naming conve ntion changes.
11634 (WebCore::CSSParser::parseSVGValue):
11635 (WebCore::CSSParser::parseSVGPaint):
11636 (WebCore::CSSParser::parseSVGColor):
11637 * svg/SVGColor.cpp: Rewrite to fully implement the SVGColor API, merge a ll constructors into one, use more descriptable create() naming convention.
11638 (WebCore::valueChanged): Stub implementation, will land in a follow-up p atch.
11639 (WebCore::SVGColor::SVGColor):
11640 (WebCore::SVGColor::setRGBColor):
11641 (WebCore::SVGColor::colorFromRGBColorString):
11642 (WebCore::SVGColor::setRGBColorICCColor):
11643 (WebCore::SVGColor::setColor):
11644 (WebCore::SVGColor::cssText):
11645 * svg/SVGColor.h:
11646 (WebCore::SVGColor::createFromString):
11647 (WebCore::SVGColor::createFromColor):
11648 (WebCore::SVGColor::color):
11649 (WebCore::SVGColor::colorType):
11650 (WebCore::SVGColor::~SVGColor):
11651 (WebCore::SVGColor::setColor):
11652 (WebCore::SVGColor::setColorType):
11653 * svg/SVGColor.idl: Enable strict type checking.
11654 * svg/SVGPaint.cpp: Rewrite to fully implement the SVGPaint API, merge a ll constructors into one, use more descriptable create() naming convention.
11655 (WebCore::valueChanged): Stub implementation, will land in a follow-up p atch.
11656 (WebCore::colorTypeForPaintType):
11657 (WebCore::SVGPaint::SVGPaint):
11658 (WebCore::SVGPaint::setUri):
11659 (WebCore::SVGPaint::defaultFill):
11660 (WebCore::SVGPaint::defaultStroke):
11661 (WebCore::SVGPaint::setPaint):
11662 (WebCore::SVGPaint::cssText):
11663 (WebCore::SVGPaint::matchesTargetURI):
11664 * svg/SVGPaint.h:
11665 (WebCore::SVGPaint::createUnknown):
11666 (WebCore::SVGPaint::createNone):
11667 (WebCore::SVGPaint::createCurrentColor):
11668 (WebCore::SVGPaint::createColor):
11669 (WebCore::SVGPaint::createURI):
11670 (WebCore::SVGPaint::createURIAndColor):
11671 (WebCore::SVGPaint::paintType):
11672 (WebCore::SVGPaint::uri):
11673 (WebCore::SVGPaint::create):
11674 (WebCore::SVGPaint::isSVGPaint):
11675 * svg/SVGPaint.idl: Enable strict type checking.
11676
11677 2011-02-25 Renata Hodovan <reni@webkit.org>
11678
11679 Reviewed by Nikolas Zimmermann.
11680
11681 FESpecularLightingElement changes doesn't require relayout.
11682 https://bugs.webkit.org/show_bug.cgi?id=54451
11683
11684 When the FESpecularLightingElement receives an update message but the gi ven value remains the same we don't need
11685 to relayout the filter. Otherwise, the light source requests a repaint o n the specular lighting filter.
11686 Besides add ASSERTs to DiffuseLightElement::setFilterEffectAttribute as well to avoid lightSources being null.
11687
11688 No new tests are needed to check the repaint because it is covered by th e dynamic update tests of FESpecularLighting.
11689 We only test what happens if we remove the light source of specularLight .
11690
11691 Test: svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSourc e.html
11692
11693 * platform/graphics/filters/FESpecularLighting.cpp:
11694 (WebCore::FESpecularLighting::setSurfaceScale):
11695 (WebCore::FESpecularLighting::setSpecularConstant):
11696 (WebCore::FESpecularLighting::setSpecularExponent):
11697 (WebCore::FESpecularLighting::setKernelUnitLengthX):
11698 (WebCore::FESpecularLighting::setKernelUnitLengthY):
11699 * platform/graphics/filters/FESpecularLighting.h:
11700 * rendering/svg/RenderSVGResourceFilter.cpp:
11701 (WebCore::RenderSVGResourceFilter::postApplyResource):
11702 * svg/SVGFEDiffuseLightingElement.cpp:
11703 (WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
11704 (WebCore::SVGFEDiffuseLightingElement::lightElementAttributeChanged):
11705 (WebCore::SVGFEDiffuseLightingElement::build):
11706 * svg/SVGFEDiffuseLightingElement.h:
11707 * svg/SVGFELightElement.cpp:
11708 (WebCore::SVGFELightElement::findLightElement):
11709 (WebCore::SVGFELightElement::findLight):
11710 (WebCore::SVGFELightElement::svgAttributeChanged):
11711 * svg/SVGFELightElement.h:
11712 * svg/SVGFESpecularLightingElement.cpp:
11713 (WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):
11714 (WebCore::SVGFESpecularLightingElement::svgAttributeChanged):
11715 (WebCore::SVGFESpecularLightingElement::lightElementAttributeChanged):
11716 (WebCore::SVGFESpecularLightingElement::build):
11717 * svg/SVGFESpecularLightingElement.h:
11718
11719 2011-02-24 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
11720
11721 Reviewed by Andreas Kling.
11722
11723 [Qt] Revert the support for QNAM affined to a different thread.
11724 https://bugs.webkit.org/show_bug.cgi?id=55149
11725
11726 Qt 4.8 will have QNAM use its own thread internally by default,
11727 no need to keep this complexity in WebKit.
11728
11729 This mainly reverts:
11730 http://trac.webkit.org/changeset/73710
11731 http://trac.webkit.org/changeset/73712
11732
11733 * WebCore.pro:
11734 * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
11735 (WebCore::MediaPlayerPrivateQt::commitLoad):
11736 * platform/network/qt/QNetworkReplyHandler.cpp:
11737 (WebCore::FormDataIODevice::FormDataIODevice):
11738 (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
11739 (WebCore::QNetworkReplyHandler::setLoadMode):
11740 (WebCore::QNetworkReplyHandler::abort):
11741 (WebCore::QNetworkReplyHandler::release):
11742 (WebCore::ignoreHttpError):
11743 (WebCore::QNetworkReplyHandler::finish):
11744 (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
11745 (WebCore::QNetworkReplyHandler::forwardData):
11746 (WebCore::QNetworkReplyHandler::start):
11747 (WebCore::QNetworkReplyHandler::sendQueuedItems):
11748 * platform/network/qt/QNetworkReplyHandler.h:
11749 (WebCore::QNetworkReplyHandler::reply):
11750 * platform/network/qt/QtNAMThreadSafeProxy.cpp: Removed.
11751 * platform/network/qt/QtNAMThreadSafeProxy.h: Removed.
11752 * platform/network/qt/ResourceHandleQt.cpp:
11753 (WebCore::ResourceHandle::willLoadFromCache):
11754 * platform/qt/CookieJarQt.cpp:
11755 (WebCore::cookieJar):
11756 (WebCore::setCookies):
11757 (WebCore::cookies):
11758 (WebCore::cookieRequestHeaderFieldValue):
11759 (WebCore::cookiesEnabled):
11760
11761 2011-02-25 Renata Hodovan <reni@webkit.org>
11762
11763 Reviewed by Andreas Kling.
11764
11765 FEBlendElement changes doesn't require relayout
11766 https://bugs.webkit.org/show_bug.cgi?id=55138
11767
11768 When the FEBlendElement receives an update message but the given value r emains the same we don't need
11769 to relayout the filter.
11770
11771 No new tests are needed because this modificiation is covered by the dyn amic update tests of FEBlend.
11772
11773 * platform/graphics/filters/FEBlend.cpp:
11774 (WebCore::FEBlend::setBlendMode):
11775 * platform/graphics/filters/FEBlend.h:
11776 * svg/SVGFEBlendElement.cpp:
11777 (WebCore::SVGFEBlendElement::setFilterEffectAttribute):
11778 (WebCore::SVGFEBlendElement::svgAttributeChanged):
11779 (WebCore::SVGFEBlendElement::synchronizeProperty):
11780 * svg/SVGFEBlendElement.h:
11781
11782 2011-02-24 Daniel Bates <dbates@rim.com>
11783
11784 Reviewed by Antonio Gomes.
11785
11786 Clean up: Extract table height adjustment for <caption> into common func tion
11787 https://bugs.webkit.org/show_bug.cgi?id=54936
11788
11789 We use similar logic for adjusting the height of a table with respect
11790 to a top- and bottom-positioned <caption>. Instead, we should extract
11791 the common code into a shared function.
11792
11793 No functionality changed. So no new tests.
11794
11795 * rendering/RenderTable.cpp:
11796 (WebCore::RenderTable::adjustLogicalHeightForCaption): Added.
11797 (WebCore::RenderTable::layout): Extracted common code to adjust table he ight
11798 with respect to the <caption> into RenderTable::adjustLogicalHeightForCa ption().
11799 * rendering/RenderTable.h:
11800
11801 2011-02-24 James Robinson <jamesr@chromium.org>
11802
11803 Reviewed by Kenneth Russell.
11804
11805 [chromium] Move draw time properties out of *LayerChromium to CCLayerImp l
11806 https://bugs.webkit.org/show_bug.cgi?id=55013
11807
11808 This adds a new type (tentatively named CCLayerImpl) responsible for dra wing/compositing layers.
11809 Currently LayerChromiums know about their CCLayerImpls and CCLayerImpls rely on the LayerChromium
11810 tree for structure. In theory updates are a LayerChromium-only concept and draw is a CCLayerImpl-only
11811 concept, but this patch doesn't go all there yet in the interest of keep ing the patch small-ish.
11812
11813 RenderSurfaces are a CCLayerImpl-only concepts and no longer have any di rect LayerChromium dependencies.
11814
11815 Note: I've put CCLayerImpl into a new 'cc' directory under platform/grap hics/chromium/ and intentionally
11816 not added it to the include path. We plan to add more compositor implem entation details to this directory
11817 and we want to keep accidental dependencies on these files to a minimum.
11818
11819 See https://bugs.webkit.org/show_bug.cgi?id=54047 for the big picture.
11820
11821 Refactor only, compositing/ tests cover these codepaths.
11822
11823 * WebCore.gypi:
11824 * platform/graphics/chromium/CanvasLayerChromium.cpp:
11825 (WebCore::CanvasLayerChromium::draw):
11826 * platform/graphics/chromium/ContentLayerChromium.cpp:
11827 (WebCore::ContentLayerChromium::requiresClippedUpdateRect):
11828 (WebCore::ContentLayerChromium::updateContentsIfDirty):
11829 (WebCore::ContentLayerChromium::draw):
11830 * platform/graphics/chromium/LayerChromium.cpp:
11831 (WebCore::LayerChromium::LayerChromium):
11832 (WebCore::LayerChromium::cleanupResources):
11833 (WebCore::LayerChromium::setLayerRenderer):
11834 (WebCore::LayerChromium::setBounds):
11835 (WebCore::LayerChromium::setFrame):
11836 (WebCore::LayerChromium::setNeedsDisplay):
11837 (WebCore::LayerChromium::setBorderColor):
11838 (WebCore::LayerChromium::borderColor):
11839 (WebCore::LayerChromium::setBorderWidth):
11840 (WebCore::LayerChromium::borderWidth):
11841 (WebCore::LayerChromium::layerRenderer):
11842 (WebCore::LayerChromium::setDoubleSided):
11843 (WebCore::LayerChromium::bounds):
11844 * platform/graphics/chromium/LayerChromium.h:
11845 (WebCore::LayerChromium::maskDrawLayer):
11846 (WebCore::LayerChromium::ccLayerImpl):
11847 * platform/graphics/chromium/LayerRendererChromium.cpp:
11848 (WebCore::LayerRendererChromium::compareLayerZ):
11849 (WebCore::LayerRendererChromium::drawLayers):
11850 (WebCore::LayerRendererChromium::updateLayersRecursive):
11851 (WebCore::LayerRendererChromium::setCompositeOffscreen):
11852 (WebCore::LayerRendererChromium::getOffscreenLayerTexture):
11853 (WebCore::LayerRendererChromium::drawLayer):
11854 * platform/graphics/chromium/LayerRendererChromium.h:
11855 * platform/graphics/chromium/PluginLayerChromium.cpp:
11856 (WebCore::PluginLayerChromium::draw):
11857 * platform/graphics/chromium/RenderSurfaceChromium.cpp:
11858 (WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
11859 (WebCore::RenderSurfaceChromium::drawSurface):
11860 (WebCore::RenderSurfaceChromium::draw):
11861 * platform/graphics/chromium/RenderSurfaceChromium.h:
11862 * platform/graphics/chromium/VideoLayerChromium.cpp:
11863 (WebCore::VideoLayerChromium::drawYUV):
11864 (WebCore::VideoLayerChromium::drawRGBA):
11865 * platform/graphics/chromium/cc/CCLayerImpl.cpp: Added.
11866 (WebCore::CCLayerImpl::CCLayerImpl):
11867 (WebCore::CCLayerImpl::~CCLayerImpl):
11868 (WebCore::CCLayerImpl::superlayer):
11869 (WebCore::CCLayerImpl::maskLayer):
11870 (WebCore::CCLayerImpl::replicaLayer):
11871 (WebCore::CCLayerImpl::setLayerRenderer):
11872 (WebCore::CCLayerImpl::createRenderSurface):
11873 (WebCore::CCLayerImpl::updateContentsIfDirty):
11874 (WebCore::CCLayerImpl::drawsContent):
11875 (WebCore::CCLayerImpl::draw):
11876 (WebCore::CCLayerImpl::unreserveContentsTexture):
11877 (WebCore::CCLayerImpl::bindContentsTexture):
11878 (WebCore::CCLayerImpl::cleanupResources):
11879 (WebCore::CCLayerImpl::getDrawRect):
11880 (WebCore::CCLayerImpl::drawDebugBorder):
11881 * platform/graphics/chromium/cc/CCLayerImpl.h: Added.
11882 (WebCore::CCLayerImpl::create):
11883 (WebCore::CCLayerImpl::setDebugBorderColor):
11884 (WebCore::CCLayerImpl::debugBorderColor):
11885 (WebCore::CCLayerImpl::setDebugBorderWidth):
11886 (WebCore::CCLayerImpl::debugBorderWidth):
11887 (WebCore::CCLayerImpl::layerRenderer):
11888 (WebCore::CCLayerImpl::renderSurface):
11889 (WebCore::CCLayerImpl::clearRenderSurface):
11890 (WebCore::CCLayerImpl::drawDepth):
11891 (WebCore::CCLayerImpl::setDrawDepth):
11892 (WebCore::CCLayerImpl::drawOpacity):
11893 (WebCore::CCLayerImpl::setDrawOpacity):
11894 (WebCore::CCLayerImpl::scissorRect):
11895 (WebCore::CCLayerImpl::setScissorRect):
11896 (WebCore::CCLayerImpl::targetRenderSurface):
11897 (WebCore::CCLayerImpl::setTargetRenderSurface):
11898 (WebCore::CCLayerImpl::doubleSided):
11899 (WebCore::CCLayerImpl::setDoubleSided):
11900 (WebCore::CCLayerImpl::bounds):
11901 (WebCore::CCLayerImpl::setBounds):
11902 (WebCore::CCLayerImpl::drawTransform):
11903 (WebCore::CCLayerImpl::setDrawTransform):
11904 (WebCore::CCLayerImpl::drawableContentRect):
11905 (WebCore::CCLayerImpl::setDrawableContentRect):
11906
11907 2011-02-24 Dan Bernstein <mitz@apple.com>
11908
11909 Reviewed by Simon Fraser.
11910
11911 REGRESSION (r79629): Non-expanding ruby base is start-aligned rather tha n centered
11912 https://bugs.webkit.org/show_bug.cgi?id=55197
11913
11914 * rendering/RenderBlockLineLayout.cpp:
11915 (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Adjust t he line boundaries even
11916 if there are no expansion opportunities. This allows RenderRubyBase to c enter itself.
11917
11918 2011-02-24 Darin Adler <darin@apple.com>
11919
11920 Reviewed by Alexey Proskuryakov.
11921
11922 REGRESSION (r79466): http/tests/incremental/slow-utf8-html.pl flaky due to incorrect assertions
11923 https://bugs.webkit.org/show_bug.cgi?id=55135
11924
11925 * platform/text/TextCodecUTF8.cpp:
11926 (WebCore::TextCodecUTF8::decode): Removed incorrect assertions.
11927
11928 2011-02-24 Darin Adler <darin@apple.com>
11929
11930 Reviewed by Anders Carlsson.
11931
11932 WebKit2: Image-based cursors do not work
11933 https://bugs.webkit.org/show_bug.cgi?id=55184
11934
11935 * WebCore.exp.in: Exported new entry points now used by WebKit2.
11936
11937 2011-02-24 Matthew Delaney <mdelaney@apple.com>
11938
11939 Reviewed by Simon Fraser.
11940
11941 ImageBuffer::clip creates an image of the incorrect context in IOSurface case
11942 https://bugs.webkit.org/show_bug.cgi?id=55170
11943
11944 Test: fast/canvas/2d.fillText.gradient.html
11945
11946 * platform/graphics/cg/ImageBufferCG.cpp: Clipping against ImageBuffer's context
11947 instead of ourself (the passed in context).
11948
11949 2011-02-24 Simon Fraser <simon.fraser@apple.com>
11950
11951 Reviewed by Dan Bernstein.
11952
11953 RenderBoxModelObject::paintBoxShadow should bail earlier
11954 https://bugs.webkit.org/show_bug.cgi?id=55186
11955
11956 Make paintBoxShadow() bail early if there is no shadow, and make
11957 callers consistent in not checking for box-shadow before calling it.
11958
11959 * rendering/InlineFlowBox.cpp:
11960 (WebCore::InlineFlowBox::paintBoxDecorations):
11961 * rendering/RenderBoxModelObject.cpp:
11962 (WebCore::RenderBoxModelObject::paintBoxShadow):
11963 * rendering/RenderTableCell.cpp:
11964 (WebCore::RenderTableCell::paintBoxDecorations):
11965
11966 2011-02-24 James Robinson <jamesr@chromium.org>
11967
11968 Reviewed by Darin Fisher.
11969
11970 Add a USE() macro to control use of the built-in UTF8 codec
11971 https://bugs.webkit.org/show_bug.cgi?id=55189
11972
11973 Guards the built in UTF8 codec registration with USE(BUILTIN_UTF8_CODEC) . ICU is used if the USE() is not set.
11974
11975 * platform/text/TextCodecICU.cpp:
11976 (WebCore::TextCodecICU::registerEncodingNames):
11977 * platform/text/TextEncodingRegistry.cpp:
11978 (WebCore::buildBaseTextCodecMaps):
11979
11980 2011-02-24 Dan Bernstein <mitz@apple.com>
11981
11982 Reviewed by Dave Hyatt.
11983
11984 <rdar://problem/8902740> Expand ruby base when it is shorter than the ru by text
11985 https://bugs.webkit.org/show_bug.cgi?id=55183
11986
11987 Test: fast/ruby/base-shorter-than-text.html
11988
11989 * rendering/RenderBlock.cpp:
11990 (WebCore::RenderBlock::availableLogicalWidthForLine):
11991 * rendering/RenderBlock.h:
11992 (WebCore::RenderBlock::adjustInlineDirectionLineBounds): Added. The base clase implementation does nothing.
11993 * rendering/RenderBlockLineLayout.cpp:
11994 (WebCore::RenderBlock::textAlignmentForLine): Added. Implements the logi c that changes "justify" to "auto" for
11995 the last line or a line that ends with a hard break.
11996 (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Use text AlignmentForLine(), compute the available
11997 width more efficiently, and call adjustInlineDirectionLineBounds() for j ustified lines.
11998 * rendering/RenderRubyBase.cpp:
11999 (WebCore::RenderRubyBase::rubyRun): Added.
12000 (WebCore::RenderRubyBase::textAlignmentForLine): Added. Alwyas returns " justify".
12001 (WebCore::RenderRubyBase::adjustInlineDirectionLineBounds): Added. Inset s the line such that the inset is
12002 half the width of a single intra-line expansion.
12003 * rendering/RenderRubyBase.h:
12004 * rendering/RenderRubyRun.cpp:
12005 (WebCore::RenderRubyRun::addChild):
12006
12007 2011-02-24 James Robinson <jamesr@chromium.org>
12008
12009 Unreviewed, rolling out r79604.
12010 http://trac.webkit.org/changeset/79604
12011 https://bugs.webkit.org/show_bug.cgi?id=55017
12012
12013 Causes assertions to fail on some SVG tests
12014
12015 * svg/graphics/SVGImage.cpp:
12016 (WebCore::SVGImage::dataChanged):
12017
12018 2011-02-24 Oliver Hunt <oliver@apple.com>
12019
12020 Build fix
12021
12022 * bindings/js/JSBindingsAllInOne.cpp:
12023
12024 2011-02-24 David Hyatt <hyatt@apple.com>
12025
12026 Reviewed by Simon Fraser.
12027
12028 https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
12029
12030 Rework the logical height computation for positioned elements to work in terms of before and after. That way the offset is determined from
12031 the correct container side in flipped block writing modes (e.g., vertica l-rl).
12032
12033 Patch locationOffsetIncludingFlipping to use the containing block to fli p so that it will behave correctly with absolute/fixed positioned
12034 elements.
12035
12036 Patch offsetFromContainer to use the flipped location offset for absolut e/fixed positioned elements so that localToAbsolute works properly.
12037
12038 Added twelve tests in fast/block/positioning/vertical-rl and fast/block/ positioning/vertical-lr.
12039
12040 * rendering/RenderBox.cpp:
12041 (WebCore::RenderBox::offsetFromContainer):
12042 (WebCore::RenderBox::computePositionedLogicalHeight):
12043 (WebCore::RenderBox::computePositionedLogicalHeightUsing):
12044 (WebCore::RenderBox::locationOffsetIncludingFlipping):
12045 * rendering/style/RenderStyle.h:
12046 (WebCore::InheritedFlags::logicalTop):
12047 (WebCore::InheritedFlags::logicalBottom):
12048
12049 2011-02-23 Oliver Hunt <oliver@apple.com>
12050
12051 Reviewed by Geoffrey Garen.
12052
12053 Make WeakGCMap use new handle infrastructure
12054 https://bugs.webkit.org/show_bug.cgi?id=55100
12055
12056 Update to new WeakGCMap APIs, this requires threading global
12057 data to a few functions that did not need it in the past, but
12058 also gets rid of a large number of destructors, as well as the
12059 forgetDOMNode, etc APIs.
12060
12061 We can also drop the JSDebugWrapperSet as its only purpose was
12062 to ensure that we retained correct semantics in the old WeakGCMap,
12063 but happilly these semantics are now guaranteed by the map itself.
12064
12065 * CMakeLists.txt:
12066 * GNUmakefile.am:
12067 * WebCore.gypi:
12068 * WebCore.pro:
12069 * WebCore.vcproj/WebCore.vcproj:
12070 * WebCore.xcodeproj/project.pbxproj:
12071 * bindings/js/JSDOMBinding.cpp:
12072 (WebCore::hasCachedDOMObjectWrapperUnchecked):
12073 (WebCore::cacheDOMObjectWrapper):
12074 (WebCore::hasCachedDOMNodeWrapperUnchecked):
12075 (WebCore::cacheDOMNodeWrapper):
12076 (WebCore::isObservableThroughDOM):
12077 (WebCore::markDOMNodesForDocument):
12078 (WebCore::takeWrappers):
12079 (WebCore::updateDOMNodeDocument):
12080 (WebCore::markDOMObjectWrapper):
12081 (WebCore::markDOMNodeWrapper):
12082 (WebCore::stringWrapperDestroyed):
12083 (WebCore::jsStringSlowCase):
12084 * bindings/js/JSDOMBinding.h:
12085 * bindings/js/JSDOMWrapper.cpp:
12086 (WebCore::DOMObject::~DOMObject):
12087 * bindings/js/JSDebugWrapperSet.cpp: Removed.
12088 * bindings/js/JSDebugWrapperSet.h: Removed.
12089 * bindings/scripts/CodeGeneratorJS.pm:
12090 * bridge/jsc/BridgeJSC.cpp:
12091 (JSC::Bindings::Instance::createRuntimeObject):
12092 * bridge/jsc/BridgeJSC.h:
12093 * bridge/runtime_object.cpp:
12094 (JSC::Bindings::RuntimeObject::~RuntimeObject):
12095 * bridge/runtime_root.cpp:
12096 (JSC::Bindings::RootObject::invalidate):
12097 (JSC::Bindings::RootObject::addRuntimeObject):
12098 (JSC::Bindings::RootObject::removeRuntimeObject):
12099 * bridge/runtime_root.h:
12100
12101 2011-02-24 James Robinson <jamesr@chromium.org>
12102
12103 Fix chromium compile.
12104
12105 * bindings/v8/custom/V8LocationCustom.cpp:
12106 (WebCore::V8Location::toStringCallback):
12107
12108 2011-02-24 Dimitri Glazkov <dglazkov@chromium.org>
12109
12110 Unreviewed, rolling out r79607.
12111 http://trac.webkit.org/changeset/79607
12112 https://bugs.webkit.org/show_bug.cgi?id=55157
12113
12114 Broke Chromium layout tests.
12115
12116 * html/shadow/MediaControls.cpp:
12117 (WebCore::MediaControls::updateVolumeSliderContainer):
12118 * rendering/RenderMediaControls.cpp:
12119 (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton):
12120 * rendering/RenderMediaControls.h:
12121 * rendering/RenderTheme.cpp:
12122 (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
12123 * rendering/RenderTheme.h:
12124 * rendering/RenderThemeChromiumMac.h:
12125 * rendering/RenderThemeChromiumMac.mm:
12126 (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton):
12127 * rendering/RenderThemeMac.h:
12128 * rendering/RenderThemeMac.mm:
12129 (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton):
12130 * rendering/RenderThemeWin.cpp:
12131 (WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton):
12132 * rendering/RenderThemeWin.h:
12133
12134 2011-02-24 Anders Carlsson <andersca@apple.com>
12135
12136 Reviewed by Sam Weinig.
12137
12138 Fix the clang -Woverloaded-virtual build.
12139
12140 JSLocation has a toString function which conflicts with the virtual JSOb ject::toString member function.
12141 Fix this by renaming the implementation function from JSLocation::toStri ng to JSLocation::toStringFunction.
12142
12143 * bindings/js/JSLocationCustom.cpp:
12144 (WebCore::JSLocation::toStringFunction):
12145 * bindings/v8/custom/V8LocationCustom.cpp:
12146 (WebCore::V8Location::toStringFunctionCallback):
12147 * page/Location.idl:
12148
12149 2011-02-24 Anders Carlsson <andersca@apple.com>
12150
12151 Fix clang build.
12152
12153 * bindings/objc/WebScriptObject.mm:
12154 (-[WebUndefined release]):
12155 Release should be "oneway void".
12156
12157 (-[WebUndefined retainCount]):
12158 Return NSUIntegerMax instead of UINT_MAX.
12159
12160 2011-02-24 Dimitri Glazkov <dglazkov@chromium.org>
12161
12162 Reviewed by Darin Adler.
12163
12164 Simplify RenderTheme::volumeSliderOffsetFromMuteButton, unduplicate code .
12165 https://bugs.webkit.org/show_bug.cgi?id=55157
12166
12167 Refactoring, no functional changes. Covered by existing tests.
12168
12169 RenderTheme::volumeSliderOffsetFromMuteButton has the same duplicated
12170 logic for all platforms. This patch:
12171 a) moves the common logic of determining absolute positioning to a
12172 platform-agnostic place;
12173 b) simplifies the method to return constant offset.
12174
12175 * html/shadow/MediaControls.cpp:
12176 (WebCore::volumeSliderOffset): Added new helper function,
12177 capturing common logic of finding the absolute position of the volum e slider.
12178 (WebCore::MediaControls::updateVolumeSliderContainer): Changed to use th e
12179 new helper.
12180 * rendering/RenderMediaControls.cpp:
12181 (WebCore::RenderMediaControls::volumeSliderOffsetRelativeToMuteButton): Simplified.
12182 * rendering/RenderMediaControls.h: Ditto.
12183 * rendering/RenderTheme.cpp:
12184 (WebCore::RenderTheme::volumeSliderOffsetRelativeToMuteButton): Ditto.
12185 * rendering/RenderTheme.h: Ditto.
12186 * rendering/RenderThemeChromiumMac.h: Ditto.
12187 * rendering/RenderThemeChromiumMac.mm: Ditto.
12188 (WebCore::RenderThemeChromiumMac::volumeSliderOffsetRelativeToMuteButton ): Ditto.
12189 * rendering/RenderThemeMac.h: Ditto.
12190 * rendering/RenderThemeMac.mm: Ditto.
12191 (WebCore::RenderThemeMac::volumeSliderOffsetRelativeToMuteButton): Ditto .
12192 * rendering/RenderThemeWin.cpp: Ditto.
12193 (WebCore::RenderThemeWin::volumeSliderOffsetRelativeToMuteButton): Ditto .
12194 * rendering/RenderThemeWin.h: Ditto.
12195
12196 2011-02-24 Tom Sepez <tsepez@chromium.org>
12197
12198 Reviewed by Darin Fisher.
12199
12200 Make frameview resized event dispatch async so that it occurs
12201 after layout has completed.
12202
12203 https://bugs.webkit.org/show_bug.cgi?id=54467
12204 Test: fast/replaced/frame-removed-during-resize-smaller.html
12205
12206 * page/EventHandler.cpp:
12207 (WebCore::EventHandler::sendResizeEvent):
12208
12209 2011-02-24 Xianzhu Wang <wangxianzhu@google.com>
12210
12211 Reviewed by Adam Barth.
12212
12213 Use loader->init() instead of loader->load() to avoid complex fake
12214 request loading and cleanup logic, and also avoid ResourceLoader leaks.
12215
12216 https://bugs.webkit.org/show_bug.cgi?id=55017
12217
12218 Test: svg/misc/SVGImage-leak-ResourceLoader.html
12219
12220 * svg/graphics/SVGImage.cpp:
12221 (WebCore::SVGImage::dataChanged):
12222
12223 2011-02-24 Dimitri Glazkov <dglazkov@chromium.org>
12224
12225 Chromium Mac build fix after r79591.
12226
12227 * WebCore.gypi: Added RenderMediaControls to WebCore.gypi.
12228
12229 2011-02-24 Misha Tyutyunik <michael.tyutyunik@nokia.com>
12230
12231 Reviewed by Andreas Kling.
12232
12233 [Qt] Dont use QPixmapCache if QPixmapCache::cacheLimit() is too small
12234 (2048Kb for now).
12235 https://bugs.webkit.org/show_bug.cgi?id=54887
12236
12237 No new tests required.
12238
12239 * platform/graphics/qt/GraphicsLayerQt.cpp:
12240 (WebCore::GraphicsLayerQtImpl::allowAcceleratedCompositingCache):
12241 (WebCore::GraphicsLayerQtImpl::drawLayerContent):
12242 (WebCore::GraphicsLayerQtImpl::paint):
12243 (WebCore::GraphicsLayerQtImpl::flushChanges):
12244
12245 2011-02-20 Martin Robinson <mrobinson@igalia.com>
12246
12247 Reviewed by Nikolas Zimmermann.
12248
12249 [CAIRO] Support ImageBuffers clip operation on all Cairo ports
12250 https://bugs.webkit.org/show_bug.cgi?id=23526
12251
12252 Add support for ImageBuffer clipping on Cairo by emulating them with ima ge
12253 masks. Since masking is immediate on Cairo, we must store the mask surfa ces
12254 on a stack and apply them during restorePlatformState.
12255
12256 * platform/graphics/GraphicsContext.h: Add pushImageMask.
12257 * platform/graphics/cairo/GraphicsContextCairo.cpp:
12258 (WebCore::GraphicsContext::savePlatformState): Push an empty mask onto t he
12259 stack, so we can keep track of when to actually apply the image mask.
12260 (WebCore::GraphicsContext::restorePlatformState): When we are ready to a pply
12261 an image mask, use cairo_mask_surface to mask the group that we pushed o nto
12262 our surface.
12263 (WebCore::GraphicsContext::pushImageMask): Added. This method will push a surface
12264 onto the image mask stack and push a group onto the Cairo state, so that the masking
12265 only affects what we paint after this point.
12266 * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Added a class to keep
12267 track of image masking information after calls to pushImageMask.
12268 (WebCore::ImageMaskInformation::update): Added
12269 (WebCore::ImageMaskInformation::valid): Added
12270 (WebCore::ImageMaskInformation::maskSurface): Added
12271 (WebCore::ImageMaskInformation::maskRect): Added
12272 * platform/graphics/cairo/ImageBufferCairo.cpp:
12273 (WebCore::ImageBuffer::clip): Call GraphicsContext::pushImageMask.
12274
12275 2011-02-24 Dimitri Glazkov <dglazkov@chromium.org>
12276
12277 Reviewed by Eric Carlson.
12278
12279 Add RenderMediaControls to Mac build, unduplicate one method.
12280 https://bugs.webkit.org/show_bug.cgi?id=55152
12281
12282 Refactoring, no functional changes.
12283
12284 * WebCore.xcodeproj/project.pbxproj: Added RenderMediaControls to projec t,
12285 ran sort-XCode-project-file.
12286 * rendering/RenderMediaControls.cpp: Moved ENABLE(VIDEO) and PLATFORM(WI N)
12287 defines to allow building on Mac.
12288 * rendering/RenderMediaControls.h: Ditto.
12289 * rendering/RenderThemeMac.mm:
12290 (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton): Replaced gu ts
12291 with a call to RenderMediaControls function.
12292
12293 2011-02-24 James Robinson <jamesr@chromium.org>
12294
12295 Unreviewed, rolling out r79584.
12296 http://trac.webkit.org/changeset/79584
12297 https://bugs.webkit.org/show_bug.cgi?id=44797
12298
12299 [chromium] Patch does not compile if ENABLE_FULLSCREEN_API is
12300 not set
12301
12302 * WebCore.gyp/WebCore.gyp:
12303 * WebCore.gypi:
12304
12305 2011-02-24 Carlos Garcia Campos <cgarcia@igalia.com>
12306
12307 Reviewed by Martin Robinson.
12308
12309 Do not cache the default cairo font options using a static
12310 variable. It fixes a memory leak reported by valgrind.
12311
12312 * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
12313 (WebCore::getDefaultFontOptions):
12314 (WebCore::FontPlatformData::initializeWithFontFace):
12315
12316 2011-02-24 Andrew Wilson <atwilson@chromium.org>
12317
12318 Unreviewed, rolling out r79570.
12319 http://trac.webkit.org/changeset/79570
12320 https://bugs.webkit.org/show_bug.cgi?id=54874
12321
12322 Breaks chromium build because glue/mocks/mock_web_frame.h/cc
12323 was not updated
12324
12325 * WebCore.exp.in:
12326
12327 2011-02-24 David Dorwin <ddorwin@chromium.org>
12328
12329 Reviewed by Eric Seidel.
12330
12331 Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled b y default.
12332
12333 fullscreen javascript bindings not implemented for v8
12334 https://bugs.webkit.org/show_bug.cgi?id=44797
12335
12336 Tested by the existing fullscreen Layout Tests.
12337
12338 * WebCore.gyp/WebCore.gyp:
12339 * WebCore.gypi:
12340
12341 2011-02-24 Pavel Feldman <pfeldman@chromium.org>
12342
12343 Reviewed by Yury Semikhatsky.
12344
12345 Web Inspector: move querySelectorAll from CSS agent to DOM agent where i t belongs.
12346 https://bugs.webkit.org/show_bug.cgi?id=55131
12347
12348 Test: inspector/elements/dom-agent-query-selector.html
12349
12350 * inspector/Inspector.idl:
12351 * inspector/InspectorCSSAgent.cpp:
12352 * inspector/InspectorCSSAgent.h:
12353 * inspector/InspectorDOMAgent.cpp:
12354 (WebCore::InspectorDOMAgent::nodeToSelectOn):
12355 (WebCore::InspectorDOMAgent::querySelector):
12356 (WebCore::InspectorDOMAgent::querySelectorAll):
12357 * inspector/InspectorDOMAgent.h:
12358 * inspector/front-end/AuditRules.js:
12359 (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
12360 * inspector/front-end/CSSStyleModel.js:
12361 (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
12362 (WebInspector.CSSStyleModel.prototype.setRuleSelector):
12363 (WebInspector.CSSStyleModel.prototype.addRule.callback):
12364 (WebInspector.CSSStyleModel.prototype.addRule):
12365
12366 2011-02-24 Eric Seidel <eric@webkit.org>
12367
12368 Reviewed by Adam Barth.
12369
12370 Fragment parsing does not need to use HTMLSourceTracker
12371 https://bugs.webkit.org/show_bug.cgi?id=55011
12372
12373 Any performance gains from this patch are likely
12374 the result of working around:
12375 https://bugs.webkit.org/show_bug.cgi?id=55005
12376 (Which suggests that fixing bug 55005 will speed
12377 up normal HTML parsing substantially.)
12378
12379 Assuming I ran the numbers correct, here is the
12380 change from PerformanceTests/Parser/tiny-innerHTML:
12381 Before patch:
12382 avg 5586.1
12383 median 5594
12384 stdev 41.295157101045135
12385 min 5425
12386 max 5633
12387
12388 After Patch:
12389 avg 2603.9
12390 median 2609.5
12391 stdev 32.500615378789355
12392 min 2475
12393 max 2649
12394
12395 Removing just the HTMLSourceTracker calls brought our
12396 score from 5500 to 5200, removing the XSSFilter as well
12397 brought it to 2600 on my machine.
12398
12399 * html/parser/HTMLDocumentParser.cpp:
12400 (WebCore::HTMLDocumentParser::HTMLDocumentParser):
12401 (WebCore::HTMLDocumentParser::pumpTokenizer):
12402 * html/parser/HTMLDocumentParser.h:
12403
12404 2011-02-24 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> and Alejandro G. Castro <alex@igalia.com>
12405
12406 Reviewed by Martin Robinson.
12407
12408 [GTK] Implement WebEventFactory, WebErrors classes for WebKit2
12409 https://bugs.webkit.org/show_bug.cgi?id=48510
12410
12411 Exported static functions for GTK, we need them to create events
12412 in WebKit2.
12413
12414 * platform/PlatformKeyboardEvent.h:
12415 * platform/gtk/KeyEventGtk.cpp:
12416 (WebCore::PlatformKeyboardEvent::keyIdentifierForGdkKeyCode):
12417 (WebCore::PlatformKeyboardEvent::windowsKeyCodeForGdkKeyCode):
12418 (WebCore::PlatformKeyboardEvent::singleCharacterString):
12419
12420 2011-02-24 Martin Robinson <mrobinson@igalia.com>
12421
12422 Reviewed by Xan Lopez.
12423
12424 [GTK] Remove the GFile GOwnPtr specialization
12425 https://bugs.webkit.org/show_bug.cgi?id=55154
12426
12427 Convert uses of GOwnPtr<GFile> to GRefPtr<GFile>.
12428
12429 No new tests. This should not change behavior.
12430
12431 * plugins/gtk/PluginPackageGtk.cpp: Fix include order and remove unneces sary include.
12432 (WebCore::PluginPackage::load): Use GRefPtr for GFile instead of GOwnPtr .
12433
12434 2011-02-24 Patrick Gansterer <paroga@webkit.org>
12435
12436 Reviewed by Eric Seidel.
12437
12438 Rename PLATFORM(SKIA) to USE(SKIA)
12439 https://bugs.webkit.org/show_bug.cgi?id=55090
12440
12441 * config.h: Removed second define of PLATFORM(SKIA).
12442 * html/HTMLCanvasElement.cpp:
12443 * platform/graphics/FloatPoint.h:
12444 * platform/graphics/FloatRect.h:
12445 * platform/graphics/Gradient.cpp:
12446 * platform/graphics/Gradient.h:
12447 * platform/graphics/GraphicsContext.cpp:
12448 * platform/graphics/GraphicsContext.h:
12449 * platform/graphics/ImageSource.h:
12450 * platform/graphics/IntPoint.h:
12451 * platform/graphics/IntRect.h:
12452 * platform/graphics/Path.h:
12453 * platform/graphics/Pattern.cpp:
12454 * platform/graphics/Pattern.h:
12455 * platform/graphics/chromium/ContentLayerChromium.cpp:
12456 * platform/graphics/chromium/ContentLayerChromium.h:
12457 * platform/graphics/chromium/GLES2Canvas.cpp:
12458 * platform/graphics/chromium/ImageLayerChromium.cpp:
12459 * platform/graphics/chromium/LayerChromium.cpp:
12460 * platform/graphics/chromium/LayerRendererChromium.cpp:
12461 * platform/graphics/chromium/LayerRendererChromium.h:
12462 * platform/graphics/chromium/LayerTilerChromium.cpp:
12463 * platform/graphics/chromium/ShaderChromium.h:
12464 * platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
12465 * platform/graphics/transforms/AffineTransform.h:
12466 * platform/graphics/transforms/TransformationMatrix.h:
12467 * platform/image-decoders/ImageDecoder.cpp:
12468 * platform/image-decoders/ImageDecoder.h:
12469 * rendering/svg/RenderSVGResourceSolidColor.cpp:
12470
12471 2011-02-24 Pavel Feldman <pfeldman@chromium.org>
12472
12473 Reviewed by Yury Semikhatsky.
12474
12475 Web Inspector: follow up to 79566. USE_PARAM not declared
12476 https://bugs.webkit.org/show_bug.cgi?id=55155
12477
12478 * bindings/js/JSInjectedScriptHostCustom.cpp:
12479 (WebCore::JSInjectedScriptHost::currentCallFrame):
12480 * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
12481 (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
12482
12483 2011-02-24 Emil A Eklund <eae@chromium.org>
12484
12485 Reviewed by Simon Fraser.
12486
12487 Add support for missing properties to getComputedStyle
12488 https://bugs.webkit.org/show_bug.cgi?id=23668
12489
12490 Implement getComputedStyle for the content, counter and outline-offset
12491 properties.
12492
12493 Test: fast/css/getComputedStyle/computed-style-properties.html
12494
12495 * css/CSSComputedStyleDeclaration.cpp:
12496 (WebCore::contentToCSSValue):
12497 (WebCore::counterToCSSValue):
12498 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
12499 * css/CSSPrimitiveValue.cpp:
12500 (WebCore::CSSPrimitiveValue::cssText):
12501 * css/CSSPrimitiveValue.h:
12502
12503 2011-02-24 Eric Seidel <eric@webkit.org>
12504
12505 Reviewed by Adam Barth.
12506
12507 SegmentedString does not need an m_composite member
12508 https://bugs.webkit.org/show_bug.cgi?id=55083
12509
12510 Storing m_composite as distinct from m_substrings.isEmpty()
12511 was just error prone and eventually going to get us in trouble.
12512
12513 I also cleaned up some of the style in SegementedString.*
12514 since this file long predates check-webkit-style.
12515
12516 * platform/text/SegmentedString.cpp:
12517 (WebCore::SegmentedString::SegmentedString):
12518 (WebCore::SegmentedString::operator=):
12519 (WebCore::SegmentedString::length):
12520 (WebCore::SegmentedString::setExcludeLineNumbers):
12521 (WebCore::SegmentedString::clear):
12522 (WebCore::SegmentedString::append):
12523 (WebCore::SegmentedString::prepend):
12524 (WebCore::SegmentedString::advanceSubstring):
12525 (WebCore::SegmentedString::toString):
12526 * platform/text/SegmentedString.h:
12527 (WebCore::SegmentedSubstring::SegmentedSubstring):
12528 (WebCore::SegmentedSubstring::appendTo):
12529 (WebCore::SegmentedString::SegmentedString):
12530 (WebCore::SegmentedString::isComposite):
12531
12532 2011-02-24 David Kilzer <ddkilzer@apple.com>
12533
12534 BUILD FIX: Add missing include for UnusedParam.h
12535
12536 Not reviewed.
12537
12538 * platform/mac/FileSystemMac.mm: Add include. It should have
12539 originally been added with r76614.
12540
12541 2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
12542
12543 Reviewed by Alexey Proskuryakov.
12544
12545 DumpRenderTree should reset frame opener between tests.
12546 https://bugs.webkit.org/show_bug.cgi?id=54874
12547
12548 No new tests. (no code affected, just exporting a method for DumpRenderT ree use)
12549
12550 * WebCore.exp.in:
12551
12552 2011-02-24 Dirk Schulze <krit@webkit.org>
12553
12554 Reviewed by Darin Adler.
12555
12556 Removing a SVG animation target during animation crashes WebKit
12557 https://bugs.webkit.org/show_bug.cgi?id=12065
12558
12559 SVGAnimations with IRI references via 'xlink:href' are slow
12560 https://bugs.webkit.org/show_bug.cgi?id=49437
12561
12562 Store reference to target element for SVG animation elements. This is im portant if the
12563 target gets referenced via 'xlink:href'. At the moment we would call get ElementById() multiple
12564 times on every animation step. A very expensive operation. This will be avoided with this patch.
12565 On the other hand, we need to be sure that the target element is always valid. The reference is
12566 reset, if the target was removed from document or its destructor was cal led. A HashMap in
12567 SVGDocumentExtensions stores all mappings from target element to all cur rent animation elements.
12568
12569 Tests: svg/custom/animate-target-id-changed.svg
12570 svg/custom/animate-target-removed-from-document.svg
12571
12572 * svg/SVGDocumentExtensions.cpp:
12573 (WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
12574 (WebCore::SVGDocumentExtensions::addAnimationElementToTarget): New anima tion gets applied to target.
12575 (WebCore::SVGDocumentExtensions::removeAnimationElementFromTarget): Anim ation stoped, remove it from HashMap.
12576 (WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget): Target no longer in document, reset all
12577 references in SVG animation elements.
12578 * svg/SVGDocumentExtensions.h:
12579 * svg/SVGElement.cpp:
12580 (WebCore::SVGElement::~SVGElement):
12581 (WebCore::SVGElement::removedFromDocument):
12582 (WebCore::SVGElement::attributeChanged):
12583 * svg/SVGElement.h:
12584 * svg/SVGHKernElement.cpp:
12585 (WebCore::SVGHKernElement::removedFromDocument):
12586 * svg/SVGVKernElement.cpp:
12587 (WebCore::SVGVKernElement::removedFromDocument):
12588 * svg/animation/SVGSMILElement.cpp:
12589 (WebCore::SVGSMILElement::SVGSMILElement):
12590 (WebCore::SVGSMILElement::removedFromDocument):
12591 (WebCore::SVGSMILElement::eventBaseFor):
12592 (WebCore::SVGSMILElement::targetElement):
12593 * svg/animation/SVGSMILElement.h:
12594 (WebCore::SVGSMILElement::resetTargetElement):
12595
12596 2011-02-24 Simon Fraser <simon.fraser@apple.com>
12597
12598 Reviewed by Eric Seidel.
12599
12600 REGRESSION: Accelerated transitions are jumpy
12601 https://bugs.webkit.org/show_bug.cgi?id=55022
12602
12603 When an accelerated transition used the default timing function,
12604 a typo in toCAMediaTimingFunction() resulting in the incorrect
12605 timing function being used.
12606
12607 Test: transitions/default-timing-function.html
12608
12609 * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
12610 (toCAMediaTimingFunction):
12611
12612 2011-02-24 Andreas Kling <kling@webkit.org>
12613
12614 Reviewed by Kenneth Rohde Christiansen.
12615
12616 [Qt] Remove bogus optimizations in TextBreakIteratorQt
12617 https://bugs.webkit.org/show_bug.cgi?id=55139
12618
12619 Let QTextBoundaryFinder hold a deep copy of the string data it's
12620 operating on, and don't use the same working buffer for all iterators.
12621
12622 * platform/text/qt/TextBreakIteratorQt.cpp:
12623 (WebCore::TextBreakIterator::TextBreakIterator):
12624 (WebCore::setUpIterator):
12625
12626 2011-02-24 Andrey Adaikin <aandrey@google.com>
12627
12628 Reviewed by Pavel Feldman.
12629
12630 Web Inspector: [Text editor] Bug in the highlighter
12631 https://bugs.webkit.org/show_bug.cgi?id=54876
12632
12633 Tests: inspector/editor/highlighter-long-line.html
12634 inspector/editor/highlighter-paste-in-comment.html
12635
12636 * inspector/front-end/TextEditorHighlighter.js:
12637 (WebInspector.TextEditorHighlighter):
12638 (WebInspector.TextEditorHighlighter.prototype.set highlightChunkLimit):
12639 (WebInspector.TextEditorHighlighter.prototype.updateHighlight):
12640 (WebInspector.TextEditorHighlighter.prototype._highlightLines):
12641
12642 2011-02-24 James Simonsen <simonjam@chromium.org>
12643
12644 Reviewed by Tony Gentilcore.
12645
12646 [Web Timing] Zero out navigationStart and unloadEvent on cross-origin re direct
12647 https://bugs.webkit.org/show_bug.cgi?id=55068
12648
12649 Test: http/tests/misc/webtiming-origins.html
12650
12651 * page/PerformanceTiming.cpp:
12652 (WebCore::PerformanceTiming::navigationStart): Zero out on cross origin redirect.
12653 (WebCore::PerformanceTiming::unloadEventStart): Ditto.
12654 (WebCore::PerformanceTiming::unloadEventEnd): Ditto.
12655
12656 2011-02-24 Adam Klein <adamk@chromium.org>
12657
12658 Reviewed by Darin Fisher.
12659
12660 [chromium] Add code to WebKit Chromium to allow access to NetworkStateNo tifier
12661 https://bugs.webkit.org/show_bug.cgi?id=54516
12662
12663 Give Chromium's NetworkStateNotifier the ability to change the value
12664 of m_isOnLine, rather than making it always true.
12665
12666 No new tests, not sure how to test this. No other LayoutTests seem
12667 to exercise navigator.onLine.
12668
12669 * WebCore.gypi:
12670 * platform/network/NetworkStateNotifier.cpp:
12671 (WebCore::NetworkStateNotifier::setOnLine): Moved and renamed from Netwo rkStateNotifierAndroid.
12672 * platform/network/NetworkStateNotifier.h:
12673 (WebCore::NetworkStateNotifier::networkStateChange): Forward to setOnLin e.
12674 * platform/network/android/NetworkStateNotifierAndroid.cpp: Removed.
12675 * platform/network/chromium/NetworkStateNotifierChromium.cpp: Removed.
12676 * platform/network/chromium/NetworkStateNotifierPrivate.h: Removed.
12677
12678 2011-02-24 Benjamin Poulain <benjamin.poulain@nokia.com>
12679
12680 Reviewed by Eric Seidel.
12681
12682 Support building WebKit with Python 3
12683 https://bugs.webkit.org/show_bug.cgi?id=55038
12684
12685 Add support for Python 3 without breaking support for Python 2.
12686
12687 Main issues:
12688 -print is a function in Python 3
12689 -list.sort() no longer have the cmp parameter
12690 -string.uppercase and string.lowercase have been removed
12691
12692 * html/parser/create-html-entity-table:
12693
12694 2011-02-24 Chris Fleizach <cfleizach@apple.com>
12695
12696 Reviewed by Eric Seidel.
12697
12698 AX: WebKit should expose MathML at least as well as it exposes ARIA role ="math"
12699 https://bugs.webkit.org/show_bug.cgi?id=55049
12700
12701 Make <math> elements behave as ARIA math roles and use MathML::alttext a s a
12702 possible accessible label.
12703
12704 Test: platform/mac/accessibility/math-alttext.html
12705
12706 * accessibility/AccessibilityRenderObject.cpp:
12707 (WebCore::AccessibilityRenderObject::accessibilityDescription):
12708 (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
12709 * mathml/mathattrs.in:
12710
12711 2011-02-24 Ilya Tikhonovsky <loislo@chromium.org>
12712
12713 Reviewed by Pavel Feldman.
12714
12715 Web Inspector: adjust protocol message format according to spec.
12716 https://bugs.webkit.org/show_bug.cgi?id=55140
12717
12718 * inspector/CodeGeneratorInspector.pm:
12719
12720 2011-02-24 Adam Roben <aroben@apple.com>
12721
12722 Windows Production build fix
12723
12724 * platform/network/cf/AuthenticationCF.cpp: Add an extra #include as a w orkaround for
12725 <rdar://problem/9042114>.
12726
12727 2011-02-23 Pavel Feldman <pfeldman@chromium.org>
12728
12729 Reviewed by Yury Semikhatsky.
12730
12731 Web Inspector: refactor inspect() workflow so that it did not push dom n odes.
12732 https://bugs.webkit.org/show_bug.cgi?id=55057
12733
12734 Test: inspector/console/command-line-api-inspect.html
12735
12736 I am working on getting rid of DOM agent pushes - everything should happ en upon
12737 front-end request. This patch changes the way we handle inspect() comman d line
12738 api: instead of pushing nodes, we are telling front-end that inspect(obj ect) has
12739 been requested. It is then up to front-end to request dom nodes and focu s them in
12740 the tree. I also made inspect() work in a generic manner, using same rou tines for
12741 nodes, databases, storages and potentially new elements.
12742
12743 As a side-effect, we don't do console.log from within inspect() anymore, but dump
12744 inspected value as inspect's result.
12745
12746 Also, I added individual object release method and made object groups op tional.
12747
12748 * bindings/js/JSInjectedScriptHostCustom.cpp:
12749 (WebCore::InjectedScriptHost::scriptValueAsNode):
12750 (WebCore::InjectedScriptHost::nodeAsScriptValue):
12751 (WebCore::JSInjectedScriptHost::inspect):
12752 (WebCore::JSInjectedScriptHost::databaseId):
12753 (WebCore::JSInjectedScriptHost::storageId):
12754 * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
12755 (WebCore::InjectedScriptHost::scriptValueAsNode):
12756 (WebCore::InjectedScriptHost::nodeAsScriptValue):
12757 (WebCore::V8InjectedScriptHost::inspectCallback):
12758 (WebCore::V8InjectedScriptHost::databaseIdCallback):
12759 (WebCore::V8InjectedScriptHost::storageIdCallback):
12760 * inspector/InjectedScript.cpp:
12761 (WebCore::InjectedScript::nodeForObjectId):
12762 (WebCore::InjectedScript::releaseObject):
12763 (WebCore::InjectedScript::wrapForConsole):
12764 (WebCore::InjectedScript::inspectNode):
12765 * inspector/InjectedScript.h:
12766 * inspector/InjectedScriptHost.cpp:
12767 (WebCore::InjectedScriptHost::inspectImpl):
12768 (WebCore::InjectedScriptHost::databaseIdImpl):
12769 (WebCore::InjectedScriptHost::storageIdImpl):
12770 * inspector/InjectedScriptHost.h:
12771 * inspector/InjectedScriptHost.idl:
12772 * inspector/InjectedScriptSource.js:
12773 * inspector/Inspector.idl:
12774 * inspector/InspectorAgent.cpp:
12775 (WebCore::InspectorAgent::focusNode):
12776 * inspector/InspectorDOMAgent.cpp:
12777 * inspector/InspectorDOMAgent.h:
12778 * inspector/InspectorDOMStorageAgent.cpp:
12779 (WebCore::InspectorDOMStorageAgent::storageId):
12780 (WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
12781 * inspector/InspectorDOMStorageAgent.h:
12782 * inspector/InspectorDOMStorageResource.cpp:
12783 * inspector/InspectorDOMStorageResource.h:
12784 * inspector/InspectorDatabaseAgent.cpp:
12785 (WebCore::InspectorDatabaseAgent::databaseId):
12786 * inspector/InspectorDatabaseAgent.h:
12787 * inspector/InspectorDatabaseResource.cpp:
12788 * inspector/InspectorDatabaseResource.h:
12789 * inspector/InspectorRuntimeAgent.cpp:
12790 (WebCore::InspectorRuntimeAgent::releaseObject):
12791 * inspector/InspectorRuntimeAgent.h:
12792 * inspector/front-end/AuditRules.js:
12793 (WebInspector.AuditRules.evaluateInTargetWindow):
12794 (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
12795 * inspector/front-end/DOMStorage.js:
12796 * inspector/front-end/Database.js:
12797 * inspector/front-end/ExtensionServer.js:
12798 (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
12799 * inspector/front-end/inspector.js:
12800 (WebInspector.inspect):
12801
12802 2011-02-22 Pavel Podivilov <podivilov@chromium.org>
12803
12804 Reviewed by Pavel Feldman.
12805
12806 Web Inspector: refactor "script or resource" mess in scripts panel.
12807 https://bugs.webkit.org/show_bug.cgi?id=54961
12808
12809 - Use sourceName instead of scriptOrResource
12810 - Replace two huge functions _addScriptToFilesMenu and _showScriptOrReso urce that are
12811 calling each other recursively with small one-purpose non-recursive fu nctions
12812
12813 Test: inspector/debugger/scripts-panel.html
12814
12815 * inspector/front-end/ScriptsPanel.js:
12816 (WebInspector.ScriptsPanel):
12817 (WebInspector.ScriptsPanel.prototype.get defaultFocusedElement):
12818 (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
12819 (WebInspector.ScriptsPanel.prototype._addScript):
12820 (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
12821 (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelectAndShowSourc eFrameIfNeeded):
12822 (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompa re):
12823 (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
12824 (WebInspector.ScriptsPanel.prototype.reset):
12825 (WebInspector.ScriptsPanel.prototype.canShowSourceLine):
12826 (WebInspector.ScriptsPanel.prototype.showSourceLine):
12827 (WebInspector.ScriptsPanel.prototype._showSourceFrame):
12828 (WebInspector.ScriptsPanel.prototype._sourceFrameForSourceName):
12829 (WebInspector.ScriptsPanel.prototype._recreateSourceFrame):
12830 (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
12831 (WebInspector.ScriptsPanel.prototype._addItemToBackForwardList):
12832 (WebInspector.ScriptsPanel.prototype._sourceNameForScript):
12833 (WebInspector.ScriptsPanel.prototype._scriptForSourceName):
12834 (WebInspector.ScriptsPanel.prototype._callFrameSelected):
12835 (WebInspector.ScriptsPanel.prototype._filesSelectChanged):
12836 (WebInspector.ScriptsPanel.prototype._goBack):
12837 (WebInspector.ScriptsPanel.prototype._goForward):
12838 * inspector/front-end/SourceFrame.js:
12839 (WebInspector.SourceFrame.prototype.setExecutionLine):
12840
12841 2011-02-24 Eric Seidel <eric@webkit.org>
12842
12843 Reviewed by Adam Barth.
12844
12845 Fragment parsing does not need to use HTMLSourceTracker
12846 https://bugs.webkit.org/show_bug.cgi?id=55011
12847
12848 Any performance gains from this patch are likely
12849 the result of working around:
12850 https://bugs.webkit.org/show_bug.cgi?id=55005
12851 (Which suggests that fixing bug 55005 will speed
12852 up normal HTML parsing substantially.)
12853
12854 Assuming I ran the numbers correct, here is the
12855 change from PerformanceTests/Parser/tiny-innerHTML:
12856 Before patch:
12857 avg 5586.1
12858 median 5594
12859 stdev 41.295157101045135
12860 min 5425
12861 max 5633
12862
12863 After Patch:
12864 avg 2603.9
12865 median 2609.5
12866 stdev 32.500615378789355
12867 min 2475
12868 max 2649
12869
12870 Removing just the HTMLSourceTracker calls brought our
12871 score from 5500 to 5200, removing the XSSFilter as well
12872 brought it to 2600 on my machine.
12873
12874 * html/parser/HTMLDocumentParser.cpp:
12875 (WebCore::HTMLDocumentParser::HTMLDocumentParser):
12876 (WebCore::HTMLDocumentParser::pumpTokenizer):
12877 * html/parser/HTMLDocumentParser.h:
12878
12879 2011-02-24 Andras Becsi <abecsi@webkit.org>
12880
12881 Reviewed by Laszlo Gombos.
12882
12883 [Qt] MinGW build fails to link
12884 https://bugs.webkit.org/show_bug.cgi?id=55050
12885
12886 Prepend the libraries of subcomponents instead of appending them
12887 to fix the library order according to the dependency of the libraries
12888
12889 No new tests needed.
12890
12891 * WebCore.pri:
12892
12893 2011-02-24 Adam Barth <abarth@webkit.org>
12894
12895 Reviewed by Eric Seidel.
12896
12897 CSP's script-src should block JavaScript URLs
12898 https://bugs.webkit.org/show_bug.cgi?id=54787
12899
12900 Blocking JavaScript URLs required some re-architecting of the lifetime
12901 of the ContentSecurityPolicy object. We now manage the lifetime the
12902 same way we manage the lifetime of the SecurityOrigin object. In
12903 particular, when SecurityOrigin inherits into an about:blank iframe, we
12904 inherit the CSP object as well. (This is covered by the test added in
12905 this patch.) In the future, we might consider making
12906 ContentSecurityPolicy a component of SecurityOrigin instead of a
12907 component of Document.
12908
12909 I noted the trickiness in
12910 http://www.w3.org/Security/wiki/Content_Security_Policies so that we'll
12911 make sure it gets defined properly in the spec.
12912
12913 Test: http/tests/security/contentSecurityPolicy/javascript-url.html
12914
12915 * bindings/ScriptControllerBase.cpp:
12916 (WebCore::ScriptController::executeIfJavaScriptURL):
12917 * dom/Document.cpp:
12918 (WebCore::Document::initSecurityContext):
12919 * dom/Document.h:
12920 (WebCore::Document::contentSecurityPolicy):
12921 * page/ContentSecurityPolicy.cpp:
12922 (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
12923 * page/ContentSecurityPolicy.h:
12924 (WebCore::ContentSecurityPolicy::create):
12925
12926 2011-02-21 Philippe Normand <pnormand@igalia.com>
12927
12928 Reviewed by Martin Robinson.
12929
12930 [GStreamer] GRefPtr support for GstElement
12931 https://bugs.webkit.org/show_bug.cgi?id=54870
12932
12933 * CMakeListsEfl.txt:
12934 * GNUmakefile.am:
12935 * platform/graphics/gstreamer/GRefPtrGStreamer.cpp: Added.
12936 (WTF::GstElement):
12937 * platform/graphics/gstreamer/GRefPtrGStreamer.h: Added.
12938 * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
12939 (webKitWebSrcQuery):
12940
12941 2011-02-24 Emil A Eklund <eae@chromium.org>
12942
12943 Reviewed by Eric Seidel.
12944
12945 Share code between elementFromPoint and caretRangeFromPoint in Document.
12946 https://bugs.webkit.org/show_bug.cgi?id=54610
12947
12948 Eliminate duplicate code by moving shared logic from elementFromPoint an d
12949 caretRangeFromPoint into helper function.
12950
12951 * dom/Document.cpp:
12952 (WebCore::nodeFromPoint):
12953 (WebCore::Document::elementFromPoint):
12954 (WebCore::Document::caretRangeFromPoint):
12955
12956 2011-02-24 Ilya Tikhonovsky <loislo@chromium.org>
12957
12958 Unreviewed build fix.
12959
12960 * inspector/InspectorDOMAgent.cpp:
12961 (WebCore::InspectorDOMAgent::removeAttribute):
12962 * inspector/InspectorResourceAgent.cpp:
12963 (WebCore::InspectorResourceAgent::cachedResources):
12964 * inspector/InspectorRuntimeAgent.cpp:
12965 (WebCore::InspectorRuntimeAgent::evaluate):
12966
12967 2011-02-24 Zan Dobersek <zandobersek@gmail.com>
12968
12969 Reviewed by Eric Seidel.
12970
12971 [gtk] Failing collinear arcTo canvas tests
12972 https://bugs.webkit.org/show_bug.cgi?id=54658
12973
12974 Check for collinearity of the three points that affect how arcTo call
12975 results. This behavior is in accordance with the HTML standard.
12976
12977 No new tests added as this is already covered by at least two tests.
12978
12979 * platform/graphics/cairo/PathCairo.cpp:
12980 (WebCore::areaOfTriangleFormedByPoints):
12981 (WebCore::Path::addArcTo):
12982
12983 2011-02-24 Ilya Tikhonovsky <loislo@chromium.org>
12984
12985 Reviewed by Pavel Feldman.
12986
12987 Web Inspector: There is a validator of the protocol message format.
12988
12989 It has two parts. InspectorBackendStub.js is the frontend part.
12990 InspectorBackendDispatcher.cpp is the backend part.
12991 Both parts are checking protocol message format and report the error if
12992 the message has not enough fields or the types of fields do not match wi th
12993 Inspector.idl specification. These validators are generated automaticall y.
12994
12995 In addition, we have a number of places at the backend where we check th e
12996 function arguments and do nothing if the arguments are invalid
12997 from the business logic point of view.
12998
12999 This patch bring us an ability to report a custom error from such functi on to the frontend.
13000
13001 https://bugs.webkit.org/show_bug.cgi?id=54971
13002
13003 * inspector/CodeGeneratorInspector.pm:
13004 * inspector/InjectedScriptHost.cpp:
13005 * inspector/InspectorAgent.cpp:
13006 * inspector/InspectorAgent.h:
13007 * inspector/InspectorApplicationCacheAgent.cpp:
13008 * inspector/InspectorApplicationCacheAgent.h:
13009 * inspector/InspectorBrowserDebuggerAgent.cpp:
13010 * inspector/InspectorBrowserDebuggerAgent.h:
13011 * inspector/InspectorCSSAgent.cpp:
13012 * inspector/InspectorCSSAgent.h:
13013 * inspector/InspectorConsoleAgent.cpp:
13014 * inspector/InspectorConsoleAgent.h:
13015 * inspector/InspectorController.cpp:
13016 * inspector/InspectorDOMAgent.cpp:
13017 * inspector/InspectorDOMAgent.h:
13018 * inspector/InspectorDOMStorageAgent.cpp:
13019 * inspector/InspectorDOMStorageAgent.h:
13020 * inspector/InspectorDatabaseAgent.cpp:
13021 * inspector/InspectorDatabaseAgent.h:
13022 * inspector/InspectorDebuggerAgent.cpp:
13023 * inspector/InspectorDebuggerAgent.h:
13024 * inspector/InspectorProfilerAgent.cpp:
13025 * inspector/InspectorProfilerAgent.h:
13026 * inspector/InspectorResourceAgent.cpp:
13027 * inspector/InspectorResourceAgent.h:
13028 * inspector/InspectorRuntimeAgent.cpp:
13029 * inspector/InspectorRuntimeAgent.h:
13030 * inspector/InspectorTimelineAgent.cpp:
13031 * inspector/InspectorTimelineAgent.h:
13032
13033 2011-02-24 Ryosuke Niwa <rniwa@webkit.org>
13034
13035 Reviewed by Ojan Vafai.
13036
13037 Crash when deleting inside a blockquote with a large offset
13038 https://bugs.webkit.org/show_bug.cgi?id=55098
13039
13040 The bug was caused by inconsistency in lineBreakExistsAtPosition and bre akOutOfEmptyMailBlockquotedParagraph.
13041 While lineBreakExistsAtPosition was checking that a line break exists at the downstream of the given position,
13042 breakOutOfEmptyMailBlockquotedParagraph wasn't using the downstream for caretPos. Fixed the bug by using
13043 the downstream position to instantiate caretPos.
13044
13045 Co-author: Abhishek Arya <inferno@chromium.org>.
13046
13047 Test: editing/deleting/delete-blockquote-large-offsets.html
13048
13049 * editing/CompositeEditCommand.cpp:
13050 (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph) :
13051
13052 2011-02-24 Robert Kroeger <rjkroege@chromium.org>
13053
13054 Reviewed by Darin Fisher.
13055
13056 Added timestamps to PlatformTouchEvent etc.
13057
13058 PlatformTouchEvent doesn't have a timestamp and so
13059 eventSender.leapForward cannot be used for touchevent based tests.
13060 This change adds a timestamp to PlatformTouchEvent and initializes
13061 it in a reasonable manner on Android and Qt platforms.
13062
13063 [chromium] [WebCore] [android] Touch events are missing time stamps
13064 https://bugs.webkit.org/show_bug.cgi?id=53510
13065
13066 * platform/PlatformTouchEvent.h:
13067 (WebCore::PlatformTouchEvent::PlatformTouchEvent):
13068 (WebCore::PlatformTouchEvent::timestamp):
13069 * platform/android/PlatformTouchEventAndroid.cpp:
13070 (WebCore::PlatformTouchEvent::PlatformTouchEvent):
13071 * platform/qt/PlatformTouchEventQt.cpp:
13072 (WebCore::PlatformTouchEvent::PlatformTouchEvent):
13073
13074 2011-02-24 Renata Hodovan <reni@webkit.org>
13075
13076 Unreviewed GTK, Snow Leopard build fix for r79474.
13077
13078 * platform/graphics/filters/FEConvolveMatrix.cpp:
13079 (WebCore::FEConvolveMatrix::setKernelUnitLength):
13080 * platform/graphics/filters/FEConvolveMatrix.h:
13081
13082 2011-02-24 Carlos Garcia Campos <cgarcia@igalia.com>
13083
13084 Reviewed by Xan Lopez.
13085
13086 Use IntRect instead of a pointer to a GtkAllocation struct to avoid
13087 unnecessary memory allocations.
13088
13089 * plugins/PluginView.h:
13090 * plugins/gtk/PluginViewGtk.cpp:
13091 (WebCore::PluginView::setNPWindowIfNeeded):
13092 (WebCore::PluginView::plugAddedCallback):
13093
13094 2011-02-24 Carlos Garcia Campos <cgarcia@igalia.com>
13095
13096 Unreviewed. Fix the build with GTK+ 3.
13097
13098 * plugins/PluginView.h:
13099
13100 2011-02-23 Ryosuke Niwa <rniwa@webkit.org>
13101
13102 Reviewed by Darin Adler.
13103
13104 Refactor HTMLEquivalent into a hierachy of classes
13105 https://bugs.webkit.org/show_bug.cgi?id=55025
13106
13107 Converted HTMLEquivalent into a class. Some logic in removeImplicitlySt yledElement is
13108 extracted as member functions of HTMLEquivalent and its subclasses.
13109
13110 * editing/ApplyStyleCommand.cpp:
13111 (WebCore::HTMLEquivalent::create): Added.
13112 (WebCore::HTMLEquivalent::~HTMLEquivalent): Added.
13113 (WebCore::HTMLEquivalent::matches): Returns true if the element is an eq uivalent, meaning that
13114 the element's implicit style affects the property of this equivalence.
13115 (WebCore::HTMLEquivalent::hasAttribute): Returns true if this equivalenc e requires attributes;
13116 e.g. color, size, dir.
13117 (WebCore::HTMLEquivalent::propertyExistsInStyle): Returns true if the pr operty of this equivalence
13118 exists in the specified style. e.g. if this equivalence is for size attr ibute and font-size property,
13119 this function returns true if the specified style has font-size property set.
13120 (WebCore::HTMLEquivalent::HTMLEquivalent): Added.
13121 (WebCore::HTMLEquivalent::valueIsPresentInStyle): Returns true if the sp ecified style has the
13122 implicit style of the specified element of this equivalence.
13123 (WebCore::HTMLEquivalent::addToStyle): Adds the implicit style of the el ement of this equivalence
13124 to the specified mutable style.
13125 (WebCore::HTMLEquivalentValueList::create): Added.
13126 (WebCore::HTMLEquivalentValueList::HTMLEquivalentValueList): Added.
13127 (WebCore::HTMLEquivalentValueList::valueIsPresentInStyle): Added.
13128 (WebCore::HTMLEquivalentAttribute::create): Added.
13129 (WebCore::HTMLEquivalentAttribute::matches): Added.
13130 (WebCore::HTMLEquivalentAttribute::hasAttribute): Added.
13131 (WebCore::HTMLEquivalentAttribute::attributeName): Added.
13132 (WebCore::HTMLEquivalentAttribute::HTMLEquivalentAttribute): Added.
13133 (WebCore::HTMLEquivalentAttribute::valueIsPresentInStyle): Added.
13134 (WebCore::HTMLEquivalentAttribute::addToStyle): Added.
13135 (WebCore::HTMLEquivalentAttribute::attributeValueAsCSSValue): Added.
13136 (WebCore::HTMLEquivalentFontSizeAttribute::create): Added.
13137 (WebCore::HTMLEquivalentFontSizeAttribute::HTMLEquivalentFontSizeAttribu te): Added.
13138 (WebCore::HTMLEquivalentFontSizeAttribute::attributeValueAsCSSValue): Ad ded.
13139 (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Uses new cl asses.
13140
13141 2011-02-23 Sheriff Bot <webkit.review.bot@gmail.com>
13142
13143 Unreviewed, rolling out r79510.
13144 http://trac.webkit.org/changeset/79510
13145 https://bugs.webkit.org/show_bug.cgi?id=55114
13146
13147 It made ~200 tests crash on Qt bot (Requested by Ossy_ on
13148 #webkit).
13149
13150 * platform/text/TextBreakIterator.h:
13151 * platform/text/TextBreakIteratorICU.cpp:
13152 (WebCore::lineBreakIterator):
13153 * platform/text/qt/TextBreakIteratorQt.cpp:
13154 (WebCore::lineBreakIterator):
13155 * rendering/RenderBlock.h:
13156 * rendering/RenderBlockLineLayout.cpp:
13157 (WebCore::RenderBlock::layoutInlineChildren):
13158 (WebCore::RenderBlock::findNextLineBreak):
13159 * rendering/RenderText.cpp:
13160 (WebCore::RenderText::computePreferredLogicalWidths):
13161 * rendering/break_lines.cpp:
13162 (WebCore::nextBreakablePosition):
13163 * rendering/break_lines.h:
13164 (WebCore::isBreakable):
13165
13166 2011-02-23 Geoffrey Garen <ggaren@apple.com>
13167
13168 Reviewed by Mark Rowe.
13169
13170 Used svn merge -r79502:79501 to roll out r79502 because it broke the
13171 SnowLeopard and Leopard builds.
13172
13173 * WebCore.xcodeproj/project.pbxproj:
13174 * platform/mac/HTMLConverter.h: Removed.
13175 * platform/mac/HTMLConverter.mm: Removed.
13176 * platform/mac/PasteboardMac.mm:
13177 (WebCore::Pasteboard::writeSelection):
13178
13179 2011-02-23 Beth Dakin <bdakin@apple.com>
13180
13181 Reviewed by Dan Bernstein.
13182
13183 Fix for <rdar://problem/9002157> Garbage in the bottom right corner of t he window
13184 when scrolling
13185
13186 When there is both a horizontal and a vertical scrollbar, it is necessar y to
13187 include the space between them in the invalidation.
13188 * platform/ScrollableArea.cpp:
13189 (WebCore::ScrollableArea::setScrollOffsetFromAnimation):
13190
13191 2011-02-23 Ned Holbrook <nholbrook@apple.com>
13192
13193 Reviewed by Dan Bernstein.
13194
13195 Minimize calls to ubrk_setText()
13196 https://bugs.webkit.org/show_bug.cgi?id=54912
13197 <rdar://problem/9032774>
13198
13199 Avoid calling ubrk_setText() once per call to isBreakable() by using a L azyLineBreakIterator, which defers
13200 break iterator creation until needed. This requires replacing the global line break iterator primitive with a
13201 version that can be nested, since in some cases two iterators may need t o be outstanding. In particular,
13202 layoutInlineChildren() may indirectly call computePreferredLogicalWidths () and each may need an iterator.
13203 In a test with a paragraph of Japanese text, this reduced the number of ubrk_setText() calls from 164 to 1.
13204
13205 * platform/text/TextBreakIterator.h: Add LazyLineBreakIterator.
13206 (WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
13207 (WebCore::LazyLineBreakIterator::~LazyLineBreakIterator):
13208 (WebCore::LazyLineBreakIterator::string):
13209 (WebCore::LazyLineBreakIterator::length):
13210 (WebCore::LazyLineBreakIterator::get):
13211 (WebCore::LazyLineBreakIterator::reset):
13212 * platform/text/TextBreakIteratorICU.cpp: Replace lineBreakIterator() pr imitive with acquireLineBreakIterator()/releaseLineBreakIterator().
13213 (WebCore::acquireLineBreakIterator):
13214 (WebCore::releaseLineBreakIterator):
13215 * platform/text/qt/TextBreakIteratorQt.cpp: Ditto TextBreakIteratorICU.c pp.
13216 (WebCore::acquireLineBreakIterator):
13217 (WebCore::releaseLineBreakIterator):
13218 * rendering/RenderBlock.h:
13219 * rendering/RenderBlockLineLayout.cpp:
13220 (WebCore::RenderBlock::layoutInlineChildren): Pass a mapping of RenderTe xt to LazyLineBreakIterator from one call of findNextLineBreak() to the next.
13221 (WebCore::RenderBlock::findNextLineBreak): Use said mapping, resetting L azyLineBreakIterator for any newly-encountered RenderText.
13222 * rendering/RenderText.cpp: Use a local LazyLineBreakIterator.
13223 (WebCore::RenderText::computePreferredLogicalWidths):
13224 * rendering/break_lines.cpp: Accept LazyLineBreakIterator rather than Te xtBreakIterator.
13225 (WebCore::nextBreakablePosition):
13226 * rendering/break_lines.h: Accept LazyLineBreakIterator rather than Text BreakIterator.
13227 (WebCore::isBreakable):
13228
13229 2011-02-23 Anders Carlsson <andersca@apple.com>
13230
13231 Fix build.
13232
13233 * platform/mac/HTMLConverter.h:
13234
13235 2011-02-17 Enrica Casucci <enrica@apple.com>
13236
13237 Reviewed by Darin Adler.
13238
13239 REGRESSION: Copied content loses formatting on paste to external apps.
13240 https://bugs.webkit.org/show_bug.cgi?id=47615
13241 <rdar://problem/9001214>
13242
13243 This patch adds a way for WebKit2 to create NSAttributedStrings from
13244 a DOM range without using the AppKit api initWithDOMRange that internall y
13245 needs to access the WebView. The NSAttributedString is needed to create
13246 RTF formats in the pasteboard.
13247 This is to be considered a first step, since in the future we want to ha ve
13248 an implementation based on the TextIterator.
13249
13250 * WebCore.xcodeproj/project.pbxproj: Added new file.
13251 * platform/mac/HTMLConverter.h: Added.
13252 * platform/mac/HTMLConverter.mm: Added.
13253 * platform/mac/PasteboardMac.mm:
13254 (WebCore::Pasteboard::writeSelection): We now use WebHTMLConverter
13255 class for WebKit2 to create the NSAttributedString from the DOM range.
13256
13257 2011-02-23 David Hyatt <hyatt@apple.com>
13258
13259 Reviewed by Sam Weinig.
13260
13261 https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
13262
13263 Patch computePositionedLogicalHeightUsing to be writing-mode-aware.
13264
13265 * rendering/RenderBox.cpp:
13266 (WebCore::RenderBox::computePositionedLogicalWidthUsing):
13267 (WebCore::RenderBox::computePositionedLogicalHeightUsing):
13268 * rendering/RenderBox.h:
13269
13270 2011-02-23 Martin Robinson <mrobinson@igalia.com>
13271
13272 Reviewed by Xan Lopez.
13273
13274 [Gtk] Flash item placed on wrong location right after load
13275 https://bugs.webkit.org/show_bug.cgi?id=37769
13276
13277 If a plugin is GtkSocket based, do not set the widget allocation until t he
13278 window is actually embedded in the parent. When the window is embedded, use
13279 any pending allocation for the call to gtk_widget_size_allocate. This bu g
13280 seems to only appear with Flash movies loaded as the src of an iframe.
13281
13282 * manual-tests/plugins/windowed-in-iframe.html: Added.
13283 * plugins/PluginView.h: Add a few new members to track window embedding state.
13284 * plugins/gtk/PluginViewGtk.cpp:
13285 (WebCore::PluginView::setNPWindowIfNeeded): If this is a GtkSocket-based plugin
13286 wait until the plug-added signal fires to set the widget allocation.
13287 (WebCore::PluginView::plugAddedCallback): Updated to be a static method, so that
13288 we can access private members. If there is a pending allocation, call gt k_widget_size_allocate
13289 with it.
13290 (WebCore::PluginView::platformStart): Update the plugin state, so that w e do not
13291 call gtk_widget_size_allocate if the window isn't embedded.
13292
13293 2011-02-18 Enrica Casucci <enrica@apple.com>
13294
13295 Reviewed by Adam Roben.
13296
13297 Mac OS X Services are not available for selected text in WebKit2 windows .
13298 https://bugs.webkit.org/show_bug.cgi?id=54777
13299 <rdar://problem/8666428>
13300
13301 The changes to WebCore for this bug are limited to exposing a new
13302 entry point in the Editor class to write to the pasteboard and
13303 changes to the Pasteboard class to write the selection with
13304 a given set of pasteboard types. The majority of the work
13305 is done in WebKit2.
13306
13307 * WebCore.exp.in:
13308 * editing/Editor.h:
13309 * editing/mac/EditorMac.mm: Added entrypoint to write the
13310 selection to the pasteboard.
13311 (WebCore::Editor::writeSelectionToPasteboard):
13312 * platform/Pasteboard.h:
13313 * platform/mac/ClipboardMac.mm:
13314 (WebCore::ClipboardMac::writeRange):
13315 * platform/mac/PasteboardMac.mm:
13316 (WebCore::Pasteboard::writeSelection):
13317
13318 2011-02-23 David Hyatt <hyatt@apple.com>
13319
13320 Reviewed by Simon Fraser.
13321
13322 https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
13323
13324 Patch computePositionedLogicalHeight to be writing-mode-aware. Function s it calls have not been
13325 patched yet, so still not testable in a vertical text environment.
13326
13327 * rendering/RenderBox.cpp:
13328 (WebCore::RenderBox::computePositionedLogicalHeight):
13329
13330 2011-02-23 David Hyatt <hyatt@apple.com>
13331
13332 Reviewed by Sam Weinig.
13333
13334 https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
13335
13336 Patch computePositionedLogicalWidthUsing to be writing-mode-aware. Still not testable in a vertical text
13337 environment, since height computations will overwrite all values compute d here until they are patched as well.
13338
13339 * rendering/RenderBox.cpp:
13340 (WebCore::RenderBox::computePositionedLogicalWidthUsing):
13341 * rendering/RenderBox.h:
13342
13343 2011-02-23 Renata Hodovan <reni@webkit.org>
13344
13345 Reviewed by Nikolas Zimmermann.
13346
13347 FEColorMatrixElement changes doesn't require relayout
13348 https://bugs.webkit.org/show_bug.cgi?id=54880
13349
13350 When the FEColorMatrixElement receives an update message but the given v alue remains the same we don't need
13351 to relayout the filter.
13352
13353 No new tests are needed because this modificiation is covered by the dyn amic update tests of FEColorMatrix.
13354
13355 * platform/graphics/filters/FEColorMatrix.cpp:
13356 (WebCore::FEColorMatrix::setType):
13357 (WebCore::FEColorMatrix::setValues):
13358 * platform/graphics/filters/FEColorMatrix.h:
13359 * svg/SVGFEColorMatrixElement.cpp:
13360 (WebCore::SVGFEColorMatrixElement::setFilterEffectAttribute):
13361 (WebCore::SVGFEColorMatrixElement::svgAttributeChanged):
13362 * svg/SVGFEColorMatrixElement.h:
13363
13364 2011-02-23 James Robinson <jamesr@chromium.org>
13365
13366 REGRESSION(79466): fast/parser/test-unicode-characters-in-attribute-name .html fails
13367
13368 Reverts TextCodecUTF16.cpp back to pre-79466 state. The crash fix in 79 466 was for UTF-8 only, it also caused the UTF16 path to fail.
13369
13370 * platform/text/TextCodecUTF16.cpp:
13371 (WebCore::newStreamingTextDecoderUTF16LE):
13372 (WebCore::newStreamingTextDecoderUTF16BE):
13373 (WebCore::TextCodecUTF16::decode):
13374 (WebCore::TextCodecUTF16::encode):
13375
13376 2011-02-23 David Hyatt <hyatt@apple.com>
13377
13378 Reviewed by Sam Weinig.
13379
13380 https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
13381
13382 Patch computePositionedLogicalWidth to be writing-mode-aware. Functions it calls have not been
13383 patched yet, so still not testable in a vertical text environment.
13384
13385 * rendering/RenderBox.cpp:
13386 (WebCore::RenderBox::computePositionedLogicalWidth):
13387
13388 2011-02-23 James Robinson <jamesr@chromium.org>
13389
13390 Unreviewed, rolling out r79428.
13391 http://trac.webkit.org/changeset/79428
13392 https://bugs.webkit.org/show_bug.cgi?id=54714
13393
13394 Does not work in the Chromium sandbox
13395
13396 * websockets/WebSocketHandshake.cpp:
13397 (WebCore::generateSecWebSocketKey):
13398 (WebCore::generateKey3):
13399
13400 2011-02-23 David Hyatt <hyatt@apple.com>
13401
13402 Reviewed by Sam Weinig.
13403
13404 https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
13405
13406 Add logical accessors for the left()/right()/top()/bottom() properties o n the RenderStyle.
13407
13408 * rendering/style/RenderStyle.h:
13409 (WebCore::InheritedFlags::logicalLeft):
13410 (WebCore::InheritedFlags::logicalRight):
13411 (WebCore::InheritedFlags::logicalTop):
13412 (WebCore::InheritedFlags::logicalBottom):
13413
13414 2011-02-23 Darin Adler <darin@apple.com>
13415
13416 Reviewed by Alexey Proskuryakov.
13417
13418 Fix crash seen in one of the regression tests.
13419
13420 * platform/text/TextCodecUTF16.cpp:
13421 (WebCore::TextCodecUTF16::decode): Handle case where we did not decode a ny new data,
13422 we were not told to flush, and we had a buffered byte. The assertion her e was incorrect,
13423 and the correct thing to do is nothing.
13424
13425 2011-02-23 Sergey Glazunov <serg.glazunov@gmail.com>
13426
13427 Reviewed by James Robinson.
13428
13429 SVGCursorElement::removeClient() should verify that its argument is conn ected with
13430 the proper cursor element.
13431 https://bugs.webkit.org/show_bug.cgi?id=54979
13432
13433 Test: svg/css/multiple-cursors-crash.html
13434
13435 * svg/SVGCursorElement.cpp:
13436 (WebCore::SVGCursorElement::removeClient):
13437
13438 2011-02-23 Renata Hodovan <reni@webkit.org>
13439
13440 Reviewed by Darin Adler.
13441
13442 FEConvolveMatrixElement changes doesn't require relayout
13443 https://bugs.webkit.org/show_bug.cgi?id=55067
13444
13445 When the FEConvolveMatrixElement receives an update message but the
13446 given value remains the same we don't need to relayout the filter.
13447
13448 No new tests are needed because this modificiation is covered by the
13449 dynamic update tests of FEConvolveMatrix.
13450
13451 * platform/graphics/filters/FEConvolveMatrix.cpp:
13452 (WebCore::FEConvolveMatrix::setDivisor):
13453 (WebCore::FEConvolveMatrix::setBias):
13454 (WebCore::FEConvolveMatrix::setTargetOffset):
13455 (WebCore::FEConvolveMatrix::edgeMode):
13456 (WebCore::FEConvolveMatrix::setEdgeMode):
13457 (WebCore::FEConvolveMatrix::setPreserveAlpha):
13458 * platform/graphics/filters/FEConvolveMatrix.h:
13459 * svg/SVGFEConvolveMatrixElement.cpp:
13460 (WebCore::SVGFEConvolveMatrixElement::setFilterEffectAttribute):
13461 (WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged):
13462 * svg/SVGFEConvolveMatrixElement.h:
13463
13464 2011-02-23 Geoffrey Garen <ggaren@apple.com>
13465
13466 Reviewed by Darin Adler.
13467
13468 Rolled back in r79367 with SnowLeopard Release bot crash fixed.
13469 https://bugs.webkit.org/show_bug.cgi?id=54999
13470
13471 * ForwardingHeaders/wtf/DoublyLinkedList.h: Added.
13472
13473 2011-02-23 Dimitri Glazkov <dglazkov@chromium.org>
13474
13475 Reviewed by Darin Adler.
13476
13477 Add more thorough manual test coverage for media controls
13478 https://bugs.webkit.org/show_bug.cgi?id=55006
13479
13480 * manual-tests/media-controls.html: Added.
13481
13482 2011-02-23 Darin Adler <darin@apple.com>
13483
13484 Fix build.
13485
13486 * platform/text/TextCodecUTF16.cpp:
13487 (WebCore::TextCodecUTF16::decode): Removed stray unused local variable.
13488
13489 2011-02-23 Dimitri Glazkov <dglazkov@chromium.org>
13490
13491 Reviewed by Darin Adler.
13492
13493 Setting shadow host should also attach and set inDocument, just like
13494 appending/inserting a child.
13495 https://bugs.webkit.org/show_bug.cgi?id=55065
13496
13497 No new tests, because functionality is not yet used.
13498
13499 * dom/Element.cpp:
13500 (WebCore::Element::setShadowRoot): Add attaching and setting inDocument
13501 for the shadow DOM subtree, like the host.
13502
13503 2011-02-23 David Hyatt <hyatt@apple.com>
13504
13505 Reviewed by Darin Adler and Simon Fraser.
13506
13507 https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
13508
13509 - Add clientLogicalWidth and clientLogicalHeight that call the correct c lientWidth or clientHeight based off
13510 writing-mode.
13511 - Patch clientLogicalBottom to use clientLogicalHeight.
13512 - Convert containingBlockWidthForPositioned and containingBlockHeightFor Positioned to be logical and to make use of
13513 clientLogicalHeight/Width. Also make them able to handle perpendicular writing mode containining blocks.
13514 - Refine containingBlockLogicalHeightForPositioned to match containingBl ockLogicalWidthForPositioned more closely.
13515
13516 * rendering/RenderBox.cpp:
13517 (WebCore::RenderBox::computeReplacedLogicalWidthUsing):
13518 (WebCore::RenderBox::computeReplacedLogicalHeightUsing):
13519 (WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
13520 (WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
13521 (WebCore::RenderBox::computePositionedLogicalWidth):
13522 (WebCore::RenderBox::computePositionedLogicalHeight):
13523 (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
13524 (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
13525 * rendering/RenderBox.h:
13526 (WebCore::RenderBox::clientLogicalWidth):
13527 (WebCore::RenderBox::clientLogicalHeight):
13528 (WebCore::RenderBox::clientLogicalBottom):
13529
13530 2011-02-23 Darin Adler <darin@apple.com>
13531
13532 Reviewed by Alexey Proskuryakov.
13533
13534 REGRESSION (new UTF-8 decoder): Reproducible crash on alltommac.se
13535 https://bugs.webkit.org/show_bug.cgi?id=54862
13536
13537 Correct handling of end of buffer partial sequence in UTF-8 and UTF-16 d ecoders when flushing with zero length
13538 https://bugs.webkit.org/show_bug.cgi?id=54444
13539
13540 No new tests at this time. I will add some tests later, but since multip le
13541 people are hitting this I wanted to get it in as quickly as possible.
13542
13543 * platform/text/TextCodecUTF16.cpp:
13544 (WebCore::TextCodecUTF16::decode): Tweaked coding style quite a bit.
13545 Removed special case for zero length now that main code handles it
13546 correctly. Used words instead of abbreviations for local variable names.
13547 Added error handling for a trailing byte.
13548
13549 * platform/text/TextCodecUTF8.cpp:
13550 (WebCore::TextCodecUTF8::consumePartialSequenceByte): Added. Helper func tion
13551 to make the handleError and handlePartialSequence functions clearer.
13552 (WebCore::TextCodecUTF8::handleError): Added. Helper function to make th e
13553 handlePartialSequence clearer.
13554 (WebCore::TextCodecUTF8::handlePartialSequence): Added. Factored out cod e for
13555 the partial sequence case. Making this a separate function probably help s make
13556 the fast case a little faster. This new version handles more cases corre ctly,
13557 which is what fixes the crashes we were seeing. In particular, it no lon ger
13558 assumes that the partial sequence is truly partial, because there are ca ses
13559 where we end up handling complete sequences here, such as when a complet e
13560 sequence is inside a malformed partial sequence.
13561 (WebCore::TextCodecUTF8::decode): Removed partial sequence code and made this
13562 call handlePartialSequence instead. Could be streamlined if we double ch ecked
13563 that passing a reference to "destination" and "source" doesn't harm code
13564 generation too much, so perhaps someone can do that research on a few co mpilers
13565 later and clean this up. Removed special case for zero length now that t he
13566 main code handles that correctly.
13567
13568 * platform/text/TextCodecUTF8.h: Added declarations for new functions.
13569 Made partial sequence buffer large enough to hold a whole sequence so we can
13570 use it to complete and decode a sequence in place.
13571
13572 2011-02-23 Abhishek Arya <inferno@chromium.org>
13573
13574 Reviewed by Dave Hyatt.
13575
13576 Make clear float lineboxes resilient against overflows.
13577 https://bugs.webkit.org/show_bug.cgi?id=54995
13578
13579 We try to dirty everthing in block range if we have a negative
13580 logical bottom, or if our logical bottom is less than our logical
13581 top, or if our logical top is equal to INT_MAX. Plus, we also dirty
13582 a linebox if its block logical height is less than zero.
13583 Tests: fast/overflow/overflow-height-float-not-removed-crash2.html
13584 fast/overflow/overflow-height-float-not-removed-crash3.html
13585
13586 * rendering/RenderBlock.cpp:
13587 (WebCore::RenderBlock::removeFloatingObject):
13588 (WebCore::RenderBlock::markLinesDirtyInBlockRange):
13589 * rendering/RootInlineBox.cpp:
13590 (WebCore::RootInlineBox::alignBoxesInBlockDirection): remove the hack
13591 added in r69735. we don't need this anymore since we are making the
13592 underlying float dirty logic resilient.
13593
13594 2011-02-22 Kenneth Russell <kbr@google.com>
13595
13596 Reviewed by Darin Fisher.
13597
13598 Per-page minimum DOMTimer interval broken for repeating timers
13599 https://bugs.webkit.org/show_bug.cgi?id=55014
13600
13601 When the minimum timer interval is adjusted, if the timer is
13602 repeating, cause its repeat interval to be set to its original
13603 timeout clamped to the new minimum interval.
13604
13605 Tests: fast/dom/timer-increase-min-interval-repeating.html
13606 fast/dom/timer-increase-then-decrease-min-interval-repeating.html
13607
13608 * page/DOMTimer.cpp:
13609 (WebCore::DOMTimer::adjustMinimumTimerInterval):
13610
13611 2011-02-23 Dan Bernstein <mitz@apple.com>
13612
13613 Reviewed by Maciej Stachowiak.
13614
13615 Fix two issues seen in WebKit2 views on Mac:
13616 - <rdar://problem/8867831> WebKit2: Insertion points in form fields no l onger blink
13617 - <rdar://problem/8950362> REGRESSION (WebKit2): Cannot deselect text
13618
13619 * page/EventHandler.cpp:
13620 (WebCore::EventHandler::EventHandler): Initialize m_activationEventNumbe r
13621 to -1. Since WebKit2 doesn�t support non-activating clicks yet (<http:// webkit.org/b/55053>
13622 <rdar://problem/9042197>) and doesn�t send event numbers, all events wer e considered to be
13623 window-activating events. This in turn prevented them from clearing the selection and resuming
13624 caret blinking on mouse up.
13625
13626 2011-02-23 Jacob Dinu <dinu.jacob@nokia.com>
13627
13628 Reviewed by Pavel Feldman.
13629
13630 Web Inspector: Linking error for some InspectorController symbols
13631 https://bugs.webkit.org/show_bug.cgi?id=54953
13632
13633 Moved out hideHighlight definition from under JAVASCRIPT_DEBUGGER flag
13634
13635 * inspector/InspectorController.cpp:
13636 (WebCore::InspectorController::hideHighlight):
13637 (WebCore::InspectorController::resume):
13638
13639 2011-02-23 Hans Wennborg <hans@chromium.org>
13640
13641 IndexedDB: Move some SQL code into IDBBackingStore
13642 https://bugs.webkit.org/show_bug.cgi?id=54889
13643
13644 The idea is to gather all the SQL logic into IDBBackingStore.
13645
13646 No new functionality, so no new tests.
13647
13648 * storage/IDBBackingStore.cpp:
13649 (WebCore::IDBBackingStore::IDBBackingStore):
13650 (WebCore::runCommands):
13651 (WebCore::createTables):
13652 (WebCore::createMetaDataTable):
13653 (WebCore::getDatabaseSchemaVersion):
13654 (WebCore::migrateDatabase):
13655 (WebCore::IDBBackingStore::open):
13656 (WebCore::IDBBackingStore::extractIDBDatabaseMetaData):
13657 (WebCore::IDBBackingStore::setIDBDatabaseMetaData):
13658 (WebCore::IDBBackingStore::getObjectStores):
13659 (WebCore::IDBBackingStore::createObjectStore):
13660 (WebCore::doDelete):
13661 (WebCore::IDBBackingStore::deleteObjectStore):
13662 (WebCore::whereSyntaxForKey):
13663 (WebCore::bindKeyToQuery):
13664 (WebCore::IDBBackingStore::getObjectStoreRecord):
13665 (WebCore::bindKeyToQueryWithNulls):
13666 (WebCore::IDBBackingStore::putObjectStoreRecord):
13667 (WebCore::IDBBackingStore::deleteIndexDataForRecord):
13668 (WebCore::IDBBackingStore::putIndexDataForRecord):
13669 (WebCore::IDBBackingStore::createIndex):
13670 (WebCore::IDBBackingStore::deleteIndex):
13671 (WebCore::IDBBackingStore::clearObjectStore):
13672 * storage/IDBBackingStore.h:
13673 * storage/IDBDatabaseBackendImpl.cpp:
13674 (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
13675 (WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
13676 (WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal):
13677 (WebCore::IDBDatabaseBackendImpl::setVersionInternal):
13678 (WebCore::IDBDatabaseBackendImpl::loadObjectStores):
13679 * storage/IDBFactoryBackendImpl.cpp:
13680 (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl):
13681 (WebCore::IDBFactoryBackendImpl::addIDBBackingStore):
13682 (WebCore::IDBFactoryBackendImpl::removeIDBBackingStore):
13683 (WebCore::IDBFactoryBackendImpl::open):
13684 * storage/IDBFactoryBackendImpl.h:
13685 * storage/IDBObjectStoreBackendImpl.cpp:
13686 (WebCore::IDBObjectStoreBackendImpl::getInternal):
13687 (WebCore::IDBObjectStoreBackendImpl::putInternal):
13688 (WebCore::IDBObjectStoreBackendImpl::clearInternal):
13689 (WebCore::populateIndex):
13690 (WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
13691 (WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
13692
13693 2011-02-23 Siddharth Mathur <siddharth.mathur@nokia.com>
13694
13695 Reviewed by Laszlo Gombos.
13696
13697 [Qt] Fix the Symbian build after r79334
13698 https://bugs.webkit.org/show_bug.cgi?id=55044
13699
13700 No new tests as there is no new functionality.
13701
13702 * WebCore.pri: Reorder symbian blocks to make sure that
13703 system-sqlite is set before it is tested.
13704
13705 Copy the rules from JavaScriptCore.pri for defineTest().
13706
13707 2011-02-23 Patrick Gansterer <paroga@webkit.org>
13708
13709 Reviewed by Alexey Proskuryakov.
13710
13711 Use AtomicString::fromUTF8 instead of String::fromUTF8 for AtomicStrings
13712 https://bugs.webkit.org/show_bug.cgi?id=54992
13713
13714 * websockets/WebSocketHandshake.cpp:
13715 (WebCore::WebSocketHandshake::readHTTPHeaders):
13716
13717 2011-02-23 Patrick Gansterer <paroga@webkit.org>
13718
13719 Reviewed by Andreas Kling.
13720
13721 [CMake] Move platform dependent files out of main CMakeLists.txt
13722 https://bugs.webkit.org/show_bug.cgi?id=53891
13723
13724 Apple Windows port does not use the image decoders,
13725 so move them into the platform specific CMake files.
13726
13727 * CMakeLists.txt:
13728 * CMakeListsEfl.txt:
13729 * CMakeListsWinCE.txt:
13730
13731 2011-02-21 Stephen White <senorblanco@chromium.org>
13732
13733 Reviewed by Kenneth Russell.
13734
13735 Jittering when animating a rotated image
13736 https://bugs.webkit.org/show_bug.cgi?id=50775
13737
13738 Since Skia does not seem to suffer from pixel cracks when scaling to
13739 non-integral sizes the way CG does, no-op roundToDevicePixels on the
13740 Skia implementation.
13741
13742 * platform/graphics/skia/GraphicsContextSkia.cpp:
13743 (WebCore::GraphicsContext::roundToDevicePixels):
13744
13745 2011-02-23 Patrick Gansterer <paroga@webkit.org>
13746
13747 Reviewed by Andreas Kling.
13748
13749 [WINCE] Get rid of TemporaryLinkStubs.cpp
13750 https://bugs.webkit.org/show_bug.cgi?id=54825
13751
13752 * CMakeListsWinCE.txt:
13753 * platform/network/win/CookieStorageWin.cpp: Copied from platform/wince/ TemporaryLinkStubs.cpp.
13754 * platform/wince/TemporaryLinkStubs.cpp: Removed.
13755
13756 2011-02-23 Patrick Gansterer <paroga@webkit.org>
13757
13758 Reviewed by Darin Adler.
13759
13760 Rename PLATFORM(CF) to USE(CF)
13761 https://bugs.webkit.org/show_bug.cgi?id=53540
13762
13763 * WebCore.gyp/WebCore.gyp:
13764 * editing/SmartReplace.cpp:
13765 * editing/SmartReplaceICU.cpp:
13766 * loader/MainResourceLoader.cpp:
13767 (WebCore::MainResourceLoader::didReceiveResponse):
13768 (WebCore::MainResourceLoader::didReceiveData):
13769 (WebCore::MainResourceLoader::didFinishLoading):
13770 (WebCore::MainResourceLoader::didFail):
13771 * loader/archive/ArchiveFactory.cpp:
13772 (WebCore::archiveMIMETypes):
13773 * platform/FileSystem.h:
13774 * platform/KURL.h:
13775 * platform/KURLGoogle.cpp:
13776 * platform/RunLoopTimer.h:
13777 * platform/SharedBuffer.cpp:
13778 * platform/SharedBuffer.h:
13779 * platform/UUID.cpp:
13780 (WebCore::createCanonicalUUIDString):
13781 * platform/network/ResourceHandle.h:
13782 * platform/network/ResourceRequestBase.h:
13783 * platform/network/curl/ResourceHandleCurl.cpp:
13784 * platform/network/curl/ResourceHandleManager.cpp:
13785 (WebCore::certificatePath):
13786 * platform/text/cf/StringCF.cpp:
13787 * platform/text/cf/StringImplCF.cpp:
13788 * platform/win/BString.cpp:
13789 * platform/win/BString.h:
13790 * platform/win/ClipboardUtilitiesWin.cpp:
13791 (WebCore::getWebLocData):
13792 (WebCore::getURL):
13793 (WebCore::getClipboardData):
13794 * platform/win/ClipboardWin.cpp:
13795 (WebCore::writeFileToDataObject):
13796 * platform/win/SearchPopupMenuWin.cpp:
13797 (WebCore::SearchPopupMenuWin::enabled):
13798 (WebCore::SearchPopupMenuWin::saveRecentSearches):
13799 (WebCore::SearchPopupMenuWin::loadRecentSearches):
13800
13801 2011-02-23 Benjamin Kalman <kalman@chromium.org>
13802
13803 Reviewed by Ojan Vafai.
13804
13805 Moving or selecting backwards by words jumps to start of contenteditable region if contenteditable=false span is encountered
13806 https://bugs.webkit.org/show_bug.cgi?id=51001
13807
13808 Test: editing/selection/extend-backward-by-word-over-non-editable.html
13809
13810 Revert some previous changes (the TextIteratorEndsAtEditingBoundary text iteration behaviour) which caused this
13811 bug in the first place, and fix SimplifiedBackwardsTextIterator's iterat ion range check as an alternative fix.
13812
13813 The original bug was that double-clicking on an inline editable span at the start of a paragraph would clear the
13814 selection (webkit.org/b/36360). This was caused by upstream/downstream VisbiblePosition complications. To fix,
13815 refuse to iterate beyond the start node (rather than refusing to iterate across editable boundaries, which
13816 causes this bug).
13817
13818 To see why this is correct, and to make it clearer that is indeed what i s happening, the text iterator code has
13819 been slightly restructured to express the invariant that the iterator wi ll never advance past the start node.
13820
13821 * editing/TextIterator.cpp:
13822 (WebCore::TextIterator::TextIterator): Remove references to TextIteratio nEndsAtEditing boundary.
13823 (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterat or): Remove m_pastStartNode as the
13824 mechanism for iteration range checking, and use a flag m_havePassedStart Node instead.
13825 (WebCore::SimplifiedBackwardsTextIterator::advance): Clean up, use advan ceRespectingRange and
13826 m_havePassedStartNode for iteration range checking rather than m_pastSta rtNode.
13827 (WebCore::SimplifiedBackwardsTextIterator::advanceRespectingRange): The new way of modifying m_node
13828 which updates m_havePassedStartNode and refuses to continue when it beco mes true.
13829 * editing/TextIterator.h: Remove TextIteratorEndsAtEditingBoundary, upda te for new/removed prototypes and
13830 member variables.
13831 * editing/visible_units.cpp:
13832 (WebCore::previousBoundary): Remove references to TextIteratorEndsAtEdit ingBoundary.
13833
13834 2011-02-23 Fumitoshi Ukai <ukai@chromium.org>
13835
13836 Reviewed by Adam Barth.
13837
13838 WebSocket uses insecure random numbers
13839 https://bugs.webkit.org/show_bug.cgi?id=54714
13840
13841 * websockets/WebSocketHandshake.cpp:
13842 (WebCore::randomNumberLessThan):
13843 (WebCore::generateSecWebSocketKey):
13844 (WebCore::generateKey3):
13845
13846 2011-02-21 Hans Wennborg <hans@chromium.org>
13847
13848 Reviewed by Jeremy Orlow.
13849
13850 IndexedDB: Rename IDBSQLiteDatabase to IDBBackingStore
13851 https://bugs.webkit.org/show_bug.cgi?id=54864
13852
13853 No new functionality, so no new tests.
13854
13855 * GNUmakefile.am:
13856 * WebCore.gypi:
13857 * storage/IDBBackingStore.cpp:
13858 (WebCore::IDBBackingStore::IDBBackingStore):
13859 (WebCore::IDBBackingStore::~IDBBackingStore):
13860 * storage/IDBBackingStore.h:
13861 (WebCore::IDBBackingStore::create):
13862 (WebCore::IDBBackingStore::db):
13863 * storage/IDBCursorBackendImpl.cpp:
13864 (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
13865 (WebCore::IDBCursorBackendImpl::currentRowExists):
13866 (WebCore::IDBCursorBackendImpl::database):
13867 * storage/IDBCursorBackendImpl.h:
13868 (WebCore::IDBCursorBackendImpl::create):
13869 * storage/IDBDatabaseBackendImpl.cpp:
13870 (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
13871 (WebCore::IDBDatabaseBackendImpl::sqliteDatabase):
13872 (WebCore::IDBDatabaseBackendImpl::createObjectStore):
13873 (WebCore::IDBDatabaseBackendImpl::setVersionInternal):
13874 (WebCore::IDBDatabaseBackendImpl::loadObjectStores):
13875 * storage/IDBDatabaseBackendImpl.h:
13876 (WebCore::IDBDatabaseBackendImpl::create):
13877 * storage/IDBFactoryBackendImpl.cpp:
13878 (WebCore::IDBFactoryBackendImpl::removeIDBBackingStore):
13879 (WebCore::openSQLiteDatabase):
13880 (WebCore::IDBFactoryBackendImpl::open):
13881 * storage/IDBFactoryBackendImpl.h:
13882 * storage/IDBIndexBackendImpl.cpp:
13883 (WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
13884 (WebCore::IDBIndexBackendImpl::openCursorInternal):
13885 (WebCore::IDBIndexBackendImpl::sqliteDatabase):
13886 * storage/IDBIndexBackendImpl.h:
13887 (WebCore::IDBIndexBackendImpl::create):
13888 * storage/IDBObjectStoreBackendImpl.cpp:
13889 (WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
13890 (WebCore::IDBObjectStoreBackendImpl::createIndex):
13891 (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
13892 (WebCore::IDBObjectStoreBackendImpl::loadIndexes):
13893 (WebCore::IDBObjectStoreBackendImpl::sqliteDatabase):
13894 * storage/IDBObjectStoreBackendImpl.h:
13895 (WebCore::IDBObjectStoreBackendImpl::create):
13896
13897 2011-02-23 Dominic Mazzoni <dmazzoni@google.com>
13898
13899 Reviewed by Kenneth Russell.
13900
13901 Add a hit test handler for canvas elements that handles clicks on the ca nvas but ignores children.
13902 https://bugs.webkit.org/show_bug.cgi?id=54697
13903
13904 New test to prevent this from regressing in the future: canvas/canvas-mo use-events.html
13905
13906 * rendering/RenderHTMLCanvas.cpp:
13907 (WebCore::RenderHTMLCanvas::nodeAtPoint):
13908
13909 2011-02-23 Patrick Gansterer <paroga@webkit.org>
13910
13911 Reviewed by Darin Adler.
13912
13913 Remove obsolete focusRingColor functions
13914 https://bugs.webkit.org/show_bug.cgi?id=54824
13915
13916 * CMakeListsWinCE.txt:
13917 * platform/graphics/haiku/ColorHaiku.cpp:
13918 * platform/graphics/wince/ColorWinCE.cpp: Removed.
13919
13920 2011-02-22 Jia Pu <jpu@apple.com>
13921
13922 Reviewed by Dan Bernstein.
13923
13924 On Mac OS X, English contractions are marked misspelled with certain use r preference setting.
13925 https://bugs.webkit.org/show_bug.cgi?id=54975
13926
13927 manual test: manual-tests/autocorrection/spellcheck-on-contraction-when- autocorrection-is-off.html
13928
13929 Without this patch, we check for contraction only when autocorrection or other type of auto-
13930 substituation is on. And we failed to check for contraction if only spel lchecking is turned on.
13931 This patch implements the desired behavior, checking for contraction whe n either correction/substitution,
13932 or spellchecking, is on.
13933
13934 * editing/Editor.cpp:
13935 (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
13936 * manual-tests/autocorrection/spellcheck-on-contraction-when-autocorrect ion-is-off.html: Added.
13937
13938 2011-02-22 Charlie Reis <creis@chromium.org>
13939
13940 Reviewed by Darin Fisher.
13941
13942 Remove DatabasePolicy from FrameLoaderTypes
13943 https://bugs.webkit.org/show_bug.cgi?id=54968
13944
13945 The DatabasePolicy enum is no longer needed now that we avoid stopping
13946 loaders on same-document navigations.
13947
13948 Existing test: storage/hash-change-with-xhr.html
13949
13950 * WebCore.exp.in:
13951 * loader/DocumentLoader.cpp:
13952 * loader/DocumentLoader.h:
13953 * loader/FrameLoader.cpp:
13954 * loader/FrameLoader.h:
13955 * loader/FrameLoaderTypes.h:
13956 * workers/WorkerThread.cpp:
13957
13958 2011-02-22 Alexis Menard <alexis.menard@openbossa.org>
13959
13960 Reviewed by Andreas Kling.
13961
13962 [Qt] QWebView ignores a palette set with QWebView::setPalette()
13963 https://bugs.webkit.org/show_bug.cgi?id=31742
13964
13965 Use custom QWebView palette if the view provides one.
13966 Modified version of a patch made by Fabrizio Machado.
13967
13968 * platform/qt/RenderThemeQt.cpp:
13969 (WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor):
13970 (WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor):
13971 (WebCore::RenderThemeQt::platformActiveSelectionForegroundColor):
13972 (WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor):
13973 (WebCore::RenderThemeQt::platformFocusRingColor):
13974
13975 2011-02-22 Brian Salomon <bsalomon@google.com>
13976
13977 Reviewed by Kenneth Russell.
13978
13979 Don't disable accelerated canvas when using the skia gpu backend.
13980
13981 No new tests are required.
13982
13983 * html/canvas/CanvasRenderingContext2D.cpp:
13984 (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
13985
13986 2011-02-22 Luiz Agostini <luiz.agostini@openbossa.org>
13987
13988 Reviewed by Kenneth Rohde Christiansen.
13989
13990 [Qt] <select>s on http://www.ryanair.com render wrong
13991 https://bugs.webkit.org/show_bug.cgi?id=29647
13992
13993 Reducing padding in <select> elements to improve its rendering and intro ducing a
13994 rendering adjustment specific to QMacStyle.
13995
13996 * platform/qt/RenderThemeQt.cpp:
13997 (WebCore::RenderThemeQt::setPopupPadding):
13998 (WebCore::RenderThemeQt::paintMenuList):
13999
14000 2011-02-22 Andreas Kling <kling@webkit.org>
14001
14002 Reviewed by Dan Bernstein.
14003
14004 FontCache: Make cTargetInactiveFontData an int instead of float.
14005 https://bugs.webkit.org/show_bug.cgi?id=54963
14006
14007 * platform/graphics/FontCache.cpp:
14008
14009 2011-02-22 Ryosuke Niwa <rniwa@webkit.org>
14010
14011 Reviewed by Darin Adler.
14012
14013 Make Editor::selectionComputedStyle return EditingStyle
14014 https://bugs.webkit.org/show_bug.cgi?id=54933
14015
14016 Renamed selectionComputedStyle to selectionStartStyle and changed the re turn type to EditingStyle.
14017 It also no longer takes a boolean shouldUseFixedFontDefaultSize.
14018
14019 Also added EditingStyle::mergeTypingStyle which replaced old editingStyl eIncludingTypingStyle. This function
14020 doesn't extract inheritable properties prior to merge because this turne d out be a bug, which was revealed
14021 by an existing layout test only after the code was shared with selection StartStyle.
14022
14023 No tests are added since this is a refactoring.
14024
14025 * editing/CompositeEditCommand.cpp:
14026 (WebCore::CompositeEditCommand::moveParagraphs): Calls EditingStyle::cre ate and EditingStyle::mergeTypingStyle.
14027 (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
14028 * editing/EditingStyle.cpp: Removed editingStyleIncludingTypingStyle.
14029 (WebCore::EditingStyle::mergeTypingStyle): Added.
14030 * editing/EditingStyle.h:
14031 (WebCore::EditingStyle::shouldUseFixedDefaultFontSize): Added.
14032 * editing/Editor.cpp:
14033 (WebCore::Editor::selectionStartHasStyle): Calls selectionStartStyle.
14034 (WebCore::Editor::selectionHasStyle): Ditto.
14035 (WebCore::Editor::selectionStartCSSPropertyValue): Ditto.
14036 (WebCore::Editor::selectionStartStyle): Renamed from selectionComputedSt yle; returns EditingStyle.
14037 * editing/Editor.h:
14038 * editing/EditorCommand.cpp:
14039 (WebCore::executeToggleStyleInList): Calls selectionStartStyle.
14040 * editing/InsertLineBreakCommand.cpp:
14041 * editing/InsertParagraphSeparatorCommand.cpp:
14042 (WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion ): Calls EditingStyle::create and
14043 EditingStyle::mergeTypingStyle.
14044 * editing/ReplaceSelectionCommand.cpp:
14045 (WebCore::ReplaceSelectionCommand::doApply): Ditto.
14046
14047 2011-02-22 Robert Hogan <robert@webkit.org>
14048
14049 Reviewed by Andreas Kling.
14050
14051 [Qt] painting of windowed plugins faulty on certain scroll events
14052
14053 https://bugs.webkit.org/show_bug.cgi?id=52735
14054
14055 Invalidate the pluginview's relative rect rather then the frameRect(). T his is because QWebFrame::renderRelativeCoords()
14056 imitates ScrollView and adds the scroll offset back on to the rect we da mage here (making the co-ordinates absolute
14057 to the frame again) before passing it to FrameView.
14058
14059 * plugins/qt/PluginViewQt.cpp:
14060 (WebCore::PluginView::updatePluginWidget):
14061
14062 2011-02-22 Philippe Normand <pnormand@igalia.com>
14063
14064 Reviewed by Martin Robinson.
14065
14066 Minimal build broken
14067 https://bugs.webkit.org/show_bug.cgi?id=54743
14068
14069 Moved the code of setInspectorExtensionAPI and
14070 dispatchMessageFromFrontend out of #if
14071 ENABLE(JAVASCRIPT_DEBUGGER) to fix link error of the minimal build.
14072
14073 * inspector/InspectorController.cpp:
14074 (WebCore::InspectorController::setInspectorExtensionAPI):
14075 (WebCore::InspectorController::dispatchMessageFromFrontend):
14076
14077 2011-02-22 Sheriff Bot <webkit.review.bot@gmail.com>
14078
14079 Unreviewed, rolling out r79367.
14080 http://trac.webkit.org/changeset/79367
14081 https://bugs.webkit.org/show_bug.cgi?id=55012
14082
14083 all layout tests are crashing on Snow Leopard (Requested by
14084 rniwa on #webkit).
14085
14086 * ForwardingHeaders/wtf/DoublyLinkedList.h: Removed.
14087
14088 2011-02-22 Ryosuke Niwa <rniwa@webkit.org>
14089
14090 Reviewed by Darin Adler.
14091
14092 Deploy EditingStyle in removeInlineStyleFromElement and removeCSSStyle
14093 https://bugs.webkit.org/show_bug.cgi?id=54944
14094
14095 Deployed EditingStyle in removeInlineStyleFromElement and removeCSSStyle .
14096
14097 Also extracted EditingStyle::conflictsWithInlineStyleOfElement from Appl yStyleCommand::removeCSSStyle,
14098 which returns true iff the specified element has inline style that confl icts or matches the editing style.
14099 It also appends conflicting property IDs to the vector of property IDs i f one is specified.
14100
14101 * editing/ApplyStyleCommand.cpp:
14102 (WebCore::ApplyStyleCommand::applyBlockStyle): Calls removeCSSStyle.
14103 (WebCore::ApplyStyleCommand::applyInlineStyle): Calls shouldSplitTextEle ment.
14104 (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Cal ls removeInlineStyleFromElement.
14105 (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Takes Editin gStyle* instead of CSSMutableStyleDeclaration*.
14106 (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto; extracted the logic to decide properties to remove as
14107 conflictsWithInlineStyleOfElement.
14108 (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Calls shouldRemoveInlineStyleFromElement.
14109 (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls remov eInlineStyleFromElement.
14110 (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto.
14111 (WebCore::ApplyStyleCommand::shouldSplitTextElement): Takes EditingStyle * instead of CSSMutableStyleDeclaration*.
14112 * editing/ApplyStyleCommand.h:
14113 (WebCore::ApplyStyleCommand::shouldRemoveInlineStyleFromElement): Ditto.
14114 * editing/EditingStyle.cpp:
14115 (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Extracted fr om ApplyStyleCommand::removeCSSStyle.
14116 * editing/EditingStyle.h:
14117 (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Added.
14118
14119 2011-02-22 Chang Shu <cshu@webkit.org>
14120
14121 Reviewed by Csaba Osztrogonác.
14122
14123 [Qt] editing/deleting/5408255.html fails
14124 https://bugs.webkit.org/show_bug.cgi?id=54964
14125
14126 Move WebCore resource file to QtWebKit since they are referred in WebKit .
14127
14128 * WebCore.pro:
14129
14130 2011-02-22 Brady Eidson <beidson@apple.com>
14131
14132 Reviewed by Anders Carlsson.
14133
14134 <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=545 14
14135 API to view and delete Application Cache data by origin.
14136
14137 Implement these to be used by WK2 API:
14138 * loader/appcache/ApplicationCacheStorage.cpp:
14139 (WebCore::ApplicationCacheStorage::getOriginsWithCache):
14140 (WebCore::ApplicationCacheStorage::deleteEntriesForOrigin):
14141
14142 2011-02-22 Geoffrey Garen <ggaren@apple.com>
14143
14144 Reviewed by Oliver Hunt.
14145
14146 Manage MarkedBlocks in a linked list instead of a vector, so arbitrary r emoval is O(1)
14147 https://bugs.webkit.org/show_bug.cgi?id=54999
14148
14149 New WTF header.
14150
14151 * ForwardingHeaders/wtf/DoublyLinkedList.h: Copied from ForwardingHeader s/wtf/FixedArray.h.
14152
14153 2011-02-22 Beth Dakin <bdakin@apple.com>
14154
14155 Reviewed by Sam Weinig.
14156
14157 Fix for https://bugs.webkit.org/show_bug.cgi?id=54991
14158 Scrollbar::nativeTheme()->usesOverlayScrollbars() should not be consulte d for CSS
14159 Scrollbars
14160 -and corresponding-
14161 <rdar://problem/9034318>
14162
14163 Instead of consulting the theme directly, callers should ask the Scrollb ar or
14164 ScrollableArea if the scrollbars are overlay or not.
14165
14166 * platform/ScrollView.cpp:
14167 (WebCore::ScrollView::visibleContentRect):
14168 (WebCore::ScrollView::scrollContents):
14169 (WebCore::ScrollView::wheelEvent):
14170 * platform/ScrollableArea.cpp:
14171 (WebCore::ScrollableArea::setScrollOffsetFromAnimation):
14172 (WebCore::ScrollableArea::hasOverlayScrollbars):
14173 * platform/ScrollableArea.h:
14174 * platform/Scrollbar.cpp:
14175 (WebCore::Scrollbar::isOverlayScrollbar):
14176 * platform/Scrollbar.h:
14177 * rendering/RenderBox.cpp:
14178 (WebCore::RenderBox::includeVerticalScrollbarSize):
14179 (WebCore::RenderBox::includeHorizontalScrollbarSize):
14180 * rendering/RenderLayer.cpp:
14181 (WebCore::RenderLayer::verticalScrollbarWidth):
14182 (WebCore::RenderLayer::horizontalScrollbarHeight):
14183 * rendering/RenderListBox.cpp:
14184 (WebCore::RenderListBox::verticalScrollbarWidth):
14185 * rendering/RenderScrollbar.h:
14186 (WebCore::RenderScrollbar::isOverlayScrollbar):
14187
14188 2011-02-22 Andras Becsi <abecsi@webkit.org>
14189
14190 Reviewed by Csaba Osztrogonác.
14191
14192 [Qt] Redesign the build system
14193 https://bugs.webkit.org/show_bug.cgi?id=51339
14194
14195 Move inspector's resource files into the final build step to fix the lay out test regression.
14196
14197 No new tests needed.
14198
14199 * WebCore.pro: Move inspector's resource files into QtWebKit.pro.
14200
14201 2011-02-22 Martin Robinson <mrobinson@igalia.com>
14202
14203 Reviewed by Xan Lopez.
14204
14205 [GTK] fast/frames/iframe-scale-applied-twice.html fails after r79167
14206 https://bugs.webkit.org/show_bug.cgi?id=54990
14207
14208 No new tests. This will cause fast/events/scroll-after-click-on-tab-inde x.html
14209 to start passing again.
14210
14211 * platform/gtk/ScrollViewGtk.cpp:
14212 (WebCore::ScrollView::visibleContentRect): Update this method to match t he original
14213 in the parent class.
14214
14215 2011-01-17 Martin Robinson <mrobinson@igalia.com>
14216
14217 Reviewed by Xan Lopez.
14218
14219 [GTK] fast/events/scroll-after-click-on-tab-index has been failing on th e bots
14220 https://bugs.webkit.org/show_bug.cgi?id=49177
14221
14222 * platform/ScrollView.cpp: Remove the GTK+ guards around the implementat ion
14223 of platformAddChild and platformRemoveChild. This code can be shared.
14224 * platform/gtk/MainFrameScrollbarGtk.cpp:
14225 (MainFrameScrollbarGtk::attachAdjustment): Prevent re-attaching an alrea dy attached
14226 adjustment. Connect the adjustment value-changed signal handler after re setting the
14227 adjustment. This prevents the rest from stomping on pre-existing WebCore values.
14228 (MainFrameScrollbarGtk::gtkValueChanged): If the scrollbar is no longer attached to
14229 a scrollview do not listing for value changes. These scrollbars are defu nct.
14230 * platform/gtk/ScrollViewGtk.cpp: Remove duplicated empty methods.
14231
14232 2011-02-22 Pavel Feldman <pfeldman@chromium.org>
14233
14234 Reviewed by Yury Semikhatsky.
14235
14236 Web Inspector: refactor InjectedScript : InspectorDOMAgent interaction.
14237 https://bugs.webkit.org/show_bug.cgi?id=54954
14238
14239 * bindings/js/JSInjectedScriptHostCustom.cpp:
14240 (WebCore::InjectedScriptHost::toNode):
14241 (WebCore::JSInjectedScriptHost::inspect):
14242 * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
14243 (WebCore::InjectedScriptHost::toNode):
14244 (WebCore::V8InjectedScriptHost::inspectCallback):
14245 * inspector/CodeGeneratorInspector.pm:
14246 * inspector/InjectedScript.cpp:
14247 (WebCore::InjectedScript::nodeForObjectId):
14248 * inspector/InjectedScript.h:
14249 * inspector/InjectedScriptHost.cpp:
14250 (WebCore::InjectedScriptHost::inspect):
14251 * inspector/InjectedScriptHost.h:
14252 * inspector/InjectedScriptHost.idl:
14253 * inspector/InjectedScriptSource.js:
14254 (.):
14255 * inspector/Inspector.idl:
14256 * inspector/InspectorAgent.cpp:
14257 (WebCore::InspectorAgent::focusNode):
14258 * inspector/InspectorAgent.h:
14259 * inspector/InspectorDOMAgent.cpp:
14260 (WebCore::InspectorDOMAgent::inspect):
14261 (WebCore::InspectorDOMAgent::pushNodeToFrontend):
14262 * inspector/InspectorDOMAgent.h:
14263 * inspector/front-end/AuditRules.js:
14264 (WebInspector.AuditRules.evaluateInTargetWindow):
14265 (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
14266 (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
14267 (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedIma ges):
14268 (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.pushImageNo des):
14269 * inspector/front-end/ConsoleView.js:
14270 (WebInspector.ConsoleView.prototype.completions):
14271 * inspector/front-end/DOMAgent.js:
14272 (WebInspector.DOMDispatcher.prototype.childNodeRemoved):
14273 (WebInspector.DOMDispatcher.prototype.inspectElementRequested):
14274 * inspector/front-end/RemoteObject.js:
14275 (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
14276
14277 2011-02-22 Brady Eidson <beidson@apple.com>
14278
14279 Reviewed by Anders Carlsson.
14280
14281 Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cg i?id=54514
14282 API to view and delete Application Cache data by origin.
14283
14284 Stub these out for now:
14285 * loader/appcache/ApplicationCacheStorage.cpp:
14286 (WebCore::ApplicationCacheStorage::getOriginsWithCache):
14287 (WebCore::ApplicationCacheStorage::deleteEntriesForOrigin):
14288 (WebCore::ApplicationCacheStorage::deleteAllEntries): Moved implementati on here from WebKit/Mac
14289 * loader/appcache/ApplicationCacheStorage.h:
14290
14291 Export the new symbols:
14292 * WebCore.exp.in:
14293
14294 2011-02-22 Anders Carlsson <andersca@apple.com>
14295
14296 Fix debug build.
14297
14298 * WebCore.exp.in:
14299
14300 2011-02-22 Balazs Kelemen <kbalazs@webkit.org>
14301
14302 Reviewed by Anders Carlsson.
14303
14304 notImplemented() should behave identical in WebCore and WebKit2
14305 https://bugs.webkit.org/show_bug.cgi?id=54449
14306
14307 No functional change so no new tests.
14308
14309 * WebCore.xcodeproj/project.pbxproj: Add NotImplemented.h as private hea der
14310 to be able to use it in WebKit2.
14311
14312 2011-02-22 Andras Becsi <abecsi@webkit.org>
14313
14314 Reviewed by Laszlo Gombos.
14315 Rubber-stamped by Csaba Osztrogonác.
14316
14317 [Qt] Redesign the build system
14318 https://bugs.webkit.org/show_bug.cgi?id=51339
14319
14320 The patch landed in r79320 didn't contain the cleanup
14321 which was already addressed in the last attachment.
14322
14323 No new tests needed.
14324
14325 * WebCore.pri: Add common LIB and CONFIG options.
14326 * WebCore.pro: Add accidentally moved sections.
14327
14328 2011-02-22 Philippe Normand <pnormand@igalia.com>
14329
14330 Unreviewed, rolling out r79321.
14331 http://trac.webkit.org/changeset/79321
14332 https://bugs.webkit.org/show_bug.cgi?id=53146
14333
14334 Regresses fast/forms/listbox-typeahead-cyrillic.html and fast
14335 /spatial-navigation/snav-single-select.html on GTK
14336
14337 * accessibility/gtk/AXObjectCacheAtk.cpp:
14338 (WebCore::notifyChildrenSelectionChange):
14339 (WebCore::AXObjectCache::postPlatformNotification):
14340
14341 2011-02-22 Ilya Tikhonovsky <loislo@chromium.org>
14342
14343 Reviewed by Yury Semikhatsky.
14344
14345 Web Inspector: Inspector.IDL change. rename attribute notify -> event.
14346 https://bugs.webkit.org/show_bug.cgi?id=54958
14347
14348 * inspector/CodeGeneratorInspector.pm:
14349 * inspector/Inspector.idl:
14350
14351 2011-02-22 Yury Semikhatsky <yurys@chromium.org>
14352
14353 Reviewed by Pavel Feldman.
14354
14355 Web Inspector: Timeline agent should have same lifetime as InspectorAgen t
14356 https://bugs.webkit.org/show_bug.cgi?id=54951
14357
14358 * inspector/CodeGeneratorInspector.pm:
14359 * inspector/Inspector.idl:
14360 * inspector/InspectorAgent.cpp:
14361 (WebCore::InspectorAgent::InspectorAgent):
14362 (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
14363 (WebCore::InspectorAgent::setFrontend):
14364 (WebCore::InspectorAgent::disconnectFrontend):
14365 (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
14366 (WebCore::InspectorAgent::didCommitLoad):
14367 (WebCore::InspectorAgent::domContentLoadedEventFired):
14368 (WebCore::InspectorAgent::loadEventFired):
14369 * inspector/InspectorAgent.h:
14370 * inspector/InspectorController.cpp:
14371 (WebCore::InspectorController::startTimelineProfiler):
14372 (WebCore::InspectorController::stopTimelineProfiler):
14373 (WebCore::InspectorController::timelineProfilerEnabled):
14374 * inspector/InspectorInstrumentation.cpp:
14375 (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
14376 * inspector/InspectorTimelineAgent.cpp:
14377 (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent):
14378 (WebCore::InspectorTimelineAgent::setFrontend):
14379 (WebCore::InspectorTimelineAgent::clearFrontend):
14380 (WebCore::InspectorTimelineAgent::restore):
14381 (WebCore::InspectorTimelineAgent::startTimelineProfiler):
14382 (WebCore::InspectorTimelineAgent::stopTimelineProfiler):
14383 (WebCore::InspectorTimelineAgent::timelineProfilerStarted):
14384 (WebCore::InspectorTimelineAgent::didCommitLoad):
14385 (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
14386 (WebCore::InspectorTimelineAgent::clearRecordStack):
14387 * inspector/InspectorTimelineAgent.h:
14388 (WebCore::InspectorTimelineAgent::create):
14389 * inspector/front-end/TimelinePanel.js:
14390 (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
14391
14392 2011-02-22 Ilya Tikhonovsky <loislo@chromium.org>
14393
14394 Reviewed by Pavel Feldman.
14395
14396 Web Inspector: flakyness of inspector tests.
14397 https://bugs.webkit.org/show_bug.cgi?id=54729
14398
14399 As far as we have the protocol with sequence numbers we can simplify tes t harness support
14400 and drop out chomium specific methods.
14401
14402 * inspector/CodeGeneratorInspector.pm:
14403 * inspector/front-end/TestController.js:
14404 (WebInspector.TestController):
14405 (WebInspector.TestController.prototype.notifyDone):
14406 (WebInspector.TestController.prototype.runAfterPendingDispatches):
14407 (WebInspector.TestController.prototype._evaluateForTestInFrontend):
14408 * inspector/front-end/inspector.js:
14409 (WebInspector.dispatch):
14410
14411 2011-02-22 Mario Sanchez Prada <msanchez@igalia.com>
14412
14413 Reviewed by Martin Robinson.
14414
14415 [GTK] Combo boxes should emit object:selection-changed even when collaps ed
14416 https://bugs.webkit.org/show_bug.cgi?id=53146
14417
14418 Emit the selection-changed signals when the menu list value has changed
14419
14420 Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.h tml
14421
14422 * accessibility/gtk/AXObjectCacheAtk.cpp:
14423 (WebCore::getListObject): New, return the right list object for
14424 menu lists and list boxes.
14425 (WebCore::notifyChildrenSelectionChange): Support menu lists.
14426 (WebCore::AXObjectCache::postPlatformNotification): Call function
14427 notifyChildrenSelectionChange for AXMenuListValueChanged.
14428
14429 2011-02-22 Andras Becsi <abecsi@webkit.org>
14430
14431 Reviewed by Laszlo Gombos.
14432
14433 [Qt] Redesign the build system
14434 https://bugs.webkit.org/show_bug.cgi?id=51339
14435
14436 Part 2.
14437
14438 Build WebCore as a static library, compile the WebKit API and WebKit2 AP I
14439 in a final step and link to WebKit2, WebCore and JSC libraries to fix
14440 linking issues resulting from stripped away symbols.
14441
14442 No new tests needed.
14443
14444 * WebCore.pri: Add needed rules for handling the static library.
14445 * WebCore.pro: Reorganize API and linker options to QtWebKit.pro.
14446
14447 2011-02-22 Pavel Podivilov <podivilov@chromium.org>
14448
14449 Reviewed by Pavel Feldman.
14450
14451 Web Inspector: [REGRESSION] navigation does not work when inspector is o pened.
14452 https://bugs.webkit.org/show_bug.cgi?id=54947
14453
14454 * inspector/InspectorAgent.cpp:
14455 (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
14456 * inspector/InspectorState.cpp:
14457 (WebCore::InspectorState::loadFromCookie):
14458 * inspector/InspectorState.h:
14459
14460 2011-02-15 Jer Noble <jer.noble@apple.com>
14461
14462 Reviewed by Darin Adler.
14463
14464 Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update playhea d location or time displays
14465 https://bugs.webkit.org/show_bug.cgi?id=46142
14466
14467 Push a LayoutStateMaintainer in RenderMedia::layout() before calling lay out() on the
14468 container elements. This is necessary because, during layout(), the chi ld renderers
14469 query the current LayoutState to determine where they will be repainting . If a new
14470 LayoutState is not pushed here, child renderers will attempt to repaint relative to
14471 their grandparent's origin instead of their parents', and repaint operat ions will fail.
14472
14473 * rendering/RenderMedia.cpp:
14474 (WebCore::RenderMedia::layout):
14475
14476 2011-02-22 Benjamin Poulain <benjamin.poulain@nokia.com>
14477
14478 Reviewed by Kenneth Rohde Christiansen.
14479
14480 Cleaning: remove a overzealous check for the pointer "files" from Chrome ::setToolTip()
14481 https://bugs.webkit.org/show_bug.cgi?id=54952
14482
14483 Remove the unnecessary condition from the if(), HTMLInputElement::files( ) always return
14484 a valid reference for the input type FileInputType.
14485
14486 * page/Chrome.cpp:
14487 (WebCore::Chrome::setToolTip):
14488
14489 2011-02-21 Pavel Podivilov <podivilov@chromium.org>
14490
14491 Reviewed by Pavel Feldman.
14492
14493 Web Inspector: extract source mapping from SourceFrame to DebuggerPresen tationModel.
14494 https://bugs.webkit.org/show_bug.cgi?id=54645
14495
14496 This is needed to map one script to several source files.
14497
14498 Test: inspector/debugger/source-frame.html
14499
14500 * WebCore.gypi:
14501 * WebCore.vcproj/WebCore.vcproj:
14502 * inspector/front-end/DebuggerPresentationModel.js: Added.
14503 (WebInspector.DebuggerPresentationModel):
14504 (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceNa me):
14505 (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
14506 (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
14507 (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
14508 (WebInspector.DebuggerPresentationModel.prototype._encodeSourceLocation) :
14509 (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourc eLocation):
14510 * inspector/front-end/ScriptsPanel.js:
14511 (WebInspector.ScriptsPanel):
14512 (WebInspector.ScriptsPanel.prototype._breakpointAdded):
14513 (WebInspector.ScriptsPanel.prototype._breakpointRemoved):
14514 (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
14515 (WebInspector.ScriptsPanel.prototype._sourceFrameForScript):
14516 (WebInspector.ScriptsPanel.prototype._addSourceFrame):
14517 (WebInspector.ScriptsPanel.prototype._removeSourceFrame):
14518 (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
14519 (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine):
14520 (WebInspector.ScriptsPanel.prototype._callFrameSelected):
14521 (WebInspector.SourceFrameContentProviderForScript.prototype._buildSource ):
14522 * inspector/front-end/SourceFrame.js:
14523 (WebInspector.SourceFrame.prototype.get loaded):
14524 (WebInspector.SourceFrame.prototype._createTextViewer):
14525 (WebInspector.SourceFrame.prototype._setTextViewerDecorations):
14526 (WebInspector.SourceFrame.prototype.setExecutionLine):
14527 (WebInspector.SourceFrame.prototype.clearExecutionLine):
14528 (WebInspector.SourceFrame.prototype.addBreakpoint):
14529 (WebInspector.SourceFrame.prototype.removeBreakpoint):
14530 (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoin t.didEditBreakpointCondition):
14531 (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoin t):
14532 (WebInspector.SourceFrame.prototype._findBreakpoint.filter):
14533 (WebInspector.SourceFrame.prototype._findBreakpoint):
14534 * inspector/front-end/WebKit.qrc:
14535 * inspector/front-end/inspector.html:
14536
14537 2011-02-22 Andrey Kosyakov <caseq@chromium.org>
14538
14539 Reviewed by Pavel Feldman.
14540
14541 Web Inspector: provide a button to expand inspector toolbar when not all panel buttons fit
14542 https://bugs.webkit.org/show_bug.cgi?id=54671
14543
14544 - factored toolbar handling out of inspector.js
14545 - added toolbar dropdown
14546
14547 * WebCore.gypi:
14548 * WebCore.vcproj/WebCore.vcproj:
14549 * inspector/front-end/ExtensionServer.js:
14550 (WebInspector.ExtensionServer.prototype._onCreatePanel):
14551 * inspector/front-end/Panel.js:
14552 (WebInspector.Panel.prototype.get toolbarItem):
14553 * inspector/front-end/Toolbar.js: Added.
14554 (WebInspector.Toolbar):
14555 (WebInspector.Toolbar.prototype.resize):
14556 (WebInspector.Toolbar.prototype.addPanel):
14557 (WebInspector.Toolbar.prototype._toolbarDragStart):
14558 (WebInspector.Toolbar.prototype._toolbarDragEnd):
14559 (WebInspector.Toolbar.prototype._toolbarDrag):
14560 (WebInspector.Toolbar.prototype._onClose):
14561 (WebInspector.Toolbar.prototype._setDropdownVisible):
14562 (WebInspector.Toolbar.prototype._toggleDropdown):
14563 (WebInspector.Toolbar.prototype._updateDropdownButtonAndHideDropdown):
14564 (WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked):
14565 (WebInspector.Toolbar.createPanelToolbarItem):
14566 (WebInspector.ToolbarDropdown):
14567 (WebInspector.ToolbarDropdown.prototype.show):
14568 (WebInspector.ToolbarDropdown.prototype.hide):
14569 (WebInspector.ToolbarDropdown.prototype.get visible):
14570 (WebInspector.ToolbarDropdown.prototype._populate):
14571 (WebInspector.ToolbarDropdown.prototype._onKeyDown):
14572 * inspector/front-end/WebKit.qrc:
14573 * inspector/front-end/inspector.css:
14574 (#toolbar):
14575 (.toolbar-item):
14576 (.toolbar-item.toggleable):
14577 (.toolbar-item.toggleable.toggled-on):
14578 (#toolbar-dropdown .toolbar-icon):
14579 (#toolbar-dropdown .toolbar-label):
14580 (#toolbar-controls):
14581 (#toolbar-dropdown-arrow):
14582 (body.attached #toolbar-dropdown-arrow):
14583 (#toolbar-dropdown-arrow.dropdown-visible):
14584 (#toolbar-dropdown-arrow:hover):
14585 (#toolbar-dropdown-arrow:active):
14586 (#toolbar-dropdown):
14587 (body.detached.platform-mac-snowleopard #toolbar-dropdown):
14588 (#toolbar-dropdown .scrollable-content):
14589 (#toolbar-dropdown .toolbar-item):
14590 (#toolbar-dropdown .toolbar-item.toggleable.toggled-on):
14591 (#toolbar-dropdown .toolbar-item:hover):
14592 (#toolbar-dropdown .toolbar-item.toggleable.toggled-on:hover):
14593 (#toolbar-dropdown .toolbar-item:active .toolbar-icon):
14594 (.scrollable-content):
14595 (.scrollable-content::-webkit-scrollbar):
14596 (.scrollable-content::-webkit-resizer):
14597 (.scrollable-content::-webkit-scrollbar-thumb:vertical):
14598 (.scrollable-content::-webkit-scrollbar-thumb:vertical:active):
14599 (.scrollable-content::-webkit-scrollbar-track:vertical):
14600 (.toolbar-search-item):
14601 (#search):
14602 (body.attached #search):
14603 (#search-results-matches):
14604 (#close-button-left, #close-button-right):
14605 (.close-left):
14606 * inspector/front-end/inspector.html:
14607 * inspector/front-end/inspector.js:
14608 (WebInspector.set attached):
14609 (WebInspector.addPanel):
14610 (WebInspector.windowResize):
14611
14612 2011-02-22 Philippe Normand <pnormand@igalia.com>
14613
14614 Reviewed by Xan Lopez.
14615
14616 [GTK] make distcheck fails
14617 https://bugs.webkit.org/show_bug.cgi?id=54943
14618
14619 Added new headers and removed references to deleted files.
14620
14621 * GNUmakefile.am:
14622
14623 2011-02-21 Yury Semikhatsky <yurys@chromium.org>
14624
14625 Reviewed by Pavel Feldman.
14626
14627 Web Inspector: make DOM storage and Database agents have the same lifeti me as InspectorAgent
14628 https://bugs.webkit.org/show_bug.cgi?id=54891
14629
14630 * inspector/InspectorAgent.cpp:
14631 (WebCore::InspectorAgent::InspectorAgent):
14632 (WebCore::InspectorAgent::setFrontend):
14633 (WebCore::InspectorAgent::disconnectFrontend):
14634 (WebCore::InspectorAgent::createFrontendLifetimeAgents):
14635 (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
14636 (WebCore::InspectorAgent::didCommitLoad):
14637 * inspector/InspectorAgent.h:
14638 (WebCore::InspectorAgent::instrumentingAgents):
14639 * inspector/InspectorDOMStorageAgent.cpp:
14640 (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
14641 (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
14642 (WebCore::InspectorDOMStorageAgent::setFrontend):
14643 (WebCore::InspectorDOMStorageAgent::clearFrontend):
14644 (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
14645 (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
14646 (WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
14647 (WebCore::InspectorDOMStorageAgent::clearResources):
14648 * inspector/InspectorDOMStorageAgent.h:
14649 (WebCore::InspectorDOMStorageAgent::create):
14650 * inspector/InspectorDatabaseAgent.cpp:
14651 (WebCore::InspectorDatabaseAgent::didOpenDatabase):
14652 (WebCore::InspectorDatabaseAgent::clearResources):
14653 (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
14654 (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
14655 (WebCore::InspectorDatabaseAgent::setFrontend):
14656 (WebCore::InspectorDatabaseAgent::clearFrontend):
14657 (WebCore::InspectorDatabaseAgent::databaseForId):
14658 (WebCore::InspectorDatabaseAgent::selectDatabase):
14659 * inspector/InspectorDatabaseAgent.h:
14660 (WebCore::InspectorDatabaseAgent::create):
14661 * inspector/InspectorInstrumentation.cpp:
14662 (WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
14663 (WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
14664
14665 2011-02-22 Steve Lacey <sjl@chromium.org>
14666
14667 Reviewed by Darin Fisher.
14668
14669 Rename new media statistics apis to better names
14670
14671 https://bugs.webkit.org/show_bug.cgi?id=54784
14672
14673 * html/HTMLMediaElement.cpp:
14674 (WebCore::HTMLMediaElement::webkitAudioDecodedByteCount):
14675 (WebCore::HTMLMediaElement::webkitVideoDecodedByteCount):
14676 * html/HTMLMediaElement.h:
14677 * html/HTMLMediaElement.idl:
14678 * html/HTMLVideoElement.cpp:
14679 (WebCore::HTMLVideoElement::webkitDecodedFrameCount):
14680 (WebCore::HTMLVideoElement::webkitDroppedFrameCount):
14681 * html/HTMLVideoElement.h:
14682 * html/HTMLVideoElement.idl:
14683 * platform/graphics/MediaPlayer.cpp:
14684 (WebCore::MediaPlayer::decodedFrameCount):
14685 (WebCore::MediaPlayer::droppedFrameCount):
14686 (WebCore::MediaPlayer::audioDecodedByteCount):
14687 (WebCore::MediaPlayer::videoDecodedByteCount):
14688 * platform/graphics/MediaPlayer.h:
14689 * platform/graphics/MediaPlayerPrivate.h:
14690 (WebCore::MediaPlayerPrivateInterface::decodedFrameCount):
14691 (WebCore::MediaPlayerPrivateInterface::droppedFrameCount):
14692 (WebCore::MediaPlayerPrivateInterface::audioDecodedByteCount):
14693 (WebCore::MediaPlayerPrivateInterface::videoDecodedByteCount):
14694
14695 2011-02-21 Roland Steiner <rolandsteiner@chromium.org>
14696
14697 Reviewed by Kent Tamura.
14698
14699 Bug 54435 - Simplify CSSStyleSelector::canShareStyleWithElement
14700 https://bugs.webkit.org/show_bug.cgi?id=54435
14701
14702 Changed the function to a series of early-exit 'if's,
14703 removed most temporary variables.
14704
14705 No new tests. (refactoring)
14706
14707 * css/CSSStyleSelector.cpp:
14708 (WebCore::CSSStyleSelector::canShareStyleWithElement):
14709
14710 2011-02-21 Nico Weber <thakis@chromium.org>
14711
14712 Reviewed by James Robinson.
14713
14714 [chromium] PopupContainer::show() confuses clang's -Woverloaded-virtual
14715 https://bugs.webkit.org/show_bug.cgi?id=54923
14716
14717 Rename PopupContainer::show() to showInRect(), to make it obvious it's
14718 not an override of ScrollView::show().
14719
14720 No intended functionality change.
14721
14722 * platform/chromium/PopupMenuChromium.cpp:
14723 (WebCore::PopupContainer::showInRect):
14724 (WebCore::PopupMenuChromium::show):
14725 * platform/chromium/PopupMenuChromium.h:
14726
14727 2011-02-21 Julien Chaffraix <jchaffraix@codeaurora.org>
14728
14729 Reviewed by Antti Koivisto.
14730
14731 Improve the local{SharedStyle,CousinList} algorithm
14732 https://bugs.webkit.org/show_bug.cgi?id=45507
14733
14734 This change improves the algorithm to find shared styles: the old
14735 algorithm would stop the search after the first cousin, even if
14736 the search threshold is not met. As such, the algorithm would
14737 systematically miss sharings across second cousins and beyond.
14738 The new algorithm continues the search, as long as threshold is
14739 not met. It also separates the threshold for sibling/cousins
14740 search, from that on the levels of search, which is easier to
14741 optimize.
14742 The new algorithm finds up to 30% more sharings on some sites
14743 (e.g. amazon.com and rakuten.co.jp) with no noticeable slowdown.
14744
14745 No new test, refactoring only.
14746
14747 * css/CSSStyleSelector.cpp:
14748 (WebCore::CSSStyleSelector::locateCousinList):
14749 (WebCore::CSSStyleSelector::locateSharedStyle):
14750 While changing the algorithm, cleaned up the style of those 2 methods
14751 (use early return, renamed some variables).
14752
14753 * css/CSSStyleSelector.h:
14754
14755 2011-02-21 Nico Weber <thakis@chromium.org>
14756
14757 Reviewed by Adam Barth.
14758
14759 RenderTableCell::baselinePosition() confuses clang's -Woverloaded-virtua l
14760 https://bugs.webkit.org/show_bug.cgi?id=54922
14761
14762 RenderTableCell::baselinePosition() has the same name as a virtual
14763 method in superclass RenderBlock. Rename the subclass method to make
14764 it clear it's not an attempted override.
14765
14766 No intended functionality change.
14767
14768 * rendering/RenderTableCell.cpp:
14769 (WebCore::RenderTableCell::cellBaselinePosition):
14770 * rendering/RenderTableCell.h:
14771 * rendering/RenderTableSection.cpp:
14772 (WebCore::RenderTableSection::calcRowLogicalHeight):
14773 (WebCore::RenderTableSection::layoutRows):
14774
14775 2011-02-21 Benjamin Kalman <kalman@chromium.org>
14776
14777 Reviewed by Ryosuke Niwa.
14778
14779 Extending selection by a boundary granularity (LineBoundary/ParagraphBou ndary/DocumentBoundary) sets incorrect
14780 start/end of selection for RTL
14781 https://bugs.webkit.org/show_bug.cgi?id=54724
14782
14783 On mac, the selection should always grow when extending by a boundary gr anularity (line/paragraph/document).
14784 This is achieved by extending from the start for the "left" direction (e .g. pressing left arrow key), or
14785 extending from the end when for the "right" direction (e.g. pressing rig ht arrow key).
14786
14787 However, this has a bug for RTL text, which should actually extend from the *end* when extending left (since
14788 direction is obviously reversed) and likewise extend from the start when extending right.
14789
14790 * editing/SelectionController.cpp:
14791 (WebCore::SelectionController::modify):
14792
14793 2011-02-21 Nico Weber <thakis@chromium.org>
14794
14795 Reviewed by Adam Barth.
14796
14797 ImageDocument::imageChanged() confuses clang's -Woverride-virtual
14798 https://bugs.webkit.org/show_bug.cgi?id=54924
14799
14800 Rename ImageDocument::imageChanged() to imageUpdated() to make clear
14801 that it's not an override of CachedResourceClient::imageChanged().
14802
14803 * html/ImageDocument.cpp:
14804 (WebCore::ImageDocumentParser::appendBytes):
14805 (WebCore::ImageDocumentParser::finish):
14806 (WebCore::ImageDocument::imageUpdated):
14807 * html/ImageDocument.h:
14808
14809 2011-02-21 Roland Steiner <rolandsteiner@chromium.org>
14810
14811 Reviewed by Kent Tamura.
14812
14813 Bug 54934 - Sort the WebCore project file(s)
14814 https://bugs.webkit.org/show_bug.cgi?id=54934
14815
14816 No new tests. (no code affected)
14817
14818 * GNUmakefile.am:
14819 * WebCore.xcodeproj/project.pbxproj:
14820
14821 2011-02-21 Nico Weber <thakis@chromium.org>
14822
14823 Reviewed by Adam Barth.
14824
14825 canAccommodateEllipsis() confuses clang's -Woverloaded-virtual
14826 https://bugs.webkit.org/show_bug.cgi?id=54909
14827
14828 Rename the overload in RootInlineBox to lineCanAccomodateEllipsis() to
14829 unconfuse clang. No intended functionality change.
14830
14831 * rendering/RenderBlockLineLayout.cpp:
14832 (WebCore::RenderBlock::checkLinesForTextOverflow):
14833 * rendering/RenderFlexibleBox.cpp:
14834 (WebCore::RenderFlexibleBox::applyLineClamp):
14835 * rendering/RootInlineBox.cpp:
14836 (WebCore::RootInlineBox::lineCanAccommodateEllipsis):
14837 * rendering/RootInlineBox.h:
14838
14839 2011-02-21 Adele Peterson <adele@apple.com>
14840
14841 Reviewed by Dan Bernstein.
14842
14843 Fix for for https://bugs.webkit.org/show_bug.cgi?id=54402
14844 REGRESSION (r72052): Placeholder text doesn't have the right padding for search fields on Windows
14845
14846 Test: updated fast/forms/placeholder-position.html and tested manually
14847
14848 Consider padding and margin for the results and cancel buttons. This is important for the Windows
14849 theme which uses padding to correctly position those buttons. This chan ge fixes the placeholder
14850 position, and also better aligns the results popup list with the actual text you type.
14851
14852 * rendering/RenderTextControlSingleLine.cpp:
14853 (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
14854 (WebCore::RenderTextControlSingleLine::clientPaddingRight):
14855
14856 2011-02-21 Nico Weber <thakis@chromium.org>
14857
14858 Reviewed by Kent Tamura.
14859
14860 GIFImageDecoder::setSize() tries to override the superclass method but f ails
14861 https://bugs.webkit.org/show_bug.cgi?id=54305
14862
14863 The superclass uses unsigned instead of int for its parameters, so
14864 GIFImageDecoder::setSize() was an overload, not an override.
14865
14866 * platform/image-decoders/gif/GIFImageDecoder.cpp:
14867 (WebCore::GIFImageDecoder::setSize):
14868 * platform/image-decoders/gif/GIFImageDecoder.h:
14869
14870 2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
14871
14872 Reviewed by Darin Adler.
14873
14874 Deploy EditingStyle more in ApplyStyleCommand and do some cleanup
14875 https://bugs.webkit.org/show_bug.cgi?id=54528
14876
14877 * editing/ApplyStyleCommand.cpp:
14878 (WebCore::StyleChange::init): Allows style to be a null pointer.
14879 (WebCore::ApplyStyleCommand::applyInlineStyle): Overrides the value of t ext-decoration property by that of
14880 -webkit-text-decorations-in-effect and remove the latter property when p resent. This allows removeImplicitlyStyledElement
14881 to ignore -webkit-text-decorations-in-effect. Also uses the return value of EditingStyle::textDirection to determine
14882 whether or not we need to apply unicode-bidi / direction instead of dire ctly checking the value of unicode-bidi property.
14883 (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Takes Editing Style* instead of CSSMutableStyleDeclaration*.
14884 (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Ditto.
14885 (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Dit to.
14886 (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto.
14887 (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Ditto.
14888 (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Ditto.
14889 (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto; no longer collap se text decoration properties because
14890 ApplyStyleCommand::applyInlineStyle already does it.
14891 * editing/ApplyStyleCommand.h:
14892 * editing/EditingStyle.cpp:
14893 (WebCore::EditingStyle::textDirection): Exits early when m_mutableStyle is null.
14894 (WebCore::EditingStyle::collapseTextDecorationProperties): Extracted fro m ApplyStyleCommand::removeInlineStyle.
14895 * editing/EditingStyle.h:
14896
14897 2011-02-21 Mark Rowe <mrowe@apple.com>
14898
14899 Reviewed by Darin Adler and Alexey Proskuryakov.
14900
14901 <http://webkit.org/b/54919> / <rdar://problem/7689300> WebCore should re trieve unclamped frame delays from ImageIO
14902
14903 * platform/graphics/cg/ImageSourceCG.cpp:
14904 (WebCore::ImageSource::frameDurationAtIndex): Look for the unclamped fra me delay in the
14905 frame properties dictionary and use that if it exists. If it does not ex ist in the
14906 dictionary then fall back to using the clamped frame delay.
14907
14908 2011-02-21 James Kozianski <koz@chromium.org>
14909
14910 Reviewed by Kent Tamura.
14911
14912 Causes elements to be unfocusable after tabindex property is removed.
14913 https://bugs.webkit.org/show_bug.cgi?id=54727
14914
14915 Test: fast/html/tabindex-removal.html
14916
14917 * dom/Node.cpp:
14918 (WebCore::Node::clearTabIndexExplicitly):
14919 * dom/Node.h:
14920 * dom/NodeRareData.h:
14921 (WebCore::NodeRareData::clearTabIndexExplicitly):
14922 * html/HTMLElement.cpp:
14923 (WebCore::HTMLElement::parseMappedAttribute):
14924
14925 2011-02-21 Alexey Proskuryakov <ap@apple.com>
14926
14927 Reviewed by Mark Rowe.
14928
14929 <rdar://problem/8995483> Remove stubs of unneeded NSURLAuthenticationCha llengeSender methods
14930
14931 * platform/network/mac/AuthenticationMac.mm: Remove the stubs that are n o longer needed.
14932
14933 2011-02-21 Sam Weinig <sam@webkit.org>
14934
14935 Reviewed by Dan Bernstein.
14936
14937 Overhang areas need to be invalidated on scroll
14938 <rdar://problem/9032194>
14939 https://bugs.webkit.org/show_bug.cgi?id=54917
14940
14941 * platform/ScrollView.cpp:
14942 (WebCore::ScrollView::scrollContents):
14943 We need to explicitly invalidate the overhang areas when we scroll the c ontents
14944 of a ScrollView, since they could contain arbitrary content that cannot be blitted.
14945
14946 2011-02-21 Lucas Forschler <lforschler@apple.com>
14947
14948 Reviewed by Stephanie Lewis.
14949
14950 Fix the Leopard Debug build by incorporating the RenderSVGAllInOne.cpp
14951
14952 No new tests required.
14953
14954 * WebCore.xcodeproj/project.pbxproj:
14955
14956 2011-02-21 Pratik Solanki <psolanki@apple.com>
14957
14958 Reviewed by Darin Adler.
14959
14960 Remove global initializer in CookieStorageCFNet.cpp
14961 https://bugs.webkit.org/show_bug.cgi?id=54905
14962
14963 * platform/network/cf/CookieStorageCFNet.cpp:
14964 (WebCore::currentCookieStorage):
14965 (WebCore::setCurrentCookieStorage):
14966 (WebCore::setCookieStoragePrivateBrowsingEnabled):
14967
14968 2011-02-18 Jer Noble <jer.noble@apple.com>
14969
14970 Reviewed by Sam Weinig.
14971
14972 WebKit2: Media document videos play only sound, no video (affects traile rs.apple.com)
14973 https://bugs.webkit.org/show_bug.cgi?id=54771
14974
14975 Now that video is accelerated, we no longer need to special case
14976 video playing within a media document.
14977
14978 * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
14979 (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
14980 (WebCore::MediaPlayerPrivateQTKit::supportsAcceleratedRendering):
14981
14982 2011-02-21 Alexey Proskuryakov <ap@apple.com>
14983
14984 Reviewed by Adam Roben.
14985
14986 REGRESSION (WebKit2): HTTP requests time out after 60 seconds
14987 https://bugs.webkit.org/show_bug.cgi?id=54755
14988 <rdar://problem/9006592>
14989
14990 No new tests - it won't be great to have a test that runs for a minute.
14991
14992 It's now possible to set a default timeout to be used at ResourceRequest creation. If one
14993 hasn't been set, ResourceRequest will behave as before (use NSURLRequest default on Mac,
14994 or use INT_MAX on other platforms).
14995
14996 * WebCore.exp.in:
14997 * platform/network/ResourceRequestBase.cpp:
14998 (WebCore::ResourceRequestBase::defaultTimeoutInterval): Get the Resource Request notion of
14999 default timeout interval (may be 0 if using NSURLRequest default).
15000 (WebCore::ResourceRequestBase::setDefaultTimeoutInterval): Set the stati c member variable.
15001 (WebCore::ResourceRequestBase::updatePlatformRequest): Added an assertio n that resource
15002 request is updated. Plaform code often calls updateResourceRequest() ind irectly from this
15003 function, and that must obviously be a no-op.
15004 (WebCore::ResourceRequestBase::updateResourceRequest): Added an assertio n in the opposite
15005 direction.
15006 * platform/network/ResourceRequestBase.h: Changed "unspecifiedTimeoutInt erval" to
15007 "defaultTimeoutInterval". It has been used as default by most platforms anyway.
15008 (WebCore::ResourceRequestBase::ResourceRequestBase):
15009
15010 * platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest: :doUpdatePlatformRequest):
15011 Now zero is the magic value, not INT_MAX. We'll use NSURLRequest default if neither
15012 setTimeoutInterval() nor setDefaultTimeoutInterval() has been called.
15013
15014 2011-02-21 Martin Robinson <mrobinson@igalia.com>
15015
15016 Reviewed by Xan Lopez.
15017
15018 [GTK] editing/pasteboard/dataTransfer-setData-getData.html fails
15019 https://bugs.webkit.org/show_bug.cgi?id=54895
15020
15021 Correct the GTK+ clipboard implementation to know that "text" is an alia s
15022 for "text/html" data. This corrects the failing test.
15023
15024 * platform/gtk/ClipboardGtk.cpp:
15025 (WebCore::dataObjectTypeFromHTMLClipboardType): Accept "text" as well as "Text".
15026 (WebCore::ClipboardGtk::types): Advertise "text" as well as "Text".
15027
15028 2011-02-21 Vsevolod Vlasov <vsevik@chromium.org>
15029
15030 Reviewed by Pavel Feldman.
15031
15032 ProcessingInstruction should provide a way to know if it is of CSS type.
15033 https://bugs.webkit.org/show_bug.cgi?id=54868
15034
15035 * dom/ProcessingInstruction.cpp:
15036 (WebCore::ProcessingInstruction::ProcessingInstruction):
15037 (WebCore::ProcessingInstruction::checkStyleSheet):
15038 (WebCore::ProcessingInstruction::setCSSStyleSheet):
15039 * dom/ProcessingInstruction.h:
15040 (WebCore::ProcessingInstruction::isCSS):
15041
15042 2011-02-21 Simon Fraser <simon.fraser@apple.com>
15043
15044 Put JSDOMImplementationCustom.cpp where it belongs in the project.
15045
15046 * WebCore.xcodeproj/project.pbxproj:
15047
15048 2011-02-21 Gavin Barraclough <barraclough@apple.com>
15049
15050 Reviewed by Sam Weinig.
15051
15052 Bug 54894 - Make inheritance structure described by ClassInfo match C++ class hierarchy.
15053
15054 The ClassInfo objects describe an inheritance hierarchy, with each Class Info instance
15055 containing a pointer to its parent class. These links should reflect the inheritance
15056 hierarchy of C++ classes below JSObject. For the large part it does, but in some cases
15057 entries in the C++ hierarchy are skipped over. This presently likely doe sn't matter,
15058 since intervening C++ classes may not have ClassInfo - but would be a po tential bug
15059 were ClassInfo were to be added.
15060
15061 * bindings/js/JSAudioConstructor.cpp:
15062 * bindings/js/JSDOMGlobalObject.cpp:
15063 * bindings/js/JSImageConstructor.cpp:
15064 * bindings/js/JSOptionConstructor.cpp:
15065 * bindings/scripts/CodeGeneratorJS.pm:
15066 * bridge/objc/objc_runtime.mm:
15067 * bridge/runtime_object.cpp:
15068
15069 2011-02-21 Pavel Feldman <pfeldman@chromium.org>
15070
15071 Reviewed by Yury Semikhatsky.
15072
15073 Web Inspector: navigation does not work after reopening frontend.
15074 https://bugs.webkit.org/show_bug.cgi?id=54879
15075
15076 Test: http/tests/inspector-enabled/open-close-open.html
15077
15078 * inspector/InspectorAgent.cpp:
15079 (WebCore::InspectorAgent::setFrontend):
15080 * inspector/InspectorState.cpp:
15081 (WebCore::InspectorState::unmute):
15082 * inspector/InspectorState.h:
15083
15084 2011-02-21 Adam Roben <aroben@apple.com>
15085
15086 Protect the PluginView when evaluating javascript: URLs
15087
15088 Fixes <http://webkit.org/b/54884> <rdar://problem/9030864>
15089 plugins/get-url-with-javascript-destroying-plugin.html crashing on Windo ws since it was
15090 added
15091
15092 Reviewed by Sam Weinig.
15093
15094 * plugins/PluginView.cpp:
15095 (WebCore::PluginView::performRequest): Protect the PluginView, not just its parent frame,
15096 when evaluating javascript: URLs.
15097
15098 2011-02-21 Martin Robinson <mrobinson@igalia.com>
15099
15100 Fix GTK+ build after r79223.
15101
15102 * GNUmakefile.am: Add file missing from the source list.
15103
15104 2011-02-14 Alexander Pavlov <apavlov@chromium.org>
15105
15106 Reviewed by Yury Semikhatsky.
15107
15108 Web Inspector: audits should not warn about gzip compression for 304s
15109 https://bugs.webkit.org/show_bug.cgi?id=54343
15110
15111 Do not run compression-related audits on 304 resources.
15112 Drive-by: handle multi-encoding resources (Content-Encoding: sdhc,gzip) correctly.
15113
15114 * inspector/front-end/AuditRules.js:
15115 (WebInspector.AuditRules.GzipRule.prototype.doRun):
15116 (WebInspector.AuditRules.GzipRule.prototype._isCompressed):
15117
15118 2011-02-08 Anton Muhin <antonm@chromium.org>
15119
15120 Reviewed by Adam Barth and Alexey Proskuryakov.
15121
15122 Propagate security origin of parent document into HTML documents created with DOMImplementation
15123 https://bugs.webkit.org/show_bug.cgi?id=53611
15124
15125 This restores invariant that JS wrappers residing in the same JS context should come
15126 from the same security origin.
15127
15128 Absence of regressions is covered by the current tests. Different securi ty origin of
15129 DOMImplementation is difficult to check with layout tests as DOMImplement ation
15130 resides in the same JS context as parent document and therefore there are no security origin checks.
15131 This is observable however in C++.
15132
15133 * Android.jscbindings.mk:
15134 * CMakeLists.txt:
15135 * WebCore.gypi:
15136 * WebCore.pro:
15137 * WebCore.vcproj/WebCore.vcproj:
15138 * WebCore.xcodeproj/project.pbxproj:
15139 * bindings/v8/V8GCController.cpp:
15140 (WebCore::NodeGrouperVisitor::visitDOMWrapper):
15141 * dom/DOMImplementation.cpp:
15142 (WebCore::DOMImplementation::DOMImplementation):
15143 (WebCore::DOMImplementation::createDocument):
15144 * dom/DOMImplementation.h:
15145 (WebCore::DOMImplementation::create):
15146 (WebCore::DOMImplementation::documentDestroyed):
15147 (WebCore::DOMImplementation::parentDocument):
15148 * dom/DOMImplementation.idl:
15149 * dom/Document.cpp:
15150 (WebCore::Document::~Document):
15151 (WebCore::Document::implementation):
15152 * dom/Document.h:
15153
15154 2011-02-21 Andrey Adaikin <aandrey@google.com>
15155
15156 Reviewed by Pavel Feldman.
15157
15158 Web Inspector: [Text editor] Optimize editing updates in gutter panel
15159 https://bugs.webkit.org/show_bug.cgi?id=54866
15160
15161 * inspector/front-end/TextViewer.js:
15162 (WebInspector.TextViewer.prototype.set startEditingListener):
15163 (WebInspector.TextViewer.prototype.set endEditingListener):
15164 (WebInspector.TextViewer.prototype.endUpdates):
15165 (WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
15166 (WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
15167 (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
15168 (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
15169 (WebInspector.TextEditorGutterPanel.prototype.textChanged):
15170 (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
15171
15172 2011-02-21 Alexander Pavlov <apavlov@chromium.org>
15173
15174 Reviewed by Yury Semikhatsky.
15175
15176 Web Inspector: [Audits] Image dimensions in inline style not checked
15177 https://bugs.webkit.org/show_bug.cgi?id=54738
15178
15179 * inspector/front-end/AuditRules.js:
15180 (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
15181
15182 2011-02-21 Yury Semikhatsky <yurys@chromium.org>
15183
15184 Reviewed by Pavel Feldman.
15185
15186 Web Inspector: create and destroy DOM agent along with InspectorAgent
15187 https://bugs.webkit.org/show_bug.cgi?id=54875
15188
15189 * GNUmakefile.am:
15190 * WebCore.gypi:
15191 * WebCore.pro:
15192 * WebCore.vcproj/WebCore.vcproj:
15193 * WebCore.xcodeproj/project.pbxproj:
15194 * inspector/InstrumentingAgents.h: Added. Agents that want to instrument WebCore should register themselve
15195 on this object.
15196 (WebCore::InstrumentingAgents::InstrumentingAgents):
15197 (WebCore::InstrumentingAgents::~InstrumentingAgents):
15198 (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent):
15199 (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent):
15200 (WebCore::InstrumentingAgents::inspectorConsoleAgent):
15201 (WebCore::InstrumentingAgents::setInspectorConsoleAgent):
15202 (WebCore::InstrumentingAgents::inspectorDOMAgent):
15203 (WebCore::InstrumentingAgents::setInspectorDOMAgent):
15204 (WebCore::InstrumentingAgents::inspectorDOMStorageAgent):
15205 (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent):
15206 (WebCore::InstrumentingAgents::inspectorDatabaseAgent):
15207 (WebCore::InstrumentingAgents::setInspectorDatabaseAgent):
15208 (WebCore::InstrumentingAgents::inspectorDebuggerAgent):
15209 (WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
15210 (WebCore::InstrumentingAgents::inspectorProfilerAgent):
15211 (WebCore::InstrumentingAgents::setInspectorProfilerAgent):
15212 (WebCore::InstrumentingAgents::inspectorResourceAgent):
15213 (WebCore::InstrumentingAgents::setInspectorResourceAgent):
15214 (WebCore::InstrumentingAgents::inspectorRuntimeAgent):
15215 (WebCore::InstrumentingAgents::setInspectorRuntimeAgent):
15216 (WebCore::InstrumentingAgents::inspectorStorageAgent):
15217 (WebCore::InstrumentingAgents::setInspectorStorageAgent):
15218 (WebCore::InstrumentingAgents::inspectorTimelineAgent):
15219 (WebCore::InstrumentingAgents::setInspectorTimelineAgent):
15220 * inspector/InspectorAgent.cpp:
15221 (WebCore::InspectorAgent::InspectorAgent):
15222 (WebCore::InspectorAgent::setFrontend):
15223 (WebCore::InspectorAgent::disconnectFrontend):
15224 (WebCore::InspectorAgent::createFrontendLifetimeAgents):
15225 (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
15226 (WebCore::InspectorAgent::didCommitLoad):
15227 (WebCore::InspectorAgent::domContentLoadedEventFired):
15228 (WebCore::InspectorAgent::loadEventFired):
15229 * inspector/InspectorAgent.h:
15230 * inspector/InspectorCSSAgent.cpp:
15231 (WebCore::InspectorCSSAgent::InspectorCSSAgent):
15232 (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
15233 * inspector/InspectorCSSAgent.h:
15234 * inspector/InspectorConsoleAgent.cpp:
15235 (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
15236 (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
15237 (WebCore::InspectorConsoleAgent::clearConsoleMessages):
15238 (WebCore::InspectorConsoleAgent::clearFrontend):
15239 (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
15240 (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
15241 (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
15242 (WebCore::InspectorConsoleAgent::addConsoleMessage):
15243 * inspector/InspectorConsoleAgent.h:
15244 * inspector/InspectorDOMAgent.cpp: DOM agent now lives even when the fro nt-end is not attached.
15245 (WebCore::InspectorDOMAgent::InspectorDOMAgent):
15246 (WebCore::InspectorDOMAgent::setFrontend): Add DOM agent to the set of a ctive agents when the front-end
15247 is attached.
15248 (WebCore::InspectorDOMAgent::clearFrontend):
15249 * inspector/InspectorDOMAgent.h:
15250 (WebCore::InspectorDOMAgent::create):
15251
15252 2011-02-21 Csaba Osztrogonác <ossy@webkit.org>
15253
15254 Reviewed by Andreas Kling.
15255
15256 [Qt][V8]REGRESSION(r79157): Fix build
15257 https://bugs.webkit.org/show_bug.cgi?id=54871
15258
15259 * bridge/npruntime_internal.h: Add one more undef because of evil X11 ma cro.
15260
15261 2011-02-16 Vitaly Repeshko <vitalyr@chromium.org>
15262
15263 Reviewed by Mihai Parparita.
15264
15265 [V8] SerializedScriptValue: fix JS exception handling.
15266 https://bugs.webkit.org/show_bug.cgi?id=54555
15267
15268 Added checks for exceptions and empty handles:
15269 * bindings/v8/SerializedScriptValue.cpp:
15270 (WebCore::Serializer::Serializer):
15271 (WebCore::Serializer::serialize):
15272 (WebCore::Serializer::checkException):
15273 (WebCore::Serializer::reportFailure):
15274 (WebCore::Serializer::ArrayState::advance):
15275 (WebCore::Serializer::AbstractObjectState::AbstractObjectState):
15276 (WebCore::Serializer::AbstractObjectState::advance):
15277 (WebCore::Serializer::push):
15278 (WebCore::Serializer::handleError):
15279 (WebCore::Serializer::newObjectState):
15280 (WebCore::Serializer::doSerialize):
15281 (WebCore::SerializedScriptValue::SerializedScriptValue):
15282
15283 2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
15284
15285 Reviewed by Kent Tamura.
15286
15287 Add selectionchange event
15288 https://bugs.webkit.org/show_bug.cgi?id=45712
15289
15290 Added the support for asynchronous selectionchange event, which is fired whenever selection is changed.
15291 This event is not cancelable and does not bubble. An event listener can be attached to a document by
15292 body element's onselectionchange attribute or via document's onselection change property.
15293
15294 Note that WebKit's implementation fires the event asynchronously whereas Internet Explorer's implementation
15295 fires it synchronously. This implies that a script that modify selection (e.g. via selection's addRange)
15296 will not observe the event before the control returns to JavaScript.
15297
15298 See also: http://msdn.microsoft.com/en-us/library/ms536968(VS.85).aspx
15299
15300 Tests: fast/events/selectionchange-iframe.html
15301 fast/events/selectionchange-user-initiated.html
15302
15303 * dom/Document.cpp:
15304 (WebCore::Document::enqueueDocumentEvent): Added.
15305 * dom/Document.h: Added selectionchange event listener.
15306 * dom/Document.idl: Added onselectionchagne attribute.
15307 * dom/EventNames.h: Added selectionchange
15308 * editing/SelectionController.cpp:
15309 (WebCore::SelectionController::setSelection): Fires selectionchange even t.
15310 * html/HTMLAttributeNames.in: Added onselectionchange.
15311 * html/HTMLBodyElement.cpp:
15312 (WebCore::HTMLBodyElement::parseMappedAttribute): Handles onselectioncha nge attribute.
15313
15314 2011-02-21 Ilya Tikhonovsky <loislo@chromium.org>
15315
15316 Reviewed by Pavel Feldman.
15317
15318 Web Inspector: protocol error messages are dumping incorrectly in Layout tests.
15319 https://bugs.webkit.org/show_bug.cgi?id=54859
15320
15321 * inspector/CodeGeneratorInspector.pm:
15322
15323 2011-02-21 Pavel Feldman <pfeldman@chromium.org>
15324
15325 Reviewed by Yury Semikhatsky.
15326
15327 Web Inspector: generate protocol documentation based on IDL.
15328 https://bugs.webkit.org/show_bug.cgi?id=54822
15329
15330 * inspector/CodeGeneratorInspector.pm:
15331
15332 2011-02-21 Andoni Morales Alastruey <amorales@flumotion.com>
15333
15334 Reviewed by Martin Robinson.
15335
15336 [GStreamer] Add URI queries support in webkitwebsrc
15337 https://bugs.webkit.org/show_bug.cgi?id=54627
15338
15339 This allow replying to URI queries from downstream elements
15340 with the uri currently set in the source element.
15341
15342 No new tests, this feature is dedicated to internal GStreamer use,
15343 such as the upcoming HTTP Live Streaming element.
15344
15345 * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
15346 (webKitWebSrcQuery):
15347
15348 2011-02-21 Andoni Morales Alastruey <amorales@flumotion.com>
15349
15350 Reviewed by Martin Robinson.
15351
15352 [GStreamer] Add 'location' property in webkitwebsrc
15353 https://bugs.webkit.org/show_bug.cgi?id=54628
15354
15355 No new tests, this feature is dedicated to internal GStreamer use,
15356 such as the upcoming HTTP Live Streaming element.
15357
15358 * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
15359 (webkit_web_src_class_init):
15360 (webKitWebSrcSetProperty):
15361 (webKitWebSrcGetProperty):
15362
15363 2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
15364
15365 Reviewed by Kent Tamura.
15366
15367 Rename Position::node() to Position::deprecatedNode()
15368 https://bugs.webkit.org/show_bug.cgi?id=54622
15369
15370 Done the rename. All calls to node() are replaced by calls to deprecated Node() except when
15371 calls were of the form node()->document() and node()->inDocument() in wh ich case they were
15372 replaced by anchorNode()->document() and anchorNode()->inDocument() resp ectively.
15373
15374 * WebCore.exp.in: Added Position::containerNode.
15375
15376 The rest abbreviated for simplicity. Please see svn log.
15377
15378 2011-02-20 Gavin Barraclough <barraclough@apple.com>
15379
15380 Build fix (remove includes).
15381
15382 * bindings/js/JSDOMBinding.cpp:
15383 * bindings/js/JSDOMWindowCustom.cpp:
15384 * bindings/js/JSHistoryCustom.cpp:
15385 * bindings/js/JSLocationCustom.cpp:
15386
15387 2011-02-20 Gavin Barraclough <barraclough@apple.com>
15388
15389 Reviewed by Oliver Hunt.
15390
15391 https://bugs.webkit.org/show_bug.cgi?id=54839
15392 Remove PrototypeFunction, NativeFunctionWrapper, and GlobalEvalFunction.
15393
15394 Historically, Native functions used to be represented by PrototypeFuncti ons, however
15395 since introducing call optimizations to the JIT this has used JSFunction s for host
15396 calls too. At the point this change was made, the interpreter continued to use
15397 PrototypeFunctions, however since fallback from the JIT to interpreter w as introduced
15398 the interpreter has had to be able to run using host functions represent ed using
15399 JSFunctions - leading to an unnecessary and redundant divergence in beha viour between
15400 interpreter only builds, and situations where the JIT has fallen back to interpreting.
15401
15402 NativeFunctionWrapper only existed to select between PrototypeFunction a nd JSFunction
15403 for wrappers for host functions, and as such can also be removed.
15404
15405 GlobalEvalFunction is a redundant wrapper that happens to be derived fro m
15406 PrototypeFunction. It existed to hold a reference to the global object - but since all
15407 functions how derive from JSObjectWithGlobalObject, this no longer requi res an
15408 additional class to provide this functionality.
15409
15410 * bindings/js/JSDOMBinding.cpp:
15411 * bindings/js/JSDOMWindowCustom.cpp:
15412 * bindings/js/JSHistoryCustom.cpp:
15413 * bindings/js/JSLocationCustom.cpp:
15414 Removed use of redundant classes.
15415
15416 2011-02-20 Sheriff Bot <webkit.review.bot@gmail.com>
15417
15418 Unreviewed, rolling out r79169.
15419 http://trac.webkit.org/changeset/79169
15420 https://bugs.webkit.org/show_bug.cgi?id=54846
15421
15422 Made unexpected results for tests without CJK characters
15423 (Requested by tkent on #webkit).
15424
15425 * platform/graphics/chromium/FontCacheChromiumWin.cpp:
15426 (WebCore::FontCache::createFontPlatformData):
15427 * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
15428 (WebCore::FontPlatformData::FontPlatformData):
15429 (WebCore::FontPlatformData::operator=):
15430 * platform/graphics/chromium/FontPlatformDataChromiumWin.h:
15431 (WebCore::FontPlatformData::orientation):
15432 * platform/graphics/skia/FontCustomPlatformData.cpp:
15433 (WebCore::FontCustomPlatformData::fontPlatformData):
15434
15435 2011-02-20 Chun-Lung Huang <alvincl.huang@gmail.com>
15436
15437 Reviewed by Kent Tamura.
15438
15439 On Chromium Windows, glyphs in vertical text tests are rotated 90
15440 degrees clockwise. https://bugs.webkit.org/show_bug.cgi?id=51450
15441
15442 This platform dependent patch makes Chromium Windows show the
15443 vertical writing text correctly. Job was done by adding a prefix '@'
15444 in front of the font family name (Windows Only). No new tests added.
15445
15446 * platform/graphics/chromium/FontCacheChromiumWin.cpp:
15447 (WebCore::FontCache::createFontPlatformData):
15448 * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
15449 (WebCore::FontPlatformData::FontPlatformData):
15450 (WebCore::FontPlatformData::operator=):
15451 * platform/graphics/chromium/FontPlatformDataChromiumWin.h:
15452 (WebCore::FontPlatformData::orientation):
15453 * platform/graphics/skia/FontCustomPlatformData.cpp:
15454 (WebCore::FontCustomPlatformData::fontPlatformData):
15455
15456 2011-02-20 Simon Fraser <simon.fraser@apple.com>
15457
15458 Reviewed by Dirk Schulze.
15459
15460 REGRESSION (r73369-r73405): transform animation interpolates incorrectly
15461 https://bugs.webkit.org/show_bug.cgi?id=54793
15462
15463 After the refactoring in r73380, the ending state for some types of
15464 accelerated animations was computed incorrectly, because the Transformat ionMatrix
15465 wasn't reset to identity before the ending value transformations were ap plied.
15466
15467 Fix by cleaning up the code to use explicit, separate values for
15468 starting and ending values. Only matrix-type animations had this
15469 issue, but cleaned up other clauses similarly.
15470
15471 Test: animations/3d/matrix-transform-type-animation.html
15472
15473 * platform/graphics/ca/GraphicsLayerCA.cpp:
15474 (WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
15475
15476 2011-02-20 Dan Bernstein <mitz@apple.com>
15477
15478 Reviewed by Maciej Stachowiak.
15479
15480 <rdar://problem/9028929> REGRESSION (r75897): Scaling applied twice to a n iframe with a transformed ancestor
15481
15482 Test: fast/frames/iframe-scale-applied-twice.html
15483
15484 * page/FrameView.cpp:
15485 (WebCore::FrameView::create): Set the initial bounds of the view to matc h the
15486 frame size.
15487 * platform/ScrollView.cpp:
15488 (WebCore::ScrollView::visibleContentRect): Based on bounds, not frame si ze.
15489 (WebCore::ScrollView::updateScrollbars): Ditto.
15490 (WebCore::ScrollView::setFrameRect): Moved code that really handles boun ds size
15491 change to setBoundsSize().
15492 (WebCore::ScrollView::setBoundsSize): Added.
15493 (WebCore::ScrollView::setInitialBoundsSize): Added. Sets the bounds size but does
15494 not update anything.
15495 (WebCore::ScrollView::frameRectsChanged): Based on bounds, not frame siz e.
15496 (WebCore::ScrollView::scrollbarCornerPresent): Ditto.
15497 * platform/ScrollView.h:
15498 (WebCore::ScrollView::boundsSize): Added this getter.
15499 * platform/Widget.h:
15500 (WebCore::Widget::resize): Set the bounds size to the frame size.
15501 * platform/mac/ScrollbarThemeMac.mm:
15502 (WebCore::ScrollbarThemeMac::paint): Fixed an error in the indirect draw ing code
15503 path where the buffer rect was resized to capture only the damaged part, but was
15504 still drawn in the original location.
15505
15506 2011-02-20 Alexey Proskuryakov <ap@apple.com>
15507
15508 Reviewed by Eric Seidel.
15509
15510 Tighten up access permissions by using libxslt API
15511 https://bugs.webkit.org/show_bug.cgi?id=52688
15512 <rdar://problem/8909191>
15513
15514 * xml/XSLTProcessorLibxslt.cpp: (WebCore::XSLTProcessor::transformToStri ng): We are only
15515 interested in a string result, so let libxslt know about that.
15516
15517 2011-02-20 Sheriff Bot <webkit.review.bot@gmail.com>
15518
15519 Unreviewed, rolling out r79104.
15520 http://trac.webkit.org/changeset/79104
15521 https://bugs.webkit.org/show_bug.cgi?id=54835
15522
15523 Might have caused flaky canaries (Requested by tonyg-cr on
15524 #webkit).
15525
15526 * html/parser/HTMLDocumentParser.cpp:
15527 (WebCore::HTMLDocumentParser::canTakeNextToken):
15528 (WebCore::HTMLDocumentParser::pumpTokenizer):
15529 * html/parser/HTMLParserScheduler.cpp:
15530 (WebCore::isLayoutTimerActive):
15531 * html/parser/HTMLParserScheduler.h:
15532 (WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
15533 * page/FrameView.h:
15534
15535 2011-02-20 Dirk Schulze <krit@webkit.org>
15536
15537 Reviewed by Nikolas Zimmermann.
15538
15539 SVG animation - analyze attribute type for animation
15540 https://bugs.webkit.org/show_bug.cgi?id=54542
15541
15542 Analyze animated attribute type to determine the kind of animation. Remo ved enum PropertyType and replace it
15543 with AnimatedAttributeType instead. More cleanup of the animation code.
15544 Added missing fillAttributeToPropertyTypeMap() for SVGGElement.
15545
15546 Use QualifiedName instead of AtomicStrings for attribute names. This mak es it easier to handle animated attributes
15547 from a different namespace like xlink:href. The rest of the SVG code is using QualifiedNames as well.
15548
15549 No change of functionality on the animation code. The changes for the <g >-element affect animateTransform. Sadly
15550 animateTransform is not supported by our SVG animation test script at th e moment. Can still be tested manually
15551 with the W3C test suite in trunk.
15552
15553 The change on SVGUseElement gets covered by animate-elem-39-t.svg
15554
15555 Test: svg/animations/animate-dynamic-update-attributeName.html
15556
15557 * svg/SVGAnimateElement.cpp:
15558 (WebCore::SVGAnimateElement::SVGAnimateElement):
15559 (WebCore::SVGAnimateElement::hasValidAttributeType):
15560 (WebCore::SVGAnimateElement::determineAnimatedAttributeType):
15561 (WebCore::SVGAnimateElement::calculateAnimatedValue):
15562 (WebCore::inheritsFromProperty):
15563 (WebCore::SVGAnimateElement::calculateFromAndToValues):
15564 (WebCore::SVGAnimateElement::calculateFromAndByValues):
15565 (WebCore::SVGAnimateElement::resetToBaseValue):
15566 (WebCore::SVGAnimateElement::applyResultsToTarget):
15567 (WebCore::SVGAnimateElement::calculateDistance):
15568 * svg/SVGAnimateElement.h:
15569 * svg/SVGAnimateMotionElement.cpp:
15570 (WebCore::SVGAnimateMotionElement::hasValidAttributeType):
15571 (WebCore::parsePoint):
15572 (WebCore::SVGAnimateMotionElement::resetToBaseValue):
15573 (WebCore::SVGAnimateMotionElement::calculateAnimatedValue):
15574 (WebCore::SVGAnimateMotionElement::calculateDistance):
15575 * svg/SVGAnimateMotionElement.h:
15576 * svg/SVGAnimateTransformElement.cpp:
15577 (WebCore::SVGAnimateTransformElement::hasValidAttributeType):
15578 (WebCore::SVGAnimateTransformElement::determineAnimatedAttributeType):
15579 (WebCore::SVGAnimateTransformElement::resetToBaseValue):
15580 (WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
15581 (WebCore::SVGAnimateTransformElement::calculateFromAndByValues):
15582 (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
15583 (WebCore::SVGAnimateTransformElement::calculateDistance):
15584 * svg/SVGAnimateTransformElement.h:
15585 * svg/SVGAnimationElement.cpp:
15586 (WebCore::parseKeyTimes):
15587 (WebCore::parseKeySplines):
15588 (WebCore::SVGAnimationElement::isTargetAttributeCSSProperty):
15589 (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
15590 (WebCore::SVGAnimationElement::calculateKeyTimesForCalcModePaced):
15591 (WebCore::solveEpsilon):
15592 (WebCore::SVGAnimationElement::calculatePercentFromKeyPoints):
15593 (WebCore::SVGAnimationElement::currentValuesFromKeyPoints):
15594 (WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
15595 (WebCore::SVGAnimationElement::startedActiveInterval):
15596 * svg/SVGAnimationElement.h:
15597 * svg/SVGFilterElement.cpp:
15598 (WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
15599 * svg/SVGGElement.cpp:
15600 (WebCore::SVGGElement::attributeToPropertyTypeMap):
15601 (WebCore::SVGGElement::fillAttributeToPropertyTypeMap): Added to fill th e animated attribute map for this element.
15602 * svg/SVGGElement.h:
15603 * svg/SVGUseElement.cpp:
15604 (WebCore::SVGUseElement::fillAttributeToPropertyTypeMap): Changed attrib ute type to AnimatedString for xlink:href.
15605 * svg/animation/SMILTimeContainer.cpp:
15606 (WebCore::SMILTimeContainer::baseValueFor):
15607 (WebCore::SMILTimeContainer::updateAnimations):
15608 * svg/animation/SMILTimeContainer.h:
15609 * svg/animation/SVGSMILElement.cpp:
15610 (WebCore::SVGSMILElement::SVGSMILElement):
15611 (WebCore::constructQualifiedName): Create a QualifiedName from a attribu te name.
15612 (WebCore::SVGSMILElement::insertedIntoDocument): Update local varaible o f attribute name.
15613 (WebCore::SVGSMILElement::removedFromDocument): Ditto.
15614 (WebCore::SVGSMILElement::attributeChanged): Ditto.
15615 * svg/animation/SVGSMILElement.h:
15616 (WebCore::SVGSMILElement::attributeName):
15617
15618 2011-02-20 David Kilzer <ddkilzer@apple.com>
15619
15620 BUILD FIX: Add missing UNUSED_PARAM() when !ENABLE(FULLSCREEN_API)
15621
15622 Not reviewed.
15623
15624 * rendering/RenderLayerCompositor.cpp:
15625 (WebCore::RenderLayerCompositor::requiresCompositingForFullScreen):
15626
15627 2011-02-20 Carlos Garcia Campos <cgarcia@igalia.com>
15628
15629 Reviewed by Martin Robinson.
15630
15631 [GTK] Implement PlatformKeyboardEvent::getCurrentModifierState()
15632 https://bugs.webkit.org/show_bug.cgi?id=52880
15633
15634 * platform/gtk/KeyEventGtk.cpp:
15635 (WebCore::PlatformKeyboardEvent::getCurrentModifierState):
15636
15637 2011-02-19 Andreas Kling <kling@webkit.org>
15638
15639 Reviewed by Oliver Hunt.
15640
15641 DragController should use Color::serialized() when passing colors to CSS StyleDeclaration
15642 https://bugs.webkit.org/show_bug.cgi?id=54545
15643
15644 * page/DragController.cpp:
15645 (WebCore::DragController::concludeEditDrag):
15646
15647 2011-02-19 Sam Weinig <sam@webkit.org>
15648
15649 Reviewed by Anders Carlsson.
15650
15651 Add phase in addition to momentumPhase to platform wheel events
15652 Part of <rdar://problem/8945362>
15653
15654 Rename existing phase to momentumPhase.
15655
15656 * platform/PlatformWheelEvent.h:
15657 (WebCore::PlatformWheelEvent::PlatformWheelEvent):
15658 (WebCore::PlatformWheelEvent::momentumPhase):
15659 * platform/mac/ScrollAnimatorMac.mm:
15660 (WebCore::ScrollAnimatorMac::handleWheelEvent):
15661 (WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
15662 * platform/mac/WheelEventMac.mm:
15663 (WebCore::momentumPhaseForEvent):
15664 (WebCore::phaseForEvent):
15665 (WebCore::PlatformWheelEvent::PlatformWheelEvent):
15666
15667 2011-02-19 Gavin Barraclough <barraclough@apple.com>
15668
15669 Qt build fix.
15670
15671 * bridge/runtime_method.h:
15672 (JSC::RuntimeMethod::createStructure):
15673
15674 2011-02-19 Gavin Barraclough <barraclough@apple.com>
15675
15676 Qt build fix.
15677
15678 * bridge/qt/qt_instance.cpp:
15679 * bridge/qt/qt_pixmapruntime.cpp:
15680
15681 2011-02-19 Gavin Barraclough <barraclough@apple.com>
15682
15683 Qt build fix.
15684
15685 * bridge/qt/qt_instance.cpp:
15686 (JSC::Bindings::QtInstance::getMethod):
15687 * bridge/qt/qt_pixmapruntime.cpp:
15688 (JSC::Bindings::QtPixmapInstance::getMethod):
15689
15690 2011-02-18 Gavin Barraclough <barraclough@apple.com>
15691
15692 Reviewed by Sam Weinig.
15693
15694 Bug 54786 - Devirtualize JSCell::classInfo()
15695
15696 Instead of making a virtual function call, add a pointer to the ClassInf o
15697 onto Structure.
15698
15699 This removes a virtual function call, and paves the way towards removing all
15700 the createStructure methods, and StructureFlags/AnonymousSlotCount prope rties
15701 (these should be able to move onto ClassInfo).
15702
15703 Calls to Structure::create must now pass a pointer to the ClassInfo for the
15704 structure. All objects now have a ClassInfo pointer, non-object cell typ es
15705 still do not.
15706
15707 Changes are most mechanical, involving three steps:
15708 * Remove virtual classInfo() methods.
15709 * Add &s_info parameter to calls to Structure::create.
15710 * Rename ClassInfo static members on classes from 'info' to 's_info' ,
15711 for consistency.
15712
15713 * WebCore.exp.in:
15714 * bindings/js/JSAudioConstructor.cpp:
15715 * bindings/js/JSAudioConstructor.h:
15716 * bindings/js/JSDOMBinding.cpp:
15717 * bindings/js/JSDOMBinding.h:
15718 * bindings/js/JSDOMGlobalObject.cpp:
15719 * bindings/js/JSDOMGlobalObject.h:
15720 * bindings/js/JSDOMWindowBase.cpp:
15721 * bindings/js/JSDOMWindowBase.h:
15722 * bindings/js/JSDOMWindowShell.cpp:
15723 * bindings/js/JSDOMWindowShell.h:
15724 * bindings/js/JSGeolocationCustom.cpp:
15725 * bindings/js/JSImageConstructor.cpp:
15726 * bindings/js/JSImageConstructor.h:
15727 * bindings/js/JSImageDataCustom.cpp:
15728 * bindings/js/JSOptionConstructor.cpp:
15729 * bindings/js/JSOptionConstructor.h:
15730 * bindings/js/JSWorkerContextBase.cpp:
15731 * bindings/js/JSWorkerContextBase.h:
15732 * bindings/js/SerializedScriptValue.cpp:
15733 * bindings/scripts/CodeGeneratorJS.pm:
15734 * bridge/c/CRuntimeObject.cpp:
15735 * bridge/c/CRuntimeObject.h:
15736 * bridge/c/c_instance.cpp:
15737 * bridge/jni/jsc/JNIUtilityPrivate.cpp:
15738 * bridge/jni/jsc/JavaInstanceJSC.cpp:
15739 * bridge/jni/jsc/JavaRuntimeObject.cpp:
15740 * bridge/jni/jsc/JavaRuntimeObject.h:
15741 * bridge/jsc/BridgeJSC.cpp:
15742 * bridge/objc/ObjCRuntimeObject.h:
15743 * bridge/objc/ObjCRuntimeObject.mm:
15744 * bridge/objc/objc_instance.mm:
15745 * bridge/objc/objc_runtime.h:
15746 * bridge/objc/objc_runtime.mm:
15747 * bridge/runtime_array.cpp:
15748 * bridge/runtime_array.h:
15749 * bridge/runtime_method.cpp:
15750 * bridge/runtime_method.h:
15751 * bridge/runtime_object.cpp:
15752 * bridge/runtime_object.h:
15753
15754 2011-02-19 Zan Dobersek <zandobersek@gmail.com>
15755
15756 Reviewed by Martin Robinson.
15757
15758 [cairo][canvas] Drawing from/into float rectangles with width or height in range 0 to 1 fails
15759 https://bugs.webkit.org/show_bug.cgi?id=54491
15760
15761 When width or height in float rectangle are in range (0, 0.5) or (-0.5, 0)
15762 and would round to 0, alter the behaviour to ensure that width or height are
15763 at least 1 pixel in size in these cases.
15764
15765 * platform/graphics/cairo/GraphicsContextCairo.cpp:
15766 (WebCore::GraphicsContext::roundToDevicePixels):
15767
15768 2011-02-19 Dan Bernstein <mitz@apple.com>
15769
15770 LLVM Compiler build fix.
15771
15772 * platform/graphics/ShadowBlur.cpp:
15773 (WebCore::ShadowBlur::blurLayerImage): Eliminated a file static that gen erated
15774 a global initializer since the compiler does not evaluate sqrtf at compi le time.
15775
15776 2011-02-19 Brian Ryner <bryner@chromium.org>
15777
15778 Reviewed by Adam Barth.
15779
15780 Replace the #include of DocumentLoader.h in Document.h with a
15781 forward declaration, and add a missing #include now that this
15782 transitive include is gone.
15783 https://bugs.webkit.org/show_bug.cgi?id=50489
15784
15785 No new tests required.
15786
15787 * bindings/ScriptControllerBase.cpp:
15788 * dom/Document.h:
15789
15790 2011-02-19 Patrick Gansterer <paroga@webkit.org>
15791
15792 Reviewed by Antonio Gomes.
15793
15794 [EFL] Remove WebCore::currentTime()
15795 https://bugs.webkit.org/show_bug.cgi?id=53886
15796
15797 There is no declaration for it and we use WTF::currentTime() everywhere.
15798
15799 * platform/efl/SystemTimeEfl.cpp:
15800
15801 2011-02-19 Patrick Gansterer <paroga@webkit.org>
15802
15803 Reviewed by Andreas Kling.
15804
15805 Move KeygenWinCE from wince into win directory
15806 https://bugs.webkit.org/show_bug.cgi?id=54804
15807
15808 Move this file into the win directory, since it can be used on all windo ws platforms.
15809
15810 * CMakeListsWinCE.txt:
15811 * platform/win/SSLKeyGeneratorWin.cpp: Renamed from platform/wince/Keyge nWinCE.cpp.
15812
15813 2011-02-19 Patrick Gansterer <paroga@webkit.org>
15814
15815 Reviewed by Andreas Kling.
15816
15817 Make FileChooserWin.cpp more portable and use it on WinCE
15818 https://bugs.webkit.org/show_bug.cgi?id=54803
15819
15820 * CMakeListsWinCE.txt:
15821 * platform/win/FileChooserWin.cpp:
15822 (WebCore::FileChooser::basenameForWidth):
15823 * platform/wince/FileChooserWinCE.cpp: Removed.
15824
15825 2011-02-19 James Simonsen <simonjam@chromium.org>
15826
15827 Reviewed by Adam Barth.
15828
15829 Make ScriptElement match the HTML5 spec
15830 https://bugs.webkit.org/show_bug.cgi?id=54676
15831
15832 This implements the "prepare a script" section of the HTML5 spec in Scri ptElement::prepareScript().
15833 http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1. html#prepare-a-script
15834
15835 There are a couple of things missing from the spec that would be new fun ctionality. These will be added later.
15836 - Support for async=false
15837 - Empty src attribute should dispatch an error.
15838
15839 There are a couple of slight behavioral changes to match the spec.
15840 - An XHTML script that is loaded then copied will not fire load on the c opy.
15841 - If onbeforeload moves the script to a different document, then it will not try to execute again because wasAlreadyStarted is true.
15842
15843 The parsers were updated to use the new API, but not rewritten to look l ike the spec. That will be done separately.
15844
15845 Test: All existing tests.
15846
15847 * dom/ScriptElement.cpp: Rewritten to match HTML5 spec.
15848 (WebCore::ScriptElement::ScriptElement):
15849 (WebCore::ScriptElement::insertedIntoDocument): Logic moved to prepareSc ript.
15850 (WebCore::ScriptElement::childrenChanged): Logic moved to prepareScript.
15851 (WebCore::ScriptElement::handleSourceAttribute): Logic moved to prepareS cript.
15852 (WebCore::isLegacySupportedJavaScriptLanguage): Added to support old scr ipt types in layout tests.
15853 (WebCore::ScriptElement::isScriptTypeSupported): Derived from old should ExecuteAsJavaScript().
15854 (WebCore::ScriptElement::prepareScript): START HERE. Main change. Should read exactly like HTML5's "prepare a script." Legacy type support needed for la yout tests using XML parser.
15855 (WebCore::ScriptElement::requestScript): Most logic moved to prepareScri pt. Check security settings here.
15856 (WebCore::ScriptElement::executeScript): Combined evaluateScript() and e xecuteScript() from old code. Logic moved to prepareScript.
15857 (WebCore::ScriptElement::stopLoadRequest): Ignore parser executed script s.
15858 (WebCore::ScriptElement::execute): Renamed executeScript.
15859 (WebCore::ScriptElement::notifyFinished): We should only listen for non- parser executed scripts.
15860 (WebCore::ScriptElement::ignoresLoadRequest): New variable names.
15861 (WebCore::ScriptElement::childrenAreCommentsOrEmptyText): Added for HTML 5 compliance.
15862 (WebCore::ScriptElement::scriptCharset): Use HTML5 variables.
15863 * dom/ScriptElement.h:
15864 (WebCore::ScriptElement::willBeParserExecuted): Added.
15865 (WebCore::ScriptElement::readyToBeParserExecuted): Added.
15866 (WebCore::ScriptElement::willExecuteWhenDocumentFinishedParsing): Added.
15867 (WebCore::ScriptElement::cachedScript): prepareScript() is the only plac e that should load scripts. This accessor lets the parsers listen for when loads finish.
15868 (WebCore::ScriptElement::isParserInserted): Added.
15869 * dom/XMLDocumentParserLibxml2.cpp:
15870 (WebCore::XMLDocumentParser::endElementNs): Should behave the same. Offl oads much of its work to prepareScript().
15871 * dom/XMLDocumentParserQt.cpp:
15872 (WebCore::XMLDocumentParser::parseEndElement): Identical to libxml2 chan ges.
15873 * html/HTMLScriptElement.cpp:
15874 (WebCore::HTMLScriptElement::insertedIntoDocument): No longer needs url.
15875 (WebCore::HTMLScriptElement::hasSourceAttribute): Added.
15876 * html/HTMLScriptElement.h:
15877 * html/parser/HTMLScriptRunner.cpp:
15878 (WebCore::HTMLScriptRunner::requestPendingScript): Requesting scripts of floaded to ScriptElement.
15879 (WebCore::HTMLScriptRunner::runScript): Should behave the same. Offloads much of its work to prepareScript().
15880 * svg/SVGScriptElement.cpp:
15881 (WebCore::SVGScriptElement::svgAttributeChanged): New ScriptElement func tion names.
15882 (WebCore::SVGScriptElement::insertedIntoDocument): No longer needs url.
15883 (WebCore::SVGScriptElement::finishParsingChildren): ScriptElement::finis hParsingChildren is gone.
15884 (WebCore::SVGScriptElement::hasSourceAttribute): Added.
15885 (WebCore::SVGScriptElement::dispatchLoadEvent): New ScriptElement functi on names.
15886 * svg/SVGScriptElement.h:
15887
15888 2011-02-19 Marc-Antoine Ruel <maruel@chromium.org>
15889
15890 Reviewed by James Robinson.
15891
15892 Split webcore_rendering off webcore_remaining to reduce its size for WPO builds
15893 https://bugs.webkit.org/show_bug.cgi?id=54789
15894
15895 * WebCore.gyp/WebCore.gyp:
15896
15897 2011-02-19 Bill Budge <bbudge@chromium.org>
15898
15899 Reviewed by David Levin.
15900
15901 ThreadableLoaderClient needs willSendRequest method
15902 https://bugs.webkit.org/show_bug.cgi?id=54688
15903
15904 No new tests. Exposes no new functionality
15905
15906 * WebCore.gypi:
15907 * loader/DocumentThreadableLoader.cpp:
15908 (WebCore::DocumentThreadableLoader::willSendRequest):
15909 (WebCore::DocumentThreadableLoader::didReceiveData):
15910 (WebCore::DocumentThreadableLoader::didReceiveCachedMetadata):
15911 * loader/DocumentThreadableLoaderClient.h: Added.
15912 (WebCore::DocumentThreadableLoaderClient::isDocumentThreadableLoaderClie nt):
15913 (WebCore::DocumentThreadableLoaderClient::willSendRequest):
15914 * loader/ThreadableLoaderClient.h:
15915 (WebCore::ThreadableLoaderClient::isDocumentThreadableLoaderClient):
15916
15917 2011-02-19 Charlie Reis <creis@chromium.org>
15918
15919 Reviewed by Mihai Parparita.
15920
15921 Ensure loading has stopped in HistoryController::goToItem
15922 https://bugs.webkit.org/show_bug.cgi?id=54517
15923
15924 Avoid stopping all loaders in goToItem for same document navigations
15925 or pseudo-back-forward URLs. Make HistoryController::goToItem private
15926 to force callers to go through Page::goToItem. Also add a callback to
15927 FrameLoaderClient to let clients decide whether to stop loading first.
15928
15929 Test: http/tests/navigation/forward-to-fragment-fires-onload.html
15930
15931 * loader/EmptyClients.h:
15932 * loader/FrameLoader.h:
15933 * loader/FrameLoaderClient.h:
15934 * loader/HistoryController.cpp:
15935 * loader/HistoryController.h:
15936 * page/Page.cpp:
15937
15938 2011-02-19 Adam Barth <abarth@webkit.org>
15939
15940 Reviewed by Daniel Bates.
15941
15942 Fix xssAuditor/iframe-injection.html
15943 https://bugs.webkit.org/show_bug.cgi?id=54591
15944
15945 We should block the iframe src attribute. Although this technically
15946 can't be used to run script, it's a pretty easy vector for stealing
15947 passwords.
15948
15949 * html/parser/XSSFilter.cpp:
15950 (WebCore::XSSFilter::filterTokenInitial):
15951 (WebCore::XSSFilter::filterIframeToken):
15952 * html/parser/XSSFilter.h:
15953
15954 2011-02-18 Tony Gentilcore <tonyg@chromium.org>
15955
15956 Reviewed by Eric Seidel.
15957
15958 Let the parser yield for layout before running scripts
15959 https://bugs.webkit.org/show_bug.cgi?id=54355
15960
15961 Prior to this patch, the parser would yield to perform a layout/paint be fore running a
15962 script only if the script or a stylesheet blocking the script is not loa ded yet. Since we
15963 don't preload scan into the body while parsing the head, typically we'll block on a script
15964 early in the body that causes us to yield to do the first paint within a reasonable time.
15965
15966 However, I'm planning to change the PreloadScanner to scan into the body from the head.
15967 That significantly improves overall load time, but would hurt first pain t time because
15968 fewer scripts would be blocked during parsing and thus wouldn't yield.
15969
15970 This change causes us to yield before running scripts if we haven't pain ted yet (regardless
15971 of whether or not the script is loaded). In addition to allowing the abo ve mentioned
15972 PreloadScanner change to be implemented without regressing first paint t ime, this also
15973 improves first paint time by itself.
15974
15975 I tested Alexa's top 45 websites using Web Page Replay to control the co ntent and simulate
15976 bandwidth. This patch improved average first paint time by 1% over an un limited connection,
15977 6% over a 1Mbps connection and 11% over a 5Mbps connection. There was no statistically
15978 signifcant change in page load time.
15979
15980 Within the pages tested, 33 had no statistically significant change in t ime to first paint,
15981 12 improved, and none regressed. Of the improved, some of the standouts from the 1Mbps set
15982 are: 20% on youtube, 37% on wiki, 27% on ebay, 13% on cnn, 16% on espn, 74% on sohu.
15983
15984 * html/parser/HTMLDocumentParser.cpp:
15985 (WebCore::HTMLDocumentParser::canTakeNextToken): This is the new yield p oint.
15986 (WebCore::HTMLDocumentParser::pumpTokenizer): Remove ASSERT that we are not paused. isPaused
15987 means that we are waiting for a script. Bug 54574 changed pumpTokenizer( ) so that it does
15988 the right thing whether we are just before a token or waiting for a scri pt. Now that we may
15989 yield before a token or before a script, this may be called while paused .
15990 * html/parser/HTMLParserScheduler.cpp:
15991 (WebCore::isLayoutTimerActive): Added a FIXME because r52919 changed min imumLayoutDelay()
15992 to return m_extraLayoutDelay instead of 0 as a minimum. So checking !min imumLayoutDelay()
15993 no longer works. The fix is to change it to check minimumLayoutDelay() = =
15994 m_extraLayoutDelay. But this is all the more reason to move this method onto Document. I'll
15995 do this in a follow up.
15996 (WebCore::HTMLParserScheduler::checkForYieldBeforeScript): Added.
15997 * page/FrameView.h:
15998 (WebCore::FrameView::hasEverPainted): Added.
15999
16000 2011-02-18 Dawit Alemayehu <adawit@kde.org>
16001
16002 Reviewed by Andreas Kling.
16003
16004 [Qt] Button Element is rendered w/ text off-center.
16005 https://bugs.webkit.org/show_bug.cgi?id=53373
16006
16007 Test: LayoutTests/fast/forms/button-white-space.html
16008
16009 * platform/qt/RenderThemeQt.cpp:
16010 (WebCore::RenderThemeQt::adjustButtonStyle):
16011
16012 2011-02-18 Jonathan Backer <backer@chromium.org>
16013
16014 Reviewed by Eric Seidel.
16015
16016 [chromium] Fix leak of texture IDs in compositor.
16017 https://bugs.webkit.org/show_bug.cgi?id=54750
16018
16019 No new tests. It is extremely unlikely that this leak would have
16020 any user visible impact because only a few bytes of space are wasted
16021 (we're leaking texture IDs, not actual textures) and the space of
16022 texture IDs is large (32 bits).
16023
16024 * platform/graphics/chromium/TextureManager.cpp:
16025 (WebCore::TextureManager::requestTexture):
16026
16027 2011-02-18 Yi Shen <yi.4.shen@nokia.com>
16028
16029 Reviewed by Tor Arne Vestbø.
16030
16031 Always display the media controls when requiresFullscreenForVideoPlaybac k() is true
16032 https://bugs.webkit.org/show_bug.cgi?id=54308
16033
16034 For video element, it should have controls when
16035 Chrome::requiresFullscreenForVideoPlayback() is true.
16036
16037 * html/HTMLMediaElement.cpp:
16038 (WebCore::HTMLMediaElement::controls):
16039
16040 2011-02-18 Adrienne Walker <enne@google.com>
16041
16042 Reviewed by Kenneth Russell.
16043
16044 [chromium] Use nearest-neighbor filtering for root layer.
16045 https://bugs.webkit.org/show_bug.cgi?id=54409
16046 https://bugs.webkit.org/show_bug.cgi?id=54509
16047
16048 This setting creates more consistent images for LayoutTests and
16049 prevents small floating point errors in texture coordinates from
16050 creating off-by-one pixel color differences.
16051
16052 * platform/graphics/chromium/LayerTilerChromium.cpp:
16053 (WebCore::LayerTilerChromium::update):
16054
16055 2011-02-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>
16056
16057 Reviewed by Kent Tamura.
16058
16059 [EFL] Fix coding style errors in RenderThemeEfl.h
16060 https://bugs.webkit.org/show_bug.cgi?id=54693
16061
16062 Fix style errors in RenderThemeEfl.h
16063
16064 * platform/efl/RenderThemeEfl.h:
16065
16066 2011-02-18 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
16067
16068 Reviewed by Andreas Kling.
16069
16070 [Qt] The localized vendor name for Qt SIS packages should be "Nokia"
16071 https://bugs.webkit.org/show_bug.cgi?id=54742
16072
16073 This change was applied in the Qt repository (qt/src/3rdparty/webkit),
16074 so we should do the same here in QtWebKit.
16075
16076 Patch by Eckhart Koppen <eckhart.koppen@nokia.com>
16077 a8a84f1667966acfa093c4be0b7d4b0900ddd3d9:
16078
16079 The previously used name "Nokia, Qt" was not usable for Nokia
16080 Content Signing, which only allows "Nokia" as the visible vendor
16081 name. The unique vendor ID remains as "Nokia, Qt"
16082
16083 * WebCore.pro:
16084
16085 2011-02-18 Alexis Menard <alexis.menard@openbossa.org>
16086
16087 Reviewed by Andreas Kling.
16088
16089 [Qt] REGRESSION(r67516) : on www.gmail.com a strange rendering issue app ears on the
16090 menu bar due to flash.
16091 https://bugs.webkit.org/show_bug.cgi?id=54741
16092
16093 Only show plugins with a valid size. We then don't involve X11 if there is
16094 nothing to see anyway.
16095
16096 * plugins/qt/PluginViewQt.cpp:
16097 (WebCore::PluginView::updatePluginWidget):
16098 (WebCore::PluginView::platformStart):
16099
16100 2011-02-18 Ryuan Choi <ryuan.choi@samsung.com>
16101
16102 Reviewed by Kent Tamura.
16103
16104 [EFL] Remove GDK dependency.
16105 https://bugs.webkit.org/show_bug.cgi?id=53978
16106
16107 Remove GLIB_SUPPORT macro in GDK related code.
16108 Regardless of GLIB_SUPPORT, getDefaultFontOptions() will works same way.
16109
16110 * CMakeListsEfl.txt:
16111 * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
16112 (WebCore::getDefaultFontOptions):
16113
16114 2011-02-18 Noel Gordon <noel.gordon@gmail.com>
16115
16116 Reviewed by James Robinson.
16117
16118 [Chromium] Add elliptical gradient support to GradientSkia
16119 https://bugs.webkit.org/show_bug.cgi?id=51841
16120
16121 Covered by existing tests, these need new rebaselines once this patch
16122 lands for chrome linux, win32
16123
16124 fast/gradients/css3-color-stop-units.html
16125 fast/gradients/css3-color-stops.html
16126 fast/gradients/css3-linear-angle-gradients.html
16127 fast/gradients/css3-radial-gradients.html
16128 fast/gradients/css3-radial-gradients2.html
16129 fast/gradients/css3-radial-gradients3.html
16130 fast/gradients/css3-repeating-radial-gradients.html
16131
16132 * platform/graphics/skia/GradientSkia.cpp:
16133 (WebCore::Gradient::platformGradient):
16134
16135 2011-02-18 James Robinson <jamesr@chromium.org>
16136
16137 Fix typo in boundary test in ASSERT() - test is for an inclusive range, not exclusive.
16138
16139 * platform/graphics/chromium/ContentLayerChromium.cpp:
16140 (WebCore::ContentLayerChromium::updateTextureIfNeeded):
16141
16142 2011-02-18 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
16143
16144 Reviewed by Kenneth Rohde Christiansen.
16145
16146 Tiled backing store area is too big.
16147 Error in area calculcation causes size of backing store
16148 up to 6 times bigger than viewport with default multipliers.
16149 https://bugs.webkit.org/show_bug.cgi?id=54587
16150
16151 * platform/graphics/TiledBackingStore.cpp:
16152 (WebCore::TiledBackingStore::createTiles):
16153
16154 2011-02-18 Beth Dakin <bdakin@apple.com>
16155
16156 Reviewed by Sam Weinig.
16157
16158 Fix for <rdar://problem/9018729> Horizontal scroller doesn't
16159 appear when loading a page with a Horizontal scrollbar from
16160 the back/forward cache.
16161
16162 This patch adds a new bool member variable to FrameView to
16163 keep track of whether we are loading a page from the back/
16164 forward cache. If we are, don't suppress scrollbars on
16165 first layout.
16166 * history/CachedFrame.cpp:
16167 (WebCore::CachedFrameBase::restore):
16168 * page/FrameView.cpp:
16169 (WebCore::FrameView::FrameView):
16170 (WebCore::FrameView::reset):
16171 (WebCore::FrameView::layout):
16172 * page/FrameView.h:
16173 (WebCore::FrameView::setIsRestoringFromBackForward):
16174 (WebCore::FrameView::isRestoringFromBackForward):
16175
16176 2011-02-18 Patrick Gansterer <paroga@webkit.org>
16177
16178 Unreviewed WinCE build fix for r78846.
16179
16180 * platform/graphics/wince/FontWinCE.cpp:
16181 (WebCore::TextRunComponent::TextRunComponent):
16182 * platform/graphics/wince/GraphicsContextWinCE.cpp:
16183 (WebCore::GraphicsContext::drawLineForText):
16184 (WebCore::GraphicsContext::drawLineForTextChecking):
16185 (WebCore::GraphicsContext::drawText):
16186 * platform/wince/FileChooserWinCE.cpp:
16187 (WebCore::FileChooser::basenameForWidth):
16188
16189 2011-02-18 Emil A Eklund <eae@chromium.org>
16190
16191 Reviewed by Darin Adler.
16192
16193 Crash in EventHandler::sendContextMenuEventForKey
16194 https://bugs.webkit.org/show_bug.cgi?id=54495
16195
16196 Test: fast/events/menu-keydown-on-hidden-element.html
16197
16198 * page/EventHandler.cpp:
16199 (WebCore::EventHandler::sendContextMenuEventForKey): Add null check.
16200
16201 2011-02-15 Adrienne Walker <enne@google.com>
16202
16203 Reviewed by James Robinson.
16204
16205 [chromium] Clean up shader code from LayerChromium classes
16206 https://bugs.webkit.org/show_bug.cgi?id=54484
16207
16208 This is a refactoring and there should be no change in functionality.
16209 All shader code is pulled out into classes in ShaderChromium.
16210 The SharedValues classes are now turned into ProgramBinding, one per
16211 shader program. These contain shader classes that know about what
16212 variables they can bind.
16213
16214 * WebCore.gypi:
16215 * platform/graphics/chromium/CanvasLayerChromium.cpp:
16216 (WebCore::CanvasLayerChromium::draw):
16217 * platform/graphics/chromium/CanvasLayerChromium.h:
16218 * platform/graphics/chromium/ContentLayerChromium.cpp:
16219 (WebCore::ContentLayerChromium::draw):
16220 * platform/graphics/chromium/ContentLayerChromium.h:
16221 * platform/graphics/chromium/GeometryBinding.cpp: Added.
16222 (WebCore::GeometryBinding::GeometryBinding):
16223 (WebCore::GeometryBinding::~GeometryBinding):
16224 (WebCore::GeometryBinding::prepareForDraw):
16225 * platform/graphics/chromium/GeometryBinding.h: Copied from Source/WebCo re/platform/graphics/chromium/PluginLayerChromium.h.
16226 (WebCore::GeometryBinding::initialized):
16227 (WebCore::GeometryBinding::context):
16228 (WebCore::GeometryBinding::quadVerticesVbo):
16229 (WebCore::GeometryBinding::quadElementsVbo):
16230 (WebCore::GeometryBinding::positionAttribLocation):
16231 (WebCore::GeometryBinding::texCoordAttribLocation):
16232 * platform/graphics/chromium/LayerChromium.cpp:
16233 (WebCore::LayerChromium::drawDebugBorder):
16234 * platform/graphics/chromium/LayerChromium.h:
16235 * platform/graphics/chromium/LayerRendererChromium.cpp:
16236 (WebCore::LayerRendererChromium::drawLayers):
16237 (WebCore::LayerRendererChromium::initializeSharedObjects):
16238 (WebCore::LayerRendererChromium::cleanupSharedObjects):
16239 * platform/graphics/chromium/LayerRendererChromium.h:
16240 (WebCore::LayerRendererChromium::sharedGeometry):
16241 (WebCore::LayerRendererChromium::borderProgram):
16242 (WebCore::LayerRendererChromium::contentLayerProgram):
16243 (WebCore::LayerRendererChromium::canvasLayerProgram):
16244 (WebCore::LayerRendererChromium::videoLayerRGBAProgram):
16245 (WebCore::LayerRendererChromium::videoLayerYUVProgram):
16246 (WebCore::LayerRendererChromium::pluginLayerProgram):
16247 (WebCore::LayerRendererChromium::renderSurfaceProgram):
16248 (WebCore::LayerRendererChromium::renderSurfaceMaskProgram):
16249 (WebCore::LayerRendererChromium::tilerProgram):
16250 * platform/graphics/chromium/LayerTilerChromium.cpp:
16251 (WebCore::LayerTilerChromium::draw):
16252 (WebCore::LayerTilerChromium::drawTexturedQuad):
16253 * platform/graphics/chromium/LayerTilerChromium.h:
16254 * platform/graphics/chromium/PluginLayerChromium.cpp:
16255 (WebCore::PluginLayerChromium::draw):
16256 * platform/graphics/chromium/PluginLayerChromium.h:
16257 * platform/graphics/chromium/ProgramBinding.cpp: Added.
16258 (WebCore::ProgramBindingBase::ProgramBindingBase):
16259 (WebCore::ProgramBindingBase::~ProgramBindingBase):
16260 (WebCore::ProgramBindingBase::init):
16261 (WebCore::ProgramBindingBase::loadShader):
16262 (WebCore::ProgramBindingBase::createShaderProgram):
16263 * platform/graphics/chromium/ProgramBinding.h: Added.
16264 (WebCore::ProgramBindingBase::program):
16265 (WebCore::ProgramBindingBase::initialized):
16266 (WebCore::ProgramBinding::ProgramBinding):
16267 (WebCore::ProgramBinding::vertexShader):
16268 (WebCore::ProgramBinding::fragmentShader):
16269 * platform/graphics/chromium/RenderSurfaceChromium.cpp:
16270 (WebCore::RenderSurfaceChromium::drawSurface):
16271 * platform/graphics/chromium/RenderSurfaceChromium.h:
16272 * platform/graphics/chromium/ShaderChromium.cpp: Added.
16273 (WebCore::VertexShaderPosTex::VertexShaderPosTex):
16274 (WebCore::VertexShaderPosTex::init):
16275 (WebCore::VertexShaderPosTex::getShaderString):
16276 (WebCore::VertexShaderPosTexYUVStretch::VertexShaderPosTexYUVStretch):
16277 (WebCore::VertexShaderPosTexYUVStretch::init):
16278 (WebCore::VertexShaderPosTexYUVStretch::getShaderString):
16279 (WebCore::VertexShaderPos::VertexShaderPos):
16280 (WebCore::VertexShaderPos::init):
16281 (WebCore::VertexShaderPos::getShaderString):
16282 (WebCore::VertexShaderPosTexTransform::VertexShaderPosTexTransform):
16283 (WebCore::VertexShaderPosTexTransform::init):
16284 (WebCore::VertexShaderPosTexTransform::getShaderString):
16285 (WebCore::FragmentTexAlphaBinding::FragmentTexAlphaBinding):
16286 (WebCore::FragmentTexAlphaBinding::init):
16287 (WebCore::FragmentShaderRGBATexFlipAlpha::getShaderString):
16288 (WebCore::FragmentShaderRGBATexAlpha::getShaderString):
16289 (WebCore::FragmentShaderBGRATexAlpha::getShaderString):
16290 (WebCore::FragmentShaderRGBATexAlphaMask::FragmentShaderRGBATexAlphaMask ):
16291 (WebCore::FragmentShaderRGBATexAlphaMask::init):
16292 (WebCore::FragmentShaderRGBATexAlphaMask::getShaderString):
16293 (WebCore::FragmentShaderYUVVideo::FragmentShaderYUVVideo):
16294 (WebCore::FragmentShaderYUVVideo::init):
16295 (WebCore::FragmentShaderYUVVideo::getShaderString):
16296 (WebCore::FragmentShaderColor::FragmentShaderColor):
16297 (WebCore::FragmentShaderColor::init):
16298 (WebCore::FragmentShaderColor::getShaderString):
16299 * platform/graphics/chromium/ShaderChromium.h: Added.
16300 (WebCore::VertexShaderPosTex::matrixLocation):
16301 (WebCore::VertexShaderPosTexYUVStretch::matrixLocation):
16302 (WebCore::VertexShaderPosTexYUVStretch::yWidthScaleFactorLocation):
16303 (WebCore::VertexShaderPosTexYUVStretch::uvWidthScaleFactorLocation):
16304 (WebCore::VertexShaderPos::matrixLocation):
16305 (WebCore::VertexShaderPosTexTransform::matrixLocation):
16306 (WebCore::VertexShaderPosTexTransform::texTransformLocation):
16307 (WebCore::FragmentTexAlphaBinding::alphaLocation):
16308 (WebCore::FragmentTexAlphaBinding::samplerLocation):
16309 (WebCore::FragmentShaderRGBATexAlphaMask::alphaLocation):
16310 (WebCore::FragmentShaderRGBATexAlphaMask::samplerLocation):
16311 (WebCore::FragmentShaderRGBATexAlphaMask::maskSamplerLocation):
16312 (WebCore::FragmentShaderYUVVideo::yTextureLocation):
16313 (WebCore::FragmentShaderYUVVideo::uTextureLocation):
16314 (WebCore::FragmentShaderYUVVideo::vTextureLocation):
16315 (WebCore::FragmentShaderYUVVideo::alphaLocation):
16316 (WebCore::FragmentShaderYUVVideo::ccMatrixLocation):
16317 (WebCore::FragmentShaderYUVVideo::signAdjLocation):
16318 (WebCore::FragmentShaderColor::colorLocation):
16319 * platform/graphics/chromium/VideoLayerChromium.cpp:
16320 (WebCore::VideoLayerChromium::draw):
16321 (WebCore::VideoLayerChromium::drawYUV):
16322 (WebCore::VideoLayerChromium::drawRGBA):
16323 * platform/graphics/chromium/VideoLayerChromium.h:
16324
16325 2011-02-18 James Robinson <jamesr@chromium.org>
16326
16327 Reviewed by Kenneth Russell.
16328
16329 [chromium] Update texture for ContentLayerChromiums in draw() call inste ad of updateContents..() call
16330 https://bugs.webkit.org/show_bug.cgi?id=54315
16331
16332 This defers all operations on the compositor's GL context until the
16333 draw() call which is a prerequisite for moving the draw() off-thread.
16334 Also cleans up the update cycle a bit - there were some unused local
16335 variables and whatnot.
16336
16337 One consequence of this change is that the upload buffer is retained
16338 across updates now instead of allocated by each paint. This is
16339 necessary so that the full layer contents can be uploaded if the
16340 texture manager evicts the layer's backing texture. This costs more
16341 persistent memory but avoids lots of allocator churn on updates.
16342 Another nonobvious detail is that I have to update the texture for
16343 ContentLayerChromiums in bindContentsTexture() because mask layers
16344 never draw(), they are instead bound to the secondary texture unit.
16345
16346 * platform/graphics/chromium/ContentLayerChromium.cpp:
16347 (WebCore::ContentLayerChromium::requiresClippedUpdateRect):
16348 (WebCore::ContentLayerChromium::updateContentsIfDirty):
16349 (WebCore::ContentLayerChromium::resizeUploadBufferForImage):
16350 (WebCore::ContentLayerChromium::resizeUploadBuffer):
16351 (WebCore::SkBitmapConditionalAutoLockerPixels::SkBitmapConditionalAutoLo ckerPixels):
16352 (WebCore::SkBitmapConditionalAutoLockerPixels::~SkBitmapConditionalAutoL ockerPixels):
16353 (WebCore::SkBitmapConditionalAutoLockerPixels::lockPixels):
16354 (WebCore::ContentLayerChromium::updateTextureIfNeeded):
16355 (WebCore::ContentLayerChromium::draw):
16356 (WebCore::ContentLayerChromium::unreserveContentsTexture):
16357 (WebCore::ContentLayerChromium::bindContentsTexture):
16358 * platform/graphics/chromium/ContentLayerChromium.h:
16359 * platform/graphics/chromium/ImageLayerChromium.cpp:
16360 (WebCore::ImageLayerChromium::updateContentsIfDirty):
16361 * platform/graphics/chromium/LayerChromium.cpp:
16362 (WebCore::LayerChromium::setBounds):
16363 * platform/graphics/chromium/LayerChromium.h:
16364
16365 2011-02-18 Kenneth Russell <kbr@google.com>
16366
16367 Unreviewed, Chromium build fix on certain Linux platforms.
16368
16369 * platform/graphics/gpu/LoopBlinnSolidFillShader.cpp:
16370
16371 2011-02-18 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
16372
16373 Reviewed by Kenneth Rohde Christiansen.
16374
16375 [Qt] Implement client based geolocation for qtport
16376 https://bugs.webkit.org/show_bug.cgi?id=42629
16377
16378 Implements client based geolocation for qtwebkit. Removed old code relat ed to non-client based geolocation
16379
16380 No tests as yet. This will be raised as different bug as new mock client implementation need to be done.
16381
16382 * WebCore.pro:
16383 * features.pri:
16384 * platform/qt/GeolocationServiceQt.cpp: Removed.
16385 * platform/qt/GeolocationServiceQt.h: Removed.
16386
16387 2011-02-18 Yael Aharon <yael.aharon@nokia.com>
16388
16389 Reviewed by Dave Hyatt.
16390
16391 Add support for dir=auto
16392 https://bugs.webkit.org/show_bug.cgi?id=50916
16393
16394 When an element has dir attribute with value "auto", call defaultWriting Mode
16395 to find its directionality.
16396 Added a flag SelfOrAncestorHasDirAutoFlag, and added hooks in the DOM to set
16397 and check this flag. This flag is set on every node between an element w ith
16398 dir=auto attribute and its first text node. Changes in the DOM between t hose
16399 elements will trigger re-evaluating the directionality, but changes not
16400 between those element do not need to be concerned.
16401 The DOM hooks were added to childrenChanged, and to parseMappedAttribute .
16402 The directionality is evaluated when children are added, and cleared whe n they are
16403 removed. Directionality flag is also cleared on a child that is no longe r determining
16404 the directionality due to a sibling being added before that child.
16405
16406 Added 2 static CSSMutableStyleDeclarations to be used for elements with dir=auto.
16407 We cannot used the mapped declaration, because it can take only one valu e.
16408
16409 Tests: fast/dom/HTMLElement/attr-dir-auto-change-before-text-node.html
16410 fast/dom/HTMLElement/attr-dir-auto-change-child-node.html
16411 fast/dom/HTMLElement/attr-dir-auto-change-text.html
16412 fast/dom/HTMLElement/attr-dir-auto-children.html
16413 fast/dom/HTMLElement/attr-dir-auto-remove-add-children.html
16414 fast/dom/HTMLElement/attr-dir-auto.html
16415 fast/dom/HTMLElement/attr-dir-value-change.html
16416
16417 * css/CSSStyleSelector.cpp:
16418 (WebCore::leftToRightDeclaration):
16419 (WebCore::rightToLeftDeclaration):
16420 (WebCore::CSSStyleSelector::canShareStyleWithElement):
16421 (WebCore::CSSStyleSelector::styleForElement):
16422 * dom/Node.h:
16423 (WebCore::Node::selfOrAncestorHasDirAutoAttribute):
16424 (WebCore::Node::setSelfOrAncestorHasDirAutoAttribute):
16425 * html/HTMLElement.cpp:
16426 (WebCore::HTMLElement::mapToEntry):
16427 (WebCore::HTMLElement::parseMappedAttribute):
16428 (WebCore::setHasDirAutoFlagRecursively):
16429 (WebCore::HTMLElement::childrenChanged):
16430 (WebCore::HTMLElement::directionalityIfhasDirAutoAttribute):
16431 (WebCore::HTMLElement::directionality):
16432 (WebCore::HTMLElement::dirAttributeChanged):
16433 (WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildAttributeCh anged):
16434 (WebCore::HTMLElement::calculateAndAdjustDirectionality):
16435 (WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged) :
16436 * html/HTMLElement.h:
16437
16438 2011-02-18 Yael Aharon <yael.aharon@nokia.com>
16439
16440 Reviewed by Antonio Gomes.
16441
16442 Navigating downwards / upwards does not focus on the links spread across more than one line.
16443 https://bugs.webkit.org/show_bug.cgi?id=54639
16444
16445 When 2 anchor elements span more than one line each, and one ends on the same line that the
16446 second starts on, the rects reported by their renderers are overlapping. When handling
16447 2 overlapping nodes, check for this case, and don't assume that one of t he nodes is on a higher layer.
16448
16449 Test: fast/spatial-navigation/snav-two-elements-one-line.html
16450
16451 * page/FocusController.cpp:
16452 (WebCore::updateFocusCandidateIfNeeded):
16453 (WebCore::FocusController::findFocusCandidateInContainer):
16454 * page/SpatialNavigation.cpp:
16455 (WebCore::areElementsOnSameLine):
16456 (WebCore::distanceDataForNode):
16457 * page/SpatialNavigation.h:
16458
16459 2011-02-18 Ben Vanik <benvanik@google.com>
16460
16461 Reviewed by Kenneth Russell.
16462
16463 Bug 53940: Implement the OES_vertex_array_object WebGL extension
16464 https://bugs.webkit.org/show_bug.cgi?id=53940
16465
16466 Initial implementation of the OES_vertex_array_object extension adding t he OESVertexArrayObject
16467 extension container and WebGLVertexArrayObjectOES VAO object. The extens ion is plumbed through
16468 the Extensions3D interface and implemented in the Extensions3DOpenGL (We bKit/OSX) version when
16469 it is available.
16470 Two big changes touching code outside of the extension files:
16471 * Moved the typedefs at the top of GraphicsContext3D.h to GraphicsTypes3 D.h (modeled after
16472 GraphicsTypes.h). They are not namespaced as they weren't before.
16473 * To make the code cleaner/clearer all vertex attribute state has been m oved to the
16474 WebGLVertexArrayObjectOES type (struct VertexAttribState) except for v alues which are still
16475 on the WebGLRenderingContext. A default VAO is now used to store the e xisting attribute
16476 states for when no other VAO is used. Code in WebGLRenderingContext de aling with buffers and
16477 vertex attributes now defers to or stores values in the bound array ob ject.
16478
16479 Tested against the WebGL conformance suite and the new
16480 oes-vertex-array-object test:
16481 https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/ conformance/oes-vertex-array-object.html
16482
16483 * CMakeLists.txt:
16484 * CodeGenerators.pri:
16485 * DerivedSources.make:
16486 * GNUmakefile.am:
16487 * WebCore.gyp: Modified property svn:ignore.
16488 * WebCore.gypi:
16489 * WebCore.pro:
16490 * WebCore.xcodeproj/project.pbxproj:
16491 * bindings/js/JSWebGLRenderingContextCustom.cpp:
16492 (WebCore::toJS):
16493 * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
16494 (WebCore::toV8Object):
16495 * html/canvas/OESVertexArrayObject.cpp: Added.
16496 (WebCore::OESVertexArrayObject::OESVertexArrayObject):
16497 (WebCore::OESVertexArrayObject::~OESVertexArrayObject):
16498 (WebCore::OESVertexArrayObject::getName):
16499 (WebCore::OESVertexArrayObject::create):
16500 (WebCore::OESVertexArrayObject::createVertexArrayOES):
16501 (WebCore::OESVertexArrayObject::deleteVertexArrayOES):
16502 (WebCore::OESVertexArrayObject::isVertexArrayOES):
16503 (WebCore::OESVertexArrayObject::bindVertexArrayOES):
16504 * html/canvas/OESVertexArrayObject.h: Added.
16505 * html/canvas/OESVertexArrayObject.idl: Added.
16506 * html/canvas/WebGLExtension.h:
16507 * html/canvas/WebGLGetInfo.cpp:
16508 (WebCore::WebGLGetInfo::WebGLGetInfo):
16509 (WebCore::WebGLGetInfo::getWebGLVertexArrayObjectOES):
16510 * html/canvas/WebGLGetInfo.h:
16511 * html/canvas/WebGLRenderingContext.cpp:
16512 (WebCore::WebGLRenderingContext::initializeNewContext):
16513 (WebCore::WebGLRenderingContext::bindBuffer):
16514 (WebCore::WebGLRenderingContext::deleteBuffer):
16515 (WebCore::WebGLRenderingContext::disableVertexAttribArray):
16516 (WebCore::WebGLRenderingContext::validateElementArraySize):
16517 (WebCore::WebGLRenderingContext::validateIndexArrayConservative):
16518 (WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
16519 (WebCore::WebGLRenderingContext::validateRenderingState):
16520 (WebCore::WebGLRenderingContext::drawElements):
16521 (WebCore::WebGLRenderingContext::enableVertexAttribArray):
16522 (WebCore::WebGLRenderingContext::getExtension):
16523 (WebCore::WebGLRenderingContext::getParameter):
16524 (WebCore::WebGLRenderingContext::getSupportedExtensions):
16525 (WebCore::WebGLRenderingContext::getVertexAttrib):
16526 (WebCore::WebGLRenderingContext::vertexAttribPointer):
16527 (WebCore::WebGLRenderingContext::validateBufferDataParameters):
16528 (WebCore::WebGLRenderingContext::vertexAttribfImpl):
16529 (WebCore::WebGLRenderingContext::vertexAttribfvImpl):
16530 (WebCore::WebGLRenderingContext::initVertexAttrib0):
16531 (WebCore::WebGLRenderingContext::simulateVertexAttrib0):
16532 (WebCore::WebGLRenderingContext::restoreStatesAfterVertexAttrib0Simulati on):
16533 (WebCore::WebGLRenderingContext::getNumberOfExtensions):
16534 (WebCore::WebGLRenderingContext::getExtensionNumber):
16535 * html/canvas/WebGLRenderingContext.h:
16536 (WebCore::WebGLRenderingContext::getMaxVertexAttribs):
16537 (WebCore::WebGLRenderingContext::setBoundVertexArrayObject):
16538 (WebCore::WebGLRenderingContext::VertexAttribValue::VertexAttribValue):
16539 * html/canvas/WebGLVertexArrayObjectOES.cpp: Added.
16540 (WebCore::WebGLVertexArrayObjectOES::create):
16541 (WebCore::WebGLVertexArrayObjectOES::WebGLVertexArrayObjectOES):
16542 (WebCore::WebGLVertexArrayObjectOES::deleteObjectImpl):
16543 * html/canvas/WebGLVertexArrayObjectOES.h: Added.
16544 (WebCore::WebGLVertexArrayObjectOES::~WebGLVertexArrayObjectOES):
16545 (WebCore::WebGLVertexArrayObjectOES::VertexAttribState::VertexAttribStat e):
16546 (WebCore::WebGLVertexArrayObjectOES::isDefaultObject):
16547 (WebCore::WebGLVertexArrayObjectOES::hasEverBeenBound):
16548 (WebCore::WebGLVertexArrayObjectOES::setHasEverBeenBound):
16549 (WebCore::WebGLVertexArrayObjectOES::getElementArrayBuffer):
16550 (WebCore::WebGLVertexArrayObjectOES::setElementArrayBuffer):
16551 (WebCore::WebGLVertexArrayObjectOES::getVertexAttribState):
16552 (WebCore::WebGLVertexArrayObjectOES::isVertexArray):
16553 * html/canvas/WebGLVertexArrayObjectOES.idl: Added.
16554 * platform/graphics/Extensions3D.h:
16555 * platform/graphics/GraphicsContext3D.h:
16556 * platform/graphics/GraphicsTypes3D.h: Added.
16557 * platform/graphics/chromium/Extensions3DChromium.h:
16558 * platform/graphics/opengl/Extensions3DOpenGL.cpp:
16559 (WebCore::Extensions3DOpenGL::supports):
16560 (WebCore::Extensions3DOpenGL::createVertexArrayOES):
16561 (WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
16562 (WebCore::Extensions3DOpenGL::isVertexArrayOES):
16563 (WebCore::Extensions3DOpenGL::bindVertexArrayOES):
16564 * platform/graphics/opengl/Extensions3DOpenGL.h:
16565 * platform/graphics/qt/Extensions3DQt.cpp:
16566 (WebCore::Extensions3DQt::createVertexArrayOES):
16567 (WebCore::Extensions3DQt::deleteVertexArrayOES):
16568 (WebCore::Extensions3DQt::isVertexArrayOES):
16569 (WebCore::Extensions3DQt::bindVertexArrayOES):
16570 * platform/graphics/qt/Extensions3DQt.h:
16571
16572 2011-02-17 Alexander Pavlov <apavlov@chromium.org>
16573
16574 Reviewed by Pavel Feldman.
16575
16576 Web Inspector: reflect changes to styles when they happen outside inspec tor.
16577 https://bugs.webkit.org/show_bug.cgi?id=44620
16578
16579 Notify InspectorInstrumentation of inline style changes from CSSMutableS tyleDeclaration
16580 whenever the style change does not come from a direct "style" attribute modification.
16581 The performance regression occurs only with the Web Inspector opened, wh en inline styles
16582 are modified through setting style.cssText or style.<styleAttribute>: ac cording to the Web Inspector protocol,
16583 an attribute change requires that all attributes for the node in questio n be pushed into the frontend.
16584
16585 Test: inspector/styles/styles-update-from-js.html
16586
16587 * css/CSSMutableStyleDeclaration.cpp:
16588 (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
16589 * inspector/InspectorDOMAgent.cpp:
16590 (WebCore::RevalidateStyleAttributeTask::reset):
16591 (WebCore::RevalidateStyleAttributeTask::RevalidateStyleAttributeTask):
16592 (WebCore::RevalidateStyleAttributeTask::scheduleFor):
16593 (WebCore::RevalidateStyleAttributeTask::onTimer):
16594 (WebCore::InspectorDOMAgent::reset):
16595 (WebCore::InspectorDOMAgent::didInvalidateStyleAttr):
16596 * inspector/InspectorDOMAgent.h:
16597 * inspector/InspectorInstrumentation.cpp:
16598 (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):
16599 * inspector/InspectorInstrumentation.h:
16600 (WebCore::InspectorInstrumentation::didInvalidateStyleAttr):
16601 * inspector/InspectorStyleSheet.cpp:
16602 (WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute):
16603 (WebCore::InspectorStyleSheetForInlineStyle::ensureParsedDataReady):
16604 (WebCore::InspectorStyleSheetForInlineStyle::elementStyleText):
16605 * inspector/InspectorStyleSheet.h:
16606 * inspector/front-end/ElementsPanel.js:
16607 (WebInspector.ElementsPanel.prototype._attributesUpdated):
16608 * inspector/front-end/StylesSidebarPane.js:
16609 (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules) :
16610 (WebInspector.StylesSidebarPane.prototype.addBlankSection):
16611 (WebInspector.StylePropertiesSection.prototype.onpopulate):
16612 (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
16613 (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
16614 (WebInspector.BlankStylePropertiesSection):
16615 (WebInspector.StylePropertyTreeElement):
16616 (WebInspector.StylePropertyTreeElement.prototype):
16617 (WebInspector.StylePropertyTreeElement.prototype.element.userInput.previ ousContent.context.moveDirection):
16618
16619 2011-02-16 Tony Gentilcore <tonyg@chromium.org>
16620
16621 Reviewed by Eric Seidel.
16622
16623 Refactor pumpTokenizer loop
16624 https://bugs.webkit.org/show_bug.cgi?id=54574
16625
16626 1. This makes pumpTokenizer() safe to call when waiting for a script or when about to get
16627 the next token, although ASSERTs still enforce that we aren't waiting for a script. This
16628 enables resumeParsingAfterYield() to call pumpTokenizer with no modif ications even if we
16629 yield before running a script rather than before taking a token (see bug 54355).
16630 2. This also picks up the refCount >= 1 assert when stopped.
16631
16632 Tested PerformanceTests/Parser to verify no regression. If anything it g ot faster.
16633 Before:
16634 avg 985.05
16635 median 985.5
16636 stdev 3.007906248539007
16637 min 980
16638 max 990
16639 After:
16640 avg 980.05
16641 median 981
16642 stdev 3.122098653149833
16643 min 974
16644 max 985
16645
16646 No new tests because no new functionality.
16647
16648 * html/parser/HTMLDocumentParser.cpp:
16649 (WebCore::HTMLDocumentParser::canTakeNextToken): Added.
16650 (WebCore::HTMLDocumentParser::pumpTokenizer):
16651 * html/parser/HTMLDocumentParser.h:
16652
16653 2011-02-18 Sheriff Bot <webkit.review.bot@gmail.com>
16654
16655 Unreviewed, rolling out r79003.
16656 http://trac.webkit.org/changeset/79003
16657 https://bugs.webkit.org/show_bug.cgi?id=54753
16658
16659 It broke tests on GTK bots (Requested by Ossy on #webkit).
16660
16661 * accessibility/AccessibilityRenderObject.cpp:
16662 (WebCore::lastChildConsideringContinuation):
16663 * dom/Node.cpp:
16664 (WebCore::Node::removeEventListener):
16665 * html/DateComponents.cpp:
16666 (WebCore::DateComponents::parseTime):
16667
16668 2011-02-18 Csaba Osztrogonác <ossy@webkit.org>
16669
16670 Rubber-stamped by Andreas Kling.
16671
16672 Warning fix. Use ASSERT_UNUSED() instead of ASSERT().
16673
16674 * accessibility/AccessibilityRenderObject.cpp:
16675 (WebCore::lastChildConsideringContinuation):
16676 * dom/Node.cpp:
16677 (WebCore::Node::removeEventListener):
16678 * html/DateComponents.cpp:
16679 (WebCore::DateComponents::parseTime):
16680
16681 2011-02-18 Andrey Adaikin <aandrey@google.com>
16682
16683 Reviewed by Pavel Feldman.
16684
16685 Web Inspector: [Text editor] Optimize editing updates in main panel
16686 https://bugs.webkit.org/show_bug.cgi?id=54661
16687
16688 * inspector/front-end/TextViewer.js:
16689 (WebInspector.TextViewer):
16690 (WebInspector.TextViewer.prototype._textChanged):
16691 (WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
16692 (WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
16693 (WebInspector.TextViewer.prototype._syncDecorationsForLine):
16694 (WebInspector.TextEditorChunkedPanel.prototype.textChanged):
16695 (WebInspector.TextEditorChunkedPanel.prototype._scroll):
16696 (WebInspector.TextEditorChunkedPanel.prototype.chunkForLine):
16697 (WebInspector.TextEditorChunkedPanel.prototype._totalHeight):
16698 (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
16699 (WebInspector.TextEditorGutterChunk):
16700 (WebInspector.TextEditorGutterChunk.prototype.addDecoration):
16701 (WebInspector.TextEditorGutterChunk.prototype.removeDecoration):
16702 (WebInspector.TextEditorMainPanel):
16703 (WebInspector.TextEditorMainPanel.prototype._expandChunks):
16704 (WebInspector.TextEditorMainPanel.prototype._highlightDataReady):
16705 (WebInspector.TextEditorMainPanel.prototype._markSkippedPaintLines):
16706 (WebInspector.TextEditorMainPanel.prototype._paintSkippedLines):
16707 (WebInspector.TextEditorMainPanel.prototype._paintLines):
16708 (WebInspector.TextEditorMainPanel.prototype._paintLine):
16709 (WebInspector.TextEditorMainPanel.prototype._positionToSelection):
16710 (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
16711 (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
16712 (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
16713 (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
16714 (WebInspector.TextEditorMainChunk):
16715 (WebInspector.TextEditorMainChunk.prototype.get startLine):
16716 (WebInspector.TextEditorMainChunk.prototype.set startLine):
16717 (WebInspector.TextEditorMainChunk.prototype.getExpandedLineRow):
16718 (WebInspector.TextEditorMainChunk.prototype.updateCollapsedLineRow):
16719
16720 2011-02-18 Steve Block <steveblock@google.com>
16721
16722 Reviewed by Andreas Kling
16723
16724 Memory allocation error in convertV8ObjectToNPVariant() for strings
16725 https://bugs.webkit.org/show_bug.cgi?id=54737
16726
16727 Include the termination character in the length when allocating memory
16728 and copying the string. This fixes a crashing bug on Android.
16729
16730 This should be tested by the java/ tests on Chromium, but these
16731 tests are currently skipped.
16732
16733 * bindings/v8/V8NPUtils.cpp:
16734 (WebCore::convertV8ObjectToNPVariant):
16735
16736 2011-02-18 Philippe Normand <pnormand@igalia.com>
16737
16738 Unreviewed, rolling out r78979.
16739 http://trac.webkit.org/changeset/78979
16740 https://bugs.webkit.org/show_bug.cgi?id=53146
16741
16742 causes multiple crashes on GTK
16743
16744 * accessibility/gtk/AXObjectCacheAtk.cpp:
16745 (WebCore::notifyChildrenSelectionChange):
16746 (WebCore::AXObjectCache::postPlatformNotification):
16747
16748 2011-02-18 Philippe Normand <pnormand@igalia.com>
16749
16750 Reviewed by Martin Robinson.
16751
16752 [GTK] minimal build unrecognized options
16753 https://bugs.webkit.org/show_bug.cgi?id=50890
16754
16755 * GNUmakefile.am: new feature defines for optional features build.
16756
16757 2011-02-17 Hans Wennborg <hans@chromium.org>
16758
16759 Reviewed by Jeremy Orlow.
16760
16761 IndexedDB: Populate indexes created for object stores with data
16762 https://bugs.webkit.org/show_bug.cgi?id=54669
16763
16764 Make sure that indices for object stores that already hold data get
16765 populated.
16766
16767 * storage/IDBIndexBackendImpl.h:
16768 (WebCore::IDBIndexBackendImpl::hasValidId):
16769 * storage/IDBObjectStoreBackendImpl.cpp:
16770 (WebCore::IDBObjectStoreBackendImpl::putInternal):
16771 (WebCore::populateIndex):
16772 (WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
16773
16774 2011-02-18 Mario Sanchez Prada <msanchez@igalia.com>
16775
16776 Reviewed by Martin Robinson.
16777
16778 [GTK] Combo boxes should emit object:selection-changed even when collaps ed
16779 https://bugs.webkit.org/show_bug.cgi?id=53146
16780
16781 Emit the selection-changed signals when the menu list value has changed
16782
16783 Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.h tml
16784
16785 * accessibility/gtk/AXObjectCacheAtk.cpp:
16786 (WebCore::getListObject): New, return the right list object for
16787 menu lists and list boxes.
16788 (WebCore::notifyChildrenSelectionChange): Support menu lists.
16789 (WebCore::AXObjectCache::postPlatformNotification): Call function
16790 notifyChildrenSelectionChange for AXMenuListValueChanged.
16791
16792 2011-02-18 Mario Sanchez Prada <msanchez@igalia.com>
16793
16794 Reviewed by Martin Robinson.
16795
16796 [Gtk] atk_text_get_selection/atk_text_set_selection fails for list items
16797 https://bugs.webkit.org/show_bug.cgi?id=53453
16798
16799 Ensure that atk_text_{get|set}_selection() work with list items.
16800
16801 * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
16802 (webkit_accessible_text_get_text): Properly handle list item
16803 markers when returning the text for an object for a given interval
16804 specified through the startOffset and endOffset parameters.
16805 (getSelectionOffsetsForObject): Bear in mind list item markers
16806 when returning the offsets for a selection over a list item.
16807 (webkit_accessible_text_set_selection): Adjust offsets if needed
16808 for list items with item markers. Ensure that it returns TRUE only
16809 when everything went fine setting the text selection.
16810
16811 2011-02-18 Antti Koivisto <antti@apple.com>
16812
16813 Reviewed by Maciej Stachowiak.
16814
16815 https://bugs.webkit.org/show_bug.cgi?id=54728
16816 checkSelector*Value functions used in fastCheckSelector fail to inline
16817
16818 Wrap the functions used as template arguments to classes.
16819
16820 * css/CSSStyleSelector.cpp:
16821 (WebCore::fastCheckSingleSelector):
16822 (WebCore::ClassCheck::checkValue):
16823 (WebCore::IdCheck::checkValue):
16824 (WebCore::TagCheck::checkValue):
16825 (WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector):
16826
16827 2011-02-17 Simon Fraser <simon.fraser@apple.com>
16828
16829 Reviewed by Sam Weinig.
16830
16831 Composited iframe content is missing from snapshots in WebKit2
16832 https://bugs.webkit.org/show_bug.cgi?id=54696
16833
16834 We need to propagate the 'flattening' paint behavior flag
16835 down to subviews while painting. WebKit1 does this via
16836 code in WebFrameView, but this is a more general fix
16837 that works in WebKit2 as well.
16838
16839 Made a utility method, parentFrameView(), which I changed
16840 some other methods to use as well.
16841
16842 * page/FrameView.cpp:
16843 (WebCore::FrameView::isEnclosedInCompositingLayer):
16844 (WebCore::FrameView::useSlowRepaints):
16845 (WebCore::FrameView::useSlowRepaintsIfNotOverlapped):
16846 (WebCore::FrameView::isOverlappedIncludingAncestors):
16847 (WebCore::FrameView::parentFrameView):
16848 (WebCore::FrameView::paintContents):
16849 * page/FrameView.h:
16850
16851 2011-02-17 Dan Bernstein <mitz@apple.com>
16852
16853 Reviewed by Simon Fraser.
16854
16855 <rdar://problem/8898595> Pages that use fixed positioning display poorly when scaled
16856
16857 * html/HTMLBodyElement.cpp:
16858 (WebCore::adjustForZoom): Account for page scale.
16859 (WebCore::HTMLBodyElement::setScrollLeft): Ditto.
16860 (WebCore::HTMLBodyElement::setScrollTop): Ditto.
16861 * page/FrameView.cpp:
16862 (WebCore::FrameView::scrollXForFixedPosition): Moved from ScrollView her e and changed to
16863 account for page scale: when the page is scaled, the “viewport” with res pect to which fixed
16864 objects are positioned is scaled as well. Since it’s now bigger than the real viewport (that is,
16865 the frame view), we move it around in proportion to the document scroll, so that when the document
16866 is fully scrolled to the bottom-right, the bottom right of the scaled vi ewport is visible.
16867 (WebCore::FrameView::scrollYForFixedPosition): Ditto.
16868 (WebCore::FrameView::scrollOffsetForFixedPosition): Moved from ScrollVie w here.
16869 * page/FrameView.h:
16870 * platform/ScrollView.cpp: Moved functions to FrameView.
16871 * platform/ScrollView.h:
16872 * rendering/RenderLayer.cpp:
16873 (WebCore::RenderLayer::updateRepaintRectsAfterScroll): Account for the R enderView being transformed.
16874 (WebCore::RenderLayer::calculateClipRects): Used scrollOffsetForFixedPos ition().
16875 (WebCore::RenderLayer::backgroundClipRect): Ditto.
16876
16877 2011-02-17 Kenneth Russell <kbr@google.com>
16878
16879 Reviewed by James Robinson.
16880
16881 Add support for GPU accelerated path rendering
16882 https://bugs.webkit.org/show_bug.cgi?id=44729
16883
16884 Incorporates the Loop and Blinn path rendering algorithm as an
16885 option to the GPU-accelerated canvas code, currently only compiled
16886 in to the Chromium port. Currently it's toggled by changing a
16887 hardcoded constant in
16888 SharedGraphicsContext3D::useLoopBlinnForPathRendering() and is
16889 disabled by default. This mechanism can be improved once we've
16890 gained more confidence in the implementation. There are some known
16891 bugs that need to be fixed first.
16892
16893 No new tests; ran some 2D Canvas tests manually with the new flag
16894 both enabled and disabled.
16895
16896 * WebCore.gypi:
16897 * platform/graphics/chromium/GLES2Canvas.cpp:
16898 (WebCore::GLES2Canvas::GLES2Canvas):
16899 (WebCore::GLES2Canvas::fillPath):
16900 * platform/graphics/chromium/GLES2Canvas.h:
16901 * platform/graphics/gpu/LoopBlinnClassifier.h:
16902 * platform/graphics/gpu/LoopBlinnLocalTriangulator.h:
16903 * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
16904 (WebCore::SharedGraphicsContext3D::create):
16905 (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
16906 (WebCore::SharedGraphicsContext3D::createBuffer):
16907 (WebCore::SharedGraphicsContext3D::bindBuffer):
16908 (WebCore::SharedGraphicsContext3D::bufferData):
16909 (WebCore::SharedGraphicsContext3D::bufferSubData):
16910 (WebCore::SharedGraphicsContext3D::useLoopBlinnForPathRendering):
16911 (WebCore::SharedGraphicsContext3D::useLoopBlinnInteriorProgram):
16912 (WebCore::SharedGraphicsContext3D::useLoopBlinnExteriorProgram):
16913 * platform/graphics/gpu/SharedGraphicsContext3D.h:
16914 * platform/graphics/skia/GraphicsContextSkia.cpp:
16915 (WebCore::GraphicsContext::fillPath):
16916
16917 2011-02-16 Stephen White <senorblanco@chromium.org>
16918
16919 Reviewed by James Robinson.
16920
16921 Layout Test fast/canvas/setWidthResetAfterForcedRender.html fails on
16922 accelerated 2D canvas w/compositor enabled.
16923 https://bugs.webkit.org/show_bug.cgi?id=54561
16924
16925 When resetting the CanvasRenderingContext2D, we also need to send a
16926 contentChanged() to the relevant RenderLayer. This is similar to what
16927 is done in didDraw().
16928
16929 Covered by fast/canvas/setWidthResetAfterForcedRender.html, but note
16930 that this test will still fail pixel tests because the compositor
16931 is not compatible with repaint tests (the green square is now white,
16932 but the half-transparent grey repaint rect does not appear).
16933
16934 * html/canvas/CanvasRenderingContext2D.cpp:
16935 (WebCore::CanvasRenderingContext2D::reset):
16936
16937 2011-02-17 Sergey Glazunov <serg.glazunov@gmail.com>
16938
16939 Reviewed by Kenneth Russell.
16940
16941 Null out the WEBKIT_lose_context WebGL extension's context pointer when
16942 the WebGL rendering context is removed.
16943 https://bugs.webkit.org/show_bug.cgi?id=54679
16944
16945 Test: fast/canvas/webgl/context-destroyed-crash.html
16946
16947 * html/canvas/WebGLRenderingContext.cpp:
16948 (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
16949 * html/canvas/WebKitLoseContext.cpp:
16950 (WebCore::WebKitLoseContext::loseContext): Add null-check for m_context.
16951 * html/canvas/WebKitLoseContext.h:
16952 (WebCore::WebKitLoseContext::contextDestroyed):
16953
16954 2011-02-17 Kenneth Russell <kbr@google.com>
16955
16956 Reviewed by Chris Marrin.
16957
16958 Construction of Uint8Array from JS Array (and possibly others) incorrect ly clamps values
16959 https://bugs.webkit.org/show_bug.cgi?id=52768
16960
16961 Removed incorrect clamping code from IntegralTypedArrayBase. Fixed
16962 code which casts from incoming double to the destination type.
16963 Changed the JSC bindings to use this code, rather than a copy of
16964 the casting code and a different constructor, in order to reuse
16965 the fix.
16966
16967 * bindings/js/JSArrayBufferViewHelper.h:
16968 (WebCore::constructArrayBufferView):
16969 * html/canvas/Int32Array.h:
16970 (WebCore::Int32Array::set):
16971 * html/canvas/Int8Array.h:
16972 (WebCore::Int8Array::set):
16973 * html/canvas/IntegralTypedArrayBase.h:
16974 (WebCore::IntegralTypedArrayBase::set):
16975 * html/canvas/Uint16Array.h:
16976 (WebCore::Uint16Array::set):
16977 * html/canvas/Uint32Array.h:
16978 (WebCore::Uint32Array::set):
16979 * html/canvas/Uint8Array.h:
16980 (WebCore::Uint8Array::set):
16981
16982 2011-02-17 Sam Weinig <sam@webkit.org>
16983
16984 Reviewed by Dan Bernstein.
16985
16986 Knob proportion not quite right during rubber-band.
16987 <rdar://problem/9015201>
16988
16989 Change knob proportion algorithm to treat overhang as making the view sm aller,
16990 rather than document bigger.
16991
16992 * platform/mac/ScrollbarThemeMac.mm:
16993 (WebCore::ScrollbarThemeMac::paint):
16994
16995 2011-02-16 Luiz Agostini <luiz.agostini@openbossa.org>
16996
16997 Reviewed by Andreas Kling.
16998
16999 Summary: HTML5 <details> and <summary>: HTMLSummaryElement
17000 https://bugs.webkit.org/show_bug.cgi?id=54584
17001
17002 Adding class HTMLSummaryElement to build systems. This class will be use d in
17003 the implementation of new HTML5 tag <summary>.
17004
17005 * CMakeLists.txt:
17006 * GNUmakefile.am:
17007 * WebCore.gypi:
17008 * WebCore.pro:
17009 * WebCore.vcproj/WebCore.vcproj:
17010 * WebCore.xcodeproj/project.pbxproj:
17011 * html/HTMLElementsAllInOne.cpp:
17012 * html/HTMLSummaryElement.cpp: Added.
17013 (WebCore::HTMLSummaryElement::create):
17014 (WebCore::HTMLSummaryElement::HTMLSummaryElement):
17015 * html/HTMLSummaryElement.h: Added.
17016 * html/HTMLTagNames.in:
17017
17018 2011-02-17 Jeremy Orlow <jorlow@chromium.org>
17019
17020 Reviewed by Nate Chapin.
17021
17022 Throwing in an IndexedDB error or success event should lead to the trans action aborting
17023 https://bugs.webkit.org/show_bug.cgi?id=54249
17024
17025 When an exception is thrown but not handled within an IDBRequests succe ss/error event,
17026 we should abort the transaction.
17027
17028 Test: storage/indexeddb/exception-in-event-aborts.html
17029
17030 * bindings/js/JSEventListener.cpp:
17031 (WebCore::JSEventListener::handleEvent):
17032 * bindings/js/JSEventTarget.cpp:
17033 (WebCore::toJS):
17034 * bindings/v8/V8AbstractEventListener.cpp:
17035 (WebCore::V8AbstractEventListener::invokeEventHandler):
17036 * dom/EventTarget.cpp:
17037 (WebCore::EventTarget::uncaughtExceptionInEventHandler):
17038 * dom/EventTarget.h:
17039 * storage/IDBRequest.cpp:
17040 (WebCore::IDBRequest::uncaughtExceptionInEventHandler):
17041 * storage/IDBRequest.h:
17042
17043 2011-02-17 Sam Weinig <sam@webkit.org>
17044
17045 Reviewed by Maciej Stachowiak.
17046
17047 WebKit2: Support Dictionary popup
17048 <rdar://problem/7660670>
17049
17050 Add some necessary exports.
17051
17052 * WebCore.exp.in:
17053
17054 2011-02-17 W. James MacLean <wjmaclean@chromium.org>
17055
17056 Reviewed by James Robinson.
17057
17058 [chromium] Add command-line flag to enable composite to offscreen textur e.
17059 https://bugs.webkit.org/show_bug.cgi?id=52311
17060
17061 Add plumbing to allow command-line switch to enable offscreen compositin g. Function
17062 LayerRendererChromium::copyOffscreenTextureToDisplay used for now to mim ic
17063 normal renderer operation.
17064
17065 Existing functionality not changed; offscreen compositing will be tested via GPU test framework.
17066
17067 * platform/graphics/chromium/LayerRendererChromium.cpp:
17068 (WebCore::LayerRendererChromium::setRootLayer):
17069 (WebCore::LayerRendererChromium::setCompositeOffscreen):
17070 (WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
17071 (WebCore::LayerRendererChromium::useRenderSurface):
17072 (WebCore::LayerRendererChromium::setScissorToRect):
17073 * platform/graphics/chromium/LayerRendererChromium.h:
17074 (WebCore::LayerRendererChromium::isCompositingOffscreen):
17075
17076 2011-02-17 Kevin Ollivier <kevino@theolliviers.com>
17077
17078 [wx] Build fixes after recent changes.
17079
17080 * dom/ScriptedAnimationController.h:
17081 * platform/graphics/wx/FontWx.cpp:
17082 (WebCore::Font::drawComplexText):
17083 * platform/graphics/wx/GraphicsContextWx.cpp:
17084 (WebCore::GraphicsContext::drawLineForText):
17085 (WebCore::GraphicsContext::drawLineForTextChecking):
17086 * platform/wx/WidgetWx.cpp:
17087 (WebCore::Widget::setFrameRect):
17088
17089 2011-02-16 Brian Weinstein <bweinstein@apple.com>
17090
17091 Reviewed by Brady Eidson.
17092
17093 WebKit2: Need a way to manage the WebCore Cache
17094 https://bugs.webkit.org/show_bug.cgi?id=54501
17095
17096 Add a way to get a set of all of the origins that have entries in the
17097 WebCore memory cache, and a method to remove all resources from the memo ry
17098 cache from a given security origin.
17099
17100 No change in behavior.
17101
17102 * WebCore.exp.in: Add functions that need to be exported.
17103 * loader/cache/MemoryCache.cpp:
17104 (WebCore::MemoryCache::removeResourcesWithOrigin):
17105 (WebCore::MemoryCache::getOriginsWithCache):
17106 * loader/cache/MemoryCache.h:
17107
17108 2011-02-16 David Hyatt <hyatt@apple.com>
17109
17110 Reviewed by Dan Bernstein.
17111
17112 https://bugs.webkit.org/show_bug.cgi?id=54244
17113
17114 Convert the line box tree to floating point and eliminate font rounding hacks. This patch removes all of the rounding
17115 hacks from the Font code and makes sure all Font APIs involving width me asurement and width offsets use floats.
17116
17117 The line box tree's x, y and logicalWidth members have all been converte d to floats and all of the line box APIs have
17118 been changed as well.
17119
17120 In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
17121
17122 Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
17123
17124 Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
17125 still have a precise floating point position.
17126
17127 Justification will now allow subpixel positioning to occur as well. Pla tforms that don't support subpixel positioning should already
17128 be rounding justification spacing in their font code.
17129
17130 Many layout test results change on Mac, since rounding hacks were used t here and are now gone.
17131
17132 * WebCore.exp.in:
17133 * html/canvas/CanvasRenderingContext2D.cpp:
17134 (WebCore::CanvasRenderingContext2D::drawTextInternal):
17135 * platform/chromium/FileChooserChromium.cpp:
17136 (WebCore::FileChooser::basenameForWidth):
17137 * platform/graphics/Font.cpp:
17138 (WebCore::Font::width):
17139 * platform/graphics/Font.h:
17140 (WebCore::Font::spaceWidth):
17141 (WebCore::Font::tabWidth):
17142 * platform/graphics/FontFastPath.cpp:
17143 (WebCore::Font::getGlyphsAndAdvancesForSimpleText):
17144 * platform/graphics/GraphicsContext.cpp:
17145 (WebCore::GraphicsContext::drawText):
17146 (WebCore::GraphicsContext::drawEmphasisMarks):
17147 (WebCore::GraphicsContext::drawBidiText):
17148 (WebCore::GraphicsContext::drawHighlightForText):
17149 * platform/graphics/GraphicsContext.h:
17150 * platform/graphics/SimpleFontData.cpp:
17151 (WebCore::SimpleFontData::SimpleFontData):
17152 (WebCore::SimpleFontData::platformGlyphInit):
17153 * platform/graphics/SimpleFontData.h:
17154 (WebCore::SimpleFontData::spaceWidth):
17155 * platform/graphics/StringTruncator.cpp:
17156 (WebCore::stringWidth):
17157 (WebCore::truncateString):
17158 (WebCore::StringTruncator::centerTruncate):
17159 (WebCore::StringTruncator::rightTruncate):
17160 (WebCore::StringTruncator::width):
17161 * platform/graphics/StringTruncator.h:
17162 * platform/graphics/TextRun.h:
17163 (WebCore::TextRun::TextRun):
17164 (WebCore::TextRun::xPos):
17165 (WebCore::TextRun::expansion):
17166 (WebCore::TextRun::directionalOverride):
17167 (WebCore::TextRun::disableSpacing):
17168 * platform/graphics/WidthIterator.cpp:
17169 (WebCore::WidthIterator::WidthIterator):
17170 (WebCore::WidthIterator::advance):
17171 * platform/graphics/WidthIterator.h:
17172 * platform/graphics/cairo/GraphicsContextCairo.cpp:
17173 (WebCore::GraphicsContext::drawLineForText):
17174 (WebCore::GraphicsContext::drawLineForTextChecking):
17175 * platform/graphics/cg/GraphicsContextCG.cpp:
17176 (WebCore::GraphicsContext::drawLineForText):
17177 * platform/graphics/mac/ComplexTextController.cpp:
17178 (WebCore::ComplexTextController::ComplexTextController):
17179 (WebCore::ComplexTextController::advance):
17180 (WebCore::ComplexTextController::adjustGlyphsAndAdvances):
17181 * platform/graphics/mac/ComplexTextController.h:
17182 * platform/graphics/mac/FontComplexTextMac.cpp:
17183 (WebCore::Font::getGlyphsAndAdvancesForComplexText):
17184 * platform/graphics/mac/GraphicsContextMac.mm:
17185 (WebCore::GraphicsContext::drawLineForTextChecking):
17186 * platform/graphics/qt/GraphicsContextQt.cpp:
17187 (WebCore::GraphicsContext::drawLineForText):
17188 (WebCore::GraphicsContext::drawLineForTextChecking):
17189 * platform/graphics/qt/SimpleFontDataQt.cpp:
17190 (WebCore::SimpleFontData::platformGlyphInit):
17191 * platform/graphics/skia/GraphicsContextSkia.cpp:
17192 (WebCore::GraphicsContext::drawLineForTextChecking):
17193 (WebCore::GraphicsContext::drawLineForText):
17194 * platform/graphics/win/GraphicsContextCGWin.cpp:
17195 (WebCore::GraphicsContext::drawLineForTextChecking):
17196 * platform/graphics/win/UniscribeController.cpp:
17197 (WebCore::UniscribeController::shapeAndPlaceItem):
17198 * platform/gtk/FileChooserGtk.cpp:
17199 (WebCore::FileChooser::basenameForWidth):
17200 * platform/mac/DragImageMac.mm:
17201 (WebCore::widthWithFont):
17202 (WebCore::drawAtPoint):
17203 * platform/mac/FileChooserMac.mm:
17204 (WebCore::FileChooser::basenameForWidth):
17205 * platform/win/DragImageWin.cpp:
17206 (WebCore::createDragImageForLink):
17207 * platform/win/FileChooserWin.cpp:
17208 (WebCore::FileChooser::basenameForWidth):
17209 * platform/win/PopupMenuWin.cpp:
17210 (WebCore::PopupMenuWin::calculatePositionAndSize):
17211 * platform/win/WebCoreTextRenderer.cpp:
17212 (WebCore::WebCoreTextFloatWidth):
17213 * rendering/HitTestResult.cpp:
17214 (WebCore::HitTestResult::addNodeToRectBasedTestResult):
17215 * rendering/HitTestResult.h:
17216 * rendering/InlineBox.cpp:
17217 (WebCore::InlineBox::adjustPosition):
17218 (WebCore::InlineBox::placeEllipsisBox):
17219 (WebCore::InlineBox::locationIncludingFlipping):
17220 (WebCore::InlineBox::flipForWritingMode):
17221 * rendering/InlineBox.h:
17222 (WebCore::InlineBox::InlineBox):
17223 (WebCore::InlineBox::adjustLineDirectionPosition):
17224 (WebCore::InlineBox::adjustBlockDirectionPosition):
17225 (WebCore::InlineBox::setX):
17226 (WebCore::InlineBox::x):
17227 (WebCore::InlineBox::setY):
17228 (WebCore::InlineBox::y):
17229 (WebCore::InlineBox::width):
17230 (WebCore::InlineBox::height):
17231 (WebCore::InlineBox::logicalLeft):
17232 (WebCore::InlineBox::logicalRight):
17233 (WebCore::InlineBox::setLogicalLeft):
17234 (WebCore::InlineBox::pixelSnappedLogicalLeft):
17235 (WebCore::InlineBox::pixelSnappedLogicalRight):
17236 (WebCore::InlineBox::setLogicalWidth):
17237 (WebCore::InlineBox::logicalWidth):
17238 (WebCore::InlineBox::verticalAlign):
17239 * rendering/InlineFlowBox.cpp:
17240 (WebCore::InlineFlowBox::roundedFrameRect):
17241 (WebCore::InlineFlowBox::adjustPosition):
17242 (WebCore::InlineFlowBox::placeBoxesInInlineDirection):
17243 (WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
17244 (WebCore::verticalPositionForBox):
17245 (WebCore::InlineFlowBox::computeLogicalBoxHeights):
17246 (WebCore::InlineFlowBox::placeBoxesInBlockDirection):
17247 (WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
17248 (WebCore::InlineFlowBox::addTextBoxVisualOverflow):
17249 (WebCore::InlineFlowBox::computeOverflow):
17250 (WebCore::InlineFlowBox::setLayoutOverflow):
17251 (WebCore::InlineFlowBox::setVisualOverflow):
17252 (WebCore::InlineFlowBox::nodeAtPoint):
17253 (WebCore::InlineFlowBox::paintBoxDecorations):
17254 (WebCore::InlineFlowBox::paintMask):
17255 (WebCore::InlineFlowBox::placeEllipsisBox):
17256 * rendering/InlineFlowBox.h:
17257 (WebCore::InlineFlowBox::maxYLayoutOverflow):
17258 (WebCore::InlineFlowBox::maxXLayoutOverflow):
17259 (WebCore::InlineFlowBox::layoutOverflowRect):
17260 (WebCore::InlineFlowBox::maxYVisualOverflow):
17261 (WebCore::InlineFlowBox::maxXVisualOverflow):
17262 (WebCore::InlineFlowBox::visualOverflowRect):
17263 * rendering/InlineTextBox.cpp:
17264 (WebCore::InlineTextBox::placeEllipsisBox):
17265 (WebCore::InlineTextBox::nodeAtPoint):
17266 (WebCore::paintTextWithShadows):
17267 (WebCore::InlineTextBox::paint):
17268 (WebCore::InlineTextBox::paintSelection):
17269 (WebCore::InlineTextBox::paintCompositionBackground):
17270 (WebCore::InlineTextBox::paintDecoration):
17271 (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
17272 (WebCore::InlineTextBox::paintTextMatchMarker):
17273 (WebCore::InlineTextBox::paintDocumentMarkers):
17274 (WebCore::InlineTextBox::paintCompositionUnderline):
17275 (WebCore::InlineTextBox::textPos):
17276 (WebCore::InlineTextBox::offsetForPosition):
17277 (WebCore::InlineTextBox::positionForOffset):
17278 * rendering/InlineTextBox.h:
17279 (WebCore::InlineTextBox::setExpansion):
17280 * rendering/RenderBR.h:
17281 (WebCore::RenderBR::width):
17282 * rendering/RenderBlock.cpp:
17283 (WebCore::stripTrailingSpace):
17284 (WebCore::updatePreferredWidth):
17285 (WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
17286 (WebCore::RenderBlock::adjustForBorderFit):
17287 (WebCore::RenderBlock::addFocusRingRects):
17288 * rendering/RenderBlock.h:
17289 * rendering/RenderBlockLineLayout.cpp:
17290 (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
17291 (WebCore::RenderBlock::fitBelowFloats):
17292 (WebCore::textWidth):
17293 (WebCore::tryHyphenating):
17294 (WebCore::RenderBlock::findNextLineBreak):
17295 * rendering/RenderBox.cpp:
17296 (WebCore::RenderBox::positionLineBox):
17297 (WebCore::RenderBox::flipForWritingMode):
17298 * rendering/RenderBox.h:
17299 * rendering/RenderCombineText.cpp:
17300 (WebCore::RenderCombineText::width):
17301 (WebCore::RenderCombineText::adjustTextOrigin):
17302 (WebCore::RenderCombineText::combineText):
17303 * rendering/RenderCombineText.h:
17304 (WebCore::RenderCombineText::combinedTextWidth):
17305 * rendering/RenderCounter.cpp:
17306 (WebCore::RenderCounter::computePreferredLogicalWidths):
17307 * rendering/RenderCounter.h:
17308 * rendering/RenderEmbeddedObject.cpp:
17309 (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
17310 * rendering/RenderFileUploadControl.cpp:
17311 (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
17312 * rendering/RenderImage.cpp:
17313 * rendering/RenderInline.cpp:
17314 (WebCore::RenderInline::linesBoundingBox):
17315 (WebCore::RenderInline::linesVisualOverflowBoundingBox):
17316 (WebCore::RenderInline::addFocusRingRects):
17317 (WebCore::RenderInline::paintOutline):
17318 * rendering/RenderListBox.cpp:
17319 (WebCore::RenderListBox::updateFromElement):
17320 (WebCore::RenderListBox::paintItemForeground):
17321 * rendering/RenderMenuList.cpp:
17322 (WebCore::RenderMenuList::updateOptionsWidth):
17323 * rendering/RenderText.cpp:
17324 (WebCore::RenderText::localCaretRect):
17325 (WebCore::RenderText::widthFromCache):
17326 (WebCore::RenderText::trimmedPrefWidths):
17327 (WebCore::RenderText::minLogicalWidth):
17328 (WebCore::RenderText::maxLogicalWidth):
17329 (WebCore::RenderText::computePreferredLogicalWidths):
17330 (WebCore::RenderText::firstRunOrigin):
17331 (WebCore::RenderText::firstRunX):
17332 (WebCore::RenderText::firstRunY):
17333 (WebCore::RenderText::width):
17334 (WebCore::RenderText::linesBoundingBox):
17335 * rendering/RenderText.h:
17336 * rendering/RenderTextControl.cpp:
17337 (WebCore::RenderTextControl::getAvgCharWidth):
17338 (WebCore::RenderTextControl::paintPlaceholder):
17339 * rendering/RenderTreeAsText.cpp:
17340 (WebCore::writeTextRun):
17341 * rendering/RootInlineBox.cpp:
17342 (WebCore::RootInlineBox::placeEllipsis):
17343 (WebCore::RootInlineBox::placeEllipsisBox):
17344 (WebCore::RootInlineBox::adjustPosition):
17345 (WebCore::RootInlineBox::beforeAnnotationsAdjustment):
17346 (WebCore::RootInlineBox::paddedLayoutOverflowRect):
17347 * rendering/RootInlineBox.h:
17348 * rendering/VerticalPositionCache.h:
17349 * rendering/svg/SVGInlineTextBox.cpp:
17350 (WebCore::SVGInlineTextBox::offsetForPosition):
17351 (WebCore::SVGInlineTextBox::positionForOffset):
17352 (WebCore::SVGInlineTextBox::constructTextRun):
17353 * rendering/svg/SVGInlineTextBox.h:
17354 * rendering/svg/SVGRenderTreeAsText.cpp:
17355 (WebCore::writeRenderSVGTextBox):
17356 * rendering/svg/SVGTextMetrics.cpp:
17357 (WebCore::SVGTextMetrics::SVGTextMetrics):
17358 (WebCore::constructTextRun):
17359 * svg/SVGFont.cpp:
17360 (WebCore::floatWidthMissingGlyphCallback):
17361 (WebCore::Font::drawTextUsingSVGFont):
17362
17363 2011-02-17 Nikolas Zimmermann <nzimmermann@rim.com>
17364
17365 Reviewed by Dirk Schulze.
17366
17367 'ex' coordinates fail, when SVGFont doesn't provide an explicit xHeight attribute
17368 https://bugs.webkit.org/show_bug.cgi?id=54672
17369
17370 Measure the xHeight from the 'x' glyph of a SVGFont, if the font itself doesn't explicitely specify an x-height attribute.
17371 Fixes the modern version of SVG 1.1 2nd Edition coords-units-03-b.svg.
17372
17373 Test: svg/W3C-SVG-1.1-SE/coords-units-03-b.svg
17374
17375 * platform/graphics/SimpleFontData.cpp:
17376 (WebCore::SimpleFontData::SimpleFontData):
17377
17378 2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
17379
17380 Reviewed by Adam Roben.
17381
17382 HTML5 <details> and <summary>: localized text
17383 https://bugs.webkit.org/show_bug.cgi?id=54260
17384
17385 The method defaultDetailsSummaryText was added to LocalizationStrategy c lass and to
17386 platform/LocalizedStrings. It is used to provide the default label to be used by a
17387 <details> tag that has no <summary> child.
17388
17389 * platform/LocalizationStrategy.h:
17390 * platform/LocalizedStrings.cpp:
17391 (WebCore::fileButtonNoFileSelectedLabel):
17392 (WebCore::defaultDetailsSummaryText):
17393 * platform/LocalizedStrings.h:
17394 * platform/android/LocalizedStringsAndroid.cpp:
17395 (WebCore::defaultDetailsSummaryText):
17396 * platform/brew/LocalizedStringsBrew.cpp:
17397 (WebCore::defaultDetailsSummaryText):
17398 * platform/efl/LocalizedStringsEfl.cpp:
17399 (WebCore::defaultDetailsSummaryText):
17400 * platform/gtk/LocalizedStringsGtk.cpp:
17401 (WebCore::defaultDetailsSummaryText):
17402 * platform/haiku/LocalizedStringsHaiku.cpp:
17403 (WebCore::defaultDetailsSummaryText):
17404 * platform/wx/LocalizedStringsWx.cpp:
17405 (WebCore::defaultDetailsSummaryText):
17406
17407 2011-02-17 Kristian Amlie <kristian.amlie@nokia.com>
17408
17409 Reviewed by Laszlo Gombos.
17410
17411 Updated include paths for phonon.
17412
17413 [Qt] WebKit patches required to work with a modularized version of Qt
17414 https://bugs.webkit.org/show_bug.cgi?id=53916
17415
17416 Build fix. No tests.
17417
17418 * WebCore.pro:
17419
17420 2011-02-17 Hui Huang <hui.2.huang@nokia.com>
17421
17422 Reviewed by Laszlo Gombos.
17423
17424 The URL of HTML5 Video Element is percent encoded at websites such as yo utube.
17425 It is percent encoded again by QUrl constructor QUrl::QUrl(QString). Thi s causes
17426 the HTTP GET request for the video to be rejected by the service provide r.
17427 https://bugs.webkit.org/show_bug.cgi?id=53973.
17428
17429 The bug is fixed by constructing QUrl from the encoded URL.
17430
17431 New test function tst_QWebPage::loadHtml5Video() is added in
17432 Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp
17433
17434 * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
17435 (WebCore::MediaPlayerPrivateQt::commitLoad):
17436
17437 2011-02-17 Andreas Kling <kling@webkit.org>
17438
17439 Reviewed by Antti Koivisto.
17440
17441 [Qt] Crash when calling QWebFrame::setUrl() while a previous load has pe nding requests
17442 https://bugs.webkit.org/show_bug.cgi?id=49216
17443
17444 CachedResourceRequest::didFail() will protect the CachedResourceLoader's
17445 document() while it runs, but if we're being called from the Document de structor,
17446 the protecting RefPtr<Document> will cause a double-delete instead.
17447
17448 * loader/cache/CachedResourceLoader.cpp:
17449 (WebCore::CachedResourceLoader::~CachedResourceLoader): Clear the m_docu ment
17450 pointer so CachedResourceRequest::didFail() won't try to protect it.
17451 (WebCore::CachedResourceLoader::frame): Add null-check for m_document.
17452
17453 2011-02-17 Andrey Adaikin <aandrey@google.com>
17454
17455 Reviewed by Pavel Feldman.
17456
17457 Web Inspector: [Text editor] Add updateHighlight method to the highlight er
17458 https://bugs.webkit.org/show_bug.cgi?id=54448
17459
17460 * inspector/front-end/SourceTokenizer.js:
17461 * inspector/front-end/TextEditorHighlighter.js:
17462 (WebInspector.TextEditorHighlighter.prototype.set mimeType):
17463 (WebInspector.TextEditorHighlighter.prototype.reset):
17464 (WebInspector.TextEditorHighlighter.prototype.updateHighlight):
17465 (WebInspector.TextEditorHighlighter.prototype._highlightInChunks):
17466 (WebInspector.TextEditorHighlighter.prototype._highlightLines):
17467
17468 2011-02-16 Pavel Podivilov <podivilov@chromium.org>
17469
17470 Reviewed by Yury Semikhatsky.
17471
17472 Web Inspector: show all inlined scripts from single document in the same source frame.
17473 https://bugs.webkit.org/show_bug.cgi?id=54544
17474
17475 Currently when debugging synchronously executed inlined scripts each scr ipt is shown in it's own source frame ("example.html:24").
17476 We should show such scripts in the same source frame "example.html" with <script></script> framing.
17477
17478 Test: inspector/debugger/debug-inlined-scripts.html
17479
17480 * inspector/front-end/ScriptsPanel.js:
17481 (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
17482 (WebInspector.ScriptsPanel.prototype._addScript):
17483 (WebInspector.ScriptsPanel.prototype._resourceForURL):
17484 (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
17485 (WebInspector.ScriptsPanel.prototype.addConsoleMessage):
17486 (WebInspector.ScriptsPanel.prototype.clearConsoleMessages):
17487 (WebInspector.ScriptsPanel.prototype.reset):
17488 (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
17489 (WebInspector.ScriptsPanel.prototype._sourceFrameForScript):
17490 (WebInspector.ScriptsPanel.prototype._recreateSourceFrame):
17491 (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
17492 (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu.optionCompare ):
17493 (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
17494 (WebInspector.SourceFrameContentProviderForScript.prototype.requestConte nt):
17495 (WebInspector.SourceFrameContentProviderForScript.prototype._buildSource ):
17496
17497 2011-02-17 Nikolas Zimmermann <nzimmermann@rim.com>
17498
17499 Reviewed by Dirk Schulze.
17500
17501 svg/batik/paints/patternRegions-positioned-objects.svg fails on Windows
17502 https://bugs.webkit.org/show_bug.cgi?id=44484
17503
17504 Pattern of pattern defined with objectBoundingBox does not render correc tly
17505 https://bugs.webkit.org/show_bug.cgi?id=53463
17506
17507 Fix <pattern> + patternContentUnits="objectBoundingBox" support.
17508 We were incorrrectly translating the tile image transform, by the target objects bbox.x()/y().
17509 RenderSVGResourceMask/Clipper don't have this error.
17510
17511 Fix nesting <patterns> in objectBoundingBox mode, propagate the tileImag eTransform as new user-space
17512 when drawing the pattern children. <mask> + <clipPath> don't have the pr oblem.
17513
17514 Test: svg/custom/nested-pattern-boundingBoxModeContent.svg
17515
17516 * rendering/svg/RenderSVGResourcePattern.cpp:
17517 (WebCore::RenderSVGResourcePattern::buildTileImageTransform):
17518 (WebCore::RenderSVGResourcePattern::createTileImage):
17519
17520 2011-02-17 Csaba Osztrogonác <ossy@webkit.org>
17521
17522 Unreviewed.
17523
17524 [Qt][V8] Buildfix after r78752.
17525
17526 * CodeGenerators.pri: Add missing IDL files.
17527
17528 2011-02-17 Benjamin Kalman <kalman@chromium.org>
17529
17530 Reviewed by Ryosuke Niwa.
17531
17532 RTL lineboundary left/right is reversed when cursor is at start of RTL c ontainer
17533 https://bugs.webkit.org/show_bug.cgi?id=54534
17534
17535 Test: editing/selection/extend-left-right-by-lineboundary.html
17536
17537 Add missing cases for extending left/right by lineboundary.
17538
17539 * editing/SelectionController.cpp:
17540 (WebCore::SelectionController::modifyExtendingRight):
17541 (WebCore::SelectionController::modifyExtendingLeft):
17542
17543 2011-02-16 Philippe Normand <pnormand@igalia.com>
17544
17545 Reviewed by Martin Robinson.
17546
17547 [GTK] libsoup critical warnings
17548 https://bugs.webkit.org/show_bug.cgi?id=54557
17549
17550 Avoid pausing a soup message for already downloaded resources.
17551
17552 * platform/network/soup/ResourceHandleSoup.cpp:
17553 (WebCore::ResourceHandle::platformSetDefersLoading):
17554
17555 2011-02-16 Brian Ryner <bryner@chromium.org>
17556
17557 Reviewed by Darin Fisher.
17558
17559 Split the socket address field into separate IP address and port fields.
17560 This will make the field less error-prone to parse, for example when
17561 dealing with IPv6 literals.
17562 https://bugs.webkit.org/show_bug.cgi?id=54607
17563
17564 No new tests required.
17565
17566 * platform/network/chromium/ResourceResponse.cpp:
17567 (WebCore::ResourceResponse::doPlatformCopyData):
17568 (WebCore::ResourceResponse::doPlatformAdopt):
17569 * platform/network/chromium/ResourceResponse.h:
17570 (WebCore::ResourceResponse::ResourceResponse):
17571 (WebCore::ResourceResponse::remoteIPAddress):
17572 (WebCore::ResourceResponse::setRemoteIPAddress):
17573 (WebCore::ResourceResponse::remotePort):
17574 (WebCore::ResourceResponse::setRemotePort):
17575
17576 2011-02-16 Dominic Mazzoni <dmazzoni@google.com>
17577
17578 Reviewed by Chris Fleizach.
17579
17580 Add support for canvas fallback content.
17581 https://bugs.webkit.org/show_bug.cgi?id=50126
17582
17583 Test: accessibility/canvas-fallback-content.html
17584
17585 * accessibility/AccessibilityObject.h:
17586 * accessibility/AccessibilityRenderObject.cpp:
17587 (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
17588 (WebCore::AccessibilityRenderObject::canHaveChildren):
17589 * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
17590 (atkRole):
17591 * accessibility/mac/AccessibilityObjectWrapper.mm:
17592 * html/HTMLFormControlElement.cpp:
17593 (WebCore::HTMLFormControlElement::isFocusable):
17594 * rendering/RenderHTMLCanvas.cpp:
17595 (WebCore::RenderHTMLCanvas::recursiveSetNoNeedsLayout):
17596 (WebCore::RenderHTMLCanvas::layout):
17597 (WebCore::RenderHTMLCanvas::nodeAtPoint):
17598 * rendering/RenderHTMLCanvas.h:
17599 (WebCore::RenderHTMLCanvas::children):
17600 (WebCore::RenderHTMLCanvas::canHaveChildren):
17601 (WebCore::RenderHTMLCanvas::virtualChildren):
17602 * rendering/RenderObject.cpp:
17603 (WebCore::RenderObject::repaint):
17604 * rendering/RenderTreeAsText.cpp:
17605 (WebCore::write):
17606
17607 2011-02-16 Matthew Delaney <mdelaney@apple.com>
17608
17609 Reviewed by Simon Fraser.
17610
17611 Allow acceleratesDrawing for WebKit2
17612 https://bugs.webkit.org/show_bug.cgi?id=54511
17613
17614 Plumb through preference for accelerated drawing.
17615
17616 When accelerated drawing is enabled, set a flag on new GraphicsLayers.
17617
17618 Not testable via Layout Tests
17619
17620 * WebCore.exp.in:
17621 * page/Settings.cpp:
17622 (WebCore::Settings::Settings):
17623 (WebCore::Settings::setAcceleratedDrawingEnabled):
17624 * page/Settings.h:
17625 (WebCore::Settings::acceleratedDrawingEnabled):
17626 * rendering/RenderLayerCompositor.cpp:
17627 (WebCore::RenderLayerCompositor::updateBacking):
17628
1 2011-02-16 Victoria Kirst <vrk@google.com> 17629 2011-02-16 Victoria Kirst <vrk@google.com>
2 17630
3 Reviewed by Kenneth Russell. 17631 Reviewed by Kenneth Russell.
4 17632
5 [chromium] Fix green pixels at edge of certain GPU-accelerated videos 17633 [chromium] Fix green pixels at edge of certain GPU-accelerated videos
6 https://bugs.webkit.org/show_bug.cgi?id=54559 17634 https://bugs.webkit.org/show_bug.cgi?id=54559
7 17635
8 Adds logic to properly resize the range of YUV textures to only 17636 Adds logic to properly resize the range of YUV textures to only
9 select legitimate values. 17637 select legitimate values.
10 17638
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 17952
325 [V8] DataView constructor can be applied as a regular method 17953 [V8] DataView constructor can be applied as a regular method
326 https://bugs.webkit.org/show_bug.cgi?id=54563 17954 https://bugs.webkit.org/show_bug.cgi?id=54563
327 17955
328 Tested by adding a new test case to fast/canvas/webgl/data-view-test.htm l. 17956 Tested by adding a new test case to fast/canvas/webgl/data-view-test.htm l.
329 17957
330 * bindings/v8/custom/V8DataViewCustom.cpp: 17958 * bindings/v8/custom/V8DataViewCustom.cpp:
331 (WebCore::V8DataView::constructorCallback): 17959 (WebCore::V8DataView::constructorCallback):
332 17960
333 == Rolled over to ChangeLog-2011-02-16 == 17961 == Rolled over to ChangeLog-2011-02-16 ==
OLDNEW
« no previous file with comments | « no previous file | Source/WebCore/bindings/v8/V8GCController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698