Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5722)

Unified Diff: chrome/test/automation/proxy_launcher.h

Issue 6689014: GTTF: Detect browser crashes on shutdown in UI tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/automation/proxy_launcher.h
===================================================================
--- chrome/test/automation/proxy_launcher.h (revision 80488)
+++ chrome/test/automation/proxy_launcher.h (working copy)
@@ -120,15 +120,14 @@
// Returns true when the browser process is running, independent if any
// renderer process exists or not. It will returns false if an user closed the
// window or if the browser process died by itself.
+ // TODO(phajdan.jr): Get rid of IsBrowserRunning, it is difficult
+ // to make it simple and reliable.
bool IsBrowserRunning();
- // Returns true when timeout_ms milliseconds have elapsed.
- // Returns false if the browser process died while waiting.
- bool CrashAwareSleep(int timeout_ms);
-
// Wait for the browser process to shut down on its own (i.e. as a result of
- // some action that your test has taken).
- bool WaitForBrowserProcessToQuit(int timeout);
+ // some action that your test has taken). If it has exited within |timeout|,
+ // puts the exit code in |exit_code| and returns true.
+ bool WaitForBrowserProcessToQuit(int timeout, int* exit_code);
AutomationProxy* automation() const;

Powered by Google App Engine
This is Rietveld 408576698