Issue 6689001: msysgit - Fix issue where gcl doesn't recognize the editor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6689001: msysgit - Fix issue where gcl doesn't recognize the editor. (Closed)

Created:
9 years, 9 months ago by Mohamed Mansour

Modified:
9 years, 6 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, rsleevi-old, Aaron Boodman

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

msysgit - Fix issue where gcl doesn't recognize the editor. gcl is now fully compatible with msysgit. BUG=70550 TEST=gcl change through msysgit. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77909

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	gcl.py	View	1	1 chunk	+7 lines, -5 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

http://codereview.chromium.org/6689001/diff/1/gcl.py File gcl.py (right): http://codereview.chromium.org/6689001/diff/1/gcl.py#newcode1067 gcl.py:1067: subprocess.call(['env', GetEditor(), filename], shell=True) While at it, use check_call(), ...

9 years, 9 months ago (2011-03-12 00:34:13 UTC) #2

M-A Ruel

9 years, 9 months ago (2011-03-12 02:17:29 UTC) #4

lgtm

http://codereview.chromium.org/6689001/diff/5001/gcl.py
File gcl.py (right):

http://codereview.chromium.org/6689001/diff/5001/gcl.py#newcode1066
gcl.py:1066: result = None
Not needed.

Expand Messages | Collapse Messages