Chromium Code Reviews| Index: gcl.py |
| =================================================================== |
| --- gcl.py (revision 77893) |
| +++ gcl.py (working copy) |
| @@ -1063,12 +1063,14 @@ |
| os.write(handle, text) |
| os.close(handle) |
| - if not silent: |
| - os.system(GetEditor() + " " + filename) |
| + result = None |
|
M-A Ruel
2011/03/12 02:17:29
Not needed.
|
| + try: |
| + if not silent: |
| + subprocess.check_call(['env', GetEditor(), filename], shell=True) |
| + result = gclient_utils.FileRead(filename, 'r') |
| + finally: |
| + os.remove(filename) |
| - result = gclient_utils.FileRead(filename, 'r') |
| - os.remove(filename) |
| - |
| if not result: |
| return 0 |