Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Issue 6688050: Mac: Elides the beginning of tab titles that have common prefixes (Closed)

Created:
9 years, 9 months ago by sail
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Mac: Elides the beginning of tab titles that have common prefixes This is just the Mac version of mad's change. See: http://codereview.chromium.org/6579050/ I'm updating GTM with my change to fade the beginning of the text field: http://code.google.com/p/google-toolbox-for-mac/source/detail?r=437 BUG=69304 TEST=Still testing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79798

Patch Set 1 #

Total comments: 12

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -3 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_controller.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_controller.mm View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 8 chunks +45 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
sail
9 years, 9 months ago (2011-03-19 01:22:02 UTC) #1
pink (ping after 24hrs)
drive-by http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right): http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm#newcode1917 chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1917: - (void)updateCommonTitlePrefix { this method needs a comment ...
9 years, 9 months ago (2011-03-21 13:31:38 UTC) #2
Robert Sesek
http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right): http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm#newcode1379 chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1379: - (void)tabMiniStateChangedWithContents:(TabContentsWrapper*)contents If a tab is unpinned, do you ...
9 years, 9 months ago (2011-03-21 19:09:14 UTC) #3
sail
http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right): http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm#newcode1379 chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1379: - (void)tabMiniStateChangedWithContents:(TabContentsWrapper*)contents On 2011/03/21 19:09:14, rsesek wrote: > If ...
9 years, 9 months ago (2011-03-22 00:47:00 UTC) #4
sail
Updated GTM with some improvements to the GTMFadeTruncatingTextFieldCell drawing code. http://code.google.com/p/google-toolbox-for-mac/source/detail?r=439
9 years, 9 months ago (2011-03-29 00:08:14 UTC) #5
MAD
On 2011/03/29 00:08:14, sail wrote: > Updated GTM with some improvements to the GTMFadeTruncatingTextFieldCell drawing ...
9 years, 9 months ago (2011-03-29 14:43:21 UTC) #6
Robert Sesek
9 years, 9 months ago (2011-03-29 14:52:43 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld 408576698