Mac: Elides the beginning of tab titles that have common prefixes

Mac: Elides the beginning of tab titles that have common prefixes

This is just the Mac version of mad's change. See:
http://codereview.chromium.org/6579050/

I'm updating GTM with my change to fade the beginning of the text field:
http://code.google.com/p/google-toolbox-for-mac/source/detail?r=437

BUG=69304
TEST=Still testing.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79798

[pink (ping after 24hrs), 2011-03-21 13:31:38]

drive-by

http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/ta...
File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right):

http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/ta...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1917: -
(void)updateCommonTitlePrefix {
this method needs a comment

http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/ta...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1922: [tabContentsArray_
objectAtIndex:tabIndex];
continuations indented 4 additional spaces.

http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/ta...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1931: for (size_t infoIndex
= 0; infoIndex < tabTitleInfos.size(); infoIndex++) {
++infoIndex, not that it really matters.

http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/ta...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1933: TabController*
tabController = [tabArray_ objectAtIndex:tabIndex];
you should DCHECK tabIndex < array length to ensure that tabIndex won't throw a
cocoa exception.

[Robert Sesek, 2011-03-21 19:09:14]

http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/ta...
File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right):

http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/ta...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1379: -
(void)tabMiniStateChangedWithContents:(TabContentsWrapper*)contents
If a tab is unpinned, do you need to call |-updateCommonTitlePrefix|?

http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/ta...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1917: -
(void)updateCommonTitlePrefix {
On 2011/03/21 13:31:38, pink wrote:
> this method needs a comment

+1. Each loop should probably have one, too.

[sail, 2011-03-22 00:47:00]

http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/ta...
File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right):

http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/ta...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1379: -
(void)tabMiniStateChangedWithContents:(TabContentsWrapper*)contents
On 2011/03/21 19:09:14, rsesek wrote:
> If a tab is unpinned, do you need to call |-updateCommonTitlePrefix|?

Done.

http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/ta...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1917: -
(void)updateCommonTitlePrefix {
On 2011/03/21 13:31:38, pink wrote:
> this method needs a comment

Done.

http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/ta...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1917: -
(void)updateCommonTitlePrefix {
On 2011/03/21 19:09:14, rsesek wrote:
> On 2011/03/21 13:31:38, pink wrote:
> > this method needs a comment
> 
> +1. Each loop should probably have one, too.

Done.

http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/ta...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1922: [tabContentsArray_
objectAtIndex:tabIndex];
On 2011/03/21 13:31:38, pink wrote:
> continuations indented 4 additional spaces.

Done.

http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/ta...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1931: for (size_t infoIndex
= 0; infoIndex < tabTitleInfos.size(); infoIndex++) {
On 2011/03/21 13:31:38, pink wrote:
> ++infoIndex, not that it really matters.

Done.

http://codereview.chromium.org/6688050/diff/1/chrome/browser/ui/cocoa/tabs/ta...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1933: TabController*
tabController = [tabArray_ objectAtIndex:tabIndex];
On 2011/03/21 13:31:38, pink wrote:
> you should DCHECK tabIndex < array length to ensure that tabIndex won't throw
a
> cocoa exception.

Done.

[sail, 2011-03-29 00:08:14]

Updated GTM with some improvements to the GTMFadeTruncatingTextFieldCell drawing
code.
http://code.google.com/p/google-toolbox-for-mac/source/detail?r=439

[MAD, 2011-03-29 14:43:21]

On 2011/03/29 00:08:14, sail wrote:
> Updated GTM with some improvements to the GTMFadeTruncatingTextFieldCell
drawing
> code.
> http://code.google.com/p/google-toolbox-for-mac/source/detail?r=439

Just a quick note to let you know to not rely on me for this code review, I
would like to claim ignorance about Mac programming :-)...

[Robert Sesek, 2011-03-29 14:52:43]

LGTM