Mac: Elides the beginning of tab titles that have common prefixes

chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h"
 
 #import <QuartzCore/QuartzCore.h>
 
 #include <limits>
 #include <string>
 
@@ skipping 18 matching lines @@
 #import "chrome/browser/ui/cocoa/constrained_window_mac.h"
 #import "chrome/browser/ui/cocoa/new_tab_button.h"
 #import "chrome/browser/ui/cocoa/tabs/tab_controller.h"
 #import "chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h"
 #import "chrome/browser/ui/cocoa/tabs/tab_strip_view.h"
 #import "chrome/browser/ui/cocoa/tabs/tab_view.h"
 #import "chrome/browser/ui/cocoa/tabs/throbber_view.h"
 #import "chrome/browser/ui/cocoa/tracking_area.h"
 #include "chrome/browser/ui/find_bar/find_bar.h"
 #include "chrome/browser/ui/find_bar/find_bar_controller.h"
+#include "chrome/browser/ui/title_prefix_matcher.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "content/browser/tab_contents/navigation_controller.h"
 #include "content/browser/tab_contents/navigation_entry.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "content/browser/tab_contents/tab_contents_view.h"
 #include "grit/app_resources.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "skia/ext/skia_utils_mac.h"
 #import "third_party/GTM/AppKit/GTMNSAnimation+Duration.h"
@@ skipping 86 matching lines @@
 - (NSInteger)indexFromModelIndex:(NSInteger)index;
 - (NSInteger)numberOfOpenTabs;
 - (NSInteger)numberOfOpenMiniTabs;
 - (NSInteger)numberOfOpenNonMiniTabs;
 - (void)mouseMoved:(NSEvent*)event;
 - (void)setTabTrackingAreasEnabled:(BOOL)enabled;
 - (void)droppingURLsAt:(NSPoint)point
             givesIndex:(NSInteger*)index
            disposition:(WindowOpenDisposition*)disposition;
 - (void)setNewTabButtonHoverState:(BOOL)showHover;
+- (void)updateCommonTitlePrefix;
 @end
 
 // A simple view class that prevents the Window Server from dragging the area
 // behind tabs. Sometimes core animation confuses it. Unfortunately, it can also
 // falsely pick up clicks during rapid tab closure, so we have to account for
 // that.
 @interface TabStripControllerDragBlockingView : NSView {
   TabStripController* controller_;  // weak; owns us
 }
 
@@ skipping 860 matching lines @@
     [self layoutTabs];
   }
 
   // During normal loading, we won't yet have a favicon and we'll get
   // subsequent state change notifications to show the throbber, but when we're
   // dragging a tab out into a new window, we have to put the tab's favicon
   // into the right state up front as we won't be told to do it from anywhere
   // else.
   [self updateFaviconForContents:contents->tab_contents() atIndex:modelIndex];
 
+  [self updateCommonTitlePrefix];
+
   // Send a broadcast that the number of tabs have changed.
   [[NSNotificationCenter defaultCenter]
       postNotificationName:kTabStripNumberOfTabsChanged
                     object:self];
 }
 
 // Called when a notification is received from the model to select a particular
 // tab. Swaps in the toolbar and content area associated with |newContents|.
 - (void)selectTabWithContents:(TabContentsWrapper*)newContents
              previousContents:(TabContentsWrapper*)oldContents
@@ skipping 99 matching lines @@
   [controller setTarget:nil];
 
   if ([hoveredTab_ isEqual:tab])
     hoveredTab_ = nil;
 
   NSValue* identifier = [NSValue valueWithPointer:tab];
   [targetFrames_ removeObjectForKey:identifier];
 
   // Once we're totally done with the tab, delete its controller
   [tabArray_ removeObjectAtIndex:index];
+
+  [self updateCommonTitlePrefix];
 }
 
 // Called by the CAAnimation delegate when the tab completes the closing
 // animation.
 - (void)animationDidStopForController:(TabController*)controller
                              finished:(BOOL)finished {
   [closingControllers_ removeObject:controller];
   [self removeTab:controller];
 }
 
@@ skipping 175 matching lines @@
   TabController* tabController = [tabArray_ objectAtIndex:index];
 
   if (change != TabStripModelObserver::LOADING_ONLY)
     [self setTabTitle:tabController withContents:contents->tab_contents()];
 
   [self updateFaviconForContents:contents->tab_contents() atIndex:modelIndex];
 
   TabContentsController* updatedController =
       [tabContentsArray_ objectAtIndex:index];
   [updatedController tabDidChange:contents->tab_contents()];
+
+  [self updateCommonTitlePrefix];
 }
 
 // Called when a tab is moved (usually by drag&drop). Keep our parallel arrays
 // in sync with the tab strip model. It can also be pinned/unpinned
 // simultaneously, so we need to take care of that.
 - (void)tabMovedWithContents:(TabContentsWrapper*)contents
                    fromIndex:(NSInteger)modelFrom
                      toIndex:(NSInteger)modelTo {
   // Take closing tabs into account.
   NSInteger from = [self indexFromModelIndex:modelFrom];
@@ skipping 11 matching lines @@
   [tabArray_ insertObject:movedTabController.get() atIndex:to];
 
   // The tab moved, which means that the mini-tab state may have changed.
   if (tabStripModel_->IsMiniTab(modelTo) != [movedTabController mini])
     [self tabMiniStateChangedWithContents:contents atIndex:modelTo];
 
   [self layoutTabs];
 }
 
 // Called when a tab is pinned or unpinned without moving.
 - (void)tabMiniStateChangedWithContents:(TabContentsWrapper*)contents

[Robert Sesek, 2011/03/21 19:09:14]

If a tab is unpinned, do you need to call |-updateCommonTitlePrefix|?

[sail, 2011/03/22 00:47:00]

Done.

                                 atIndex:(NSInteger)modelIndex {
   // Take closing tabs into account.
   NSInteger index = [self indexFromModelIndex:modelIndex];
 
   TabController* tabController = [tabArray_ objectAtIndex:index];
   DCHECK([tabController isKindOfClass:[TabController class]]);
 
   // Don't do anything if the change was already picked up by the move event.
   if (tabStripModel_->IsMiniTab(modelIndex) == [tabController mini])
     return;
@@ skipping 517 matching lines @@
   NSInteger modelIndex = [self modelIndexForContentsView:tabContentsView];
   NSInteger index = [self indexFromModelIndex:modelIndex];
   BrowserWindowController* controller =
       (BrowserWindowController*)[[switchView_ window] windowController];
   DCHECK(index >= 0);
   if (index >= 0) {
     [controller setTab:[self viewAtIndex:index] isDraggable:YES];
   }
 }
 
+- (void)updateCommonTitlePrefix {

[pink (ping after 24hrs), 2011/03/21 13:31:38]

this method needs a comment

[Robert Sesek, 2011/03/21 19:09:14]

+1. Each loop should probably have one, too.

[sail, 2011/03/22 00:47:00]

Done.

[sail, 2011/03/22 00:47:00]

Done.

+  std::vector<TitlePrefixMatcher::TitleInfo> tabTitleInfos;
+  int tabIndex = 0;
+  for (TabController* tabController in tabArray_.get()) {
+    TabContentsController* tabContentsController =
+      [tabContentsArray_ objectAtIndex:tabIndex];

[pink (ping after 24hrs), 2011/03/21 13:31:38]

continuations indented 4 additional spaces.

[sail, 2011/03/22 00:47:00]

Done.

+    TabContents* tabContents = [tabContentsController tabContents];
+    if (!tabContents->GetTitle().empty() && ![tabController mini]) {
+      tabTitleInfos.push_back(TitlePrefixMatcher::TitleInfo(
+          &(tabContents->GetTitle()), tabIndex));
+    }
+  }
+  TitlePrefixMatcher::CalculatePrefixLengths(&tabTitleInfos);
+
+  for (size_t infoIndex = 0; infoIndex < tabTitleInfos.size(); infoIndex++) {

[pink (ping after 24hrs), 2011/03/21 13:31:38]

++infoIndex, not that it really matters.

[sail, 2011/03/22 00:47:00]

Done.

+    tabIndex = tabTitleInfos[infoIndex].caller_value;
+    TabController* tabController = [tabArray_ objectAtIndex:tabIndex];

[pink (ping after 24hrs), 2011/03/21 13:31:38]

you should DCHECK tabIndex < array length to ensure that tabIndex won't throw a
cocoa exception.

[sail, 2011/03/22 00:47:00]

Done.

+    [tabController setTitleCommonPrefixLength:
+        tabTitleInfos[infoIndex].prefix_length];
+  }
+}
+
 @end