Add tests for ChromeOS prefs: kAccessibilityEnabled, kEnableScreenLock and kTapToClickEnabled.

Add tests for ChromeOS prefs: kAccessibilityEnabled, kEnableScreenLock and kTapToClickEnabled.


Add tests for ChromeOS prefs: kAccessibilityEnabled, kEnableScreenLock and kTapToClickEnabled.


BUG=none
TEST=new automation

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78960

[anna, 2011-03-21 19:00:02]

This patch adds tests for ChromeOS preferences, as per crbug.com/70696 and
crbug.com/76751.

Thanks for reviewing.
-Anna

[Raghu Simha, 2011-03-21 19:32:47]

None of these tests will get compiled or run on the Chromium trybots due to the
ifdefs. Could you run them by the linux_chromeos bot to make sure they compile?
http://build.chromium.org/p/tryserver.chromium/waterfall?builder=linux_chromeos

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
File chrome/test/live_sync/two_client_live_preferences_sync_test.cc (right):

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:755:
kTapToClickEnabled) {
nit: Adjust indentation to align with the line above.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:760: bool
new_kAccessibilityEnabled = !GetPrefs0()->
Wrong variable name here. This won't compile on Chrome OS.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:763:
new_kTapToClickEnabled);
nit: Adjust indentation to align with the line above.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:765:
new_kTapToClickEnabled);
nit: Adjust indentation to align with the line above.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:774:
!new_kTapToClickEnabledd);
nit: Adjust indentation to align with the line above.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:776:
!new_kTapToClickEnabled);
nit: Adjust indentation to align with the line above.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:789:
kAccessibilityEnabled) {
nit: Adjust indentation to align with the line above.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:795:
GetBoolean(prefs::kAccessibilityEnabled);
nit: Adjust indentation to align with the line above.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:797:
new_kAccessibilityEnabled);
nit: Adjust indentation to align with the line above.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:799:
new_kAccessibilityEnabled);
nit: Adjust indentation to align with the line above.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:808:
!new_kAccessibilityEnabled);
nit: Adjust indentation to align with the line above.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:810:
!new_kAccessibilityEnabled);
nit: Adjust indentation to align with the line above.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:823:
kEnableScreenLock) {
nit: Adjust indentation to align with the line above.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:828: bool
new_kAccessibilityEnabled = !GetPrefs0()->
Wrong variable name here. This won't compile on Chrome OS.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:831:
new_kEnableScreenLock);
nit: Adjust indentation to align with the line above.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:841:
!new_kEnableScreenLock);
nit: Adjust indentation to align with the line above.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:843:
!new_kEnableScreenLock);
nit: Adjust indentation to align with the line above.

[anna, 2011-03-21 21:19:40]

Adjusted spacing and variable names as per feedback.

Thanks,
-Anna

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
File chrome/test/live_sync/two_client_live_preferences_sync_test.cc (right):

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:755:
kTapToClickEnabled) {
On 2011/03/21 19:32:47, rsimha wrote:
> nit: Adjust indentation to align with the line above.

Done.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:755:
kTapToClickEnabled) {
We do not have strict indentation style rules on the test framework side. The
code still conforms with the general style requirements.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:755:
kTapToClickEnabled) {
On 2011/03/21 19:32:47, rsimha wrote:
> nit: Adjust indentation to align with the line above.

Done.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:760: bool
new_kAccessibilityEnabled = !GetPrefs0()->
On 2011/03/21 19:32:47, rsimha wrote:
> Wrong variable name here. This won't compile on Chrome OS.

Done.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:763:
new_kTapToClickEnabled);
On 2011/03/21 19:32:47, rsimha wrote:
> nit: Adjust indentation to align with the line above.

Done.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:765:
new_kTapToClickEnabled);
On 2011/03/21 19:32:47, rsimha wrote:
> nit: Adjust indentation to align with the line above.

Done.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:774:
!new_kTapToClickEnabledd);
On 2011/03/21 19:32:47, rsimha wrote:
> nit: Adjust indentation to align with the line above.

Done.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:776:
!new_kTapToClickEnabled);
On 2011/03/21 19:32:47, rsimha wrote:
> nit: Adjust indentation to align with the line above.

Done.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:789:
kAccessibilityEnabled) {
On 2011/03/21 19:32:47, rsimha wrote:
> nit: Adjust indentation to align with the line above.

Done.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:795:
GetBoolean(prefs::kAccessibilityEnabled);
On 2011/03/21 19:32:47, rsimha wrote:
> nit: Adjust indentation to align with the line above.

Done.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:797:
new_kAccessibilityEnabled);
On 2011/03/21 19:32:47, rsimha wrote:
> nit: Adjust indentation to align with the line above.

Done.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:799:
new_kAccessibilityEnabled);
On 2011/03/21 19:32:47, rsimha wrote:
> nit: Adjust indentation to align with the line above.

Done.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:808:
!new_kAccessibilityEnabled);
On 2011/03/21 19:32:47, rsimha wrote:
> nit: Adjust indentation to align with the line above.

Done.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:810:
!new_kAccessibilityEnabled);
On 2011/03/21 19:32:47, rsimha wrote:
> nit: Adjust indentation to align with the line above.

Done.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:823:
kEnableScreenLock) {
On 2011/03/21 19:32:47, rsimha wrote:
> nit: Adjust indentation to align with the line above.

Done.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:828: bool
new_kAccessibilityEnabled = !GetPrefs0()->
On 2011/03/21 19:32:47, rsimha wrote:
> Wrong variable name here. This won't compile on Chrome OS. 

Done.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:831:
new_kEnableScreenLock);
On 2011/03/21 19:32:47, rsimha wrote:
> nit: Adjust indentation to align with the line above.

Done.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:841:
!new_kEnableScreenLock);
On 2011/03/21 19:32:47, rsimha wrote:
> nit: Adjust indentation to align with the line above.

Done.

http://codereview.chromium.org/6688045/diff/2001/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_live_preferences_sync_test.cc:843:
!new_kEnableScreenLock);
On 2011/03/21 19:32:47, rsimha wrote:
> nit: Adjust indentation to align with the line above.

Done.

[Raghu Simha, 2011-03-21 23:18:33]

LGTM pending green runs on sync and linux_chromeos trybots.

Thanks for adding new tests!