Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gcl.py

Issue 6686027: Use TERM to distinguish between console and msysgit.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | git_cl/git_cl.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
===================================================================
--- gcl.py (revision 77947)
+++ gcl.py (working copy)
@@ -1065,9 +1065,8 @@
# Open up the default editor in the system to get the CL description.
cmd = [GetEditor(), filename]
- if sys.platform == 'win32' and 'mingw\\bin' in os.environ['PATH']:
- # Msysgit requires the usage of 'env' to be present. The only way to
- # accomplish that is by reading the environment variable for mingw\bin.
+ if sys.platform == 'win32' and os.environ['TERM'] == 'msys':
M-A Ruel 2011/03/13 21:16:17 os.environ.get('TERM') would have worked but it's
+ # Msysgit requires the usage of 'env' to be present.
cmd.insert(0, 'env')
try:
if not silent:
« no previous file with comments | « no previous file | git_cl/git_cl.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698