Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: git_cl/git_cl.py

Issue 6686027: Use TERM to distinguish between console and msysgit.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gcl.py ('K') | « gcl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl/git_cl.py
===================================================================
--- git_cl/git_cl.py (revision 77947)
+++ git_cl/git_cl.py (working copy)
@@ -712,9 +712,8 @@
# Open up the default editor in the system to get the CL description.
cmd = [editor, filename]
- if sys.platform == 'win32' and 'mingw\\bin' in os.environ['PATH']:
- # Msysgit requires the usage of 'env' to be present. The only way to
- # accomplish that is by reading the environment variable for mingw\bin.
+ if sys.platform == 'win32' and os.environ['TERM'] == 'msys':
+ # Msysgit requires the usage of 'env' to be present.
cmd.insert(0, 'env')
try:
subprocess.check_call(cmd)
« gcl.py ('K') | « gcl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698