Use TERM to distinguish between console and msysgit....

Use TERM to distinguish between console and msysgit.

It is cleaner this way since in Win32 console, the
value is always "dumb" while in msysgit it is always
"msys" The user shouldn't change the value of $TERM
in msysgit otherwise their whole copy of msysgit
will be flaky.

BUG=70548
TEST=check $TERM in windows


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77954

[Mohamed Mansour, 2011-03-12 21:00:51]

I think this approach is cleaner. I was playing around the terminal to see why
my home key wasn't set in putty and I changed it to "linux". That made me wonder
what the value for $TERM for msysgit was. It was "msys".

[M-A Ruel, 2011-03-12 21:09:52]

lgtm

[jam, 2011-03-13 21:14:38]

This broke gcl on Windows again.  Please test these changes carefully as
these tools are depended on by a large number of developers.

A:\chrome2\src>gcl change
Traceback (most recent call last):
  File "A:\depot_tools\gcl.py", line 1408, in <module>
    sys.exit(main(sys.argv[1:]))
  File "A:\depot_tools\gcl.py", line 1388, in main
    return command(argv[1:])
  File "A:\depot_tools\gcl.py", line 1068, in CMDchange
    if sys.platform == 'win32' and os.environ['TERM'] == 'msys':
  File "A:\depot_tools\python_bin\lib\os.py", line 423, in __getitem__
    return self.data[key.upper()]
KeyError: 'TERM'
Sending crash report ...
  exception: 'TERM'
  args: ['A:\\depot_tools\\gcl.py', 'change']
  stack:   File "A:\depot_tools\gcl.py", line 1408, in <mod
  host: JABDELMALEK0-W.ad.corp.google.com
  version: 2.6.2 (r262:71600, Apr 21 2009, 15:05:37) [MSC v.1
  user: jabdelmalek
  cwd: A:\chrome2\src
A stack trace has been sent to the maintainers.

On Sat, Mar 12, 2011 at 1:09 PM, <maruel@chromium.org> wrote:

> lgtm
>
>
> http://codereview.chromium.org/6686027/
>

[M-A Ruel, 2011-03-13 21:16:17]

ltgm

http://codereview.chromium.org/6686027/diff/1/gcl.py
File gcl.py (right):

http://codereview.chromium.org/6686027/diff/1/gcl.py#newcode1068
gcl.py:1068: if sys.platform == 'win32' and os.environ['TERM'] == 'msys':
os.environ.get('TERM') would have worked but it's fine.