Issue 6685093: Use keyboard_layout instead of initial_locale

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6685093: Use keyboard_layout instead of initial_locale (Closed)

Created:
9 years, 9 months ago by Nick Sanders

Modified:
9 years, 7 months ago

Reviewers:
Hung-Te, yongjaek, Jay Kim

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, Tammo Spalink

Base URL:
ssh://git@gitrw.chromium.org:9222/autotest.git@master

Visibility:
Public.

Description

Use keyboard_layout instead of initial_locale * SelectKeyboard writes both kb layout and locale * hw components checks kb layout * still todo (another CL): reference kb file from kb layout * still todo (another CL): en-GB is stubbed out. Need actual png. BUG=chrome-os-partner:2591 TEST=will do Change-Id: If828499983fc2066197e4ecfd0713c144c78bbea Review URL: http://codereview.chromium.org/6679050 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=6570817

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -7 lines)			Patch
M	client/site_tests/factory_Keyboard/factory_Keyboard.py	View	1 chunk	+4 lines, -1 line	0 comments	Download
A	client/site_tests/factory_Keyboard/src/en-GB.bindings	View	1 chunk	+79 lines, -0 lines	0 comments	Download
A	client/site_tests/factory_Keyboard/src/en-GB.png	View	Binary file		0 comments	Download
M	client/site_tests/factory_SelectKeyboard/factory_SelectKeyboard.py	View	1 chunk	+8 lines, -5 lines	0 comments	Download
M	client/site_tests/hardware_Components/hardware_Components.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jay Kim

9 years, 9 months ago (2011-03-18 20:56:07 UTC) #2

LGTM. It is known that the png file has not been corrected yet, but all change
is integrated from the factory branch to the main sincerely.

Expand Messages | Collapse Messages