Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 6679050: Use keyboard_layout instead of initial_locale (Closed)

Created:
9 years, 9 months ago by Nick Sanders
Modified:
9 years, 7 months ago
Reviewers:
Hung-Te, yongjaek, Jay Kim
CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli
Visibility:
Public.

Description

Use keyboard_layout instead of initial_locale * SelectKeyboard writes both kb layout and locale * hw components checks kb layout * still todo (another CL): reference kb file from kb layout * still todo (another CL): en-GB is stubbed out. Need actual png. BUG=chrome-os-partner:2591 TEST=will do Change-Id: If828499983fc2066197e4ecfd0713c144c78bbea Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=51429b2

Patch Set 1 #

Patch Set 2 : typos #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -8 lines) Patch
M client/site_tests/factory_Keyboard/factory_Keyboard.py View 1 chunk +4 lines, -1 line 0 comments Download
A client/site_tests/factory_Keyboard/src/en-GB.bindings View 1 chunk +79 lines, -0 lines 0 comments Download
A client/site_tests/factory_Keyboard/src/en-GB.png View Binary file 0 comments Download
M client/site_tests/factory_SelectKeyboard/factory_SelectKeyboard.py View 1 1 chunk +9 lines, -6 lines 1 comment Download
M client/site_tests/hardware_Components/hardware_Components.py View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (0 generated)
Nick Sanders
9 years, 9 months ago (2011-03-14 22:44:27 UTC) #1
yongjaek
Is initial_locale used anywhere? I don't see initial_locale usage here except for writing it. http://codereview.chromium.org/6679050/diff/3001/client/site_tests/factory_SelectKeyboard/factory_SelectKeyboard.py ...
9 years, 9 months ago (2011-03-14 23:08:33 UTC) #2
yongjaek
I also have a question to the attached png file. It looks the same as ...
9 years, 9 months ago (2011-03-14 23:10:41 UTC) #3
Nick Sanders
Yep: we don't have configs: no time to Photoshop up a new KB, and generate ...
9 years, 9 months ago (2011-03-14 23:25:03 UTC) #4
yongjaek
Ok ... if the png is a known to-do item, I'm fine with that. LGTM ...
9 years, 9 months ago (2011-03-14 23:30:02 UTC) #5
Nick Sanders
oops that's embarrassing. fixed!
9 years, 9 months ago (2011-03-14 23:36:59 UTC) #6
yongjaek
9 years, 9 months ago (2011-03-15 00:11:09 UTC) #7
Plz, don't forget to integrate this to the main branch.

Powered by Google App Engine
This is Rietveld 408576698