Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Unified Diff: views/controls/single_split_view.cc

Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Refinements, etc. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/controls/single_split_view.cc
diff --git a/views/controls/single_split_view.cc b/views/controls/single_split_view.cc
index 76e924eeb287be58b61310a5bdf2baa9dd4fc746..b50bdac540082bb6fbf8b658797692ff449a2f5b 100644
--- a/views/controls/single_split_view.cc
+++ b/views/controls/single_split_view.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -182,11 +182,12 @@ bool SingleSplitView::OnMouseDragged(const MouseEvent& event) {
return true;
}
-void SingleSplitView::OnMouseReleased(const MouseEvent& event, bool canceled) {
+void SingleSplitView::OnMouseCaptureLost() {
+ // TODO(msw): Was this intentionally a no-op on non-cancelled mouse releases?
msw 2011/03/17 23:28:51 Need guidance / testing / revision history researc
if (child_count() < 2)
return;
- if (canceled && drag_info_.initial_divider_offset != divider_offset_) {
+ if (drag_info_.initial_divider_offset != divider_offset_) {
set_divider_offset(drag_info_.initial_divider_offset);
if (!observer_ || observer_->SplitHandleMoved(this))
Layout();

Powered by Google App Engine
This is Rietveld 408576698