Disambiguate OnMouseCaptureLost from OnMouseReleased, etc.

views/controls/single_split_view.cc

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/controls/single_split_view.h"
 
 #if defined(OS_LINUX)
 #include <gdk/gdk.h>
 #endif
 
 #include "skia/ext/skia_utils_win.h"
@@ skipping 163 matching lines @@
   new_size = std::min(GetPrimaryAxisSize() - kDividerSize, new_size);
 
   if (new_size != divider_offset_) {
     set_divider_offset(new_size);
     if (!observer_ || observer_->SplitHandleMoved(this))
       Layout();
   }
   return true;
 }
 
-void SingleSplitView::OnMouseReleased(const MouseEvent& event, bool canceled) {
+void SingleSplitView::OnMouseCaptureLost() {
+  // TODO(msw): Was this intentionally a no-op on non-cancelled mouse releases?

[msw, 2011/03/17 23:28:51]

Need guidance / testing / revision history research.

   if (child_count() < 2)
     return;
 
-  if (canceled && drag_info_.initial_divider_offset != divider_offset_) {
+  if (drag_info_.initial_divider_offset != divider_offset_) {
     set_divider_offset(drag_info_.initial_divider_offset);
     if (!observer_ || observer_->SplitHandleMoved(this))
       Layout();
   }
 }
 
 void SingleSplitView::OnBoundsChanged(const gfx::Rect& previous_bounds) {
   divider_offset_ = CalculateDividerOffset(divider_offset_, previous_bounds,
                                            bounds());
 }
@@ skipping 42 matching lines @@
 int SingleSplitView::NormalizeDividerOffset(int divider_offset,
                                             const gfx::Rect& bounds) const {
   int primary_axis_size = GetPrimaryAxisSize(bounds.width(), bounds.height());
   if (divider_offset < 0)
     return (primary_axis_size - kDividerSize) / 2;
   return std::min(divider_offset,
                   std::max(primary_axis_size - kDividerSize, 0));
 }
 
 }  // namespace views