Disambiguate OnMouseCaptureLost from OnMouseReleased, etc.

chrome/browser/ui/views/tabs/side_tab_strip.cc

Index: chrome/browser/ui/views/tabs/side_tab_strip.cc
diff --git a/chrome/browser/ui/views/tabs/side_tab_strip.cc b/chrome/browser/ui/views/tabs/side_tab_strip.cc
index 23326d3d9c485c849d6d08c85ab7a81724f26057..8c31f37a06e031684a6c74ab7746042238ab3c39 100644
--- a/chrome/browser/ui/views/tabs/side_tab_strip.cc
+++ b/chrome/browser/ui/views/tabs/side_tab_strip.cc
@@ -29,10 +29,12 @@ class SideTabNewTabButton : public SideTab {
  public:
   explicit SideTabNewTabButton(TabStripController* controller);
 
-  virtual bool ShouldPaintHighlight() const { return false; }
-  virtual bool IsSelected() const { return false; }
-  bool OnMousePressed(const views::MouseEvent& event);
-  void OnMouseReleased(const views::MouseEvent& event, bool canceled);
+  virtual bool ShouldPaintHighlight() const OVERRIDE { return false; }
+  virtual bool IsSelected() const OVERRIDE { return false; }
+  virtual bool OnMousePressed(const views::MouseEvent& event) OVERRIDE;
+  virtual void OnMouseReleased(const views::MouseEvent& event) OVERRIDE;
+  // TODO(msw): Remove? Overrides BaseTab::OnMouseCaptureLost() with no-op.

[msw, 2011/03/17 23:28:51]

Need guidance / testing / investigation.

+  virtual void OnMouseCaptureLost() OVERRIDE {}
 
  private:
   TabStripController* controller_;
@@ -56,9 +58,8 @@ bool SideTabNewTabButton::OnMousePressed(const views::MouseEvent& event) {
   return true;
 }
 
-void SideTabNewTabButton::OnMouseReleased(const views::MouseEvent& event,
-                                          bool canceled) {
-  if (!canceled && event.IsOnlyLeftMouseButton() && HitTest(event.location()))
+void SideTabNewTabButton::OnMouseReleased(const views::MouseEvent& event) {
+  if (event.IsOnlyLeftMouseButton() && HitTest(event.location()))
     controller_->CreateNewTab();
 }