Disambiguate OnMouseCaptureLost from OnMouseReleased, etc.

chrome/browser/ui/views/tabs/side_tab_strip.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/tabs/side_tab_strip.h"
 
 #include "chrome/browser/ui/view_ids.h"
 #include "chrome/browser/ui/views/tabs/side_tab.h"
 #include "chrome/browser/ui/views/tabs/tab_strip_controller.h"
 #include "grit/generated_resources.h"
@@ skipping 11 matching lines @@
 const SkColor kSeparatorColor = SkColorSetARGB(255, 151, 159, 179);
 
 // Height of the separator.
 const int kSeparatorHeight = 1;
 
 // The new tab button is rendered using a SideTab.
 class SideTabNewTabButton : public SideTab {
  public:
   explicit SideTabNewTabButton(TabStripController* controller);
 
-  virtual bool ShouldPaintHighlight() const { return false; }
-  virtual bool IsSelected() const { return false; }
-  bool OnMousePressed(const views::MouseEvent& event);
-  void OnMouseReleased(const views::MouseEvent& event, bool canceled);
+  virtual bool ShouldPaintHighlight() const OVERRIDE { return false; }
+  virtual bool IsSelected() const OVERRIDE { return false; }
+  virtual bool OnMousePressed(const views::MouseEvent& event) OVERRIDE;
+  virtual void OnMouseReleased(const views::MouseEvent& event) OVERRIDE;
+  // TODO(msw): Remove? Overrides BaseTab::OnMouseCaptureLost() with no-op.

[msw, 2011/03/17 23:28:51]

Need guidance / testing / investigation.

+  virtual void OnMouseCaptureLost() OVERRIDE {}
 
  private:
   TabStripController* controller_;
 
   DISALLOW_COPY_AND_ASSIGN(SideTabNewTabButton);
 };
 
 SideTabNewTabButton::SideTabNewTabButton(TabStripController* controller)
     : SideTab(NULL),
       controller_(controller) {
   // Never show a close button for the new tab button.
   close_button()->SetVisible(false);
   TabRendererData data;
   data.favicon = *ResourceBundle::GetSharedInstance().GetBitmapNamed(
       IDR_SIDETABS_NEW_TAB);
   data.title = l10n_util::GetStringUTF16(IDS_NEW_TAB_TITLE);
   SetData(data);
 }
 
 bool SideTabNewTabButton::OnMousePressed(const views::MouseEvent& event) {
   return true;
 }
 
-void SideTabNewTabButton::OnMouseReleased(const views::MouseEvent& event,
-                                          bool canceled) {
-  if (!canceled && event.IsOnlyLeftMouseButton() && HitTest(event.location()))
+void SideTabNewTabButton::OnMouseReleased(const views::MouseEvent& event) {
+  if (event.IsOnlyLeftMouseButton() && HitTest(event.location()))
     controller_->CreateNewTab();
 }
 
 }  // namespace
 
 // static
 const int SideTabStrip::kTabStripInset = 3;
 
 ////////////////////////////////////////////////////////////////////////////////
 // SideTabStrip, public:
@@ skipping 178 matching lines @@
     tab->SetBounds(layout_rect.x(), y, layout_rect.width(),
                    tab->GetPreferredSize().height());
     tab->SchedulePaint();
     y += tab->height();
   }
 }
 
 int SideTabStrip::GetSizeNeededForTabs(const std::vector<BaseTab*>& tabs) {
   return static_cast<int>(tabs.size()) * SideTab::GetPreferredHeight();
 }