Wires up ability for page to specify instant auto complete

Wires up ability for page to specify instant auto complete
behavior. The choices are:
. immediately (current behavior and is the default).
. delayed (transitions to autocompleted after a delay).
. never (only show the suggestion, but never autocomplete it).
I'm doing this so we can collect some data to help understand which is
the less error prone of the 3. The data collection is all done on the
server side.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78211

[sky, 2011-03-14 18:33:13]

It looks like Peter is gone all week. Jay, could you review this?

Thanks,

  -Scott

[Jay Civelli, 2011-03-14 20:34:26]

LGTM

[Peter Kasting, 2011-03-15 19:42:02]

Did you want me to look at this once I have time, or is it mechanical enough
that Jay's review should cover everything?

[sky, 2011-03-15 19:48:57]

I would love a full review from you when you have the time.

  -Scott

On Tue, Mar 15, 2011 at 12:42 PM,  <pkasting@chromium.org> wrote:
> Did you want me to look at this once I have time, or is it mechanical enough
> that Jay's review should cover everything?
>
> http://codereview.chromium.org/6685002/
>

[Peter Kasting, 2011-03-29 00:10:26]

LGTM

http://codereview.chromium.org/6685002/diff/3001/chrome/browser/autocomplete/...
File chrome/browser/autocomplete/autocomplete_edit.cc (right):

http://codereview.chromium.org/6685002/diff/3001/chrome/browser/autocomplete/...
chrome/browser/autocomplete/autocomplete_edit.cc:231: if
(!might_support_instant) {
Nit: I'd remove the "!" and reverse the conditions

http://codereview.chromium.org/6685002/diff/3001/chrome/browser/instant/insta...
File chrome/browser/instant/instant_browsertest.cc (right):

http://codereview.chromium.org/6685002/diff/3001/chrome/browser/instant/insta...
chrome/browser/instant/instant_browsertest.cc:695:
IN_PROC_BROWSER_TEST_F(InstantTest, InstantCompleteNever) {
Is testing INSTANT_COMPLETE_NOW what all the rest of the code in this file does?

[sky, 2011-03-29 00:11:20]

http://codereview.chromium.org/6685002/diff/3001/chrome/browser/instant/insta...
File chrome/browser/instant/instant_browsertest.cc (right):

http://codereview.chromium.org/6685002/diff/3001/chrome/browser/instant/insta...
chrome/browser/instant/instant_browsertest.cc:695:
IN_PROC_BROWSER_TEST_F(InstantTest, InstantCompleteNever) {
On 2011/03/29 00:10:27, Peter Kasting wrote:
> Is testing INSTANT_COMPLETE_NOW what all the rest of the code in this file
does?

Yes, since that's the default.