Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9805)

Unified Diff: chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Issue 6685002: Wires up ability for page to specify instant auto complete (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit test and stray char Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm b/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
index 5e1de22005f67cea4d9b75fb2cdaf8c8f691cb75..f366f887f0b9434984e2a9de4aee973aaea820da 100644
--- a/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
+++ b/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
@@ -604,7 +604,7 @@ void AutocompleteEditViewMac::OnStartingIME() {
// Reset the suggest text just before starting an IME composition session,
// otherwise the IME composition may be interrupted when the suggest text
// gets reset by the IME composition change.
- SetInstantSuggestion(string16());
+ SetInstantSuggestion(string16(), false);
}
bool AutocompleteEditViewMac::OnInlineAutocompleteTextMaybeChanged(
@@ -703,7 +703,8 @@ CommandUpdater* AutocompleteEditViewMac::GetCommandUpdater() {
}
void AutocompleteEditViewMac::SetInstantSuggestion(
- const string16& suggest_text) {
+ const string16& suggest_text,
+ bool animate_to_complete) {
NSString* text = GetNonSuggestTextSubstring();
bool needs_update = (suggest_text_length_ > 0);
@@ -769,7 +770,7 @@ bool AutocompleteEditViewMac::OnDoCommandBySelector(SEL cmd) {
// Reset the suggest text for any change other than key right or tab.
// TODO(rohitrao): This is here to prevent complications when editing text.
// See if this can be removed.
- SetInstantSuggestion(string16());
+ SetInstantSuggestion(string16(), false);
}
if (cmd == @selector(deleteForward:))

Powered by Google App Engine
This is Rietveld 408576698