Issue 6684025: Don't buffer output in-memory for rietveld server - it logs to stdout by

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6684025: Don't buffer output in-memory for rietveld server - it logs to stdout by (Closed)

Created:
9 years, 9 months ago by Dirk Pranke

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, M-A Ruel, Evan Martin

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools

Visibility:
Public.

Don't buffer output in-memory for rietveld server - it logs to stdout by default and can fill the pipe used by subprocess.Popen(), leading to hangs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78084

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	git_cl/test/local_rietveld.py	View		2 chunks	+11 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

oops

lgtm