Don't buffer output in-memory for rietveld server - it logs to stdout by

git_cl/test/local_rietveld.py

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Setups a local Rietveld instance to test against a live server for
 integration tests.
 
 It makes sure Google AppEngine SDK is found, download Rietveld and Django code
 if necessary and starts the server on a free inbound TCP port.
 """
@@ skipping 78 matching lines @@
                 ['svn', 'co', '-q',
                     'http://code.djangoproject.com/'
                         'svn/django/branches/releases/1.0.X/django@13637',
                     self.django_path]):
                 raise Failure('Failed to checkout django')
 
     def start_server(self, verbose=False):
         self.install_prerequisites()
         self.port = find_free_port()
         if verbose:
-            stdout = None
-            stderr = None
+            self.out = None
+            self.err = None
         else:
-            stdout = subprocess.PIPE
-            stderr = subprocess.PIPE
+            self.out = open(os.devnull, 'w')
+            self.err = open(os.devnull, 'w')
         output = []
         self.test_server = subprocess.Popen(
             [self.dev_app, self.rietveld, '--port=%d' % self.port,
             '--datastore_path=' + os.path.join(self.rietveld, 'tmp.db'), '-c'],
-            stdout=stdout, stderr=stderr, env=self.env)
+            stdout=self.out, stderr=self.err, env=self.env)
         # Loop until port 127.0.0.1:port opens or the process dies.
         while not test_port(self.port):
             self.test_server.poll()
             if self.test_server.returncode is not None:
                 raise Failure(
                     'Test rietveld instance failed early on port %s' %
                     self.port)
             time.sleep(0.001)
 
     def stop_server(self):
         if self.test_server:
             self.test_server.kill()
             self.test_server = None
             self.port = None
+        if self.out:
+            self.out.close()
+            self.out = None
+        if self.err:
+            self.err.close()
+            self.err = None
 
 
 def main():
     print LocalRietveld().start_server()
 
 
 if __name__ == '__main__':
     main()
 
 # vim: ts=4:sw=4:tw=80:et: