Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 668248: Small simplification of #include dependencies. (Closed)

Created:
10 years, 9 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Small simplification of #include dependencies. Remove messages.h from v8.h and include it explicitly in only the few places it is needed. Many files relied on getting handles-inl.h implicitly from messages.h through v8.h, so include handles-inl.h explicitly in v8.h instead. Remove zone-inl.h from header files where it is not needed, can be replaced by a forward declaration, or can be replaced by zone.h (specifically, factory.h and heap.h). Include zone.h or zone-inl.h in header files where it was implicitly included via heap.h or factory.h. Prefer zone.h over zone-inl.h in header files where possible by including zone-inl.h in .cc files. Committed: http://code.google.com/p/v8/source/detail?r=4058

Patch Set 1 #

Patch Set 2 : Removed zone.h from .cc files where unused. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M SConstruct View 1 chunk +2 lines, -2 lines 0 comments Download
M src/accessors.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/api.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/frame-element.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/frame-element.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/frames.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/heap-profiler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap-profiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/jsregexp.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/jump-target.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/messages.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/scopeinfo.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/top.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/v8.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
I had to add -fno-strict-aliasing in order to compile with gcc 4.4.1. I can commit ...
10 years, 9 months ago (2010-03-08 05:03:24 UTC) #1
Mads Ager (chromium)
10 years, 9 months ago (2010-03-08 07:52:03 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698