VMWare [1/2]: Fix vmware image generation.

VMWare [1/2]: Fix vmware image generation.

[SdLiYong, 2010-03-08 05:12:17]

I suggest we start udev in the chromeos_startup script and use the ROOT=LABEL as
the kernel command
Do not use the /dev/sda3 as the vmware boot device

http://codereview.chromium.org/668215/diff/1/2
File src/scripts/image_to_vmware.sh (right):

http://codereview.chromium.org/668215/diff/1/2#newcode64
src/scripts/image_to_vmware.sh:64: sudo "$TEMP_MNT"/postinst /dev/sda3
If we can use the root=LABEL as the kernel command line, it will support the
USB/VMWARE/VIRTUALBOX images

[adlr, 2010-03-08 06:20:21]

The issue is that we'd need an initrd to support root=LABEL= in the kernel
command line, and we don't have initrd support.

On Sun, Mar 7, 2010 at 9:12 PM, <SdLiYong@gmail.com> wrote:

> I suggest we start udev in the chromeos_startup script and use the
> ROOT=LABEL as
> the kernel command
> Do not use the /dev/sda3 as the vmware boot device
>
>
> http://codereview.chromium.org/668215/diff/1/2
> File src/scripts/image_to_vmware.sh (right):
>
> http://codereview.chromium.org/668215/diff/1/2#newcode64
> src/scripts/image_to_vmware.sh:64: sudo "$TEMP_MNT"/postinst /dev/sda3
> If we can use the root=LABEL as the kernel command line, it will support
> the USB/VMWARE/VIRTUALBOX images
>
>
> http://codereview.chromium.org/668215
>

[SdLiYong, 2010-03-08 11:19:17]

Thank you for your update

I noticed there is no initrd in the extlinux.conf. It is OK to change the root
device name using your patch

Another question, we need the same changes in the virtualbox image creation
script. Can you modify the image_to_virtualbox.sh and add the vesa video
card(Virtualbox uses VESA as the video card)?

I hope someone can approve the patch as soon as possible since we cannot test
the build image using virtual machine now 

On 2010/03/08 06:20:21, adlr wrote:
> The issue is that we'd need an initrd to support root=LABEL= in the kernel
> command line, and we don't have initrd support.
> 
> On Sun, Mar 7, 2010 at 9:12 PM, <mailto:SdLiYong@gmail.com> wrote:
> 
> > I suggest we start udev in the chromeos_startup script and use the
> > ROOT=LABEL as
> > the kernel command
> > Do not use the /dev/sda3 as the vmware boot device
> >
> >
> > http://codereview.chromium.org/668215/diff/1/2
> > File src/scripts/image_to_vmware.sh (right):
> >
> > http://codereview.chromium.org/668215/diff/1/2#newcode64
> > src/scripts/image_to_vmware.sh:64: sudo "$TEMP_MNT"/postinst /dev/sda3
> > If we can use the root=LABEL as the kernel command line, it will support
> > the USB/VMWARE/VIRTUALBOX images
> >
> >
> > http://codereview.chromium.org/668215
> >
>

[adlr, 2010-03-09 04:08:42]

remove duplicate code; virtual box support.

ready for another look.

[tedbo, 2010-03-10 21:45:27]

LGTM w/ a coupld of comments.

Thanks for working on this!

http://codereview.chromium.org/668215/diff/2001/3002
File src/scripts/image_to_vmware.sh (right):

http://codereview.chromium.org/668215/diff/2001/3002#newcode31
src/scripts/image_to_vmware.sh:31: DEFINE_string format vmware \
Probably better to put "vmware" in quotes here.

http://codereview.chromium.org/668215/diff/2001/3002#newcode72
src/scripts/image_to_vmware.sh:72: TEMP_IMG=temp.image
I think this will make the tmp files in the current directory. It may be better
to use "$(mktemp)" and "$(mktemp -d)"

http://codereview.chromium.org/668215/diff/2001/3002#newcode117
src/scripts/image_to_vmware.sh:117: displayName = \"ChromeOS\"
s/ChromeOS/Chromium OS/

[adlr, 2010-03-11 00:10:07]

fixed and submitted, thanks!

http://codereview.chromium.org/668215/diff/2001/3002
File src/scripts/image_to_vmware.sh (right):

http://codereview.chromium.org/668215/diff/2001/3002#newcode31
src/scripts/image_to_vmware.sh:31: DEFINE_string format vmware \
On 2010/03/10 21:45:27, tedbo wrote:
> Probably better to put "vmware" in quotes here.
> 

Done.

http://codereview.chromium.org/668215/diff/2001/3002#newcode72
src/scripts/image_to_vmware.sh:72: TEMP_IMG=temp.image
On 2010/03/10 21:45:27, tedbo wrote:
> I think this will make the tmp files in the current directory. It may be
better
> to use "$(mktemp)" and "$(mktemp -d)"
> 

Done.

http://codereview.chromium.org/668215/diff/2001/3002#newcode117
src/scripts/image_to_vmware.sh:117: displayName = \"ChromeOS\"
On 2010/03/10 21:45:27, tedbo wrote:
> s/ChromeOS/Chromium OS/

Done.