Build skia as a dll in windows multi-dll build.

Build skia as a dll in windows multi-dll build. 

BUG=75686
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78510

[bsalomon, 2011-03-16 12:41:38]

LGTM. But maybe Brett or someone who has a better understanding of the
skia/platform layer should have a look.

On 2011/03/15 22:17:33, Chris Guillory wrote:

[Chris Guillory, 2011-03-16 19:47:49]

Brett, can you take a peek? 

Ken, Mike mentioned that you might have some comments around skia's link
dependencies.

[brettw, 2011-03-16 20:47:59]

LGTM

[Ken Russell (switch to Gerrit), 2011-03-16 20:54:08]

It looks fine to me as long as it works. I think there might be problems with
linking the command buffer client code into two different DLLs (chrome.dll and
skia.dll). My recollection is that if the thread-local variables in those DLLs
are multiply defined in the overall executable then things break. This is why we
had to change the Chromium port of WebKit's compositor to use the command buffer
client code compiled into the renderer rather than compiling a separate copy
into the WebKit DLL in the Windows multi-DLL build.

[Chris Guillory, 2011-03-17 02:26:13]

On 2011/03/16 20:54:08, kbr wrote:
> It looks fine to me as long as it works. I think there might be problems with
> linking the command buffer client code into two different DLLs (chrome.dll and
> skia.dll). My recollection is that if the thread-local variables in those DLLs
> are multiply defined in the overall executable then things break. This is why
we
> had to change the Chromium port of WebKit's compositor to use the command
buffer
> client code compiled into the renderer rather than compiling a separate copy
> into the WebKit DLL in the Windows multi-DLL build.
The only reason we need to link command buffer client code into skia.dll is
because skia gpu depends on it. However, skia gpu is not a dependency of and
project needed to build chrome (perhaps it can be in another configuration?). If
I remove skia gpu code I can build chrome with skia.dll additionally depending
on just base.
http://codereview.chromium.org/6667071/

So command buffer client problems may occur if skia gpu is used in Chrome.