Issue 668170: Cleanup and add open to push test image to usb

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 668170: Cleanup and add open to push test image to usb (Closed)

Created:
10 years, 9 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
gauravsh

CC:
chromium-os-reviews_chromium.org, kmixter1

Visibility:
Public.

Description

Cleanup and add open to push test image to usb

Patch Set 1 #

Patch Set 2 : Missed a quote #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -45 lines)			Patch
	M	src/scripts/image_to_usb.sh	View	1	9 chunks	+62 lines, -45 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sosa

Cleanup of image_to_usb to make consistent use of {}'s around variables. Also, make it easy ...

10 years, 9 months ago (2010-03-05 18:45:36 UTC) #1

sosa

10 years, 9 months ago (2010-03-05 19:22:53 UTC) #3

Thanks for the quick review gaurav!

On Fri, Mar 5, 2010 at 11:11 AM,  <gauravsh@chromium.org> wrote:
> Very nice, lgtm.
>
> http://codereview.chromium.org/668170
>

Expand Messages | Collapse Messages