chrome/browser/resources/options/chromeos_internet_options.html - Issue 6679040: [cros] Add checkbox for toggling data roaming setting.

Unified Diff: chrome/browser/resources/options/chromeos_internet_options.html

Issue 6679040: [cros] Add checkbox for toggling data roaming setting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: js/css cleanup Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/user_cros_settings_provider.cc ('K') | « chrome/browser/chromeos/webui/internet_options_handler.cc ('k') | chrome/browser/resources/options/chromeos_internet_options.js » ('j') | chrome/browser/resources/options/chromeos_internet_options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/chromeos_internet_options.html

diff --git a/chrome/browser/resources/options/chromeos_internet_options.html b/chrome/browser/resources/options/chromeos_internet_options.html

index c42ecd736d75a4a55be65308fb1288de9c3abb2b..3863c41ec0aa28cc62dafdb297fba9e75efe523e 100644

--- a/chrome/browser/resources/options/chromeos_internet_options.html

+++ b/chrome/browser/resources/options/chromeos_internet_options.html

@@ -6,14 +6,37 @@

</div>

- <div id="networkingControls">

- <button id="enableWifi" class="hidden" i18n-content="enableWifi"></button>

- <button id="disableWifi" class="hidden"

- i18n-content="disableWifi"></button>

- <button id="enableCellular" class="hidden"

- i18n-content="enableCellular"></button>

- <button id="disableCellular" class="hidden"

- i18n-content="disableCellular"></button>

+ <div>

+ <div id="networkingControls" class="section-group">

+ <button id="enableWifi" class="hidden"

arv (Not doing code reviews) 2011/03/16 17:04:12 Use hidden attribute instead? IDs should use dash

Nikita (slow) 2011/03/17 10:45:57 Done. Did some cleanup.

+ i18n-content="enableWifi"></button>

+ <button id="disableWifi" class="hidden"

+ i18n-content="disableWifi"></button>

+ <button id="enableCellular" class="hidden"

+ i18n-content="enableCellular"></button>

+ <button id="disableCellular" class="hidden"

+ i18n-content="disableCellular"></button>

+ </div>

+ <div class="option">

+ <div id="internetOwnerOnlyWarning" class="hidden">

+ <span i18n-content="owner_only"></span>

arv (Not doing code reviews) 2011/03/16 17:04:12 i18n names should use camelCase

Nikita (slow) 2011/03/17 10:45:57 Done.

+ <span i18n-content="owner_user_id"></span>

+ </div>

+ <table class="option-control-table">

arv (Not doing code reviews) 2011/03/16 17:04:12 Why the table?

Nikita (slow) 2011/03/17 10:45:57 Done.

+ <tr>

+ <td class="option-name">

+ <div class="checkbox">

+ <label>

+ <input id="enableDataRoaming"

+ pref="cros.signed.data_roaming_enabled"

+ metric="Options_Internet_DataRoaming" type="checkbox">

+ <span i18n-content="enableDataRoaming"></span>

+ </label>

+ </div>

+ </td>

+ </tr>

+ </table>

+ </div>

</div>

</section>