chrome/browser/resources/options/chromeos_internet_options.html - Issue 6679040: [cros] Add checkbox for toggling data roaming setting.

Side by Side Diff: chrome/browser/resources/options/chromeos_internet_options.html

Issue 6679040: [cros] Add checkbox for toggling data roaming setting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: js/css cleanup Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/chromeos/user_cros_settings_provider.cc ('K') | « chrome/browser/chromeos/webui/internet_options_handler.cc ('k') | chrome/browser/resources/options/chromeos_internet_options.js » ('j') | chrome/browser/resources/options/chromeos_internet_options.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <div class="page hidden" id="internetPage">	1 <div class="page hidden" id="internetPage">

2 <h1 i18n-content="internetPage"></h1>	2 <h1 i18n-content="internetPage"></h1>

3 <div id="lockedNetworkBanner">	3 <div id="lockedNetworkBanner">

4 <span id="lockedNetworkIcon"></span>	4 <span id="lockedNetworkIcon"></span>

5 <span id="accessLockedText" i18n-content="accessLockedMsg"></span>	5 <span id="accessLockedText" i18n-content="accessLockedMsg"></span>

6 </div>	6 </div>

7 <section id="wirelessButtons">	7 <section id="wirelessButtons">

8 <h3 i18n-content="generalNetworkingTitle"></h3>	8 <h3 i18n-content="generalNetworkingTitle"></h3>

9 <div id="networkingControls">	9 <div>

10 <button id="enableWifi" class="hidden" i18n-content="enableWifi"></button>	10 <div id="networkingControls" class="section-group">

11 <button id="disableWifi" class="hidden"	11 <button id="enableWifi" class="hidden"
	arv (Not doing code reviews) 2011/03/16 17:04:12 Use hidden attribute instead? IDs should use dash Use hidden attribute instead? IDs should use dashes <button id="enable-wifi" hidden i18n-content"enableWifi"></button> Nikita (slow) 2011/03/17 10:45:57 Done. Did some cleanup. Show quoted text On 2011/03/16 17:04:12, arv wrote: > Use hidden attribute instead? > > IDs should use dashes > > <button id="enable-wifi" hidden i18n-content"enableWifi"></button> Done. Did some cleanup.
12 i18n-content="disableWifi"></button>	12 i18n-content="enableWifi"></button>

13 <button id="enableCellular" class="hidden"	13 <button id="disableWifi" class="hidden"

14 i18n-content="enableCellular"></button>	14 i18n-content="disableWifi"></button>

15 <button id="disableCellular" class="hidden"	15 <button id="enableCellular" class="hidden"

16 i18n-content="disableCellular"></button>	16 i18n-content="enableCellular"></button>

	17 <button id="disableCellular" class="hidden"

	18 i18n-content="disableCellular"></button>

	19 </div>

	20 <div class="option">

	21 <div id="internetOwnerOnlyWarning" class="hidden">

	22 <span i18n-content="owner_only"></span>
	arv (Not doing code reviews) 2011/03/16 17:04:12 i18n names should use camelCase i18n names should use camelCase Nikita (slow) 2011/03/17 10:45:57 Done. Show quoted text On 2011/03/16 17:04:12, arv wrote: > i18n names should use camelCase Done.
	23 <span i18n-content="owner_user_id"></span>

	24 </div>

	25 <table class="option-control-table">
	arv (Not doing code reviews) 2011/03/16 17:04:12 Why the table? Why the table? Nikita (slow) 2011/03/17 10:45:57 Done. Show quoted text On 2011/03/16 17:04:12, arv wrote: > Why the table? Done.
	26 <tr>

	27 <td class="option-name">

	28 <div class="checkbox">

	29 <label>

	30 <input id="enableDataRoaming"

	31 pref="cros.signed.data_roaming_enabled"

	32 metric="Options_Internet_DataRoaming" type="checkbox">

	33 <span i18n-content="enableDataRoaming"></span>

	34 </label>

	35 </div>

	36 </td>

	37 </tr>

	38 </table>

	39 </div>

17 </div>	40 </div>

18 </section>	41 </section>

19 <section id="wiredSection">	42 <section id="wiredSection">

20 <h3 i18n-content="wired_title"></h3>	43 <h3 i18n-content="wired_title"></h3>

21 <div class="networks" id="wiredList"></div>	44 <div class="networks" id="wiredList"></div>

22 </section>	45 </section>

23 <section id="wirelessSection">	46 <section id="wirelessSection">

24 <h3 i18n-content="wireless_title"></h3>	47 <h3 i18n-content="wireless_title"></h3>

25 <div class="networks" id="wirelessList"></div>	48 <div class="networks" id="wirelessList"></div>

26 </section>	49 </section>

27 <section id="rememberedSection">	50 <section id="rememberedSection">

28 <h3 i18n-content="remembered_title"></h3>	51 <h3 i18n-content="remembered_title"></h3>

29 <div class="networks" id="rememberedList"></div>	52 <div class="networks" id="rememberedList"></div>

30 </section>	53 </section>

31 </div>	54 </div>

OLD	NEW