Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 6679032: Fix prompting - had the logic backwards (Closed)

Created:
9 years, 9 months ago by Dirk Pranke
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Fix prompting - had the logic backwards. The git-cl unit tests actually test the prompting correctly (once they are modified to pass otherwise). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77985

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M git_cl/git_cl.py View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dirk Pranke
9 years, 9 months ago (2011-03-13 02:26:30 UTC) #1
M-A Ruel
9 years, 9 months ago (2011-03-13 02:49:34 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698