Fix prompting - had the logic backwards

git_cl/git_cl.py

 #!/usr/bin/python
 # git-cl -- a git-command for integrating reviews on Rietveld
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 import errno
 import logging
 import optparse
 import os
 import re
 import StringIO
@@ skipping 760 matching lines @@
 
   # Apply watchlists on upload.
   if not committing:
     watchlist = watchlists.Watchlists(change.RepositoryRoot())
     files = [f.LocalPath() for f in change.AffectedFiles()]
     watchers = watchlist.GetWatchersForPaths(files)
     RunCommand(['git', 'config', '--replace-all',
                'rietveld.extracc', ','.join(watchers)])
 
   output = StringIO.StringIO()
-  res = presubmit_support.DoPresubmitChecks(change, committing,
+  should_continue = presubmit_support.DoPresubmitChecks(change, committing,
       verbose=None, output_stream=output, input_stream=sys.stdin,
       default_presubmit=None, may_prompt=False, tbr=tbr,
       host_url=cl.GetRietveldServer())
   hook_results = HookResults(output.getvalue())
   if hook_results.output:
     print hook_results.output
 
   # TODO(dpranke): We should propagate the error out instead of calling exit().
-  if not res and ('** Presubmit ERRORS **' in hook_results.output or
-                  '** Presubmit WARNINGS **' in hook_results.output):
-    res = True
+  if should_continue and hook_results.output and (
+      '** Presubmit ERRORS **\n' in hook_results.output or
+      '** Presubmit WARNINGS **\n' in hook_results.output):
+    should_continue = False
 
-  if res:
+  if not should_continue:
     if may_prompt:
       response = raw_input('Are you sure you want to continue? (y/N): ')
       if not response.lower().startswith('y'):
         sys.exit(1)
     else:
       sys.exit(1)
 
 
   return hook_results
 
@@ skipping 607 matching lines @@
             ('AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
              'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
 
   # Not a known command. Default to help.
   GenUsage(parser, 'help')
   return CMDhelp(parser, argv)
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))