Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 6677069: Provisional fix for WebFrame API change upstream. (Closed)

Created:
9 years, 9 months ago by Daniel Sievers (Google)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Provisional fix for WebFrame API change upstream (webkit bug 56139). This is somewhat hackish.. the new version of the function upstream has a default initializer. I think it's better though to add it this way to remove ambiguity - for the overloading the default initializer should not matter. Either way, I expect to remove the obsolete definition within a day or so. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78794

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M webkit/mocks/mock_webframe.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webkit/mocks/mock_webframe.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
levin
As discussed, consider using an enum as a parameter.
9 years, 9 months ago (2011-03-18 22:40:38 UTC) #1
levin
LGTM
9 years, 9 months ago (2011-03-18 23:31:59 UTC) #2
commit-bot: I haz the power
Running presubmit hooks... ** Presubmit Messages ** If this change has an associated bug, add ...
9 years, 9 months ago (2011-03-18 23:32:15 UTC) #3
commit-bot: I haz the power
Running presubmit hooks... ** Presubmit Messages ** If this change has an associated bug, add ...
9 years, 9 months ago (2011-03-18 23:33:55 UTC) #4
commit-bot: I haz the power
9 years, 9 months ago (2011-03-19 01:28:58 UTC) #5
Change committed as 78794

Powered by Google App Engine
This is Rietveld 408576698