Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: content/browser/in_process_webkit/indexed_db_dispatcher_host.cc

Issue 6677034: Add IndexedDB browser test that causes a crash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove DISABLED marker on this new test Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/in_process_webkit/indexed_db_dispatcher_host.cc
diff --git a/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc b/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc
index b52f5f13eb9ba52fcf31cae546d95fc9a39b3527..693a148cb1fd40cbe7170a942cd741e5d5cb72ee 100644
--- a/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc
+++ b/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc
@@ -113,6 +113,8 @@ bool IndexedDBDispatcherHost::OnMessageReceived(const IPC::Message& message,
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::WEBKIT));
+ // TODO(dgrogan): The page cycler test can crash here because
+ // database_dispatcher_host_ becomes invalid.
jorlow 2011/03/15 02:30:04 Add a bug number.
dgrogan 2011/03/16 22:00:12 Will do. I'm suddenly having a hard time reproduc
bool handled =
database_dispatcher_host_->OnMessageReceived(message, message_was_ok) ||
index_dispatcher_host_->OnMessageReceived(message, message_was_ok) ||

Powered by Google App Engine
This is Rietveld 408576698