Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: content/browser/in_process_webkit/indexed_db_browsertest.cc

Issue 6677034: Add IndexedDB browser test that causes a crash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove DISABLED marker on this new test Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/in_process_webkit/indexed_db_browsertest.cc
diff --git a/content/browser/in_process_webkit/indexed_db_browsertest.cc b/content/browser/in_process_webkit/indexed_db_browsertest.cc
index 35f60b2abbe5869d627aaab53181dfc3ed037a26..5a5878a45a862d63dd5d62083e39692ca4cb6f41 100644
--- a/content/browser/in_process_webkit/indexed_db_browsertest.cc
+++ b/content/browser/in_process_webkit/indexed_db_browsertest.cc
@@ -9,6 +9,7 @@
#include "base/scoped_temp_dir.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/ui/browser.h"
+#include "chrome/common/chrome_switches.h"
#include "chrome/test/in_process_browser_test.h"
#include "chrome/test/testing_profile.h"
#include "chrome/test/thread_test_helper.h"
@@ -46,6 +47,9 @@ class IndexedDBBrowserTest : public InProcessBrowserTest {
FAIL() << "Failed: " << js_result;
}
}
+ virtual void SetUpCommandLine(CommandLine* command_line) {
+ command_line->AppendSwitchASCII(switches::kJavaScriptFlags, "--expose-gc");
jorlow 2011/03/15 02:30:04 Let's only do this on tests we have to. I've seen
dgrogan 2011/03/15 03:32:27 Sounds good. Is it easy to add this per test in t
jorlow 2011/03/15 03:35:37 I believe you just need another text fixture that
Paweł Hajdan Jr. 2011/03/15 19:49:11 Can we create a constant for --expose-gc?
jorlow 2011/03/15 20:25:46 The only reason to bother making a constant is if
dgrogan 2011/03/16 22:00:12 Done.
+ }
};
IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, CursorTest) {
@@ -80,6 +84,11 @@ IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, DISABLED_TransactionTest) {
SimpleTest(testUrl(FilePath(FILE_PATH_LITERAL("transaction_test.html"))));
}
+IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, DatabaseCallbacksTest) {
+ SimpleTest(
+ testUrl(FilePath(FILE_PATH_LITERAL("database_callbacks_first.html"))));
+}
+
// Flaky: http://crbug.com/70773
IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, DISABLED_DoesntHangTest) {
SimpleTest(testUrl(FilePath(

Powered by Google App Engine
This is Rietveld 408576698