Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: tests/presubmit_unittest.py

Issue 6676128: fix a few minor lint and test issues. Note that presubmit_canned_checks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « presubmit_support.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/presubmit_unittest.py
diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py
index c7ad8191d2a4cd923a6df20789ab10d083d7fdf9..1ecadb9c134b91e5176124e26c575881bdbeba5f 100755
--- a/tests/presubmit_unittest.py
+++ b/tests/presubmit_unittest.py
@@ -721,8 +721,8 @@ class InputApiUnittest(PresubmitTestsBase):
'basename', 'cPickle', 'cStringIO', 'canned_checks', 'change', 'environ',
'host_url', 'is_committing', 'json', 'marshal', 'os_path',
'owners_db', 'pickle', 'platform', 'python_executable', 're',
- 'subprocess', 'tbr', 'tempfile', 'traceback', 'unittest', 'urllib2',
- 'version',
+ 'subprocess', 'tbr', 'tempfile', 'time', 'traceback', 'unittest',
+ 'urllib2', 'version',
]
# If this test fails, you should add the relevant test.
self.compareMembers(presubmit.InputApi(self.fake_change, './.', False,
@@ -1247,6 +1247,7 @@ class CannedChecksUnittest(PresubmitTestsBase):
def testMembersChanged(self):
self.mox.ReplayAll()
members = [
+ 'CheckBuildbotPendingBuilds',
'CheckChangeHasBugField', 'CheckChangeHasDescription',
'CheckChangeHasNoStrayWhitespace',
'CheckChangeHasOnlyOneEol', 'CheckChangeHasNoCR',
@@ -1256,15 +1257,15 @@ class CannedChecksUnittest(PresubmitTestsBase):
'CheckChangeHasTestField',
'CheckChangeLintsClean',
'CheckChangeSvnEolStyle',
- 'CheckLicense',
- 'CheckSvnModifiedDirectories',
- 'CheckSvnForCommonMimeTypes', 'CheckSvnProperty',
'CheckDoNotSubmit',
'CheckDoNotSubmitInDescription', 'CheckDoNotSubmitInFiles',
- 'CheckLongLines', 'CheckTreeIsOpen', 'RunPythonUnitTests',
- 'RunPylint',
- 'CheckBuildbotPendingBuilds', 'CheckRietveldTryJobExecution',
+ 'CheckLongLines', 'CheckTreeIsOpen', 'PanProjectChecks',
+ 'CheckLicense',
'CheckOwners',
+ 'CheckRietveldTryJobExecution',
+ 'CheckSvnModifiedDirectories',
+ 'CheckSvnForCommonMimeTypes', 'CheckSvnProperty',
+ 'RunPythonUnitTests', 'RunPylint',
]
# If this test fails, you should add the relevant test.
self.compareMembers(presubmit_canned_checks, members)
« no previous file with comments | « presubmit_support.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698