fix a few minor lint and test issues. Note that presubmit_canned_checks

tests/presubmit_unittest.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for presubmit_support.py and presubmit_canned_checks.py."""
 
 # pylint is too confused.
 # pylint: disable=E1101,E1103,W0212,W0403
 
@@ skipping 703 matching lines @@
     members = [
       'AbsoluteLocalPaths', 'AffectedFiles', 'AffectedSourceFiles',
       'AffectedTextFiles',
       'DEFAULT_BLACK_LIST', 'DEFAULT_WHITE_LIST',
       'DepotToLocalPath', 'FilterSourceFile', 'LocalPaths',
       'LocalToDepotPath',
       'PresubmitLocalPath', 'ReadFile', 'RightHandSideLines', 'ServerPaths',
       'basename', 'cPickle', 'cStringIO', 'canned_checks', 'change', 'environ',
       'host_url', 'is_committing', 'json', 'marshal', 'os_path',
       'owners_db', 'pickle', 'platform', 'python_executable', 're',
-      'subprocess', 'tbr', 'tempfile', 'traceback', 'unittest', 'urllib2',
-      'version',
+      'subprocess', 'tbr', 'tempfile', 'time', 'traceback', 'unittest',
+      'urllib2', 'version',
     ]
     # If this test fails, you should add the relevant test.
     self.compareMembers(presubmit.InputApi(self.fake_change, './.', False,
                                            False, None),
                         members)
 
   def testDepotToLocalPath(self):
     presubmit.scm.SVN.CaptureInfo('svn://foo/smurf').AndReturn(
         {'Path': 'prout'})
     presubmit.scm.SVN.CaptureInfo('svn:/foo/notfound/burp').AndReturn({})
@@ skipping 504 matching lines @@
     input_api.change = change
     input_api.host_url = 'http://localhost'
     input_api.is_committing = committing
     input_api.tbr = False
     input_api.python_executable = 'pyyyyython'
     return input_api
 
   def testMembersChanged(self):
     self.mox.ReplayAll()
     members = [
+      'CheckBuildbotPendingBuilds',
       'CheckChangeHasBugField', 'CheckChangeHasDescription',
       'CheckChangeHasNoStrayWhitespace',
       'CheckChangeHasOnlyOneEol', 'CheckChangeHasNoCR',
       'CheckChangeHasNoCrAndHasOnlyOneEol', 'CheckChangeHasNoTabs',
       'CheckChangeTodoHasOwner',
       'CheckChangeHasQaField', 'CheckChangeHasTestedField',
       'CheckChangeHasTestField',
       'CheckChangeLintsClean',
       'CheckChangeSvnEolStyle',
+      'CheckDoNotSubmit',
+      'CheckDoNotSubmitInDescription', 'CheckDoNotSubmitInFiles',
+      'CheckLongLines', 'CheckTreeIsOpen', 'PanProjectChecks',
       'CheckLicense',
+      'CheckOwners',
+      'CheckRietveldTryJobExecution',
       'CheckSvnModifiedDirectories',
       'CheckSvnForCommonMimeTypes', 'CheckSvnProperty',
-      'CheckDoNotSubmit',
-      'CheckDoNotSubmitInDescription', 'CheckDoNotSubmitInFiles',
-      'CheckLongLines', 'CheckTreeIsOpen', 'RunPythonUnitTests',
-      'RunPylint',
-      'CheckBuildbotPendingBuilds', 'CheckRietveldTryJobExecution',
-      'CheckOwners',
+      'RunPythonUnitTests', 'RunPylint',
     ]
     # If this test fails, you should add the relevant test.
     self.compareMembers(presubmit_canned_checks, members)
 
   def DescriptionTest(self, check, description1, description2, error_type,
                       committing):
     change1 = presubmit.Change('foo1', description1, self.fake_root_dir, None,
                                0, 0)
     input_api1 = self.MockInputApi(change1, committing)
     change2 = presubmit.Change('foo2', description2, self.fake_root_dir, None,
@@ skipping 690 matching lines @@
 
   def testCannedCheckOwners_HTTPS_HostURL(self):
     self.OwnersTest(is_committing=True,
         approvers=set(['ben@example.com']),
         uncovered_files=set(), host_url='https://localhost')
 
 
 if __name__ == '__main__':
   import unittest
   unittest.main()