Issue 6676128: fix a few minor lint and test issues. Note that presubmit_canned_checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6676128: fix a few minor lint and test issues. Note that presubmit_canned_checks (Closed)

Created:
9 years, 9 months ago by Dirk Pranke

Modified:
9 years, 7 months ago

Reviewers:
bradn

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

fix a few minor lint and test issues. Note that presubmit_canned_checks should never import any modules directly but always access modules through input_api. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79337

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -11 lines)			Patch
M	presubmit_canned_checks.py	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	presubmit_support.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/presubmit_unittest.py	View	3 chunks	+9 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

LGTM

Sorry, didn't run the tests....