Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: chrome/browser/password_manager/password_store.cc

Issue 6676015: Coverity: Pass values by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win/Mac fix. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/password_manager/password_store.h ('k') | chrome/browser/ui/gtk/location_bar_view_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/password_store.cc
diff --git a/chrome/browser/password_manager/password_store.cc b/chrome/browser/password_manager/password_store.cc
index af0306c73b30f2f4ecd2cf0202f3c866930c23c3..712ef1cb96ebcf22b899104bcd207ccfaf657688 100644
--- a/chrome/browser/password_manager/password_store.cc
+++ b/chrome/browser/password_manager/password_store.cc
@@ -77,7 +77,7 @@ int PasswordStore::GetBlacklistLogins(PasswordStoreConsumer* consumer) {
}
void PasswordStore::NotifyConsumer(GetLoginsRequest* request,
- const vector<PasswordForm*> forms) {
+ const vector<PasswordForm*>& forms) {
scoped_ptr<GetLoginsRequest> request_ptr(request);
#if !defined(OS_MACOSX)
@@ -91,7 +91,7 @@ void PasswordStore::NotifyConsumer(GetLoginsRequest* request,
void PasswordStore::NotifyConsumerImpl(PasswordStoreConsumer* consumer,
int handle,
- const vector<PasswordForm*> forms) {
+ const vector<PasswordForm*>& forms) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
// Don't notify the consumer if the request was canceled.
if (pending_requests_.find(handle) == pending_requests_.end()) {
« no previous file with comments | « chrome/browser/password_manager/password_store.h ('k') | chrome/browser/ui/gtk/location_bar_view_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698