Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 6675053: Revert 79618 - Landing for Julien Tinnes, jln@google.com:... (Closed)

Created:
9 years, 8 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
Chris Evans
CC:
chromium-reviews, agl
Visibility:
Public.

Description

Revert 79618 - Landing for Julien Tinnes, jln@google.com: --- chroot to /proc instead of /tmp. This gets rid of a lot of unnecessary complexity and fixes a race condition. (Original idea from Markus) The chroot helper will chroot to /proc/self/fdinfo (or /proc/self/fd). This is pretty safe because access to this directory is protected by the ptrace() check in the kernel and the helper is privileged. Moreover, as soon as the helper _exit() and becomes a zombie, the directory will be empty. Zygote should wait() for us to make everything deterministric. We also export SBX_HELPER_PID so that Zygote can specifically wait for the helper. --- BUG=76542 R=markus,agl Review URL: http://codereview.chromium.org/6683056 TBR=cevans@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -51 lines) Patch
M sandbox/linux/suid/sandbox.c View 6 chunks +124 lines, -51 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
laforge
9 years, 8 months ago (2011-03-30 18:30:16 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698