Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 6683056: Landing for Julien Tinnes, jln@google.com: (Closed)

Created:
9 years, 9 months ago by Chris Evans
Modified:
9 years, 6 months ago
Reviewers:
Markus, agl
CC:
chromium-reviews, agl
Visibility:
Public.

Description

Landing for Julien Tinnes, jln@google.com: --- chroot to /proc instead of /tmp. This gets rid of a lot of unnecessary complexity and fixes a race condition. (Original idea from Markus) The chroot helper will chroot to /proc/self/fdinfo (or /proc/self/fd). This is pretty safe because access to this directory is protected by the ptrace() check in the kernel and the helper is privileged. Moreover, as soon as the helper _exit() and becomes a zombie, the directory will be empty. Zygote should wait() for us to make everything deterministric. We also export SBX_HELPER_PID so that Zygote can specifically wait for the helper. --- BUG=76542 R=markus,agl Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79618

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -124 lines) Patch
M sandbox/linux/suid/sandbox.c View 6 chunks +51 lines, -124 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698