Issue 6674049: Fix some of the spacing in the description.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6674049: Fix some of the spacing in the description. (Closed)

Created:
9 years, 9 months ago by Dirk Pranke

Modified:
9 years, 7 months ago

Reviewers:
chase, M-A Ruel

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Fix some of the spacing in the description. R=chase@chromium.org,maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78601

Patch Set 1 #

Total comments: 4

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	gcl.py	View		1 chunk	+7 lines, -2 lines	4 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm with optional nits http://codereview.chromium.org/6674049/diff/1/gcl.py File gcl.py (right): http://codereview.chromium.org/6674049/diff/1/gcl.py#newcode1106 gcl.py:1106: reviewers_re.match(l) for l in description.splitlines()): ...

9 years, 9 months ago (2011-03-17 13:13:08 UTC) #2

Dirk Pranke

9 years, 9 months ago (2011-03-17 18:44:38 UTC) #4

http://codereview.chromium.org/6674049/diff/1/gcl.py
File gcl.py (right):

http://codereview.chromium.org/6674049/diff/1/gcl.py#newcode1106
gcl.py:1106: reviewers_re.match(l) for l in description.splitlines()):
On 2011/03/17 13:13:08, Marc-Antoine Ruel wrote:
> optional style nit: I'd rather this to save a line but I don't really mind:
> 
> if not any(
>     re.match(REVIEWERS_REGEX, l) for l in description.splitlines()):

Done.

http://codereview.chromium.org/6674049/diff/1/gcl.py#newcode1109
gcl.py:1109: if not description.endswith('\n'):
On 2011/03/17 13:13:08, Marc-Antoine Ruel wrote:
> description = description.rstrip() + '\n'

Done.

Expand Messages | Collapse Messages