Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: gcl.py

Issue 6674049: Fix some of the spacing in the description. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
===================================================================
--- gcl.py (revision 78497)
+++ gcl.py (working copy)
@@ -1097,13 +1097,18 @@
unaffected_files = [x for x in other_files if not file_re.match(x[0])]
if not change_info.reviewers:
- suggested_reviewers = suggest_reviewers(change_info, affected_files)
+ files_for_review = affected_files[:]
+ files_for_review.extend(change_info.GetFiles())
+ suggested_reviewers = suggest_reviewers(change_info, files_for_review)
if suggested_reviewers:
reviewers_re = re.compile(REVIEWERS_REGEX)
if not any(
reviewers_re.match(l) for l in description.splitlines()):
M-A Ruel 2011/03/17 13:13:08 optional style nit: I'd rather this to save a line
Dirk Pranke 2011/03/17 18:44:38 Done.
- description += '\nR=' + ','.join(suggested_reviewers) + '\n'
+ description += '\n\nR=' + ','.join(suggested_reviewers)
+ if not description.endswith('\n'):
M-A Ruel 2011/03/17 13:13:08 description = description.rstrip() + '\n'
Dirk Pranke 2011/03/17 18:44:38 Done.
+ description += '\n'
+
separator1 = ("\n---All lines above this line become the description.\n"
"---Repository Root: " + change_info.GetLocalRoot() + "\n"
"---Paths in this changelist (" + change_info.name + "):\n")
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698