Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 6673104: Fix gcl to pass in the suggested owners properly. (Closed)

Created:
9 years, 9 months ago by Dirk Pranke
Modified:
9 years, 7 months ago
Reviewers:
chase, M-A Ruel
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Fix gcl to pass in the suggested owners properly in order to fix the bug introduced in r78329 (we were passing in a generator to the owners object and it needed to be a list). Fix a couple of other minor bugs related to suggesting reviewers while we're at it. R=chase@chromium.org,maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M gcl.py View 3 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
chase
lgtm
9 years, 9 months ago (2011-03-16 23:58:06 UTC) #1
M-A Ruel
lgtm, you forgot to send a review email?
9 years, 9 months ago (2011-03-17 01:38:55 UTC) #2
Dirk Pranke
Yeah, I do that a lot, unfortunately :( I'm used to webkit-patch, which defaults to ...
9 years, 9 months ago (2011-03-17 01:45:34 UTC) #3
M-A Ruel
9 years, 9 months ago (2011-03-17 02:11:47 UTC) #4
--send-mail -r foo@chromium.org

Le 16 mars 2011 21:45, Dirk Pranke <dpranke@chromium.org> a écrit :

> Yeah, I do that a lot, unfortunately :( I'm used to webkit-patch,
> which defaults to sending email on upload.
>
> -- Dirk
>
> On Wed, Mar 16, 2011 at 6:38 PM,  <maruel@chromium.org> wrote:
> > lgtm, you forgot to send a review email?
> >
> > http://codereview.chromium.org/6673104/
> >
>

Powered by Google App Engine
This is Rietveld 408576698