Index: gcl.py |
=================================================================== |
--- gcl.py (revision 78355) |
+++ gcl.py (working copy) |
@@ -323,7 +323,7 @@ |
subject = l |
matched_reviewers = reviewers_re.match(l) |
if matched_reviewers: |
- reviewers = matched_reviewers.group(1) |
+ reviewers = matched_reviewers.group(1).split(',') |
parsed_lines.append(l) |
if len(subject) > 100: |
@@ -766,7 +766,7 @@ |
def suggest_reviewers(change_info, affected_files): |
owners_db = owners.Database(change_info.GetLocalRoot(), fopen=file, |
os_path=os.path) |
- return owners_db.reviewers_for(affected_files) |
+ return owners_db.reviewers_for([f[1] for f in affected_files]) |
def defer_attributes(a, b): |
@@ -1096,12 +1096,13 @@ |
affected_files = [x for x in other_files if file_re.match(x[0])] |
unaffected_files = [x for x in other_files if not file_re.match(x[0])] |
- suggested_reviewers = suggest_reviewers(change_info, affected_files) |
- if suggested_reviewers: |
- reviewers_re = re.compile(REVIEWERS_REGEX) |
- if not any( |
- reviewers_re.match(l) for l in description.splitlines()): |
- description += '\nR=' + ','.join(suggested_reviewers) + '\n' |
+ if not change_info.reviewers: |
+ suggested_reviewers = suggest_reviewers(change_info, affected_files) |
+ if suggested_reviewers: |
+ reviewers_re = re.compile(REVIEWERS_REGEX) |
+ if not any( |
+ reviewers_re.match(l) for l in description.splitlines()): |
+ description += '\nR=' + ','.join(suggested_reviewers) + '\n' |
separator1 = ("\n---All lines above this line become the description.\n" |
"---Repository Root: " + change_info.GetLocalRoot() + "\n" |