Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1960)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6673082: Refactor lithium CheckSmi instruction into two separate instructions CheckSmi... (Closed)

Created:
9 years, 9 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Refactor lithium CheckSmi instruction into two separate instructions CheckSmi and CheckNonSmi. There is no need to store the branch condition separately in the LIR. Committed: http://code.google.com/p/v8/source/detail?r=7206

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -38 lines) Patch
M src/arm/lithium-arm.h View 2 chunks +10 lines, -8 lines 0 comments Download
M src/arm/lithium-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +10 lines, -8 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +10 lines, -8 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years, 9 months ago (2011-03-16 16:21:04 UTC) #1
Kevin Millikin (Chromium)
9 years, 9 months ago (2011-03-16 16:25:29 UTC) #2 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698