Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 6673082: Refactor lithium CheckSmi instruction into two separate instructions CheckSmi... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1665 matching lines...) Expand 10 before | Expand all | Expand 10 after
1676 return DefineAsRegister(new LInteger32ToDouble(Use(instr->value()))); 1676 return DefineAsRegister(new LInteger32ToDouble(Use(instr->value())));
1677 } 1677 }
1678 } 1678 }
1679 UNREACHABLE(); 1679 UNREACHABLE();
1680 return NULL; 1680 return NULL;
1681 } 1681 }
1682 1682
1683 1683
1684 LInstruction* LChunkBuilder::DoCheckNonSmi(HCheckNonSmi* instr) { 1684 LInstruction* LChunkBuilder::DoCheckNonSmi(HCheckNonSmi* instr) {
1685 LOperand* value = UseRegisterAtStart(instr->value()); 1685 LOperand* value = UseRegisterAtStart(instr->value());
1686 return AssignEnvironment(new LCheckSmi(value, zero)); 1686 return AssignEnvironment(new LCheckNonSmi(value));
1687 } 1687 }
1688 1688
1689 1689
1690 LInstruction* LChunkBuilder::DoCheckInstanceType(HCheckInstanceType* instr) { 1690 LInstruction* LChunkBuilder::DoCheckInstanceType(HCheckInstanceType* instr) {
1691 LOperand* value = UseRegisterAtStart(instr->value()); 1691 LOperand* value = UseRegisterAtStart(instr->value());
1692 LOperand* temp = TempRegister(); 1692 LOperand* temp = TempRegister();
1693 LCheckInstanceType* result = new LCheckInstanceType(value, temp); 1693 LCheckInstanceType* result = new LCheckInstanceType(value, temp);
1694 return AssignEnvironment(result); 1694 return AssignEnvironment(result);
1695 } 1695 }
1696 1696
1697 1697
1698 LInstruction* LChunkBuilder::DoCheckPrototypeMaps(HCheckPrototypeMaps* instr) { 1698 LInstruction* LChunkBuilder::DoCheckPrototypeMaps(HCheckPrototypeMaps* instr) {
1699 LOperand* temp = TempRegister(); 1699 LOperand* temp = TempRegister();
1700 LCheckPrototypeMaps* result = new LCheckPrototypeMaps(temp); 1700 LCheckPrototypeMaps* result = new LCheckPrototypeMaps(temp);
1701 return AssignEnvironment(result); 1701 return AssignEnvironment(result);
1702 } 1702 }
1703 1703
1704 1704
1705 LInstruction* LChunkBuilder::DoCheckSmi(HCheckSmi* instr) { 1705 LInstruction* LChunkBuilder::DoCheckSmi(HCheckSmi* instr) {
1706 LOperand* value = UseRegisterAtStart(instr->value()); 1706 LOperand* value = UseRegisterAtStart(instr->value());
1707 return AssignEnvironment(new LCheckSmi(value, not_zero)); 1707 return AssignEnvironment(new LCheckSmi(value));
1708 } 1708 }
1709 1709
1710 1710
1711 LInstruction* LChunkBuilder::DoCheckFunction(HCheckFunction* instr) { 1711 LInstruction* LChunkBuilder::DoCheckFunction(HCheckFunction* instr) {
1712 LOperand* value = UseRegisterAtStart(instr->value()); 1712 LOperand* value = UseRegisterAtStart(instr->value());
1713 return AssignEnvironment(new LCheckFunction(value)); 1713 return AssignEnvironment(new LCheckFunction(value));
1714 } 1714 }
1715 1715
1716 1716
1717 LInstruction* LChunkBuilder::DoCheckMap(HCheckMap* instr) { 1717 LInstruction* LChunkBuilder::DoCheckMap(HCheckMap* instr) {
(...skipping 381 matching lines...) Expand 10 before | Expand all | Expand 10 after
2099 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) { 2099 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) {
2100 HEnvironment* outer = current_block_->last_environment()->outer(); 2100 HEnvironment* outer = current_block_->last_environment()->outer();
2101 current_block_->UpdateEnvironment(outer); 2101 current_block_->UpdateEnvironment(outer);
2102 return NULL; 2102 return NULL;
2103 } 2103 }
2104 2104
2105 2105
2106 } } // namespace v8::internal 2106 } } // namespace v8::internal
2107 2107
2108 #endif // V8_TARGET_ARCH_IA32 2108 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698