Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: chrome/browser/autofill/personal_data_manager_unittest.cc

Issue 6673079: Reduce boxing and unboxing of AutofillFieldType (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/personal_data_manager_mac.mm ('k') | chrome/browser/autofill/phone_number.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/personal_data_manager_unittest.cc
diff --git a/chrome/browser/autofill/personal_data_manager_unittest.cc b/chrome/browser/autofill/personal_data_manager_unittest.cc
index 6ae07e405fbef8c134f79f9771dc4ef4b143de8d..29d1221001734b506f18bc36669cadc06c6dfd13 100644
--- a/chrome/browser/autofill/personal_data_manager_unittest.cc
+++ b/chrome/browser/autofill/personal_data_manager_unittest.cc
@@ -130,7 +130,7 @@ TEST_F(PersonalDataManagerTest, SetProfiles) {
// - Update profile0
// - Remove profile1
// - Add profile2
- profile0.SetInfo(AutofillType(NAME_FIRST), ASCIIToUTF16("John"));
+ profile0.SetInfo(NAME_FIRST, ASCIIToUTF16("John"));
update.clear();
update.push_back(profile0);
update.push_back(profile2);
@@ -198,7 +198,7 @@ TEST_F(PersonalDataManagerTest, SetCreditCards) {
// - Update creditcard0
// - Remove creditcard1
// - Add creditcard2
- creditcard0.SetInfo(AutofillType(CREDIT_CARD_NAME), ASCIIToUTF16("Joe"));
+ creditcard0.SetInfo(CREDIT_CARD_NAME, ASCIIToUTF16("Joe"));
update.clear();
update.push_back(creditcard0);
update.push_back(creditcard2);
@@ -499,7 +499,7 @@ TEST_F(PersonalDataManagerTest, Refresh) {
// open with a previous snapshot of the profiles, and something [e.g. sync]
// removed a profile from the browser. In this edge case, we will end up
// in a consistent state by dropping the write).
- profile2.SetInfo(AutofillType(NAME_FIRST), ASCIIToUTF16("Jo"));
+ profile2.SetInfo(NAME_FIRST, ASCIIToUTF16("Jo"));
update.clear();
update.push_back(profile0);
update.push_back(profile1);
@@ -701,17 +701,17 @@ TEST_F(PersonalDataManagerTest, ImportPhoneNumberSplitAcrossMultipleFields) {
TEST_F(PersonalDataManagerTest, SetUniqueCreditCardLabels) {
CreditCard credit_card0;
- credit_card0.SetInfo(AutofillType(CREDIT_CARD_NAME), ASCIIToUTF16("John"));
+ credit_card0.SetInfo(CREDIT_CARD_NAME, ASCIIToUTF16("John"));
CreditCard credit_card1;
- credit_card1.SetInfo(AutofillType(CREDIT_CARD_NAME), ASCIIToUTF16("Paul"));
+ credit_card1.SetInfo(CREDIT_CARD_NAME, ASCIIToUTF16("Paul"));
CreditCard credit_card2;
- credit_card2.SetInfo(AutofillType(CREDIT_CARD_NAME), ASCIIToUTF16("Ringo"));
+ credit_card2.SetInfo(CREDIT_CARD_NAME, ASCIIToUTF16("Ringo"));
CreditCard credit_card3;
- credit_card3.SetInfo(AutofillType(CREDIT_CARD_NAME), ASCIIToUTF16("Other"));
+ credit_card3.SetInfo(CREDIT_CARD_NAME, ASCIIToUTF16("Other"));
CreditCard credit_card4;
- credit_card4.SetInfo(AutofillType(CREDIT_CARD_NAME), ASCIIToUTF16("Ozzy"));
+ credit_card4.SetInfo(CREDIT_CARD_NAME, ASCIIToUTF16("Ozzy"));
CreditCard credit_card5;
- credit_card5.SetInfo(AutofillType(CREDIT_CARD_NAME), ASCIIToUTF16("Dio"));
+ credit_card5.SetInfo(CREDIT_CARD_NAME, ASCIIToUTF16("Dio"));
// This will verify that the web database has been loaded and the notification
// sent out.
« no previous file with comments | « chrome/browser/autofill/personal_data_manager_mac.mm ('k') | chrome/browser/autofill/phone_number.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698