Reduce boxing and unboxing of AutofillFieldType

chrome/browser/autofill/personal_data_manager_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/message_loop.h"
 #include "base/ref_counted.h"
 #include "base/scoped_ptr.h"
@@ skipping 112 matching lines @@
 
   const std::vector<AutofillProfile*>& results1 = personal_data_->profiles();
   ASSERT_EQ(2U, results1.size());
   EXPECT_EQ(0, profile0.Compare(*results1.at(0)));
   EXPECT_EQ(0, profile1.Compare(*results1.at(1)));
 
   // Three operations in one:
   //  - Update profile0
   //  - Remove profile1
   //  - Add profile2
-  profile0.SetInfo(AutofillType(NAME_FIRST), ASCIIToUTF16("John"));
+  profile0.SetInfo(NAME_FIRST, ASCIIToUTF16("John"));
   update.clear();
   update.push_back(profile0);
   update.push_back(profile2);
   personal_data_->SetProfiles(&update);
 
   const std::vector<AutofillProfile*>& results2 = personal_data_->profiles();
   ASSERT_EQ(2U, results2.size());
   EXPECT_EQ(0, profile0.Compare(*results2.at(0)));
   EXPECT_EQ(0, profile2.Compare(*results2.at(1)));
 
@@ skipping 47 matching lines @@
 
   const std::vector<CreditCard*>& results1 = personal_data_->credit_cards();
   ASSERT_EQ(2U, results1.size());
   EXPECT_EQ(0, creditcard0.Compare(*results1.at(0)));
   EXPECT_EQ(0, creditcard1.Compare(*results1.at(1)));
 
   // Three operations in one:
   //  - Update creditcard0
   //  - Remove creditcard1
   //  - Add creditcard2
-  creditcard0.SetInfo(AutofillType(CREDIT_CARD_NAME), ASCIIToUTF16("Joe"));
+  creditcard0.SetInfo(CREDIT_CARD_NAME, ASCIIToUTF16("Joe"));
   update.clear();
   update.push_back(creditcard0);
   update.push_back(creditcard2);
   personal_data_->SetCreditCards(&update);
 
   const std::vector<CreditCard*>& results2 = personal_data_->credit_cards();
   ASSERT_EQ(2U, results2.size());
   EXPECT_EQ(creditcard0, *results2.at(0));
   EXPECT_EQ(creditcard2, *results2.at(1));
 
@@ skipping 280 matching lines @@
   EXPECT_EQ(profile2, *results2.at(2));
 
   wds->RemoveAutofillProfile(profile1.guid());
   wds->RemoveAutofillProfile(profile2.guid());
 
   // Before telling the PDM to refresh, simulate an edit to one of the profiles
   // via a SetProfile update (this would happen if the AutoFill window was
   // open with a previous snapshot of the profiles, and something [e.g. sync]
   // removed a profile from the browser.  In this edge case, we will end up
   // in a consistent state by dropping the write).
-  profile2.SetInfo(AutofillType(NAME_FIRST), ASCIIToUTF16("Jo"));
+  profile2.SetInfo(NAME_FIRST, ASCIIToUTF16("Jo"));
   update.clear();
   update.push_back(profile0);
   update.push_back(profile1);
   update.push_back(profile2);
   personal_data_->SetProfiles(&update);
 
   // Wait for the refresh.
   EXPECT_CALL(personal_data_observer_,
       OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
 
@@ skipping 181 matching lines @@
   autofill_test::SetProfileInfo(&expected, "George", NULL,
       "Washington", NULL, NULL, "21 Laussat St", NULL,
       "San Francisco", "California", "94102", NULL, "6505550000", NULL);
   const std::vector<AutofillProfile*>& results = personal_data_->profiles();
   ASSERT_EQ(1U, results.size());
   EXPECT_EQ(0, expected.Compare(*results[0]));
 }
 
 TEST_F(PersonalDataManagerTest, SetUniqueCreditCardLabels) {
   CreditCard credit_card0;
-  credit_card0.SetInfo(AutofillType(CREDIT_CARD_NAME), ASCIIToUTF16("John"));
+  credit_card0.SetInfo(CREDIT_CARD_NAME, ASCIIToUTF16("John"));
   CreditCard credit_card1;
-  credit_card1.SetInfo(AutofillType(CREDIT_CARD_NAME), ASCIIToUTF16("Paul"));
+  credit_card1.SetInfo(CREDIT_CARD_NAME, ASCIIToUTF16("Paul"));
   CreditCard credit_card2;
-  credit_card2.SetInfo(AutofillType(CREDIT_CARD_NAME), ASCIIToUTF16("Ringo"));
+  credit_card2.SetInfo(CREDIT_CARD_NAME, ASCIIToUTF16("Ringo"));
   CreditCard credit_card3;
-  credit_card3.SetInfo(AutofillType(CREDIT_CARD_NAME), ASCIIToUTF16("Other"));
+  credit_card3.SetInfo(CREDIT_CARD_NAME, ASCIIToUTF16("Other"));
   CreditCard credit_card4;
-  credit_card4.SetInfo(AutofillType(CREDIT_CARD_NAME), ASCIIToUTF16("Ozzy"));
+  credit_card4.SetInfo(CREDIT_CARD_NAME, ASCIIToUTF16("Ozzy"));
   CreditCard credit_card5;
-  credit_card5.SetInfo(AutofillType(CREDIT_CARD_NAME), ASCIIToUTF16("Dio"));
+  credit_card5.SetInfo(CREDIT_CARD_NAME, ASCIIToUTF16("Dio"));
 
   // This will verify that the web database has been loaded and the notification
   // sent out.
   EXPECT_CALL(personal_data_observer_,
               OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
 
   // The message loop will exit when the mock observer is notified.
   MessageLoop::current()->Run();
 
   // Add the test credit cards to the database.
@@ skipping 915 matching lines @@
 
   // Expect that the newer information is saved.  In this case the year is
   // added to the existing credit card.
   CreditCard expected2;
   autofill_test::SetCreditCardInfo(&expected2,
       "Biggie Smalls", "4111111111111111", "01", "2011");
   const std::vector<CreditCard*>& results2 = personal_data_->credit_cards();
   ASSERT_EQ(1U, results2.size());
   EXPECT_EQ(0, expected2.Compare(*results2[0]));
 }