chrome/browser/sync/glue/autofill_profile_change_processor.cc - Issue 6673079: Reduce boxing and unboxing of AutofillFieldType

Unified Diff: chrome/browser/sync/glue/autofill_profile_change_processor.cc

Issue 6673079: Reduce boxing and unboxing of AutofillFieldType (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Compile on Windows. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/personal_data_manager_mac.mm ('K') | « chrome/browser/sync/glue/autofill_model_associator.cc ('k') | chrome/browser/sync/glue/autofill_profile_model_associator.cc » ('j') | chrome/browser/sync/glue/autofill_profile_model_associator_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/autofill_profile_change_processor.cc

diff --git a/chrome/browser/sync/glue/autofill_profile_change_processor.cc b/chrome/browser/sync/glue/autofill_profile_change_processor.cc

index 76b414b5bb61be7172bf0bc69ed8b1d49e4783fc..a9e675dcfa1a94fefb105a8ccb467c8885b83ee8 100644

--- a/chrome/browser/sync/glue/autofill_profile_change_processor.cc

+++ b/chrome/browser/sync/glue/autofill_profile_change_processor.cc

@@ -327,31 +327,31 @@ void AutofillProfileChangeProcessor::WriteAutofillProfile(

specifics.set_guid(profile.guid());

specifics.set_name_first(UTF16ToUTF8(

dhollowa 2011/03/16 17:07:11 nit: A number of these should fit on single line n

Ilya Sherman 2011/03/17 03:42:29 Done.

- profile.GetFieldText(AutofillType(NAME_FIRST))));

+ profile.GetFieldText(NAME_FIRST)));

specifics.set_name_middle(UTF16ToUTF8(

- profile.GetFieldText(AutofillType(NAME_MIDDLE))));

+ profile.GetFieldText(NAME_MIDDLE)));

specifics.set_name_last(

- UTF16ToUTF8(profile.GetFieldText(AutofillType(NAME_LAST))));

+ UTF16ToUTF8(profile.GetFieldText(NAME_LAST)));

specifics.set_address_home_line1(

- UTF16ToUTF8(profile.GetFieldText(AutofillType(ADDRESS_HOME_LINE1))));

+ UTF16ToUTF8(profile.GetFieldText(ADDRESS_HOME_LINE1)));

specifics.set_address_home_line2(

- UTF16ToUTF8(profile.GetFieldText(AutofillType(ADDRESS_HOME_LINE2))));

+ UTF16ToUTF8(profile.GetFieldText(ADDRESS_HOME_LINE2)));

specifics.set_address_home_city(UTF16ToUTF8(profile.GetFieldText(

- AutofillType(ADDRESS_HOME_CITY))));

+ ADDRESS_HOME_CITY)));

specifics.set_address_home_state(UTF16ToUTF8(profile.GetFieldText(

- AutofillType(ADDRESS_HOME_STATE))));

+ ADDRESS_HOME_STATE)));

specifics.set_address_home_country(UTF16ToUTF8(profile.GetFieldText(

- AutofillType(ADDRESS_HOME_COUNTRY))));

+ ADDRESS_HOME_COUNTRY)));

specifics.set_address_home_zip(UTF16ToUTF8(profile.GetFieldText(

- AutofillType(ADDRESS_HOME_ZIP))));

+ ADDRESS_HOME_ZIP)));

specifics.set_email_address(UTF16ToUTF8(profile.GetFieldText(

- AutofillType(EMAIL_ADDRESS))));

+ EMAIL_ADDRESS)));

specifics.set_company_name(UTF16ToUTF8(profile.GetFieldText(

- AutofillType(COMPANY_NAME))));

+ COMPANY_NAME)));

specifics.set_phone_fax_whole_number(UTF16ToUTF8(profile.GetFieldText(

- AutofillType(PHONE_FAX_WHOLE_NUMBER))));

+ PHONE_FAX_WHOLE_NUMBER)));

specifics.set_phone_home_whole_number(UTF16ToUTF8(profile.GetFieldText(

- AutofillType(PHONE_HOME_WHOLE_NUMBER))));

+ PHONE_HOME_WHOLE_NUMBER)));

node->SetAutofillProfileSpecifics(specifics);

}