Reduce boxing and unboxing of AutofillFieldType

chrome/browser/sync/glue/autofill_profile_change_processor.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/glue/autofill_profile_change_processor.h"
 
 #include <string>
 #include <vector>
 
 #include "base/string_util.h"
@@ skipping 308 matching lines @@
     sync_api::WriteNode* node) {
   sync_pb::AutofillProfileSpecifics specifics;
 
   // This would get compiled out in official builds. The caller is expected to
   // pass in a valid profile object with valid guid.(i.e., the caller might
   // have to a DCHECK and log before calling. Having to check in 2 places is
   // not optimal.)
   DCHECK(guid::IsValidGUID(profile.guid()));
 
   specifics.set_guid(profile.guid());
   specifics.set_name_first(UTF16ToUTF8(

[dhollowa, 2011/03/16 17:07:11]

nit: A number of these should fit on single line now.

[Ilya Sherman, 2011/03/17 03:42:29]

Done.

-      profile.GetFieldText(AutofillType(NAME_FIRST))));
+      profile.GetFieldText(NAME_FIRST)));
   specifics.set_name_middle(UTF16ToUTF8(
-      profile.GetFieldText(AutofillType(NAME_MIDDLE))));
+      profile.GetFieldText(NAME_MIDDLE)));
   specifics.set_name_last(
-      UTF16ToUTF8(profile.GetFieldText(AutofillType(NAME_LAST))));
+      UTF16ToUTF8(profile.GetFieldText(NAME_LAST)));
   specifics.set_address_home_line1(
-      UTF16ToUTF8(profile.GetFieldText(AutofillType(ADDRESS_HOME_LINE1))));
+      UTF16ToUTF8(profile.GetFieldText(ADDRESS_HOME_LINE1)));
   specifics.set_address_home_line2(
-      UTF16ToUTF8(profile.GetFieldText(AutofillType(ADDRESS_HOME_LINE2))));
+      UTF16ToUTF8(profile.GetFieldText(ADDRESS_HOME_LINE2)));
   specifics.set_address_home_city(UTF16ToUTF8(profile.GetFieldText(
-      AutofillType(ADDRESS_HOME_CITY))));
+      ADDRESS_HOME_CITY)));
   specifics.set_address_home_state(UTF16ToUTF8(profile.GetFieldText(
-      AutofillType(ADDRESS_HOME_STATE))));
+      ADDRESS_HOME_STATE)));
   specifics.set_address_home_country(UTF16ToUTF8(profile.GetFieldText(
-      AutofillType(ADDRESS_HOME_COUNTRY))));
+      ADDRESS_HOME_COUNTRY)));
   specifics.set_address_home_zip(UTF16ToUTF8(profile.GetFieldText(
-      AutofillType(ADDRESS_HOME_ZIP))));
+      ADDRESS_HOME_ZIP)));
   specifics.set_email_address(UTF16ToUTF8(profile.GetFieldText(
-      AutofillType(EMAIL_ADDRESS))));
+      EMAIL_ADDRESS)));
   specifics.set_company_name(UTF16ToUTF8(profile.GetFieldText(
-      AutofillType(COMPANY_NAME))));
+      COMPANY_NAME)));
   specifics.set_phone_fax_whole_number(UTF16ToUTF8(profile.GetFieldText(
-      AutofillType(PHONE_FAX_WHOLE_NUMBER))));
+      PHONE_FAX_WHOLE_NUMBER)));
   specifics.set_phone_home_whole_number(UTF16ToUTF8(profile.GetFieldText(
-      AutofillType(PHONE_HOME_WHOLE_NUMBER))));
+      PHONE_HOME_WHOLE_NUMBER)));
   node->SetAutofillProfileSpecifics(specifics);
 }
 
 }  // namespace browser_sync