Move Start/EndPage() from NewPage/PageDone() to inside the metafile.

Move Start/EndPage() from NewPage/PageDone()
to inside the metafile.

BUG=NONE
TEST=NONE

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78399

[dpapad, 2011-03-15 16:07:36]

Changed RenderPrintedPage return type to bool. Removed StartPage/EndPage
(windows calls) from NewPage/PageDone. Added StartPage/EndPage within
RenderPrintedPage. As of now, RenderPrintedPage can only fail in Windows so it
always returns true for the other platforms.

[vandebo (ex-Chrome), 2011-03-15 17:23:05]

http://codereview.chromium.org/6673035/diff/1/printing/printed_document_win.cc
File printing/printed_document_win.cc (right):

http://codereview.chromium.org/6673035/diff/1/printing/printed_document_win.c...
printing/printed_document_win.cc:100: if (StartPage(context) <= 0)
We wanted to move this to PrintWebViewHelper::RenderPage

http://codereview.chromium.org/6673035/diff/1/printing/printing_context_win.cc
File printing/printing_context_win.cc (left):

http://codereview.chromium.org/6673035/diff/1/printing/printing_context_win.c...
printing/printing_context_win.cc:305: // Inform the driver that the application
is about to begin sending data.
Add a comment similar to the one in the Linux version of this method.

[dpapad, 2011-03-15 20:32:31]

http://codereview.chromium.org/6673035/diff/1/printing/printed_document_win.cc
File printing/printed_document_win.cc (right):

http://codereview.chromium.org/6673035/diff/1/printing/printed_document_win.c...
printing/printed_document_win.cc:100: if (StartPage(context) <= 0)
On 2011/03/15 17:23:06, vandebo wrote:
> We wanted to move this to PrintWebViewHelper::RenderPage

Done.

http://codereview.chromium.org/6673035/diff/1/printing/printing_context_win.cc
File printing/printing_context_win.cc (left):

http://codereview.chromium.org/6673035/diff/1/printing/printing_context_win.c...
printing/printing_context_win.cc:305: // Inform the driver that the application
is about to begin sending data.
On 2011/03/15 17:23:06, vandebo wrote:
> Add a comment similar to the one in the Linux version of this method.

Done.

[vandebo (ex-Chrome), 2011-03-15 20:41:39]

A better CL description might be: Move Start/EndPage() from NewPage/PageDone()
to inside the metafile.

http://codereview.chromium.org/6673035/diff/4001/chrome/renderer/print_web_vi...
File chrome/renderer/print_web_view_helper_win.cc (right):

http://codereview.chromium.org/6673035/diff/4001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper_win.cc:211:
DCHECK((*metafile)->StartPage());
Better to do bool foo = action; DCHECK(foo);

http://codereview.chromium.org/6673035/diff/4001/printing/printing_context_wi...
File printing/printing_context_win.cc (right):

http://codereview.chromium.org/6673035/diff/4001/printing/printing_context_wi...
printing/printing_context_win.cc:304: // Intentional No-op.
Hmm, maybe we should note that NativeMetafile::SafePlayback takes care of
calling ::StartPage()

[dpapad, 2011-03-15 20:56:44]

http://codereview.chromium.org/6673035/diff/4001/chrome/renderer/print_web_vi...
File chrome/renderer/print_web_view_helper_win.cc (right):

http://codereview.chromium.org/6673035/diff/4001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper_win.cc:211:
DCHECK((*metafile)->StartPage());
On 2011/03/15 20:41:39, vandebo wrote:
> Better to do bool foo = action; DCHECK(foo);

Done.

http://codereview.chromium.org/6673035/diff/4001/printing/printing_context_wi...
File printing/printing_context_win.cc (right):

http://codereview.chromium.org/6673035/diff/4001/printing/printing_context_wi...
printing/printing_context_win.cc:304: // Intentional No-op.
On 2011/03/15 20:41:39, vandebo wrote:
> Hmm, maybe we should note that NativeMetafile::SafePlayback takes care of
> calling ::StartPage()

Done.

[vandebo (ex-Chrome), 2011-03-15 22:50:29]

LGTM if your try jobs are green.