Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: printing/printing_context_win.cc

Issue 6673035: Move Start/EndPage() from NewPage/PageDone() to inside the metafile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Windows fix after rebasing Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/print_web_view_helper_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/printing_context_win.cc
diff --git a/printing/printing_context_win.cc b/printing/printing_context_win.cc
index 467bf3c7ad52b3c00d4349d98839e82cca5ac298..32a44be1d14fad9c7fae77323d8c234ca37e4932 100644
--- a/printing/printing_context_win.cc
+++ b/printing/printing_context_win.cc
@@ -298,13 +298,11 @@ PrintingContext::Result PrintingContextWin::NewDocument(
PrintingContext::Result PrintingContextWin::NewPage() {
if (abort_printing_)
return CANCEL;
-
DCHECK(context_);
DCHECK(in_print_job_);
- // Inform the driver that the application is about to begin sending data.
- if (StartPage(context_) <= 0)
- return OnError();
+ // Intentional No-op. NativeMetafile::SafePlayback takes care of calling
+ // ::StartPage().
return OK;
}
@@ -314,8 +312,9 @@ PrintingContext::Result PrintingContextWin::PageDone() {
return CANCEL;
DCHECK(in_print_job_);
- if (EndPage(context_) <= 0)
- return OnError();
+ // Intentional No-op. NativeMetafile::SafePlayback takes care of calling
+ // ::EndPage().
+
return OK;
}
« no previous file with comments | « chrome/renderer/print_web_view_helper_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698