Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 667002: Update unixbench for new chromeos build. (Closed)

Created:
10 years, 9 months ago by ericli
Modified:
9 years, 7 months ago
Reviewers:
kdlucas, truty1
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

At the beginning of UnixBench Run script, it used the following logic to decide what flavor of unix it is running. if [ -z "${FLAVOR-}" ]; then # determine flavor of UNIX from number of lines generated by "time" Fcount=`/usr/bin/time date 2>&1 | wc -l | sed 's/ //g'` case "$Fcount" in 2) FLAVOR=BSD ;; 3) FLAVOR=Linux ;; 5) FLAVOR=SysV ;; *) echo "Flavor of UNIX is not known." echo "Please define FLAVOR in Run script" exit;; esac fi export FLAVOR Unfortunately the new chromeos does not have /usr/bin/time installed and it will fail since it could no longer figure out the flavor itself. This CL intend to teach UnixBench which unix flavor it is.

Patch Set 1 #

Patch Set 2 : patch 1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M client/tests/unixbench/unixbench.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ericli
10 years, 9 months ago (2010-03-03 21:06:41 UTC) #1
kdlucas
LGTM
10 years, 9 months ago (2010-03-03 21:55:58 UTC) #2
ericli
10 years, 9 months ago (2010-03-03 22:01:20 UTC) #3
Submitting.

Note I am not planning to upstream this change.

On Wed, Mar 3, 2010 at 1:55 PM, <kdlucas@chromium.org> wrote:

> LGTM
>
>
> http://codereview.chromium.org/667002
>



-- 
Eric Li
李咏竹
Google Kirkland

Powered by Google App Engine
This is Rietveld 408576698